Re: [dpdk-dev] [PATCH 0/2] net/bnxt: supress warnings

2019-03-15 Thread Ferruh Yigit
On 3/14/2019 9:32 PM, Stephen Hemminger wrote: > Silence messages that are not errors. > > Stephen Hemminger (2): > net/bnxt: silence iova warnings > net/bnxt: suppress supprious error log Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix RSS query

2019-03-15 Thread Ferruh Yigit
On 3/12/2019 10:19 AM, Alejandro Lucero wrote: > Current code is not properly giving the RSS information > regarding the redirection table. > > Fixes: 934e4c60fbff ("nfp: add RSS") > Cc: sta...@dpdk.org > > Signed-off-by: Alejandro Lucero Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: silence iova warnings

2019-03-15 Thread Ajit Khaparde
On Fri, Mar 15, 2019 at 6:03 AM Rami Rosen wrote: > > Stephen Hemminger ‏: > >> When using bnxt on bare-metal with vfio-pci, the driver logs an >> unnecessary warning. Hardware works fine, message is not urgent. >> Change it to INFO level. >> >> Fixes: 62196f4e0941 ("mem: rename address mapping

Re: [dpdk-dev] [PATCH v2] app/testpmd: optimized MAC swap by using neon intrinsics

2019-03-15 Thread Ferruh Yigit
On 3/12/2019 1:05 PM, Honnappa Nagarahalli wrote: >> Improved MAC swap performance for ARM platform. >> The improvement was achieved by using neon intrinsics to save CPU cycles >> and doing swap for four packets at a time. >> The optimization had 15% - 20% throughput boost in testpmd MAC swap >> mo

Re: [dpdk-dev] [PATCH 0/3] bnxt: logging cleanups

2019-03-15 Thread Ferruh Yigit
On 3/11/2019 6:19 PM, Ajit Khaparde wrote: > On Mon, Mar 11, 2019 at 11:11 AM Stephen Hemminger < > step...@networkplumber.org> wrote: > >> This reduces the logging in this driver and makes it >> work like others. >> >> Stephen Hemminger (3): >> net/bnxt: change PTP message to DEBUG level >> n

[dpdk-dev] [PATCH v3 3/4] build: use version number from config file

2019-03-15 Thread Bruce Richardson
Since we have the version number in a separate file at the root level, we should not need to duplicate this in rte_version.h too. Best approach here is to move the macros for specifying the year/month/etc. parts from the version header file to the build config file - leaving the other utility macro

[dpdk-dev] [PATCH v3 4/4] eal: remove unneeded version logic

2019-03-15 Thread Bruce Richardson
The version number in the DPDK_VERSION file will never have an offset that needs to be subtracted, so remove that logic from the version string generation. Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- V2,V3: No changes, added Luca's ack lib/librte_eal/common/include/rte_version.

[dpdk-dev] [PATCH v3 1/4] build: add single source of DPDK version number

2019-03-15 Thread Bruce Richardson
Add a new file VERSION to hold the current DPDK version number. Have meson use this file for it's project version, and have make use it for reporting out "showversion" and "showversionum". Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- v3: rename file from DPDK_VERSION to VERSION v

[dpdk-dev] [PATCH v3 0/4] One versionfile to rule them all...

2019-03-15 Thread Bruce Richardson
Right now with DPDK we have two sources of version information - the rte_version.h header file containing macros for C use, and the project version number in the project definition in meson.build. This is not optimal, so this patchset aims to provide a single source for the DPDK version. The option

[dpdk-dev] [PATCH v3 2/4] build: move meson version handling to config directory

2019-03-15 Thread Bruce Richardson
To keep the top-level meson.build file as clean and clear as possible, we move the version handling to the config/meson.build file, where the rest of the build configuration is already being set up. Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- V3: Reordered patch in set V2: No cha

Re: [dpdk-dev] [PATCH v2] net/qede: support IOVA VA mode

2019-03-15 Thread Ferruh Yigit
On 3/8/2019 9:28 AM, Kevin Traynor wrote: > Set RTE_PCI_DRV_IOVA_AS_VA in drv_flags. This allows initializing qede > PMD as non-root also on Linux v4.x, where /proc/self/pagemap can't be > acccessed without CAP_SYS_ADMIN privileges. > > The flag was introduced generically but not in pmds in commit

Re: [dpdk-dev] [PATCH v2] net/kni: calc mbuf&mtu according to given mb_pool

2019-03-15 Thread Ferruh Yigit
On 3/15/2019 5:02 PM, Liron Himi wrote: > > > -Original Message- > From: Ferruh Yigit > Sent: Thursday, March 14, 2019 11:28 > To: Liron Himi > Cc: dev@dpdk.org; Alan Winkowski > Subject: Re: [PATCH v2] net/kni: calc mbuf&mtu according to given mb_pool > > On 3/14/2019 6:37 AM, Liron

Re: [dpdk-dev] [PATCH v3 8/8] net/ice: support vector AVX2 in TX

2019-03-15 Thread Ferruh Yigit
On 3/15/2019 6:22 AM, Wenzhuo Lu wrote: > Signed-off-by: Wenzhuo Lu > --- > doc/guides/rel_notes/release_19_05.rst | 4 + > drivers/net/ice/ice_rxtx.c | 13 ++- > drivers/net/ice/ice_rxtx.h | 2 + > drivers/net/ice/ice_rxtx_vec_avx2.c| 158 > +

Re: [dpdk-dev] [PATCH v3 6/8] net/ice: support Rx AVX2 vector

2019-03-15 Thread Ferruh Yigit
On 3/15/2019 6:22 AM, Wenzhuo Lu wrote: > Signed-off-by: Wenzhuo Lu <...> > +#ifdef RTE_LIBRTE_ICE_16BYTE_RX_DESC > + /* for AVX we need alignment otherwise loads are not atomic */ > + if (avx_aligned) { > + /* load in descriptors, 2 at a time, in rever

Re: [dpdk-dev] [PATCH v3 3/8] net/ice: support vector SSE in RX

2019-03-15 Thread Ferruh Yigit
On 3/15/2019 6:22 AM, Wenzhuo Lu wrote: > Signed-off-by: Wenzhuo Lu <...> > @@ -305,6 +305,7 @@ CONFIG_RTE_LIBRTE_ICE_DEBUG_TX=n > CONFIG_RTE_LIBRTE_ICE_DEBUG_TX_FREE=n > CONFIG_RTE_LIBRTE_ICE_RX_ALLOW_BULK_ALLOC=y > CONFIG_RTE_LIBRTE_ICE_16BYTE_RX_DESC=n > +CONFIG_RTE_LIBRTE_ICE_INC_VECTOR=y

Re: [dpdk-dev] [PATCH v3 2/8] net/ice: add pointer for queue buffer release

2019-03-15 Thread Ferruh Yigit
On 3/15/2019 6:22 AM, Wenzhuo Lu wrote: > Add function pointers of buffer releasing for RX and > TX queues, for vector functions will be added for RX > and TX. > > Signed-off-by: Wenzhuo Lu <...> > @@ -27,6 +27,9 @@ > > #define ICE_SUPPORT_CHAIN_NUM 5 > > +typedef void (*ice_rx_release_mbu

Re: [dpdk-dev] [PATCH v3 1/8] net/ice: fix Tx function setting

2019-03-15 Thread Ferruh Yigit
On 3/15/2019 6:22 AM, Wenzhuo Lu wrote: > The TX setting functions is not called. > > Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx") Do we need sta...@dpdk.org tag for this? > Signed-off-by: Wenzhuo Lu > --- > drivers/net/ice/ice_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [dpdk-dev] [PATCH 4/4] power: send confirmation cmd to vm guest

2019-03-15 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hajkowski > + int ret = -1; > + if (valid_unit) > + ret = send_ack_for_received_cmd(pkt, > + chan_info, > +

Re: [dpdk-dev] [PATCH v2] net/kni: calc mbuf&mtu according to given mb_pool

2019-03-15 Thread Liron Himi
-Original Message- From: Ferruh Yigit Sent: Thursday, March 14, 2019 11:28 To: Liron Himi Cc: dev@dpdk.org; Alan Winkowski Subject: Re: [PATCH v2] net/kni: calc mbuf&mtu according to given mb_pool On 3/14/2019 6:37 AM, Liron Himi wrote: > > > -Original Message- > From: Ferr

Re: [dpdk-dev] [PATCH] cryptodev: make xform key pointer constant

2019-03-15 Thread Kusztal, ArkadiuszX
Hi Fan, Only one thing from me (with [AK]) Except for that looks good, I can ack v2. Arek > -Original Message- > From: Zhang, Roy Fan > Sent: Friday, March 1, 2019 2:43 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Zhang, Roy Fan ; > Kusztal, ArkadiuszX ; > jerin.ja...@caviumnetworks.c

Re: [dpdk-dev] [PATCH 4/4] power: send confirmation cmd to vm guest

2019-03-15 Thread Pattan, Reshma
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hajkowski > static int > process_request(struct channel_packet *pkt, struct channel_info *chan_info) > { > @@ -645,33 +678,52 @@ process_request(struct channel_packet *pkt, struct > channel_info *chan_info)

[dpdk-dev] [PATCH v4] net/ixgbe: Restore vlan filter for ixgbevf

2019-03-15 Thread David Harton
ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation. Restoring the capbility to enable the vlan strip offload at configuration time. Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") Signed-off-by: David Harton --- v4: fixed

[dpdk-dev] [PATCH] app/pdump: enforcing pdump to use sw mempool

2019-03-15 Thread Harman Kalra
Since pdump uses SW rings to manage packets hence pdump should use SW ring mempool for managing its own copy of packets. Signed-off-by: Harman Kalra --- app/pdump/main.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index ccf2a1d2f..

[dpdk-dev] [Bug 227] Flow control mode on mac Intel Corporation I350 Gigabit Network Connection (rev 01) issues

2019-03-15 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=227 Bug ID: 227 Summary: Flow control mode on mac Intel Corporation I350 Gigabit Network Connection (rev 01) issues Product: DPDK Version: 18.11 Hardware: x86 OS: Linux

Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats API

2019-03-15 Thread David Marchand
On Thu, Mar 14, 2019 at 4:13 PM David Marchand wrote: > Introduce a new api to retrieve per queue statistics from the drivers. > The api objectives: > - easily add some common per queue statistics and have it exposed > through the user xstats api while the user stats api is left untouched > - r

Re: [dpdk-dev] [PATCH v3 1/1] ring: enforce reading the tail before reading ring slots

2019-03-15 Thread Ananyev, Konstantin
> -Original Message- > From: Gavin Hu [mailto:gavin...@arm.com] > Sent: Tuesday, March 12, 2019 4:59 PM > To: dev@dpdk.org > Cc: n...@arm.com; gavin hu ; tho...@monjalon.net; Ananyev, > Konstantin ; > jer...@marvell.com; hemant.agra...@nxp.com; nipun.gu...@nxp.com; > honnappa.nagaraha.

Re: [dpdk-dev] [PATCH 1/2] net/bnxt: silence iova warnings

2019-03-15 Thread Rami Rosen
Stephen Hemminger ‏: > When using bnxt on bare-metal with vfio-pci, the driver logs an > unnecessary warning. Hardware works fine, message is not urgent. > Change it to INFO level. > > Fixes: 62196f4e0941 ("mem: rename address mapping function to IOVA") > Signed-off-by: Stephen Hemminger > --- >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-15 Thread Ananyev, Konstantin
Hi Wei, > > > > > > > > > > > > > > Hi Qi, > > > > > > > > > > > > > > This patch was rejected with no feedback. > > > > > > > > > > > > > > Can you share why? > > > > > > > > > > > > Because as Zhao Wei explained in v1 thread, in > > > > > > ixgbe_vlan_offload_config , ETH_VLAN_FILTER_MASK and >

Re: [dpdk-dev] [PATCH v6 1/2] eal/ticketlock: ticket based to improve fairness

2019-03-15 Thread Ananyev, Konstantin
Hi, > diff --git a/lib/librte_eal/common/include/generic/rte_ticketlock.h > b/lib/librte_eal/common/include/generic/rte_ticketlock.h > new file mode 100644 > index 000..d63 > --- /dev/null > +++ b/lib/librte_eal/common/include/generic/rte_ticketlock.h > @@ -0,0 +1,308 @@ > +/* SPDX-Licens

[dpdk-dev] [PATCH v3] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-15 Thread David Harton
ixgbevf vlan strip and extend capabilities were removed when migrating to the bit flags implementation. Restoring the capbility to enable these offloads at configuration time. Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\") Signed-off-by: David Harton --- v3: restored ixgbe_

Re: [dpdk-dev] [PATCH v8 0/3] generic spinlock optimization and test case enhancements

2019-03-15 Thread Ananyev, Konstantin
> > V8: Remove internal ChangeId > > V7: Update the 1/3 patch headline and commit message > > V6: Rebase and drop the first patch as a similar fix was already merged. > > V5: Remove ChangeId(sorry for that) > > V4: > 1. Drop one patch for the test case to get time precisely as the overhead

Re: [dpdk-dev] [PATCH v3 1/3] rwlock: reimplement with atomic builtins

2019-03-15 Thread Ananyev, Konstantin
Hi, > The __sync builtin based implementation generates full memory > barriers ('dmb ish') on Arm platforms. Using C11 atomic builtins > to generate one way barriers. > > Here is the assembly code of __sync_compare_and_swap builtin. > __sync_bool_compare_and_swap(dst, exp, src); >0x0

Re: [dpdk-dev] [PATCH ] doc: fix two typos in contributing guide

2019-03-15 Thread Kovacevic, Marko
> This patch fixes two typos in the coding style part of DPDK contributing > guide: > > - The header entry should have .h file instead of .c file. > - The will->This will > > Fixes: 44a6dface13b ("doc: describe how to add new components") > > Signed-off-by: Rami Rosen > --- > doc/guides/contr

Re: [dpdk-dev] [PATCH] app/testpmd: fix support of hex string parser for flow API

2019-03-15 Thread Ananyev, Konstantin
Hi Wei, > > There is need for users to set configuration of HEX number for RSS > key. The key byte should be pass down as hex number not as char > string. This patch enable cmdline flow parse HEX number, > in order to not using string which pass ASIC number. > > Fixes: f4d623f96119 ("app/testpmd

[dpdk-dev] [PATCH 3/4] power: reset function pointers on unset env

2019-03-15 Thread Hajkowski
From: Marcin Hajkowski Set all power environment related function pointers to NULL when unset is being made. Signed-off-by: Marcin Hajkowski --- lib/librte_power/rte_power.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/lib/librte_power/rte_power.c b

[dpdk-dev] [PATCH 2/4] power: return error in set env when power env already set

2019-03-15 Thread Hajkowski
From: Marcin Hajkowski On attempt to set_env in already initialized state notify user by returning error that operation cannot be performed. Signed-off-by: Marcin Hajkowski --- doc/guides/rel_notes/release_19_05.rst | 4 lib/librte_power/rte_power.c | 3 ++- lib/librte_power/rte

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-15 Thread Zhao1, Wei
Hi , Konstantin > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, March 15, 2019 5:24 PM > To: Zhao1, Wei ; Zhang, Qi Z ; > David Harton (dharton) > Cc: Lu, Wenzhuo ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf > > > > > > Hi,q

[dpdk-dev] [PATCH 1/4] power: fix non thread-safe power env modification

2019-03-15 Thread Hajkowski
From: Marcin Hajkowski Due to lack of thread safety in exisiting solution use spinlock mechanism for atomic modification of power environment related data. Fixes: 445c6528b5 ("power: common interface for guest and host") Cc: sta...@dpdk.org Signed-off-by: Marcin Hajkowski --- doc/guides/rel_n

[dpdk-dev] [PATCH 4/4] power: add UTs for all power env types

2019-03-15 Thread Hajkowski
From: Marcin Hajkowski Test all existing power environment configuration to verify if related data is properly initialized and clean in set/unset scenarios. Signed-off-by: Marcin Hajkowski --- app/test/test_power.c | 155 -- 1 file changed, 120 insertion

[dpdk-dev] [PATCH 0/4] rte_power APIs enhancement

2019-03-15 Thread Hajkowski
From: Marcin Hajkowski Modifications to assure thread safety of rte_power APIs for power env set and unset, better user notification by returning more suitable value and internal data cleaning corrections. Marcin Hajkowski (4): power: fix non thread-safe power env modification power: return

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-15 Thread Ananyev, Konstantin
> > Hi,qi > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Friday, March 15, 2019 9:20 AM > > To: David Harton (dharton) > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > ; dev@dpdk.org; Zhao1, Wei > > > > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf >

[dpdk-dev] [PATCH ] doc: fix two typos in contributing guide

2019-03-15 Thread Rami Rosen
This patch fixes two typos in the coding style part of DPDK contributing guide: - The header entry should have .h file instead of .c file. - The will->This will Fixes: 44a6dface13b ("doc: describe how to add new components") Signed-off-by: Rami Rosen --- doc/guides/contributing/coding_style.r

[dpdk-dev] [PATCH] app/testpmd: fix support of hex string parser for flow API

2019-03-15 Thread Wei Zhao
There is need for users to set configuration of HEX number for RSS key. The key byte should be pass down as hex number not as char string. This patch enable cmdline flow parse HEX number, in order to not using string which pass ASIC number. Fixes: f4d623f96119 ("app/testpmd: fix missing RSS fields

[dpdk-dev] [PATCH] bonding: fix lacp negotiation failed

2019-03-15 Thread Liang Zhang
When monitor(port-mirroring) traffic from other lacp port-channel, rx_machine_update may recieving other lacp negotiation packets. Thus bond mode 4 will negotiation failed. Signed-off-by: Liang Zhang --- drivers/net/bonding/rte_eth_bond_8023ad.c | 12 ++-- drivers/net/bonding/rte

[dpdk-dev] [PATCH v3 2/2] bonding: change mac_addr filled position

2019-03-15 Thread Liang Zhang
When mac_address update in bond_mode_8023ad_mac_address_update, bonding port's mac_addr should update also. Signed-off-by: Liang Zhang --- drivers/net/bonding/rte_eth_bond_8023ad.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023a

[dpdk-dev] [PATCH v3 1/2] bonding: fix lacp negotiation failed

2019-03-15 Thread Liang Zhang
When monitor(port-mirroring) traffic from other lacp port-channel, rx_machine_update may recieving other lacp negotiation packets. Thus bond mode 4 will negotiation failed. Signed-off-by: Liang Zhang --- drivers/net/bonding/rte_eth_bond_8023ad.c | 9 +++-- drivers/net/bonding/rte_eth

Re: [dpdk-dev] [PATCH v3 0/8] Support vector instructions on ICE

2019-03-15 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Friday, March 15, 2019 2:23 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH v3 0/8] Support vector instructions on ICE > > Use SSE and AVX2 instructions in ICE RX and TX

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf

2019-03-15 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, March 15, 2019 1:28 PM > To: Zhang, Qi Z ; David Harton (dharton) > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: Restore vlan filter/extend for ixgbevf > > Hi,qi > > > -Origina