Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-22 Thread Anoob Joseph
Hi Fiona, > -Original Message- > From: Trahe, Fiona > Sent: Friday, February 22, 2019 9:09 PM > To: Anoob Joseph ; Akhil Goyal ; > Doherty, Declan ; De Lara Guarch, Pablo > > Cc: Jerin Jacob Kollanukkaran ; Narayana Prasad Raju > Athreya ; dev@dpdk.org; Ankur Dwivedi > ; Trahe, Fiona >

[dpdk-dev] [PATCH] eal: add option to not store segment fd's

2019-02-22 Thread Anatoly Burakov
Due to internal glibc limitations [1], DPDK may exhaust internal file descriptor limits when using smaller page sizes, which results in inability to use system calls such as select() by user applications. While the problem can be worked around using --single-file-segments option, it does not work

Re: [dpdk-dev] Question about DPDK hugepage fd change

2019-02-22 Thread Burakov, Anatoly
On 06-Feb-19 1:57 PM, Iain Barker wrote: Can you use 1G hugepages instead of 2M pages or a combo of the two, not sure how dpdk handles having both in the system? Unfortunately, no. Some of our customer deployments are tenancies on KVM hosts and low-end appliances, which are not configurable b

Re: [dpdk-dev] [PATCH 2/2] doc: rename avf to iavf

2019-02-22 Thread Ferruh Yigit
On 2/22/2019 3:03 PM, Leyi Rong wrote: > This patch renames avf to iavf only for the doc files. > > Signed-off-by: Leyi Rong > --- > MAINTAINERS| 6 +++--- > doc/guides/nics/features/{avf.ini => iavf.ini} | 2 +- > .../nics/features/{avf_vec.ini => i

Re: [dpdk-dev] [PATCH 1/2] net/iavf: rename avf to iavf

2019-02-22 Thread Ferruh Yigit
On 2/22/2019 3:03 PM, Leyi Rong wrote: > diff --git a/drivers/net/avf/rte_pmd_avf_version.map > b/drivers/net/iavf/rte_pmd_iavf_version.map > similarity index 100% > rename from drivers/net/avf/rte_pmd_avf_version.map > rename to drivers/net/iavf/rte_pmd_iavf_version.map > diff --git a/drivers/net

Re: [dpdk-dev] [PATCH 1/2] net/iavf: rename avf to iavf

2019-02-22 Thread Ferruh Yigit
On 2/22/2019 3:03 PM, Leyi Rong wrote: > Rename Intel Ethernet Adaptive Virtual Function driver avf to iavf. > > This patch renames the directory name, filenames, lib name, macros, > functions, structs and any other strings in the iavf src code. > > Signed-off-by: Leyi Rong > --- > config/commo

[dpdk-dev] [PATCH 1/3] fbarray: add API to find biggest used or free chunks

2019-02-22 Thread Anatoly Burakov
Currently, while there is a way to find total amount of used/free space in an fbarray, there is no way to find biggest contiguous chunk. Add such API, as well as unit tests to test this API. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_fbarray.c | 109 ++ lib/

[dpdk-dev] [PATCH 3/3] eal: attempt multiple hugepage allocations at init

2019-02-22 Thread Anatoly Burakov
When requesting memory with ``-m`` or ``--socket-mem`` flags, currently the init will fail if the requested memory amount was bigger than any one memseg list, even if total amount of available memory was sufficient. Fix this by making EAL to attempt to allocate pages multiple times, until we eithe

[dpdk-dev] [PATCH 2/3] memalloc: improve best-effort allocation

2019-02-22 Thread Anatoly Burakov
Previously, when using non-exact allocation, we were requesting N pages to be allocated, but allowed the memory subsystem to allocate less than requested. However, we were still expecting to see N contigous free pages in the memseg list. This presents a problem because there is no way to try and a

[dpdk-dev] [PATCH 0/7] Subject: [PATCH ...] Add stack library and new mempool handler

2019-02-22 Thread Gage Eads
This patchset introduces a stack library, supporting both lock-based and non-blocking stacks, and a non-blocking stack mempool handler. The lock-based stack code is derived from the existing stack mempool handler, and that handler is refactored to use the stack library. The non-blocking stack mem

[dpdk-dev] [PATCH 4/7] test/stack: add stack perf test

2019-02-22 Thread Gage Eads
stack_perf_autotest tests the following with one lcore: - Cycles to attempt to pop an empty stack - Cycles to push then pop a single object - Cycles to push then pop a burst of 32 objects It also tests the cycles to push then pop a burst of 8 and 32 objects with the following lcore combinations (i

[dpdk-dev] [PATCH 3/7] test/stack: add stack test

2019-02-22 Thread Gage Eads
stack_autotest performs positive and negative testing of the stack API, and exercises the push and pop datapath functions with all available lcores. Signed-off-by: Gage Eads --- MAINTAINERS| 1 + test/test/Makefile | 2 + test/test/meson.build | 3 + test/test/test_stack.c

[dpdk-dev] [PATCH 6/7] test/stack: add non-blocking stack tests

2019-02-22 Thread Gage Eads
This commit adds non-blocking stack variants of stack_autotest (stack_nb_autotest) and stack_perf_autotest (stack_nb_perf_autotest), which differ only in that the non-blocking versions pass the STACK_F_NB flag to all rte_stack_create() calls. Signed-off-by: Gage Eads --- test/test/meson.build

[dpdk-dev] [PATCH 7/7] mempool/stack: add non-blocking stack mempool handler

2019-02-22 Thread Gage Eads
This commit adds support for non-blocking (linked list based) stack mempool handler. In mempool_perf_autotest the lock-based stack outperforms the non-blocking handler for certain lcore/alloc count/free count combinations*, however: - For applications with preemptible pthreads, a lock-based stack'

[dpdk-dev] [PATCH 5/7] stack: add non-blocking stack implementation

2019-02-22 Thread Gage Eads
This commit adds support for a non-blocking (linked list based) stack to the stack API. This behavior is selected through a new rte_stack_create() flag, STACK_F_NB. The stack consists of a linked list of elements, each containing a data pointer and a next pointer, and an atomic stack depth counter

[dpdk-dev] [PATCH 1/7] stack: introduce rte stack library

2019-02-22 Thread Gage Eads
The rte_stack library provides an API for configuration and use of a bounded stack of pointers. Push and pop operations are MT-safe, allowing concurrent access, and the interface supports pushing and popping multiple pointers at a time. The library's interface is modeled after another DPDK data st

[dpdk-dev] [PATCH 2/7] mempool/stack: convert mempool to use rte stack

2019-02-22 Thread Gage Eads
The new rte_stack library is derived from the mempool handler, so this commit removes duplicated code and simplifies the handler by migrating it to this new API. Signed-off-by: Gage Eads --- MAINTAINERS | 2 +- drivers/mempool/stack/Makefile| 3 +- dri

[dpdk-dev] [PATCH] mem: warn user when running without NUMA support

2019-02-22 Thread Anatoly Burakov
Running in non-legacy mode on a NUMA-enabled system without libnuma is unsupported, so explicitly print out a warning when trying to do so. Running in legacy mode without libnuma is still supported whether or not we are running with libnuma support enabled, so also fix init to allow that scenario.

[dpdk-dev] [PATCH v2 1/1] eal: add 128-bit cmpxchg (x86-64 only)

2019-02-22 Thread Gage Eads
This operation can be used for non-blocking algorithms, such as a non-blocking stack or ring. Signed-off-by: Gage Eads --- .../common/include/arch/x86/rte_atomic_64.h| 33 lib/librte_eal/common/include/generic/rte_atomic.h | 59 ++ 2 files changed, 92 ins

[dpdk-dev] [PATCH v2 0/1] Add 128-bit compare and set

2019-02-22 Thread Gage Eads
This patch addresses x86-64 only; other architectures can/will be supported in the future. The __atomic intrinsic was considered for the implementation, however libatomic was found[1] to use locks to implement the 128-bit CAS on at least one architecture and so is eschewed here. The interface is mo

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix driver name comparison

2019-02-22 Thread Trahe, Fiona
Hi Anoob, > > > > @@ -542,8 +543,8 @@ rte_cryptodev_get_dev_id(const char *name) > > > > return -1; > > > > > > > > for (i = 0; i < cryptodev_globals.nb_devs; i++) > > > > - if ((strcmp(cryptodev_globals.devs[i].data->name, name) > > > > -

[dpdk-dev] [PATCH v4] lib/metrics: add unregister api for metrics

2019-02-22 Thread wanjunjie
From: junka The bitmap will help maintain the metrics. We can dynamically add and remove metrics data. For example, after uninit latency lib, it could remove itself from the metrics. This could make the result from rte_metrics_get_names much more simple to display the wanted metrics data only. S

[dpdk-dev] [PATCH] malloc: fix documentation for realloc

2019-02-22 Thread Anatoly Burakov
The documentation for rte_realloc claims that the resized area will always reside on the same NUMA node. This is not actually the case - while *resized* area will be on the same NUMA node, if resizing the area is not possible, then the memory will be reallocated using rte_malloc(), which can alloca

[dpdk-dev] [PATCH v3] lib/metrics: add unregister api for metrics

2019-02-22 Thread wanjunjie
From: junka The bitmap will help maintain the metrics. We can dynamically add and remove metrics data. After uninit latency, it can remove itself from the metrics. This could make the result from rte_metrics_get_names much more simple to display the wanted metrics data only. Signed-off-by: junka

[dpdk-dev] [PATCH 2/2] test/metrics: first test case fails on continuous execution

2019-02-22 Thread Harman Kalra
Issue is observed while running 'metrics_autotest' continuously without quiting. During first execution all test cases pass but second run onwards first test case fails as library is already initialized. To resolve, introduced a new API to deinitialise the library after all test cases are executed

[dpdk-dev] [PATCH 1/2] metrics: new API to deinitialise metrics library

2019-02-22 Thread Harman Kalra
Once the library usage is over, it must be deinitialized which will free the shared memory reserved during initialization. Fixes: observed an issue while running 'metrics_autotest' continuously without quiting. For the first run 'metrics_autotest' passes all test cases but second run onwards first

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix reset active slave

2019-02-22 Thread Ferruh Yigit
On 2/22/2019 1:52 AM, Chas Williams wrote: > > > On 2/20/19 10:16 AM, Hyong Youb Kim wrote: >> On Wed, Feb 20, 2019 at 02:56:36PM +, Radu Nicolau wrote: >>> >>> >>> On 2/20/2019 12:33 PM, Ferruh Yigit wrote: On 2/18/2019 3:58 PM, Radu Nicolau wrote: > > On 2/18/2019 11:59 AM, Har

[dpdk-dev] [PATCH v2] lib/metrics: add unregister api for metrics

2019-02-22 Thread wanjunjie
From: junka The bitmap will help maintain the metrics. We can dynamically add and remove metrics data. After uninit latency, it can remove itself from the metrics. This could make the result from rte_metrics_get_names much more simple to display the wanted metrics data only. Signed-off-by: junka

Re: [dpdk-dev] [PATCH v2 1/4] ipsec: add AES-CTR algorithm support

2019-02-22 Thread Ananyev, Konstantin
> > This patch adds AES-CTR cipher algorithm support to ipsec > library. > > Signed-off-by: Fan Zhang > --- > lib/librte_ipsec/crypto.h | 17 ++ > lib/librte_ipsec/sa.c | 133 > ++ > lib/librte_ipsec/sa.h | 18 +++ > 3 files chang

Re: [dpdk-dev] [PATCH v2 2/4] ipsec-secgw: add test scripts for aes ctr

2019-02-22 Thread Ananyev, Konstantin
> This patch adds the functional test scripts to ipsec-secgw > sample application for both transport and tunnel working > mode. > > Updated a bit on common_defs to use "mktemp" instead of "tempfile" > as Fedora does not like the command. > > Signed-off-by: Fan Zhang > --- > examples/ipsec-secgw

Re: [dpdk-dev] [PATCH v2 4/4] ipsec-secgw: add 3des test files

2019-02-22 Thread Ananyev, Konstantin
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, February 19, 2019 3:33 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Ananyev, Konstantin ; > Zhang, Roy Fan > Subject: [PATCH v2 4/4] ipsec-secgw: add 3des test files > > This patch adds the functional test scripts to ips

Re: [dpdk-dev] [PATCH v2 3/4] ipsec: add 3DES-CBC algorithm support

2019-02-22 Thread Ananyev, Konstantin
> This patch adds triple-des CBC mode cipher algorithm to ipsec > library. > > Signed-off-by: Fan Zhang > --- > lib/librte_ipsec/sa.c | 10 ++ > lib/librte_ipsec/sa.h | 6 ++ > 2 files changed, 16 insertions(+) > > diff --git a/lib/librte_ipsec/sa.c b/lib/librte_ipsec/sa.c > index

[dpdk-dev] RSS hashing support on ixgbevf

2019-02-22 Thread Gareth Bradshaw
Hi all, Does the IXGBE PMD support RSS in the VF? The value of "dev_info.flow_type_rss_offloads" is 0 for ixgbevf_dev_info_get and triggers the "invalid argument" check added to rte_eth_dev_configure (@line 1243). The PF equivalent (ixbge_dev_info_get) sets flow_type_rss_offloads to IXGBE_RSS

[dpdk-dev] [PATCH v1] examples/distributor: detect high frequency cores

2019-02-22 Thread David Hunt
The distributor application is bottlenecked by the distributor core, so if we can give more frequency to this core, then the overall performance of the application may increase. This patch uses the rte_power_get_capabilities() API to query the cores provided in the core mask, and if any high frequ

[dpdk-dev] 18.11.1 patches review and test

2019-02-22 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for LTS release 18.11.1. Please help review and test. The planned date for the final release is 9th of March. Before that, please shout if anyone has objections with these patches being applied. Also for the companies committed to running regression test

[dpdk-dev] [PATCH 6/6] net/dpaa2: add basic support for generic flow

2019-02-22 Thread Hemant Agrawal
From: Sunil Kumar Kori Signed-off-by: Sunil Kumar Kori Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/Makefile |1 + drivers/net/dpaa2/base/dpaa2_hw_dpni.c |4 +- drivers/net/dpaa2/dpaa2_ethdev.c | 90 +- drivers/net/dpaa2/dpaa2_ethdev.h | 22 + drivers

[dpdk-dev] [PATCH 5/6] net/dpaa2: support low level loopback tester

2019-02-22 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- doc/guides/nics/dpaa2.rst | 5 + .../fslmc/qbman/include/fsl_qbman_portal.h| 18 ++ drivers/bus/fslmc/qbman/qbman_portal.c| 161 ++ drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 + drivers/net/dpaa2/dpaa2_e

[dpdk-dev] [PATCH 4/6] net/dpaa2: add support for 16 Rx Queues per traffic class

2019-02-22 Thread Hemant Agrawal
From: Ashish Jain Adding support for 16 queues per TC per DPNI port which is required for LX2 platform. Signed-off-by: Ashish Jain --- drivers/net/dpaa2/dpaa2_ethdev.c | 6 -- drivers/net/dpaa2/dpaa2_ethdev.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH 3/6] bus/fslmc: add enqueue response read routines in qbman

2019-02-22 Thread Hemant Agrawal
From: Nipun Gupta Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 47 drivers/bus/fslmc/portal/dpaa2_hw_dpio.h | 4 + drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 24 ++ .../fslmc/qbman/include/fsl_qbman_portal.h| 56 +++- drivers/bus/fslmc/q

[dpdk-dev] [PATCH 1/6] net/dpaa2: add support for VLAN tpid config

2019-02-22 Thread Hemant Agrawal
This patch add support to config custom tpid in dpni. i.e. value other than 0x8100 and 0x88A8 Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c| 39 drivers/net/dpaa2/mc/dpni.c | 98 + drivers/net/dpaa2/mc/fsl_dpni.h | 20

[dpdk-dev] [PATCH 2/6] mempool/dpaa2: fix to reduce continuous print on empty pool

2019-02-22 Thread Hemant Agrawal
Changing the print to DP_DEBUG to avoid continuous prints when buffer pools runs out of buffers Fixes: 3646ccf0b036 ("mempool/dpaa2: support dynamic logging") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 4 ++-- 1 file changed, 2 insertions(+)

[dpdk-dev] [PATCH] bus/dpaa: fix Rx discard mask register

2019-02-22 Thread Hemant Agrawal
From: Shreyansh Jain Current value of 'fmbm_rfsdm' register (0x010CE3F0) doesn't include the bit to drop colored (red) packets. New value (0x010EE3F0) fixes this. Check with 'fmbm_rffc' register of fm_port_bmi_regs. Fixes: 6d6b4f49a155 ("bus/dpaa: add FMAN hardware operations") Signed-off-by: S

[dpdk-dev] [PATCH] test/crypto: fix duplicate device id uses by CCP device

2019-02-22 Thread Hemant Agrawal
These duplicate device id is causing incorrect mapping for DPAA_SEC for test case execultion on the basis of capabilities. Fixes: e155ca055e84 ("test/crypto: add tests for AMD CCP") Cc: sta...@dpdk.org Cc: ravi1.ku...@amd.com Reported-by: Anoob Joseph Signed-off-by: Hemant Agrawal --- test/tes

[dpdk-dev] [dpdk-announce] DPDK summit March 9th and Hands on Session March 8th Bangalore Schedule announced

2019-02-22 Thread Tibrewala, Sujata
Hi, We are excited to announce the schedule for the DPDK summit Bangalore March 9th and DPDK hands on session the day before on March 8th at Bangalore. At the summit we have exciting talks on Edge & 5G infrastructure, DPDK architecture and tech board updates, Kamuee Router, Cloud Native funct

[dpdk-dev] DPDK Techboard minutes of Feb 13 2019

2019-02-22 Thread Hemant Agrawal
Meeting notes for the DPDK technical board meeting held on 2019-01-30 Attendees: 7/9 - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Konstantin Ananyev - Stephen Hemminger

[dpdk-dev] [PATCH] vhost: fix interrupt suppression for the split ring

2019-02-22 Thread Jiayu Hu
The VIRTIO_RING_F_EVENT_IDX feature of split ring might be broken, as the value of signalled_used is unpredictable after live migration or start up. This patch fixes it by using signalled_used_valid. In addition, this patch makes the VIRTIO_RING_F_EVENT_IDX implementation of split ring match kerne