Re: [dpdk-dev] [PATCH] net/mlx5: fix concurrent use of Tx offloads

2019-01-28 Thread Yongseok Koh
> On Jan 28, 2019, at 10:49 PM, Dekel Peled wrote: > > Original patch implemented the use of match_metadata offload in the > different burst functions. > The concurrent use of match_metadata and multi_segs offloads was > not handled. > > This patch updates function txq_scatter_v(), to pass metad

[dpdk-dev] [Bug 196] IXGBE Driver Tx Packet/Bytes counters Sent returns Zero even though link-partner received valid packets

2019-01-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=196 Bug ID: 196 Summary: IXGBE Driver Tx Packet/Bytes counters Sent returns Zero even though link-partner received valid packets Product: DPDK Version: 18.08 Hardware: x86

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue for some architectures

2019-01-28 Thread Shahaf Shuler
Monday, January 28, 2019 4:22 PM, Viacheslav Ovsiienko: > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: fix compilation issue for some architectures > > Added inclusion, was not included on some building setups > (ARMv8). > > Fixes: 61fea2920403 ("net/mlx5: fix VXLAN port registration race condi

[dpdk-dev] [PATCH v5] doc/patches: add meson build to contributing guide

2019-01-28 Thread Vipin Varghese
Patches has to be validated for meson devtool script for code and document changes. Updating documentation for meson build steps in checking Compilation category. Signed-off-by: Vipin Varghese Tested-by: Marko Kovacevic Acked-by: Marko Kovacevic --- V5: create sub section to Compilation - Tho

Re: [dpdk-dev] [PATCH 1/1] eal: add 128-bit cmpset (x86-64 only)

2019-01-28 Thread Ola Liljedahl
On Mon, 2019-01-28 at 11:29 -0600, Gage Eads wrote: > This operation can be used for non-blocking algorithms, such as a > non-blocking stack or ring. > > Signed-off-by: Gage Eads > --- >  .../common/include/arch/x86/rte_atomic_64.h| 31 +++ >  lib/librte_eal/common/include/generic/

Re: [dpdk-dev] [PATCH v3 2/5] ring: add a non-blocking implementation

2019-01-28 Thread Ola Liljedahl
On Mon, 2019-01-28 at 18:54 +, Eads, Gage wrote: > > > > > -Original Message- > > From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > > Sent: Monday, January 28, 2019 4:36 AM > > To: jer...@marvell.com; mcze...@marvell.com; Eads, Gage > > ; dev@dpdk.org > > Cc: olivier.m...@6wind.com

Re: [dpdk-dev] [RFC] lfring: lock-free ring buffer

2019-01-28 Thread Ola Liljedahl
On Mon, 2019-01-28 at 21:04 +, Eads, Gage wrote: > Hey Ola, > > > > > -Original Message- > > From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > > Sent: Monday, January 28, 2019 6:29 AM > > To: dev@dpdk.org; Eads, Gage ; Honnappa Nagarahalli > > ; Richardson, Bruce > > > > Cc: nd ;

Re: [dpdk-dev] [RFC] lfring: lock-free ring buffer

2019-01-28 Thread Eads, Gage
Hey Ola, > -Original Message- > From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > Sent: Monday, January 28, 2019 6:29 AM > To: dev@dpdk.org; Eads, Gage ; Honnappa Nagarahalli > ; Richardson, Bruce > > Cc: nd ; Ola Liljedahl > Subject: [RFC] lfring: lock-free ring buffer > > Lock-free

Re: [dpdk-dev] [PATCH v3 2/5] ring: add a non-blocking implementation

2019-01-28 Thread Eads, Gage
> -Original Message- > From: Jerin Jacob Kollanukkaran [mailto:jer...@marvell.com] > Sent: Monday, January 28, 2019 7:34 AM > To: ola.liljed...@arm.com; Maciej Czekaj ; Eads, Gage > ; dev@dpdk.org > Cc: olivier.m...@6wind.com; step...@networkplumber.org; n...@arm.com; > Richardson, Bruce

Re: [dpdk-dev] [PATCH v3 2/5] ring: add a non-blocking implementation

2019-01-28 Thread Eads, Gage
> -Original Message- > From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > Sent: Monday, January 28, 2019 4:36 AM > To: jer...@marvell.com; mcze...@marvell.com; Eads, Gage > ; dev@dpdk.org > Cc: olivier.m...@6wind.com; step...@networkplumber.org; nd > ; Richardson, Bruce ; > arybche...@s

[dpdk-dev] [PATCH v4 4/5] test_ring_perf: add non-blocking ring perf test

2019-01-28 Thread Gage Eads
nb_ring_perf_autotest re-uses the ring_perf_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- test/test/test_ring_perf.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/test/test/test_rin

[dpdk-dev] [PATCH v4 5/5] mempool/ring: add non-blocking ring handlers

2019-01-28 Thread Gage Eads
These handlers allow an application to create a mempool based on the non-blocking ring, with any combination of single/multi producer/consumer. Also, add a note to the programmer's guide's "known issues" section. Signed-off-by: Gage Eads Acked-by: Andrew Rybchenko --- doc/guides/prog_guide/env

[dpdk-dev] [PATCH v4 2/5] ring: add a non-blocking implementation

2019-01-28 Thread Gage Eads
This commit adds support for non-blocking circular ring enqueue and dequeue functions. The ring uses a 128-bit compare-and-swap instruction, and thus is currently limited to x86_64. The algorithm is based on the original rte ring (derived from FreeBSD's bufring.h) and inspired by Michael and Scott

[dpdk-dev] [PATCH v4 3/5] test_ring: add non-blocking ring autotest

2019-01-28 Thread Gage Eads
ring_nb_autotest re-uses the ring_autotest code by wrapping its top-level function with one that takes a 'flags' argument. Signed-off-by: Gage Eads --- test/test/test_ring.c | 57 --- 1 file changed, 36 insertions(+), 21 deletions(-) diff --git a/

[dpdk-dev] [PATCH v4 1/5] ring: add 64-bit headtail structure

2019-01-28 Thread Gage Eads
64-bit head and tail index widths greatly increases the time it takes for them to wrap-around (with current CPU speeds, it won't happen within the author's lifetime). This is fundamental to avoiding the ABA problem -- in which a thread mistakes reading the same tail index in two accesses to mean th

[dpdk-dev] [PATCH v4 0/5] Add non-blocking ring

2019-01-28 Thread Gage Eads
For some users, the rte ring's "non-preemptive" constraint is not acceptable; for example, if the application uses a mixture of pinned high-priority threads and multiplexed low-priority threads that share a mempool. This patchset introduces a non-blocking ring, on top of which a mempool can run. C

[dpdk-dev] i40e doesn't calculate RSS for GRE traffic.

2019-01-28 Thread Igor Ryzhov
Hello everyone, We are currently testing i40e support for RSS calculation. RSS is configured with all supported flags: #define I40E_RSS_OFFLOAD_ALL ( \ ETH_RSS_FRAG_IPV4 | \ ETH_RSS_NONFRAG_IPV4_TCP | \ ETH_RSS_NONFRAG_IPV4_UDP | \ ETH_RSS_NONFRAG_IPV4_SCTP | \ ETH_RSS_NONFRAG_IPV4_OTHER | \ ETH

[dpdk-dev] [PATCH 1/1] eal: add 128-bit cmpset (x86-64 only)

2019-01-28 Thread Gage Eads
This operation can be used for non-blocking algorithms, such as a non-blocking stack or ring. Signed-off-by: Gage Eads --- .../common/include/arch/x86/rte_atomic_64.h| 31 +++ lib/librte_eal/common/include/generic/rte_atomic.h | 65 ++ 2 files changed, 96 inse

[dpdk-dev] [PATCH 0/1] Add 128-bit compare and set

2019-01-28 Thread Gage Eads
This patch addresses x86-64 only; other architectures can/will be supported in the future. The __atomic intrinsic was considered for the implementation, however libatomic was found[1] to use locks to implement the 128-bit CAS on at least one architecture and so is eschewed here. The interface is mo

Re: [dpdk-dev] [PATCH] doc: deprecation notice for sched changes

2019-01-28 Thread Pattan, Reshma
Hi, More details needs to be added to deprecation note which are not clear yet, so self NACK. Thanks, Reshma > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Reshma Pattan > Sent: Monday, January 28, 2019 11:28 AM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; D

Re: [dpdk-dev] [PATCH v5 2/2] doc: add guide for debug and troubleshoot

2019-01-28 Thread Thomas Monjalon
28/01/2019 15:51, Varghese, Vipin: > Hi Thomas, > > snipped > > > > I feel this doc will be updated to provide a complete debug checklist, > Attempt is made to capture commonly seen filed issue. Saying so, I am clear > that I will not be able to identify all debug check list. As time, experience

Re: [dpdk-dev] [PATCH v4] doc/patches: add meson build to contributing guide

2019-01-28 Thread Varghese, Vipin
Thanks Thomas for the updates, I will check and send next version soon > -Original Message- > From: Thomas Monjalon > Sent: Monday, January 28, 2019 8:23 PM > To: Varghese, Vipin > Cc: dev@dpdk.org; Mcnamara, John ; Kovacevic, > Marko ; Yigit, Ferruh ; > Padubidri, Sanjay A ; Patel, Amol

[dpdk-dev] some question about rte_security_ipsec_sa_options

2019-01-28 Thread Ananyev, Konstantin
Hi everyone, For 19.05 we plan to extend librte_ipsec with proper support of construction/updating inner/outer ipv4/ipv6 fields as described in https://tools.ietf.org/html/rfc4301#section-5.1.2. So few questions regarding struct rte_security_ipsec_sa_options fields. 1. dec_ttl - as I can see the

Re: [dpdk-dev] [PATCH v4] doc/patches: add meson build to contributing guide

2019-01-28 Thread Thomas Monjalon
28/01/2019 15:27, Varghese, Vipin: > Hi Thomas, > > snipped > > > +Compilation of patches is to be tested with ``test-meson-builds.sh`` > > > +script in ``devtools`` directory of the DPDK repo:: > > > > Would be more straight-forward to give the full path: > > devtools/test-meson-builds.sh >

Re: [dpdk-dev] [PATCH v5 2/2] doc: add guide for debug and troubleshoot

2019-01-28 Thread Varghese, Vipin
Hi Thomas, snipped > > I feel this doc will be updated to provide a complete debug checklist, Attempt is made to capture commonly seen filed issue. Saying so, I am clear that I will not be able to identify all debug check list. As time, experience and sharing increases (from the community), I a

Re: [dpdk-dev] [PATCH v5 0/3] EAL change for using a config file for DPDK

2019-01-28 Thread Ferruh Yigit
On 1/24/2019 5:45 PM, Thomas Monjalon wrote: > 24/01/2019 17:18, Ferruh Yigit: >> On 1/24/2019 4:06 PM, Thomas Monjalon wrote: >>> 24/01/2019 15:46, Ferruh Yigit: On 1/24/2019 2:32 PM, Thomas Monjalon wrote: > 24/01/2019 14:54, Ferruh Yigit: >> On 1/23/2019 8:26 PM, Thomas Monjalon wro

Re: [dpdk-dev] [PATCH v5 1/2] doc: add svg for debug and troubleshoot guide

2019-01-28 Thread Varghese, Vipin
Thanks Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Monday, January 28, 2019 6:38 AM > To: Varghese, Vipin > Cc: dev@dpdk.org; shreyansh.j...@nxp.com; Mcnamara, John > ; Kovacevic, Marko > ; Patel, Amol ; > Padubidri, Sanjay A > Subject: Re: [dpdk-dev] [PATCH v5 1/2] do

Re: [dpdk-dev] DPDK Release Status Meeting 24/01/2018

2019-01-28 Thread Aaron Conole
Thomas Monjalon writes: > 26/01/2019 00:37, Ferruh Yigit: >> On 1/25/2019 9:16 PM, Aaron Conole wrote: >> > Jay Rolette writes: >> > >> >>>* Questions from Intel Test about the use of the Stable Tree. >> >>> Do people use it? Each stable/LTS release requires a lot of >> >>> testin

Re: [dpdk-dev] [PATCH v4] doc/patches: add meson build to contributing guide

2019-01-28 Thread Varghese, Vipin
Hi Thomas, snipped > > +Compilation of patches is to be tested with ``test-meson-builds.sh`` > > +script in ``devtools`` directory of the DPDK repo:: > > Would be more straight-forward to give the full path: > devtools/test-meson-builds.sh I also like to use ' devtools/test-meson-builds.sh

[dpdk-dev] [PATCH] net/mlx5: fix compilation issue for some architectures

2019-01-28 Thread Viacheslav Ovsiienko
Added inclusion, was not included on some building setups (ARMv8). Fixes: 61fea2920403 ("net/mlx5: fix VXLAN port registration race condition") Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_tcf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_flo

Re: [dpdk-dev] [PATCH v3 2/5] ring: add a non-blocking implementation

2019-01-28 Thread Ola Liljedahl
On Mon, 2019-01-28 at 14:04 +, Jerin Jacob Kollanukkaran wrote: > > Does PPC (64-bit POWER?) have support for double-word (128-bit) CAS? > > I dont know, I was telling wrt in general C11 mem model for PPC. Sorry, I misunderstood. -- Ola Liljedahl, Networking System Architect, Arm Phone +4670

Re: [dpdk-dev] [PATCH v3 2/5] ring: add a non-blocking implementation

2019-01-28 Thread Jerin Jacob Kollanukkaran
On Mon, 2019-01-28 at 13:43 +, Ola Liljedahl wrote: > On Mon, 2019-01-28 at 13:34 +, Jerin Jacob Kollanukkaran wrote: > > On Fri, 2019-01-25 at 17:21 +, Eads, Gage wrote: > > > > -Original Message- > > > > From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > > > > Sent: Wednesda

Re: [dpdk-dev] [PATCH] kni: fix rte_kni_update_link

2019-01-28 Thread Ferruh Yigit
On 1/28/2019 1:49 PM, Igor Ryzhov wrote: > Hi again, > > Sorry for bothering, I should have done more testing. It works as it is now. > So, self NACK on the patch. Thanks for the update Igor. Since the file is pseudo-file, sysfs, I would expect no seek operation should be required, your update c

[dpdk-dev] [PATCH] net/mlx5: fix concurrent use of Tx offloads

2019-01-28 Thread Dekel Peled
Original patch implemented the use of match_metadata offload in the different burst functions. The concurrent use of match_metadata and multi_segs offloads was not handled. This patch updates function txq_scatter_v(), to pass metadata value from mbuf to wqe, when indicated by offload flags. Fixes

Re: [dpdk-dev] [PATCH] kni: fix rte_kni_update_link

2019-01-28 Thread Igor Ryzhov
Hi again, Sorry for bothering, I should have done more testing. It works as it is now. So, self NACK on the patch. Best regards, Igor On Mon, Jan 28, 2019 at 2:45 PM Igor Ryzhov wrote: > Hi Ferruh, > > Can you, please, take a look at this patch? > The current implementation is broken, I think

Re: [dpdk-dev] [PATCH v3 2/5] ring: add a non-blocking implementation

2019-01-28 Thread Ola Liljedahl
On Mon, 2019-01-28 at 13:34 +, Jerin Jacob Kollanukkaran wrote: > On Fri, 2019-01-25 at 17:21 +, Eads, Gage wrote: > > > > > > > > -Original Message- > > > From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > > > Sent: Wednesday, January 23, 2019 4:16 AM > > > To: Eads, Gage ; dev

Re: [dpdk-dev] [PATCH v3 2/5] ring: add a non-blocking implementation

2019-01-28 Thread Jerin Jacob Kollanukkaran
On Fri, 2019-01-25 at 17:21 +, Eads, Gage wrote: > > -Original Message- > > From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > > Sent: Wednesday, January 23, 2019 4:16 AM > > To: Eads, Gage ; dev@dpdk.org > > Cc: olivier.m...@6wind.com; step...@networkplumber.org; nd > > ; Richardson,

Re: [dpdk-dev] [EXT] Re: [PATCH v3 0/5] Add non-blocking ring

2019-01-28 Thread Jerin Jacob Kollanukkaran
On Wed, 2019-01-23 at 16:29 +, Ola Liljedahl wrote: > External Email > > --- > --- > On Wed, 2019-01-23 at 16:02 +, Jerin Jacob Kollanukkaran wrote: > > On Tue, 2019-01-22 at 09:27 +, Ola Liljedahl wrote: > > > On Fri, 201

[dpdk-dev] maintainers: resign from maintainership of link bonding

2019-01-28 Thread Declan Doherty
I've been unable to dedicate enough time to actively help in the maintainership of the link bonding PMD, and as Chas is now actively maintaining this PMD, I'm removing my name against it in the MAINTAINERS file. Signed-off-by: Declan Doherty --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-)

Re: [dpdk-dev] [EXT] Default cacheline size for ARM

2019-01-28 Thread Jerin Jacob Kollanukkaran
On Wed, 2019-01-23 at 16:28 +, Honnappa Nagarahalli wrote: > > On Fri, 2019-01-18 at 05:50 +, Honnappa Nagarahalli wrote: > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > The cacheline size (RTE_CACHE_LINE_SIZE) for ARM > > > > > > > > > > CPUs is > > > > > > > > > > set to

[dpdk-dev] [RFC] lfring: lock-free ring buffer

2019-01-28 Thread Ola Liljedahl
Lock-free MP/MC ring buffer with SP/SC options. The ring buffer metadata only maintains one set of head and tail pointers. Tail is updated on enqueue, head is updated on dequeue. The ring slots between head and tail always contains valid (unconsumed) slots. Each ring slot consists of a struct of da

Re: [dpdk-dev] [PATCH] kni: fix rte_kni_update_link

2019-01-28 Thread Igor Ryzhov
Hi Ferruh, Can you, please, take a look at this patch? The current implementation is broken, I think the patch should be merged into 19.02 and 18.11.1. Best regards, Igor On Thu, Jan 24, 2019 at 11:47 PM Igor Ryzhov wrote: > After read, file offset must be set to 0 before write. > Otherwise, t

[dpdk-dev] [PATCH] doc: deprecation notice for sched changes

2019-01-28 Thread Reshma Pattan
From: Jasvinder Singh Add deprecation note for making changes in data structures, APIs and macros in order to increase the traffic classes, flexible mapping of pipe queues to traffic classes, subport level configuration of pipes, queues sizes, etc. Signed-off-by: Jasvinder Singh Cc: Cristian Du

Re: [dpdk-dev] [PATCH v3 0/5] Add non-blocking ring

2019-01-28 Thread Ola Liljedahl
On Fri, 2019-01-25 at 17:56 +, Eads, Gage wrote: > > > > > -Original Message- > > From: Eads, Gage > > Sent: Friday, January 25, 2019 11:43 AM > > To: 'Honnappa Nagarahalli' ; dev@dpdk.org > > Cc: olivier.m...@6wind.com; arybche...@solarflare.com; Richardson, Bruce > > ; Ananyev, Kons

Re: [dpdk-dev] [PATCH v3 2/5] ring: add a non-blocking implementation

2019-01-28 Thread Ola Liljedahl
On Fri, 2019-01-25 at 17:21 +, Eads, Gage wrote: > > > > > -Original Message- > > From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > > Sent: Wednesday, January 23, 2019 4:16 AM > > To: Eads, Gage ; dev@dpdk.org > > Cc: olivier.m...@6wind.com; step...@networkplumber.org; nd > > ; Ric

Re: [dpdk-dev] [RFC] pci: force address of mappings in secondary process

2019-01-28 Thread Burakov, Anatoly
On 23-Jan-19 8:37 PM, Stephen Hemminger wrote: On Wed, 23 Jan 2019 19:21:03 + Ferruh Yigit wrote: On 7/12/2017 9:58 AM, jianfeng.tan at intel.com (Tan, Jianfeng) wrote: -Original Message- From: Gonzalez Monroy, Sergio Sent: Wednesday, July 12, 2017 3:32 PM To: Tan, Jianfeng; Steph

[dpdk-dev] [PATCH] net/ice: enable VLAN filter offloads support

2019-01-28 Thread Wei Zhao
There is need to check whether dev_conf.rxmode.offloads is set when start ice device, if one of the vlan related bits is set, for example DEV_RX_OFFLOAD_VLAN_FILTER and so on, sevice start process to enable this offloads request. Signed-off-by: Wei Zhao --- drivers/net/ice/ice_ethdev.c | 10