[dpdk-dev] [PATCH] doc: announce change of rte service API parameter type

2019-01-21 Thread Nikhil Rao
rte_service_attr_get() is passed a uint32_t * to retrieve an attribute value, this will be changed to uin64_t * as per patch posted at http://patchwork.dpdk.org/patch/49968/ Signed-off-by: Nikhil Rao --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/

Re: [dpdk-dev] [PATCH v2] igb_uio: remove out-of-date comment

2019-01-21 Thread Ye Xiaolong
Hi, Stephen On 01/17, Ye Xiaolong wrote: >On 01/16, Stephen Hemminger wrote: >>On Wed, 16 Jan 2019 15:48:36 +0800 >>Ye Xiaolong wrote: >> >>> Hi, Stephen >>> >>> On 01/15, Stephen Hemminger wrote: >>> >On Wed, 16 Jan 2019 08:34:52 +0800 >>> >Xiaolong Ye wrote: >>> > >>> >> The comment for igb

Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: fix compile

2019-01-21 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Monday, January 21, 2019 3:56 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com > Subject: [dpdk-dev] [PATCH v2] crypto/aesni_mb: fix compile > > This patch fixes the inflexible compile issue AES

Re: [dpdk-dev] rte_errno set to negative value to be fixed

2019-01-21 Thread Burakov, Anatoly
On 21-Jan-19 4:26 PM, Andrew Rybchenko wrote: Hi all, there are a number of cases where rte_errno is obviously set to negative value. I think it should be fixed. Regards, Andrew. +1 -- Thanks, Anatoly

[dpdk-dev] rte_errno set to negative value to be fixed

2019-01-21 Thread Andrew Rybchenko
Hi all, there are a number of cases where rte_errno is obviously set to negative value. I think it should be fixed. Regards, Andrew. $ git grep 'rte_errno = -E' drivers/event/opdl/opdl_evdev.c:    rte_errno = -EINVAL; drivers/event/opdl/opdl_evdev.c:    rte_errno = -ED

Re: [dpdk-dev] dev Digest, Vol 231, Issue 6

2019-01-21 Thread Wiles, Keith
Please do not top post, your response should be inline with the text. > On Jan 21, 2019, at 10:11 AM, Anudeep Kumar wrote: > > Hi Keith, > > Thanks for replying, > > Now able to run l3fwd application, > > But once we run l3fwd application, able to send packets using pktgen, > > but if we pi

[dpdk-dev] [PATCH] ethdev: fix errno to have positive value

2019-01-21 Thread Andrew Rybchenko
rte_errno should be set to positive value from errno.h plus few RTE-specific values. Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation") Fixes: 439a90b5f2a7 ("ethdev: reorder inline functions") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- lib/librte_ethdev/rte_ethdev.h | 4 ++-- 1 fil

Re: [dpdk-dev] dev Digest, Vol 231, Issue 6

2019-01-21 Thread Anudeep Kumar
Hi Keith, Thanks for replying, Now able to run l3fwd application, But once we run l3fwd application, able to send packets using pktgen, but if we ping packets unable to reach destination. Why this issue ? Is there any method to ping the Packets to destination? Regards, Anudeep On Mon, Jan 2

Re: [dpdk-dev] dev Digest, Vol 231, Issue 6

2019-01-21 Thread Wiles, Keith
> On Jan 21, 2019, at 7:23 AM, Anudeep Kumar wrote: > > Hi, > > I am unable to run l3fwd in dpdk. Please provide steps to run. > > Regards, > Anudeep > > On Mon, Jan 21, 2019, 18:49 Please provide much more information as to what the problem is here. DPDK version used? What do you mean

[dpdk-dev] [PATCH v2] crypto/aesni_mb: fix compile

2019-01-21 Thread Fan Zhang
This patch fixes the inflexible compile issue AESNI-MB PMD. Originally the compile of the PMD will fail if IPSec_MB is not installed in default location. Fixes: c68d7aa354f6 ("crypto/aesni_mb: use architecture independent macros") Signed-off-by: Fan Zhang Acked-by: Pablo de Lara --- v2: - uses

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vfio: allow secondary process to query IOMMU type

2019-01-21 Thread Thomas Monjalon
21/01/2019 11:29, Stojaczyk, Dariusz: > > It is only possible to know IOMMU type of a given VFIO container > > by attempting to initialize it. Since secondary process never > > attempts to set up VFIO container itself (because they're shared > > between primary and secondary), it never knows which

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2019-01-21 Thread Thomas Monjalon
21/01/2019 14:39, Burakov, Anatoly: > On 21-Jan-19 1:18 PM, Hu, Xuekun wrote: > > > >> You might also want to look here: https://bugs.dpdk.org/show_bug.cgi?id=76 > > > >> There are apparently issues with some kernel versions that will manifest > >> themselves as problems with using VF devices wi

Re: [dpdk-dev] [PATCH 1/6] ring: change head and tail to pointer-width size

2019-01-21 Thread Burakov, Anatoly
On 11-Jan-19 7:27 PM, Eads, Gage wrote: -Original Message- From: Richardson, Bruce Sent: Friday, January 11, 2019 5:59 AM To: Burakov, Anatoly Cc: Eads, Gage ; dev@dpdk.org; olivier.m...@6wind.com; arybche...@solarflare.com; Ananyev, Konstantin Subject: Re: [dpdk-dev] [PATCH 1/6] rin

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2019-01-21 Thread Burakov, Anatoly
On 21-Jan-19 1:18 PM, Hu, Xuekun wrote: You might also want to look here: https://bugs.dpdk.org/show_bug.cgi?id=76 There are apparently issues with some kernel versions that will manifest themselves as problems with using VF devices with IOMMU in a VM. Thanks, Anatoly. By updating host ke

Re: [dpdk-dev] dev Digest, Vol 231, Issue 6

2019-01-21 Thread Anudeep Kumar
Hi, I am unable to run l3fwd in dpdk. Please provide steps to run. Regards, Anudeep On Mon, Jan 21, 2019, 18:49 Send dev mailing list submissions to > dev@dpdk.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://mails.dpdk.org/listinfo/dev > or, via email

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2019-01-21 Thread Hu, Xuekun
> You might also want to look here: https://bugs.dpdk.org/show_bug.cgi?id=76 > There are apparently issues with some kernel versions that will manifest > themselves as problems with using VF devices with IOMMU in a VM. Thanks, Anatoly. By updating host kernel to 4.18, the issue is gone. 😊

Re: [dpdk-dev] [PATCH] vhost: fix possible out of bound access for indirect descs

2019-01-21 Thread Maxime Coquelin
On 1/21/19 9:12 AM, Tiwei Bie wrote: Fix a possible out of bound access which may happen when handling indirect descs in split ring. Fixes: 1be4ebb1c464 ("vhost: support indirect descriptor in mergeable Rx") Cc: sta...@dpdk.org Reported-by: Haiyue Wang Signed-off-by: Tiwei Bie --- lib/li

Re: [dpdk-dev] [PATCH] service: fix parameter type

2019-01-21 Thread Van Haaren, Harry
> -Original Message- > From: Rao, Nikhil > Sent: Saturday, January 19, 2019 2:01 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Rao, Nikhil > Subject: [PATCH] service: fix parameter type > > The type of value parameter to rte_service_attr_get > should be uint64_t *, since the attributes

Re: [dpdk-dev] [PATCH] doc: add deprecation notice to remove rte meter color

2019-01-21 Thread Mohammad Abdul Awal
On 12/12/2018 16:38, Reshma Pattan wrote: Added deprecation notice to replace rte_meter_color with rte_color. Signed-off-by: Reshma Pattan Acked-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/d

[dpdk-dev] [PATCH v6 1/4] pipeline: support QinQ PPPoE encap

2019-01-21 Thread Nemanja Marjanovic
From: "Nemanja Marjanovic" Add support of QinQ PPPoE packet encapsulation action. Signed-off-by: Nemanja Marjanovic Acked-by: Cristian Dumitrescu --- v5:Removing footer from patch. v6:Added missing acks. --- lib/librte_pipeline/rte_table_action.c | 61 ++ lib/librte_pi

[dpdk-dev] [PATCH v6 2/4] examples/ip_pipeline: support QinQ PPPoE encap

2019-01-21 Thread Nemanja Marjanovic
From: "Nemanja Marjanovic" Add implementation of QinQ PPPoE packet encapsulation action. Signed-off-by: Nemanja Marjanovic Acked-by: Cristian Dumitrescu --- v5:Removing footer from patch. v6:Added missing acks. --- examples/ip_pipeline/cli.c | 46 -- 1 file

[dpdk-dev] [PATCH v6 4/4] net: add PPPoE ethertypes

2019-01-21 Thread Nemanja Marjanovic
From: "Nemanja Marjanovic" Add PPPoE ethertypes in to rte_ether.h. Signed-off-by: Nemanja Marjanovic Acked-by: Cristian Dumitrescu --- v5:Removing footer from patch. v6:Added missing acks. --- lib/librte_net/rte_ether.h | 2 ++ lib/librte_pipeline/rte_table_action.c | 2 -- 2 file

[dpdk-dev] [PATCH v6 3/4] net/softnic: support QinQ PPPoE encap

2019-01-21 Thread Nemanja Marjanovic
From: "Nemanja Marjanovic" Add implementation of QinQ PPPoE packet encapsulation action. Signed-off-by: Nemanja Marjanovic Acked-by: Cristian Dumitrescu --- v5:Removing footer from patch. v6:Added missing acks. --- drivers/net/softnic/rte_eth_softnic_cli.c | 44 ++- 1 file

Re: [dpdk-dev] [PATCH v2] drivers: fix to replace strcat with strncat

2019-01-21 Thread Parthasarathy, JananeeX M
>-Original Message- >From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Chaitanya Babu Talluri >Sent: Friday, January 18, 2019 8:54 PM >To: dev@dpdk.org >Cc: rm...@marvell.com; Pattan, Reshma ; >shsha...@marvell.com; Xing, Beilei ; Zhang, Qi Z >; alejandro.luc...@netronome.com; De Lara

Re: [dpdk-dev] [PATCH v2] vfio: allow secondary process to query IOMMU type

2019-01-21 Thread Stojaczyk, Dariusz
> -Original Message- > From: Burakov, Anatoly > Sent: Friday, January 18, 2019 11:25 AM > Subject: [PATCH v2] vfio: allow secondary process to query IOMMU type > > It is only possible to know IOMMU type of a given VFIO container > by attempting to initialize it. Since secondary process n

Re: [dpdk-dev] [PATCH v2] vfio: allow secondary process to query IOMMU type

2019-01-21 Thread Burakov, Anatoly
On 21-Jan-19 10:21 AM, Thomas Monjalon wrote: 21/01/2019 11:13, Burakov, Anatoly: On 19-Jan-19 3:23 AM, Wang, Xiao W wrote: Hi Anatoly, From: Burakov, Anatoly It is only possible to know IOMMU type of a given VFIO container by attempting to initialize it. Since secondary process never attemp

Re: [dpdk-dev] [PATCH v2] vfio: allow secondary process to query IOMMU type

2019-01-21 Thread Thomas Monjalon
21/01/2019 11:13, Burakov, Anatoly: > On 19-Jan-19 3:23 AM, Wang, Xiao W wrote: > > Hi Anatoly, > > > > From: Burakov, Anatoly > >> > >> It is only possible to know IOMMU type of a given VFIO container > >> by attempting to initialize it. Since secondary process never > >> attempts to set up VFIO

Re: [dpdk-dev] [PATCH v2] vfio: allow secondary process to query IOMMU type

2019-01-21 Thread Burakov, Anatoly
On 19-Jan-19 3:23 AM, Wang, Xiao W wrote: Hi Anatoly, -Original Message- From: Burakov, Anatoly Sent: Friday, January 18, 2019 6:25 PM To: dev@dpdk.org Cc: Wang, Xiao W ; Zhang, Qi Z ; qingfu@alibaba-inc.com; tho...@monjalon.net; Stojaczyk, Dariusz ; sta...@dpdk.org Subject: [PATCH

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix compile

2019-01-21 Thread Zhang, Roy Fan
Hi, Thanks guys. I will send a v2 to remove the backslash. Regards, Fan > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, January 18, 2019 11:56 AM > To: Thomas Monjalon > Cc: Zhang, Roy Fan ; dev@dpdk.org; > akhil.go...@nxp.com; De Lara Guarch, Pablo > > Subject: RE: [

[dpdk-dev] [PATCH v5 4/4] net: add PPPoE ethertypes

2019-01-21 Thread Nemanja Marjanovic
From: "Marjanovic,Nemanja" Add PPPoE ethertypes in to rte_ether.h. Signed-off-by: Nemanja Marjanovic --- v5:Removing footer from patch. --- lib/librte_net/rte_ether.h | 2 ++ lib/librte_pipeline/rte_table_action.c | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH v5 3/4] net/softnic: support QinQ PPPoE encap

2019-01-21 Thread Nemanja Marjanovic
From: "Marjanovic,Nemanja" Add implementation of QinQ PPPoE packet encapsulation action. Signed-off-by: Nemanja Marjanovic --- v5:Removing footer from patch. --- drivers/net/softnic/rte_eth_softnic_cli.c | 44 ++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v5 2/4] examples/ip_pipeline: support QinQ PPPoE encap

2019-01-21 Thread Nemanja Marjanovic
From: "Marjanovic,Nemanja" Add implementation of QinQ PPPoE packet encapsulation action. Signed-off-by: Nemanja Marjanovic --- v5:Removing footer from patch --- examples/ip_pipeline/cli.c | 46 -- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH v5 1/4] pipeline: support QinQ PPPoE encap

2019-01-21 Thread Nemanja Marjanovic
From: "Marjanovic,Nemanja" Add support of QinQ PPPoE packet encapsulation action. Signed-off-by: Nemanja Marjanovic --- v5:Removing footer from patch. --- lib/librte_pipeline/rte_table_action.c | 61 ++ lib/librte_pipeline/rte_table_action.h | 16 +++ 2 files change

[dpdk-dev] [PATCH] bus/ifpga: add a shared data structure to struct rte_afu_device

2019-01-21 Thread Andy Pei
Add a data structure rte_afu_shared to data structure rte_afu_device. Struct rte_afu_shared contains a rte_spinlock_t and a void pointer. This struct rte_afu_shared will be used in net/vbng. Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library") Cc: rosen...@intel.com Cc: sta...@dpdk.org S

Re: [dpdk-dev] [PATCH] vhost: fix possible out of bound access for indirect descs

2019-01-21 Thread Maxime Coquelin
On 1/21/19 9:12 AM, Tiwei Bie wrote: Fix a possible out of bound access which may happen when handling indirect descs in split ring. Fixes: 1be4ebb1c464 ("vhost: support indirect descriptor in mergeable Rx") Cc: sta...@dpdk.org Reported-by: Haiyue Wang Signed-off-by: Tiwei Bie --- lib/li

Re: [dpdk-dev] [PATCH v3] vhost: add external message handling callbacks to the public API

2019-01-21 Thread Maxime Coquelin
On 1/17/19 4:32 PM, Darek Stojaczyk wrote: External message callbacks are used e.g. by vhost crypto to parse crypto-specific vhost-user messages. We are now publishing the API to register those callbacks, so that other backends outside of DPDK can use them as well. Signed-off-by: Darek Stoja

[dpdk-dev] [PATCH] vhost: fix possible out of bound access for indirect descs

2019-01-21 Thread Tiwei Bie
Fix a possible out of bound access which may happen when handling indirect descs in split ring. Fixes: 1be4ebb1c464 ("vhost: support indirect descriptor in mergeable Rx") Cc: sta...@dpdk.org Reported-by: Haiyue Wang Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 8 ++-- 1 fil