[dpdk-dev] [PATCH v4 1/4] eal: fix clang compilation error on x86

From: Gavin Hu When CONFIG_RTE_FORCE_INTRINSICS is enabled for x86, the clang compilation error was: include/generic/rte_atomic.h:215:9: error: implicit declaration of function '__atomic_exchange_2' is invalid in C99 include/generic/rte_atomic.h:494

[dpdk-dev] [PATCH v4 2/4] test/spinlock: remove 1us delay for correct benchmarking

From: Gavin Hu The test is to benchmark the performance of spinlock by counting the number of spinlock acquire and release operations within the specified time. A typical pair of lock and unlock operations costs tens or hundreds of nano seconds, in comparison to this, delaying 1 us outside of the

[dpdk-dev] [PATCH v4 0/4] spinlock optimization and test case enhancements

V4: 1. Drop one patch for the test case to get time precisely as the overhead of getting time is amortized already in another patch. 2. Drop the ticket lock patch from this series as there are no dependency between them, the ticket lock patch was submitted separately: http://patchwork.dpd

[dpdk-dev] [PATCH v4 3/4] test/spinlock: amortize the cost of getting time

From: Gavin Hu Instead of getting timestamps per iteration, amortize its overhead can help getting more precise benchmarking results. Change-Id: I32642b181f883cd57bc1f7c4f56a4744b0438781 Signed-off-by: Gavin Hu Reviewed-by: Joyce Kong --- test/test/test_spinlock.c | 29 ---

[dpdk-dev] [PATCH v4 4/4] spinlock: reimplement with atomic one-way barrier builtins

From: Gavin Hu The __sync builtin based implementation generates full memory barriers ('dmb ish') on Arm platforms. Using C11 atomic builtins to generate one way barriers. Here is the assembly code of __sync_compare_and_swap builtin. __sync_bool_compare_and_swap(dst, exp, src); 0x0090

[dpdk-dev] [PATCH v1] net/i40e: support request any number of queues

Before this patch, VF must request a specific queues(1/2/4/8/16) with DPDK PF. This patch align the number of requested queues to next power of 2. So VF can request any number queues from 1 to 16. Signed-off-by: Zhirun Yan --- drivers/net/i40e/i40e_pf.c | 5 - 1 file changed, 4 insertions(+)

[dpdk-dev] [PATCH v2 1/2] vhost: fix memory leak on realloc failure

When realloc() fails, the original block isn't freed. Fixes: e246896178e6 ("vhost: get guest/host physical address mappings") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/l

[dpdk-dev] [PATCH v2 0/2] Fixes for realloc() in vhost

Tiwei Bie (2): vhost: fix memory leak on realloc failure examples/vhost: fix path allocation failure handling examples/vhost/main.c | 8 lib/librte_vhost/vhost_user.c | 3 +++ 2 files changed, 11 insertions(+) -- 2.17.1

[dpdk-dev] [PATCH v2 2/2] examples/vhost: fix path allocation failure handling

Add the missing failure handling for path allocation, as realloc() may fail. Fixes: ad0eef4d2203 ("examples/vhost: support multiple socket files") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- v2: - Improve the title and add some explanations (Thomas); examples

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

Hi, Ravi Did you resolve this issue that VF used in guest with vIOMMU enabled? I googled, but still can't get the answer that it is driver or qemu vt-d emulation issue. Currently I met the same issue again that host reported DMAR error: [59939.130110] DMAR: DRHD: handling fault status reg 2 [

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] examples/vhost: fix realloc failure

On Tue, Jan 15, 2019 at 02:56:39AM +0100, Thomas Monjalon wrote: > 14/01/2019 04:34, Tiwei Bie: > > Fixes: ad0eef4d2203 ("examples/vhost: support multiple socket files") > > Cc: sta...@dpdk.org > > Please add some explanations about what was wrong. My bad. Will do it in the next version. > > Ab

Re: [dpdk-dev] [PATCH v2] vhost: remove statement for non-existed function

On Tue, Jan 15, 2019 at 02:48:13PM +0800, Xiaolong Ye wrote: > vhost_user_host_notifier_ctrl is not existed anymore, its statement in > header file should be removed accordingly. > > Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl") > Cc: xiao.w.w...@intel.com > > Signed-off-by

[dpdk-dev] [PATCH v2] vhost: remove statement for non-existed function

vhost_user_host_notifier_ctrl is not existed anymore, its statement in header file should be removed accordingly. Fixes: 43f34e35663f ("vhost: provide helper for host notifier ctrl") Cc: xiao.w.w...@intel.com Signed-off-by: Xiaolong Ye --- lib/librte_vhost/vhost_user.h | 1 - 1 file changed, 1

Re: [dpdk-dev] [PATCH v2] net/virtio: add platform memory ordering feature support

Thursday, January 10, 2019 10:37 PM, Shahaf Shuler: > Subject: RE: [dpdk-dev] [PATCH v2] net/virtio: add platform memory > ordering feature support > > Wednesday, January 9, 2019 5:50 PM, Michael S. Tsirkin: > > alejandro.luc...@netronome.com; Daniel Marcovitch > > > > Subject: Re: [dpdk-dev] [PA

[dpdk-dev] [DPDK] [PATCH v4] raw/ifpga: fix a typo and delete code of unused function

fix a typo and delete code of unused function Fixes: 88c9eb7cb4b5 (\"fix a typo and delete code of unused function\") Cc: andy@intel.com Cc: rosen...@intel.com Cc: tianfei.zh...@intel.com Signed-off-by: Andy Pei --- drivers/raw/ifpga_rawdev/base/opae_hw_api.c | 24 +---

Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

Tested-by: Yinan Wang Best Wishes, Yinan -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jiayu Hu Sent: 2019年1月10日 23:06 To: dev@dpdk.org Cc: Ananyev, Konstantin ; tho...@monjalon.net; Hu, Jiayu ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v2] gro: add missing i

Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, January 15, 2019 9:00 AM > To: Hu, Jiayu > Cc: dev@dpdk.org; Ananyev, Konstantin ; > tho...@monjalon.net; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] gro: add missing invalid pac

Re: [dpdk-dev] [PATCH] vhost: fix deadlock when vhost unregister.

Hi, On 01/11, sunwenjie wrote: >When rte_vhost_driver_unregister delete the connection fd, >fdset_try_del will always try and donot release the >vhostuser.mutex if the fd is busy, but the fdset_event_dispatch >will set the fd to busy and call vhost_user_msg_handler to get >vh

[dpdk-dev] [PATCH v2] net/i40e: fix FPK VF overwrite PF RSS LUT

i40e_aq_set_rss_lut should set rigister according to the vsi->type. if not, VF may overwrite the rigister of PF Fixes: d0a349409bd7 ("i40e: support AQ based RSS config") Cc: sta...@dpdk.org Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_ethdev.c | 6 -- 1 file changed, 4 insertions(+)

[dpdk-dev] [dpdk-announce] release candidate 19.02-rc2

A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v19.02-rc2 Less than 200 patches were integrated. The release notes were updated: http://doc.dpdk.org/guides/rel_notes/release_19_02.html Some highlights of 19.02-rc2: - new library for I

Re: [dpdk-dev] [PATCH] net/i40e: fix FPK VF overwrite PF RSS LUT

Hi qi, -Original Message- From: Zhang, Qi Z Sent: Monday, January 14, 2019 8:48 PM To: Wu, Yanglong ; dev@dpdk.org Cc: Hall, Ryan E ; sta...@dpdk.org Subject: RE: [PATCH] net/i40e: fix FPK VF overwrite PF RSS LUT > -Original Message- > From: Wu, Yanglong > Sent: Monday, January

Re: [dpdk-dev] [PATCH 3/6] net/tap: check interface name in kvargs

11/01/2019 20:50, Wiles, Keith: > > > On Jan 11, 2019, at 1:49 PM, Stephen Hemminger > > wrote: > > > > On Fri, 11 Jan 2019 19:37:00 + > > "Wiles, Keith" wrote: > > > >>> +/* make sure name is a possible Linux network device name */ > >>> +static bool is_valid_iface(const char *name) >

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] examples/vhost: fix realloc failure

14/01/2019 04:34, Tiwei Bie: > Fixes: ad0eef4d2203 ("examples/vhost: support multiple socket files") > Cc: sta...@dpdk.org Please add some explanations about what was wrong. About the title, do you mean "fix path allocation failure handling" ?

Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

14/01/2019 15:21, Bruce Richardson: > On Mon, Jan 14, 2019 at 06:04:35AM +, Chaitanya Babu Talluri wrote: > > Strcat does not check the destination length and there might be > > chances of string overflow so insted of strcat, strncat is used. [...] > > While I believe this is correct, this (an

Re: [dpdk-dev] [PATCH] examples/vhost: fix a typo

14/01/2019 16:37, Gavin Hu (Arm Technology China): > > > -Original Message- > > From: dev On Behalf Of Rami Rosen > > Sent: Monday, January 14, 2019 10:48 PM > > To: dev@dpdk.org > > Cc: maxime.coque...@redhat.com; huawei@intel.com; > > tiwei@intel.com; Rami Rosen > > Subject: [d

Re: [dpdk-dev] [PATCH v2] doc: fix a typo in programmer's guide

07/01/2019 10:10, Yong Wang: > This patch fixes a typo in programmer's guide. It should be Frequency, > not Fequence. > > Fixes: 450f0791312c ("power: add traffic pattern aware power control") > > Signed-off-by: Yong Wang Applied, thanks

Re: [dpdk-dev] [PATCH v5 1/2] mbuf: add function returning buffer address

14/01/2019 22:16, Yongseok Koh: > This patch introduces two new functions - rte_mbuf_buf_addr() and > rte_mbuf_data_addr_default(). > > rte_mbuf_buf_addr() reutrns the buffer address of given mbuf which comes > after mbuf structure and private data. > > rte_mbuf_data_addr_default() returns the de

Re: [dpdk-dev] [PATCH v2 0/3] segment sanity checks

07/01/2019 09:57, David Marchand: > Resubmitting this series that I did not finish in my previous life (6WIND > people are okay with this). > > Here is a little series which helped me identify a multi segment issue. > Hope it can help others. > > The difference since the RFC patches I sent some t

Re: [dpdk-dev] [PATCH v1 0/8] Clean up rte_option

20/12/2018 18:06, Gaetan Rivet: > rte_option lib might benefit from a few improvements. > > Overview: > > - list registered options on /rte/app --help > - check duplicates within base EAL options > - rename some fields to be closer to standard struct option > and just cleaner overall. >

Re: [dpdk-dev] [PATCH v2] gro: add missing invalid packet checks

On Thu, 10 Jan 2019 23:06:08 +0800 Jiayu Hu wrote: > + > +#define ILLEGAL_ETHER_HDRLEN(len) ((len) != ETHER_HDR_LEN) > +#define ILLEGAL_ETHER_VXLAN_HDRLEN(len) \ > + ((len) != (ETHER_VXLAN_HLEN + ETHER_HDR_LEN)) > +#define ILLEGAL_IPV4_HDRLEN(len) ((len) != sizeof(struct ipv4_hdr)) > +#define

Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup

11/01/2019 18:51, Reshma Pattan: > Virtual devices added in pdump application > using rte_eal_hotplug_add should be removed explicitly > while existing the pdump application, otherwise the existing -> exiting ? > subsequent run of the pdump application will fail with the reason > that virtual dev

Re: [dpdk-dev] [PATCH] examples/tep_term: remove MAX_PRINT_BUFF

13/01/2019 16:02, Rami Rosen: > The definition of MAX_PRINT_BUFF in examples/tep_termination/main.c > is not necessary as it is not used. This cleanup patch removes it. > > Fixes: a50245ede72a ("examples/tep_term: initialize VXLAN sample") > Cc: sta...@dpdk.org > > Signed-off-by: Rami Rosen A

Re: [dpdk-dev] [PATCH v2] examples/ip_fragmentation: support big packets

14/01/2019 13:55, Ananyev, Konstantin: > > > > In some vendors the RX and TX configuration must be the same, therefore > > the MTU size need to be equal to max_rx_pkt_len. > > The MTU is the largest size packet in bytes that can be sent on the > > network, therefore before changing this parameter,

Re: [dpdk-dev] [PATCH v3]/driver/raw/ifpga_rawdev: fix a memory leak bug in ifpga

Hi Andy, I comment here for all your patches (4 are pending). They are your first patches for DPDK, welcome! You may want to read the guides explaining how to contribute: http://doc.dpdk.org/guides/contributing/patches.html The title should be "raw/ifpga: fix memory leak in [area here]"

Re: [dpdk-dev] [PATCH v1] ticketlock: ticket based to improve fairness

> Subject: [PATCH v1] ticketlock: ticket based to improve fairness > > From: Joyce Kong > > The spinlock implementation is unfair, some threads may take locks > aggressively while leaving the other threads starving for long time. As shown > in the following test, within same period of time, ther

Re: [dpdk-dev] [PATCH v2] test/hash: reset iter and found in perf test

14/01/2019 10:23, Dharmik Thakkar: > Reset 'iter' and 'tbl_rw_test_param.found' on each iteration > to give correct result for lost and duplicated keys. > > This patch also changes the default return value of the test to -1 > when not enough resources are provided. > > Fixes: 0eb3726ebcf14 ("test

Re: [dpdk-dev] [PATCH] examples/power: fix wrong core_id with JSON cmds

> > >> This patch fixes a bug introduced in the 64-core limtation > > >> enhancement where the core_id is inadvertently converted from > > >> virtual to physical even though it may already be a physical > > >> core_id. > > >> > > >> We should be using the core_type field, and only converting via >

Re: [dpdk-dev] [PATCH] examples/power: fix intel pstate power manager

08/01/2019 16:25, David Hunt: > The vm_power_manager starts by setting the environment to acpi > using rte_power_set_env(PM_ENV_ACPI_CPUFREQ). This causes a problem > starting vm_power_manager when the system is using the intel_pstate > driver. The env should be set to none, or not called at all, b

Re: [dpdk-dev] [PATCH] test/power: fix unit test to handle pstate mode

07/01/2019 15:40, David Hunt: > The cpufreq test breakes when the system is using the intel_pstate > driver for frequency management. The power library has recentyly been > updated to allow use of the intel_pstate driver, this patch fixes the > cpufreq test so that it can now use either acpi or pst

Re: [dpdk-dev] [PATCH] lib/power: fix return code to unsigned value

07/01/2019 15:40, David Hunt: > The power_pstate_cpufreq_freqs() function was returning -1 in an > unsigned int, causing buffer over-runs when the results were being > processed. This function should be returning zero for all error > conditions, similar to it's acpi relation, power_acpi_cpufreq_fre

Re: [dpdk-dev] [PATCH] lib/power: fix freq list function to handle null

07/01/2019 15:39, David Hunt: > This patch fixes a segfault in the case where a null buffer is passed > to the following functions: >power_acpi_cpufreq_freqs() >power_pstate_cpufreq_freqs() > > Fixes: 445c6528b55f ("power: common interface for guest and host") > > Signed-off-by: David Hun

Re: [dpdk-dev] [PATCH] lib/power: fix error handling on setting governor

08/01/2019 15:59, David Hunt: > In the power_set_governor_*() functions, we using fputs() on /sys > filesystem. However, we also need to call fflush() to ensure that > the write completes successfully. Otherwise the attempt to set the > power governor fails and the function returns as if it has > s

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] lib/efd: fix to free tail queue entry after use

> > Any review please? > > 11/01/2019 12:49, Hari Kumar Vemula: > > In rte_efd_create() allocated memory for tail queue entry but not > > freed. > > Added freeing the tail queue entry. > > > > Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") > > Cc: sta...@dpdk.org > > > > Signed

Re: [dpdk-dev] [PATCH] libs/power: fix the resource leaking issue

28/12/2018 12:32, Liang Ma: > Fixes: e6c6dc0f96c8 ("power: add p-state driver compatibility") > Coverity issue: 328528 > > Also add the missing functionality of enable/disable turbo If you are changing two things, you probably need to split in two patches. In 19.02 timeframe, we will get only the

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] lib/efd: fix to free tail queue entry after use

Any review please? 11/01/2019 12:49, Hari Kumar Vemula: > In rte_efd_create() allocated memory for tail queue entry but > not freed. > Added freeing the tail queue entry. > > Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") > Cc: sta...@dpdk.org > > Signed-off-by: Hari Kumar Vem

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] gro: add missing invalid packet checks

Any review, please? 10/01/2019 16:06, Jiayu Hu: > Currently, GRO library doesn't check if input packets have > invalid headers. The packets with invalid headers will also > be processed by GRO. > > However, GRO shouldn't process invalid packets. This patch adds > missing invalid packet checks. >

Re: [dpdk-dev] [dpdk-stable] [PATCH] drivers: fix sprintf with snprintf

09/01/2019 15:47, Akhil Goyal: > On 1/7/2019 4:16 PM, Pallantla Poornima wrote: > > sprintf function is not secure as it doesn't check the length of string. > > More secure function snprintf is used > > > > Fixes: 828d51d8fc ("bus/fslmc: refactor scan and probe functions") > > Fixes: c22fab9a6c ("r

Re: [dpdk-dev] [PATCH] ipsec: fix compilation problem

14/01/2019 16:58, Konstantin Ananyev: > gcc 6.2 and 6.4 fails to compile lib/librte_ipsec/sa.c > with the following errors: > /local/kananye1/dpdk.org/lib/librte_ipsec/sa.c: > In function âinline_outb_tun_pkt_processâ: > dpdk.org/x86_64-native-linuxapp-gcc/include/rte_memcpy.h:337:2: > error: ar

[dpdk-dev] [PATCH v5 2/2] net/mlx5: fix instruction hotspot on replenishing Rx buffer

On replenishing Rx buffers for vectorized Rx, mbuf->buf_addr isn't needed to be accessed as it is static and easily calculated from the mbuf address. Accessing the mbuf content causes unnecessary load stall and it is worsened on ARM. Fixes: 545b884b1da3 ("net/mlx5: fix buffer address posting in SS

[dpdk-dev] [PATCH v5 1/2] mbuf: add function returning buffer address

This patch introduces two new functions - rte_mbuf_buf_addr() and rte_mbuf_data_addr_default(). rte_mbuf_buf_addr() reutrns the buffer address of given mbuf which comes after mbuf structure and private data. rte_mbuf_data_addr_default() returns the default address of mbuf data taking the headroom

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

On Mon, Jan 14, 2019 at 6:54 PM Thomas Monjalon wrote: > 14/01/2019 19:29, Alejandro Lucero: > > On Mon, Jan 14, 2019 at 6:22 PM Ferruh Yigit > wrote: > > > > > On 1/14/2019 6:00 PM, Alejandro Lucero wrote: > > > > > > > > > > > > On Mon, Jan 14, 2019 at 10:40 AM Ferruh Yigit < > ferruh.yi...@in

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix build of external apps with clang on armv8

14/01/2019 19:49, Thomas Monjalon: > 14/01/2019 17:27, Thomas Monjalon: > > 14/01/2019 17:14, Ilya Maximets: > > > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > > > But 'rte_atomic.h' is a generic header that included to the > > > external apps like OVS while building with DPD

Re: [dpdk-dev] [PATCH] config: remove NFP PMD from 32-bits builds

14/01/2019 19:12, Alejandro Lucero: > Signed-off-by: Alejandro Lucero > --- > config/defconfig_i686-native-linuxapp-gcc| 5 + > config/defconfig_i686-native-linuxapp-icc| 5 + > config/defconfig_x86_x32-native-linuxapp-gcc | 5 + > 3 files changed, 15 insertions(+) You forgot

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

14/01/2019 19:29, Alejandro Lucero: > On Mon, Jan 14, 2019 at 6:22 PM Ferruh Yigit wrote: > > > On 1/14/2019 6:00 PM, Alejandro Lucero wrote: > > > > > > > > > On Mon, Jan 14, 2019 at 10:40 AM Ferruh Yigit > > > wrote: > > > > > > On 1/13/2019 9:41 PM, Thomas M

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix build of external apps with clang on armv8

14/01/2019 17:27, Thomas Monjalon: > 14/01/2019 17:14, Ilya Maximets: > > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > > But 'rte_atomic.h' is a generic header that included to the > > external apps like OVS while building with DPDK. As a result, > > clang build of OVS fails

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

14/01/2019 17:50, Honnappa Nagarahalli: > > > > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > > But 'rte_atomic.h' is a generic header that included to the external apps > > like > > OVS while building with DPDK. As a result, clang build of OVS fails on ARMv8 >

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

On Mon, Jan 14, 2019 at 6:22 PM Ferruh Yigit wrote: > On 1/14/2019 6:00 PM, Alejandro Lucero wrote: > > > > > > On Mon, Jan 14, 2019 at 10:40 AM Ferruh Yigit > > wrote: > > > > On 1/13/2019 9:41 PM, Thomas Monjalon wrote: > > > 11/01/2019 17:42, Ferruh Yigi

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

On 1/14/2019 6:00 PM, Alejandro Lucero wrote: > > > On Mon, Jan 14, 2019 at 10:40 AM Ferruh Yigit > wrote: > > On 1/13/2019 9:41 PM, Thomas Monjalon wrote: > > 11/01/2019 17:42, Ferruh Yigit: > >> On 1/11/2019 1:25 PM, Alejandro Lucero wrote: > >>>

[dpdk-dev] [PATCH] config: remove NFP PMD from 32-bits builds

Signed-off-by: Alejandro Lucero --- config/defconfig_i686-native-linuxapp-gcc| 5 + config/defconfig_i686-native-linuxapp-icc| 5 + config/defconfig_x86_x32-native-linuxapp-gcc | 5 + 3 files changed, 15 insertions(+) diff --git a/config/defconfig_i686-native-linuxapp-gcc b/

Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service

On Mon, Jan 14, 2019 at 10:40 AM Ferruh Yigit wrote: > On 1/13/2019 9:41 PM, Thomas Monjalon wrote: > > 11/01/2019 17:42, Ferruh Yigit: > >> On 1/11/2019 1:25 PM, Alejandro Lucero wrote: > >>> The Netronome's Network Flow Processor chip is highly programmable > >>> with the goal of processing pac

Re: [dpdk-dev] TX unable to enqueue packets to NIC due to no free TX descriptor

I doubled the mempool size to 65535 but the issue is not resolved. On 1/11/19, 4:27 PM, "dev on behalf of Soni, Shivam" wrote: Hi Stephen, Thanks for the reply. Our mbuf pool is big enough. We have 2 RX cores, 2 TX cores and 8 worker cores. NTxd and NRxd is 1024 each

Re: [dpdk-dev] [EXT] [PATCH v3 5/6] spinlock: reimplement with atomic one-way barrier builtins

> > > > > *sl); static > > > > > inline void rte_spinlock_lock(rte_spinlock_t *sl) { > > > > > - while (__sync_lock_test_and_set(&sl->locked, 1)) > > > > > - while(sl->locked) > > > > > + int exp = 0; > > > > > + > > > > > + while (!__atomic_compare_exchange_n(&sl->locked

Re: [dpdk-dev] [EXT] [PATCH v1] ticketlock: ticket based to improve fairness

> -Original Message- > From: Jerin Jacob Kollanukkaran > Sent: Monday, January 14, 2019 4:00 PM > To: Gavin Hu (Arm Technology China) ; > dev@dpdk.org > Cc: step...@networkplumber.org; Honnappa Nagarahalli > ; tho...@monjalon.net; nd > ; Joyce Kong (Arm Technology China) > ; hemant.agra.

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

> > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > But 'rte_atomic.h' is a generic header that included to the external apps like > OVS while building with DPDK. As a result, clang build of OVS fails on ARMv8

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ilya Maximets > Sent: Monday, January 14, 2019 4:15 PM > To: dev@dpdk.org; Thomas Monjalon > Cc: Pavan Nikhilesh ; Ilya Maximets > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] eal: fix build of external apps w

Re: [dpdk-dev] [PATCH 0/2] net/enic: two trivial fixes

On 1/14/2019 3:01 PM, Hyong Youb Kim wrote: > Hyong Youb Kim (2): > net/enic: remove useless include > net/enic: remove redundant log level check Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v5] mk: fix scope of disabling AVX512F support

14/01/2019 16:49, Ferruh Yigit: > AVX512 was disabled for GCC because of Bugzilla issue 97 [1], > the GCC defect submitted for the issue [2] highlighted that this is > a known binutils version 2.30 issue. > > Narrowed the scope of no-avx512 to the this specific binutils version. > > [1] > https:/

Re: [dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

14/01/2019 17:14, Ilya Maximets: > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. > But 'rte_atomic.h' is a generic header that included to the > external apps like OVS while building with DPDK. As a result, > clang build of OVS fails on ARMv8 if DPDK built using gcc: > > in

Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

On Mon, 14 Jan 2019 13:29:38 + Ferruh Yigit wrote: > On 1/14/2019 6:04 AM, Chaitanya Babu Talluri wrote: > > Strcat does not check the destination length and there might be > > chances of string overflow so insted of strcat, strncat is used. > > > > Fixes: 540a211084 ("bnx2x: driver core") >

Re: [dpdk-dev] [PATCH 2/3] mempool/nb_stack: add non-blocking stack mempool

> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Sunday, January 13, 2019 7:31 AM > To: Eads, Gage ; dev@dpdk.org > Cc: olivier.m...@6wind.com; Richardson, Bruce ; > Ananyev, Konstantin > Subject: Re: [PATCH 2/3] mempool/nb_stack: add non-blocking

[dpdk-dev] [PATCH] eal: fix build of external apps with clang on armv8

In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined. But 'rte_atomic.h' is a generic header that included to the external apps like OVS while building with DPDK. As a result, clang build of OVS fails on ARMv8 if DPDK built using gcc: include/generic/rte_atomic.h:215:9: error:

Re: [dpdk-dev] [PATCH] doc: update description in qat compression guide

> -Original Message- > From: Jozwiak, TomaszX > Sent: Monday, January 14, 2019 3:11 PM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > ; De Lara Guarch, Pablo > > Subject: [PATCH] doc: update description in qat compression guide > > Added limitations description for the QAT comp

[dpdk-dev] [PATCH] ipsec: fix compilation problem

gcc 6.2 and 6.4 fails to compile lib/librte_ipsec/sa.c with the following errors: /local/kananye1/dpdk.org/lib/librte_ipsec/sa.c: In function âinline_outb_tun_pkt_processâ: dpdk.org/x86_64-native-linuxapp-gcc/include/rte_memcpy.h:337:2: error: array subscript is above array bounds [-Werror=array

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: add function returning default buffer address

Hi, On Fri, Jan 11, 2019 at 01:48:12PM +0100, David Marchand wrote: > On Fri, Jan 11, 2019 at 12:57 PM Bruce Richardson < > bruce.richard...@intel.com> wrote: > > > On Fri, Jan 11, 2019 at 02:17:04PM +0300, Andrew Rybchenko wrote: > > > Olivier, David, > > > > > > could you take a look at naming

[dpdk-dev] [PATCH v5] mk: fix scope of disabling AVX512F support

AVX512 was disabled for GCC because of Bugzilla issue 97 [1], the GCC defect submitted for the issue [2] highlighted that this is a known binutils version 2.30 issue. Narrowed the scope of no-avx512 to the this specific binutils version. [1] https://bugs.dpdk.org/show_bug.cgi?id=97 [2] https://g

Re: [dpdk-dev] [PATCH 1/3] eal: add 128-bit cmpset (x86-64 only)

> -Original Message- > From: Varghese, Vipin > Sent: Sunday, January 13, 2019 10:29 PM > To: Andrew Rybchenko ; Eads, Gage > ; dev@dpdk.org > Cc: olivier.m...@6wind.com; Richardson, Bruce ; > Ananyev, Konstantin > Subject: RE: [dpdk-dev] [PATCH 1/3] eal: add 128-bit cmpset (x86-64 only)

Re: [dpdk-dev] [PATCH 1/3] eal: add 128-bit cmpset (x86-64 only)

From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Sunday, January 13, 2019 6:19 AM To: Eads, Gage ; dev@dpdk.org Cc: olivier.m...@6wind.com; Richardson, Bruce ; Ananyev, Konstantin Subject: Re: [PATCH 1/3] eal: add 128-bit cmpset (x86-64 only) On 1/10/19 11:55 PM, Gage Eads wrote

Re: [dpdk-dev] [PATCH 1/2] mbuf: remove deprecated macro

14/01/2019 16:23, Olivier Matz: > On Mon, Jan 14, 2019 at 10:50:50AM +0100, Thomas Monjalon wrote: > > 14/01/2019 08:40, Andrew Rybchenko: > > > On 1/14/19 8:20 AM, Yongseok Koh wrote: > > > > RTE_MBUF_INDIRECT() is replaced with RTE_MBUF_CLONED() and removed. > > > > This macro was deprecated in r

Re: [dpdk-dev] [PATCH] examples/vhost: fix a typo

> -Original Message- > From: dev On Behalf Of Rami Rosen > Sent: Monday, January 14, 2019 10:48 PM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; huawei@intel.com; > tiwei@intel.com; Rami Rosen > Subject: [dpdk-dev] [PATCH] examples/vhost: fix a typo > > This minor patch

Re: [dpdk-dev] [PATCH v3] mbuf: fix compile by making sched struct visible

14/01/2019 15:58, Olivier Matz: > On Fri, Jan 11, 2019 at 02:33:16PM +, Dumitrescu, Cristian wrote: > > From: Van Haaren, Harry > > > > > > Although C compilation works with the struct rte_mbuf_sched > > > declared inside the struct rte_mbuf namespace, C++ fails to > > > compile. This fix move

Re: [dpdk-dev] [PATCH 1/2] mbuf: remove deprecated macro

On Mon, Jan 14, 2019 at 10:50:50AM +0100, Thomas Monjalon wrote: > 14/01/2019 08:40, Andrew Rybchenko: > > On 1/14/19 8:20 AM, Yongseok Koh wrote: > > > RTE_MBUF_INDIRECT() is replaced with RTE_MBUF_CLONED() and removed. > > > This macro was deprecated in release 18.05 when EXT_ATTACHED_MBUF was >

Re: [dpdk-dev] [PATCH 2/2] mbuf: remove experimental tag of external buffer attachment

On Mon, Jan 14, 2019 at 10:42:21AM +0300, Andrew Rybchenko wrote: > On 1/14/19 8:20 AM, Yongseok Koh wrote: > > Remove the experimental tag of rte_pktmbuf_attach_extbuf() which was > > introduced in 18.05. > > > > Signed-off-by: Yongseok Koh > > Acked-by: Andrew Rybchenko > Acked-by: Olivier

[dpdk-dev] [PATCH] doc: update description in qat compression guide

Added limitations description for the QAT compression PMD. Updated intermediate buffers description in qat.rst file. Signed-off-by: Tomasz Jozwiak --- doc/guides/compressdevs/qat_comp.rst | 4 doc/guides/cryptodevs/qat.rst| 6 -- 2 files changed, 8 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH v2 7/7] net/tap: don't print pointer in info message

> On Jan 11, 2019, at 2:35 PM, Stephen Hemminger > wrote: > > Printing pointer in log is uninformative (unless in a debugger), > instead print the assigned kernel device name which correlates > well with what TAP is doing. > > Signed-off-by: Stephen Hemminger > --- > drivers/net/tap/rte_eth

[dpdk-dev] [PATCH 1/2] net/enic: remove useless include

libgen.h is not used, so do not include it. Fixes: fefed3d1e62c ("enic: new driver") Cc: sta...@dpdk.org Signed-off-by: Hyong Youb Kim --- drivers/net/enic/enic_clsf.c | 2 -- drivers/net/enic/enic_main.c | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/net/enic/enic_clsf.c b/driver

[dpdk-dev] [PATCH 2/2] net/enic: remove redundant log level check

Fixes: 8d496995346c ("net/enic: support multicast filtering") Cc: sta...@dpdk.org Suggested-by: Ferruh Yigit Signed-off-by: Hyong Youb Kim --- drivers/net/enic/enic_ethdev.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net

[dpdk-dev] [PATCH 0/2] net/enic: two trivial fixes

Hyong Youb Kim (2): net/enic: remove useless include net/enic: remove redundant log level check drivers/net/enic/enic_clsf.c | 2 -- drivers/net/enic/enic_ethdev.c | 9 - drivers/net/enic/enic_main.c | 1 - 3 files changed, 4 insertions(+), 8 deletions(-) -- 2.16.2

Re: [dpdk-dev] [PATCH v3] mbuf: fix compile by making sched struct visible

On Fri, Jan 11, 2019 at 02:33:16PM +, Dumitrescu, Cristian wrote: > > > > -Original Message- > > From: Van Haaren, Harry > > Sent: Friday, January 11, 2019 11:33 AM > > To: dev@dpdk.org > > Cc: Van Haaren, Harry ; Pattan, Reshma > > ; Dumitrescu, Cristian > > ; olivier.m...@6wind.com;

Re: [dpdk-dev] [PATCH] memalloc: fix pointer dereferencing

08/01/2019 17:46, Anatoly Burakov: > The original code was supposed to overwrite the value pointed to > by the pointer, but the new one is instead overwriting the > pointer value itself, which has no effect outside that function. > Fix it by adding a pointer dereference. > > Fixes: 582bed1e1d1d ("

[dpdk-dev] [PATCH] examples/vhost: fix a typo

This minor patch fixes a typo in examples/vhost/main.c. Fixes: d19533e86f1d ("examples/vhost: copy old vhost example") Signed-off-by: Rami Rosen --- examples/vhost/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index dc9e

Re: [dpdk-dev] [PATCH v5] eal: fix core number validation

On Mon, Jan 14, 2019 at 11:31 AM Hari Kumar Vemula < hari.kumarx.vem...@intel.com> wrote: > diff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c > index 2acab9d69..4dc22ec36 100644 > --- a/test/test/test_eal_flags.c > +++ b/test/test/test_eal_flags.c > @@ -18,6 +18,7 @@ > #include

Re: [dpdk-dev] [PATCH] memalloc: fix variable shadowing

08/01/2019 17:33, Anatoly Burakov: > A local variable ``flags`` was shadowing another variable from outer > scope. Fix this by renaming the variable and make it const. > > Fixes: c127be93f619 ("mem: support using memfd segments for in-memory mode") > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: fix wrong pointer reference in macswap

On 1/14/2019 1:39 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Yongseok Koh [mailto:ys...@mellanox.com] >> Sent: Monday, January 14, 2019 10:00 AM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org >> Subject: [PATCH

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vfio: don't unregister callback in secondaries

10/01/2019 17:33, Anatoly Burakov: > Callbacks are only registered in the primary, so do not attempt to > unregister callbacks in secondary processes. > > Fixes: 43e463137154 ("vfio: support memory event callbacks") > Cc: sta...@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks

Re: [dpdk-dev] [PATCH v2] ethdev: report error on name truncation

13/01/2019 16:38, Nithin Kumar Dabilpuram: > Currently this api doesn't report error if name is > truncated and so user is not sure about uniqueness > of name. This change reports error to help user. > > Signed-off-by: Nithin Dabilpuram > --- > + if (rc >= RTE_MEMZONE_NAMESIZE) { > +

Re: [dpdk-dev] [PATCH] eal/bsdapp: don't clean up files at startup

10/01/2019 12:34, Anatoly Burakov: > On FreeBSD, closing the file descriptor drops the lock even if the > file descriptor was mmap'ed. This leads to the cleanup at the end > of EAL init to remove fbarray files that are still in use by the > process itself. > > However, instead of working around th

Re: [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat

On Mon, Jan 14, 2019 at 06:04:35AM +, Chaitanya Babu Talluri wrote: > Strcat does not check the destination length and there might be > chances of string overflow so insted of strcat, strncat is used. > > Fixes: 540a211084 ("bnx2x: driver core") > Fixes: e163c18a15 ("net/i40e: update ptype and

Re: [dpdk-dev] [PATCH] eal: fix strdup usages in internal config

10/01/2019 14:38, Anatoly Burakov: > Currently, we use strdup in a few places to store command-line > parameter values for certain internal config values. There are > several issues with that. > > First of all, they're never freed, so memory ends up leaking > either after EAL exit, or when these c

Re: [dpdk-dev] [PATCH v2 0/6] net/tap: fixes and cleanups

On 1/11/2019 8:35 PM, Stephen Hemminger wrote: > The tap device (used by vdev_netvsc on Azure) has a bug that > prevents it working with primary/secondary process model because > the device name generation assumed a single process. The fix for > this is to have the kernel assign the device name (p

Re: [dpdk-dev] [PATCH v2 7/7] net/tap: don't print pointer in info message

On 1/11/2019 8:35 PM, Stephen Hemminger wrote: > Printing pointer in log is uninformative (unless in a debugger), > instead print the assigned kernel device name which correlates > well with what TAP is doing. > > Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit

  1   2   >