Hi All, would be glad to have comments on this patch.
Good day!
Regards,
Asaf Penso
> -Original Message-
> From: Asaf Penso
> Sent: Wednesday, November 28, 2018 5:26 PM
> To: Adrien Mazarguil
> Cc: Asaf Penso ; dev@dpdk.org; Shahaf Shuler
> ; Ori Kam ; Thomas
> Monjalon
> Subject: [PATC
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Thursday, December 6, 2018 2:41 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 01/20] net/ice: add base code
>
>
> Note: In version 1 I enquired about unit or DTS validation for PMD. Is this
> still
On Thu, 6 Dec 2018 11:45:22 +0800
"bai bakari" <912873...@qq.com> wrote:
> when i send packets using dpdk-pktgen, i found:
> ip_len = 46
> ip_header_len = 20
> but the tcp_header_len=(tcp_hdr->data_off << 2)=0,
> and (payload - (uint8_t *)ipv4_hdr) = 340 > ip_len.
dpdk pktgen sends UDP not TCP.
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Varghese, Vipin
> Sent: Thursday, December 6, 2018 2:41 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 01/20] net/ice: add base code
>
> snipped
> > > > > > >
> > > > > > > I this README
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Thursday, December 6, 2018 2:31 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Yang, Qiming ; Li, Xiaoyun
> ; Wu, Jingjing
> Subject: RE: [dpdk-dev] [PATCH v2 02/20] net/ice: support device
> initialization
>
> snipped
> > > > > >
snipped
> > > > > >
> > > > > > I this README persistent in upcoming releases of 'driver/net/ice'?
> > > > > Yes.
> > > > If Linux driver is enabled in 4.20.1 or higher, then will the
> > > > wording 'This directory contains source code of FreeBSD ice driver
> > > > of' still
> > hold true?
> > > A
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Thursday, December 6, 2018 2:03 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 01/20] net/ice: add base code
>
> snipped
> > > > >
> > > > > > +Intel® ICE driver
> > > > > > +==
> > >
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Thursday, December 6, 2018 2:26 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 19/20] doc: add ICE description and
> update release note
>
> snipped
> > > > > Thanks Wenzhuo
> > > > >
> > > > > snippe
snipped
> > > > > + ice_init_controlq_parameter(hw);
> > > > > +
> > > > > + ret = ice_init_hw(hw);
> > > > > + if (ret) {
> > > > > + PMD_INIT_LOG(ERR, "Failed to initialize HW");
> > > > > + return -EINVAL;
> > > > > + }
> > > >
> > > > Definition for ice_i
snipped
> > > > Thanks Wenzhuo
> > > >
> > > > snipped
> > > > > >
> > > > > > Do we support Traffic Manager and Inline Crypto? If not, can
> > > > > > we add this also to limitations?
> > > > > The style is only listed supported features here. I don't think
> > > > > we'll list everything not supp
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Thursday, December 6, 2018 2:09 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 19/20] doc: add ICE description and
> update release note
>
>
>
> > -Original Message-
> > From: Lu, Wenzhuo
>
Port packets excluding pf VSI discards were used for packet count. And
port bytes were used for byte count. This will cause inconsistent count
in some cases. This patch would take all VSI stats as packet and byte
count to address the issue.
Fixes: 763de290cbd1 ("net/i40e: fix packet count for PF")
On 12/6/2018 6:03 AM, Varghese, Vipin wrote:
> snipped
>
>> +Intel® ICE driver
>> +==
>> +
>> +This directory contains source code of FreeBSD ice driver of
>> +version
>> +2018.10.30 released by the team which develops basic drivers
>> +for any ice NI
Thank your answers, that helped me out.
-- --
??: "Shyam Shrivastav";
: 2018??12??6??(??) 2:22
??: "bai bakari"<912873...@qq.com>;
: "dev";
: Re: [dpdk-dev] About the data payload of rte_mbuf?
And if just payload lengt
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Thursday, December 6, 2018 1:33 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Yang, Qiming ; Li, Xiaoyun
> ; Wu, Jingjing
> Subject: RE: [dpdk-dev] [PATCH v2 02/20] net/ice: support device
> initialization
>
> snipped
> > > > +
> -Original Message-
> From: Lu, Wenzhuo
> Sent: Thursday, December 6, 2018 11:36 AM
> To: Varghese, Vipin ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 19/20] doc: add ICE description and update
> release note
>
> Hi Vipin,
>
>
> > -Original Message-
> > From: Varghese, V
> -Original Message-
> From: Lu, Wenzhuo
> Sent: Thursday, December 6, 2018 11:29 AM
> To: Varghese, Vipin ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build
>
> Hi Vipin,
>
>
> > -Original Message-
> > From: Varghese, Vipin
> > Sent: Thursd
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Thursday, December 6, 2018 12:34 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 19/20] doc: add ICE description and
> update release note
>
> Thanks Wenzhuo
>
> snipped
> > >
> > > Do we support Traf
snipped
> > > >
> > > > > +Intel® ICE driver
> > > > > +==
> > > > > +
> > > > > +This directory contains source code of FreeBSD ice driver of
> > > > > +version
> > > > > +2018.10.30 released by the team which develops basic drivers
> > > > > +for any ice NIC. The directory of base
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Thursday, December 6, 2018 12:31 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build
>
> Hi Wenzhuo
>
> snipped
> > >
> > > Should not meson build option be add start.
Thanks, I get what you are saying since by default ' rte_eth_dev_get_mtu'
fetches MTU ' dev->data->mtu'. But is not ICE_DSI a switch so MTU would be
picked up from switch HW ?
> -Original Message-
> From: Lu, Wenzhuo
> Sent: Thursday, December 6, 2018 11:11 AM
> To: Varghese, Vipin ; dev
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Thursday, December 6, 2018 12:29 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 01/20] net/ice: add base code
>
> Hi Wenzhuo,
>
> thanks for the updates, couple of follow up and suggestions
>
> snipp
> >
> > snipped
> > > +uint16_t
> > > +ice_recv_pkts(void *rx_queue,
> > > + struct rte_mbuf **rx_pkts,
> > > + uint16_t nb_pkts)
> > > +{
> > > + struct ice_rx_queue *rxq = rx_queue;
> > > + volatile union ice_rx_desc *rx_ring = rxq->rx_ring;
> > > + volatile union ice_rx_desc *rxdp;
>
And if just payload length is required one can get by subtracting
(ip-hdr-len + tcp-offset) from total length in ip header ...
On Thu, Dec 6, 2018 at 11:18 AM Shyam Shrivastav
wrote:
>
> As per my understanding
>
> payload = (uint8_t *)tcp_hdr + (tcp_hdr->data_off << 2);
>
> should be
>
> payloa
Snipped
> >
> > snipped
> > > + ns->eth.tx_bytes -= (ns->eth.tx_unicast + ns->eth.tx_multicast +
> > > + ns->eth.tx_broadcast) * ETHER_CRC_LEN;
> >
> > In earlier patch for 'mtu set check' we added VSI SWITCH VLAN. Should
> > we add VSI VLAN here?
> Don't need. They're differen
> >
> > snipped
> > > +static void
> > > +ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info
> > > +*dev_info) {
> > > + struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data-
> > >dev_private);
> > > + struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data-
> > > >dev_private);
> > > + s
As per my understanding
payload = (uint8_t *)tcp_hdr + (tcp_hdr->data_off << 2);
should be
payload = (uint8_t *)tcp_hdr + (tcp_hdr->data_off >> 4) << 2);
Note that data offset is 4 most significant bits of the byte, refer tcp
header
On Thu, Dec 6, 2018 at 9:15 AM bai bakari <912873...@qq.com
Hi,
snipped
For your two question,
1. I think it's right, because the definition of "rte_pktmbuf_mtod_offset" is:
#define rte_pktmbuf_mtod_offset(m, t, o) \
((t)((char *)(m)->buf_addr + (m)->data_off + (o)))
You are passing ' ipv4_hdr = rte_pktmbuf_mtod_offset(m, struct ipv4
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, December 4, 2018 1:52 PM
> To: Varghese, Vipin ; Lu, Wenzhuo
> ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Yang, Qiming
> ; Li, Xiaoyun ; Wu, Jingjing
>
> Subject: RE: [dpdk-dev] [PATCH v2 07/20] net/ice: support MTU setting
>
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, December 4, 2018 1:42 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Yang, Qiming
> ; Li, Xiaoyun ; Wu, Jingjing
>
> Subject: RE: [dpdk-dev] [PATCH v2 16/20] net/ice: support basic RX/TX
>
> snipped
> > +ui
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, December 4, 2018 1:35 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Guo, Jia
> Subject: RE: [dpdk-dev] [PATCH v2 14/20] net/ice: support statistics
>
> snipped
> > + ns->eth.tx_bytes -= (ns->eth.tx_unica
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, December 4, 2018 1:26 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Yang, Qiming
> ; Li, Xiaoyun ; Wu, Jingjing
>
> Subject: RE: [dpdk-dev] [PATCH v2 07/20] net/ice: support MTU setting
>
> snipped
> > +st
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, December 4, 2018 1:19 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Zhao1, Wei
>
> Subject: RE: [dpdk-dev] [PATCH v2 05/20] net/ice: support packet type
> getting
>
> snipped
> > +static inline uint32_t
>
snipped
> > > + ice_init_controlq_parameter(hw);
> > > +
> > > + ret = ice_init_hw(hw);
> > > + if (ret) {
> > > + PMD_INIT_LOG(ERR, "Failed to initialize HW");
> > > + return -EINVAL;
> > > + }
> >
> > Definition for ice_init_hw in patch 01/20 does not check for primary-
> > second
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, December 4, 2018 1:00 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Yang, Qiming
> ; Li, Xiaoyun ; Wu, Jingjing
>
> Subject: RE: [dpdk-dev] [PATCH v2 04/20] net/ice: support getting device
> information
>
Hi Wenzhuo,
Please find my updates below
snipped
> > > + if (!vsi->rss_key)
> > > + vsi->rss_key = rte_zmalloc("rss_key",
> > > +vsi->rss_key_size, 0);
> > > + if (!vsi->rss_lut)
> > > + vsi->rss_lut = rte_zmalloc("rss_lut",
> > > +
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, December 4, 2018 12:53 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Yang, Qiming
> ; Li, Xiaoyun ; Wu, Jingjing
>
> Subject: RE: [dpdk-dev] [PATCH v2 03/20] net/ice: support device and queue
> ops
>
> sni
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, December 4, 2018 12:41 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Yang, Qiming
> ; Li, Xiaoyun ; Wu, Jingjing
>
> Subject: RE: [dpdk-dev] [PATCH v2 02/20] net/ice: support device
> initialization
>
>
>
Hi,
Thank your reply.
For your two question,
1. I think it's right, because the definition of "rte_pktmbuf_mtod_offset" is:
#define rte_pktmbuf_mtod_offset(m, t, o)\
((t)((char *)(m)->buf_addr + (m)->data_off + (o)))
2. I set the packet type is IPv4 when i use dpdk-pktgen,
Thanks Wenzhuo
snipped
> >
> > Do we support Traffic Manager and Inline Crypto? If not, can we add
> > this also to limitations?
> The style is only listed supported features here. I don't think we'll list
> everything
> not supported as limitation.
Thanks for the correction in format, hence the
Hi Wenzhuo
snipped
> >
> > Should not meson build option be add start. That is in patch 1/20 so
> > compile options does not fail?
> It will not fail. Enabling the compile earlier only means the code can be
> compiled.
> But, to use this device we do need the whole patch set. From this point of
Hi Wenzhuo,
thanks for the updates, couple of follow up and suggestions
snipped
> >
> > > +Intel® ICE driver
> > > +==
> > > +
> > > +This directory contains source code of FreeBSD ice driver of
> > > +version
> > > +2018.10.30 released by the team which develops basic drivers for
On 2018/12/5 下午9:33, Ilya Maximets wrote:
On 05.12.2018 12:49, Maxime Coquelin wrote:
A read barrier is required to ensure that the ordering between
descriptor's flags and content reads is enforced.
Fixes: 2f3225a7d69b ("vhost: add vector filling support for packed ring")
Cc: sta...@dpdk.org
Hi,
A quick query from your email
Snipped
> ipv4_hdr = rte_pktmbuf_mtod_offset(m, struct ipv4_hdr *, sizeof(struct
> ether_hdr));
Questions:
1. Should not be sizeof(struct ipv4_hdr) since you are passing second argument
as ipv4_hdr?
2. you are getting packets which starts from ether or ipv4?
On 2018/12/5 下午7:30, Ilya Maximets wrote:
On 05.12.2018 12:49, Maxime Coquelin wrote:
A read barrier is required to ensure the ordering between
available index and the descriptor reads is enforced.
Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")
Cc: sta...@dpdk.org
https://bugs.dpdk.org/show_bug.cgi?id=120
Bug ID: 120
Summary: secondary fails failure without option '--legacy-mem'
Product: DPDK
Version: 18.05
Hardware: All
OS: All
Status: CONFIRMED
Severity: normal
Hi,
Now, I want to get the data payload of rte_mbuf, and i wrote the following code:
struct ipv4_hdr *ipv4_hdr;
struct tcp_hdr *tcp_hdr;
uint32_t payload_len, ip_len;
uint8_t *payload = NULL;
ipv4_hdr = rte_pktmbuf_mtod_offset(m, struct ipv4_hdr *, sizeof(struct
ether_hdr));
ip_len = ntohs(
Hi Vipin,
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, December 4, 2018 12:19 PM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: RE: [dpdk-dev] [PATCH v2 01/20] net/ice: add base code
>
> Snipped
>
> > +Intel® ICE driver
> > +==
> > +
> >
There is need to add boundary for input number from commandline,
If it beyond the defination, code will return error.
Signed-off-by: Wei Zhao
---
v2:
change mask writing format.
---
app/test-pmd/cmdline_flow.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-pmd/cmdline_flow.c b/
Hi, Zhirun
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhirun Yan
> Sent: Wednesday, December 5, 2018 8:46 PM
> To: dev@dpdk.org; Zhang, Qi Z ; Wang, Haiyue
>
> Cc: Yan, Zhirun
> Subject: [dpdk-dev] [PATCH v2] net/i40e: fix VF/PF port reset
>
> Port reset
Hi Rami,
> -Original Message-
> From: Rami Rosen [mailto:roszenr...@gmail.com]
> Sent: Monday, December 3, 2018 11:24 PM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org; Yang, Qiming ; Li, Xiaoyun
> ; Wu, Jingjing
> Subject: Re: [dpdk-dev] [PATCH 03/19] net/ice: support device and queue
> ops
>
>
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Tuesday, December 4, 2018 5:22 PM
> To: Zhao1, Wei ; dev@dpdk.org
> Cc: sta...@dpdk.org; Peng, Yuan ; Zhao1, Wei
>
> Subject: RE: [dpdk-dev] [PATCH] app/testpmd: add boundary check in flow
> commandline
>
>
>
> > -Original
On Wed, Dec 05, 2018 at 07:01:23PM +0300, Ilya Maximets wrote:
> On 28.11.2018 12:47, Maxime Coquelin wrote:
> > Instead of writing back descriptors chains in order, let's
> > write the first chain flags last in order to improve batching.
>
> I'm not sure if this fully compliant with virtio spec.
From: Gao Feng
The RTE_PROC_PRIMARY error handler lost the unlock statement in the
current codes. Now fix it.
Signed-off-by: Gao Feng
---
lib/librte_eal/common/eal_common_memzone.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/eal_common_memzone.c
b/lib/librte_eal/
On Wed, 5 Dec 2018 12:28:27 +0100
Maxime Coquelin wrote:
> > +static uint16_t
>
> In think it should be inlined.
>
> > +virtqueue_dequeue_burst_rx_packed(struct virtqueue *vq,
> > + struct rte_mbuf **rx_pkts,
> > + uint32_t *len,
> > +
The problem is a regression in 4.20 kernel. Bisecting now.
The kernel in 4.19.7 works.
Failure with logging is:
$ sudo ./testpmd -l 0-1 -n2 --log-level=8 --log-level='pmd.*,8'
--log-level='bus.vmbus,8' -- --port-topology=chained --forward-mode=rxonly
--stats-period 1 --eth-peer=0,00:15:5d:1e:20
On WS2016 and 4.19.7 kernel (with the 4 patches), this is what I see:
$ sudo ./testpmd -l 0-1 -n2 --log-level=8 --log-level='pmd.*,8'
--log-level='bus.vmbus,8' -- --port-topology=chained --forward-mode=rxonly
--stats-period 1 --eth-peer=0,00:15:5d:1e:20:c0 --txq 2 --rxq 2
EAL: Detected 4 lcore(s
Add more instrumentation to subchannel setup to help diagnose
startup issues.
Signed-off-by: Stephen Hemminger
---
drivers/bus/vmbus/linux/vmbus_uio.c | 24 +++-
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c
b/drivers/bus/
NDIS multi-queue support is only in WS2012 or later. Check the NDIS
version to limit to single queue on older versions. Similar code
exists in Linux driver.
Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
Signed-off-by: Stephen Hemminger
---
drivers/net/netvsc/hn_ethdev.c | 5
Make DPDK enable SRIOV flag in same way as Linux and FreeBSD.
Fixes: dc7680e8597c ("net/netvsc: support integrated VF")
Signed-off-by: Stephen Hemminger
---
drivers/net/netvsc/hn_nvs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/netvsc/hn_nvs.c b/drivers
When using multiple queues, there was a race with the kernel
in setting up the second channel. This regression is due to a kernel change
which does not allow accessing sysfs files for Hyper-V channels that are not
opened.
The fix is simple, just move the logic to detect not ready
sub channels ear
The DPAA bus support code put out messages like:
dpaax: read_memory_node(): Unable to glob device-tree memory
node: (/proc/device-tree/memory[@0-9]*/reg)(3)
dpaax: PA->VA translation not available;
dpaax: Expect performance impact.
These are unnecessary and likely to
Hi,
Just wondering if there's any change in status of this topic? I can
currently access bypass support for this card in the Silicom utility
driver, but have no access in the current DPDK-18.11.0. Will there be
support similar to the 82599 bypass API in the future?
Thanks,
EJ
On Tue, Jul 24, 201
From: Subarna Kar
---
drivers/net/i40e/i40e_ethdev.c | 14 +-
drivers/net/i40e/i40e_ethdev.h | 109 +-
drivers/net/i40e/i40e_fdir.c | 392 +++--
drivers/net/i40e/i40e_flow.c | 781 -
4 files changed, 1250 insertions(+), 46 deletion
On Wed, 5 Dec 2018 19:55:31 +0800
Qiming Yang wrote:
> May return NULL when manage tries for packet in acl library. So
> this patch added warning for the NULL pointer return.
>
> Fixes: 074f54ad03ee ("acl: fix build and runtime for default target")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Qimi
This patch fixes a typo in testpmd guide (should be ICMP and not IMCP).
Fixes: ac718398f477 ("doc: testpmd application user guide")
Signed-off-by: Rami Rosen
Acked-by: Bernard Iremonger
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
> -Original Message-
> From: Chalupnik, KamilX
> Sent: Wednesday 5 December 2018 10:40
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; akhil.go...@nxp.com;
> Chalupnik, KamilX
> Subject: [PATCH v2] baseband/turbo_sw: update for FlexRAN 18.09
>
> Update BBDEV Turbo SW driver download/build instr
> -Original Message-
> From: David Marchand [mailto:david.march...@redhat.com]
> Sent: Tuesday 4 December 2018 20:58
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; nhor...@tuxdriver.com; tredae...@redhat.com;
> Yigit, Ferruh ; Mokhtar, Amr
>
> Subject: [PATCH] bbdev: add missing experimental
From: Zyta Szpak
I'd ask few questions: how is this new rte_ethdev_read_clock different from
existing rte_eth_timesync_read_time ?
Is it that this new function does not convert the clock raw value into
timespec? Would it be too much overhead to use the timespec type of value? Or
do they intent
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anatoly Burakov
> Sent: Wednesday, December 5, 2018 9:26 AM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] test: add missing fbarray autotest to meson
>
> Currently, fbarray autotest is o
Currently, fbarray autotest is only built by make, but is
missing from meson build files.
Fixes: 7985860c18af ("test/fbarray: add autotests")
Cc: sta...@dpdk.org
Signed-off-by: Anatoly Burakov
---
test/test/meson.build | 2 ++
1 file changed, 2 insertions(+)
diff --git a/test/test/meson.build
The 'external_mem_autotest' was defined in the meson build, but
the actual source file was not being compiled by meson.
Fixes: b270daa43b3d ("test: support external memory")
Cc: sta...@dpdk.org
Signed-off-by: Anatoly Burakov
---
test/test/meson.build | 1 +
1 file changed, 1 insertion(+)
diff
On 28.11.2018 12:47, Maxime Coquelin wrote:
> Instead of writing back descriptors chains in order, let's
> write the first chain flags last in order to improve batching.
I'm not sure if this fully compliant with virtio spec.
It says that 'each side (driver and device) are only required to poll
(or
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Jozwiak
> Sent: Wednesday, December 5, 2018 8:47 AM
> To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX
> ; shally.ve...@cavium.com;
> akhil.go...@nxp.com
> Subject: [dpdk-dev] [PATCH v5 0/5] add initial v
> -Original Message-
> From: Daly, Lee
> Sent: Wednesday, December 5, 2018 3:39 PM
> To: akhil.go...@nxp.com; Jozwiak, TomaszX ;
> Trahe, Fiona
> Cc: dev@dpdk.org; Daly, Lee
> Subject: [PATCH v3] test/compress: add mbuf offset unit test
>
> added mbuf offset test to compressdev test s
Flags could be updated in a separate process leading to the
inconsistent check.
Additionally, read marked as 'volatile' to highlight the shared
nature of the variable and avoid such issues in the future.
Fixes: d3211c98c456 ("vhost: add helpers for packed virtqueues")
Cc: sta...@dpdk.org
Signed-
added mbuf offset test to compressdev test suite, which tests
compression/decompression with a mbuf containing
an offset spanning across mulitple segments.
V2:
- Change how test checks capalilites structure.
V3:
- Change commit message.
Signed-off-by: Lee Daly
---
test/test/test_compress
If the user has MAKEFLAGS set in the environment when building the
documentation, the doc/guides/conf.py script which calls "make"
exclusively to get the project version might pick up garbage from
stdout, like:
FAQ — Data Plane Development Kit make[2]:
Entering directory '/build/1st/dpdk-18.11/doc
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lee Daly
> Sent: Wednesday, November 28, 2018 11:42 AM
> To: Trahe, Fiona ; akhil.go...@nxp.com
> Cc: dev@dpdk.org; Daly, Lee
> Subject: [dpdk-dev] [PATCH v2 2/3] test/compress: add checksum tests
>
> This patc
On 05.12.2018 12:49, Maxime Coquelin wrote:
> Cast to volatile is done when reading avail index and writing
> the used index. This would not be necessary if proper barriers
> are used.
'volatile' and barriers are not really connected. 'volatile' is
the disabling of the compiler optimizations, whil
On 05.12.2018 12:49, Maxime Coquelin wrote:
> A read barrier is required to ensure that the ordering between
> descriptor's flags and content reads is enforced.
>
> Fixes: 2f3225a7d69b ("vhost: add vector filling support for packed ring")
> Cc: sta...@dpdk.org
>
> Reported-by: Jason Wang
> Signe
On Wed, Dec 5, 2018 at 1:23 PM Neil Horman wrote:
> On Tue, Dec 04, 2018 at 09:48:22PM +0100, David Marchand wrote:
> > On Tue, Dec 4, 2018 at 4:16 PM Neil Horman
> wrote:
> > > If you would like to make this adjustment, I'm fine with it, though be
> > > aware,
> > > you will likely need to make
Hi Zhirun:
> -Original Message-
> From: Yan, Zhirun
> Sent: Wednesday, December 5, 2018 8:46 PM
> To: dev@dpdk.org; Zhang, Qi Z ; Wang, Haiyue
>
> Cc: Yan, Zhirun
> Subject: [PATCH v2] net/i40e: fix VF/PF port reset
>
> Port reset will call i40evf_uninit_vf() to release resource. It wan
Signed-off-by: Leonid Myravjev
---
drivers/net/e1000/igb_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index d9d29d22f..ebc242cd9 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -458
On Tue, Dec 04, 2018 at 09:48:22PM +0100, David Marchand wrote:
> On Tue, Dec 4, 2018 at 4:16 PM Neil Horman wrote:
>
> > On Tue, Dec 04, 2018 at 09:21:43AM +0100, David Marchand wrote:
> > > On Mon, Dec 3, 2018 at 5:48 PM Neil Horman
> > wrote:
> > > > On Mon, Dec 03, 2018 at 02:01:02PM +0100,
On Tue, Dec 04, 2018 at 09:57:45PM +0100, David Marchand wrote:
> Those two symbols are missing the experimental tag in the library
> header.
> Because of this, a user can try to call this symbol without being aware
> this is an experimental api (neither compilation nor link warning).
>
> Fixes: 4
On Wed, Dec 05, 2018 at 12:28:27PM +0100, Maxime Coquelin wrote:
On 12/3/18 3:15 PM, Jens Freimann wrote:
Implement the receive part.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 61 +++--
drivers/net/virtio/virtio_ethdev.h | 5 +
driver
> -Original Message-
> From: Dumitrescu, Cristian
> Sent: Tuesday, December 4, 2018 5:39 PM
> To: Singh, Jasvinder ; dev@dpdk.org
> Cc: Pattan, Reshma
> Subject: RE: [PATCH] mbuf: implement generic format for sched field
>
> > >
> > > > + uint8_t color;
On 05.12.2018 12:49, Maxime Coquelin wrote:
> A read barrier is required to ensure the ordering between
> available index and the descriptor reads is enforced.
>
> Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")
> Cc: sta...@dpdk.org
>
> Reported-by: Jason Wang
> Signe
On 12/3/18 3:15 PM, Jens Freimann wrote:
Implement the receive part.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 61 +++--
drivers/net/virtio/virtio_ethdev.h | 5 +
drivers/net/virtio/virtio_rxtx.c | 369 +++
On 12/3/18 3:15 PM, Jens Freimann wrote:
Add helper functions to set/clear and check descriptor flags.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 2 +
drivers/net/virtio/virtqueue.h | 73 +-
2 files changed, 73 insertions(+), 2
On 12/3/18 3:15 PM, Jens Freimann wrote:
This implements the transmit path for devices with
support for packed virtqueues.
Signed-off-by: Jens Freiman
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 54 ---
drivers/net/virtio/virtio_ethdev.h | 2 +
drivers/net/v
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Saturday, December 1, 2018 2:23 PM
> To: Singh, Jasvinder
> Cc: dev@dpdk.org; Dumitrescu, Cristian ;
> Pattan, Reshma ; Rao, Nikhil
>
> Subject: Re: [dpdk-dev] [PATCH] mbuf: implement generic forma
Update BBDEV Turbo SW driver download/build instructions for
FlexRAN 18.09 release
Signed-off-by: Kamil Chalupnik
---
doc/guides/bbdevs/turbo_sw.rst | 21 +++---
drivers/baseband/turbo_sw/bbdev_turbo_software.c | 90 +---
2 files changed, 14 insertions(+), 9
On 04-Dec-18 5:06 PM, Seth Howell wrote:
When secondary process hotplugs memory, it sends a request
to primary, which then performs the real mmap() and sends
sync requests to all secondary processes. Upon receiving
such sync request, each secondary process will notify the
upper layers of hotplugg
Cast to volatile is done when reading avail index and writing
the used index. This would not be necessary if proper barriers
are used.
Now that the read barrier has been added, we can remove these
cast to volatile.
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/virtio_net.c | 7 +++
1
This prefetch does not show any performance improvement.
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/virtio_net.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index 0a860ca72..679ce388b 100644
--- a/lib/librte_vhost/vi
This patch moves the prefetch after the available index
is read to avoid prefetching a descriptor not available yet.
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/virtio_net.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/lib
A read barrier is required to ensure that the ordering between
descriptor's flags and content reads is enforced.
Fixes: 2f3225a7d69b ("vhost: add vector filling support for packed ring")
Cc: sta...@dpdk.org
Reported-by: Jason Wang
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/virtio_net.
A read barrier is required to ensure the ordering between
available index and the descriptor reads is enforced.
Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")
Cc: sta...@dpdk.org
Reported-by: Jason Wang
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/virtio_net.
1 - 100 of 110 matches
Mail list logo
