Re: [dpdk-dev] [PATCH 00/19] A new net PMD - ice

2018-12-04 Thread Thomas Monjalon
05/12/2018 07:39, Lu, Wenzhuo: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 23/11/2018 07:56, Wenzhuo Lu: > > > net/ice: add base code > > > > This first patch is really too big. > > Please could you try to split it logically? > > This is base code which is not developed by us. We'r

Re: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build

2018-12-04 Thread Lu, Wenzhuo
Hi Vipin, > -Original Message- > From: Varghese, Vipin > Sent: Monday, December 3, 2018 6:01 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v2 20/20] net/ice: support meson build > > Should not meson build option be add start. That is in patch 1/2

Re: [dpdk-dev] [PATCH v2 19/20] doc: add ICE description and update release note

2018-12-04 Thread Lu, Wenzhuo
Hi Vipin, > -Original Message- > From: Varghese, Vipin > Sent: Monday, December 3, 2018 4:15 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v2 19/20] doc: add ICE description and > update release note > > Hi, > > Thanks for adding details for se

Re: [dpdk-dev] [PATCH 00/19] A new net PMD - ice

2018-12-04 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, November 23, 2018 7:00 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 00/19] A new net PMD - ice > > Hi Wenzhuo, > > 23/11/2018 07:56, Wenzhuo Lu: > > net/ic

[dpdk-dev] [PATCH] eal: Add the check for null peer pointer in mp request handler

2018-12-04 Thread gfree . wind
From: Gao Feng Add the check for null peer pointer like the bundle pointer in the mp request handler. They should follow same style. And add some logs for nomem cases. Signed-off-by: Gao Feng --- lib/librte_eal/common/hotplug_mp.c | 15 +++ 1 file changed, 15 insertions(+) diff --

[dpdk-dev] [Bug 118] conflicting information for 'Running DPDK Applications Without Root Privileges'

2018-12-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=118 Bug ID: 118 Summary: conflicting information for 'Running DPDK Applications Without Root Privileges' Product: DPDK Version: 18.11 Hardware: All OS: All S

[dpdk-dev] [Bug 117] in case of malloc_elem_alloc should we increment alloc_count (heap->alloc_count++)?

2018-12-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=117 Bug ID: 117 Summary: in case of malloc_elem_alloc should we increment alloc_count (heap->alloc_count++)? Product: DPDK Version: 18.11 Hardware: All OS: All

Re: [dpdk-dev] [PATCH] lib: add warning for NULL pointer

2018-12-04 Thread Varghese, Vipin
Do you plan to check for all iteration for ' flows->last_cmplt ' is successful? > -Original Message- > From: dev On Behalf Of Varghese, Vipin > Sent: Wednesday, December 5, 2018 10:07 AM > To: Yang, Qiming ; dev@dpdk.org > Cc: Yang, Qiming ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATC

[dpdk-dev] [PATCH v2] net/i40e: fix VF/PF port reset

2018-12-04 Thread Zhirun Yan
Port reset will call i40evf_uninit_vf() to release resource. It wants to call i40evf_dev_close() to do some clean work. Before this patch, port reset will never call i40evf_dev_close() to shutdown adminq. So the i40evf_dev_init() will failed. The status of stop/start should be flaged by dev->data-

Re: [dpdk-dev] [PATCH] lib: add warning for NULL pointer

2018-12-04 Thread Varghese, Vipin
Hi, Should not the warning be stated for ' alloc_completion' failure Snipped > flows->num_packets * flows->categories); > } > > + if (flows->last_cmplt == NULL) > + RTE_LOG(WARNING, MALLOC, "packet tries allocate > fail

[dpdk-dev] [PATCH] lib: add warning for NULL pointer

2018-12-04 Thread Qiming Yang
May return NULL when manage tries for packet in acl library. So this patch added warning for the NULL pointer return. Fixes: 074f54ad03ee ("acl: fix build and runtime for default target") Cc: sta...@dpdk.org Signed-off-by: Qiming Yang --- lib/librte_acl/acl_run.h | 3 +++ 1 file changed, 3 inse

Re: [dpdk-dev] [PATCH] devtools: fix symbol check when adding experimental section

2018-12-04 Thread Gao Feng
Sorry for the noise. Please ignore this reply. It is caused by wrong command. Best Regards Feng At 2018-12-05 10:50:26, "" wrote: >From: David Marchand > >The incriminated commit did relax the condition to catch all sections >but dropped the + removal which can trigger false detection of the >

[dpdk-dev] [Bug 116] Single-port, multi-core and multi-queue mode (open RSS), when configuring IP, may cause dpdk coredump

2018-12-04 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=116 Bug ID: 116 Summary: Single-port, multi-core and multi-queue mode (open RSS), when configuring IP, may cause dpdk coredump Product: DPDK Version: unspecified Hardware: x86

[dpdk-dev] [PATCH] devtools: fix symbol check when adding experimental section

2018-12-04 Thread gfree . wind
From: David Marchand The incriminated commit did relax the condition to catch all sections but dropped the + removal which can trigger false detection of the special EXPERIMENTAL section when adding symbols and the section in the same patch. Fixes: 7281cf520f89 ("devtools: relax rule for identif

[dpdk-dev] [PATCH] eal: fix memleak on mp request error handler

2018-12-04 Thread gfree . wind
From: Gao Feng When rte_eal_alarm_set failed, need to free the bundle mem in the error handler of handle_primary_request and handle_secondary_request. Signed-off-by: Gao Feng --- lib/librte_eal/common/hotplug_mp.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/common/ho

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-04 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of David Marchand > Sent: Tuesday, December 4, 2018 12:48 PM > To: nhor...@tuxdriver.com; Yigit, Ferruh > Cc: dev@dpdk.org; Timothy Redaelli ; > adrien.mazarg...@6wind.com > Subject: Re: [dpdk-dev] Marking symbols a

Re: [dpdk-dev] [PATCH] app/testpmd: fix MPLSoGRE encapsulation

2018-12-04 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, December 4, 2018 3:52 PM > To: wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com > Cc: dev@dpdk.org; Ori Kam ; Shahaf Shuler > ; Dekel Peled > Subject: [dpdk-dev] [PATCH] app/testpmd: fi

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix MPLSoUDP encapsulation

2018-12-04 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Dekel Peled > Sent: Tuesday, December 4, 2018 3:52 PM > To: wenzhuo...@intel.com; jingjing...@intel.com; > bernard.iremon...@intel.com > Cc: dev@dpdk.org; Ori Kam ; Shahaf Shuler > ; Dekel Peled > Subject: [dpdk-dev] [PATCH v2] app/testpmd:

[dpdk-dev] [PATCH] bbdev: add missing experimental tags

2018-12-04 Thread David Marchand
Those two symbols are missing the experimental tag in the library header. Because of this, a user can try to call this symbol without being aware this is an experimental api (neither compilation nor link warning). Fixes: 4935e1e9f76e ("bbdev: introduce wireless base band device lib") Signed-off-by

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-04 Thread David Marchand
On Tue, Dec 4, 2018 at 4:16 PM Neil Horman wrote: > On Tue, Dec 04, 2018 at 09:21:43AM +0100, David Marchand wrote: > > On Mon, Dec 3, 2018 at 5:48 PM Neil Horman > wrote: > > > On Mon, Dec 03, 2018 at 02:01:02PM +0100, David Marchand wrote: > > > I would say, give it a try, and if you can demon

Re: [dpdk-dev] [PATCH] mbuf: implement generic format for sched field

2018-12-04 Thread Dumitrescu, Cristian
> > > > > + uint8_t color; /**< Color. */ > > > > We should create a new file rte_color.h in a common place > > (librte_eal/common/include) to consolidate the color definition, which is > > currently replicated in too many places, such as: rte_meter.h, rte_mtr.h, > > rte_t

[dpdk-dev] [PATCH] malloc: notify primary process about hotplug in secondary

2018-12-04 Thread Seth Howell
When secondary process hotplugs memory, it sends a request to primary, which then performs the real mmap() and sends sync requests to all secondary processes. Upon receiving such sync request, each secondary process will notify the upper layers of hotplugged memory (and will call all locally regist

Re: [dpdk-dev] Problems running netvsc multiq

2018-12-04 Thread Mohammed Gamal
On Tue, 2018-12-04 at 08:48 -0800, Stephen Hemminger wrote: > On Fri, 30 Nov 2018 14:06:52 -0500 (EST) > Mohammed Gamal wrote: > > > - Stephen Hemminger wrote: > > > On Fri, 30 Nov 2018 12:04:41 +0100 > > > Mohammed Gamal wrote: > > >    > > > > Hi All, > > > > I am having the following err

Re: [dpdk-dev] [RFC] mem: do not merge elems from different heap allocs

2018-12-04 Thread Burakov, Anatoly
On 29-Nov-18 7:13 PM, Jim Harris wrote: SPDK uses the rte_mem_event_callback_register API to create RDMA memory regions (MRs) for newly allocated regions of memory. This is used in both the SPDK NVMe-oF target and the NVMe-oF host driver. DPDK creates internal malloc_elem structures for these a

Re: [dpdk-dev] Problems running netvsc multiq

2018-12-04 Thread Stephen Hemminger
On Fri, 30 Nov 2018 14:06:52 -0500 (EST) Mohammed Gamal wrote: > - Stephen Hemminger wrote: > > On Fri, 30 Nov 2018 12:04:41 +0100 > > Mohammed Gamal wrote: > > > > > Hi All, > > > I am having the following errors when I run testpmd with the netvsc > > > driver and --txq 2 and --rxq 2 op

Re: [dpdk-dev] [PATCH 1/2] cryptodev: change queue pair configure structure

2018-12-04 Thread Trahe, Fiona
Hi Fan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Thursday, November 15, 2018 10:24 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com > Subject: [dpdk-dev] [PATCH 1/2] cryptodev: change queue pair configure > structure > > This patch cha

[dpdk-dev] [RFC] malloc: fix deadlock when using malloc stats

2018-12-04 Thread Anatoly Burakov
Currently, malloc statistics and external heap creation code use memory hotplug lock as a way to synchronize accesses to heaps (as in, locking the hotplug lock to prevent list of heaps from changing under our feet). At the same time, malloc statistics code will also lock the heap because it needs t

Re: [dpdk-dev] [PATCH v2 1/9] cryptodev: add opaque userdata pointer into crypto sym session

2018-12-04 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mohammad Abdul Awal > Sent: Tuesday, December 4, 2018 6:14 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/9] cryptodev: add opaque userdata pointer > into crypto sym > session >

Re: [dpdk-dev] [PATCH] log: add missing experimental tag

2018-12-04 Thread Neil Horman
On Tue, Dec 04, 2018 at 09:28:31AM +0100, David Marchand wrote: > When rte_log_register_type_and_pick_level() has been introduced, it has > been correctly added to the EXPERIMENTAL section of the eal map and the > symbol itself has been marked at its definition. > > However, the declaration of thi

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-04 Thread Neil Horman
On Tue, Dec 04, 2018 at 09:21:43AM +0100, David Marchand wrote: > On Mon, Dec 3, 2018 at 5:48 PM Neil Horman wrote: > > > On Mon, Dec 03, 2018 at 02:01:02PM +0100, David Marchand wrote: > > > Hello Neil, > > > > > > Looking at > > > > > http://doc.dpdk.org/guides/contributing/versioning.html#expe

[dpdk-dev] [PATCH] app/testpmd: fix MPLSoGRE encapsulation

2018-12-04 Thread Dekel Peled
In function cmd_set_mplsogre_encap_parsed(), MPLS label value was set in mplsogre_encap_conf struct without the required offset. As a result the value was copied incorrectly into rte_flow_item_mpls struct. This patch sets MPLS label value in appropriate location at mplsogre_encap_conf struct, so i

[dpdk-dev] [PATCH v2] app/testpmd: fix MPLSoUDP encapsulation

2018-12-04 Thread Dekel Peled
In function cmd_set_mplsoudp_encap_parsed(), MPLS label value was set in mplsoudp_encap_conf struct without the required offset. As a result the value was copied incorrectly into rte_flow_item_mpls struct. This patch sets MPLS label value in appropriate location at mplsoudp_encap_conf struct, so i

Re: [dpdk-dev] [PATCH v2 1/9] cryptodev: add opaque userdata pointer into crypto sym session

2018-12-04 Thread Mohammad Abdul Awal
On 30/11/2018 16:45, Konstantin Ananyev wrote: Add 'uint64_t opaque_data' inside struct rte_cryptodev_sym_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev --- lib/librte_cryptodev/rte_cryptodev.h | 2 ++ 1 file

Re: [dpdk-dev] [PATCH v2 2/9] security: add opaque userdata pointer into security session

2018-12-04 Thread Mohammad Abdul Awal
On 30/11/2018 16:45, Konstantin Ananyev wrote: Add 'uint64_t opaque_data' inside struct rte_security_session. That allows upper layer to easily associate some user defined data with the session. Signed-off-by: Konstantin Ananyev --- lib/librte_security/rte_security.h | 2 ++ 1 file change

Re: [dpdk-dev] [PATCH v2 3/9] net: add ESP trailer structure definition

2018-12-04 Thread Mohammad Abdul Awal
On 30/11/2018 16:46, Konstantin Ananyev wrote: Signed-off-by: Konstantin Ananyev --- lib/librte_net/rte_esp.h | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/librte_net/rte_esp.h b/lib/librte_net/rte_esp.h index f77ec2eb2..8e1b3d2dd 100644 --- a/lib/librte

Re: [dpdk-dev] [PATCH] app/test-pmd: expand test-pmd queue threshold size of RED parameters

2018-12-04 Thread Xu, Rosen
> -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, December 04, 2018 20:29 > To: Xu, Rosen ; dev@dpdk.org > Cc: Dumitrescu, Cristian ; Lu, Wenzhuo > ; Yigit, Ferruh ; Wu, > Jingjing > Subject: RE: [PATCH] app/test-pmd: expand test-pmd queue threshold size of > RED parameters

Re: [dpdk-dev] [PATCH] app/test-pmd: expand test-pmd queue threshold size of RED parameters

2018-12-04 Thread Singh, Jasvinder
> -Original Message- > From: Xu, Rosen > Sent: Monday, November 26, 2018 8:36 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Lu, Wenzhuo > ; Singh, Jasvinder ; Xu, > Rosen ; Yigit, Ferruh ; Wu, > Jingjing > Subject: [PATCH] app/test-pmd: expand test-pmd queue threshold size of RED >

Re: [dpdk-dev] [PATCH] doc: update turbo SW documentation

2018-12-04 Thread Mokhtar, Amr
> -Original Message- > From: Chalupnik, KamilX > Sent: Tuesday 4 December 2018 10:20 > To: dev@dpdk.org > Cc: Mokhtar, Amr ; De Lara Guarch, Pablo > ; akhil.go...@nxp.com; Chalupnik, > KamilX > Subject: [PATCH] doc: update turbo SW documentation > > turbo_sw.rst documentation updated t

[dpdk-dev] [PATCH 18.11] malloc: fix deadlock when using malloc stats

2018-12-04 Thread Anatoly Burakov
Currently, malloc statistics and external heap creation code use memory hotplug lock as a way to synchronize accesses to heaps (as in, locking the hotplug lock to prevent list of heaps from changing under our feet). At the same time, malloc statistics code will also lock the heap because it needs t

Re: [dpdk-dev] [PATCH] bus/vmbus: fix race in sub channel creation

2018-12-04 Thread Mohammed Gamal
On Mon, 2018-12-03 at 08:48 -0800, Stephen Hemminger wrote: > On Mon, 03 Dec 2018 07:02:55 +0100 > Mohammed Gamal wrote: > > > On Fri, 2018-11-30 at 12:24 -0800, Stephen Hemminger wrote: > > > When using multiple queues, there was a race with the kernel > > > in setting up the second channel. Thi

[dpdk-dev] Flow Director vs. 5-tuple filters on a 10GbE Intel 82599 ES NIC

2018-12-04 Thread Georgios Katsikas
Dear all, I am performing rule installation/deletion benchmarks on a dual port 10 GbE Intel 82599 ES NIC using DPDK 18.11. The benchmark installs increasing number of rules (5 to 8000), measures the rule installation rate and latency and then deletes the rules (measuring again the rule deletion ra

[dpdk-dev] [PATCH] doc: update turbo SW documentation

2018-12-04 Thread Kamil Chalupnik
turbo_sw.rst documentation updated to match FlexRAN 18.09 Signed-off-by: Kamil Chalupnik --- doc/guides/bbdevs/turbo_sw.rst | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/doc/guides/bbdevs/turbo_sw.rst b/doc/guides/bbdevs/turbo_sw.rst index 0b96fbb..2

Re: [dpdk-dev] [PATCH] app/testpmd: add boundary check in flow commandline

2018-12-04 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Tuesday, December 4, 2018 5:52 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Peng, Yuan ; Zhao1, Wei > > Subject: [dpdk-dev] [PATCH] app/testpmd: add boundary check in flow > commandline > > T

[dpdk-dev] [PATCH] log: add missing experimental tag

2018-12-04 Thread David Marchand
When rte_log_register_type_and_pick_level() has been introduced, it has been correctly added to the EXPERIMENTAL section of the eal map and the symbol itself has been marked at its definition. However, the declaration of this symbol in rte_log.h is missing the __rte_experimental tag. Because of th

Re: [dpdk-dev] Marking symbols as experimental in the headers only

2018-12-04 Thread David Marchand
On Mon, Dec 3, 2018 at 5:48 PM Neil Horman wrote: > On Mon, Dec 03, 2018 at 02:01:02PM +0100, David Marchand wrote: > > Hello Neil, > > > > Looking at > > > http://doc.dpdk.org/guides/contributing/versioning.html#experimental-apis, > > is there a real need to mark both the definition and the decl