Re: [dpdk-dev] [PATCH v2 1/2] doc: add guide for debug and troubleshoot

2018-11-25 Thread Thomas Monjalon
26/11/2018 04:53, Varghese, Vipin: > Hi Thomas, > > snipped > > > > > > > Signed-off-by: Vipin Varghese > > > Acked-by: Marko Kovacevic > > > > I was in the hope of seeing more reviews for this guide. > > Thanks for the update will wait for feedbacks > > > I have the feeling it is not ready

[dpdk-dev] [PATCH v3 2/2] doc: add guide for debug and troubleshoot

2018-11-25 Thread Vipin Varghese
Add user guide on debug and troubleshoot for common issues and bottleneck found in various application models running on single or multi stages. Signed-off-by: Vipin Varghese Acked-by: Marko Kovacevic --- V3: - reorder for removing warning in 'make doc-guides-html' - Thomas Monjalon V2: - ad

[dpdk-dev] [PATCH v3 1/2] doc: add svg for debug and troubleshoot guide

2018-11-25 Thread Vipin Varghese
Add svg for debug and troubleshoot guide for single or multi stage applications. Signed-off-by: Vipin Varghese Acked-by: Marko Kovacevic --- V3: - reorder for removing warning in 'make doc-guides-html' - Thomas Monjalon V2: - add ACK from Marko - Vipin Varghese --- doc/guides/howto/img/dtg_

Re: [dpdk-dev] [PATCH 02/19] net/ice: support device initialization

2018-11-25 Thread Varghese, Vipin
Thank you, will wait for updated documentation and release notes. > -Original Message- > From: Li, Xiaoyun > Sent: Monday, November 26, 2018 10:49 AM > To: Varghese, Vipin ; Lu, Wenzhuo > ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH 02/

Re: [dpdk-dev] [PATCH 02/19] net/ice: support device initialization

2018-11-25 Thread Li, Xiaoyun
Yes. > -Original Message- > From: Varghese, Vipin > Sent: Monday, November 26, 2018 13:14 > To: Li, Xiaoyun ; Lu, Wenzhuo ; > dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH 02/19] net/ice: support device initialization > > Thanks for the u

Re: [dpdk-dev] [PATCH 02/19] net/ice: support device initialization

2018-11-25 Thread Varghese, Vipin
Thanks for the update, so we can assume all functions are available in secondary. If not supported it will return right error code and documentation is updated for the limitation too. > -Original Message- > From: Li, Xiaoyun > Sent: Monday, November 26, 2018 10:40 AM > To: Varghese, Vipi

Re: [dpdk-dev] [PATCH 02/19] net/ice: support device initialization

2018-11-25 Thread Li, Xiaoyun
Hi > Do we check if process is secondary and ICE PMD is already is initialized? If > we > do not check will we run to multi process reinitilization? Yes. We check. It is in [PATCH 16/19] net/ice: support basic RX/TX. Please see that. We roughly split the ice codes in different patch. So the fil

Re: [dpdk-dev] [PATCH v4 5/9] app/procinfo: add support for show tm

2018-11-25 Thread Varghese, Vipin
Hi Stephen, snipped > > > > > > > > > > > > > > > > > > > > > > > > > > > > + if ((ret) | (!is_leaf)) > > > > > > > > > > + > > > > > > > > > > > > > > > > > > Is the operator here should be || ? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Check is done

Re: [dpdk-dev] [PATCH 19/19] doc: add ICE description and update release note

2018-11-25 Thread Varghese, Vipin
Hi Qiming, Thanks for the update, please feel free to update the limitation in release notes which all are not supported too. Note: do we plan to add test cases (unit) for the same? > -Original Message- > From: Yang, Qiming > Sent: Monday, November 26, 2018 9:13 AM > To: Varghese, Vipin

Re: [dpdk-dev] [PATCH 07/19] net/ice: support MTU setting

2018-11-25 Thread Varghese, Vipin
Hi Qiming > -Original Message- > From: Yang, Qiming > Sent: Monday, November 26, 2018 9:09 AM > To: Varghese, Vipin ; Lu, Wenzhuo > ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Li, Xiaoyun ; > Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH 07/19] net/ice: support MTU setting > > Hi, Vipin > Not sur

Re: [dpdk-dev] [PATCH v2 1/2] doc: add guide for debug and troubleshoot

2018-11-25 Thread Varghese, Vipin
Hi Thomas, snipped > > > > Signed-off-by: Vipin Varghese > > Acked-by: Marko Kovacevic > > I was in the hope of seeing more reviews for this guide. Thanks for the update will wait for feedbacks > I have the feeling it is not ready for prime time. ok > We should take time to discuss what we

Re: [dpdk-dev] [PATCH 19/19] doc: add ICE description and update release note

2018-11-25 Thread Yang, Qiming
Hi, Vipin Not all feature enabled for secondary process. We add secondary process check in each ops like below, if (rte_eal_process_type() == RTE_PROC_SECONDARY) return -E_RTE_SECONDARY; Qiming -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf

Re: [dpdk-dev] [PATCH 07/19] net/ice: support MTU setting

2018-11-25 Thread Yang, Qiming
Hi, Vipin Not sure understand your question. We have no need to configure jumbo frame, because jumbo frame offload will be enable when mtu>1500. Qiming -Original Message- From: Varghese, Vipin Sent: Friday, November 23, 2018 5:58 PM To: Lu, Wenzhuo ; dev@dpdk.org Cc: Lu, Wenzhuo ; Yang,

Re: [dpdk-dev] MLX5 driver - number of descriptors overflow

2018-11-25 Thread Yongseok Koh
> On Nov 21, 2018, at 1:01 AM, Amedeo Sapio wrote: > > Hello, > > I experienced a problem with the MLX5 driver running a code that is working > fine with an Intel card. I have found that the reason of this error is an > overflow of the uint16_t number of descriptors in the mlx driver. > > Here

[dpdk-dev] [dpdk-announce] release candidate 18.11-rc5

2018-11-25 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v18.11-rc5 58 patches (docs and fixes) were integrated. This is the last release candidate for DPDK 18.11. If no objection, the version 18.11.0 will be out on Monday 26th. Please do the very last checks t

Re: [dpdk-dev] [PATCH v3] dev: don't remove devargs that are still referenced

2018-11-25 Thread Thomas Monjalon
23/11/2018 18:04, Maxime Coquelin: > Hi, > > On 11/23/18 4:43 PM, Darek Stojaczyk wrote: > > Even if a device failed to plug, it's still a device > > object that references the devargs. Those devargs will > > be freed automatically together with the device, but > > freeing them any earlier - like

Re: [dpdk-dev] [PATCH] dev: fix devargs memleak on IPC detach request

2018-11-25 Thread Thomas Monjalon
23/11/2018 20:17, Zhang, Qi Z: > From: Stojaczyk, Dariusz > > Device detach triggered through IPC leaked some memory. > > It allocated a devargs objects just to use it for parsing the devargs > > string in order > > to retrieve the device name. Those devargs weren't passed anywhere and were > > ne

Re: [dpdk-dev] [PATCH] dev: don't fail the hotplug request if device is attached in secondary

2018-11-25 Thread Thomas Monjalon
> > Consider the following scenario: > > > > 1) primary process (A) starts, probes the bus > > 2) a secondary process (B) starts, probes the bus > > 3) yet another secondary process (C) starts > > 4) (C) registers the pci driver and hotplugs the device > > * an IPC attach req is sent to th

Re: [dpdk-dev] [PATCH v2] dev: fix attach rollback of a device that was already attached

2018-11-25 Thread Thomas Monjalon
23/11/2018 22:26, Darek Stojaczyk: > When primary process receives an IPC attach request > of a device that's already locally-attached, it > doesn't setup its variables properly and is prone to > segfaulting on a subsequent rollback. > > `ret = local_dev_probe(req->devargs, &dev)` > > The above f

Re: [dpdk-dev] [PATCH] dev: don't try to rollback a device attach that failed

2018-11-25 Thread Thomas Monjalon
21/11/2018 20:05, Darek Stojaczyk: > If a device fails to attach before it's plugged, > the subsequent rollback will still try to detach it, > causing a segfault. Unplugging a device that wasn't > plugged isn't really supported, so this patch adds > an extra error check to prevent that from happeni

Re: [dpdk-dev] [PATCH] vfio: don't needlessly setup devices in secondary process

2018-11-25 Thread Thomas Monjalon
23/11/2018 10:12, Burakov, Anatoly: > On 21-Nov-18 6:41 PM, Darek Stojaczyk wrote: > > Setting up a device that wasn't setup in the primary > > process will possibly break the primary process. That's > > because the IPC message to retrieve the group fd in the > > primary will also *open* that group

Re: [dpdk-dev] [PATCH] bus/pci: fix allocation of PCI device path

2018-11-25 Thread Thomas Monjalon
23/11/2018 12:01, Maxime Coquelin: > On 11/23/18 1:29 AM, Ferruh Yigit wrote: > > The pci_resource_by_index called strlen() on uninitialized > > memory which would lead to the wrong size of memory allocated > > for the path portion of the resource map. This would either cause > > excessively large

Re: [dpdk-dev] [PATCH v3 0/2] IOPL related fixes

2018-11-25 Thread Thomas Monjalon
23/11/2018 23:29, Thomas Monjalon: > 23/11/2018 21:07, Kevin Traynor: > > On 11/23/2018 04:25 PM, Maxime Coquelin wrote: > > > On 11/23/18 4:53 PM, Ilya Maximets wrote: > > >> On 23.11.2018 18:41, Maxime Coquelin wrote: > > >>> On 11/23/18 4:39 PM, Ilya Maximets wrote: > > Patches primary targ

Re: [dpdk-dev] [PATCH v2 1/2] doc: add guide for debug and troubleshoot

2018-11-25 Thread Thomas Monjalon
09/11/2018 16:03, Vipin Varghese: > Add user guide on debug and troubleshoot for common issues and bottleneck > found in various application models running on single or multi stages. > > Signed-off-by: Vipin Varghese > Acked-by: Marko Kovacevic I was in the hope of seeing more reviews for this

Re: [dpdk-dev] [PATCH] doc: hash library programmer guide improvement

2018-11-25 Thread Thomas Monjalon
22/11/2018 18:59, Mcnamara, John: > From: Wang, Yipeng1 > > This commit improves the programmer guide of the hash library to be more > > accurate on new features introduced in 18.11. > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: update commands for pdump

2018-11-25 Thread Thomas Monjalon
22/11/2018 18:54, Mcnamara, John: > From: Bie, Tiwei > > The --server-socket-path and --client-socket-path options have already > > been removed. So also remove them from the doc to avoid confusion. > > Acked-by: John McNamara Applied, thanks