Re: [dpdk-dev] [PATCH] net/thunderx: fix Tx desc corruption in scatter-gather mode

2018-11-11 Thread Verma, Shally
>-Original Message- >From: dev On Behalf Of Nithin Dabilpuram >Sent: 09 November 2018 11:21 >To: dev@dpdk.org; Jacob, Jerin ; Czekaj, >Maciej >Cc: Nilla, Subrahmanyam ; sta...@dpdk.org; >Dabilpuram, Nithin > >Subject: [dpdk-dev] [PATCH] net/thunderx: fix Tx desc corruption in >scatt

Re: [dpdk-dev] [PATCH] doc: document Direct Verbs flow engine limitation

2018-11-11 Thread Shahaf Shuler
Monday, November 12, 2018 8:05 AM, Shahaf Shuler: > Subject: [dpdk-dev] [PATCH] doc: document Direct Verbs flow engine > limitation > > Would be good to add also a code which disable the dv_flow_en the user > requested. However such support will need to use new netlink command to > query the switc

[dpdk-dev] [PATCH] doc: document Direct Verbs flow engine limitation

2018-11-11 Thread Shahaf Shuler
Would be good to add also a code which disable the dv_flow_en the user requested. However such support will need to use new netlink command to query the switchdev mode from the underlying kernel. Considering the current 18.11 release is close to RC3, only a documentation is added. Signed-off-by:

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: fix rule cleanup Netlink command sending

2018-11-11 Thread Slava Ovsiienko
> -Original Message- > From: Yongseok Koh > Sent: Sunday, November 11, 2018 13:42 > To: Slava Ovsiienko > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH 3/3] net/mlx5: fix rule cleanup Netlink command sending > > > > On Nov 10, 2018, at 1:59 AM, Slava Ovsiienko > wrote: > > > >

Re: [dpdk-dev] [PATCH v2 1/1] hash: separate lf and rw lock lookup code paths

2018-11-11 Thread Honnappa Nagarahalli
> > Subject: [PATCH v2 1/1] hash: separate lf and rw lock lookup code > > paths > > > > The lock-free algorithm has caused significant lookup performance > > regression for certain use cases. The regression is attributed to the > > use of non-relaxed memory orderings. 2 versions of the lookup > > f

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] eal: fix build issue

2018-11-11 Thread Jerin Jacob
-Original Message- > Date: Mon, 12 Nov 2018 02:37:15 +0100 > From: Thomas Monjalon > To: Jerin Jacob > Cc: sta...@dpdk.org, "dev@dpdk.org" , Qi Zhang > , Xiao Wang , > "sthem...@microsoft.com" , "shaopeng...@intel.com" > , "Jacob, Jerin" > > Subject: Re: [dpdk-stable] [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement

2018-11-11 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona >Sent: 10 November 2018 06:24 >To: Jozwiak, TomaszX ; Verma, Shally >; dev@dpdk.org; >akhil.go...@nxp.com >Cc: Trahe, Fiona >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance >measurement > >External Email > >Hi Shally, Tom

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] eal: fix build issue

2018-11-11 Thread Thomas Monjalon
07/11/2018 07:59, Jerin Jacob: > drivers/net/fm10k/fm10k_ethdev.c | 11 +++ > lib/librte_eal/common/rte_reciprocal.c | 17 + > 2 files changed, 4 insertions(+), 24 deletions(-) This patch is corrupted, please check.

Re: [dpdk-dev] [PATCH 3/3] app/testpmd: fix callback issue for hot-unplug

2018-11-11 Thread Thomas Monjalon
11/11/2018 08:31, Matan Azrad: > From: Jeff Guo > > On 11/9/2018 1:24 PM, Matan Azrad wrote: > > > From: Jeff Guo > > >> On 11/8/2018 5:35 PM, Matan Azrad wrote: > > >>> From: Jeff Guo > > On 11/8/2018 3:28 PM, Matan Azrad wrote: > > > From: Ananyev, Konstantin > > >> From: Guo, Jia

Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice

2018-11-11 Thread Thomas Monjalon
07/11/2018 18:46, Zhang, Qi Z: > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > On Wed, Nov 07, 2018 at 04:53:50PM +, Zhang, Qi Z wrote: > > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > > > On Tue, Nov 06, 2018 at 09:36:22PM +0100, Thomas Monjalon wrote: > > > > > 06/11/2018

Re: [dpdk-dev] [PATCH v2] bus/pci: update device devargs on each rescan

2018-11-11 Thread Thomas Monjalon
07/11/2018 00:40, Gaëtan Rivet: > On Tue, Nov 06, 2018 at 10:21:38PM +, Zhang, Qi Z wrote: > > From: Dariusz Stojaczyk [mailto:darek.stojac...@gmail.com] > > > From: Darek Stojaczyk > > > > > > Bus rescan is done e.g. during the device hotplug, where devargs are > > > re-allocated. By not upd

Re: [dpdk-dev] [PATCH] test: fix build

2018-11-11 Thread Thomas Monjalon
06/11/2018 20:54, Neil Horman: > On Tue, Nov 06, 2018 at 02:35:01PM +, Ferruh Yigit wrote: > > With "make -C test/" command getting following warnings: > > awk: cmd. line:1: fatal: cannot open file `/cmdline_test/cmdline_test/' > > for reading (No such file or directory) > > awk: cmd. l

Re: [dpdk-dev] [PATCH] telemetry: fix shared build for make

2018-11-11 Thread Thomas Monjalon
09/11/2018 23:19, Ferruh Yigit: > On 11/7/2018 6:10 PM, Kevin Laatz wrote: > > Currently, telemetry is not working for shared builds in make. > > > > The --as-needed flag is preventing telemetry from being linked as there are > > no direct API calls from the app to telemetry. This is causing the >

[dpdk-dev] [PATCH] pci: fix parsing of address without function number

2018-11-11 Thread Thomas Monjalon
If the last part of the PCI address (function number) is missing, the parsing was successful, assuming function 0. The call to strtoul is not returning an error in such a case, so an explicit check is inserted before. This bug has always been there in older parsing macros: - GET_PCIADDR_FI

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/x86: remove unused memcpy file

2018-11-11 Thread Thomas Monjalon
09/11/2018 18:35, Ferruh Yigit: > On 11/9/2018 1:46 PM, Thomas Monjalon wrote: > > The use of rte_memcpy_ptr was removed in revert below, > > but it was missing removing the file arch/x86/rte_memcpy.c. > > > > Fixes: d35cc1fe6a7a ("eal/x86: revert select optimized memcpy at run-time") > > Cc: sta.

Re: [dpdk-dev] [PATCH] devargs: do not replace already inserted devargs

2018-11-11 Thread Thomas Monjalon
08/11/2018 18:12, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 08/11/2018 12:25, Stojaczyk, Dariusz: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > > > The devargs of a device can be replaced by a newly allocated one > > > > when trying to probe again

[dpdk-dev] [PATCH] drivers/net: set close behaviour flag at probing

2018-11-11 Thread Thomas Monjalon
The ethdev flag RTE_ETH_DEV_CLOSE_REMOVE is set for drivers having migrated to the new behaviour of rte_eth_dev_close(). As any other flag, it can be useful to know about its value as soon as the port is probed. Unfortunately, it was set inside the close operation, just before being erased by mems

Re: [dpdk-dev] [PATCH v2 1/1] hash: separate lf and rw lock lookup code paths

2018-11-11 Thread Wang, Yipeng1
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Saturday, November 10, 2018 10:56 AM > To: Richardson, Bruce ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; > hemant.agra...@nxp.com; chao...@linux.vnet.ibm.com; W

[dpdk-dev] 答复: [PATCH v2] mem: accelerate dpdk program startup by reuse page from page cache

2018-11-11 Thread 范建明
Hi, Burakov Thanks very much for your reply. I run the testpmd dpdk18.08 on my router with 200GB huge page configured. And find it still takes 50s in zeroing the 200GB huge page each time the program restarts. As you mentioned app shall calls rte_eal_cleanup() to do the cleanup.

Re: [dpdk-dev] [dpdk-stable] AVX512 bug on SkyLake

2018-11-11 Thread Thomas Monjalon
11/11/2018 15:15, Ananyev, Konstantin: > Hi Thomas, > > > Below is my conclusion for this bug. > > An expert of x86 is required to follow-up. > > > > Summary: > > - CPU: Intel Skylake > > - Linux environment: Ubuntu 18.04 > > - Compiler: GCC 7 or 8 > > - Scenario: testpmd crashes

[dpdk-dev] [PATCH] app/testpmd: fix set L4 len for UDP packets

2018-11-11 Thread Raslan Darawsheh
testpmd only sets the L4 len in case of TCP packets. some PMD's like tap rely on mbuf meta data to calculate csum this will set the L4 len for UDP packets same as TCP Fixes: 160c3dc9 ("app/testpmd: introduce IP parsing functions in csum fwd engine") Signed-off-by: Raslan Darawsheh Signed-off-by

[dpdk-dev] [PATCH 1/3] crypto/octeontx: fix non null terminated string

2018-11-11 Thread Anoob Joseph
If the length of string pointed by 'name' is equal to or greater than the sizeof cptvf->dev_name string, the resultant string will not be null terminated. Using strlcpy would make sure the string would always be null terminated. Fixes: 0dc1cffa4d33 ("crypto/octeontx: add hardware init routine") S

[dpdk-dev] [PATCH 2/3] crypto/octeontx: fix null pointer dereferencing

2018-11-11 Thread Anoob Joseph
Fixes: bfe2ae495ee2 ("crypto/octeontx: add PMD skeleton") Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx/otx_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/octeontx/otx_cryptodev.c b/drivers/crypto/octeontx/otx_cryptodev.c index 269f045..

[dpdk-dev] [PATCH 3/3] crypto/octeontx: fix null pointer dereferencing

2018-11-11 Thread Anoob Joseph
The function otx_cpt_get_resource() would be setting the pointer 'instance'. In case of error, 'instance' would be set to NULL, and returns rte_errno. If rte_errno when 'instance' is set to NULL, it can lead to NULL pointer dereferencing. Fixes: 0961348fdf52 ("crypto/octeontx: add queue pair funct

[dpdk-dev] [PATCH 0/3] fixing coverity reported issues

2018-11-11 Thread Anoob Joseph
Anoob Joseph (3): crypto/octeontx: fix non null terminated string crypto/octeontx: fix null pointer dereferencing crypto/octeontx: fix null pointer dereferencing drivers/crypto/octeontx/otx_cryptodev.c | 2 +- drivers/crypto/octeontx/otx_cryptodev_hw_access.c | 5 - drivers/cr

Re: [dpdk-dev] [dpdk-stable] AVX512 bug on SkyLake

2018-11-11 Thread Ananyev, Konstantin
Hi Thomas, > > Below is my conclusion for this bug. > An expert of x86 is required to follow-up. > > Summary: > - CPU: Intel Skylake > - Linux environment: Ubuntu 18.04 > - Compiler: GCC 7 or 8 > - Scenario: testpmd crashes when it starts forwarding > - Behaviour: A

[dpdk-dev] 2 weeks for FOSDEM talk proposal - join at Brussels in February

2018-11-11 Thread Thomas Monjalon
FOSDEM is looking for interesting talks about SDN, including DPDK and related technologies. What is FOSDEM? It is one of the biggest developper event in the world (8000 attendees, 600 talks): https://fosdem.org/2019/ It happens every year, during the first week-end of February, at Brussels, Belgiu

Re: [dpdk-dev] [PATCH] net/mlx5: quietly fallback if pkg-config is unavailable

2018-11-11 Thread Shahaf Shuler
Saturday, November 10, 2018 12:48 AM, Luca Boccassi: > Subject: [PATCH] net/mlx5: quietly fallback if pkg-config is unavailable > > Don't fail the build if pkg-config can't be found, instead print the linker > flag as > it was doing before the change. > > Fixes: b6b87939193a ("net/mlx5: use pkg-

Re: [dpdk-dev] [PATCH] net/mlx5: fix VXLAN device rollback if rule apply fails

2018-11-11 Thread Shahaf Shuler
Sunday, November 11, 2018 1:34 PM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: fix VXLAN device rollback if rule apply fails > > On Nov 10, 2018, at 2:01 AM, Slava Ovsiienko > wrote: > > > > If rule contains tunneling action (like VXLAN encapsulation) the VTEP > > (Virtual Tunneling EndPoint) d

Re: [dpdk-dev] [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation

2018-11-11 Thread Shahaf Shuler
Sunday, November 11, 2018 1:32 PM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation > > > > On Nov 11, 2018, at 3:15 AM, Shahaf Shuler > wrote: > > > > Such limitation seems not to exist on: > > - MLNX_OFED_linux-4.5-0.3.0.0 (Beta) > > - MLNX_OFED_LINUX-4.

Re: [dpdk-dev] [PATCH 0/3] fix VXLAN related rules cleanup and management

2018-11-11 Thread Shahaf Shuler
Saturday, November 10, 2018 11:59 AM, Slava Ovsiienko: > Subject: [PATCH 0/3] fix VXLAN related rules cleanup and management > > The VXLAN related rule cleanup routine queries and gathers all existing local > IP and neigh rules into buffer list. One buffer may contain multiple rule > deletetion co

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow director add and delete

2018-11-11 Thread Shahaf Shuler
Friday, November 9, 2018 12:12 AM¸ Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: fix flow director add and delete > > > > On Nov 8, 2018, at 1:29 PM, Dekel Peled wrote: > > > > Fix the flow_fdir_cmp() function, used by flow_fdir_filter_lookup(). > > This function is used by flow_fdir_filter_add

Re: [dpdk-dev] [v2] app/testpmd: revert setting default RSS

2018-11-11 Thread Shahaf Shuler
Sunday, November 11, 2018 11:56 AM, Ophir Munk: > Subject: RE: [v2] app/testpmd: revert setting default RSS > > On 09.11.2018 12:38, Ophir Munk wrote: > > > This reverts the patch that enables default RSS action by setting > > > key=NULL and key_len=0. > > > In current testpmd implementation a key

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: fix rule cleanup Netlink command sending

2018-11-11 Thread Yongseok Koh
> On Nov 10, 2018, at 1:59 AM, Slava Ovsiienko wrote: > > The VXLAN related rule cleanup routine queries and gathers all > existing local IP and neigh rules into buffer list. One buffer > may contain multiple rule deletetion commands and is prepared > to send into Netlink as single message. But

Re: [dpdk-dev] [PATCH 2/3] net/mlx5: add Netlink message size check in rule cleanup

2018-11-11 Thread Yongseok Koh
> On Nov 10, 2018, at 1:59 AM, Slava Ovsiienko wrote: > > This patch is preparation for the following fix, we are going to send > Netlink message from buffer in one-by-one fashion. It is highly > desirable to check multimessage buffer consistency for debug purposes. > > Signed-off-by: Viachesl

Re: [dpdk-dev] [PATCH 1/3] net/mlx5: fix buffer allocation check in rule cleanup

2018-11-11 Thread Yongseok Koh
> On Nov 10, 2018, at 1:59 AM, Slava Ovsiienko wrote: > > The Netlink message buffer is allocated and there is the typo, > the other pointer is checked instead of returned one. If no > memory is allocated and NULL is returned by allocation routine > the bug causes segmentation fault. The patch

Re: [dpdk-dev] [PATCH] net/mlx5: fix VXLAN device rollback if rule apply fails

2018-11-11 Thread Yongseok Koh
> On Nov 10, 2018, at 2:01 AM, Slava Ovsiienko wrote: > > If rule contains tunneling action (like VXLAN encapsulation) > the VTEP (Virtual Tunneling EndPoint) device is preconfigured > before appying the rule. If kernel returnsan error this > VTEP configuration should be rolled back to the orig

Re: [dpdk-dev] [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation

2018-11-11 Thread Yongseok Koh
> On Nov 11, 2018, at 3:15 AM, Shahaf Shuler wrote: > > Such limitation seems not to exist on: > - MLNX_OFED_linux-4.5-0.3.0.0 (Beta) > - MLNX_OFED_LINUX-4.4-2.0.7.0 (GA) > - upstream kernel 4.19.0-rc7 > > Signed-off-by: Shahaf Shuler > --- Acked-by: Yongseok Koh Thanks > drivers/net/mlx5/

[dpdk-dev] [PATCH] net/mlx5: remove GRE inner IPv6 matching limitation

2018-11-11 Thread Shahaf Shuler
Such limitation seems not to exist on: - MLNX_OFED_linux-4.5-0.3.0.0 (Beta) - MLNX_OFED_LINUX-4.4-2.0.7.0 (GA) - upstream kernel 4.19.0-rc7 Signed-off-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.

Re: [dpdk-dev] [v2] app/testpmd: revert setting default RSS

2018-11-11 Thread Ophir Munk
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Friday, November 09, 2018 12:43 PM > To: Ophir Munk ; Wenzhuo Lu > ; Jingjing Wu ; Bernard > Iremonger ; dev@dpdk.org; Adrien > Mazarguil > Cc: Asaf Penso ; Shahaf Shuler > ; Thomas Monjalon ; > Olga Shern

Re: [dpdk-dev] [PATCH v2] ethdev: document RSS default key and types

2018-11-11 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Ophir Munk > Sent: Friday, November 9, 2018 10:14 AM > To: Yongseok Koh ; Adrien Mazarguil > ; Andrew Rybchenko > > Cc: Ferruh Yigit ; dev@dpdk.org; Thomas Monjalon > ; Asaf Penso ; Shahaf Shuler > ; Olga Shern > Subject: Re: [dpdk-dev] [P