From: Ananyev, Konstantin
> > -Original Message-
> > From: Guo, Jia
> > Sent: Wednesday, November 7, 2018 7:30 AM
> > To: Matan Azrad ; Ananyev, Konstantin
> > ; Burakov, Anatoly
> > ; Thomas Monjalon
> ;
> > Iremonger, Bernard ; Wu, Jingjing
> > ; Lu, Wenzhuo
> > Cc: Yigit, Ferruh ; dev
From: Jeff Guo
> On 11/6/2018 2:23 PM, Matan Azrad wrote:
> > Hi Jeff
> >
> > Can you detail more in the commit log that we can understand the
> synchronization problematic scenario. And how does this commit fix it?
> >
>
> Please check my reply in the 1/3 mail. And explain more here is that, wh
If bind i40e NICs with PMD and run application, after application quits,
some kernel driver may not be able to set PHY to link up again by
``ifconfig`` after NICs be rebound to kernel driver.
Signed-off-by: Jeff Guo
---
v2->v1:
refine some typo and word.
---
doc/guides/rel_notes/known_issues.rst
From: Jeff Guo
> hi matan
>
> On 11/6/2018 2:22 PM, Matan Azrad wrote:
> > Hi Jeff
> >
> > Can you detail more in the commit log that we can understand the
> deadlock scenario. And how does this commit fix it?
>
>
> Before i add more detail in the commit log of next version, i would explain t
Hi, qi
Mostly accept, please check v2 version for that, thanks.
Best regards,
Jeff Guo
-Original Message-
From: Zhang, Qi Z
Sent: Saturday, October 20, 2018 2:05 AM
To: Guo, Jia ; Xing, Beilei ;
Mcnamara, John ; Kovacevic, Marko
Cc: Wu, Jingjing ; dev@dpdk.org; Zhang, Helin
Subject
On 11/7/18 7:41 PM, Adrien Mazarguil wrote:
On Wed, Nov 07, 2018 at 03:13:07PM +, Ophir Munk wrote:
-Original Message-
From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
Sent: Wednesday, November 07, 2018 4:06 PM
To: Ophir Munk
Cc: Ferruh Yigit ; Andrew Rybchenko
; dev@dpdk.
On 11/8/18 5:09 AM, Wenzhuo Lu wrote:
The new configuration is stored during the process.
But the process may fail. We better rolling the
configuration back as the new one doesn't take effect.
Signed-off-by: Wenzhuo Lu
I would say that the order is wrong. We should fix this bug first and
the
On 11/7/18 9:15 PM, Stephen Hemminger wrote:
Any solution is fine because of that. You could flag it as false in Coverity
or change code to avoid warning. Just want to get it fixed, don't care how.
Done, marked it as false positive in Coverity and provided explanation why.
Andrew.
hi, stephen
On 11/8/2018 3:33 AM, Stephen Hemminger wrote:
On Wed, 7 Nov 2018 17:41:31 +0800
Jeff Guo wrote:
When device is hot-unplugged, the device fd will be deleted in kernel.
Then in the progress of detaching device, if it try to close the fd,
it will cause a kernel crash, which shown a
Hi，Chas Williams
> -Original Message-
> From: Chas Williams [mailto:3ch...@gmail.com]
> Sent: Thursday, November 8, 2018 2:55 AM
> To: Zhao1, Wei ; Luca Boccassi ;
> dev@dpdk.org
> Cc: Lu, Wenzhuo ; Ananyev, Konstantin
> ; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: reduc
> -Original Message-
> From: Luca Boccassi [mailto:bl...@debian.org]
> Sent: Thursday, November 8, 2018 3:10 AM
> To: Chas Williams <3ch...@gmail.com>; Zhao1, Wei ;
> dev@dpdk.org
> Cc: Lu, Wenzhuo ; Ananyev, Konstantin
> ; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: redu
The new configuration is stored during the process.
But the process may fail. We better rolling the
configuration back as the new one doesn't take effect.
Signed-off-by: Wenzhuo Lu
---
lib/librte_ethdev/rte_ethdev.c | 59 ++
1 file changed, 43 insertions(+
The device information cannot be gotten correctly before
the configuration is set. Because on some NICs the
information has dependence on the configuration.
Fixes: 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters")
Signed-off-by: Wenzhuo Lu
---
lib/librte_ethdev/rte_ethdev.c | 21 ++
> -Original Message-
> From: Yigit, Ferruh
> Sent: Thursday, November 8, 2018 3:02 AM
> To: Peng, Yuan ; Zhao1, Wei ;
> dev@dpdk.org
> Cc: sta...@dpdk.org; Lu, Wenzhuo ; Iremonger,
> Bernard
> Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix Rx offload search error
>
> On 11/7/2018 7
Hi Burakov,
Thanks a lot for you review. I will update the change and push the next version
ASAP.
Thanks!
Br,
Tone
-Original Message-
From: Burakov, Anatoly
Sent: Wednesday, November 7, 2018 6:13 PM
To: Tone Zhang (Arm Technology China) ; dev@dpdk.org
Cc: nd
Subject: Re: [dpdk-dev]
The devargs of a device can be replaced by a newly allocated one
when trying to probe again the same device (multi-process or
multi-ports scenarios). This is breaking some pointer references.
It can be avoided by copying the new content, freeing the new devargs,
and returning the already inserted
> > > >
> > > > Coverity spotted self assignment in BPF eval_divmod.
> > >
> > > Yep, there is one.
> > > As I remember I have to add it because one of old versions
> > > of compiler (clang???) complained about 'variable being used
> > > uninitialized'.
> > >
> > > > This looks like a bug where th
Hi Cody,
>Hey Konstantin,
>Thanks for reviewing -- I see your point about this patch only removing one of
>the places where the code makes assumptions about the position of the
>fragmentation header.
>Unfortunately at the moment I don't have the resources to dedicate to writing
>the complete s
07/11/2018 19:58, dwilder:
> On 2018-11-07 02:03, Thomas Monjalon wrote:
> > 05/11/2018 22:20, Pradeep Satyanarayana:
> >> From: Thomas Monjalon
> >> > 30/08/2018 13:58, Christian Ehrhardt:
> >> > > On Thu, Aug 30, 2018 Takeshi T Yoshimura wrote:
> >> > > > Hi,
> >> > > > I could reproduce the is
07/11/2018 20:05, dwilder:
> On 2018-11-07 08:00, Thomas Monjalon wrote:
> > The AltiVec header file breaks boolean type:
> >
> > error: incompatible types when initializing type
> > '__vector _bool int' {aka '_vector(4) __bool int'} using type 'int'
> >
> > If __APPLE_ALTIVEC__ is defined, then
07/11/2018 19:10, Kevin Laatz:
> Currently, telemetry is not working for shared builds in make.
>
> The --as-needed flag is preventing telemetry from being linked as there are
> no direct API calls from the app to telemetry. This is causing the
> --telemetry option to not be recognized by EAL.
> T
Hey Konstantin,
Thanks for reviewing -- I see your point about this patch only removing one
of the places where the code makes assumptions about the position of the
fragmentation header.
Unfortunately at the moment I don't have the resources to dedicate to
writing the complete solution and doing
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, November 7, 2018 7:52 PM
> To: Ananyev, Konstantin
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC 3/5] bpf: fix validation of eal_divmod
>
> On Wed, 7 Nov 2018 12:54:54 +
> "Ana
On Wed, 7 Nov 2018 12:54:54 +
"Ananyev, Konstantin" wrote:
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger
> > Sent: Tuesday, November 6, 2018 9:49 PM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger
> > Subject: [dpdk-dev] [RFC 3/5] bp
On Wed, 7 Nov 2018 17:41:31 +0800
Jeff Guo wrote:
> When device is hot-unplugged, the device fd will be deleted in kernel.
> Then in the progress of detaching device, if it try to close the fd,
> it will cause a kernel crash, which shown a kernel null pointer error.
If this happens, then it is
On Wed, 7 Nov 2018 17:41:30 +0800
Jeff Guo wrote:
> Since the hotplug API and device event API have make public, so in order
> to let applications or driver deal with device directly, it would be
> helpful if the states of device could be exposed, especially for hotplug
> process.
>
> This patc
On Wed, 2018-11-07 at 13:54 -0500, Chas Williams wrote:
>
> On 11/07/2018 04:17 AM, Zhao1, Wei wrote:
> > Hi, Luca Boccassi
> >
> > The purpose of this patch is to reduce the mailbox interrupt
> > from vf to pf, but there seem some point need for discussion in
> > this patch.
> >
> > Firs
On 11/7/2018 3:11 PM, Wiles, Keith wrote:
>
>
>> On Nov 7, 2018, at 1:58 PM, Varghese, Vipin wrote:
>>
>> In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
>> has to be invoked for successful device registration.
>>
>>
>> Signed-off-by: Vipin Varghese
>
> Acked-by: Keith
On 2018-11-07 08:00, Thomas Monjalon wrote:
The AltiVec header file breaks boolean type:
error: incompatible types when initializing type
'__vector _bool int' {aka '_vector(4) __bool int'} using type 'int'
If __APPLE_ALTIVEC__ is defined, then bool type is redefined
and conflicts with stdbool.h
On 11/7/2018 7:58 AM, Peng, Yuan wrote:
<...>
> From: Zhao1, Wei
> Sent: Wednesday, November 7, 2018 2:14 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Peng, Yuan ; Lu, Wenzhuo
> ; Zhao1, Wei
> Subject: [PATCH] app/testpmd: fix Rx offload search error
>
> There is an error in function in funct
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of wangyunjian
> Sent: Tuesday, November 6, 2018 12:57 AM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: stone.z...@huawei.com; Yunjian Wang ;
> sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/e1000: fix uninitialized var
On 2018-11-07 02:03, Thomas Monjalon wrote:
05/11/2018 22:20, Pradeep Satyanarayana:
From: Thomas Monjalon
> 30/08/2018 13:58, Christian Ehrhardt:
> > On Thu, Aug 30, 2018 Takeshi T Yoshimura wrote:
> > > Hi,
> > > I could reproduce the issue you reported in 18.08 with my ppc64le
> > > box wit
On 11/07/2018 04:17 AM, Zhao1, Wei wrote:
Hi, Luca Boccassi
The purpose of this patch is to reduce the mailbox interrupt from vf to
pf, but there seem some point need for discussion in this patch.
First, I do not know why do you change code of function ixgbe_check_mac_link_vf(), beca
Take the 'other interrupt' into account when setting
up MSI-X interrupts and use the proper mask when enabling
it. Also rearm the MSI-X vector after the LSC interrupt fires.
This change allows both LSC and RXQ interrupts to work at the
same time.
Signed-off-by: Timmons C. Player
---
drivers/ne
> -Original Message-
> From: Luca Boccassi [mailto:bl...@debian.org]
> Sent: Wednesday, November 7, 2018 5:55 AM
> To: Zhang, Qi Z ; Chas Williams <3ch...@gmail.com>;
> dev@dpdk.org
> Cc: Lu, Wenzhuo ; Ananyev, Konstantin
> ; sta...@dpdk.org
> Subject: Re: [PATCH v3 1/2] net/ixgbe: fix x5
On 11/7/2018 2:43 AM, Zhao1, Wei wrote:
>
>> -Original Message-
>> From: Ori Kam [mailto:or...@mellanox.com]
>> Sent: Tuesday, November 6, 2018 2:32 PM
>> To: Ori Kam ; Zhao1, Wei
>> Cc: dev@dpdk.org
>> Subject: [PATCH] examples/flow_filtering: fix capability setting
>>
>> The tx offload
On Wed, 7 Nov 2018 09:30:13 +0300
Andrew Rybchenko wrote:
> On 11/6/18 10:30 PM, Stephen Hemminger wrote:
> > There is a potential issue seen by static tools if number of multicast
> > addresses is zero, and rte_realloc of zero size fails (ie returns NULL).
> > This won't happen in real world for
Currently, telemetry is not working for shared builds in make.
The --as-needed flag is preventing telemetry from being linked as there are
no direct API calls from the app to telemetry. This is causing the
--telemetry option to not be recognized by EAL.
Telemetry registers it's EAL option using th
On 11/7/2018 4:30 PM, Burakov, Anatoly wrote:
> On 07-Nov-18 4:01 PM, Ferruh Yigit wrote:
>> On 11/7/2018 1:56 PM, Anatoly Burakov wrote:
>>> On some distributions (such as CentOS 7) lspci may not be installed
>>> by default, causing exceptions which are difficult to interpret.
>>>
>>> Fix devbind
> -Original Message-
> From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com]
> Sent: Wednesday, November 7, 2018 10:15 AM
> To: Zhang, Qi Z
> Cc: Thomas Monjalon ; dev@dpdk.org; Yigit, Ferruh
>
> Subject: Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice
>
> On Wed, Nov 07, 20
On Wed, Nov 07, 2018 at 04:53:50PM +, Zhang, Qi Z wrote:
>
>
> > -Original Message-
> > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com]
> > Sent: Tuesday, November 6, 2018 4:34 PM
> > To: Thomas Monjalon
> > Cc: Zhang, Qi Z ; dev@dpdk.org; Yigit, Ferruh
> >
> > Subject: Re: [dpdk
Hi Wei,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Peng, Yuan
> Sent: Wednesday, November 7, 2018 7:58 AM
> To: Zhao1, Wei ; dev@dpdk.org
> Cc: sta...@dpdk.org; Lu, Wenzhuo
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix Rx offload search error
>
> Tes
> -Original Message-
> From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com]
> Sent: Tuesday, November 6, 2018 4:34 PM
> To: Thomas Monjalon
> Cc: Zhang, Qi Z ; dev@dpdk.org; Yigit, Ferruh
>
> Subject: Re: [dpdk-dev] [PATCH] bus/vdev: fix probe same device twice
>
> On Tue, Nov 06, 2018
On Wed, Nov 07, 2018 at 03:13:07PM +, Ophir Munk wrote:
>
> > -Original Message-
> > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> > Sent: Wednesday, November 07, 2018 4:06 PM
> > To: Ophir Munk
> > Cc: Ferruh Yigit ; Andrew Rybchenko
> > ; dev@dpdk.org; Thomas Monjalon
On 07-Nov-18 4:01 PM, Ferruh Yigit wrote:
On 11/7/2018 1:56 PM, Anatoly Burakov wrote:
On some distributions (such as CentOS 7) lspci may not be installed
by default, causing exceptions which are difficult to interpret.
Fix devbind script to check if lspci is installed at script startup.
I gu
The AltiVec header file breaks boolean type:
error: incompatible types when initializing type
'__vector _bool int' {aka '_vector(4) __bool int'} using type 'int'
If __APPLE_ALTIVEC__ is defined, then bool type is redefined
and conflicts with stdbool.h.
There is no good solution to fix it for the
On 11/7/2018 1:56 PM, Anatoly Burakov wrote:
> On some distributions (such as CentOS 7) lspci may not be installed
> by default, causing exceptions which are difficult to interpret.
>
> Fix devbind script to check if lspci is installed at script startup.
I guess we need lspci for `--status`, bind
On 01-Nov-18 4:04 PM, Ilya Maximets wrote:
If the multispeed fiber link is in DOWN state, ixgbe_setup_link
could take around a second of busy polling. This is highly
inconvenient for the case where single thread periodically
checks the link statuses. For example, OVS main thread
periodically upda
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> Sent: Wednesday, November 07, 2018 4:06 PM
> To: Ophir Munk
> Cc: Ferruh Yigit ; Andrew Rybchenko
> ; dev@dpdk.org; Thomas Monjalon
> ; Asaf Penso ; Shahaf
> Shuler ; Olga Shern
> Subject: Re: [dpdk-dev]
> On Nov 7, 2018, at 1:58 PM, Varghese, Vipin wrote:
>
> In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
> has to be invoked for successful device registration.
>
Acked-by: Keith Wiles
> Signed-off-by: Vipin Varghese
> ---
> ---
> drivers/net/tap/rte_eth_tap.c | 1
Hi Mordechay,
On 7/11/2018 2:09 PM, Mordechay Haimovsky wrote:
This patch replaces the rte_exit routine with error printing when
init_power_library() fails and by that restores the previous behavior
of the program (which was to issue an error message and continue
working if init_power_library fa
This patch replaces the rte_exit routine with error printing when
init_power_library() fails and by that restores the previous behavior
of the program (which was to issue an error message and continue
working if init_power_library fails). This allows the user to still
experience the Rx interrupts f
On Wed, Nov 07, 2018 at 12:39:24PM +, Ophir Munk wrote:
> > -Original Message-
> > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> > Sent: Wednesday, November 07, 2018 11:31 AM
> > To: Ophir Munk
> > Cc: Ferruh Yigit ; Andrew Rybchenko
> > ; dev@dpdk.org; Thomas Monjalon
>
In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
has to be invoked for successful device registration.
Signed-off-by: Vipin Varghese
---
---
drivers/net/tap/rte_eth_tap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/
On some distributions (such as CentOS 7) lspci may not be installed
by default, causing exceptions which are difficult to interpret.
Fix devbind script to check if lspci is installed at script startup.
Cc: sta...@dpdk.org
Signed-off-by: Anatoly Burakov
---
usertools/dpdk-devbind.py | 7 +++
07/11/2018 13:00, Marko Kovacevic:
> Fixing a bug raised in coverity using
> uninitialized value.
>
> Coverity issue: 325881
> Fixes: 527cbf3d5ee3 ("examples/fips_validation: support TDES parsing")
> Cc: marko.kovace...@intel.com
>
> Signed-off-by: Marko Kovacevic
Applied, thanks
07/11/2018 12:47, Ferruh Yigit:
> On 11/7/2018 10:14 AM, Burakov, Anatoly wrote:
> > On 07-Nov-18 9:44 AM, Alejandro Lucero wrote:
> >> Current code has different max DMA mask width values for 32 and 64
> >> bits systems. IOMMU hardware could report a higher supported width
> >> than current MAX_DM
On 07-Nov-18 2:40 AM, Yong Wang wrote:
The library for handling NUMA is not libnuma-devel, but numactl-devel
in Red Hat/Fedora and libnuma-dev in Debian/Ubuntu.
Signed-off-by: Yong Wang
---
v2:
* Add lib name in Ubuntu.
---
Acked-by: Anatoly Burakov
--
Thanks,
Anatoly
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Tuesday, November 6, 2018 9:49 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger
> Subject: [dpdk-dev] [RFC 3/5] bpf: fix validation of eal_divmod
>
> Coverity spotted self assignment in B
On Tue, 2018-11-06 at 23:31 +, Zhang, Qi Z wrote:
> > -Original Message-
> > From: Chas Williams [mailto:3ch...@gmail.com]
> > Sent: Monday, November 5, 2018 11:19 AM
> > To: Zhang, Qi Z ; Luca Boccassi > .org>;
> > dev@dpdk.org
> > Cc: Lu, Wenzhuo ; Ananyev, Konstantin
> > ; sta...@dp
> -Original Message-
> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com]
> Sent: Wednesday, November 07, 2018 11:31 AM
> To: Ophir Munk
> Cc: Ferruh Yigit ; Andrew Rybchenko
> ; dev@dpdk.org; Thomas Monjalon
> ; Asaf Penso ; Shahaf
> Shuler ; Olga Shern
> Subject: Re: [dpdk-dev]
Fixing a bug raised in coverity using
uninitialized value.
Coverity issue: 325881
Fixes: 527cbf3d5ee3 ("examples/fips_validation: support TDES parsing")
Cc: marko.kovace...@intel.com
Signed-off-by: Marko Kovacevic
---
examples/fips_validation/fips_validation_tdes.c | 2 +-
1 file changed, 1 ins
Fixing a bug raised in coverity using
uninitialized value.
Coverity issue: 325881
Fixes: 527cbf3d5ee3 ("examples/fips_validation: support TDES parsing")
Cc: marko.kovace...@intel.com
Signed-off-by: Marko Kovacevic
---
examples/fips_validation/fips_validation_tdes.c | 2 +-
1 file changed, 1 ins
On 11/7/2018 10:14 AM, Burakov, Anatoly wrote:
> On 07-Nov-18 9:44 AM, Alejandro Lucero wrote:
>> Current code has different max DMA mask width values for 32 and 64
>> bits systems. IOMMU hardware could report a higher supported width
>> than current MAX_DMA_MASK_BITS when RTE_ARCH_64 is not define
> -Original Message-
> From: Guo, Jia
> Sent: Wednesday, November 7, 2018 7:30 AM
> To: Matan Azrad ; Ananyev, Konstantin
> ; Burakov, Anatoly
> ; Thomas Monjalon ;
> Iremonger, Bernard ; Wu,
> Jingjing ; Lu, Wenzhuo
> Cc: Yigit, Ferruh ; dev@dpdk.org; Zhang, Helin
> ; He, Shaopeng
>
> -Original Message-
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Tuesday, November 6, 2018 4:40 PM
> To: Jozwiak, TomaszX ; dev@dpdk.org; Trahe,
> Fiona ; akhil.go...@nxp.com
> Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance
> measurement
>
>
>
> -Original Message-
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Tuesday, November 6, 2018 4:37 PM
> To: Jozwiak, TomaszX ; dev@dpdk.org; Trahe,
> Fiona ; akhil.go...@nxp.com
> Subject: RE: [PATCH v2 2/3] app/compress-perf: add performance
> measurement
>
>
>
> >---
On 07-Nov-18 9:44 AM, Alejandro Lucero wrote:
Current code has different max DMA mask width values for 32 and 64
bits systems. IOMMU hardware could report a higher supported width
than current MAX_DMA_MASK_BITS when RTE_ARCH_64 is not defined. This
is actually true with a 32 bits kernel running i
On 07-Nov-18 4:55 AM, Tone Zhang (Arm Technology China) wrote:
Hi Burakov,
Please find my test case below. Thanks!
Br,
Tone
-Original Message-
From: Burakov, Anatoly
Sent: Tuesday, November 6, 2018 7:03 PM
To: Tone Zhang (Arm Technology China) ; dev@dpdk.org
Cc: nd
Subject: Re: [dpdk
> On Nov 6, 2018, at 7:30 PM, Stephen Hemminger
> wrote:
>
> Static analysis tools don't like the fact that fd could be zero
> in the error path. This won't happen in real world because
> stdin would have to be closed, then other error occurring.
Acked-by: Keith Wiles
>
> Coverity issue: 1
05/11/2018 22:20, Pradeep Satyanarayana:
> From: Thomas Monjalon
> > 30/08/2018 13:58, Christian Ehrhardt:
> > > On Thu, Aug 30, 2018 Takeshi T Yoshimura wrote:
> > > > Hi,
> > > > I could reproduce the issue you reported in 18.08 with my ppc64le
> > > > box with RedHat 7.5 and GCC4.8.
> > > > Th
> On Nov 6, 2018, at 7:30 PM, Stephen Hemminger
> wrote:
>
> If netlink socket setup fails the file descriptor was leaked.
Acked-by: Keith Wiles
>
> Coverity issue: 257040
> Fixes: 7c25284e30c2 ("net/tap: add netlink back-end for flow API")
> Signed-off-by: Stephen Hemminger
> ---
> drive
Hi and sorry for the delay.
On Thu, Oct 18, 2018 at 06:42:52AM +, Peng, Yuan wrote:
> Hi Adrien,
>
> I have a doubt about the action rss types in rte_flow.
> testpmd> flow create 0 ingress pattern end actions rss types end / end
>
> what is the expected function of the command?
> Does it mea
> -Original Message-
> From: Li Han [mailto:han@zte.com.cn]
> Sent: Wednesday, November 7, 2018 6:10 AM
> To: Pattan, Reshma
> Cc: dev@dpdk.org; Li Han
> Subject: [PATCH v3] [dpdk-dev] app/proc-info: fix port mask parse issue
>
> parse_portmask return type is int,but global variab
Current code has different max DMA mask width values for 32 and 64
bits systems. IOMMU hardware could report a higher supported width
than current MAX_DMA_MASK_BITS when RTE_ARCH_64 is not defined. This
is actually true with a 32 bits kernel running in a 64 bits server
with IOMMU hardware. This cou
Hi，Sam
https://bugs.dpdk.org/buglist.cgi?bug_status=__open__&list_id=835&product=DPDK
report here, and give out your problem step by step.
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Sam
> Sent: Wednesday, November 7, 2018 3:55 PM
> To: dev@dpdk.org
> Su
Add svg for debug and troubleshoot guide for single or
multi stage applications.
Signed-off-by: Vipin Varghese
---
---
doc/guides/howto/img/dtg_consumer_ring.svg| 19
doc/guides/howto/img/dtg_crypto.svg | 16 +++
.../howto/img/dtg_distributor_worker.svg | 31 ++
do
Add user guide for debug and troubleshoot for common issues and bottleneck
found in various application models running on single or multi stages.
Signed-off-by: Vipin Varghese
---
---
doc/guides/howto/debug_troubleshoot_guide.rst | 349 ++
doc/guides/howto/index.rst
Since the hotplug API and device event API have make public, so in order
to let applications or driver deal with device directly, it would be
helpful if the states of device could be exposed, especially for hotplug
process.
This patch will add some devices states in rte device structure
to recode
When device is hot-unplugged, the device fd will be deleted in kernel.
Then in the progress of detaching device, if it try to close the fd,
it will cause a kernel crash, which shown a kernel null pointer error.
This patch aim to fix this issue by checking the device state to decide
whether the fd
Since the hotplug API and device event API have make public, so in order
to let applications or driver deal with device directly, it would be
helpful if the states of device could be exposed. Especially for hotplug
process, when device is hot-unplugged, some invalid process should be
skipped by che
On Wed, Nov 07, 2018 at 09:23:42AM +, Ophir Munk wrote:
> struct rte_flow_action_rss include fields 'key' and 'types'.
> Field 'key' is a pointer to bytes array (uint8_t *) which contains the
> specific RSS hash key.
> If an application is only interested in default RSS operation it
> should no
struct rte_flow_action_rss include fields 'key' and 'types'.
Field 'key' is a pointer to bytes array (uint8_t *) which contains the
specific RSS hash key.
If an application is only interested in default RSS operation it
should not care about the specific hash key. The application can set
the hash k
Hi, Luca Boccassi
The purpose of this patch is to reduce the mailbox interrupt from vf to pf,
but there seem some point need for discussion in this patch.
First, I do not know why do you change code of function
ixgbe_check_mac_link_vf(), because in rte_eth_link_get_nowait() and
rte_eth_li
> On Nov 6, 2018, at 9:30 PM, Yongseok Koh wrote:
>
>
>> On Nov 5, 2018, at 6:06 AM, Wiles, Keith wrote:
>>
>>
>>
>>> On Nov 2, 2018, at 9:04 PM, Yongseok Koh wrote:
>>>
>>> This is a workaround to prevent a crash, which might be caused by
>>> optimization of newer gcc (7.3.0) on Intel
The caller will guarantee that msg won't be null. Remove
the unneeded null pointer check which caused a Coverity
warning.
Coverity issue: 323484
Fixes: 8f972312b8f4 ("vhost: support vhost-user")
Cc: sta...@dpdk.org
Signed-off-by: Tiwei Bie
---
lib/librte_vhost/vhost_user.c | 2 +-
1 file change
Coverity issue: 302861
Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0")
Signed-off-by: Tiwei Bie
---
This patch can't be backported because it depends on the
API change introduced by below commit in this release.
commit e8d435f1f3a1 ("bus/pci: harmonize return value of config read")
d
Tiwei Bie (2):
net/virtio: fix unchecked return value
vhost: remove unneeded null pointer check
drivers/net/virtio/virtio_pci.c | 10 --
lib/librte_vhost/vhost_user.c | 2 +-
2 files changed, 9 insertions(+), 3 deletions(-)
--
2.19.1
88 matches
Mail list logo
