Re: [dpdk-dev] [pull-request] next-qos 18.11 PRE-RC2

02/11/2018 13:37, Cristian Dumitrescu: > http://dpdk.org/git/next/dpdk-next-qos > > Leah Tekoa (1): > app/testpmd: fix RED byte stats > > Rosen Xu (2): > app/test-pmd: fix shaper profile params > doc/guides/testp

Re: [dpdk-dev] [PATCH v2 3/3] net/mlx5: remove flags setting from flow preparation

> -Original Message- > From: Yongseok Koh > Sent: Monday, November 5, 2018 9:21 AM > To: Shahaf Shuler > Cc: dev@dpdk.org; Ori Kam ; Yongseok Koh > > Subject: [PATCH v2 3/3] net/mlx5: remove flags setting from flow preparation > > Even though flow_drv_prepare() takes item_flags and ac

Re: [dpdk-dev] [PATCH v2 2/3] net/mlx5: fix Direct Verbs flow tunnel

> -Original Message- > From: Yongseok Koh > Sent: Monday, November 5, 2018 9:21 AM > To: Shahaf Shuler > Cc: dev@dpdk.org; Ori Kam ; Yongseok Koh > > Subject: [PATCH v2 2/3] net/mlx5: fix Direct Verbs flow tunnel > > 1) Fix layer parsing > In translation of tunneled flows, dev_flow->l

Re: [dpdk-dev] [PATCH 2/3] devargs: delay freeing previous devargs when overriding them

Hi, 05/11/2018 08:04, Darek Stojaczyk: > -int __rte_experimental > -rte_devargs_insert(struct rte_devargs *da) > +void __rte_experimental > +rte_devargs_insert(struct rte_devargs *da, struct rte_devargs **prev_da) You should update the API section of the release notes. > { > - int ret; >

[dpdk-dev] [PATCH v2 3/3] net/mlx5: remove flags setting from flow preparation

Even though flow_drv_prepare() takes item_flags and action_flags to be filled in, those are not used and will be overwritten by parsing of flow_drv_translate(). There's no reason to keep the flags and fill it. Appropriate notes are added to the documentation of flow_drv_prepare() and flow_drv_trans

[dpdk-dev] [PATCH v2 2/3] net/mlx5: fix Direct Verbs flow tunnel

1) Fix layer parsing In translation of tunneled flows, dev_flow->layers must not be used to check tunneled layer as it contains all the layers parsed from flow_drv_prepare(). Checking tunneled layer is needed to distinguish between outer and inner item. This should be based on dynamic parsing. With

[dpdk-dev] [PATCH v2 1/3] net/mlx5: fix Verbs flow tunnel

1) Fix layer parsing In translation of tunneled flows, dev_flow->layers must not be used to check tunneled layer as it contains all the layers parsed from flow_drv_prepare(). Checking tunneled layer is needed to set IBV_FLOW_SPEC_INNER and it should be based on dynamic parsing. With dev_flow->layer

[dpdk-dev] [PATCH v2 0/3] net/mlx5: fix tunnel flow

v2: * rebase on top of the latest branch tip * change function names appropriately Yongseok Koh (3): net/mlx5: fix Verbs flow tunnel net/mlx5: fix Direct Verbs flow tunnel net/mlx5: remove flags setting from flow preparation drivers/net/mlx5/mlx5_flow.c | 38 +-- drivers/net/mlx5/ml

[dpdk-dev] [PATCH 3/3] eal: handle bus rescan failures during hotplug

Fixes for devargs dangling pointers and various segfaults caused by failed hotplug requests. If rescan failed, we have one the following scenarios to cover: a) the device was never scanned at all; the devargs that were just allocated are not referenced anywhere and can be removed straight

[dpdk-dev] [PATCH 1/3] bus/pci: update device devargs on each rescan

Bus rescan is done e.g. during the device hotplug, where devargs are re-allocated. By not updating the rte_device->devargs pointer we potentially make it a dangling one, as previous devargs could have been (or will be soon) freed. Fixes: 55e411b301c3 ("bus/pci: fix resource mapping override") Cc:

[dpdk-dev] [PATCH 2/3] devargs: delay freeing previous devargs when overriding them

In eal hotplug path, the previous devargs may be still referenced by device structs at the time the rte_devargs_insert() is called. Those references are updated almost immediately afterwards, but in cases something goes wrong and they cannot be updated, we might want to still keep the old devargs a

Re: [dpdk-dev] DEV_RX_OFFLOAD_VLAN_EXTEND offload

05/11/2018 05:22, Zhao1, Wei: > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > From: "Zhao1, Wei" > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > > > > From: Ferruh Yigit > > > > > On 10/26/2018 11:56 AM, Jerin Jacob wrote: > > > > > > > > > > > > Does anyo

Re: [dpdk-dev] [dpdk-stable] [PATCH 6/8] net/qede: correct offload not supported mask

> -Original Message- > From: dev On Behalf Of Ferruh Yigit > Sent: Saturday, November 3, 2018 1:32 AM > To: Patil, Harish > Cc: Xiaolong Ye ; Qi Zhang ; > Beilei Xing ; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 6/8] net/qede: correct offload > not > sup

Re: [dpdk-dev] [PATCH 2/3] net/mlx5: fix Direct Verbs flow tunnel

> On Nov 4, 2018, at 10:08 PM, Ori Kam wrote: > > > >> -Original Message- >> From: Yongseok Koh >> Sent: Monday, November 5, 2018 7:38 AM >> To: Ori Kam >> Cc: Shahaf Shuler ; dev@dpdk.org >> Subject: Re: [PATCH 2/3] net/mlx5: fix Direct Verbs flow tunnel >> >> On Sun, Nov 04, 2018

Re: [dpdk-dev] [PATCH 2/3] net/mlx5: fix Direct Verbs flow tunnel

> -Original Message- > From: Yongseok Koh > Sent: Monday, November 5, 2018 7:38 AM > To: Ori Kam > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH 2/3] net/mlx5: fix Direct Verbs flow tunnel > > On Sun, Nov 04, 2018 at 01:22:34AM -0700, Ori Kam wrote: > > > > > -Original Mes

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: remove flags setting from flow preparation

On Sun, Nov 04, 2018 at 01:29:13AM -0700, Ori Kam wrote: > > > > -Original Message- > > From: dev On Behalf Of Yongseok Koh > > Sent: Friday, November 2, 2018 11:08 PM > > To: Shahaf Shuler > > Cc: dev@dpdk.org; Yongseok Koh > > Subject: [dpdk-dev] [PATCH 3/3] net/mlx5: remove flags se

Re: [dpdk-dev] [PATCH 2/3] net/mlx5: fix Direct Verbs flow tunnel

On Sun, Nov 04, 2018 at 01:22:34AM -0700, Ori Kam wrote: > > > -Original Message- > > From: Yongseok Koh > > Sent: Friday, November 2, 2018 11:08 PM > > To: Shahaf Shuler > > Cc: dev@dpdk.org; Yongseok Koh ; Ori Kam > > > > Subject: [PATCH 2/3] net/mlx5: fix Direct Verbs flow tunnel > >

[dpdk-dev] [PATCH v1] net/e1000: update Tx offload mask

Tx offload mask is updated in following commit: 1037ed842c37 ("mbuf: fix Tx offload mask") Currently, the new added offload flags are not supported in PMD and application will fail to call PMD transmit prepare function. This patch updates IGB_TX_OFFFLOAD_MASK. Fixes: 1037ed842c37 ("mbuf: fix Tx o

Re: [dpdk-dev] DEV_RX_OFFLOAD_VLAN_EXTEND offload

Hi, Jerin Jacob > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Thursday, November 1, 2018 6:34 PM > To: Zhao1, Wei > Cc: Yigit, Ferruh ; dev@dpdk.org; > tho...@monjalon.net; arybche...@solarflare.com; > olivier.m...@6wind.com; Zhang, Qi Z ; Xing,

[dpdk-dev] [PATCH v4] net/i40e: fix Rx instability with vector mode

Previously, there is instability during vector Rx if descriptor number is not power of 2, e.g. process hang and some Rx packets are unexpectedly empty. That's because vector Rx mode assumes Rx descriptor number is power of 2 when doing bit mask. This patch allows vector mode only when the number of

Re: [dpdk-dev] [dpdk-stable] [PATCH 0/8] Correct XXX_TX_OFFLOAD_NOTSUP_MASK

Hi, Ferruh On 11/02, Ferruh Yigit wrote: >On 10/27/2018 11:40 AM, Xiaolong Ye wrote: >> Hi, >> >> This patch series is to correct the wrong setting of >> XXX_TX_OFFLOAD_MASK in multiple PMDs. >> >> Just as the name XXX_TX_OFFLOAD_NOTSUP_MASK indicates, it should be the >> mask of unsupported fea

[dpdk-dev] Fwd: Disable receiving new flows on a core

Begin forwarded message: From: chintanin...@outlook.com Date: November 1, 2018 at 6:19:49 PM PDT To: us...@dpdk.org Subject: Disable receiving new flows on a core Hi, We use RSS for distributing flows across cores. Sometimes, in special

Re: [dpdk-dev] [PATCH v2 0/7] fix DMA mask check

02/11/2018 19:38, Ferruh Yigit: > On 11/1/2018 7:53 PM, Alejandro Lucero wrote: > > A patchset sent introducing DMA mask checks has several critical > > issues precluding apps to execute. The patchset was reviewed and > > finally accepted after three versions. Obviously it did not go > > through t

Re: [dpdk-dev] [PATCH] doc: fix pdf build

02/11/2018 17:31, Mcnamara, John: > From: Kovacevic, Marko > > PDF build was failing in the howto guides found the weird character > > causing the issue > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] eal: fix build with gcc 9.0

02/11/2018 20:06, Ferruh Yigit: > build error: > In function ‘eal_plugin_add’, > .../lib/librte_eal/common/eal_common_options.c:225:2: > error: ‘strncpy’ output may be truncated copying 4095 bytes from a >string of length 4095 [-Werror=stringop-truncation] > strncpy(solib->n

Re: [dpdk-dev] [PATCH] eal: fix broken rte strerror

02/11/2018 18:20, Ferruh Yigit: > On 11/2/2018 9:41 AM, Thomas Monjalon wrote: > > 02/11/2018 09:11, Jerin Jacob: > >> errno_autotest testcase were failed since > >> commit 5d7b673d5fd6 ("mk: build with _GNU_SOURCE defined by default") > >> RTE>>errno_autotest > >> rte_strerror: 'Unknown error 11',

Re: [dpdk-dev] [PATCH] crypto/scheduler: fix build with gcc 8.2

03/11/2018 15:58, Jerin Jacob: > build_error: > > drivers/crypto/scheduler/scheduler_pmd.c: In function ‘parse_name_arg’: > drivers/crypto/scheduler/scheduler_pmd.c:372:2: error: ‘strncpy’ > specified bound 64 equals destination size [-Werror=stringop-truncation] > strncpy(params->name, value, R

Re: [dpdk-dev] [PATCH v3] build: disable gcc AVX512F support

03/11/2018 02:06, Yongseok Koh: > This is a workaround to prevent a crash, which might be caused by > optimization of newer gcc (7.3.0) on Intel Skylake. > > This disables AVX512F support of gcc by adding -mno-avx512f if it is > disabled in DPDK (CONFIG_RTE_ENABLE_AVX512=n). > > This does not app

Re: [dpdk-dev] [PATCH] examples/vm_power: fix app to respect max cpus

31/10/2018 12:50, David Hunt: > The vm_power_manager app was not respecting the POWER_MGR_MAX_CPUS > during initialisation, so if there were more CPUs than this value (64), > it would lead to buffer overruns of there were more then 64 cores in > the system. > > Added in a check during init and un-

Re: [dpdk-dev] [PATCH v3] devtools: add explicit warning messages for forbidden tokens

02/11/2018 11:52, Arnon Warshavsky: > Replace the content of warning in the forbidden tokens script > from using the searched regex into using explicit messages > > Signed-off-by: Arnon Warshavsky Applied, thanks

Re: [dpdk-dev] [PATCH v3] examples/client_server_mp: add sigint handler to server

27/09/2018 13:51, Raslan Darawsheh: > add sigint handler in the server application to stop and close ports > > Signed-off-by: Raslan Darawsheh Applied, thanks

Re: [dpdk-dev] [PATCH v5] net/mlx5: set RSS key to NULL to indicate default RSS

Sunday, November 4, 2018 2:10 PM, Ophir Munk: > Subject: [PATCH v5] net/mlx5: set RSS key to NULL to indicate default RSS > > Applications which add RSS rules must supply an RSS key and length. > If an application is only interested in default RSS operation it should not > care > about the exact

[dpdk-dev] [RFC] ethdev: introduce DMA memory mapping for external memory

Request for comment on the high level changes present on this patch. The need to use external memory (memory belong to application and not part of the DPDK hugepages) is allready present. Starting from storage apps which prefer to manage their own memory blocks for efficient use of the storage dev

[dpdk-dev] [PATCH] net/mlx5: support flow counters using devx

This commit adds counters support when creating flows via direct verbs. The implementation uses devx interface in order to create query and delete the counters. This support requires MLNX_OFED_LINUX-4.5-0.1.0.1 installation. devx support in the firmware is enabled via the "mcra /dev/mst/ 0x3ce4.7:1

[dpdk-dev] [PATCH v5] net/mlx5: set RSS key to NULL to indicate default RSS

Applications which add RSS rules must supply an RSS key and length. If an application is only interested in default RSS operation it should not care about the exact RSS key. By setting the key to NULL - the PMD will use the default RSS key. In addition if the application does not care about the RSS

[dpdk-dev] [PATCH] doc: update testpmd user guide for clarity

The description of prefix for mask creation was misunderstood. I updated the description, so it is clearly understood which mask will be created by a certain prefix. Signed-off-by: Dekel Peled --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [dpdk-dev] [PATCH v4] net/mlx5: set RSS key to NULL to indicate default RSS

> -Original Message- > From: Shahaf Shuler > Sent: Sunday, November 04, 2018 8:29 AM > To: Ophir Munk ; Yongseok Koh > ; dev@dpdk.org > Cc: Asaf Penso ; Thomas Monjalon > ; Olga Shern > Subject: RE: [PATCH v4] net/mlx5: set RSS key to NULL to indicate default > RSS > > Hi Ophir, > > Sa

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: remove flags setting from flow preparation

> -Original Message- > From: dev On Behalf Of Yongseok Koh > Sent: Friday, November 2, 2018 11:08 PM > To: Shahaf Shuler > Cc: dev@dpdk.org; Yongseok Koh > Subject: [dpdk-dev] [PATCH 3/3] net/mlx5: remove flags setting from flow > preparation > > Even though flow_drv_prepare() takes

Re: [dpdk-dev] [PATCH 2/3] net/mlx5: fix Direct Verbs flow tunnel

> -Original Message- > From: Yongseok Koh > Sent: Friday, November 2, 2018 11:08 PM > To: Shahaf Shuler > Cc: dev@dpdk.org; Yongseok Koh ; Ori Kam > > Subject: [PATCH 2/3] net/mlx5: fix Direct Verbs flow tunnel > > 1) Fix layer parsing > In translation of tunneled flows, dev_flow->laye

Re: [dpdk-dev] [PATCH 1/3] net/mlx5: fix Verbs flow tunnel

> -Original Message- > From: Yongseok Koh > Sent: Friday, November 2, 2018 11:08 PM > To: Shahaf Shuler > Cc: dev@dpdk.org; Yongseok Koh ; Ori Kam > > Subject: [PATCH 1/3] net/mlx5: fix Verbs flow tunnel > > 1) Fix layer parsing > In translation of tunneled flows, dev_flow->layers mus

Re: [dpdk-dev] [PATCH v8 0/7] add encap and decap actions to Direct Verbs flow in MLX5 PMD

Thursday, November 1, 2018 7:18 PM, Ferruh Yigit: > > The dependent patch looks OK, but I wonder why I don't see the build error. > > mlx5_flow_dv.c has a big `#ifdef HAVE_IBV_FLOW_DV_SUPPORT` block > > And `HAVE_IBV_FLOW_DV_SUPPORT` set: > if `infiniband/mlx5dv.h` has `mlx5dv_create_flow_action