[dpdk-dev] [PATCH v5 13/13] net/mlx5: add E-switch VXLAN rule cleanup routines

2018-11-02 Thread Slava Ovsiienko
The last part of patchset contains the rule cleanup routines. These ones is the part of outer interface initialization at the moment of VXLAN VTEP attaching. These routines query the list of attached VXLAN devices, the list of local IP addresses with peer and link scope attribute and the list of pe

[dpdk-dev] [PATCH v5 12/13] net/mlx5: add E-Switch VXLAN encapsulation rules

2018-11-02 Thread Slava Ovsiienko
VXLAN encap rules are applied to the VF ingress traffic and have the VTEP as actual redirection destinations instead of outer PF. The encapsulation rule should provide: - redirection action VF->PF - VF port ID - some inner network parameters (MACs/IP) - the tunnel outer source IP (v4/v6) - the tunn

[dpdk-dev] [PATCH v5 11/13] net/mlx5: add E-switch VXLAN tunnel devices management

2018-11-02 Thread Slava Ovsiienko
VXLAN interfaces are dynamically created for each local UDP port of outer networks and then used as targets for TC "flower" filters in order to perform encapsulation. These VXLAN interfaces are system-wide, the only one device with given UDP port can exist in the system (the attempt of creating ano

[dpdk-dev] [PATCH v5 09/13] net/mlx5: update E-Switch VXLAN netlink routines

2018-11-02 Thread Slava Ovsiienko
This part of patchset updates Netlink exchange routine. Message sequence numbers became not random ones, the multipart reply messages are supported, not propagating errors to the following socket calls, Netlink replies buffer size is increased to MNL_SOCKET_BUFFER_SIZE and now is preallocated at co

[dpdk-dev] [PATCH v5 10/13] net/mlx5: fix E-Switch Flow counter deletion

2018-11-02 Thread Slava Ovsiienko
The counters for E-Switch rules were erroneously deleted in flow_tcf_remove() routine. The counters deletion is moved to flow_tcf_destroy() routine. Fixes: e1114ff6a5ab ("net/mlx5: support e-switch flow count action") Cc: Moti Haimovsky Suggested-by: Adrien Mazarguil Signed-off-by: Viacheslav O

[dpdk-dev] [PATCH v5 08/13] net/mlx5: add VXLAN support to flow translate routine

2018-11-02 Thread Slava Ovsiienko
This part of patchset adds support of VXLAN-related items and actions to the flow translation routine. Later some tunnel types, other than VXLAN can be addedd (GRE). No VTEP devices are created at this point, the flow rule is just translated, not applied yet. Suggested-by: Adrien Mazarguil Signed

[dpdk-dev] [PATCH v5 06/13] net/mlx5: add E-Switch VXLAN support to validation routine

2018-11-02 Thread Slava Ovsiienko
This patch adds VXLAN support for flow item/action lists validation. The following entities are now supported: - RTE_FLOW_ITEM_TYPE_VXLAN, contains the tunnel VNI - RTE_FLOW_ACTION_TYPE_VXLAN_DECAP, if this action is specified the items in the flow items list treated as outer network paramet

[dpdk-dev] [PATCH v5 07/13] net/mlx5: add VXLAN support to flow prepare routine

2018-11-02 Thread Slava Ovsiienko
The e-switch Flow prepare function is updated to support VXLAN encapsulation/and decapsulation actions. The function calculates buffer size for Netlink message and Flow description structures, including optional ones for tunneling purposes. Suggested-by: Adrien Mazarguil Signed-off-by: Viacheslav

[dpdk-dev] [PATCH v5 05/13] net/mlx5: swap items/actions validations for E-Switch rules

2018-11-02 Thread Slava Ovsiienko
The rule validation function for E-Switch checks item list first, then action list is checked. This patch swaps the validation order, now actions are checked first. This is preparation for validation function update with VXLAN tunnel actions. VXLAN decapsulation action requires to check the items i

[dpdk-dev] [PATCH v5 04/13] net/mlx5: add necessary structures for E-Switch VXLAN

2018-11-02 Thread Slava Ovsiienko
This patch introduces the data structures needed to implement VXLAN encapsulation/decapsulation hardware offload support for E-Switch. Suggested-by: Adrien Mazarguil Signed-off-by: Viacheslav Ovsiienko Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.h | 9 drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH v5 03/13] net/mlx5: add necessary definitions for E-Switch VXLAN

2018-11-02 Thread Slava Ovsiienko
This patch contains tc flower related and some other definitions needed to implement VXLAN encapsulation/decapsulation hardware offload support for E-Switch. mlx5 driver dynamically creates and manages the VXLAN virtual tunnel endpoint devices, the following definitions control the parameters of t

[dpdk-dev] [PATCH v5 02/13] net/mlx5: prepare meson.build for adding E-Switch VXLAN

2018-11-02 Thread Slava Ovsiienko
This patch updates meson.build before adding E-Switch VXLAN encapsulation/decapsulation hardware offload support. E-Switch rules are controlled via tc Netilnk commands, so we need to include tc related headers, and check for some tunnel specific key definitions. Suggested-by: Adrien Mazarguil Sig

[dpdk-dev] [PATCH v5 01/13] net/mlx5: prepare makefile for adding E-Switch VXLAN

2018-11-02 Thread Slava Ovsiienko
This patch updates makefile before adding E-Switch VXLAN encapsulation/decapsulation hardware offload support. E-Switch rules are controlled via tc Netilnk commands, so we need to include tc related headers, and check for some tunnel specific key definitions. Suggested-by: Adrien Mazarguil Signed

[dpdk-dev] [PATCH v5 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload

2018-11-02 Thread Slava Ovsiienko
This patchset adds the VXLAN encapsulation/decapsulation hardware offload feature for E-Switch. A typical use case of tunneling infrastructure is port representors in switchdev mode, with VXLAN traffic encapsulation performed on traffic coming *from* a representor and decapsulation on traffic go

Re: [dpdk-dev] [PATCH] pci_vfio: Support 64KB kernel page_size with vfio-pci driver

2018-11-02 Thread Tone Zhang (Arm Technology China)
Hi Burakov, Thanks! Please check my feedback below. Br, Tone -Original Message- From: dev On Behalf Of Burakov, Anatoly Sent: Thursday, November 1, 2018 6:01 PM To: Tone Zhang (Arm Technology China) ; dev@dpdk.org Cc: nd Subject: Re: [dpdk-dev] [PATCH] pci_vfio: Support 64KB kernel pag

Re: [dpdk-dev] Question about rte_manage_timer() and eal_intr_handle_interrupts

2018-11-02 Thread Somnath Kotur
Hi Anatoly/keith, I just tried using rte_eal_alarm_set() in the driver like so: rte_eal_alarm_set(US_PER_S * 2, timer0_cb, (void *)data); The moment i start this off, i stop getting async events/interrupt notifications in my driver ...I'm hitting the same problem as it was be

Re: [dpdk-dev] Question about rte_manage_timer() and eal_intr_handle_interrupts

2018-11-02 Thread Somnath Kotur
Thank you Anatoly and keith for your replies. What i still don't get is why the two cannot seem to co-exist? That is , whenever this while loop was running in the EAL thread that i showed in the code, my driver would stop receiving interrupts/async events ...Do we understand that? But you are righ

Re: [dpdk-dev] [PATCH v5 2/2] ring: move the atomic load of head above the loop

2018-11-02 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Bruce Richardson > Sent: Friday, November 2, 2018 7:44 PM > To: Gavin Hu (Arm Technology China) > Cc: dev@dpdk.org; tho...@monjalon.net; step...@networkplumber.org; > olivier.m...@6wind.com; chao...@linux.vnet.ibm.com; > konstantin.anan...@intel.com; jerin.

[dpdk-dev] [PATCH v3] build: disable gcc AVX512F support

2018-11-02 Thread Yongseok Koh
This is a workaround to prevent a crash, which might be caused by optimization of newer gcc (7.3.0) on Intel Skylake. This disables AVX512F support of gcc by adding -mno-avx512f if it is disabled in DPDK (CONFIG_RTE_ENABLE_AVX512=n). This does not apply to the meson build as that doesn't have suc

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: disable compiler AVX512F support

2018-11-02 Thread Yongseok Koh
On Fri, Nov 02, 2018 at 09:46:09PM +, Ferruh Yigit wrote: > On 11/2/2018 8:59 PM, Yongseok Koh wrote: > > On Fri, Nov 02, 2018 at 01:48:11PM +, Ferruh Yigit wrote: > >> On 11/2/2018 12:42 PM, Ferruh Yigit wrote: > >>> On 10/23/2018 10:23 PM, Yongseok Koh wrote: > This is a workaround t

Re: [dpdk-dev] [PATCH v4 08/13] net/mlx5: add VXLAN support to flow translate routine

2018-11-02 Thread Yongseok Koh
> On Nov 2, 2018, at 2:53 PM, Yongseok Koh wrote: > > On Fri, Nov 02, 2018 at 10:53:20AM -0700, Slava Ovsiienko wrote: >> This part of patchset adds support of VXLAN-related items and >> actions to the flow translation routine. Later some tunnel types, >> other than VXLAN can be addedd (GRE). N

Re: [dpdk-dev] [PATCH v4 08/13] net/mlx5: add VXLAN support to flow translate routine

2018-11-02 Thread Yongseok Koh
On Fri, Nov 02, 2018 at 10:53:20AM -0700, Slava Ovsiienko wrote: > This part of patchset adds support of VXLAN-related items and > actions to the flow translation routine. Later some tunnel types, > other than VXLAN can be addedd (GRE). No VTEP devices are created at > this point, the flow rule is

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: disable compiler AVX512F support

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 8:59 PM, Yongseok Koh wrote: > On Fri, Nov 02, 2018 at 01:48:11PM +, Ferruh Yigit wrote: >> On 11/2/2018 12:42 PM, Ferruh Yigit wrote: >>> On 10/23/2018 10:23 PM, Yongseok Koh wrote: This is a workaround to prevent a crash, which might be caused by optimization of newer g

Re: [dpdk-dev] [PATCH v4 07/13] net/mlx5: add VXLAN support to flow prepare routine

2018-11-02 Thread Yongseok Koh
On Fri, Nov 02, 2018 at 10:53:19AM -0700, Slava Ovsiienko wrote: > The e-switch Flow prepare function is updated to support VXLAN > encapsulation/and decapsulation actions. The function calculates > buffer size for Netlink message and Flow description structures, > including optional ones for tunne

[dpdk-dev] [PATCH 3/3] net/mlx5: remove flags setting from flow preparation

2018-11-02 Thread Yongseok Koh
Even though flow_drv_prepare() takes item_flags and action_flags to be filled in, those are not used and will be overwritten by parsing of flow_drv_translate(). There's no reason to keep the flags and fill it. Appropriate notes are added to the documentation of flow_drv_prepare() and flow_drv_trans

[dpdk-dev] [PATCH 2/3] net/mlx5: fix Direct Verbs flow tunnel

2018-11-02 Thread Yongseok Koh
1) Fix layer parsing In translation of tunneled flows, dev_flow->layers must not be used to check tunneled layer as it contains all the layers parsed from flow_drv_prepare(). Checking tunneled layer is needed to distinguish between outer and inner item. This should be based on dynamic parsing. With

[dpdk-dev] [PATCH 1/3] net/mlx5: fix Verbs flow tunnel

2018-11-02 Thread Yongseok Koh
1) Fix layer parsing In translation of tunneled flows, dev_flow->layers must not be used to check tunneled layer as it contains all the layers parsed from flow_drv_prepare(). Checking tunneled layer is needed to set IBV_FLOW_SPEC_INNER and it should be based on dynamic parsing. With dev_flow->layer

[dpdk-dev] ubuntu 14.04 and intel controller 82574L not working

2018-11-02 Thread Avinash Chaurasia
Hi, I am using ubuntu 14.04 with intel controller 82574L and I am neither able to send any packets or receive. My dpdk version is 17.11. However, when I switched to ubuntu 16.04, it worked with vfio-pci driver. Is something wrong with 82574L driver in ubuntu 14.04? Thanks Avinash Kumar Chaurasia

[dpdk-dev] [PATCH v2] build: disable compiler AVX512F support

2018-11-02 Thread Yongseok Koh
This is a workaround to prevent a crash, which might be caused by optimization of newer gcc (7.3.0) on Intel Skylake. Bugzilla ID: 97 Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- v2: * disable the flag only in case of gcc config/x86/meson.build | 5 + mk/rte.cpuflags.mk | 7 ++

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: disable compiler AVX512F support

2018-11-02 Thread Yongseok Koh
On Fri, Nov 02, 2018 at 01:48:11PM +, Ferruh Yigit wrote: > On 11/2/2018 12:42 PM, Ferruh Yigit wrote: > > On 10/23/2018 10:23 PM, Yongseok Koh wrote: > >> This is a workaround to prevent a crash, which might be caused by > >> optimization of newer gcc (7.3.0) on Intel Skylake. > >> > >> Bugzil

Re: [dpdk-dev] [PATCH] net/enic: use rte macro for attribute weak

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 5:49 AM, Hyong Youb Kim wrote: > Fixes: 8a6ff33d6d36 ("net/enic: add AVX2 based vectorized Rx handler") > > Signed-off-by: Hyong Youb Kim Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH] vhost/crypto: fix inferred misuse of enum

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 8:22 PM, Ferruh Yigit wrote: > On 11/1/2018 2:15 PM, stable-boun...@dpdk.org wrote: >> Fix inffered misuse of enum rte_crypto_cipher_algorithm and >> rte_crypto_auth_algorithm >> >> Coverity issue 277202 >> >> Fixes: e80a98708166 ("vhost/crypto: add session message handler") >> Cc: sta

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: clarify TSO Tx offload prerequisite

2018-11-02 Thread Ferruh Yigit
On 11/1/2018 1:33 PM, Ferruh Yigit wrote: > On 11/1/2018 8:46 AM, Jerin Jacob wrote: >> Based on the PKT_TX_TCP_SEG definition, >> the application needs to update PKT_TX_IPV4 or PKT_TX_IPV6 >> based on IPV4 or IPV6 packet and PKT_TX_IP_CKSUM ol_flags >> to enable Tx TSO offload. >> >> Fixes: dad1ec

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix port status for new bonded devices

2018-11-02 Thread Ferruh Yigit
On 11/1/2018 12:11 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Nicolau, Radu >> Sent: Thursday, November 1, 2018 11:21 AM >> To: dev@dpdk.org >> Cc: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard ; >> Doherty, Declan ; ch...@att.com; Nicolau, Radu >> ; sta...@dpdk.org >

Re: [dpdk-dev] [PATCH v2] net/bonding: fix segfault when creating bonded device

2018-11-02 Thread Ferruh Yigit
On 10/31/2018 4:14 PM, Chas Williams wrote: > > > On 10/31/2018 11:50 AM, Radu Nicolau wrote: >> After the patch below the call to rte_eth_bond_8023ad_agg_selection_set >> from probe() segfaults; there is no need to call the function, just set >> the mode directly. >> Also, reverted 1620175b400e.

Re: [dpdk-dev] [PATCH] net/ena: remove resources when port is being closed

2018-11-02 Thread Ferruh Yigit
On 10/31/2018 2:53 PM, Michal Krawczyk wrote: > The new API introduced in 18.11 is suggesting, that the driver should > release all it's resources at the dev_close routine. > > All resources previously released in uninit routine during PCI removal, > are now being released at the dev_close and the

Re: [dpdk-dev] [PATCH] net/qede/base: fix to initialize HW for LLH filters

2018-11-02 Thread Ferruh Yigit
On 10/31/2018 12:27 AM, Mody, Rasesh wrote: > During initalization of leading PF, we need to initialize HW for LLH > filters. Set HW init parameter to set the eingine affinity for > multiple engine adapters. > > Fixes: 3eed444a9621 ("net/qede/base: changes for 100G") > > Signed-off-by: Rasesh Mod

Re: [dpdk-dev] [PATCH] ethdev: fix redundant function pointer check

2018-11-02 Thread Ferruh Yigit
On 10/28/2018 9:43 AM, Thomas Monjalon wrote: > 28/10/2018 02:46, Ferruh Yigit: >> RTE_FUNC_PTR_OR_ERR_RET() already does the `ethdev_uninit` NULL check. >> >> Fixes: e489007a411c ("ethdev: add generic create/destroy ethdev APIs") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Ferruh Yigit > > Acked

Re: [dpdk-dev] [PATCH] app/testpmd: fix possible uninitialized variable usage

2018-11-02 Thread Ferruh Yigit
On 10/30/2018 10:59 AM, Iremonger, Bernard wrote: >> -Original Message- >> From: Yigit, Ferruh >> Sent: Sunday, October 28, 2018 2:17 AM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org >> Subject: [PATCH] app/testpmd: fix possi

Re: [dpdk-dev] [dpdk-stable] [PATCH] vhost/crypto: fix inferred misuse of enum

2018-11-02 Thread Ferruh Yigit
On 11/1/2018 2:15 PM, stable-boun...@dpdk.org wrote: > Fix inffered misuse of enum rte_crypto_cipher_algorithm and > rte_crypto_auth_algorithm > > Coverity issue 277202 > > Fixes: e80a98708166 ("vhost/crypto: add session message handler") > Cc: sta...@dpdk.org > > Signed-off-by: Fan Zhang Revi

Re: [dpdk-dev] [dpdk-stable] [PATCH 6/8] net/qede: correct offload not supported mask

2018-11-02 Thread Ferruh Yigit
On 10/27/2018 11:40 AM, Xiaolong Ye wrote: > Previously XXX_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead > to unexpected result, correct it by using a NOT-AND operation. > > Fixes: 29540be7efce ("net/qede: support LRO/TSO offloads") > > Cc: harish.pa...@qlogic.com > Cc: sta...@dpdk

Re: [dpdk-dev] [dpdk-stable] [PATCH 0/8] Correct XXX_TX_OFFLOAD_NOTSUP_MASK

2018-11-02 Thread Ferruh Yigit
On 10/27/2018 11:40 AM, Xiaolong Ye wrote: > Hi, > > This patch series is to correct the wrong setting of > XXX_TX_OFFLOAD_MASK in multiple PMDs. > > Just as the name XXX_TX_OFFLOAD_NOTSUP_MASK indicates, it should be the > mask of unsupported features (either not in PKT_TX_OFFLOAD_MASK or in > X

[dpdk-dev] [PATCH v2] test/bpf: use hton instead of _builtin_bswap

2018-11-02 Thread Malvika Gupta
From: Malvika Gupta Convert host machine endianness to networking endianness for comparison of incoming packets with BPF filter Suggested-by: Brian Brooks Signed-off-by: Malvika Gupta Reviewed-by: Gavin Hu Reviewed-by: Konstantin Ananyev Acked-by: Honnappa Nagarahalli --- v2: * Correct comp

Re: [dpdk-dev] [PATCH v2 0/7] fix DMA mask check

2018-11-02 Thread Ferruh Yigit
On 11/1/2018 7:53 PM, Alejandro Lucero wrote: > A patchset sent introducing DMA mask checks has several critical > issues precluding apps to execute. The patchset was reviewed and > finally accepted after three versions. Obviously it did not go > through the proper testing what can be explained, a

[dpdk-dev] [PATCH v2 1/2] bus/dpaa: fix build with gcc 9.0

2018-11-02 Thread Ferruh Yigit
build error: In function ‘fman_if_init’, .../drivers/bus/dpaa/base/fman/fman.c:186:2: error: ‘strncpy’ output may be truncated copying 4095 bytes from a string of length 4095 [-Werror=stringop-truncation] strncpy(__if->node_path, dpa_node->full_name, PATH_MAX - 1); strncpy m

[dpdk-dev] [PATCH v2 2/2] eal: fix build with gcc 9.0

2018-11-02 Thread Ferruh Yigit
build error: In function ‘eal_plugin_add’, .../lib/librte_eal/common/eal_common_options.c:225:2: error: ‘strncpy’ output may be truncated copying 4095 bytes from a string of length 4095 [-Werror=stringop-truncation] strncpy(solib->name, path, PATH_MAX-1); strncpy may result

[dpdk-dev] FW: [PATCH v2] net/mlx5: set RSS key to NULL to indicate default RSS

2018-11-02 Thread Ophir Munk
> -Original Message- > From: Shahaf Shuler > Sent: Thursday, November 01, 2018 4:01 PM > To: Ophir Munk ; dev@dpdk.org; Yongseok Koh > > Cc: Thomas Monjalon ; Olga Shern > ; Asaf Penso > Subject: RE: [PATCH v2] net/mlx5: set RSS key to NULL to indicate > default RSS > > Hi Ophir, >

[dpdk-dev] [PATCH v4 08/13] net/mlx5: add VXLAN support to flow translate routine

2018-11-02 Thread Slava Ovsiienko
This part of patchset adds support of VXLAN-related items and actions to the flow translation routine. Later some tunnel types, other than VXLAN can be addedd (GRE). No VTEP devices are created at this point, the flow rule is just translated, not applied yet. Suggested-by: Adrien Mazarguil Signed

[dpdk-dev] [PATCH v4 09/13] net/mlx5: update E-Switch VXLAN netlink routines

2018-11-02 Thread Slava Ovsiienko
This part of patchset updates Netlink exchange routine. Message sequence numbers became not random ones, the multipart reply messages are supported, not propagating errors to the following socket calls, Netlink replies buffer size is increased to MNL_SOCKET_BUFFER_SIZE and now is preallocated at co

[dpdk-dev] [PATCH v4 13/13] net/mlx5: add E-switch VXLAN rule cleanup routines

2018-11-02 Thread Slava Ovsiienko
The last part of patchset contains the rule cleanup routines. These ones is the part of outer interface initialization at the moment of VXLAN VTEP attaching. These routines query the list of attached VXLAN devices, the list of local IP addresses with peer and link scope attribute and the list of pe

[dpdk-dev] [PATCH v4 12/13] net/mlx5: add E-Switch VXLAN encapsulation rules

2018-11-02 Thread Slava Ovsiienko
VXLAN encap rules are applied to the VF ingress traffic and have the VTEP as actual redirection destinations instead of outer PF. The encapsulation rule should provide: - redirection action VF->PF - VF port ID - some inner network parameters (MACs/IP) - the tunnel outer source IP (v4/v6) - the tunn

[dpdk-dev] [PATCH v4 11/13] net/mlx5: add E-switch VXLAN tunnel devices management

2018-11-02 Thread Slava Ovsiienko
VXLAN interfaces are dynamically created for each local UDP port of outer networks and then used as targets for TC "flower" filters in order to perform encapsulation. These VXLAN interfaces are system-wide, the only one device with given UDP port can exist in the system (the attempt of creating ano

[dpdk-dev] [PATCH v4 10/13] net/mlx5: fix E-Switch Flow counter deletion

2018-11-02 Thread Slava Ovsiienko
The counters for E-Switch rules were erroneously deleted in flow_tcf_remove() routine. The counters deletion is moved to flow_tcf_destroy() routine. Fixes: e1114ff6a5ab ("net/mlx5: support e-switch flow count action") Cc: Moti Haimovsky Suggested-by: Adrien Mazarguil Signed-off-by: Viacheslav O

[dpdk-dev] [PATCH v4 06/13] net/mlx5: add E-Switch VXLAN support to validation routine

2018-11-02 Thread Slava Ovsiienko
This patch adds VXLAN support for flow item/action lists validation. The following entities are now supported: - RTE_FLOW_ITEM_TYPE_VXLAN, contains the tunnel VNI - RTE_FLOW_ACTION_TYPE_VXLAN_DECAP, if this action is specified the items in the flow items list treated as outer network paramet

[dpdk-dev] [PATCH v4 05/13] net/mlx5: swap items/actions validations for E-Switch rules

2018-11-02 Thread Slava Ovsiienko
The rule validation function for E-Switch checks item list first, then action list is checked. This patch swaps the validation order, now actions are checked first. This is preparation for validation function update with VXLAN tunnel actions. VXLAN decapsulation action requires to check the items i

[dpdk-dev] [PATCH v4 07/13] net/mlx5: add VXLAN support to flow prepare routine

2018-11-02 Thread Slava Ovsiienko
The e-switch Flow prepare function is updated to support VXLAN encapsulation/and decapsulation actions. The function calculates buffer size for Netlink message and Flow description structures, including optional ones for tunneling purposes. Suggested-by: Adrien Mazarguil Signed-off-by: Viacheslav

[dpdk-dev] [PATCH v4 04/13] net/mlx5: add necessary structures for E-Switch VXLAN

2018-11-02 Thread Slava Ovsiienko
This patch introduces the data structures needed to implement VXLAN encapsulation/decapsulation hardware offload support for E-Switch. Suggested-by: Adrien Mazarguil Signed-off-by: Viacheslav Ovsiienko Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.h | 9 drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH v4 01/13] net/mlx5: prepare makefile for adding E-Switch VXLAN

2018-11-02 Thread Slava Ovsiienko
This patch updates makefile before adding E-Switch VXLAN encapsulation/decapsulation hardware offload support. E-Switch rules are controlled via tc Netilnk commands, so we need to include tc related headers, and check for some tunnel specific key definitions. Suggested-by: Adrien Mazarguil Signed

[dpdk-dev] [PATCH v4 00/13] net/mlx5: e-switch VXLAN encap/decap hardware offload

2018-11-02 Thread Slava Ovsiienko
This patchset adds the VXLAN encapsulation/decapsulation hardware offload feature for E-Switch. A typical use case of tunneling infrastructure is port representors in switchdev mode, with VXLAN traffic encapsulation performed on traffic coming *from* a representor and decapsulation on traffic go

[dpdk-dev] [PATCH v4 02/13] net/mlx5: prepare meson.build for adding E-Switch VXLAN

2018-11-02 Thread Slava Ovsiienko
This patch updates meson.build before adding E-Switch VXLAN encapsulation/decapsulation hardware offload support. E-Switch rules are controlled via tc Netilnk commands, so we need to include tc related headers, and check for some tunnel specific key definitions. Suggested-by: Adrien Mazarguil Sig

[dpdk-dev] [PATCH v4 03/13] net/mlx5: add necessary definitions for E-Switch VXLAN

2018-11-02 Thread Slava Ovsiienko
This patch contains tc flower related and some other definitions needed to implement VXLAN encapsulation/decapsulation hardware offload support for E-Switch. mlx5 driver dynamically creates and manages the VXLAN virtual tunnel endpoint devices, the following definitions control the parameters of t

[dpdk-dev] [Bug 105] Cannot create crypto_openssl after vdev_uninit

2018-11-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=105 Bug ID: 105 Summary: Cannot create crypto_openssl after vdev_uninit Product: DPDK Version: 18.08 Hardware: x86 OS: Linux Status: CONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH v2 0/4] hash: deprecate lock ellision and read/write concurreny flags

2018-11-02 Thread Honnappa Nagarahalli
> > On Thu, Nov 01, 2018 at 06:25:18PM -0500, Honnappa Nagarahalli wrote: > > Various configuration flags in rte_hash library result in increase of > > number of test cases. Configuration flags for enabling transactional > > memory use and read/write concurrency are not required. These features >

Re: [dpdk-dev] [PATCH] eal: fix broken rte strerror

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 9:41 AM, Thomas Monjalon wrote: > 02/11/2018 09:11, Jerin Jacob: >> errno_autotest testcase were failed since >> commit 5d7b673d5fd6 ("mk: build with _GNU_SOURCE defined by default") >> RTE>>errno_autotest >> rte_strerror: 'Unknown error 11', >> strerror: 'Resource temporarily unavaila

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Ferruh Yigit
On 10/31/2018 5:19 PM, Ferruh Yigit wrote: > rte_strerror uses strerror_r(), and strerror_r() has two version of it. > - XSI-compliant version, (_POSIX_C_SOURCE >= 200112L) && ! _GNU_SOURCE > - GNU-specific version > > Those two has different return types, so the exiting return type check > is no

Re: [dpdk-dev] [PATCH 1/2] net/virtio: do not re-enter clean up routines

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 4:48 PM, Maxime Coquelin wrote: > > > On 11/2/18 4:19 PM, Chas Williams wrote: >> >> >> On 11/02/2018 10:33 AM, Ferruh Yigit wrote: >>> On 11/1/2018 2:45 PM, Luca Boccassi wrote: On Mon, 2017-07-17 at 19:05 -0400, Charles (Chas) Williams wrote: > .dev_uninit calls .dev_stop

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/ixgbe: fix x550 code to handle unidentified PHY

2018-11-02 Thread Luca Boccassi
On Fri, 2018-11-02 at 16:49 +, Zhang, Qi Z wrote: > > -Original Message- > > From: Luca Boccassi [mailto:bl...@debian.org] > > Sent: Friday, November 2, 2018 10:21 AM > > To: Zhang, Qi Z ; dev@dpdk.org > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > ; sta...@dpdk.org > > Subject: Re: [PAT

Re: [dpdk-dev] [PATCH] doc: cryptodev deprecation notice for sym session changes

2018-11-02 Thread Zhang, Roy Fan
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Konstantin > Ananyev > Sent: Thursday, October 11, 2018 3:20 PM > To: dev@dpdk.org > Cc: Ananyev, Konstantin > Subject: [dpdk-dev] [PATCH] doc: cryptodev deprecation notice for sym > session changes > Acked-by: F

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 3:45 PM, Jerin Jacob wrote: > -Original Message- >> Date: Fri, 2 Nov 2018 15:39:04 + >> From: Ferruh Yigit >> To: Jerin Jacob >> CC: Bruce Richardson , "dev@dpdk.org" >> , "sta...@dpdk.org" >> Subject: Re: [dpdk-dev] [PATCH] eal: fix API to get error string >> User-Agen

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix x550 code to handle unidentified PHY

2018-11-02 Thread Zhang, Qi Z
> -Original Message- > From: Luca Boccassi [mailto:bl...@debian.org] > Sent: Friday, November 2, 2018 10:21 AM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; sta...@dpdk.org > Subject: Re: [PATCH 1/2] net/ixgbe: fix x550 code to handle unidentified PHY > > O

Re: [dpdk-dev] [PATCH 1/2] net/virtio: do not re-enter clean up routines

2018-11-02 Thread Maxime Coquelin
On 11/2/18 4:19 PM, Chas Williams wrote: On 11/02/2018 10:33 AM, Ferruh Yigit wrote: On 11/1/2018 2:45 PM, Luca Boccassi wrote: On Mon, 2017-07-17 at 19:05 -0400, Charles (Chas) Williams wrote: .dev_uninit calls .dev_stop and .dev_close.  The work that is done in those routines doesn't ne

Re: [dpdk-dev] [PATCH] doc: fix pdf build

2018-11-02 Thread Kovacevic, Marko
All appreciations can be shown here Thomas :) https://mobro.co/13793316 And had help from John :) > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, November 2, 2018 4:44 PM > To: Kovacevic, Marko > Cc: dev@dpdk.org; Mcnamara, John ; > ciara.po...@i

Re: [dpdk-dev] [PATCH] doc: fix pdf build

2018-11-02 Thread Thomas Monjalon
02/11/2018 14:38, Marko Kovacevic: > PDF build was failing in the howto guides > found the weird character causing the issue [...] > -* Python ≥ 2.5 > +* Python >= 2.5 I spent some time on it and gave up. You are my hero :)

Re: [dpdk-dev] [PATCH] doc: fix pdf build

2018-11-02 Thread Mcnamara, John
> -Original Message- > From: Kovacevic, Marko > Sent: Friday, November 2, 2018 1:38 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; tho...@monjalon.net; > Kovacevic, Marko ; ciara.po...@intel.com > Subject: [PATCH] doc: fix pdf build > > PDF build was failing in the howto guides found the wei

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Ferruh Yigit
On 11/1/2018 1:40 PM, Thomas Monjalon wrote: > 01/11/2018 13:46, Ferruh Yigit: >> On 10/31/2018 6:43 PM, Thomas Monjalon wrote: >>> 31/10/2018 19:26, Ferruh Yigit: On 10/31/2018 6:26 PM, Ferruh Yigit wrote: > On 10/31/2018 5:16 PM, Thomas Monjalon wrote: >> 31/10/2018 18:19, Ferruh Yig

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 3:45 PM, Jerin Jacob wrote: > -Original Message- >> Date: Fri, 2 Nov 2018 15:39:04 + >> From: Ferruh Yigit >> To: Jerin Jacob >> CC: Bruce Richardson , "dev@dpdk.org" >> , "sta...@dpdk.org" >> Subject: Re: [dpdk-dev] [PATCH] eal: fix API to get error string >> User-Agen

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Jerin Jacob
-Original Message- > Date: Fri, 2 Nov 2018 15:39:04 + > From: Ferruh Yigit > To: Jerin Jacob > CC: Bruce Richardson , "dev@dpdk.org" > , "sta...@dpdk.org" > Subject: Re: [dpdk-dev] [PATCH] eal: fix API to get error string > User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) G

Re: [dpdk-dev] [PATCH] eal: fix API to get error string

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 9:51 AM, Jerin Jacob wrote: > -Original Message- >> Date: Wed, 31 Oct 2018 17:19:28 + >> From: Ferruh Yigit >> To: Bruce Richardson >> CC: dev@dpdk.org, Ferruh Yigit , sta...@dpdk.org >> Subject: [dpdk-dev] [PATCH] eal: fix API to get error string >> X-Mailer: git-send-em

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix x550 code to handle unidentified PHY

2018-11-02 Thread Luca Boccassi
On Fri, 2018-11-02 at 14:11 +, Zhang, Qi Z wrote: > > -Original Message- > > From: Luca Boccassi [mailto:bl...@debian.org] > > Sent: Thursday, November 1, 2018 9:04 AM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > ; Zhang, Qi Z ; > > Luca > > Boccassi ; sta...@dpdk.

Re: [dpdk-dev] [PATCH 1/2] net/virtio: do not re-enter clean up routines

2018-11-02 Thread Chas Williams
On 11/02/2018 10:33 AM, Ferruh Yigit wrote: On 11/1/2018 2:45 PM, Luca Boccassi wrote: On Mon, 2017-07-17 at 19:05 -0400, Charles (Chas) Williams wrote: .dev_uninit calls .dev_stop and .dev_close. The work that is done in those routines doesn't need repeated. Use started and opened to trac

[dpdk-dev] [PATCH v3 2/2] net/ixgbe: add LHA ID to x550 code

2018-11-02 Thread Luca Boccassi
ixgbe is able to recognize 1G SX and LX id, but it is missing the LHA. Add it, so that it can handle LHA sfp plugin. Fixes: d2e72774e58c ("ixgbe/base: support X550") Cc: sta...@dpdk.org Signed-off-by: Luca Boccassi --- drivers/net/ixgbe/base/ixgbe_82599.c | 2 ++ drivers/net/ixgbe/base/ixgbe_p

[dpdk-dev] [PATCH v3 1/2] net/ixgbe: fix x550 code to handle unidentified PHY

2018-11-02 Thread Luca Boccassi
ixgbe_identify_sfp_module_X550em() was missing the code to handle unidentified PHY that has been there in 82599 so it was not able to complete initialization of ixgbe sequence if no sfp plugged in. Port it over to return an appropriate type and complete init sequence properly. Fixes: d2e72774e58c

Re: [dpdk-dev] [PATCH] doc: fix pdf build

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 1:38 PM, Marko Kovacevic wrote: > PDF build was failing in the howto guides > found the weird character causing the issue > > Fixes: 6e9270eab112 ("doc: add telemetry how-to") > Cc: ciara.po...@intel.com > > Signed-off-by: Marko Kovacevic Tested-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] net: fix compilation with GRE header

2018-11-02 Thread Ferruh Yigit
On 11/1/2018 12:46 PM, Shahaf Shuler wrote: > The following error popped when compiling with -pedantic: > > In file included from > /.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/ > mlx5/mlx5_flow_dv.c:28:0: > /.autodirect/swgwork/shahafs/workspace/dpdk.org/ > build/include/rte_gre.h:

Re: [dpdk-dev] [PATCH v4 0/2] vhost: packed ring support completion

2018-11-02 Thread Maxime Coquelin
On 11/2/18 2:42 PM, Tiwei Bie wrote: On Wed, Oct 31, 2018 at 11:26:38AM +0100, Maxime Coquelin wrote: In this v4, it restores back to only save last avail index and its wrap counter value at get time, and restore both used and avail indexes to avail values at set time. The change compared to

Re: [dpdk-dev] Question about rte_manage_timer() and eal_intr_handle_interrupts

2018-11-02 Thread Wiles, Keith
> On Nov 2, 2018, at 9:35 AM, Wiles, Keith wrote: > > Sorry, meant to hit cancel for my previous email, Anatoly answered it correctly. Regards, Keith

Re: [dpdk-dev] Question about rte_manage_timer() and eal_intr_handle_interrupts

2018-11-02 Thread Wiles, Keith
> On Nov 2, 2018, at 6:31 AM, Burakov, Anatoly > wrote: > > On 02-Nov-18 4:00 AM, Somnath Kotur wrote: >> Hello, >>I'm trying to launch a thread - lcore_mainloop( from >> examples/timer/main.c ) that runs rte_manage_timer() every 2s from testpmd >> to ensure the timers i've registered

Re: [dpdk-dev] [PATCH 1/2] net/virtio: do not re-enter clean up routines

2018-11-02 Thread Ferruh Yigit
On 11/1/2018 2:45 PM, Luca Boccassi wrote: > On Mon, 2017-07-17 at 19:05 -0400, Charles (Chas) Williams wrote: >> .dev_uninit calls .dev_stop and .dev_close.  The work that is done in >> those routines doesn't need repeated.  Use started and opened to >> track >> the adapter's status. >> >> Signed-

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix x550 code to handle unidentified PHY

2018-11-02 Thread Zhang, Qi Z
> -Original Message- > From: Luca Boccassi [mailto:bl...@debian.org] > Sent: Thursday, November 1, 2018 9:04 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhang, Qi Z ; Luca > Boccassi ; sta...@dpdk.org > Subject: [PATCH 1/2] net/ixgbe: fix x550 code to handle unident

Re: [dpdk-dev] [PATCH v10 0/9] implement packed virtqueues

2018-11-02 Thread Tiwei Bie
On Fri, Nov 02, 2018 at 10:07:40AM +0100, Jens Freimann wrote: > This is a basic implementation of packed virtqueues as specified in the > Virtio 1.1 draft. A compiled version of the current draft is available > at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at > https://github.com/oas

Re: [dpdk-dev] [PATCH v10 1/9] net/virtio: vring init for packed queues

2018-11-02 Thread Tiwei Bie
On Fri, Nov 02, 2018 at 10:07:41AM +0100, Jens Freimann wrote: > Add and initialize descriptor data structures. > > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtio_ethdev.c | 22 +++ > drivers/net/virtio/virtio_pci.h| 7 > drivers/net/virtio/virtio_ring.h | 60

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix busy polling while fiber link update

2018-11-02 Thread Zhang, Qi Z
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Thursday, November 1, 2018 11:05 AM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Laurent Hardy > ; Wei Dai ; Yigit, Ferruh > ; Ilya Maximets ; > sta...@dpdk.org > Subject: [P

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: disable compiler AVX512F support

2018-11-02 Thread Ferruh Yigit
On 11/2/2018 12:42 PM, Ferruh Yigit wrote: > On 10/23/2018 10:23 PM, Yongseok Koh wrote: >> This is a workaround to prevent a crash, which might be caused by >> optimization of newer gcc (7.3.0) on Intel Skylake. >> >> Bugzilla ID: 97 > > After checking the defect description again, this is the is

Re: [dpdk-dev] [PATCH v4 0/2] vhost: packed ring support completion

2018-11-02 Thread Tiwei Bie
On Wed, Oct 31, 2018 at 11:26:38AM +0100, Maxime Coquelin wrote: > In this v4, it restores back to only save last avail index and > its wrap counter value at get time, and restore both used > and avail indexes to avail values at set time. > The change compared to v1 is that wrap counter value is >

[dpdk-dev] [PATCH] doc: fix pdf build

2018-11-02 Thread Marko Kovacevic
PDF build was failing in the howto guides found the weird character causing the issue Fixes: 6e9270eab112 ("doc: add telemetry how-to") Cc: ciara.po...@intel.com Signed-off-by: Marko Kovacevic --- doc/guides/howto/telemetry.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [dpdk-dev] [dpdk-stable] [PATCH] build: disable compiler AVX512F support

2018-11-02 Thread Ferruh Yigit
On 10/23/2018 10:23 PM, Yongseok Koh wrote: > This is a workaround to prevent a crash, which might be caused by > optimization of newer gcc (7.3.0) on Intel Skylake. > > Bugzilla ID: 97 After checking the defect description again, this is the issue observed in rte_memcpy() implementation for AVX2

[dpdk-dev] [pull-request] next-pipeline 18.11 PRE-RC2

2018-11-02 Thread Cristian Dumitrescu
eal: fix memory leak on multi-process hotplug rollback (2018-11-02 00:05:49 +0100) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-pipeline for you to fetch changes up to bce13ccf20c9d510fbd9931087be70aef7e1b3c4: examples/ip_pipeline: fix port and table stats

Re: [dpdk-dev] [PATCH 01/12] examples/ip_pipeline: add rule list per table

2018-11-02 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cristian Dumitrescu > Sent: Friday, November 2, 2018 11:37 AM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Ni, Hongjun > > Subject: [dpdk-dev] [PATCH 01/12] examples/ip_pipeline: add rule list per > table > > Fo

[dpdk-dev] [pull-request] next-qos 18.11 PRE-RC2

2018-11-02 Thread Cristian Dumitrescu
eal/linux: handle UIO read failure in interrupt handler (2018-11-02 10:50:49 +0100) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-qos for you to fetch changes up to 8bca54df755ed9e58cb1e336b13c9aa62532d7fb: doc/qos_meter: add policer table details (2018-11-0

[dpdk-dev] [pull-request] next-pipeline 18.11 PRE-RC2

2018-11-02 Thread Cristian Dumitrescu
eal/linux: handle UIO read failure in interrupt handler (2018-11-02 10:50:49 +0100) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-qos for you to fetch changes up to 8bca54df755ed9e58cb1e336b13c9aa62532d7fb: doc/qos_meter: add policer table details (2018-11-0

  1   2   >