Re: [dpdk-dev] [RFC v2 5/9] ipsec: add SA data-path API

-Original Message- > Date: Tue, 30 Oct 2018 13:53:30 + > From: "Ananyev, Konstantin" > To: Jerin Jacob > CC: "dev@dpdk.org" , "Awal, Mohammad Abdul" > , "Joseph, Anoob" > , "Athreya, Narayana Prasad" > > Subject: RE: [dpdk-dev] [RFC v2 5/9] ipsec: add SA data-path API > > > Hi J

Re: [dpdk-dev] [PATCH] compress/qat: fix out-of-bounds error

-Original Message- > Date: Wed, 31 Oct 2018 00:39:54 + > From: Fiona Trahe > To: dev@dpdk.org > CC: tho...@monjalon.net, akhil.go...@nxp.com, tomaszx.jozw...@intel.com, > jerin.ja...@caviumnetworks.com, Fiona Trahe > Subject: [PATCH] compress/qat: fix out-of-bounds error > X-Mailer:

Re: [dpdk-dev] [PATCH v1 3/3] test/hash: add readwrite test for ext table

> On Fri, Oct 26, 2018 at 12:23:56AM +, Honnappa Nagarahalli wrote: > > > > > > On Wed, Oct 10, 2018 at 02:48:05PM -0700, Yipeng Wang wrote: > > > > This commit improves the readwrite test to consider extendable > > > > table feature and add more functional tests to cover more corner cases. > >

Re: [dpdk-dev] [PATCH] net/avf/base: fix shifting 32 bits signed variable 31 times

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Sunday, October 28, 2018 11:52 AM > To: Wu, Jingjing ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/avf/base: fix shifting 32 bits sign

[dpdk-dev] [PATCH v2 2/2] ring: move the atomic load of head above the loop

In __rte_ring_move_prod_head, move the __atomic_load_n up and out of the do {} while loop as upon failure the old_head will be updated, another load is costly and not necessary. This helps a little on the latency,about 1~5%. Test result with the patch(two cores): SP/SC bulk enq/dequeue (size: 8

[dpdk-dev] [PATCH v2 1/2] ring: synchronize the load and store of the tail

Synchronize the load-acquire of the tail and the store-release within update_tail, the store release ensures all the ring operations, enqueue or dequeue, are seen by the observers on the other side as soon as they see the updated tail. The load-acquire is needed here as the data dependency is not a

[dpdk-dev] [PATCH v2 0/2] rte ring c11 bug fix and optimization

v1->v2 1) Add the changes to the 18.11 release notes V1: Updated the rte ring C11 driver including the following changes 1) Synchronize the load and store of the tail to ensure the enqueue/dequeue operations are really completed before seen by the observers on the other sides. 2) Move the a

[dpdk-dev] [Bug 101] 18.11-RC1/ Testpmd start fail

https://bugs.dpdk.org/show_bug.cgi?id=101 Bug ID: 101 Summary: 18.11-RC1/ Testpmd start fail Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status: CONFIRMED Severity: major Priority: Norma

[dpdk-dev] [Bug 100] testpmd deadlock

https://bugs.dpdk.org/show_bug.cgi?id=100 Bug ID: 100 Summary: testpmd deadlock Product: DPDK Version: 18.11 Hardware: x86 OS: Linux Status: CONFIRMED Severity: critical Priority: Normal

[dpdk-dev] [PATCH v5 2/3] net: add IPv6 extension header definitions

Add a common IPv6 extension header and an inline function for determining whether a next header field represents an IPv6 extension header. Signed-off-by: Cody Doucette --- lib/librte_net/rte_ip.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/lib/librte_net/rte_

[dpdk-dev] [PATCH v5 1/3] net/failsafe: remove D_XOPEN_SOURCE flag

Compilation flag D_XOPEN_SOURCE is causing failsafe to fail to build when changing some DPDK libraries. The flag is not needed and therefore is removed. Signed-off-by: Cody Doucette --- drivers/net/failsafe/Makefile| 1 - drivers/net/failsafe/meson.build | 1 - 2 files changed, 2 deletions(-

[dpdk-dev] [PATCH v5 0/3] Extend rte_ipv6_frag_get_ipv6_fragment_header()

Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any other IPv6 extension headers when finding the fragment header. --- v5: * Removed duplicate patch from submission. v4: * Separated into multiple patches and added cover letter. v3: * Removed compilation flag D_XOPEN_SOURCE=700 from t

[dpdk-dev] [PATCH v5 3/3] ip_frag: extend IPv6 fragment header retrieval

Add the ability to parse IPv6 extenders to find the IPv6 fragment header, and update callers. According to RFC 8200, there is no guarantee that the IPv6 Fragment extension header will come before any other extension header, even though it is recommended. Signed-off-by: Cody Doucette Signed-off-b

Re: [dpdk-dev] to wait or not to wait.. DPDK & OVS ixgbe with fibre disconnected

Hi, Stephen Hemminger > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Friday, August 31, 2018 11:12 PM > To: David Evans > Cc: Yang, Qiming ; dev@dpdk.org > Subject: Re: [dpdk-dev] to wait or not to wait.. DPDK & OVS ixgbe with fi

[dpdk-dev] [PATCH] compress/qat: display error in case IM buffer too small

Display trace if error returned from firmware is likely due to intermediate buffers being too small for the compressed output. Update documentation to explain this error case and to clarify intermediate buffer memory usage. Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 22

[dpdk-dev] [PATCH] test/compress: improve trace

Make clear which engine is compressing and which is decompressing in debug output. Also add newline and print ratio = 0 if test fails. Signed-off-by: Fiona Trahe --- test/test/test_compressdev.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/test/

[dpdk-dev] [PATCH] compress/qat: fix out-of-bounds error

QAT array for sgls in intermediate buffer structure was #defined to 1, but setup code hardcoded as if 2 buffers so causing out of bounds write. Reworked to loop correctly using #define. Fixes: a124830a6f00 ("compress/qat: enable dynamic huffman encoding") Reported-by: Jerin Jacob Signed-off-by:

[dpdk-dev] [PATCH] net/qede/base: fix to initialize HW for LLH filters

During initalization of leading PF, we need to initialize HW for LLH filters. Set HW init parameter to set the eingine affinity for multiple engine adapters. Fixes: 3eed444a9621 ("net/qede/base: changes for 100G") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c |8

[dpdk-dev] [PATCH v5 2/3] net: add IPv6 extension header definitions

Add a common IPv6 extension header and an inline function for determining whether a next header field represents an IPv6 extension header. Signed-off-by: Cody Doucette --- lib/librte_net/rte_ip.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/lib/librte_net/rte_

[dpdk-dev] [PATCH v5 1/3] net/failsafe: remove D_XOPEN_SOURCE flag

Compilation flag D_XOPEN_SOURCE is causing failsafe to fail to build when changing some DPDK libraries. The flag is not needed and therefore is removed. Signed-off-by: Cody Doucette --- drivers/net/failsafe/Makefile| 1 - drivers/net/failsafe/meson.build | 1 - 2 files changed, 2 deletions(-

[dpdk-dev] [PATCH v4 0/3] Extend rte_ipv6_frag_get_ipv6_fragment_header()

Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any other IPv6 extension headers when finding the fragment header. --- v5: * Removed duplicate patch from submission. v4: * Separated into multiple patches and added cover letter. v3: * Removed compilation flag D_XOPEN_SOURCE=700 from t

[dpdk-dev] [PATCH v5 3/3] ip_frag: extend IPv6 fragment header retrieval

Add the ability to parse IPv6 extenders to find the IPv6 fragment header, and update callers. According to RFC 8200, there is no guarantee that the IPv6 Fragment extension header will come before any other extension header, even though it is recommended. Signed-off-by: Cody Doucette Signed-off-b

Re: [dpdk-dev] [PATCH v4 3/3] ip_frag: extend IPv6 extension header parsing

Please ignore v4 since I renamed something and caused a duplicate patch to be sent. I will send a clean v5. Cody On Tue, Oct 30, 2018 at 8:12 PM Cody Doucette wrote: > Add the ability to parse IPv6 extenders to find the > IPv6 fragment header, and update callers. > > According to RFC 8200, ther

[dpdk-dev] [PATCH v4 0/3] Extend rte_ipv6_frag_get_ipv6_fragment_header()

Extend rte_ipv6_frag_get_ipv6_fragment_header() to skip over any other IPv6 extension headers when finding the fragment header. --- v4: * Separated into multiple patches and added cover letter. v3: * Removed compilation flag D_XOPEN_SOURCE=700 from the failsafe driver to allow compilation on fre

[dpdk-dev] [PATCH v4 3/3] ip_frag: extend IPv6 extension header parsing

Add the ability to parse IPv6 extenders to find the IPv6 fragment header, and update callers. According to RFC 8200, there is no guarantee that the IPv6 Fragment extension header will come before any other extension header, even though it is recommended. Signed-off-by: Cody Doucette Signed-off-b

[dpdk-dev] [PATCH v4 2/3] net: add IPv6 extension header definitions

Add a common IPv6 extension header and an inline function for determining whether a next header field represents an IPv6 extension header. Signed-off-by: Cody Doucette --- lib/librte_net/rte_ip.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/lib/librte_net/rte_

[dpdk-dev] [PATCH v4 1/3] net/failsafe: remove D_XOPEN_SOURCE flag

Compilation flag D_XOPEN_SOURCE is causing failsafe to fail to build when changing some DPDK libraries. The flag is not needed and therefore is removed. Signed-off-by: Cody Doucette --- drivers/net/failsafe/Makefile| 1 - drivers/net/failsafe/meson.build | 1 - 2 files changed, 2 deletions(-

[dpdk-dev] [PATCH v4 3/3] ip_frag: extend IPv6 fragment header retrieval

Add the ability to parse IPv6 extenders to find the IPv6 fragment header, and update callers. According to RFC 8200, there is no guarantee that the IPv6 Fragment extension header will come before any other extension header, even though it is recommended. Signed-off-by: Cody Doucette Signed-off-b

Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

30/10/2018 19:09, Cody Doucette: > OK, I will send three separate patches plus a cover letter. > > I seem to be having trouble with checkpatch complaining that new symbols > are not inserted into the EXPERIMENTAL section of the .map file: > > ERROR: symbol break is added in a section other than t

Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix zero copy

On 2018-10-30 15:48, Fan Zhang wrote: This patch fixes the zero copy enable problem for vhost crypto sample application. For some Crypto PMDs such as AESNI-MB and AESNI-GCM the data to be processed will be made a copy in the same buffer but next to the data. For example, to encrypt 64 bytes data

Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

OK, I will send three separate patches plus a cover letter. I seem to be having trouble with checkpatch complaining that new symbols are not inserted into the EXPERIMENTAL section of the .map file: ERROR: symbol break is added in a section other than the EXPERIMENTAL section of the version map ER

[dpdk-dev] [PATCH v3] bus/pci: fix unexpected resource mapping override

When scanning an already plugged device, the virtual address of mapped PCI resource in rte_pci_device will be overridden with 0, that may cause driver does not work correctly. The fix is not to update any rte_pci_device's field if the being scanned device's driver is already probed. Bugzilla ID: 8

Re: [dpdk-dev] [PATCH v2] bus/pci: fix unexpected resource mapping override

> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, October 28, 2018 6:27 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Yigit, > Ferruh ; geoffrey...@gmail.com; > ajit.khapa...@broadcom.com; sta...@dpdk.org; gaetan.ri...@6wind.com; > ar

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

Hi Lucero, From: Alejandro Lucero [mailto:alejandro.luc...@netronome.com] Sent: Tuesday, October 30, 2018 10:57 PM To: Lin, Xueqin Cc: Yao, Lei A ; Thomas Monjalon ; dev ; Xu, Qian Q ; Burakov, Anatoly ; Yigit, Ferruh ; Zhang, Qi Z Subject: Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

On Tue, Oct 30, 2018 at 2:45 PM Lin, Xueqin wrote: > Hi Lucero, > > > > The patch could fix both testpmd and multi-process can’t setup issues on > my environment. > > Hope that you could upload fix patch to patches page in community. > > Thanks a lot. > > > Great. I need to format the patchset

[dpdk-dev] [PATCH] examples/vhost_crypto: fix zero copy

This patch fixes the zero copy enable problem for vhost crypto sample application. For some Crypto PMDs such as AESNI-MB and AESNI-GCM the data to be processed will be made a copy in the same buffer but next to the data. For example, to encrypt 64 bytes data the PMD will copy this data from offset

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

Hi Lucero, The patch could fix both testpmd and multi-process can’t setup issues on my environment. Hope that you could upload fix patch to patches page in community. Thanks a lot. Best regards, Xueqin From: Alejandro Lucero [mailto:alejandro.luc...@netronome.com] Sent: Tuesday, October 30, 20

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

On Tue, Oct 30, 2018 at 2:14 PM Burakov, Anatoly wrote: > On 30-Oct-18 2:04 PM, Alejandro Lucero wrote: > > > > > > On Tue, Oct 30, 2018 at 12:37 PM Alejandro Lucero > > mailto:alejandro.luc...@netronome.com>> > > > wrote: > > > > > > > > On Tue, Oct 30, 2018 at 12:22 PM Lin, Xueqin >

Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

30/10/2018 10:46, Ananyev, Konstantin: > Hi Thomas, > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 28/10/2018 21:54, Cody Doucette: > > > On Sun, Oct 28, 2018 at 6:22 AM Thomas Monjalon > > > wrote: > > > > 27/07/2018 15:52, Cody Doucette: > > > > > Extend rte_ipv6_frag_get_ipv6_frag

[dpdk-dev] [PATCH 3/4] net/softnic: fix string copy

From: Reshma Pattan Use strlcpy instead of strcpy to avoid buffer overrun. Coverity issue: 323475 Fixes: c169b6a588 ("net/softnic: map flow attribute to pipeline table") CC: cristian.dumitre...@intel.com CC: jasvinder.si...@intel.com Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_e

[dpdk-dev] [PATCH 4/4] net/softnic: fix string copy

From: Reshma Pattan Use strlcpy instead of strcpy to avoid buffer overrun. Coverity issue: 323478 Fixes: b767f8efc8 ("net/softnic: replace pointers with arrays") CC: cristian.dumitre...@intel.com CC: jasvinder.si...@intel.com Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softn

[dpdk-dev] [PATCH 2/4] net/softnic: fix string copy

From: Reshma Pattan Replace strcpy with strlcpy to avoid buffer overrun. Coverity issue: 323515 Fixes: b767f8efc8 ("net/softnic: replace pointers with arrays") CC: cristian.dumitre...@intel.com CC: jasvinder.si...@intel.com Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softnic

[dpdk-dev] [PATCH 1/4] net/softnic: fix string copy

From: Reshma Pattan Use strlcpy instead of strcpy to avoid buffer overrun. Coverity issue: 323514 Fixes: b767f8efc8 ("net/softnic: replace pointers with arrays") CC: cristian.dumitre...@intel.com CC: jasvinder.si...@intel.com Signed-off-by: Reshma Pattan --- drivers/net/softnic/rte_eth_softn

[dpdk-dev] [PATCH v3] doc: add meson build to contributing guide

Patches has to be validated for meson builds. Updating documentation for meson build steps in Checking Compilation category. Signed-off-by: Vipin Varghese --- V3: removed extra character - Vipin Varghese V2: updated the meson build options - Bruce Richardson --- doc/guides/contributing/patches

[dpdk-dev] [PATCH v2] doc: add meson build to contributing guide

Patches has to be validated for meson builds. Updating documentation for meson build steps in Checking Compilation category. Signed-off-by: Vipin Varghese --- V2: updated the meson build options - Bruce Richardson --- doc/guides/contributing/patches.rst | 6 ++ 1 file changed, 6 insertions(

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

On 30-Oct-18 2:04 PM, Alejandro Lucero wrote: On Tue, Oct 30, 2018 at 12:37 PM Alejandro Lucero mailto:alejandro.luc...@netronome.com>> wrote: On Tue, Oct 30, 2018 at 12:22 PM Lin, Xueqin mailto:xueqin@intel.com>> wrote: Some found on some our servers: If  no

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

On Tue, Oct 30, 2018 at 12:37 PM Alejandro Lucero < alejandro.luc...@netronome.com> wrote: > > > On Tue, Oct 30, 2018 at 12:22 PM Lin, Xueqin wrote: > >> Some found on some our servers: >> >> If not add ”intel_iommu=on iommu=pt” in /boot/grub2/grub.cfg file, then >> reboot to make it effective.

Re: [dpdk-dev] [PATCH v3 0/3] force IOVA to a particular mode

On Tue, Oct 30, 2018 at 1:48 PM Burakov, Anatoly wrote: > On 30-Oct-18 12:02 PM, Alejandro Lucero wrote: > > > > > > On Sun, Oct 28, 2018 at 11:04 PM Thomas Monjalon > > wrote: > > > > 11/10/2018 12:08, Thomas Monjalon: > > > +Cc more maintainers in order to

Re: [dpdk-dev] [PATCH v2] lib/compressdev: Fix logic error on op allocation

>-Original Message- >From: Fiona Trahe >Sent: 27 October 2018 06:13 >To: dev@dpdk.org >Cc: tho...@monjalon.net; akhil.go...@nxp.com; tomaszx.jozw...@intel.com; >saby...@hpe.com; Verma, Shally >; Fiona Trahe ; sta...@dpdk.org >Subject: [PATCH v2] lib/compressdev: Fix logic error on op a

Re: [dpdk-dev] [PATCH] lib/compressdev: clarify usage of op structure

>-Original Message- >From: Fiona Trahe >Sent: 27 October 2018 05:44 >To: dev@dpdk.org >Cc: tho...@monjalon.net; akhil.go...@nxp.com; tomaszx.jozw...@intel.com; >lee.d...@intel.com; saby...@hpe.com; Verma, Shally >; Fiona Trahe ; sta...@dpdk.org >Subject: [PATCH] lib/compressdev: clarif

Re: [dpdk-dev] [RFC v2 5/9] ipsec: add SA data-path API

Hi Jerin, > > > > > > + > > > > > > +/** > > > > > > + * Checks that inside given rte_ipsec_session crypto/security > > > > > > fields > > > > > > + * are filled correctly and setups function pointers based on > > > > > > these values. > > > > > > + * @param ss > > > > > > + * Pointer to t

Re: [dpdk-dev] [PATCH v3 0/3] force IOVA to a particular mode

On 30-Oct-18 12:02 PM, Alejandro Lucero wrote: On Sun, Oct 28, 2018 at 11:04 PM Thomas Monjalon > wrote: 11/10/2018 12:08, Thomas Monjalon: > +Cc more maintainers in order to collect more reviews > > 04/10/2018 11:19, Burakov, Anatoly: > > O

[dpdk-dev] Error in adding vdev for packet capture from secondary process

Hello Team, I have an application (DPDK secondary process) which is required to capture packet into PCAP file. As I have gone through *dpdk-pdump* application, I came to know that pcap driver receives packets from virtual Ethernet device and place them into a .pcap file. For the same purpose I d

Re: [dpdk-dev] [PATCH v2] eal/bus: use RTE_IOVA_PA only if phys addresses are available

On Mon, Sep 17, 2018 at 2:06 PM Stojaczyk, Dariusz < dariusz.stojac...@intel.com> wrote: > > > > -Original Message- > > From: Burakov, Anatoly > > Sent: Monday, September 17, 2018 12:34 PM > > To: Stojaczyk, Dariusz ; dev@dpdk.org; > > Santosh Shukla ; Hemant Agrawal > > ; Jerin Jacob > >

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

On Tue, Oct 30, 2018 at 12:22 PM Lin, Xueqin wrote: > Some found on some our servers: > > If not add ”intel_iommu=on iommu=pt” in /boot/grub2/grub.cfg file, then > reboot to make it effective. > > 18.11 rc1: Success to setup testpmd and secondary process. > > > > If add ”intel_iommu=on iommu=

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

Some found on some our servers: If not add ”intel_iommu=on iommu=pt” in /boot/grub2/grub.cfg file, then reboot to make it effective. 18.11 rc1: Success to setup testpmd and secondary process. If add ”intel_iommu=on iommu=pt” in /boot/grub2/grub.cfg file, then reboot to make it effective. 18.

Re: [dpdk-dev] [PATCH v3 0/3] force IOVA to a particular mode

On Sun, Oct 28, 2018 at 11:04 PM Thomas Monjalon wrote: > 11/10/2018 12:08, Thomas Monjalon: > > +Cc more maintainers in order to collect more reviews > > > > 04/10/2018 11:19, Burakov, Anatoly: > > > On 03-Oct-18 9:53 PM, eric zhang wrote: > > > > This patchset introduces an EAL command line opt

Re: [dpdk-dev] [PATCH] app/testpmd: fix possible uninitialized variable usage

> -Original Message- > From: Yigit, Ferruh > Sent: Sunday, October 28, 2018 2:17 AM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org > Subject: [PATCH] app/testpmd: fix possible uninitialized variable usage > > ol_flags can be wro

Re: [dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost

On 10/25/18 11:46 AM, Tiwei Bie wrote: Tiwei Bie (2): net/virtio: drop duplicated reset method net/vhost: fix parameters string drivers/net/vhost/rte_eth_vhost.c | 6 +- drivers/net/virtio/virtio_pci.c | 15 --- drivers/net/virtio/virtio_pci.h

Re: [dpdk-dev] [PATCH 0/6] Fixes for virtio/virtio-user

On 10/29/18 6:28 AM, Tiwei Bie wrote: Tiwei Bie (6): net/virtio-user: do not stop stopped device again net/virtio-user: do not make vhost user channel nonblock net/virtio-user: do not reset owner when driver resets net/virtio-user: fix device features for server mode net/virtio-

Re: [dpdk-dev] [PATCH v1] doc: add meson build to contributing guide

On Tue, Oct 30, 2018 at 10:26:33AM +0530, Vipin Varghese wrote: > Patches has to be validated for meson builds. Updating documentation > for meson build steps in Checking Compilation category. > > Signed-off-by: Vipin Varghese > --- > doc/guides/contributing/patches.rst | 9 + > 1 file c

Re: [dpdk-dev] [PATCH v2] build: add meson.build for kni kernel module

On Mon, Oct 29, 2018 at 03:33:47PM +, Luca Boccassi wrote: > On Mon, 2018-10-29 at 17:09 +0300, Ilya Maximets wrote: > > > On Fri, 2018-10-12 at 17:29 +0100, Bruce Richardson wrote: > > > > On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote: > > > > > A Kbuild is also included to all

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

On Tue, Oct 30, 2018 at 10:34 AM Lin, Xueqin wrote: > Hi Lucero, > > > > No, we have reproduced multi-process issues(include symmetric_mp, > simple_mp, hotplug_mp, multi-process unit test… )on most of our servers. > > It is also strange that 1~2 servers don’t have the issue. > > > Yes, you are r

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

Hi Lucero, No, we have reproduced multi-process issues(include symmetric_mp, simple_mp, hotplug_mp, multi-process unit test… )on most of our servers. It is also strange that 1~2 servers don’t have the issue. Bind two NNT ports or FVL ports ./build/symmetric_mp -c 4 --proc-type=auto -- -p 3 --nu

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/mp: remove rte_panic and profanity

On 26-Oct-18 9:41 PM, Thomas Monjalon wrote: 26/10/2018 16:55, Anatoly Burakov: --- a/lib/librte_eal/common/eal_common_proc.c +++ b/lib/librte_eal/common/eal_common_proc.c + /* +* set the alarm before sending message. there are two possible error +* scenarios to consider he

Re: [dpdk-dev] [PATCH 6/6] net/virtio: fix guest announce support

On 10/29/18 6:28 AM, Tiwei Bie wrote: We need to check the status field in virtio net config structure instead of the bits read from ISR register to know whether we need to do guest announce. Fixes: 7365504f77e3 ("net/virtio: support guest announce") Cc: sta...@dpdk.org Signed-off-by: Tiwei

Re: [dpdk-dev] [PATCH 5/6] net/virtio-user: simplify device features preparation

On 10/29/18 6:28 AM, Tiwei Bie wrote: Get rid of the duplicated code in device features preparation which looks awful. Signed-off-by: Tiwei Bie --- .../net/virtio/virtio_user/virtio_user_dev.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) Welcomed cleanup!

Re: [dpdk-dev] [PATCH v2] eal/bus: use RTE_IOVA_PA only if phys addresses are available

On 28-Oct-18 11:11 PM, Thomas Monjalon wrote: 17/09/2018 12:33, Burakov, Anatoly: On 07-Sep-18 4:58 PM, Darek Stojaczyk wrote: When neither RTE_IOVA_VA nor RTE_IOVA_PA was explicitly requested, DPDK would currently fallback to the default RTE_IOVA_PA mode and possibly encounter a failure later

Re: [dpdk-dev] [PATCH 4/6] net/virtio-user: fix device features for server mode

On 10/29/18 6:28 AM, Tiwei Bie wrote: We need to save the supported frontend features (which won't be announced by vhost backend), otherwise we will lost them when the connection to vhost-user backend is established in server mode. Fixes: 201a41651715 ("net/virtio-user: fix multiple queues fa

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

On Tue, Oct 30, 2018 at 10:19 AM Burakov, Anatoly wrote: > On 29-Oct-18 11:39 AM, Alejandro Lucero wrote: > > I got a patch that solves a bug when calling rte_eal_dma_mask using the > > mask instead of the maskbits. However, this does not solves the deadlock. > > > > Interestingly, the problem lo

Re: [dpdk-dev] [PATCH 3/6] net/virtio-user: do not reset owner when driver resets

On 10/29/18 6:28 AM, Tiwei Bie wrote: When driver resets the device, virtio-user just needs to send GET_VRING_BASE messages to stop the vhost backend, and that's what QEMU does. With this change, we won't need to set owner when starting virtio-user device anymore. This will help us to get rid

Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update

Any more thoughts on that fix? Or is there any chance for it to be accepted? Best regards, Ilya Maximets. On 31.08.2018 15:39, Ilya Maximets wrote: > If the multispeed fiber link is in DOWN state, ixgbe_setup_link > could take around a second of busy polling. This is highly > inconvenient for the

Re: [dpdk-dev] [PATCH 2/6] net/virtio-user: do not make vhost user channel nonblock

On 10/29/18 6:28 AM, Tiwei Bie wrote: There is no need to make the vhost user channel nonblock, and making it nonblock will make vhost_user_read() fail with EAGAIN when vhost messages need a reply. Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") Cc: sta...@dpdk.org Signed-off-by

Re: [dpdk-dev] [PATCH 1/6] net/virtio-user: do not stop stopped device again

On 10/29/18 6:28 AM, Tiwei Bie wrote: Without this change, virtio-user still works, but it will show annoying error messages like this on shutdown: vhost_kernel_set_backend(): VHOST_NET_SET_BACKEND fails, Operation not permitted vhost_kernel_ioctl(): VHOST_RESET_OWNER failed: Operation not pe

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

On 29-Oct-18 11:39 AM, Alejandro Lucero wrote: I got a patch that solves a bug when calling rte_eal_dma_mask using the mask instead of the maskbits. However, this does not solves the deadlock. Interestingly, the problem looks like a compiler one. Calling rte_memseg_walk does not return when ca

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

On Tue, Oct 30, 2018 at 10:11 AM Burakov, Anatoly wrote: > On 29-Oct-18 2:18 PM, Thomas Monjalon wrote: > > 29/10/2018 14:40, Alejandro Lucero: > >> On Mon, Oct 29, 2018 at 1:18 PM Yao, Lei A wrote: > >>> *From:* Alejandro Lucero [mailto:alejandro.luc...@netronome.com] > >>> On Mon, Oct 29, 2018

Re: [dpdk-dev] [PATCH v2] eal: fix IPC memleak on device hotplug

On 29-Oct-18 11:47 AM, Darek Stojaczyk wrote: rte_mp_request_sync() says that the caller is responsible for freeing one of its parameters afterwards. EAL didn't do that, causing a memory leak. Fixes: 244d5130719c ("eal: enable hotplug on multi-process") Cc: qi.z.zh...@intel.com Cc: anatoly.bura.

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

On 29-Oct-18 2:18 PM, Thomas Monjalon wrote: 29/10/2018 14:40, Alejandro Lucero: On Mon, Oct 29, 2018 at 1:18 PM Yao, Lei A wrote: *From:* Alejandro Lucero [mailto:alejandro.luc...@netronome.com] On Mon, Oct 29, 2018 at 11:46 AM Thomas Monjalon wrote: 29/10/2018 12:39, Alejandro Lucero: I g

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

On 29-Oct-18 7:37 PM, Alejandro Lucero wrote: On Mon, Oct 29, 2018 at 6:54 PM Yongseok Koh > wrote: > On Oct 29, 2018, at 7:18 AM, Thomas Monjalon mailto:tho...@monjalon.net>> wrote: > > 29/10/2018 14:40, Alejandro Lucero: >> On Mon, Oct 29, 201

Re: [dpdk-dev] [PATCH v3] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Sunday, October 28, 2018 9:19 PM > To: Cody Doucette > Cc: dev@dpdk.org; Gaetan Rivet ; Ananyev, Konstantin > ; Olivier Matz > ; Dumitrescu, Cristian > ; Michel Machado ; Fu, > Qiaobin > > Sub

Re: [dpdk-dev] PDF guides broken

30/10/2018 10:07, Kovacevic, Marko: > I'll try and find it and send up a fix. It's already fixed by Dan Gora :) It is again a .svg reference in .rst. We could add an automatic check for this. > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Monday,

Re: [dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

On Tue, Oct 30, 2018 at 3:20 AM Lin, Xueqin wrote: > Hi Lucero&Thomas, > > > > Find the patch can’t fix multi-process cases. > Hi, I think it is not specifically about multiprocess but about hotplug with multiprocess because I can execute the symmetric_mp successfully with a secondary process.

Re: [dpdk-dev] [PATCH 2/2] net/vhost: fix parameters string

On 10/25/18 11:46 AM, Tiwei Bie wrote: Add the missing params to the param string. Fixes: 39cac2adcad0 ("net/vhost: add client option") Fixes: 4ce97c6f6b4f ("net/vhost: add an option to enable dequeue zero copy") Fixes: 447e0d379756 ("net/vhost: add parameter to enable IOMMU feature") Fixes:

Re: [dpdk-dev] [PATCH 1/2] net/virtio: drop duplicated reset method

On 10/25/18 11:46 AM, Tiwei Bie wrote: Drop the duplicated reset() method in virtio_pci_ops. Currently vtpci_reset() is implemented on set_status() and get_status() directly. The reset() method in virtio_pci_ops isn't used and its implementation in the legacy device isn't right. Signed-off-by

Re: [dpdk-dev] PDF guides broken

I'll try and find it and send up a fix. > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, October 29, 2018 3:38 AM > To: Mcnamara, John ; Kovacevic, Marko > > Cc: dev@dpdk.org > Subject: PDF guides broken > > Hi, > > The command make-guides-pdf fa

Re: [dpdk-dev] [PATCH] vhost/crypto: fix incorrect copy

Hi Fan, The patch is quite complex. Is there any chance it could be split in multiple parts to ease reviewing? I have found one possible bug, see below: On 10/24/18 3:18 PM, Fan Zhang wrote: This patch fixes the incorrect packet content copy in the chaining operation in the copy mode. Original

[dpdk-dev] [PATCH] net/mlx5: fix validation of MLPS-in-GRE

Multiple tunnel isn't allowed but MPLS over GRE should be accepted. Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --

[dpdk-dev] [PATCH] net/mlx5: add missing FDIR flow delete

Deleting FDIR flow is not implemented by mistake. Also the name of static functions are properly renamed. Fixes: b42c000e37a8 ("net/mlx5: remove flow support") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 158 +-- dri

[dpdk-dev] [PATCH v2 1/2] net/mlx5: move device spawn configuration to probing

Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 54 - 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index ec6a482a9a..6fa50ba1b1 100644 --- a/drivers/net/mlx5/mlx5.c +++ b

[dpdk-dev] [PATCH v2 2/2] net/mlx5: make vectorized Tx threshold configurable

Add txqs_max_vec parameter to configure the maximum number of Tx queues to enable vectorized Tx. And its default value is set according to the architecture and device type. Signed-off-by: Yongseok Koh --- doc/guides/nics/mlx5.rst | 16 +++- drivers/net/mlx5/mlx5.c |

[dpdk-dev] [PATCH v2 0/2] net/mlx5: make vectorized Tx threshold configurable

v2: * add "net/mlx5: move device spawn configuration to probing" * rename txqs_min_vec to txqs_max_vec Yongseok Koh (2): net/mlx5: move device spawn configuration to probing net/mlx5: make vectorized Tx threshold configurable doc/guides/nics/mlx5.rst | 16 - drivers/net/mlx5/