Re: [dpdk-dev] [PATCH v6 3/3] net/tap: allow secondary process to access primary device queues

2018-10-16 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, October 16, 2018 2:28 PM > To: Raslan Darawsheh ; keith.wi...@intel.com > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf > Shuler ; Ori Kam > Subject: Re: [PATCH v6 3/3] net/tap: allow secondary process to access > primary device

Re: [dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail

2018-10-16 Thread Gavin Hu (Arm Technology China)
Hi Jerin As the 1st one of the 3-patch set was not concluded, I submit this 2-patch series to unblock the merge. Best Regards, Gavin > -Original Message- > From: Gavin Hu > Sent: Wednesday, October 17, 2018 2:30 PM > To: dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; Honnappa > N

[dpdk-dev] [PATCH 1/2] ring: synchronize the load and store of the tail

2018-10-16 Thread Gavin Hu
Synchronize the load-acquire of the tail and the store-release within update_tail, the store release ensures all the ring operations, enqueue or dequeue, are seen by the observers on the other side as soon as they see the updated tail. The load-acquire is needed here as the data dependency is not a

[dpdk-dev] [PATCH 2/2] ring: move the atomic load of head above the loop

2018-10-16 Thread Gavin Hu
In __rte_ring_move_prod_head, move the __atomic_load_n up and out of the do {} while loop as upon failure the old_head will be updated, another load is costly and not necessary. This helps a little on the latency,about 1~5%. Test result with the patch(two cores): SP/SC bulk enq/dequeue (size: 8

Re: [dpdk-dev] [PATCH v3 1/4] app/testpmd: allow detaching a port not closed

2018-10-16 Thread Andrew Rybchenko
On 10/17/18 4:54 AM, Thomas Monjalon wrote: The testpmd application aim is for testing; so order of operations should not be enforced. There was a test to forbid detaching before closing a port. However, it may interesting to test what happens in such case. It is possible for a PMD to automatica

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support metadata as flow rule criteria

2018-10-16 Thread Andrew Rybchenko
On 10/17/18 8:27 AM, Dekel Peled wrote: Thanks, PSB. *From:* Andrew Rybchenko *Sent:* Tuesday, October 16, 2018 5:12 PM *To:* Dekel Peled ; wenzhuo...@intel.com; jingjing...@intel.com; bernard.iremon...@intel.com; olivier.m...@6wind.com; Adrien Mazarguil ; Thomas Monjalon ; ferruh.yi...@int

[dpdk-dev] [PATCH] net/dpaa2: fix mac address initialization

2018-10-16 Thread Shreyansh Jain
Fixes: c3e0a706fd75 ("net/dpaa2: read hardware provided MAC for DPNI devices") Signed-off-by: Shreyansh Jain --- - In response to the sys_...@intel.com reported issue "Fwd: | ERROR | daily Intel builds (38/49)" drivers/net/dpaa2/dpaa2_ethdev.c | 5 - 1 file changed, 4 insertions(+), 1 de

Re: [dpdk-dev] dpaax warnings

2018-10-16 Thread Shreyansh Jain
On Wednesday 17 October 2018 03:57 AM, Thomas Monjalon wrote: > Hi Shreyansh, > > When initializing DPDK on x86, we get those warnings: > dpaax: Unable to glob device-tree memory node: > (/proc/device-tree/memory[@0-9]*/reg)(3) > dpaax: PA->VA translation not available; > dpaax:

Re: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front to jump over ntuple filter case

2018-10-16 Thread Zhao1, Wei
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, October 15, 2018 11:31 AM > To: Zhao1, Wei ; mocan > Cc: dev@dpdk.org; Lu, Wenzhuo > Subject: RE: Re:RE: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front > to jump over ntuple filter case > > Hi Wei: > > > -Original

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-16 Thread Joseph, Anoob
Hi Fiona, Reminder!! Thanks, Anoob > -Original Message- > From: Joseph, Anoob > Sent: 10 October 2018 11:10 > To: Thomas Monjalon ; Trahe, Fiona > > Cc: dev@dpdk.org; Akhil Goyal ; Joseph, Anoob > ; De Lara Guarch, Pablo > ; Murthy, Nidadavolu > ; Jacob, Jerin > ; Athreya, Narayana Pras

[dpdk-dev] [PATCH] vfio: fix missing header inclusion

2018-10-16 Thread Jerin Jacob
The following change set introduces HAVE_VFIO_DEV_REQ_INTERFACE and used in the below files. drivers/bus/pci/linux/pci_vfio.c drivers/bus/pci/pci_common.c lib/librte_eal/linuxapp/eal/eal_interrupts.c However, Except the first file, the change missed to include where HAVE_VFIO_DEV_REQ_INTERFACE d

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support metadata as flow rule criteria

2018-10-16 Thread Dekel Peled
Thanks, PSB. From: Andrew Rybchenko Sent: Tuesday, October 16, 2018 5:12 PM To: Dekel Peled ; wenzhuo...@intel.com; jingjing...@intel.com; bernard.iremon...@intel.com; olivier.m...@6wind.com; Adrien Mazarguil ; Thomas Monjalon ; ferruh.yi...@intel.com Cc: Shahaf Shuler ; dev@dpdk.org; Ori Kam

Re: [dpdk-dev] [PATCH] devtools: add exception for OCTEON TX

2018-10-16 Thread Joseph, Anoob
Hi Thomas, Can you review this patch and let me know your comments? Thanks, Anoob > -Original Message- > From: Joseph, Anoob > Sent: 10 October 2018 18:31 > To: Thomas Monjalon > Cc: Joseph, Anoob ; Jacob, Jerin > ; Athreya, Narayana Prasad > ; dev@dpdk.org > Subject: [PATCH] devtools:

Re: [dpdk-dev] [PATCH 5/5] net/mlx5: fix flow mark ID conversion in Direct Verbs

2018-10-16 Thread Ori Kam
> -Original Message- > From: Yongseok Koh > Sent: Wednesday, October 17, 2018 5:08 AM > To: Shahaf Shuler > Cc: dev@dpdk.org; Yongseok Koh ; Ori Kam > > Subject: [PATCH 5/5] net/mlx5: fix flow mark ID conversion in Direct Verbs > > Fixes: d02cb0691299 ("net/mlx5: add Direct Verbs tran

Re: [dpdk-dev] [PATCH 2/5] net/mlx5: fix UDP hash field flag in Direct Verbs

2018-10-16 Thread Ori Kam
> -Original Message- > From: Yongseok Koh > Sent: Wednesday, October 17, 2018 5:08 AM > To: Shahaf Shuler > Cc: dev@dpdk.org; Yongseok Koh ; Ori Kam > > Subject: [PATCH 2/5] net/mlx5: fix UDP hash field flag in Direct Verbs > > Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translat

Re: [dpdk-dev] [PATCH 1/5] net/mlx5: add warning message for Direct Verbs flow

2018-10-16 Thread Ori Kam
> -Original Message- > From: Yongseok Koh > Sent: Wednesday, October 17, 2018 5:08 AM > To: Shahaf Shuler > Cc: dev@dpdk.org; Yongseok Koh ; Ori Kam > > Subject: [PATCH 1/5] net/mlx5: add warning message for Direct Verbs flow > > In case that the library doesn't support DV flow, if en

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: complete closing of port

2018-10-16 Thread Thomas Monjalon
17/10/2018 03:54, Thomas Monjalon: > After closing a port, it cannot be restarted. > So there is no reason to not free all associated resources. > > The last step was done with rte_eth_dev_detach() which is deprecated. > Instead of blindly removing the associated rte_device, the driver should > ch

[dpdk-dev] [PATCH 1/5] net/mlx5: add warning message for Direct Verbs flow

2018-10-16 Thread Yongseok Koh
In case that the library doesn't support DV flow, if enabled by 'dv_flow_en=1', print out a warning message and disable it. Fixes: 51e72d386c99 ("net/mlx5: add runtime parameter to enable Direct Verbs") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh Acked-by: Ori Kam --- drivers/net/mlx5/m

[dpdk-dev] [PATCH 5/5] net/mlx5: fix flow mark ID conversion in Direct Verbs

2018-10-16 Thread Yongseok Koh
Fixes: d02cb0691299 ("net/mlx5: add Direct Verbs translate actions") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow_dv.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c

[dpdk-dev] [PATCH 3/5] net/mlx5: fix item validation in Direct Verbs

2018-10-16 Thread Yongseok Koh
1) remove MPLS item in validation as it doesn't have a translator. 2) add missing NVGRE item to validation 3) match switch-case order between validation and translation. Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items") Fixes: 3d69434113d1 ("net/mlx5: add Direct Verbs validation

[dpdk-dev] [PATCH 4/5] net/mlx5: fix wildcard item for Direct Verbs

2018-10-16 Thread Yongseok Koh
If a network layer is specified with no spec, it means wildcard match. flow_dv_translate_item_*() returns without writing anything if spec is null and it causes creation of wrong flow. E.g., the following flow has to patch with any ipv4 packet. flow create 0 ingress pattern eth / ipv4 / end acti

[dpdk-dev] [PATCH 2/5] net/mlx5: fix UDP hash field flag in Direct Verbs

2018-10-16 Thread Yongseok Koh
Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx

Re: [dpdk-dev] [PATCH v3 1/4] app/testpmd: allow detaching a port not closed

2018-10-16 Thread Thomas Monjalon
+Cc Bernard Note that the function port_is_closed is replaced because a closed port is always seen as invalid after this series: the state is set to RTE_ETH_DEV_UNUSED by rte_eth_dev_release_port(). I may split this patch and add a release note to make it clear. 17/10/2018 03:54, Thomas Monjalon

[dpdk-dev] [PATCH v3 1/4] app/testpmd: allow detaching a port not closed

2018-10-16 Thread Thomas Monjalon
The testpmd application aim is for testing; so order of operations should not be enforced. There was a test to forbid detaching before closing a port. However, it may interesting to test what happens in such case. It is possible for a PMD to automatically close the port when detaching. Signed-off

[dpdk-dev] [PATCH v3 3/4] ethdev: remove release function for secondary process

2018-10-16 Thread Thomas Monjalon
After previous changes, the function rte_eth_dev_release_port() can be used for primary or secondary process as well. The only difference with rte_eth_dev_release_port_secondary() is the shared lock used in rte_eth_dev_release_port(). The function rte_eth_dev_release_port_secondary() was recently

[dpdk-dev] [PATCH v3 2/4] ethdev: free all common data when releasing port

2018-10-16 Thread Thomas Monjalon
This is a clean-up of common ethdev data freeing. All data freeing are moved to rte_eth_dev_release_port() and done only in case of primary process. It is probably fixing some memory leaks for PMDs which were not freeing all data. Signed-off-by: Thomas Monjalon --- drivers/net/af_packet/rte_eth

[dpdk-dev] [PATCH v3 0/4] ethdev port freeing

2018-10-16 Thread Thomas Monjalon
The function rte_eth_dev_detach() is freeing a port and its underlying rte_device object. The issue is that we may have several ports associated to the same rte_device. The right replacement is to free the port, and free the rte_device if no more ports. At ethdev level, the public function for por

[dpdk-dev] [PATCH v3 4/4] ethdev: complete closing of port

2018-10-16 Thread Thomas Monjalon
After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of blindly removing the associated rte_device, the driver should check if no more port (ethdev, cryptodev, etc) is

[dpdk-dev] [PATCH] doc: update release note for hash library

2018-10-16 Thread Yipeng Wang
This patch updates release note for the new extendable bucket feature and the partial-key hashing. Signed-off-by: Yipeng Wang --- doc/guides/rel_notes/release_18_11.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/relea

Re: [dpdk-dev] [PATCH] app/testpmd: fix physic port socket initialization

2018-10-16 Thread Phil Yang (Arm Technology China)
> -Original Message- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Tuesday, October 16, 2018 6:40 PM > To: dev ; dev@dpdk.org > Cc: Yigit, Ferruh ; nd > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix physic port socket > initialization > > > > > -Original Message- > >

[dpdk-dev] [PATCH v2] app/testpmd: fix physic port socket initialization

2018-10-16 Thread Phil Yang
Once the lcore list setting excluded the socket which physic device attached, it will cause failure. Meanwhile, it will disable Testpmd cross NUMA scenario. Fixes: dbfb8ec ("app/testpmd: optimize mbuf pool allocation") Signed-off-by: Phil Yang Reviewed-by: Gavin Hu --- app/test-pmd/testpmd.c |

[dpdk-dev] [PATCH v4 4/6] examples/kni: monitor and update link status continually

2018-10-16 Thread Dan Gora
Update KNI example to add the command line flag '-m' to enable a function to continuously monitor the Ethernet link status of the physical link and update the link status of the corresponding interfaces with rte_kni_update_link(). Signed-off-by: Dan Gora --- examples/kni/Makefile | 2 ++ exampl

[dpdk-dev] [PATCH v4 6/6] examples/kni: improve zeroing statistics

2018-10-16 Thread Dan Gora
The worker threads incrementing the rx/tx_packets race with the signal handler from the main thread zeroing the entire statistics structure. This can cause the statistics to fail to be zeroed, even when there is no traffic on those interfaces. Improve zeroing the statistics by only incrementing rx

[dpdk-dev] [PATCH v4 5/6] examples/kni: add log msgs to show and clear stats

2018-10-16 Thread Dan Gora
Add logging messages showing the commands necessary for the user to have the application display and zero the statistics. Signed-off-by: Dan Gora --- examples/kni/main.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.

[dpdk-dev] [PATCH v4 3/6] kni: set default carrier state of interface

2018-10-16 Thread Dan Gora
Add module parameter 'carrier='on|off' to set the default carrier state for linux network interfaces created by the KNI module. The default carrier state is 'off'. For KNI interfaces which need to reflect the carrier state of a physical Ethernet port controlled by the DPDK application, the defaul

[dpdk-dev] [PATCH v4 1/6] kni: add API to set link status on kernel interface

2018-10-16 Thread Dan Gora
Add a new API function to KNI, rte_kni_update_link() to allow DPDK applications to update the link status for KNI network interfaces in the linux kernel. Signed-off-by: Dan Gora --- lib/librte_kni/rte_kni.c | 41 ++ lib/librte_kni/rte_kni.h | 20 ++

[dpdk-dev] [PATCH v4 2/6] kni: add link status test

2018-10-16 Thread Dan Gora
Test changing the link status of the KNI interface with rte_kni_update_link(). Signed-off-by: Dan Gora --- test/test/test_kni.c | 77 1 file changed, 77 insertions(+) diff --git a/test/test/test_kni.c b/test/test/test_kni.c index cf64c0b27..e38206905

[dpdk-dev] [PATCH v4 0/6] kni: add API to set link status on kernel interface

2018-10-16 Thread Dan Gora
Hi All, Attached is version 4 of a patchset to add a new API function to set the link status on kernel interfaces created with the KNI kernel module. v4 * Rework rte_kni_update_link to only take linkup/linkdown as parameter, return previous link state, and remove log messages. * Update pa

[dpdk-dev] [PATCH] test: fix compilation error in external memory test

2018-10-16 Thread Dan Gora
Fix a compilation error in test_external_mem.c: CC test_external_mem.o test_external_mem.c: In function ‘test_external_mem’: test_external_mem.c:375:2: error: ‘for’ loop initial declarations are only allowed in C99 mode for (int i = 0; i < n_pages; i++) { ^ test_e

[dpdk-dev] [PATCH v3 0/2] support e-switch flow count action

2018-10-16 Thread Mordechay Haimovsky
The following patches add support in mlx5 PMD for configuring and reading flow counters from the device e-switch. Moti Haimovsky (2): net/mlx5: refactor TC-flow infrastructure net/mlx5: support e-switch flow count action drivers/net/mlx5/mlx5.c| 18 +- drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH v3 1/2] net/mlx5: refactor TC-flow infrastructure

2018-10-16 Thread Mordechay Haimovsky
This commit refactors tc_flow as a preparation to coming commits that sends different type of messages and expect differ type of replies while still using the same underlying routines. Signed-off-by: Moti Haimovsky --- v3: * Rebase on top of d80c8167c4fe ("net/mlx5: fix compilation issue on A

[dpdk-dev] [PATCH v3 2/2] net/mlx5: support e-switch flow count action

2018-10-16 Thread Mordechay Haimovsky
This commit adds support for configuring flows destined to the mlx5 eswitch with 'count' action and for querying these counts at runtime. Each flow rule configured by the mlx5 driver is implicitly assigned with flow counters. These counters can be retrieved when querying the flow rule via Netlink,

Re: [dpdk-dev] [PATCH v3 4/7] hash: add memory ordering to avoid race conditions

2018-10-16 Thread Honnappa Nagarahalli
> When I applied this commit: > fatal: sha1 information is lacking or useless > (lib/librte_hash/rte_cuckoo_hash.c). > Please double check. I will verify the patches when I send out the next version. > > >-Original Message- > >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.co

Re: [dpdk-dev] [PATCH v3 3/7] hash: correct key store element alignment

2018-10-16 Thread Honnappa Nagarahalli
> >-Original Message- > >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > >Sent: Thursday, October 11, 2018 11:32 PM > >To: Richardson, Bruce ; De Lara Guarch, > >Pablo > >Cc: dev@dpdk.org; Wang, Yipeng1 ; > >honnappa.nagaraha...@arm.com; dharmik.thak...@arm.com; > >gavin

[dpdk-dev] dpaax warnings

2018-10-16 Thread Thomas Monjalon
Hi Shreyansh, When initializing DPDK on x86, we get those warnings: dpaax: Unable to glob device-tree memory node: (/proc/device-tree/memory[@0-9]*/reg)(3) dpaax: PA->VA translation not available; dpaax: Expect performance impact. Is it possible to avoid running dpaax ini

[dpdk-dev] [PATCH v4 1/3] ethdev: add raw encapsulation action

2018-10-16 Thread Ori Kam
Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet header, while L3 encapsulation is where the inner packet doesn't have the Ethernet header). In addtion the parameter to to the encap action is

[dpdk-dev] [PATCH v4 2/3] app/testpmd: add MPLSoUDP encapsulation

2018-10-16 Thread Ori Kam
MPLSoUDP is an example for L3 tunnel encapsulation. L3 tunnel type is a tunnel that is missing the layer 2 header of the inner packet. Example for MPLSoUDP tunnel: ETH / IPV4 / UDP / MPLS / IP / L4..L7 In order to encapsulate such a tunnel there is a need to remove L2 of the inner packet and enc

[dpdk-dev] [PATCH v4 3/3] app/testpmd: add MPLSoGRE encapsulation

2018-10-16 Thread Ori Kam
Example for MPLSoGRE tunnel: ETH / IPV4 / GRE / MPLS / IP / L4..L7 In order to encapsulate such a tunnel there is a need to remove L2 of the inner packet and encap the remaining tunnel, this is done by applying 2 rte flow commands l2_decap followed by mplsogre_encap. Both commands must appear in t

[dpdk-dev] [PATCH v4 0/3] ethdev: add generic raw tunnel encapsulation actions

2018-10-16 Thread Ori Kam
This series implement the raw tunnel encapsulation actions and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet header, wh

[dpdk-dev] [PATCH v2] vhost/crypto: fix build without cryptodev (shared lib)

2018-10-16 Thread Timothy Redaelli
Currently it's not possible to build DPDK as shared library with cryptodev disabled since vhost is trying to link with rte_crypto, but rte_crypto and rte_hash are only needed when you build vhost_crypto and so only when cryptodev is enabled. This patch fix this by linking rte_vhost with rte_crypto

Re: [dpdk-dev] [RFC] DFS (DPDK Filesystem)

2018-10-16 Thread Wiles, Keith
> On Oct 9, 2018, at 5:52 PM, Wiles, Keith wrote: > > > >> On Oct 8, 2018, at 5:42 PM, Wiles, Keith wrote: >> >> Hi Everyone, >> >> I would like to request comments on DFS as I presented at the DPDK summit in >> Ireland. > > Here is a repo you can look at and play with. The code is most

Re: [dpdk-dev] [PATCH] vhost/crypto: fix build without cryptodev (shared lib)

2018-10-16 Thread Maxime Coquelin
On 10/16/2018 06:54 PM, Timothy Redaelli wrote: Currently it's not possible to build DPDK as shared library with cryptodev disabled since vhost is trying to link with rte_crypto, but rte_crypto and rte_hash are only needed when you build vhost_crypto and so only when cryptodev is enabled. Thi

[dpdk-dev] [PATCH] vhost/crypto: fix build without cryptodev (shared lib)

2018-10-16 Thread Timothy Redaelli
Currently it's not possible to build DPDK as shared library with cryptodev disabled since vhost is trying to link with rte_crypto, but rte_crypto and rte_hash are only needed when you build vhost_crypto and so only when cryptodev is enabled. This patch fix this by linking rte_vhost with rte_crypto

Re: [dpdk-dev] [PATCH v17 0/6] enable hotplug on multi-process

2018-10-16 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, October 16, 2018 3:52 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; gaetan.ri...@6wind.com; Burakov, Anatoly > ; arybche...@solarflare.com; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ;

[dpdk-dev] [Bug 95] eal/memory: testpmd failed to start with --socket-mem > 16384 with 2MB huge pages and with memory hotplug

2018-10-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=95 Bug ID: 95 Summary: eal/memory: testpmd failed to start with --socket-mem > 16384 with 2MB huge pages and with memory hotplug Product: DPDK Version: 18.11 Hardware: x86

[dpdk-dev] [PATCH v5 12/13] usertools: add client python script for telemetry

2018-10-16 Thread Kevin Laatz
From: Ciara Power This patch adds a python script which can be used as a demo client. The script is interactive and will allow the user to register, request statistics, and unregister. To run the script, an argument for the client file path must be passed in: "python telemetry_client.py ". This

[dpdk-dev] [PATCH v5 13/13] build: add dependency on telemetry to apps in meson

2018-10-16 Thread Kevin Laatz
This patch adds telemetry as a dependecy to all applications. Without these changes, the --telemetry flag will not be recognised and applications will fail to run if they want to enable telemetry. Signed-off-by: Bruce Richardson Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- app/mes

[dpdk-dev] [PATCH v5 11/13] doc: add telemetry documentation

2018-10-16 Thread Kevin Laatz
From: Ciara Power This patch adds all documentation for telemetry. A description on how to use the Telemetry API with a DPDK application is given in this document. It also adds the MAINTAINERS file entry for telemetry. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by: K

[dpdk-dev] [PATCH v5 10/13] telemetry: add ability to disable selftest

2018-10-16 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to enable/disable the selftest. This functionality will be extended in future to make the enabling/disabling more dynamic and remove this 'hardcoded' approach. We are temporarily using this approach due to the design changes (vdev vs eal) made to t

[dpdk-dev] [PATCH v5 09/13] telemetry: add tests for telemetry api

2018-10-16 Thread Kevin Laatz
From: Ciara Power This patch adds all tests for the Telemetry API. The tests added include a parser test, selftest, and socket messaging tests. The parser tests pass valid and invalid messages to the parser to ensure the correct return values are received. The selftest tests basic functions in t

[dpdk-dev] [PATCH v5 08/13] telemetry: format json response when sending stats

2018-10-16 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to create a JSON message in order to send it to a client socket. When stats are requested by a client, they are retrieved from the metrics library and encoded in JSON format. Signed-off-by: Ciara Power Signed-off-by: Brian Archbold Signed-off-by

[dpdk-dev] [PATCH v5 07/13] telemetry: update metrics before sending stats

2018-10-16 Thread Kevin Laatz
From: Ciara Power This patch adds functionality to update the statistics in the metrics library with values from the ethdev stats. Values need to be updated before they are encoded into a JSON message and sent to the client that requested them. The JSON encoding will be added in a subsequent pat

[dpdk-dev] [PATCH v5 04/13] telemetry: add initial connection socket

2018-10-16 Thread Kevin Laatz
From: Ciara Power This patch adds the telemetry UNIX socket. It is used to allow connections from external clients. On the initial connection from a client, ethdev stats are registered in the metrics library, to allow for their retrieval at a later stage. Signed-off-by: Ciara Power Signed-off-

[dpdk-dev] [PATCH v5 02/13] eal: make get runtime dir function public

2018-10-16 Thread Kevin Laatz
This patch makes the eal_get_runtime_dir() API public so it can be used from outside EAL. Signed-off-by: Kevin Laatz Acked-by: Harry van Haaren --- Note: I have added rte_eal_get_runtime_dir() to the 18.11 version in the .map file instead of the EXPERIMENTAL section as the function already exis

[dpdk-dev] [PATCH v5 06/13] telemetry: add parser for client socket messages

2018-10-16 Thread Kevin Laatz
From: Ciara Power This patch adds the parser file. This is used to parse any messages that are received on any of the client sockets. Currently, the unregister functionality works using the parser. Functionality relating to getting statistic values for certain ports will be added in a subsequent

[dpdk-dev] [PATCH v5 03/13] telemetry: initial telemetry infrastructure

2018-10-16 Thread Kevin Laatz
From: Ciara Power This patch adds the infrastructure and initial code for the telemetry library. The telemetry init is registered with eal_init(). We can then check to see if --telemetry was passed as an eal option. If --telemetry was parsed, then we call telemetry init at the end of eal init.

[dpdk-dev] [PATCH v5 05/13] telemetry: add client feature and sockets

2018-10-16 Thread Kevin Laatz
From: Ciara Power This patch introduces clients to the telemetry API. When a client makes a connection through the initial telemetry socket, they can send a message through the socket to be parsed. Register messages are expected through this socket, to enable clients to register and have a clien

[dpdk-dev] [PATCH v5 01/13] eal: add param register infrastructure

2018-10-16 Thread Kevin Laatz
This commit adds infrastructure to EAL that allows an application to register it's init function with EAL. This allows libraries to be initialized at the end of EAL init. This infrastructure allows libraries that depend on EAL to be initialized as part of EAL init, removing circular dependency iss

[dpdk-dev] [PATCH v5 00/13] introduce telemetry library

2018-10-16 Thread Kevin Laatz
This patchset introduces a Telemetry library for DPDK Service Assurance. This library provides an easy way to query DPDK Ethdev metrics. The telemetry library provides a method for a service assurance component to retrieve metrics from a DPDK packet forwarding application. Communicating from the s

Re: [dpdk-dev] [PATCH] ethdev: add function name to log message

2018-10-16 Thread Ferruh Yigit
On 10/12/2018 3:54 PM, Stephen Hemminger wrote: > On Fri, 12 Oct 2018 14:43:57 +0200 > Adrien Mazarguil wrote: > >> On Fri, Oct 12, 2018 at 11:45:01AM +0100, Ferruh Yigit wrote: >>> On 10/12/2018 11:42 AM, Ferruh Yigit wrote: On 10/11/2018 6:59 PM, Stephen Hemminger wrote: > @@ -161,

Re: [dpdk-dev] [PATCH v8] linuxapp, eal: Fix the memory leak issue of logid

2018-10-16 Thread Ferruh Yigit
On 9/12/2018 2:31 AM, Ziye Yang wrote: > From: Ziye Yang > > This patch is used to fix the memory leak issue of logid. > We use the ASAN test in SPDK when intergrating DPDK and > find this memory leak issue. > > Signed-off-by: Ziye Yang Reviewed-by: Ferruh Yigit check-git-log.sh complains a

Re: [dpdk-dev] [PATCH] net/tap: fix reported number of Tx packets

2018-10-16 Thread Ferruh Yigit
On 10/10/2018 1:39 PM, Wiles, Keith wrote: > > >> On Oct 10, 2018, at 2:01 AM, Raslan Darawsheh wrote: >> >> When writev fails to send packets it doesn't update the >> number of Tx packets, but it still num_tx is updated. >> >> the value that should be returned is the actual number >> of sent pa

Re: [dpdk-dev] [PATCH v4 01/13] eal: add param register infrastructure

2018-10-16 Thread Thomas Monjalon
16/10/2018 16:20, Laatz, Kevin: > Hi Thomas, > > Thanks for reviewing, see replies below. > > > On 16/10/2018 14:42, Thomas Monjalon wrote: > > Hi, > > > > 11/10/2018 18:58, Kevin Laatz: > >> This commit adds infrastructure to EAL that allows an application to > >> register it's init function wi

Re: [dpdk-dev] [dpdk-users] i40e VF PMD not getting multicast packets

2018-10-16 Thread Dey, Souvik
Hi Xing/Wu, I am using dpdk 17.11.2 and i40e kernel driver 2.4.6, and I see all multocast packets are not reaching the VF. Do we support/tested i40evf pmd for v6 support ? Can you please let me know what we need to do extra to make v6 work with i40evf pmd. V4 works fine. I also h

Re: [dpdk-dev] [PATCH v1] doc: fix sample application formatting

2018-10-16 Thread Ferruh Yigit
On 8/16/2018 5:35 PM, Marko Kovacevic wrote: > Fixed formatting an extra header was added making it an extra > section when it was not intended. > > Fixes: d0dff9ba445e ("doc: sample application user guide") > Cc: bernard.iremon...@intel.com > > Signed-off-by: Marko Kovacevic Cc: sta...@dpdk.or

Re: [dpdk-dev] [dpdk-users] i40e VF PMD not getting multicast packets

2018-10-16 Thread Dey, Souvik
Hi Ruinan, In that case, do we say that v6 will not work at all i40evf pmd till trust mode is on ? Yes I do agree that I am able to see the error in the dmesg on the host “kernel: i40e :83:00.3: Unprivileged VF 1 is attempting to configure promiscuous mode” , when trust mode

Re: [dpdk-dev] [PATCH] app/test-pmd: add and identify shaper profile parameters

2018-10-16 Thread Dumitrescu, Cristian
> > Can you also update the help command section (test-pmd/cmdline.c) as well > as the documentation (doc/guides/testpmd_app_ug) for these changes. > Thanks! Rosen, any update on this request? This is required in order to merge this patch. Thanks, Cristian

Re: [dpdk-dev] [PATCH 4/4] ixgbe: remove mild profanity

2018-10-16 Thread Ferruh Yigit
On 7/25/2018 7:20 PM, stephen at networkplumber.org (Stephen Hemminger) wrote: > At the tail end of comment about barriers (I feel your pain); > remove mild profanity. > > Signed-off-by: Stephen Hemminger Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity

2018-10-16 Thread Ferruh Yigit
On 10/16/2018 3:45 PM, Ferruh Yigit wrote: > On 9/19/2018 5:40 PM, Mody, Rasesh wrote: >>> From: Stephen Hemminger >>> Sent: Tuesday, September 18, 2018 8:07 AM >>> >>> On Tue, 18 Sep 2018 11:40:28 +0200 >>> Thomas Monjalon wrote: >>> 25/07/2018 20:20, Stephen Hemminger: > No need for pr

[dpdk-dev] [pull-request] next-crypto 18.11 rc1

2018-10-16 Thread Akhil Goyal
The following changes since commit c89fdd8da2f076cd0ec698707162da15f2a93e17: eal/bsd: fix build (2018-10-16 14:54:25 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 5454c866d0c1aa288ecf19291be8992c85907fe6: drivers/

Re: [dpdk-dev] [PATCH 2/4] bnx2x: remove profanity

2018-10-16 Thread Ferruh Yigit
On 9/19/2018 5:40 PM, Mody, Rasesh wrote: >> From: Stephen Hemminger >> Sent: Tuesday, September 18, 2018 8:07 AM >> >> On Tue, 18 Sep 2018 11:40:28 +0200 >> Thomas Monjalon wrote: >> >>> 25/07/2018 20:20, Stephen Hemminger: No need for profanity in comments. Signed-off-by: Stephen

Re: [dpdk-dev] [PATCH v4 0/8] FIPS validation capability

2018-10-16 Thread Akhil Goyal
Hi Marko/Fan, On 10/12/2018 8:14 PM, Marko Kovacevic wrote: > This sample application is made for the purpose so that users of DPDK > who wish to get FIPS certification for their platforms, this sample app > enables > users to parse test vectors that is gotten from NIST and be able to get > a gen

Re: [dpdk-dev] [PATCH v3] drivers/qat: fix failure to create PMD

2018-10-16 Thread Akhil Goyal
On 10/11/2018 10:57 PM, Cel, TomaszX wrote: >> -Original Message- >> From: Trahe, Fiona >> Sent: Thursday, October 11, 2018 7:14 PM >> To: dev@dpdk.org >> Cc: akhil.go...@nxp.com; sta...@dpdk.org; Jozwiak, TomaszX >> ; Cel, TomaszX ; >> Trahe, Fiona >> Subject: [PATCH v3] drivers/qat: fi

Re: [dpdk-dev] [dpdk-stable] [PATCH] lib/cryptodev: fix library version

2018-10-16 Thread Akhil Goyal
On 10/15/2018 6:48 PM, Ferruh Yigit wrote: > On 10/15/2018 12:28 PM, stable-boun...@dpdk.org wrote: >> This patch fixes the cryptodev library version number that was >> missed updating in DPDK 18.08. >> >> Fixes: a4493be5bdfa ("cryptodev: replace bus specific struct with generic >> dev") >> Cc:

Re: [dpdk-dev] [PATCH v5 0/3] security: support for pdcp

2018-10-16 Thread Akhil Goyal
On 10/16/2018 4:08 PM, Akhil Goyal wrote: > From: Akhil Goyal > > Security library currently only has support for IPSec protocol. > This patchset defines structures for pdcp protocol in rte_security > and provide a sample driver implementation for lookaside protocol > offload to support PDCP. >

Re: [dpdk-dev] [PATCH v2 00/14] Introducing the NXP CAAM job ring driver

2018-10-16 Thread Akhil Goyal
On 10/12/2018 8:10 PM, Gagandeep Singh wrote: > v1->v2 change-log: > * Most of the checkpatch warnings and erros are removed > * CONFIG_RTE_CAAM_JR_PMD_MAX_NB_SESSIONS and >CONFIG_RTE_PMD_CAAM_JR_DEBUG flags removed > * local unlikely macro removed > * extra spaces removed and functions forma

[dpdk-dev] [PATCH v3] net/softnic: add support for flow API vxlan encap action

2018-10-16 Thread Reshma Pattan
Added support to handle vxlan encap action of rte flow rule. Signed-off-by: Reshma Pattan Acked-by: Dumitrescu Cristian --- v3: fixed vlan pcp, dei and vid parsing. fixed ipv6 flow_label and dscp parsing. --- drivers/net/softnic/rte_eth_softnic_flow.c | 192 + 1 file changed

Re: [dpdk-dev] [PATCH] doc: clarify VLAN and QinQ Tx offload prerequisite

2018-10-16 Thread Ferruh Yigit
On 10/16/2018 2:16 PM, Jerin Jacob wrote: > - Fix missing PKT_TX_VLAN mbuf.ol_flag and mbuf.vlan_tci > fields for Tx VLAN INSERT offload. > > - Fix missing mbuf.vlan_tci_outer field for Tx QINQ INSERT offload. > > - Rename deprecated PKT_TX_QINQ_PKT to PKT_TX_QINQ > > Fixes: cba7f53b717d ("ethde

Re: [dpdk-dev] [PATCH v4 01/13] eal: add param register infrastructure

2018-10-16 Thread Laatz, Kevin
Hi Thomas, Thanks for reviewing, see replies below. On 16/10/2018 14:42, Thomas Monjalon wrote: Hi, 11/10/2018 18:58, Kevin Laatz: This commit adds infrastructure to EAL that allows an application to register it's init function with EAL. This allows libraries to be initialized at the end of

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: support metadata as flow rule criteria

2018-10-16 Thread Andrew Rybchenko
On 10/11/18 1:49 PM, Dekel Peled wrote: As described in [1], a new rte_flow item is added to support metadata to use as flow rule match pattern. The metadata is an opaque item, fully controlled by the application. The use of metadata is relevant for egress rules only. It can be set in the flow r

Re: [dpdk-dev] [PATCH v2 1/2] mbuf: fix missing Tx offload flag name and list update

2018-10-16 Thread Ferruh Yigit
On 10/16/2018 2:42 PM, Ferruh Yigit wrote: > On 10/16/2018 1:45 PM, Jerin Jacob wrote: >> Fix missing PKT_TX* ol_flag name and list updatation. >> >> Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") >> Fixes: 829a1c2c41dc ("mbuf: extend flow director field") >> Fixes: 63c0d74daaa9 (

Re: [dpdk-dev] [PATCH v4 01/13] eal: add param register infrastructure

2018-10-16 Thread Thomas Monjalon
Hi, 11/10/2018 18:58, Kevin Laatz: > This commit adds infrastructure to EAL that allows an application to > register it's init function with EAL. This allows libraries to be > initialized at the end of EAL init. > > This infrastructure allows libraries that depend on EAL to be initialized > as pa

Re: [dpdk-dev] [PATCH v2 1/2] mbuf: fix missing Tx offload flag name and list update

2018-10-16 Thread Ferruh Yigit
On 10/16/2018 1:45 PM, Jerin Jacob wrote: > Fix missing PKT_TX* ol_flag name and list updatation. > > Fixes: 6d18505efaa6 ("vhost: support UDP Fragmentation Offload") > Fixes: 829a1c2c41dc ("mbuf: extend flow director field") > Fixes: 63c0d74daaa9 ("mbuf: add Tx side tunneling type") > > Cc: sta.

Re: [dpdk-dev] [PATCH v1 2/2] test/crypto: remove data verification at rsa verify operation

2018-10-16 Thread Akhil Goyal
On 10/11/2018 7:13 PM, Akash Saxena wrote: > Change unit test app to check only for op->status = > RTE_CRYPTO_OP_STATUS_SUCCESS/ERROR instead of calling rsa_verify(). > > Signed-off-by: Ayuj Verma > Signed-off-by: Shally Verma > --- > test/test/test_cryptodev_asym.c | 9 ++--- > 1 file c

Re: [dpdk-dev] [PATCH v1 1/2] crypto/openssl: changes for RSA verify operation

2018-10-16 Thread Akhil Goyal
On 10/11/2018 7:13 PM, Akash Saxena wrote: > Add tmp buffer to pass to OpenSSL sign API and memcmp output with > original plain text to verify signature match. > Set op->status = RTE_CRYPO_OP_STATUS_ERROR on signature mismatch. > > Signed-off-by: Ayuj Verma > Signed-off-by: Akash Saxena > Signe

[dpdk-dev] [PATCH] doc: clarify VLAN and QinQ Tx offload prerequisite

2018-10-16 Thread Jerin Jacob
- Fix missing PKT_TX_VLAN mbuf.ol_flag and mbuf.vlan_tci fields for Tx VLAN INSERT offload. - Fix missing mbuf.vlan_tci_outer field for Tx QINQ INSERT offload. - Rename deprecated PKT_TX_QINQ_PKT to PKT_TX_QINQ Fixes: cba7f53b717d ("ethdev: introduce Tx queue offloads API") Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v1 1/2] crypto/openssl: changes for RSA verify operation

2018-10-16 Thread Akhil Goyal
On 10/11/2018 7:13 PM, Akash Saxena wrote: > Add tmp buffer to pass to OpenSSL sign API and memcmp output with > original plain text to verify signature match. > Set op->status = RTE_CRYPO_OP_STATUS_ERROR on signature mismatch. > > Signed-off-by: Ayuj Verma > Signed-off-by: Akash Saxena > Signed-

Re: [dpdk-dev] [PATCH v4 1/3] app/testpmd: move dumping packets to a separate function

2018-10-16 Thread Ferruh Yigit
On 10/16/2018 11:10 AM, Raslan Darawsheh wrote: > Hi Ferruh, > > PSB. > > Kindest regards, > Raslan Darawsheh > >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, October 11, 2018 5:56 PM >> To: Raslan Darawsheh ; jingjing...@intel.com >> Cc: Thomas Monjalon ; dev@dpdk.org;

Re: [dpdk-dev] [PATCH 2/6] doc: remove shared libs with no API from release notes

2018-10-16 Thread Jerin Jacob
-Original Message- > Date: Mon, 15 Oct 2018 15:50:53 +0100 > From: Ferruh Yigit > To: John McNamara , Marko Kovacevic > > CC: dev@dpdk.org, Ferruh Yigit , > yipeng1.w...@intel.com, pablo.de.lara.gua...@intel.com, Jerin Jacob > , Nipun Gupta , > Stephen Hemminger , "K. Y. Srinivasan" >

Re: [dpdk-dev] [PATCH v2 00/14] Introducing the NXP CAAM job ring driver

2018-10-16 Thread Akhil Goyal
On 10/12/2018 8:10 PM, Gagandeep Singh wrote: > v1->v2 change-log: > * Most of the checkpatch warnings and erros are removed > * CONFIG_RTE_CAAM_JR_PMD_MAX_NB_SESSIONS and >CONFIG_RTE_PMD_CAAM_JR_DEBUG flags removed > * local unlikely macro removed > * extra spaces removed and functions forma

  1   2   >