Re: [dpdk-dev] [PATCH 2/2] doc: clarify L4 Tx checksum prerequisite

2018-10-04 Thread Andrew Rybchenko
On 10/5/18 7:46 AM, Jerin Jacob wrote: Based on PKT_TX_[TCP|UDP|SCTP]_CKSUM definition the user needs to fill l2_len and l3_len mbuf fields before issuing HW Tx checksum request. Fixes: dad1ec72a377 ("doc: document NIC features") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob Acked-by: Andre

Re: [dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite

2018-10-04 Thread Andrew Rybchenko
On 10/5/18 7:46 AM, Jerin Jacob wrote: Based on PKT_TX_IP_CKSUM definition the user needs to fill l2_len and l3_len mbuf fields before issuing HW Tx checksum request. Fixes: dad1ec72a377 ("doc: document NIC features") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob Acked-by: Andrew Rybchenko

[dpdk-dev] [PATCH 2/2] doc: clarify L4 Tx checksum prerequisite

2018-10-04 Thread Jerin Jacob
Based on PKT_TX_[TCP|UDP|SCTP]_CKSUM definition the user needs to fill l2_len and l3_len mbuf fields before issuing HW Tx checksum request. Fixes: dad1ec72a377 ("doc: document NIC features") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob --- See PKT_TX_TCP_CKSUM defintion at https://git.dpdk.or

[dpdk-dev] [PATCH 1/2] doc: clarify L3 Tx checksum prerequisite

2018-10-04 Thread Jerin Jacob
Based on PKT_TX_IP_CKSUM definition the user needs to fill l2_len and l3_len mbuf fields before issuing HW Tx checksum request. Fixes: dad1ec72a377 ("doc: document NIC features") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob --- See PKT_TX_IP_CKSUM at https://git.dpdk.org/dpdk/tree/lib/librte_

Re: [dpdk-dev] [PATCH] net/mlx5: allow multi probing

2018-10-04 Thread Yongseok Koh
On Wed, Oct 03, 2018 at 01:01:23AM -0700, Ophir Munk wrote: > Implement probing of a device multiple times, see [1]. > Consecutive probing requests with a devargs string may contain > repetitive master and representors devices for which eth device should > be created. If an eth device already exist

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-10-04 Thread Gavin Hu (Arm Technology China)
Hi Jerin, Thanks for your review, inline comments from our internal discussions. BR. Gavin > -Original Message- > From: Jerin Jacob > Sent: Saturday, September 29, 2018 6:49 PM > To: Gavin Hu (Arm Technology China) > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; Steve Capper > ; Ola Lilje

[dpdk-dev] [PATCH v6 3/4] test/hash: implement extendable bucket hash test

2018-10-04 Thread Yipeng Wang
This commit changes the current rte_hash unit test to test the extendable table feature and performance. Signed-off-by: Yipeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Dharmik Thakkar --- test/test/test_hash.c | 159 +++-- test/test/test_has

[dpdk-dev] [PATCH v6 2/4] hash: add extendable bucket feature

2018-10-04 Thread Yipeng Wang
In use cases that hash table capacity needs to be guaranteed, the extendable bucket feature can be used to contain extra keys in linked lists when conflict happens. This is similar concept to the extendable bucket hash table in packet framework. This commit adds the extendable bucket feature. User

[dpdk-dev] [PATCH v6 1/4] hash: fix race condition in iterate

2018-10-04 Thread Yipeng Wang
In rte_hash_iterate, the reader lock did not protect the while loop which checks empty entry. This created a race condition that the entry may become empty when enters the lock, then a wrong key data value would be read out. This commit reads out the position in the while condition, which makes su

[dpdk-dev] [PATCH v6 4/4] hash: use partial-key hashing

2018-10-04 Thread Yipeng Wang
This commit changes the hashing mechanism to "partial-key hashing" to calculate bucket index and signature of key. This is proposed in Bin Fan, et al's paper "MemC3: Compact and Concurrent MemCache with Dumber Caching and Smarter Hashing". Basically the idea is to use "xor" to derive alternative

[dpdk-dev] [PATCH v6 0/4] hash: add extendable bucket and partial key hashing

2018-10-04 Thread Yipeng Wang
This patch has dependency on another bug fix patch set: http://patchwork.dpdk.org/cover/45611/ This patch set makes two major optimizations over the current rte_hash library. First, it adds Extendable Bucket Table feature: a new structure that can accommodate keys that failed to get inserted into

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix representor port xstats

2018-10-04 Thread Thomas Monjalon
28/09/2018 02:11, Yongseok Koh: > > > On Sep 19, 2018, at 12:55 AM, Xueming Li wrote: > > > > This patch fixes the issue that representor port shows xstats of PF. > > > > Fixes: 2b7302638898 ("net/mlx5: probe all port representors") > > Cc: adrien.mazarg...@6wind.com > > > > Signed-off-by: Xue

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix wrong representor port link status

2018-10-04 Thread Thomas Monjalon
28/09/2018 02:13, Yongseok Koh: > > > On Sep 19, 2018, at 1:27 AM, Xueming Li wrote: > > > > Current code uses PF links status for representor port, not the > > representor > > interface itself. This caused wrong representor port link status when > > toggling linterface up or down. > > > > Fixe

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix Direct Verbs flow matcher caching

2018-10-04 Thread Thomas Monjalon
04/10/2018 07:53, Ori Kam: > The Direct Verbs are using matcher object to filter flows, This object > can be reused for all flows that are using the same flow items and > masks. > > This was implemented with an issue, that the list pointer pointed > to incorrect list type, this resulted in compila

Re: [dpdk-dev] [PATCH 3/4] hash: fix rw concurrency while moving keys

2018-10-04 Thread Wang, Yipeng1
>-Original Message- >From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] >Sent: Wednesday, October 3, 2018 8:54 PM >To: Honnappa Nagarahalli ; Wang, Yipeng1 >; Van Haaren, Harry >; Richardson, Bruce >Cc: De Lara Guarch, Pablo ; dev@dpdk.org; >Gavin Hu (Arm Technology China)

[dpdk-dev] [PATCH] app/testpmd: fix displaying RSS hash functions

2018-10-04 Thread Ferruh Yigit
Command shouldn't ask RSS hash functions as argument to get supported RSS hash function, those values will be overwritten by PMD anyway. To display configured RSS hash functions "show port (port_id) rss-hash" To display configured RSS hash functions and hash key "show port (port_id) rss-hash key"

Re: [dpdk-dev] [PATCH v2 3/5] bus/pci: use IOVAs check when setting IOVA mode

2018-10-04 Thread Alejandro Lucero
On Thu, Oct 4, 2018 at 4:49 PM Burakov, Anatoly wrote: > On 04-Oct-18 2:35 PM, Alejandro Lucero wrote: > > > > > > On Wed, Oct 3, 2018 at 1:56 PM Burakov, Anatoly > > mailto:anatoly.bura...@intel.com>> wrote: > > > > On 31-Aug-18 1:50 PM, Alejandro Lucero wrote: > > > Although VT-d emula

Re: [dpdk-dev] [PATCH v2 2/5] mem: use address hint for mapping hugepages

2018-10-04 Thread Alejandro Lucero
On Thu, Oct 4, 2018 at 4:43 PM Burakov, Anatoly wrote: > On 04-Oct-18 2:15 PM, Alejandro Lucero wrote: > > > > > > On Thu, Oct 4, 2018 at 1:08 PM Burakov, Anatoly > > mailto:anatoly.bura...@intel.com>> wrote: > > > > On 04-Oct-18 12:43 PM, Alejandro Lucero wrote: > > > > > > > >

[dpdk-dev] [PATCH] app/testpmd: clarify flow types in port info

2018-10-04 Thread Ferruh Yigit
In "show port info #" cmd output, "Supported flow types:" part is not clear what flow types are listed. Those are flow types that hash calculation offload supported by NIC. Updated command output as "Supported RSS offload flow types:" Signed-off-by: Ferruh Yigit --- app/test-pmd/config.c | 4 ++

Re: [dpdk-dev] Fwd: [PATCH v2 1/5] mem: add function for checking memsegs IOVAs addresses

2018-10-04 Thread Alejandro Lucero
On Thu, Oct 4, 2018 at 4:39 PM Burakov, Anatoly wrote: > On 04-Oct-18 1:59 PM, Alejandro Lucero wrote: > > I sent this email only to Anatoly. Sending it again to mailing list. > > > > On Wed, Oct 3, 2018 at 1:43 PM Burakov, Anatoly < > anatoly.bura...@intel.com> > > wrote: > > > >> On 31-Aug-18 1

Re: [dpdk-dev] [PATCH] event/dsw: avoid supplying -Wno-format-nonliteral to icc

2018-10-04 Thread Thomas Monjalon
04/10/2018 18:09, Thomas Monjalon: > 03/10/2018 21:18, Ferruh Yigit: > > On 10/3/2018 9:13 AM, Mattias Rönnblom wrote: > > > Make the -Wno-format-nonliteral flag conditional, and only set in > > > clang and gcc builds, since this flag is not supported (nor needed) > > > when building with icc. > >

Re: [dpdk-dev] [PATCH v3 00/11] net/mlx5: add Direct Verbs flow driver support

2018-10-04 Thread Thomas Monjalon
25/09/2018 01:17, Yongseok Koh: > Ori Kam (11): > net/mlx5: split flow validation to dedicated function > net/mlx5: add flow prepare function > net/mlx5: add flow translate function > net/mlx5: add support for multiple flow drivers > net/mlx5: add Direct Verbs validation function > net/

Re: [dpdk-dev] [PATCH v2 0/3] net/mlx5: migrate Linux TC flower driver to new flow engine

2018-10-04 Thread Thomas Monjalon
24/09/2018 21:55, Yongseok Koh: > Yongseok Koh (3): > net/mlx5: add abstraction for multiple flow drivers > net/mlx5: remove Netlink flow driver > net/mlx5: add Linux TC flower driver for E-Switch flow applied to dpdk-next-net-mlx

Re: [dpdk-dev] [PATCH v4 1/2] net/enic: move common Rx functions to a new header file

2018-10-04 Thread Ferruh Yigit
On 10/3/2018 9:09 PM, John Daley wrote: > From: Hyong Youb Kim > > Move a number of Rx functions to the header file so that the avx2 > based Rx handler can use them. > > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley Series applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH] eal/linuxapp: improve segment list preallocation

2018-10-04 Thread Anatoly Burakov
Current code to preallocate segment lists is trying to do everything in one go, and thus ends up being convoluted, hard to understand, and, most importantly, does not scale beyond initial assumptions about number of NUMA nodes and number of page sizes, and therefore has issues on some configuration

Re: [dpdk-dev] [PATCH] event/dsw: avoid supplying -Wno-format-nonliteral to icc

2018-10-04 Thread Thomas Monjalon
03/10/2018 21:18, Ferruh Yigit: > On 10/3/2018 9:13 AM, Mattias Rönnblom wrote: > > Make the -Wno-format-nonliteral flag conditional, and only set in > > clang and gcc builds, since this flag is not supported (nor needed) > > when building with icc. > > > > Signed-off-by: Mattias Rönnblom > > pe

Re: [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask

2018-10-04 Thread Ferruh Yigit
On 10/4/2018 3:31 AM, Hu, Jiayu wrote: > > >> -Original Message- >> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] >> Sent: Tuesday, October 2, 2018 6:52 PM >> To: Olivier Matz >> Cc: dev@dpdk.org; Jerin Jacob ; >> sta...@dpdk.org; Hu, Jiayu >> Subject: [dpdk-dev] [PATCH v2 2

Re: [dpdk-dev] [RFC v3] ethdev: claim device reset as async

2018-10-04 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, October 4, 2018 7:30 PM > To: Zhang, Qi Z ; tho...@monjalon.net; Doherty, > Declan > Cc: ktray...@redhat.com; dev@dpdk.org; Shelton, Benjamin H > ; Vangati, Narender > > Subject: Re: [RFC v3] ethdev: claim device reset as asyn

Re: [dpdk-dev] [PATCH v2] config: disable RTE_NEXT_ABI by default

2018-10-04 Thread Thomas Monjalon
04/10/2018 17:28, Ferruh Yigit: > On 10/4/2018 4:10 PM, Thomas Monjalon wrote: > > 04/10/2018 17:48, Ferruh Yigit: > >> Enabling RTE_NEXT_ABI means to enable APIs that break the ABI for > >> the current release and these APIs are targeted for further release. > > > > It seems nobody is using it in

Re: [dpdk-dev] [PATCH v2 00/10] introduce telemetry library

2018-10-04 Thread Thomas Monjalon
04/10/2018 15:25, Van Haaren, Harry: > From: Van Haaren, Harry > > From: Laatz, Kevin > > > > > > This patchset introduces a Telemetry library for DPDK Service Assurance. > > > This library provides an easy way to query DPDK Ethdev metrics. > > > > > > > > > Note: We are aware that the --telemet

Re: [dpdk-dev] [PATCH] eal/vfio: share the default container in multi process

2018-10-04 Thread Burakov, Anatoly
On 03-Oct-18 1:39 PM, Darek Stojaczyk wrote: So far each process in MP used to have a separate container and relied on the primary process to register all memsegs. Mapping external memory via rte_vfio_container_dma_map() in secondary processes was broken, because the default (process-local) cont

Re: [dpdk-dev] [PATCH v2 3/5] bus/pci: use IOVAs check when setting IOVA mode

2018-10-04 Thread Burakov, Anatoly
On 04-Oct-18 2:35 PM, Alejandro Lucero wrote: On Wed, Oct 3, 2018 at 1:56 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 31-Aug-18 1:50 PM, Alejandro Lucero wrote: > Although VT-d emulation currently only supports 39 bits, it could > be iovas being within that

Re: [dpdk-dev] [PATCH v2 2/5] mem: use address hint for mapping hugepages

2018-10-04 Thread Burakov, Anatoly
On 04-Oct-18 2:15 PM, Alejandro Lucero wrote: On Thu, Oct 4, 2018 at 1:08 PM Burakov, Anatoly mailto:anatoly.bura...@intel.com>> wrote: On 04-Oct-18 12:43 PM, Alejandro Lucero wrote: > > > On Wed, Oct 3, 2018 at 1:50 PM Burakov, Anatoly > mailto:anatoly.bura...@intel.

Re: [dpdk-dev] Fwd: [PATCH v2 1/5] mem: add function for checking memsegs IOVAs addresses

2018-10-04 Thread Burakov, Anatoly
On 04-Oct-18 1:59 PM, Alejandro Lucero wrote: I sent this email only to Anatoly. Sending it again to mailing list. On Wed, Oct 3, 2018 at 1:43 PM Burakov, Anatoly wrote: On 31-Aug-18 1:50 PM, Alejandro Lucero wrote: A device can suffer addressing limitations. This functions checks memsegs ha

Re: [dpdk-dev] [PATCH] ethdev: add action to swap source and destination MAC to flow API

2018-10-04 Thread Ferruh Yigit
On 9/24/2018 9:32 AM, Andrew Rybchenko wrote: > On 9/24/18 11:29 AM, wrote: >> This action is useful for offloading loopback mode, where the hardware >> will swap source and destination MAC addresses in the outermost Ethernet >> header before looping back the packet. This action can be used in >> c

Re: [dpdk-dev] [PATCH 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-10-04 Thread Ferruh Yigit
On 10/4/2018 2:55 PM, Ori Kam wrote: > > >> -Original Message- >> From: dev On Behalf Of Rahul Lakkireddy >> Sent: Monday, September 24, 2018 11:28 AM >> To: dev@dpdk.org >> Cc: indra...@chelsio.com; nirran...@chelsio.com >> Subject: [dpdk-dev] [PATCH 2/3] ethdev: add flow api actions to

Re: [dpdk-dev] [PATCH v3] ethdev: get rxq interrupt fd

2018-10-04 Thread Ferruh Yigit
On 10/2/2018 11:48 AM, Ferruh Yigit wrote: > On 9/29/2018 3:12 AM, Xiaoyun Li wrote: >> Some users want to use their own epoll instances to control both >> DPDK rxq interrupt fds and their own other fds. So added a function >> to get rxq interrupt fd based on port id and queue id. >> >> Signed-off-

Re: [dpdk-dev] [PATCH v2] config: disable RTE_NEXT_ABI by default

2018-10-04 Thread Ferruh Yigit
On 10/4/2018 4:10 PM, Thomas Monjalon wrote: > 04/10/2018 17:48, Ferruh Yigit: >> Enabling RTE_NEXT_ABI means to enable APIs that break the ABI for >> the current release and these APIs are targeted for further release. > > It seems nobody is using it in last releases. > >> RTE_NEXT_ABI shouldn't

Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede

2018-10-04 Thread Bruce Richardson
On Thu, Oct 04, 2018 at 06:10:12PM +0300, Ilya Maximets wrote: > On 04.10.2018 17:51, Ferruh Yigit wrote: > > On 10/4/2018 2:18 PM, Ilya Maximets wrote: > >> This functionality was missed while adding new drivers to > >> the meson build. > > > > Is there any call from base code to experimental API

[dpdk-dev] [PATCH] devtools/check-symbol-changes.sh: awk script issue

2018-10-04 Thread Liang Ma
There is a issue inside check-symbol-changes.sh awk script. When the script try to parse the section name from patch, The script put char "+" into the section name. Signed-off-by: Liang Ma --- devtools/check-symbol-change.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/de

Re: [dpdk-dev] [PATCH v2 00/10] introduce telemetry library

2018-10-04 Thread Gaëtan Rivet
Hi Harry, On Thu, Oct 04, 2018 at 01:25:51PM +, Van Haaren, Harry wrote: > > -Original Message- > > From: Van Haaren, Harry > > Sent: Thursday, October 4, 2018 2:00 PM > > To: Laatz, Kevin ; dev@dpdk.org > > Cc: step...@networkplumber.org; gaetan.ri...@6wind.com; > > shreyansh.j...@nxp

Re: [dpdk-dev] [PATCH v2] config: disable RTE_NEXT_ABI by default

2018-10-04 Thread Thomas Monjalon
04/10/2018 17:48, Ferruh Yigit: > Enabling RTE_NEXT_ABI means to enable APIs that break the ABI for > the current release and these APIs are targeted for further release. It seems nobody is using it in last releases. > RTE_NEXT_ABI shouldn't be enabled by default. The reason for having it enable

Re: [dpdk-dev] [PATCH v3 05/19] vhost: fix error handling when mem table gets updated

2018-10-04 Thread Ilya Maximets
On 04.10.2018 18:06, Maxime Coquelin wrote: > > > On 10/04/2018 04:59 PM, Ilya Maximets wrote: >> On 04.10.2018 11:13, Maxime Coquelin wrote: >>> When the memory table gets updated, the rings addresses need >>> to be translated again. If it fails, we need to exit cleanly >>> by unmapping memory r

Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 checksum for csum engine

2018-10-04 Thread Iremonger, Bernard
Hi Jerin, > > > Subject: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 > > > checksum for csum engine > > > > > > Collect and prints the statistics for PKT_RX_EL4_CKSUM_BAD errors. > > > > > > Signed-off-by: Jerin Jacob > > > Reviewed-by: Andrew Rybchenko > > > --- > > > > > > >

Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede

2018-10-04 Thread Ilya Maximets
On 04.10.2018 17:51, Ferruh Yigit wrote: > On 10/4/2018 2:18 PM, Ilya Maximets wrote: >> This functionality was missed while adding new drivers to >> the meson build. > > Is there any call from base code to experimental APIs? What do you think > adding > this when we need it, since I have feeling

Re: [dpdk-dev] [PATCH v3 05/19] vhost: fix error handling when mem table gets updated

2018-10-04 Thread Maxime Coquelin
On 10/04/2018 04:59 PM, Ilya Maximets wrote: On 04.10.2018 11:13, Maxime Coquelin wrote: When the memory table gets updated, the rings addresses need to be translated again. If it fails, we need to exit cleanly by unmapping memory regions. Fixes: d5022533c20a ("vhost: retranslate vring addr

Re: [dpdk-dev] [PATCH v3 06/19] vhost: define postcopy protocol flag

2018-10-04 Thread Ilya Maximets
On 04.10.2018 11:13, Maxime Coquelin wrote: > Signed-off-by: Dr. David Alan Gilbert > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/rte_vhost.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h > index b02673d4a..b

Re: [dpdk-dev] [PATCH v3 05/19] vhost: fix error handling when mem table gets updated

2018-10-04 Thread Ilya Maximets
On 04.10.2018 11:13, Maxime Coquelin wrote: > When the memory table gets updated, the rings addresses need > to be translated again. If it fails, we need to exit cleanly > by unmapping memory regions. > > Fixes: d5022533c20a ("vhost: retranslate vring addr when memory table > changes") > Cc: sta.

Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede

2018-10-04 Thread Ferruh Yigit
On 10/4/2018 2:18 PM, Ilya Maximets wrote: > This functionality was missed while adding new drivers to > the meson build. Is there any call from base code to experimental APIs? What do you think adding this when we need it, since I have feeling that this may not be needed. > > Fixes: 1d75caf8147

Re: [dpdk-dev] [PATCH] config: disable RTE_NEXT_ABI by default

2018-10-04 Thread Luca Boccassi
On Thu, 2018-10-04 at 16:43 +0100, Ferruh Yigit wrote: > Enabling RTE_NEXT_ABI means to enable APIs that break the ABI for > the current release and these APIs are targetted for further release. > > RTE_NEXT_ABI shouldn't be enabled by default. > > Signed-off-by: Ferruh Yigit > --- > Cc: Neil Ho

[dpdk-dev] [PATCH v2] config: disable RTE_NEXT_ABI by default

2018-10-04 Thread Ferruh Yigit
Enabling RTE_NEXT_ABI means to enable APIs that break the ABI for the current release and these APIs are targeted for further release. RTE_NEXT_ABI shouldn't be enabled by default. Signed-off-by: Ferruh Yigit --- Cc: Neil Horman Cc: Thomas Monjalon Cc: Luca Boccassi Cc: Christian Ehrhardt v

Re: [dpdk-dev] [PATCH v3 03/19] vhost: clarify reply-ack in case a reply was already sent

2018-10-04 Thread Ilya Maximets
On 04.10.2018 11:13, Maxime Coquelin wrote: > For messages that require a reply, a second ack should not be > sent when reply-ack protocol feature is negotiated, even if > the corresponding flag is set in the message. > > The code is compliant with the spec but it isn't clear it is, > so this patc

Re: [dpdk-dev] [PATCH v3 04/19] vhost: fix payload size of reply

2018-10-04 Thread Ilya Maximets
On 04.10.2018 11:13, Maxime Coquelin wrote: > QEMU doesn't expect any payload for the reply of > VHOST_USER_SET_LOG_BASE request, so don't send any. > Note that the Vhost-user specification isn't clear about > it and would need to be fixed. > > Fixes: 54f9e32305d4 ("vhost: handle dirty pages loggi

Re: [dpdk-dev] [PATCH v3 02/19] vhost: fix return code of messages requiring replies

2018-10-04 Thread Ilya Maximets
On 04.10.2018 11:13, Maxime Coquelin wrote: > VHOST_USER_GET_PROTOCOL_FEATURES, VHOST_USER_GET_VRING_BASE > and VHOST_USER_SET_LOG_BASE require replies, so their handlers > should return VH_RESULT_REPLY, not VH_RESULT_OK. > > Fixes: 0bff510b5ea6 ("vhost: unify message handling function signature")

Re: [dpdk-dev] [PATCH v3 01/19] vhost: fix messages error checks

2018-10-04 Thread Ilya Maximets
On 04.10.2018 11:13, Maxime Coquelin wrote: > Return of message handling has now changed to an enum that can > take non-negative value that is not zero in case a reply is > needed. But the code checking the variable afterwards has not > been updated, leading to success messages handling being > tre

Re: [dpdk-dev] [PATCH v3 1/3] app/testpmd: move dumping packets to a separate function

2018-10-04 Thread Iremonger, Bernard
Hi Raslan, > -Original Message- > From: Raslan Darawsheh [mailto:rasl...@mellanox.com] > Sent: Wednesday, October 3, 2018 4:16 PM > To: Wu, Jingjing > Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf > Shuler ; Raslan Darawsheh > ; Xueming(Steven) Li ; > Ori Kam ; jerin.ja...@caviumnetworks.com

[dpdk-dev] [PATCH] config: disable RTE_NEXT_ABI by default

2018-10-04 Thread Ferruh Yigit
Enabling RTE_NEXT_ABI means to enable APIs that break the ABI for the current release and these APIs are targetted for further release. RTE_NEXT_ABI shouldn't be enabled by default. Signed-off-by: Ferruh Yigit --- Cc: Neil Horman Cc: Thomas Monjalon Cc: Luca Boccassi Cc: Christian Ehrhardt -

[dpdk-dev] [PATCH v14 7/7] app/testpmd: use hotplug failure handler

2018-10-04 Thread Jeff Guo
This patch use testpmd for example, to show how an app smoothly handle failure when device be hot-unplug. Except that app should enabled the device event monitor and register the hotplug event’s callback, it also need enable hotplug handle mechanism before running. Once app detect the removal event

[dpdk-dev] [PATCH v14 5/7] bus: add helper to handle sigbus

2018-10-04 Thread Jeff Guo
This patch aims to add a helper to iterate over all buses to find the relevant bus to handle the sigbus error. Signed-off-by: Jeff Guo Acked-by: Shaopeng He Acked-by: Konstantin Ananyev --- v14->v13: no change. --- lib/librte_eal/common/eal_common_bus.c | 43 ++

[dpdk-dev] [PATCH v14 6/7] eal: add failure handle mechanism for hot-unplug

2018-10-04 Thread Jeff Guo
The mechanism can initially register the sigbus handler after the device event monitor is enabled. When a sigbus event is captured, it will check the failure address and accordingly handle the memory failure of the corresponding device by invoke the hot-unplug handler. It could prevent the applicat

[dpdk-dev] [PATCH v14 2/7] bus/pci: implement hot-unplug handler ops

2018-10-04 Thread Jeff Guo
This patch implements the ops to handle hot-unplug on the PCI bus. For UIO PCI, it could avoids BARs read/write errors by creating a new dummy memory to remap the memory where the failure is. For VFIO or other kernel driver, it could specific implement function to handle hot-unplug case by case. S

[dpdk-dev] [PATCH v14 1/7] bus: add hot-unplug handler

2018-10-04 Thread Jeff Guo
A hot-unplug failure and app crash can be caused, when a device is hot-unplugged but the application still try to access the device by reading or writing from the BARs, which is already invalid but still not timely be unmap or released. This patch introduces bus ops to handle hot-unplug failures.

[dpdk-dev] [PATCH v14 4/7] bus/pci: implement sigbus handler ops

2018-10-04 Thread Jeff Guo
This patch implements the ops for the PCI bus sigbus handler. It finds the PCI device that is being hot-unplugged and calls the relevant ops of the hot-unplug handler to handle the hot-unplug failure of the device. Signed-off-by: Jeff Guo Acked-by: Shaopeng He Acked-by: Konstantin Ananyev --- v

[dpdk-dev] [PATCH v14 0/7] hot-unplug failure handle mechanism

2018-10-04 Thread Jeff Guo
Hotplug is an important feature for use-cases like the datacenter device's fail-safe and for SRIOV Live Migration in SDN/NFV. It could bring higher flexibility and continuality to networking services in multiple use-cases in the industry. So let's see how DPDK can help users implement hotplug solut

[dpdk-dev] [PATCH v14 3/7] bus: add sigbus handler

2018-10-04 Thread Jeff Guo
When a device is hot-unplugged, a sigbus error will occur of the datapath can still read/write to the device. A handler is required here to capture the sigbus signal and handle it appropriately. This patch introduces a bus ops to handle sigbus errors. Each bus can implement its own case-dependent

Re: [dpdk-dev] [PATCH v2 1/2] event/dpaa: remove duplicate log macros

2018-10-04 Thread Jerin Jacob
-Original Message- > Date: Tue, 25 Sep 2018 12:32:34 +0530 > From: Hemant Agrawal > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com > Subject: [PATCH v2 1/2] event/dpaa: remove duplicate log macros > X-Mailer: git-send-email 2.7.4 > > align and cleanup the debug log prints > > Sign

[dpdk-dev] [PATCH v3 2/2] drivers/net: use sleep delay by default for intel NICs

2018-10-04 Thread Ilya Maximets
NICs uses different delays up to a second during their configuration. It makes no sense to busy-wait so long wasting CPU cycles and preventing any other threads to execute on the same CPU core. These busy polling are the rudiments that came from the kernel drivers where you can not sleep in interru

[dpdk-dev] [PATCH v3 1/2] eal: add nanosleep based delay function

2018-10-04 Thread Ilya Maximets
Add a new rte_delay_us_sleep() function that uses nanosleep(). This function can be used by applications to not implement their own nanosleep() based callback and by internal DPDK code if CPU non-blocking delay needed. Signed-off-by: Ilya Maximets --- lib/librte_eal/common/eal_common_timer.c

[dpdk-dev] [PATCH v3 0/2] CPU non-blocking delay

2018-10-04 Thread Ilya Maximets
For meson build without deprecation warnings following patch should be applied first: http://patches.dpdk.org/patch/46064/ Version 3: * Minor rebase on top of current master. Version 2: * Added comment for EINTR handling for nanosleep. [Stephen Hemminger] Ilya Maximets (2):

Re: [dpdk-dev] [PATCH v3 0/7] ethdev: add flow API object converter

2018-10-04 Thread Ferruh Yigit
On 10/3/2018 9:31 PM, Thomas Monjalon wrote: > 31/08/2018 13:32, Nélio Laranjeiro: >> On Fri, Aug 31, 2018 at 11:00:57AM +0200, Adrien Mazarguil wrote: >>> This is a follow up to the "Flow API helpers enhancements" series submitted >>> almost a year ago [1]. The new title is due to the reduced scop

Re: [dpdk-dev] [PATCH v2 3/3] eal: allow probing a device again

2018-10-04 Thread Thomas Monjalon
04/10/2018 11:44, Doherty, Declan: > On 28/09/2018 5:40 PM, Thomas Monjalon wrote: > > In the devargs syntax for device representors, it is possible to add > > several devices at once: -w dbdf,representor=[0-3] > > It will become a more frequent case when introducing wildcards > > and ranges in the

Re: [dpdk-dev] [PATCH v3 7/7] ethdev: deprecate rte_flow_copy function

2018-10-04 Thread Ferruh Yigit
On 8/31/2018 10:01 AM, Adrien Mazarguil wrote: > No users left for this function, time to deprecate it. > > Signed-off-by: Adrien Mazarguil > Cc: Thomas Monjalon > Cc: Ferruh Yigit > Cc: Andrew Rybchenko > Cc: Gaetan Rivet > -- > v3 changes: > > - Removed deprecation notice (finally got Ferr

Re: [dpdk-dev] [PATCH v2] event/dsw: fix icc build

2018-10-04 Thread Jerin Jacob
-Original Message- > Date: Thu, 4 Oct 2018 13:21:13 +0200 > From: Mattias Rönnblom > To: Jerin Jacob > CC: Ferruh Yigit , dev@dpdk.org, Mattias Rönnblom > > Subject: [PATCH v2] event/dsw: fix icc build > X-Mailer: git-send-email 2.17.1 > > Make the -Wno-format-nonliteral flag condition

Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 checksum for csum engine

2018-10-04 Thread Jerin Jacob
-Original Message- > Date: Thu, 4 Oct 2018 13:45:42 + > From: "Iremonger, Bernard" > To: Jerin Jacob , "Lu, Wenzhuo" > , "Wu, Jingjing" > CC: "dev@dpdk.org" , "shah...@mellanox.com" > > Subject: RE: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 > checksum for csum en

Re: [dpdk-dev] [PATCH v2 01/10] telemetry: initial telemetry infrastructure

2018-10-04 Thread Gaëtan Rivet
Hi, On Wed, Oct 03, 2018 at 06:36:03PM +0100, Kevin Laatz wrote: > From: Ciara Power > > This patch adds the infrastructure and initial code for the telemetry > library. > > The telemetry init is registered with eal_init(). We can then check to see > if --telemetry was passed as an eal flag. If

[dpdk-dev] [PATCH v4 6/6] net/vdev_netvsc: disable vdev netvsc build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled vdev_netvsc build in FreeBSD because it is not supported. Added changes to enable vdev_netvsc build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan Acked-by: Stephen Hemmminger --- drivers/net/vdev_netvsc/meson.build | 3 +++ 1 file changed, 3 inserti

[dpdk-dev] [PATCH v4 0/6] fix for meson builds in freebsd

2018-10-04 Thread Agalya Babu RadhaKrishnan
Compilation issues were observed in FreeBSD when built via meson. VFIO flags are enabled/disabled based on linux/freebsd. Changes are done in meson.build files to ensure the build of drivers are enabled/disabled based on platform. 1/6: set/unset of vfio flags based on platforms 2/6: updated net/nf

[dpdk-dev] [PATCH v4 4/6] net/softnic: disable softnic build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled softnic build in FreeBSD because it is not supported Added changes to enable softnic build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan Acked-by: Jasvinder Singh --- drivers/net/softnic/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --g

[dpdk-dev] [PATCH v4 1/6] build: fix for FREEBSD build via meson

2018-10-04 Thread Agalya Babu RadhaKrishnan
FreeBSD compilation was failing through meson build. RTE_EAL_VFIO is not supported in FreeBSD. But RTE_EAL_VFIO was enabled for both linux and freebsd. So RTE_EAL_VFIO is removed from config/rte_config.h and based on the platform RTE_EAL_VFIO flag is enabled/disabled appropriately. Fixes: 844514c7

[dpdk-dev] [PATCH v4 2/6] net/nfp: disable nfp build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled nfp build in FreeBSD because it is not supported Added changes to enable NFP build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/nfp/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/nfp/meson.build b/driv

[dpdk-dev] [PATCH v4 5/6] net/tap: disable tap build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled tap build in FreeBSD because it is not supported Added changes to enable tap build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan Acked-by: Keith Wiles --- drivers/net/tap/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net

[dpdk-dev] [PATCH v4 3/6] net/avp: disable avp build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled avp build in FreeBSD because it is not supported. Added changes to enable avp build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan Acked-by: Allain Legacy --- drivers/net/avp/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/

Re: [dpdk-dev] [PATCH v7 0/8] implement packed virtqueues

2018-10-04 Thread Maxime Coquelin
Hi Jens, On 10/03/2018 03:11 PM, Jens Freimann wrote: To support out-of-order processing I used the vq_desc_extra struct to add a .next field and use it as a list for managing descriptors. This seemed to add less complexity to the code than adding a new data structure to use as a list for packed

Re: [dpdk-dev] [PATCH v13 7/7] app/testpmd: use hotplug failure handler

2018-10-04 Thread Jeff Guo
thanks for your kindly review. On 10/4/2018 6:31 PM, Iremonger, Bernard wrote: Hi Jeff, -Original Message- From: Guo, Jia Sent: Thursday, October 4, 2018 7:31 AM To: step...@networkplumber.org; Richardson, Bruce ; Yigit, Ferruh ; Ananyev, Konstantin ; gaetan.ri...@6wind.com; Wu, Jingji

Re: [dpdk-dev] [PATCH 2/3] ethdev: add flow api actions to modify TCP/UDP port numbers

2018-10-04 Thread Ori Kam
> -Original Message- > From: dev On Behalf Of Rahul Lakkireddy > Sent: Monday, September 24, 2018 11:28 AM > To: dev@dpdk.org > Cc: indra...@chelsio.com; nirran...@chelsio.com > Subject: [dpdk-dev] [PATCH 2/3] ethdev: add flow api actions to modify > TCP/UDP port numbers > > Add action

Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 checksum for csum engine

2018-10-04 Thread Iremonger, Bernard
Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, October 3, 2018 7:17 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; shah...@mellanox.com; Jerin Jacob > > Subject: [dpdk-dev] [PATCH v3 4/4] app

[dpdk-dev] [PATCH v3 6/6] net/vdev_netvsc: disable vdev netvsc build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled vdev_netvsc build in FreeBSD because it is not supported. Added changes to enable vdev_netvsc build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/vdev_netvsc/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/n

Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede

2018-10-04 Thread Bruce Richardson
On Thu, Oct 04, 2018 at 04:18:35PM +0300, Ilya Maximets wrote: > This functionality was missed while adding new drivers to > the meson build. > > Fixes: 1d75caf81474 ("net/avf: add meson support") > Fixes: 30d3d0168301 ("net/qede: add in meson build") > > Signed-off-by: Ilya Maximets > --- Acked

Re: [dpdk-dev] [PATCH v2 3/5] bus/pci: use IOVAs check when setting IOVA mode

2018-10-04 Thread Alejandro Lucero
On Wed, Oct 3, 2018 at 1:56 PM Burakov, Anatoly wrote: > On 31-Aug-18 1:50 PM, Alejandro Lucero wrote: > > Although VT-d emulation currently only supports 39 bits, it could > > be iovas being within that supported range. This patch allows > > IOVA mode in such a case. > > > > Indeed, memory initi

[dpdk-dev] [PATCH v3 1/6] build: fix for FREEBSD build via meson

2018-10-04 Thread Agalya Babu RadhaKrishnan
FreeBSD compilation was failing through meson build. RTE_EAL_VFIO is not supported in FreeBSD. But RTE_EAL_VFIO was enabled for both linux and freebsd. So RTE_EAL_VFIO is removed from config/rte_config.h and based on the platform RTE_EAL_VFIO flag is enabled/disabled appropriately. Fixes: 844514c7

[dpdk-dev] [PATCH v3 4/6] net/softnic: disable softnic build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled softnic build in FreeBSD because it is not supported Added changes to enable softnic build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/softnic/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/softnic/me

[dpdk-dev] [PATCH v3 2/6] net/nfp: disable nfp build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled nfp build in FreeBSD because it is not supported Added changes to enable NFP build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/nfp/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/nfp/meson.build b/driv

[dpdk-dev] [PATCH v3 5/6] net/tap: disable tap build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled tap build in FreeBSD because it is not supported Added changes to enable tap build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/tap/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/tap/meson.build b/driv

[dpdk-dev] [PATCH v3 3/6] net/avp: disable avp build in FREEBSD

2018-10-04 Thread Agalya Babu RadhaKrishnan
Disabled avp build in FreeBSD because it is not supported. Added changes to enable avp build if it is Linux OS and disable in FreeBSD. Signed-off-by: Agalya Babu RadhaKrishnan --- drivers/net/avp/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/avp/meson.build b/dri

[dpdk-dev] [PATCH v3 0/6] fix for meson builds in freebsd

2018-10-04 Thread Agalya Babu RadhaKrishnan
Compilation issues were observed in FreeBSD when built via meson. VFIO flags are enabled/disabled based on linux/freebsd. Changes are done in meson.build files to ensure the build of drivers are enabled/disabled based on platform. 1/6: set/unset of vfio flags based on platforms 2/6: updated net/nf

[dpdk-dev] [PATCH v3 4/8] examples: add TDES parser and enablement for test types

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for TDES parser, to allow the application to parser the TDES request files and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fip

[dpdk-dev] [PATCH v3 6/8] examples: add cmac parser and enablement for test types

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for CMAC parser, to allow the application to parser the cmac request files and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fip

[dpdk-dev] [PATCH v3 5/8] examples: add gcm parser

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for GCM parser, to allow the application to parser the GCM request file and to validate all tests supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fips_parse_

[dpdk-dev] [PATCH v3 2/8] examples: add aes parser and enablement for test types

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for AES-CBC parser, to allow the application to parser the aes request file and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fi

[dpdk-dev] [PATCH v3 7/8] examples: add ccm parser and enablement for test types

2018-10-04 Thread Fan Zhang
From: Marko Kovacevic Added enablement for CCM parser, to allow the application to parser the ccm request files and to validate all test types supported. Signed-off-by: Marko Kovacevic Signed-off-by: Fan Zhang --- examples/cryptodev_fips_validate/Makefile | 1 + .../cryptodev_fips_

  1   2   >