Re: [dpdk-dev] [PATCH] net/i40e: fix 25G AOC and ACC cable detection on XXV710

2018-09-26 Thread Zhang, Qi Z
> -Original Message- > From: Damjan Marion [mailto:damar...@cisco.com] > Sent: Tuesday, September 25, 2018 4:17 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Damjan Marion ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix 25G AOC and ACC cable detection on XXV710 > > Fixes:

[dpdk-dev] [PATCH] test: reduce test time for hash multiwriter ut

2018-09-26 Thread Jananee Parthasarathy
From: Naga Suresh Somarowthu Reduced test duration for hash_multiwriter_autotest. Number of entries and total insertions are reduced such that the duration is less than 10 seconds. Signed-off-by: Naga Suresh Somarowthu --- test/test/test_hash_multiwriter.c | 4 ++-- 1 file changed, 2 insertion

[dpdk-dev] [PATCH] test: reduce test time for hash multiwriter ut

2018-09-26 Thread Naga Suresh Somarowthu
Reduced test duration for hash_multiwriter_autotest. Number of entries and total insertions are reduced such that the duration is less than 10 seconds. Signed-off-by: Naga Suresh Somarowthu --- test/test/test_hash_multiwriter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --gi

[dpdk-dev] [PATCH v2 2/2] test/event: add adapter tests to meson build

2018-09-26 Thread Nikhil Rao
Add tests for event eth Rx, crypto and timer adapters to meson build Cc: Abhinandan Gujjar Cc: Erik G. Carrillo Signed-off-by: Nikhil Rao --- test/test/meson.build | 7 +++ 1 file changed, 7 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index b1dd6ec..1b2e8b7 1

[dpdk-dev] [PATCH v2 1/2] test: fix event timer compiler warning

2018-09-26 Thread Nikhil Rao
Limit the number of objects passed to rte_mempool_put_bulk() to the size of the object table. This fix eliminates a compiler warning (array-bounds) triggered when the march command line parameter to gcc is set to nehalem. Fixes: d1f3385d0076 ("test: add event timer adapter auto-test") Cc: erik.g.c

Re: [dpdk-dev] [PATCH v2 7/7] hash: use partial-key hashing

2018-09-26 Thread Honnappa Nagarahalli
> -Original Message- > From: Yipeng Wang > Sent: Friday, September 21, 2018 12:18 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; yipeng1.w...@intel.com; mic...@digirati.com.br; > Honnappa Nagarahalli > Subject: [PATCH v2 7/7] hash: use partial-key hashing > > This commit chang

Re: [dpdk-dev] [PATCH v2 6/7] test/hash: implement extendable bucket hash test

2018-09-26 Thread Honnappa Nagarahalli
> -Original Message- > From: Yipeng Wang > Sent: Friday, September 21, 2018 12:18 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; yipeng1.w...@intel.com; mic...@digirati.com.br; > Honnappa Nagarahalli > Subject: [PATCH v2 6/7] test/hash: implement extendable bucket hash test >

Re: [dpdk-dev] [PATCH v2 0/7] hash: add extendable bucket and partial key hashing

2018-09-26 Thread Honnappa Nagarahalli
> -Original Message- > From: Yipeng Wang > Sent: Friday, September 21, 2018 12:17 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; yipeng1.w...@intel.com; mic...@digirati.com.br; > Honnappa Nagarahalli > Subject: [PATCH v2 0/7] hash: add extendable bucket and partial key hashing

Re: [dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature

2018-09-26 Thread Honnappa Nagarahalli
> -Original Message- > From: Yipeng Wang > Sent: Friday, September 21, 2018 12:18 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; yipeng1.w...@intel.com; mic...@digirati.com.br; > Honnappa Nagarahalli > Subject: [PATCH v2 5/7] hash: add extendable bucket feature > > In use case

Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

2018-09-26 Thread Honnappa Nagarahalli
> -Original Message- > From: Yipeng Wang > Sent: Friday, September 21, 2018 12:17 PM > To: bruce.richard...@intel.com > Cc: dev@dpdk.org; yipeng1.w...@intel.com; mic...@digirati.com.br; > Honnappa Nagarahalli > Subject: [PATCH v2 1/7] test/hash: fix bucket size in hash perf test > > T

Re: [dpdk-dev] [PATCH v2 3/7] test/hash: fix rw test with non-consecutive cores

2018-09-26 Thread Wang, Yipeng1
I added another commit for this. Please test. Thanks! >-Original Message- > >When testing this patch, I see that the read-write autotests are not >currently in the meson.build file for the test binary. I think this >patchset should include this fix too, as a separate patch.

Re: [dpdk-dev] [PATCH v2 0/7] hash: add extendable bucket and partial key hashing

2018-09-26 Thread Wang, Yipeng1
Done! Now they are two separate patch sets. Thanks Yipeng >-Original Message- >From: Richardson, Bruce >I'd suggest splitting this set into two. The first 4 patches are easy to >review and should be quickly merged (I hope :-)), allowing us to focus more on >the bigger patches adding the k

Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

2018-09-26 Thread Wang, Yipeng1
Hi Bruce, In the test, the bucket size and number of buckets are used to map to the underneath rte_hash structure. They are used to test performance of two scenarios: keys in primary buckets only and keys in both primary and secondary buckets. Although there is no functional issue with bucket siz

[dpdk-dev] [PATCH v3 3/3] hash: use partial-key hashing

2018-09-26 Thread Yipeng Wang
This commit changes the hashing mechanism to "partial-key hashing" to calculate bucket index and signature of key. This is proposed in Bin Fan, et al's paper "MemC3: Compact and Concurrent MemCache with Dumber Caching and Smarter Hashing". Bascially the idea is to use "xor" to derive alternative

[dpdk-dev] [PATCH v3 2/3] test/hash: implement extendable bucket hash test

2018-09-26 Thread Yipeng Wang
This commit changes the current rte_hash unit test to test the extendable table feature and performance. Signed-off-by: Yipeng Wang --- test/test/test_hash.c | 151 +++-- test/test/test_hash_perf.c | 114 +- 2 files cha

[dpdk-dev] [PATCH v3 1/3] hash: add extendable bucket feature

2018-09-26 Thread Yipeng Wang
In use cases that hash table capacity needs to be guaranteed, the extendable bucket feature can be used to contain extra keys in linked lists when conflict happens. This is similar concept to the extendable bucket hash table in packet framework. This commit adds the extendable bucket feature. User

[dpdk-dev] [PATCH v3 0/3] hash: add extendable bucket and partial key hashing

2018-09-26 Thread Yipeng Wang
This patch set made two major optimizations over the current rte_hash library. First, it adds Extendable Bucket Table feature: a new structure that can accommodate keys that failed to get inserted into the main hash table due to the unlikely event of excessive hash collisions. The hash table bucke

[dpdk-dev] [PATCH v2] net/i40e: remove keeping CRC configuration for VF

2018-09-26 Thread Beilei Xing
Remove keeping CRC configuration since it's not supported by i40e VF. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev_vf.c | 16 1 file changed, 16 deletions(-) v2 changes: - Remove the whole branch since offload has been checked in rte_eth_dev_configure. diff --

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-09-26 Thread Hideyuki Yamashita
Dear Thomas, Thanks for your answer. It took me a little time to digest answer. Please see inline. > 21/09/2018 09:19, Hideyuki Yamashita: > > Dear Gaetan and Thomas, > > > > Thanks for your answer. > > Please see inline. > > > > > 20/09/2018 11:09, Ga?an Rivet: > > > > On Thu, Sep 20, 2018 a

[dpdk-dev] [PATCH v3 5/6] examples/kni: add log msgs to show and clear stats

2018-09-26 Thread Dan Gora
Add logging messages showing the commands necessary for the user to have the application display and zero the statistics. Signed-off-by: Dan Gora --- examples/kni/main.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/examples/kni/main.c b/examples/kni/main.

[dpdk-dev] [PATCH v3 2/6] kni: add link status test

2018-09-26 Thread Dan Gora
Test changing the link, speed, duplex, etc. status of the KNI interface with rte_kni_update_link(). Signed-off-by: Dan Gora --- test/test/test_kni.c | 131 +++ 1 file changed, 131 insertions(+) diff --git a/test/test/test_kni.c b/test/test/test_kni.c inde

[dpdk-dev] [PATCH v3 6/6] examples/kni: improve zeroing statistics

2018-09-26 Thread Dan Gora
The worker threads incrementing the rx/tx_packets race with the signal handler from the main thread zeroing the entire statistics structure. This can cause the statistics to fail to be zeroed, even when there is no traffic on those interfaces. Improve zeroing the statistics by only incrementing rx

[dpdk-dev] [PATCH v3 3/6] kni: set default carrier state to 'off'

2018-09-26 Thread Dan Gora
Set the carrier state to 'off' when the interface is instantiated or when it is marked 'up' or 'down'. This is necessary to set the interface to a known operational state until the carrier state is changed with rte_kni_update_link(). Signed-off-by: Dan Gora --- kernel/linux/kni/kni_misc.c | 2 +

[dpdk-dev] [PATCH v3 4/6] examples/kni: monitor and update link status continually

2018-09-26 Thread Dan Gora
Update KNI example to continuously monitor the Ethernet link status of the physical link and update the link status of the corresponding interfaces with rte_kni_update_link(). Signed-off-by: Dan Gora --- examples/kni/Makefile | 2 ++ examples/kni/main.c | 73 +-

[dpdk-dev] [PATCH v3 1/6] kni: add API to set link status on kernel interface

2018-09-26 Thread Dan Gora
Add a new API function to KNI, rte_kni_update_link() to allow DPDK applications to update the link status for KNI network interfaces in the linux kernel. Signed-off-by: Dan Gora --- lib/librte_kni/rte_kni.c | 57 ++ lib/librte_kni/rte_kni.h | 18 ++

[dpdk-dev] [PATCH v3 0/6] kni: add API to set link status on kernel interface

2018-09-26 Thread Dan Gora
Hi All, Attached is version 3 of a patchset to add a new API function to set the link status on kernel interfaces created with the KNI kernel module. v3 * Use separate function to test rte_kni_update_link() in 'test' app. * Separate changes to 'test' app into separate patch to facilitate

[dpdk-dev] [PATCH] kni: implement header_ops parse method

2018-09-26 Thread Igor Ryzhov
Signed-off-by: Igor Ryzhov --- kernel/linux/kni/kni_net.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c index 7fcfa106c..128a5477c 100644 --- a/kernel/linux/kni/kni_net.c +++ b/kernel/linux/kni/kni_net.c @@ -678,6 +678,

[dpdk-dev] [PATCH v2 2/4] devargs: simplify parameters of removal function

2018-09-26 Thread Thomas Monjalon
The function rte_devargs_remove(), which is intended to be internal, can take a devargs structure as argument. The matching is still using string comparison of bus name and device name. It is simpler and may allow a different devargs matching in future. Signed-off-by: Thomas Monjalon --- drivers

[dpdk-dev] [PATCH v2 3/4] eal: remove experimental flag of hotplug functions

2018-09-26 Thread Thomas Monjalon
These functions are quite old and are the only available replacement for the deprecated attach/detach functions. Note: some new functions may (again) replace these hotplug functions, in future, with better parameters. Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/eal_common_dev.c |

[dpdk-dev] [PATCH v2 4/4] eal: simplify parameters of hotplug functions

2018-09-26 Thread Thomas Monjalon
All information about a device to probe can be grouped in a common string, which is what we usually call devargs. An application should not have to parse this string before calling the EAL probe function. And the syntax could evolve to be more complex and support matching multiple devices in one st

[dpdk-dev] [PATCH v2 1/4] devargs: remove deprecated functions

2018-09-26 Thread Thomas Monjalon
rte_eal_parse_devargs_str() does not support parsing the bus name at the start of devargs. So it has been renamed and deprecated. rte_eal_devargs_add(), rte_eal_devargs_type_count() and rte_eal_devargs_dump() were declared deprecated and had their implementation body renamed. All these functions

[dpdk-dev] [PATCH v2 0/4] eal: simplify devargs and hotplug functions

2018-09-26 Thread Thomas Monjalon
This is a follow-up of an idea presented at Dublin during the "hotplug talk". Instead of changing the existing hotplug functions, as in the RFC, some new experimental functions are added. The old functions lose their experimental status in order to provide a non-experimental replacement for deprec

[dpdk-dev] [PATCH v2 3/3] ethdev: remove vxlan and nvgre encapsulation commands

2018-09-26 Thread Ori Kam
This patch removes the VXLAN and NVGRE encapsulation commands. Those commands are subset of the TUNNEL_ENCAP command so there is no need to keep both versions. Signed-off-by: Ori Kam --- doc/guides/prog_guide/rte_flow.rst | 107 - lib/librte_ethdev/rte_flow.h

[dpdk-dev] [PATCH v2 2/3] app/testpmd: convert testpmd encap commands to new API

2018-09-26 Thread Ori Kam
Currently there are 2 encapsulation commands in testpmd one for VXLAN and one for NVGRE, both of those commands are using the old rte encap command. This commit update the commands to work with the new tunnel encap actions. The reason that we have different encapsulation commands, one for VXLAN a

[dpdk-dev] [PATCH v2 0/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-09-26 Thread Ori Kam
This series implement the generic L2/L3 tunnel encapsulation actions and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet

[dpdk-dev] [PATCH v2 1/3] ethdev: add generic L2/L3 tunnel encapsulation actions

2018-09-26 Thread Ori Kam
Currenlty the encap/decap actions only support encapsulation of VXLAN and NVGRE L2 packets (L2 encapsulation is where the inner packet has a valid Ethernet header, while L3 encapsulation is where the inner packet doesn't have the Ethernet header). In addtion the parameter to to the encap action is

[dpdk-dev] [PATCH v3 5/5] hash: fix unused define

2018-09-26 Thread Yipeng Wang
Since the depth-first search of cuckoo path is removed, we do not need the macro anymore which specifies the depth of the cuckoo search. Fixes: f2e3001b53ec ("hash: support read/write concurrency") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- lib/librte_hash/rt

[dpdk-dev] [PATCH v3 4/5] test/hash: fix missing file in meson build file

2018-09-26 Thread Yipeng Wang
The test_hash_readwrite.c was not in the meson.build file. This commit adds the missing test into the file. Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang --- test/test/meson.build | 1 + 1 file changed, 1 insertion(+) diff

[dpdk-dev] [PATCH v3 2/5] test/hash: more accurate hash perf test output

2018-09-26 Thread Yipeng Wang
Edit the printf information when error happens to be more accurate and informative. Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- test/test/test_hash_perf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/test/test_hash_perf.c b/test/test/test_has

[dpdk-dev] [PATCH v3 3/5] test/hash: fix rw test with non-consecutive cores

2018-09-26 Thread Yipeng Wang
the multi-reader and multi-writer rte_hash unit test does not work correctly with non-consicutive core ids. This commit fixes the issue. Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang Tested-by: Bruce Richardson Acked-by: Br

[dpdk-dev] [PATCH v3 0/5] hash: fix multiple issues

2018-09-26 Thread Yipeng Wang
This patch set was part of extendable hash table patch set V2. According to Bruce's comment, this patch set is now separated from the original patch set for easier review and merge. https://mails.dpdk.org/archives/dev/2018-September/112555.html This patch set fixes multiple issues/bugs from rte_ha

[dpdk-dev] [PATCH v3 1/5] test/hash: fix bucket size in hash perf test

2018-09-26 Thread Yipeng Wang
The bucket size was changed from 4 to 8 but the corresponding perf test was not changed accordingly. In the test, the bucket size and number of buckets are used to map to the underneath rte_hash structure. They are used to test performance of two conditions: keys in primary buckets only and keys i

Re: [dpdk-dev] [PATCH v2 3/5] examples/kni: monitor and update link status continually

2018-09-26 Thread Dan Gora
On Wed, Sep 26, 2018 at 11:00 AM, Ferruh Yigit wrote: > On 9/19/2018 8:55 PM, Dan Gora wrote: >> Update KNI example to continuously monitor the Ethernet link status of >> the physical link and update the carrier status of the corresponding >> interfaces with rte_kni_update_link(). >> >> Signed-off

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-26 Thread Dan Gora
On Wed, Sep 26, 2018 at 1:42 PM, Ferruh Yigit wrote: >> There is nothing to "reflect" to the kernel interface, nor to apply to >> the kernel interface. This is exactly how every other kernel driver >> works on link status changes. There is no "netif_set_speed()' >> function. When a link status

Re: [dpdk-dev] [PATCH] eal: fix '--huge-unlink' option

2018-09-26 Thread Wodkowski, PawelX
Hi Anatoly, Can you take a look at this small fix. Thank you Paweł > -Original Message- > From: Wodkowski, PawelX > Sent: Friday, September 21, 2018 1:57 PM > To: dev@dpdk.org > Cc: Wodkowski, PawelX > Subject: [PATCH] eal: fix '--huge-unlink' option > > The final_va field is set durin

[dpdk-dev] [PATCH v2 14/15] net/dpaa2: support MBUF VLAN tci population from HW parser

2018-09-26 Thread Shreyansh Jain
From: Hemant Agrawal This patch adds the support to update the mbuf vlan tci field from the HW parse results in annotation area. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 40 ++ drivers/net/dpaa2/dpaa2_rxtx.c | 55 +--

[dpdk-dev] [PATCH v2 13/15] net/dpaa2: enhance the queue memory cleanup routines

2018-09-26 Thread Shreyansh Jain
From: Hemant Agrawal Earlier the tx queue data was getting cleaned up in close while rest of the functionality was in un-init. Now a new func is created to free queue memory. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 56 ++-- 1 file change

[dpdk-dev] [PATCH v2 15/15] net/dpaa2: support Rx checksum offload in slow parsing

2018-09-26 Thread Shreyansh Jain
From: Hemant Agrawal This is required for new mode for LX2 platform specifically Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_rxtx.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c index bc8b9ff89..eab943dcf

[dpdk-dev] [PATCH v2 11/15] net/dpaa2: update RSS value in mbuf for lx2 platform

2018-09-26 Thread Shreyansh Jain
From: Hemant Agrawal This patch copies the flc based hw provided hash results to the mbuf rss field for lx2 platform only. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_rxtx.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_rx

[dpdk-dev] [PATCH v2 10/15] net/dpaa2: add per queue stats get and reset support

2018-09-26 Thread Shreyansh Jain
For now, only the packet count stats per queue is available. This is part of xstats output (though, per queue stats are actually part of rte_eth_stats basic stats). Signed-off-by: Shreyansh Jain --- drivers/net/dpaa2/dpaa2_ethdev.c | 32 1 file changed, 32 insert

[dpdk-dev] [PATCH v2 12/15] net/dpaa2: optimize the fd reset in Tx path

2018-09-26 Thread Shreyansh Jain
From: Hemant Agrawal various field of FD structure was getting reset in scattered fashion. This patch align them in single macro. Signed-off-by: Hemant Agrawal --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 6 ++ drivers/net/dpaa2/dpaa2_rxtx.c | 8 +++- 2 files changed, 9 inser

[dpdk-dev] [PATCH v2 09/15] net/dpaa2: read hardware provided MAC for DPNI devices

2018-09-26 Thread Shreyansh Jain
Firmware would contain pre-configured devices for each DPMAC backing a DPNI. This patch reads those MAC address when the device is initialized and sets it. THereafter, it can be changed through API or commands from testpmd. Signed-off-by: Shreyansh Jain --- drivers/net/dpaa2/dpaa2_ethdev.c | 79

[dpdk-dev] [PATCH v2 08/15] bus/fslmc: disable annotation prefetch for LX2

2018-09-26 Thread Shreyansh Jain
From: Nipun Gupta In case of LX2 we get parse result summary in FD. We do not need to prefetch and read the annotation to fetch the parse results. Signed-off-by: Nipun Gupta DPDK-1404 --- drivers/net/dpaa2/dpaa2_rxtx.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --gi

[dpdk-dev] [PATCH v2 07/15] bus/fslmc: support 32 enq and deq for LX2 platform

2018-09-26 Thread Shreyansh Jain
From: Nipun Gupta LX2 can support upto 32 frames in one hw pull request. Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c| 17 ++-- drivers/bus/fslmc/portal/dpaa2_hw_dpio.h| 4 drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 22 ---

[dpdk-dev] [PATCH v2 06/15] bus/fslmc: support memory backed portals with QBMAN 5.0

2018-09-26 Thread Shreyansh Jain
From: Nipun Gupta This new mode is available in LX2160 platform. The code dynamically detect the underlying qbman version and choose the mode at runtime. Signed-off-by: Youri Querry Signed-off-by: Roy Pledge Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 180 +

[dpdk-dev] [PATCH v2 05/15] crypto/dpaa2_sec: upgarde mc FW APIs to 10.10.0

2018-09-26 Thread Shreyansh Jain
From: Hemant Agrawal This also brings in support to configure the queues for order restoration. Signed-off-by: Hemant Agrawal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 1 + drivers/crypto/dpaa2_sec/mc/dpseci.c | 128 ++- drivers/crypto/dpaa2_sec/mc/fsl_dpseci

[dpdk-dev] [PATCH v2 04/15] net/dpaa2: upgrade dpni to mc FW APIs to 10.10.0

2018-09-26 Thread Shreyansh Jain
From: Hemant Agrawal New feature includes ordering support and link related enhancements Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/mc/dpni.c | 134 +- drivers/net/dpaa2/mc/fsl_dpkg.h | 71 ++ drivers/net/dpaa2/mc/fsl_dpni.h | 378 -

[dpdk-dev] [PATCH v2 03/15] bus/fslmc: upgrade mc FW APIs to 10.10.0

2018-09-26 Thread Shreyansh Jain
From: Hemant Agrawal This patch add the support for new Management Complex Firmware version to 10.1x.x. One of the main changes in the APIs ordered queue. The fslmc bus lib ABI will need to be bumped to reflect the MC FW API and structure changes. This will also result in bumping of ABI verion

[dpdk-dev] [PATCH v2 02/15] net/dpaa2: fix VLAN filter enablement

2018-09-26 Thread Shreyansh Jain
From: Hemant Agrawal Enable the VLAN filters only when requested in rx offload. Fixes: 0ebce6129bc6 ("net/dpaa2: support new ethdev offload APIs") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

[dpdk-dev] [PATCH v2 01/15] net/dpaa2: fix IOVA conversion for congestion memory

2018-09-26 Thread Shreyansh Jain
From: Nipun Gupta The code was incorrectly using the Virtual mode, whent the IOVA mode was set as Physical. Fixes: 5ae1edff6895 ("dpaa2: prepare for 32-bit build") Cc: sta...@dpdk.org Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/dpaa2_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 d

[dpdk-dev] [PATCH v2 00/15] Upgrade DPAA2 FW and other feature/bug fixes

2018-09-26 Thread Shreyansh Jain
About the series: This series of patches upgrades the DPAA2 driver firmware to v10.10.10 (MC Firmware). As the bus/fslmc is modified, it is a dependent object for other drivers like net/crypto/qdma. Also, the changes are mostly tightly linked - thus, the patches include upgrade as well as sequenti

Re: [dpdk-dev] [RFC] ipsec: new library for IPsec data-path processing

2018-09-26 Thread Jerin Jacob
-Original Message- > Date: Mon, 24 Sep 2018 08:45:48 + > From: "Ananyev, Konstantin" > To: Jerin Jacob > CC: "Joseph, Anoob" , "dev@dpdk.org" > , "Awal, Mohammad Abdul" , > "Doherty, Declan" , Narayana Prasad > , "akhil.go...@nxp.com" > , "hemant.agra...@nxp.com" , > "shreyansh.j

Re: [dpdk-dev] [PATCH] igb_uio: fix refcount if open returns error

2018-09-26 Thread Ferruh Yigit
On 9/14/2018 4:30 PM, Stephen Hemminger wrote: > This fixes the problem of reference count leak if > igbuio_pci_enable_interrupts fails. > > Also, replace mutex and integer with a kernel atomic counter. > This is standard pattern for kernel devices. > > Fixes: 19685d5aa79c ("igb_uio: allow multi-

[dpdk-dev] [PATCH v5 10/10] doc/vm_power_manager: add JSON interface API info

2018-09-26 Thread David Hunt
Also added meson/ninja build info Signed-off-by: David Hunt Acked-by: Marko Kovacevic --- .../sample_app_ug/vm_power_management.rst | 272 +- 1 file changed, 270 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample

[dpdk-dev] [PATCH v5 06/10] examples/power: increase allowed number of clients

2018-09-26 Thread David Hunt
Now that we're handling host policies, containers and virtual machines, we'll rename MAX_VMS to MAX_CLIENTS, and increase from 4 to 64 Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/channel_manager.h | 4 ++-- examples/vm_power_manager/channel_monitor.c | 10

[dpdk-dev] [PATCH v5 01/10] examples/power: add checks around hypervisor

2018-09-26 Thread David Hunt
Allow vm_power_manager to run without requiring qemu to be present on the machine. This will be required for instances where the JSON interface is used for commands and polices, without any VMs present. A use case for this is a container enviromnent. Signed-off-by: David Hunt Acked-by: Anatoly Bu

[dpdk-dev] [PATCH v5 09/10] examples/power: add meson/ninja build support

2018-09-26 Thread David Hunt
Add meson.build in vm_power_manager and the guest_cli subdirectory. Building can be achieved by going to the build directory, and using meson configure -Dexamples=vm_power_manager,vm_power_manager/guest_cli Then, when ninja is invoked, it will build dpdk-vm_power_manger and dpdk-guest_cli Work s

[dpdk-dev] [PATCH v5 07/10] examples/power: add json string handling

2018-09-26 Thread David Hunt
Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentation updates. This patch introduces a new dependency on Jansson, a C library for encoding, decoding and m

[dpdk-dev] [PATCH v5 08/10] examples/power: clean up verbose messages

2018-09-26 Thread David Hunt
Some messages appearing several times a second, removing as they are unnecessary. Other less severe messages change from INFO to DEBUG Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/channel_monitor.c | 19 +-- 1 file changed, 5 insertions(+), 1

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-26 Thread Ferruh Yigit
On 9/26/2018 3:55 PM, Dan Gora wrote: > On Wed, Sep 26, 2018 at 10:59 AM, Ferruh Yigit wrote: >> On 9/19/2018 8:55 PM, Dan Gora wrote: >>> Add a new API function to KNI, rte_kni_update_link() to allow DPDK >>> applications to update the link status for KNI network interfaces in >>> the linux kerne

[dpdk-dev] [PATCH v5 05/10] examples/power: add host channel to power manager

2018-09-26 Thread David Hunt
This patch adds a fifo channel to the vm_power_manager app through which we can send commands and polices. Intended for sending JSON strings. The fifo is at /tmp/powermonitor/fifo Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/channel_manager.c | 109 +

[dpdk-dev] [PATCH v5 03/10] lib/power: add changes for host commands/policies

2018-09-26 Thread David Hunt
This patch does a couple of things: * Adds a new message type for removing policies (PKT_POLICY_REMOVE) Used when we want to remove a previously created policy. * Adds a core_type bool to the channel packet struct to specify whether the type of core we want to control is cirtual or phys

[dpdk-dev] [PATCH v5 0/10] add json power policy interface for containers

2018-09-26 Thread David Hunt
The current vm_power_manager example app has the capability to accept power policies from virtual machines via virtio-serial channels. These power policies allow a virtual machine to give information to the power manager to allow the power manager take care of the power management of the virtual m

[dpdk-dev] [PATCH v5 04/10] examples/power: add necessary changes to guest app

2018-09-26 Thread David Hunt
The changes here are minimal, as the guest app functionality is not changing at all, but there is a new element in the channel_packet struct that needs to have a default set (channel_packet->core_type). Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- examples/vm_power_manager/guest_cli/

[dpdk-dev] [PATCH v5 02/10] examples/power: allow for number of vms to be zero

2018-09-26 Thread David Hunt
Previously the vm_power_manager app required to have some vms defined, so the call to get_all_vm() always set the noVms variable. Now we're accepting policies from the host OS (without any VMs defined), so it is now valid to have zero VMs. This patch initialises the relevant variables to zero just

[dpdk-dev] [PATCH v3] kni: dynamically allocate memory for each KNI

2018-09-26 Thread Igor Ryzhov
Long time ago preallocation of memory for KNI was introduced in commit 0c6bc8e. It was done because of lack of ability to free previously allocated memzones, which led to memzone exhaustion. Currently memzones can be freed and this patch uses this ability for dynamic KNI memory allocation. Signed-

Re: [dpdk-dev] [PATCH v5 21/21] doc: add external memory feature to programmer's guide

2018-09-26 Thread Kovacevic, Marko
> > Hi Anatoly, > > > > Im getting an error when doing > > > > make-doc-guides-html > > > > /dpdk/doc/guides/prog_guide/env_abstraction_layer.rst:241: WARNING: > Unexpected indentation. > > /dpdk/doc/guides/prog_guide/env_abstraction_layer.rst:242: WARNING: > Block quote ends without a blank line;

Re: [dpdk-dev] [PATCH v4 11/11] examples/power: add json example files

2018-09-26 Thread Hunt, David
Good point. There's also a couple of tiny niggles I'd like to resolve in patch 10 of the set, so I'll re-spin in v5. -Original Message- From: Kovacevic, Marko Sent: Wednesday, 26 September, 2018 4:58 PM To: Hunt, David ; dev@dpdk.org Cc: Mcnamara, John ; step...@networkplumber.org; Yao,

Re: [dpdk-dev] [PATCH v5 21/21] doc: add external memory feature to programmer's guide

2018-09-26 Thread Burakov, Anatoly
On 26-Sep-18 4:19 PM, Kovacevic, Marko wrote: Add a short chapter on usage of external memory in DPDK to the Programmer's Guide. Signed-off-by: Anatoly Burakov --- .../prog_guide/env_abstraction_layer.rst | 37 +++ 1 file changed, 37 insertions(+) +The expected workfl

Re: [dpdk-dev] [PATCH v4 11/11] examples/power: add json example files

2018-09-26 Thread Kovacevic, Marko
Hi Dave, Feel like this part is not needed in the patch as you have this already in the documentation, People can just copy and paste the examples from the docs, so we don't need to maintain two things. Thanks, Marko K.

Re: [dpdk-dev] [PATCH] doc: change tools guide to SPDX license

2018-09-26 Thread Hemant Agrawal
Colin/Christian, Can you or someone from canonical ack this patch. This is one of the last remaining roadblock in making DPDK SPDX complaint. Regards, Hemant On 7/4/2018 12:51 PM, Hemant Agrawal wrote: Colin/Christian, Can someone from canonical ack this patch. Regards, Hemant -Origin

Re: [dpdk-dev] [PATCH 06/12] vhost: register new regions with userfaultfd

2018-09-26 Thread Alejandro Lucero
On Wed, Sep 26, 2018 at 8:28 AM Maxime Coquelin wrote: > Signed-off-by: Dr. David Alan Gilbert > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost_user.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhos

Re: [dpdk-dev] [PATCH 04/12] vhost: introduce postcopy's advise message

2018-09-26 Thread Alejandro Lucero
On Wed, Sep 26, 2018 at 8:27 AM Maxime Coquelin wrote: > This patch opens a userfaultfd and sends it back to Qemu's > VHOST_USER_POSTCOPY_ADVISE request. > > Signed-off-by: Dr. David Alan Gilbert > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost.h | 2 ++ > lib/librte_vhost

Re: [dpdk-dev] secondary processes and private data

2018-09-26 Thread Alejandro Lucero
On Wed, Sep 26, 2018 at 3:33 PM Stephen Hemminger < step...@networkplumber.org> wrote: > On Wed, 26 Sep 2018 15:21:52 +0200 > Thomas Monjalon wrote: > > > Hi Alejandro, > > > > 25/09/2018 16:10, Alejandro Lucero: > > > I've a problem when part of device private data needs to be private per > > >

Re: [dpdk-dev] [PATCH v5 21/21] doc: add external memory feature to programmer's guide

2018-09-26 Thread Kovacevic, Marko
> Add a short chapter on usage of external memory in DPDK to the > Programmer's Guide. > > Signed-off-by: Anatoly Burakov > --- > .../prog_guide/env_abstraction_layer.rst | 37 +++ > 1 file changed, 37 insertions(+) > +The expected workflow is as follows: > + > +* Get a poi

Re: [dpdk-dev] [PATCH v2 1/5] kni: add API to set link status on kernel interface

2018-09-26 Thread Dan Gora
On Wed, Sep 26, 2018 at 10:59 AM, Ferruh Yigit wrote: > On 9/19/2018 8:55 PM, Dan Gora wrote: >> Add a new API function to KNI, rte_kni_update_link() to allow DPDK >> applications to update the link status for KNI network interfaces in >> the linux kernel. >> >> Signed-off-by: Dan Gora > > <...>

Re: [dpdk-dev] [PATCH v2 5/5] examples/kni: improve zeroing statistics

2018-09-26 Thread Dan Gora
On Wed, Sep 26, 2018 at 11:01 AM, Ferruh Yigit wrote: > On 9/19/2018 8:55 PM, Dan Gora wrote: >> The worker threads incrementing the rx/tx_packets race with the signal >> handler from the main thread zeroing the entire statistics structure. >> This can cause the statistics to fail to be zeroed, ev

Re: [dpdk-dev] [PATCH 0/4] Address reader-writer concurrency in rte_hash

2018-09-26 Thread Honnappa Nagarahalli
Hi Bruce/Pablo, I need to get this into 18.11, appreciate any review/feedback soon. Thank you, Honnappa > -Original Message- > From: Honnappa Nagarahalli > Sent: Friday, September 14, 2018 4:19 PM > To: Honnappa Nagarahalli ; > bruce.richard...@intel.com; pablo.de.lara.gua...@intel.co

[dpdk-dev] [PATCH] doc: fix typos in the flow API guide

2018-09-26 Thread Ilya Maximets
Fixes: 3e0ceb9f17ff ("doc: add basic howto for flow API") Cc: sta...@dpdk.org Signed-off-by: Ilya Maximets --- doc/guides/howto/rte_flow.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/guides/howto/rte_flow.rst b/doc/guides/howto/rte_flow.rst index c71152

Re: [dpdk-dev] secondary processes and private data

2018-09-26 Thread Stephen Hemminger
On Wed, 26 Sep 2018 15:21:52 +0200 Thomas Monjalon wrote: > Hi Alejandro, > > 25/09/2018 16:10, Alejandro Lucero: > > I've a problem when part of device private data needs to be private per > > process. > > It appears we are facing the same issue to support multi-process in tap. > > > Curren

Re: [dpdk-dev] [PATCH v4 10/11] doc/vm_power_manager: add JSON interface API info

2018-09-26 Thread Kovacevic, Marko
> Also added meson/ninja build info > > Signed-off-by: David Hunt > --- > .../sample_app_ug/vm_power_management.rst | 272 > +- Acked-by: Marko Kovacevic

Re: [dpdk-dev] [PATCH v4 08/11] examples/power: clean up verbose messages

2018-09-26 Thread Burakov, Anatoly
On 26-Sep-18 2:40 PM, David Hunt wrote: Some messages appearing several times a second, removing as they are unnecessary. Other less severe messages change from INFO to DEBUG Signed-off-by: David Hunt --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v4 07/11] examples/power: add json string handling

2018-09-26 Thread Burakov, Anatoly
On 26-Sep-18 2:40 PM, David Hunt wrote: Add JSON string handling to vm_power_manager for JSON strings received through the fifo. The format of the JSON strings are detailed in the next patch, the vm_power_manager user guide documentation updates. This patch introduces a new dependency on Jansson

Re: [dpdk-dev] [PATCH v4 06/11] examples/power: increase allowed number of clients

2018-09-26 Thread Burakov, Anatoly
On 26-Sep-18 2:40 PM, David Hunt wrote: Now that we're handling host policies, containers and virtual machines, we'll rename MAX_VMS to MAX_CLIENTS, and increase from 4 to 64 Signed-off-by: David Hunt --- Acked-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH v4 05/11] examples/power: add host channel to power manager

2018-09-26 Thread Burakov, Anatoly
On 26-Sep-18 2:40 PM, David Hunt wrote: This patch adds a fifo channel to the vm_power_manager app through which we can send commands and polices. Intended for sending JSON strings. The fifo is at /tmp/powermonitor/fifo Signed-off-by: David Hunt --- Acked-by: Anatoly Burakov -- Thanks, Anat

[dpdk-dev] [PATCH] test: reduce test duration for efd autotest

2018-09-26 Thread Jananee Parthasarathy
Reduced test time for efd_autotest. Key length is updated, invoke times of random function is reduced. Signed-off-by: Jananee Parthasarathy --- test/test/test_efd.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/test/test/test_efd.c b/test/test/test_efd.c i

Re: [dpdk-dev] [PATCH v2 5/5] examples/kni: improve zeroing statistics

2018-09-26 Thread Ferruh Yigit
On 9/19/2018 8:55 PM, Dan Gora wrote: > The worker threads incrementing the rx/tx_packets race with the signal > handler from the main thread zeroing the entire statistics structure. > This can cause the statistics to fail to be zeroed, even when there > is no traffic on those interfaces. > > Impr

Re: [dpdk-dev] [PATCH v2 4/5] examples/kni: add log msgs to show and clear stats

2018-09-26 Thread Ferruh Yigit
On 9/19/2018 8:55 PM, Dan Gora wrote: > Add logging messages showing the commands necessary for the user to > have the application display and zero the statistics. > > Signed-off-by: Dan Gora Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2 3/5] examples/kni: monitor and update link status continually

2018-09-26 Thread Ferruh Yigit
On 9/19/2018 8:55 PM, Dan Gora wrote: > Update KNI example to continuously monitor the Ethernet link status of > the physical link and update the carrier status of the corresponding > interfaces with rte_kni_update_link(). > > Signed-off-by: Dan Gora Also this patch sets kni interfaces "up", ple

Re: [dpdk-dev] [PATCH v2 2/5] kni: set default carrier state to 'off'

2018-09-26 Thread Ferruh Yigit
On 9/19/2018 8:55 PM, Dan Gora wrote: > Set the carrier state to 'off' when the interface is instantiated > or when it is marked 'up' or 'down'. This is necessary to set the > interface to a known operational state until the carrier state is > changed with rte_kni_update_link(). > > Signed-off-by

  1   2   3   >