[dpdk-dev] [PATCH v2 05/12] net/bnxt: add support for extended port counters

2018-09-21 Thread Ajit Khaparde
This patch adds support extended port statistics like COS bytes, packets, XON -> XOFF and XOFF -> XON transitions in Tx and Rx path. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 8 ++ drivers/net/bnxt/bnxt_ethdev.c | 30 - drivers/net/bnxt/bnxt_hwrm.c | 44 +++

[dpdk-dev] [PATCH v2 11/12] net/bnxt: set VLAN strip mode before default vnic cfg

2018-09-21 Thread Ajit Khaparde
From: Bei Sun Firmware sets pf pair in default vnic cfg. If the VLAN strip setting is not available at this time, it will not be configured correctly in the CFA. Set the desired VLAN strip mode before default vnic configuration. Signed-off-by: Bei Sun Signed-off-by: Ajit Khaparde --- drivers/

[dpdk-dev] [PATCH v2 06/12] net/bnxt: add support to enable new mailbox channel

2018-09-21 Thread Ajit Khaparde
For hardware having multiple embedded management processors the firmware has added support to indicate if the comm channel to the processor has been enabled. If the channel is enabled, switch the CFA NTUPLE and EM filtering commands to use the kong channel. Signed-off-by: Ajit Khaparde --- drive

[dpdk-dev] [PATCH v2 08/12] net/bnxt: use correct macro to register VF async event completion ring

2018-09-21 Thread Ajit Khaparde
From: yongping While registering vf's event completion ring to FW, use the wrong macro, FW doesn't set up the event completion ring successfully, VF can't receive any async event. Signed-off-by: yongping Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 i

[dpdk-dev] [PATCH v2 09/12] net/bnxt: set MAC filtering as outer for non tunnel frames

2018-09-21 Thread Ajit Khaparde
We need to set HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST bit in L2_FILTER_ALLOC for filtering non-tunnel packets based on outermost MAC. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers

[dpdk-dev] [PATCH v2 07/12] net/bnxt: add support for trusted VF

2018-09-21 Thread Ajit Khaparde
In the current model, VFs are not trusted. So it is not allowed to send many HWRM commands. Newer firmware has added support to allow VF to be trusted. Now the VF queries if it is a trusted entity and based on that it can send HWRM commands to the firmware. Signed-off-by: Ajit Khaparde --- drive

[dpdk-dev] [PATCH v2 12/12] net/bnxt: remove excess log messages

2018-09-21 Thread Ajit Khaparde
When the firmware version and the driver HWRM version do not match, we are logging some messages. These messages unnecessarily clutter the logs and can add to the noise. We are logging the HWRM version and the firmware version anyway. The difference in version numbers can be gleaned from that. Remo

[dpdk-dev] [PATCH v2 10/12] net/bnxt: set a VNIC as default only once

2018-09-21 Thread Ajit Khaparde
If a vnic is configured as default and the setting has not changed, there is no need to issue this setting again to the FW. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt_hwrm.c | 9 - 2 files changed, 9 insertions(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v2 03/12] net/bnxt: fix MTU setting

2018-09-21 Thread Ajit Khaparde
The HW can support maximum frame length of 9600 bytes. And we are currently capping the max frame size to 9500 bytes. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Cc: sta...@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 2 +- drivers/net/bnxt/bnxt_ethdev.c | 2

[dpdk-dev] [PATCH v2 00/12] bnxt patchset

2018-09-21 Thread Ajit Khaparde
Patchset against dpdk-next-net. v1->v2: net/bnxt: get rid of ff pools array and use the vnic info array instead - Fix access to uninitialized variable. - Rectify the wrong 'Fixes' reference. net/bnxt: update HWRM version - Update from 1.9.2.45 to version 1.9.2.53 Please apply. Ajit Khaparde (8)

[dpdk-dev] [PATCH v2 02/12] net/bnxt: fix uninitialized ptr access in transmit handler

2018-09-21 Thread Ajit Khaparde
From: Somnath Kotur bnxt_start_xmit() was attempting to access an uninitialized ptr - txbd1 which would lead to segmentation fault. Fix to initialize ptr to NULL and check for the same before access. Fixes: f10258e39ec2 ("net/bnxt: fix HW Tx checksum offload check") Cc: sta...@broadcom.com Sign

[dpdk-dev] [PATCH v2 01/12] net/bnxt: get rid of ff pools array and use the vnic info array instead

2018-09-21 Thread Ajit Khaparde
From: Somnath Kotur There was no direct association between the rxq's vnic and the vnic_info[]. Explicitly associate the two in bnxt_mq_rx_configure(). Fixes: 0a256e4a548b ("net/bnxt: fix Rx ring count limitation") Cc: sta...@dpdk.org Cc: ajit.khapa...@broadcom.com Signed-off-by: Somnath Kotur

Re: [dpdk-dev] [PATCH v3 2/2] examples/vdpa: introduce a new sample for vDPA

2018-09-21 Thread Ye Xiaolong
On 09/21, Wang, Xiao W wrote: >Hi Xiaolong, > >> -Original Message- >> From: Ye, Xiaolong >> Sent: Friday, September 21, 2018 6:28 AM >> To: dev@dpdk.org; Maxime Coquelin ; Bie, >> Tiwei ; Wang, Zhihong >> Cc: Wang, Xiao W ; Rami Rosen >> ; Wang, Haiyue ; Ye, >> Xiaolong >> Subject: [PATC

Re: [dpdk-dev] [PATCH] latencystats: fix timestamp marking and latency calculation

2018-09-21 Thread longtb5
Hi Reshma, > -Original Message- > From: reshma.pat...@intel.com [mailto:reshma.pat...@intel.com] > Sent: Friday, September 21, 2018 11:02 PM > To: long...@viettel.com.vn; konstantin.anan...@intel.com; dev@dpdk.org > Cc: Reshma Pattan > Subject: [PATCH] latencystats: fix timestamp marking

[dpdk-dev] ARM server+intel NIC run dpdk met error

2018-09-21 Thread wang.yong19
Hi, I tried to run dpdk testpmd on Qualcomm ARM server + intel 82599 NIC + CentOS 7.4. However, an error occured with the following output. [root@localhost app]# ./testpmd -l 4-5 -m 1024 -w :01:00.1 -- -i -a --forward-mode=io EAL: Detected 47 lcore(s) EAL: Detected 1 NUMA nodes EAL: Multi-

Re: [dpdk-dev] [PATCH 2/5] net/bnx2x: update link/PHY management

2018-09-21 Thread Mody, Rasesh
>From: Ferruh Yigit >Sent: Friday, September 21, 2018 11:10 AM > >On 9/19/2018 10:59 PM, Mody, Rasesh wrote: >> This patch has changes to update the link/PHY management (elink) code >> to the latest. >> >> Signed-off-by: Rasesh Mody >> --- >> drivers/net/bnx2x/bnx2x.h |3 + >> drivers/ne

[dpdk-dev] [PATCH v2 5/7] hash: add extendable bucket feature

2018-09-21 Thread Yipeng Wang
In use cases that hash table capacity needs to be guaranteed, the extendable bucket feature can be used to contain extra keys in linked lists when conflict happens. This is similar concept to the extendable bucket hash table in packet framework. This commit adds the extendable bucket feature. User

[dpdk-dev] [PATCH v2 7/7] hash: use partial-key hashing

2018-09-21 Thread Yipeng Wang
This commit changes the hashing mechanism to "partial-key hashing" to calculate bucket index and signature of key. This is proposed in Bin Fan, et al's paper "MemC3: Compact and Concurrent MemCache with Dumber Caching and Smarter Hashing". Bascially the idea is to use "xor" to derive alternative

[dpdk-dev] [PATCH v2 3/7] test/hash: fix rw test with non-consecutive cores

2018-09-21 Thread Yipeng Wang
the multi-reader and multi-writer rte_hash unit test does not work correctly with non-consicutive core ids. This commit fixes the issue. Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang --- test/test/test_hash_readwrite.c | 78

[dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

2018-09-21 Thread Yipeng Wang
The bucket size was changed from 4 to 8 but the corresponding perf test was not changed accordingly. Fixes: 58017c98ed53 ("hash: add vectorized comparison") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang --- test/test/test_hash_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v2 6/7] test/hash: implement extendable bucket hash test

2018-09-21 Thread Yipeng Wang
This commit changes the current rte_hash unit test to test the extendable table feature and performance. Signed-off-by: Yipeng Wang --- test/test/test_hash.c | 151 +++-- test/test/test_hash_perf.c | 114 +- 2 files cha

[dpdk-dev] [PATCH v2 4/7] hash: fix unnecessary code

2018-09-21 Thread Yipeng Wang
Since the depth-first search of cuckoo path is removed, we do not need the macro anymore which specifies the depth of the cuckoo search. Fixes: f2e3001b53ec ("hash: support read/write concurrency") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang --- lib/librte_hash/rte_cuckoo_hash.h | 2 -- 1 fi

[dpdk-dev] [PATCH v2 2/7] test/hash: more accurate hash perf test output

2018-09-21 Thread Yipeng Wang
Edit the printf information when error happens to be more accurate and informative. Signed-off-by: Yipeng Wang --- test/test/test_hash_perf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c index 9ed7125..4d00

[dpdk-dev] [PATCH v2 0/7] hash: add extendable bucket and partial key hashing

2018-09-21 Thread Yipeng Wang
The first four commits of the patch set try to fix small issues of previous code. The other commits make two major optimizations over the current rte_hash library. First, it adds Extendable Bucket Table feature: a new structure that can accommodate keys that failed to get inserted into the main h

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/bonding: fix RX slave fairness

2018-09-21 Thread Ferruh Yigit
On 9/20/2018 1:52 PM, Chas Williams wrote: > From: Chas Williams > > Some PMDs, especially ones with vector receives, require a minimum number > of receive buffers in order to receive any packets. If the first slave > read leaves less than this number available, a read from the next slave > may

Re: [dpdk-dev] [PATCH 2/5] net/bnx2x: update link/PHY management

2018-09-21 Thread Ferruh Yigit
On 9/19/2018 10:59 PM, Mody, Rasesh wrote: > This patch has changes to update the link/PHY management (elink) code > to the latest. > > Signed-off-by: Rasesh Mody > --- > drivers/net/bnx2x/bnx2x.h |3 + > drivers/net/bnx2x/ecore_hsi.h | 20 +- > drivers/net/bnx2x/elink.c | 7951 >

Re: [dpdk-dev] [PATCH v2 01/21] net/atlantic: atlantic PMD driver skeleton

2018-09-21 Thread Ferruh Yigit
On 9/21/2018 4:35 PM, Igor Russkikh wrote: > Hi Ferruh, > > Thanks for your comments! > All understood, we'll fix that in next version. > > Another question related to new PMDs integration process: > I have not found any requirements or statements on passing/supporting DPDK > Test Suite for new

[dpdk-dev] DPDK Release Status Meeting 20/09/2018

2018-09-21 Thread Ferruh Yigit
Minutes 20 September 2018 - Agenda: * Dates * Subtrees * Bugzilla * Reviewathon Participants: * Intel * RedHat * Debian * Cavium * Mellanox * NXP Release Dates - * RC1 date is unchanged, it is *5th October 2018* * 690 patces in backlog, two weeks to integrat

Re: [dpdk-dev] [PATCH] vdev: free reply.msgs memory for secondary process

2018-09-21 Thread Ferruh Yigit
On 9/21/2018 5:25 PM, Paul Luse wrote: > From: paul luse > > This patch fixes an issue caught with ASAN where a vdev_scan() > to a secondary bus was failing to free some memory. > > Signed-off-by: paul luse Hi Paul, Is this different from below patch, which seems already acked: https://patche

[dpdk-dev] [PATCH] netvsc: support multicast/promiscuous settings on VF

2018-09-21 Thread Stephen Hemminger
Provide API's to enable allmulticast and promiscuous in Netvsc PMD with VF. This keeps the VF and PV path in sync. Signed-off-by: Stephen Hemminger --- Patch against dpdk-net-next drivers/net/netvsc/hn_ethdev.c | 14 + drivers/net/netvsc/hn_var.h| 9 + drivers/net/netvs

Re: [dpdk-dev] [PATCH v1] testpmd: eeprom display

2018-09-21 Thread Ferruh Yigit
On 9/21/2018 5:13 PM, Gaëtan Rivet wrote: > On Fri, Sep 21, 2018 at 04:41:10PM +0100, Ferruh Yigit wrote: >> On 9/18/2018 9:59 AM, Gaetan Rivet wrote: >>> The interactive command >>> >>> show port eeprom >>> >>> will dump the content of the EEPROM for the selected port. >>> Dumping eeprom of all

Re: [dpdk-dev] [PATCH v3 0/2] net/failsafe: support multicast MAC address set

2018-09-21 Thread Stephen Hemminger
On Fri, 21 Sep 2018 19:33:16 +0300 Andrew Rybchenko wrote: > On 9/21/18 7:21 PM, Stephen Hemminger wrote: > > On Fri, 21 Sep 2018 16:36:19 +0100 > > Andrew Rybchenko wrote: > > > >> v3: > >> - move apply on sync to fs_eth_dev_conf_apply() to apply to > >>a new subdevice only > >>

Re: [dpdk-dev] [PATCH v3 0/2] net/failsafe: support multicast MAC address set

2018-09-21 Thread Andrew Rybchenko
On 9/21/18 7:33 PM, Andrew Rybchenko wrote: On 9/21/18 7:21 PM, Stephen Hemminger wrote: On Fri, 21 Sep 2018 16:36:19 +0100 Andrew Rybchenko wrote: v3: - move apply on sync to fs_eth_dev_conf_apply() to apply to    a new subdevice only - use ethdev API to apply to sub-device on

Re: [dpdk-dev] [PATCH v3 0/2] net/failsafe: support multicast MAC address set

2018-09-21 Thread Andrew Rybchenko
On 9/21/18 7:21 PM, Stephen Hemminger wrote: On Fri, 21 Sep 2018 16:36:19 +0100 Andrew Rybchenko wrote: v3: - move apply on sync to fs_eth_dev_conf_apply() to apply to a new subdevice only - use ethdev API to apply to sub-device on sync - remove unnecessary check the same

[dpdk-dev] [PATCH] vdev: free reply.msgs memory for secondary process

2018-09-21 Thread Paul Luse
From: paul luse This patch fixes an issue caught with ASAN where a vdev_scan() to a secondary bus was failing to free some memory. Signed-off-by: paul luse --- drivers/bus/vdev/vdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index 69

Re: [dpdk-dev] [PATCH v3 0/2] net/failsafe: support multicast MAC address set

2018-09-21 Thread Stephen Hemminger
On Fri, 21 Sep 2018 16:36:19 +0100 Andrew Rybchenko wrote: > v3: > - move apply on sync to fs_eth_dev_conf_apply() to apply to > a new subdevice only > - use ethdev API to apply to sub-device on sync > - remove unnecessary check the same pointer from the method > implement

Re: [dpdk-dev] [PATCH 2/5] test: add quick run tests under test-fast suite

2018-09-21 Thread Bruce Richardson
On Fri, Sep 21, 2018 at 04:58:45PM +0100, Hari Kumar Vemula wrote: > Added test cases that runs quickly under test fast category > > Signed-off-by: Hari Kumar Vemula > --- > test/test/meson.build | 89 > +++ > 1 file changed, 83 insertions(+), 6 d

[dpdk-dev] [PATCH v4 20/20] doc: add external memory feature to programmer's guide

2018-09-21 Thread Anatoly Burakov
Add a short chapter on usage of external memory in DPDK to the Programmer's Guide. Signed-off-by: Anatoly Burakov --- .../prog_guide/env_abstraction_layer.rst | 38 +++ 1 file changed, 38 insertions(+) diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guid

[dpdk-dev] [PATCH v4 09/20] malloc: add function to query socket ID of named heap

2018-09-21 Thread Anatoly Burakov
When we will be creating external heaps, they will have their own "fake" socket ID, so add a function that will map the heap name to its socket ID. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 14 lib/librte_eal/common/rte_malloc.c | 37 +++

[dpdk-dev] [PATCH v4 08/20] malloc: add name to malloc heaps

2018-09-21 Thread Anatoly Burakov
We will need to refer to external heaps in some way. While we use heap ID's internally, for external API use it has to be something more user-friendly. So, we will be using a string to uniquely identify a heap. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc_heap.h |

[dpdk-dev] [PATCH v4 15/20] malloc: allow attaching to external memory chunks

2018-09-21 Thread Anatoly Burakov
In order to use external memory in multiple processes, we need to attach to primary process's memseg lists, so add a new API to do that. It is the responsibility of the user to ensure that memory is accessible and that it has been previously added to the malloc heap by another process. Signed-off-

[dpdk-dev] [PATCH v4 07/20] sched: do not check for invalid socket ID

2018-09-21 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(

[dpdk-dev] [PATCH v4 12/20] malloc: allow destroying heaps

2018-09-21 Thread Anatoly Burakov
Add an API to destroy specified heap. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 23 + lib/librte_eal/common/malloc_heap.c| 22 lib/librte_eal/common/malloc_heap.h| 3 ++ lib/librte_eal/common/rte_malloc.c | 58 ++

[dpdk-dev] [PATCH v4 03/20] malloc: index heaps using heap ID rather than NUMA node

2018-09-21 Thread Anatoly Burakov
Switch over all parts of EAL to use heap ID instead of NUMA node ID to identify heaps. Heap ID for DPDK-internal heaps is NUMA node's index within the detected NUMA node list. Heap ID for external heaps will be order of their creation. Signed-off-by: Anatoly Burakov --- config/common_base

[dpdk-dev] [PATCH v4 10/20] malloc: add function to check if socket is external

2018-09-21 Thread Anatoly Burakov
An API is needed to check whether a particular socket ID belongs to an internal or external heap. Prime user of this would be mempool allocator, because normal assumptions of IOVA contiguousness in IOVA as VA mode do not hold in case of externally allocated memory. Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v4 05/20] flow_classify: do not check for invalid socket ID

2018-09-21 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_flow_classify/rte_flow_classify.c | 3 +-- 1 file chan

[dpdk-dev] [PATCH v4 18/20] app/testpmd: add support for external memory

2018-09-21 Thread Anatoly Burakov
Currently, mempools can only be allocated either using native DPDK memory, or anonymous memory. This patch will add two new methods to allocate mempool using external memory (regular or hugepage memory), and add documentation about it to testpmd user guide. It adds a new flag "--mp-alloc", with fo

[dpdk-dev] [PATCH v4 02/20] mem: allow memseg lists to be marked as external

2018-09-21 Thread Anatoly Burakov
When we allocate and use DPDK memory, we need to be able to differentiate between DPDK hugepage segments and segments that were made part of DPDK but are externally allocated. Add such a property to memseg lists. This breaks the ABI, so bump the EAL library ABI version and document the change in r

[dpdk-dev] [PATCH v4 16/20] malloc: allow detaching from external memory

2018-09-21 Thread Anatoly Burakov
Add API to detach from existing chunk of external memory in a process. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 27 ++ lib/librte_eal/common/rte_malloc.c | 27 ++ lib/librte_eal/rte_eal_version.map |

[dpdk-dev] [PATCH v4 11/20] malloc: allow creating malloc heaps

2018-09-21 Thread Anatoly Burakov
Add API to allow creating new malloc heaps. They will be created with socket ID's going above RTE_MAX_NUMA_NODES, to avoid clashing with internal heaps. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 19 lib/librte_eal/common/malloc_heap.c| 30 ++

[dpdk-dev] [PATCH v4 01/20] mem: add length to memseg list

2018-09-21 Thread Anatoly Burakov
Previously, to calculate length of memory area covered by a memseg list, we would've needed to multiply page size by length of fbarray backing that memseg list. This is not obvious and unnecessarily low level, so store length in the memseg list itself. Signed-off-by: Anatoly Burakov --- drivers/

[dpdk-dev] [PATCH v4 14/20] malloc: allow removing memory from named heaps

2018-09-21 Thread Anatoly Burakov
Add an API to remove memory from specified heaps. This will first check if all elements within the region are free, and that the region is the original region that was added to the heap (by comparing its length to length of memory addressed by the underlying memseg list). Signed-off-by: Anatoly Bu

[dpdk-dev] [PATCH v4 19/20] doc: add external memory feature to the release notes

2018-09-21 Thread Anatoly Burakov
Document the addition of external memory support to DPDK. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst index 63bbb1b51..9a05c9980

[dpdk-dev] [PATCH v4 17/20] test: add unit tests for external memory support

2018-09-21 Thread Anatoly Burakov
Add simple unit tests to test external memory support. The tests are pretty basic and mostly consist of checking if invalid API calls are handled correctly, plus a simple allocation/deallocation test for malloc and memzone. Signed-off-by: Anatoly Burakov --- test/test/Makefile| 1 +

[dpdk-dev] [PATCH v4 13/20] malloc: allow adding memory to named heaps

2018-09-21 Thread Anatoly Burakov
Add an API to add externally allocated memory to malloc heap. The memory will be stored in memseg lists like regular DPDK memory. Multiple segments are allowed within a heap. If IOVA table is not provided, IOVA addresses are filled in with RTE_BAD_IOVA. Signed-off-by: Anatoly Burakov --- lib/lib

[dpdk-dev] [PATCH v4 06/20] pipeline: do not check for invalid socket ID

2018-09-21 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_pipeline/rte_pipeline.c | 3 +-- 1 file changed, 1 ins

[dpdk-dev] [PATCH v4 04/20] mem: do not check for invalid socket ID

2018-09-21 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. This changes the semantics of what we understand by "socket ID", so document the change in the release

Re: [dpdk-dev] [PATCH v1] testpmd: eeprom display

2018-09-21 Thread Gaëtan Rivet
On Fri, Sep 21, 2018 at 04:41:10PM +0100, Ferruh Yigit wrote: > On 9/18/2018 9:59 AM, Gaetan Rivet wrote: > > The interactive command > > > > show port eeprom > > > > will dump the content of the EEPROM for the selected port. > > Dumping eeprom of all ports at once is not supported. > > > > S

[dpdk-dev] [PATCH v4 00/20] Support externally allocated memory in DPDK

2018-09-21 Thread Anatoly Burakov
This is a proposal to enable using externally allocated memory in DPDK. In a nutshell, here is what is being done here: - Index internal malloc heaps by NUMA node index, rather than NUMA node itself (external heaps will have ID's in order of creation) - Add identifier string to malloc heap, to

Re: [dpdk-dev] [PATCH v3 0/2] net/failsafe: support multicast MAC address set

2018-09-21 Thread Gaëtan Rivet
Hi, Seems good, thanks. Acked-by: Gaetan Rivet On Fri, Sep 21, 2018 at 04:36:20PM +0100, Andrew Rybchenko wrote: > v3: > - move apply on sync to fs_eth_dev_conf_apply() to apply to > a new subdevice only > - use ethdev API to apply to sub-device on sync > - remove unnecessary

[dpdk-dev] [PATCH] latencystats: fix timestamp marking and latency calculation

2018-09-21 Thread Reshma Pattan
Latency calculation logic is not correct for the case where packets gets dropped before TX. As for the dropped packets, the timestamp is not cleared, and such packets still gets counted for latency calculation in next runs, that will result in inaccurate latency measurement. So fix this issue as b

[dpdk-dev] [PATCH 4/5] test: add library dependent tests under test-driver suite

2018-09-21 Thread Hari Kumar Vemula
Added test cases that depend on library as cryptodev Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/test/test/meson.build b/test/test/meson.build index edda0b5b7..b3a9e7ef9 100644 --- a/

[dpdk-dev] [PATCH 5/5] test: add dump test cases under test-dump suite

2018-09-21 Thread Hari Kumar Vemula
Grouped logging or dump related test cases to test-dump category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/test/test/meson.build b/test/test/meson.build index b3a9e7ef9..f6ba600b7 100644 -

[dpdk-dev] [PATCH 0/5] create different meson test targets

2018-09-21 Thread Hari Kumar Vemula
1/5: remove existing test cases to reorganize further 2/5: add test-fast suite to meson targets 3/5: add test-perf suite to meson targets 4/5: add test-driver suite to meson targets 5/5: add test-dump suite to meson targets 2/5, 3/5, 4/5, 5/5 are needed to execute unit test from meson Hari Kumar

[dpdk-dev] [PATCH 3/5] test: add performance tests under test-perf suite

2018-09-21 Thread Hari Kumar Vemula
Grouped performace test cases under test-perf category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 34 ++ 1 file changed, 34 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index 087d635e1..edda0b5b7 100644 --- a/test/tes

[dpdk-dev] [PATCH 2/5] test: add quick run tests under test-fast suite

2018-09-21 Thread Hari Kumar Vemula
Added test cases that runs quickly under test fast category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 89 +++ 1 file changed, 83 insertions(+), 6 deletions(-) diff --git a/test/test/meson.build b/test/test/meson.build index a364

[dpdk-dev] [PATCH 1/5] test: remove existing testcases for categorization

2018-09-21 Thread Hari Kumar Vemula
Removed testcase list from meson build to categorize testcases into suites Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 104 -- 1 file changed, 104 deletions(-) diff --git a/test/test/meson.build b/test/test/meson.build index b1dd6

Re: [dpdk-dev] [PATCH v2 01/21] net/atlantic: atlantic PMD driver skeleton

2018-09-21 Thread Igor Russkikh
Hi Ferruh, Thanks for your comments! All understood, we'll fix that in next version. Another question related to new PMDs integration process: I have not found any requirements or statements on passing/supporting DPDK Test Suite for new PMDs. Do you have any expectations here? BR, Igor

Re: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front to jump over ntuple filter case

2018-09-21 Thread Zhang, Qi Z
Hi Faicker: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of faicker.mo > Sent: Tuesday, September 18, 2018 1:49 PM > To: dev@dpdk.org > Cc: faicker.mo > Subject: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front to jump over > ntuple filter case > > From

Re: [dpdk-dev] [PATCH v1] testpmd: eeprom display

2018-09-21 Thread Ferruh Yigit
On 9/18/2018 9:59 AM, Gaetan Rivet wrote: > The interactive command > > show port eeprom > > will dump the content of the EEPROM for the selected port. > Dumping eeprom of all ports at once is not supported. > > Signed-off-by: Gaetan Rivet <...> > +void > +port_eeprom_display(portid_t port

[dpdk-dev] [PATCH v3 1/2] net/failsafe: remove not supported multicast MAC filter

2018-09-21 Thread Andrew Rybchenko
From: Evgeny Im set_mc_addr_list method is not implemented by the driver yet. Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Cc: sta...@dpdk.org Signed-off-by: Evgeny Im Signed-off-by: Andrew Rybchenko --- doc/guides/nics/features/failsafe.ini | 1 - 1 file changed, 1 deletion(-) d

[dpdk-dev] [PATCH v3 0/2] net/failsafe: support multicast MAC address set

2018-09-21 Thread Andrew Rybchenko
v3: - move apply on sync to fs_eth_dev_conf_apply() to apply to a new subdevice only - use ethdev API to apply to sub-device on sync - remove unnecessary check the same pointer from the method implementation in failsafe v2: - fix setting of zero addresses since rte_real

[dpdk-dev] [PATCH v3 2/2] net/failsafe: support multicast address list set

2018-09-21 Thread Andrew Rybchenko
From: Evgeny Im Signed-off-by: Evgeny Im Signed-off-by: Andrew Rybchenko --- doc/guides/nics/features/failsafe.ini | 1 + doc/guides/rel_notes/release_18_11.rst | 1 + drivers/net/failsafe/failsafe.c | 1 + drivers/net/failsafe/failsafe_ether.c | 17 + drivers/net/fails

[dpdk-dev] [PATCH v3 0/2] net/failsafe: support multicast MAC address set

2018-09-21 Thread Andrew Rybchenko
v3: - move apply on sync to fs_eth_dev_conf_apply() to apply to a new subdevice only - use ethdev API to apply to sub-device on sync - remove unnecessary check the same pointer from the method implementation in failsafe v2: - fix setting of zero addresses since rte_real

Re: [dpdk-dev] Incorrect latencystats implementation

2018-09-21 Thread Pattan, Reshma
Hi, > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, September 21, 2018 1:14 PM > To: Pattan, Reshma ; long...@viettel.com.vn > Cc: dev@dpdk.org > Subject: RE: Incorrect latencystats implementation > > Hi Reshma, > > > -Original Message- > > From: dev [mailto:dev-

[dpdk-dev] [PATCH v2 6/6] crypto/mvsam: add 3DES ECB to the capabilities list

2018-09-21 Thread Andrzej Ostruszka
From: Tomasz Duszynski 3DES in ECB mode is supported by the PMD thus specific entry should exist in the crypto PMD capabilities list. Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 20 1 file changed, 20 inserti

[dpdk-dev] [PATCH v2 3/6] crypto/mvsam: support for HMAC SHA224

2018-09-21 Thread Andrzej Ostruszka
From: Tomasz Duszynski Add support for the HMAC SHA224 authentication algorithm. Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 3 +++ drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 21 + 2 files changed, 24 insertio

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/sfc: fix an Rx queue double release possibility

2018-09-21 Thread Ferruh Yigit
On 9/14/2018 8:31 AM, Andrew Rybchenko wrote: > From: Igor Romanov > > There are two function that call sfc_rx_qfini(): > sfc_rx_fini_queues() and sfc_rx_queue_release(). But only > sfc_rx_queue_release() sets rx_queues pointer of the device data to NULL. > It may lead to the scenario in which a

[dpdk-dev] [PATCH v2 4/6] crypto/mvsam: support for AES ECB

2018-09-21 Thread Andrzej Ostruszka
From: Tomasz Duszynski Add support for AES128/192/256 in ECB mode. Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 5 + drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 20 2 files changed, 25 insertions(+) diff -

[dpdk-dev] [PATCH v2 5/6] crypto/mvsam: support for crypto/auth NULL algorithms

2018-09-21 Thread Andrzej Ostruszka
From: Tomasz Duszynski Add support for both cipher and auth NULL algorithms. Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 6 + drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 45 + 2 files changed, 5

[dpdk-dev] [PATCH v2 2/6] crypto/mvsam: update hash digest sizes

2018-09-21 Thread Andrzej Ostruszka
From: Szymon Sliwa Update hash digest sizes to match hardware capabilities. Cc: sta...@dpdk.org Signed-off-by: Szymon Sliwa Reviewed-by: Yelena Krivosheev Reviewed-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 46 - 1 file changed, 23 ins

[dpdk-dev] [PATCH v2 1/6] crypto/mvsam: fix shared library build

2018-09-21 Thread Andrzej Ostruszka
From: Tomasz Duszynski Add missing rte_kvargs library dependency. Without that shared library build fails due to unresolved rte_kvargs_* symbols. Fixes: 25b05a1c806b ("crypto/mvsam: parse max number of sessions") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Tomasz Duszy

[dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes

2018-09-21 Thread Andrzej Ostruszka
This patch series introduces following changes: * Add support for HMAC SHA224, AES ECB and NULL algorithms. * Update hash digest sizes to match hardware capabilities. * Fix a shared build. v2: * added Cc: sta...@dpdk.org to couple of patches * rephrased the subject/commit msgs Szymon Sliwa (

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-21 Thread Thomas Monjalon
21/09/2018 15:47, Ferruh Yigit: > On 9/20/2018 1:18 AM, Thomas Monjalon wrote: > > When trying to include stdbool.h in DPDK base headers, there are a lot > > of conflicts with drivers which redefine bool/true/false > > in their compatibility layer. > > > > It is fixed by including stdbool.h in the

Re: [dpdk-dev] [PATCH 3/6] crypto/mvsam: add support for HMAC SHA224

2018-09-21 Thread Andrzej Ostruszka
On 17.09.2018 15:57, Akhil Goyal wrote: > Hi Tomasz, > > On 8/24/2018 7:24 PM, Tomasz Duszynski wrote: >> Add support for the HMAC SHA224 authentication algorithm. [...] >> { /* SHA224 */ >> .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC, >> {.sym = { > doc shall also be u

Re: [dpdk-dev] [PATCH 4/6] crypto/mvsam: add support for AES ECB

2018-09-21 Thread Andrzej Ostruszka
Akhil This is ECB mode so AFAIU there is no need for IV as this is not feed forward/back type of algo and there is nothing extra needed by the first block (same thing in ccp driver). I'm leaving this as it is (same for 3DES). On 17.09.2018 15:59, Akhil Goyal wrote: > On 8/24/2018 7:24 PM, Tomasz

Re: [dpdk-dev] [PATCH v4 0/3] AVF build improvements

2018-09-21 Thread Zhang, Qi Z
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, September 19, 2018 6:04 PM > To: Wu, Jingjing ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh > ; Richardson, Bruce > Subject: [PATCH v4 0/3] AVF build improvements > > This set adds a number of build im

Re: [dpdk-dev] [PATCH v2 00/21] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver

2018-09-21 Thread Kevin Traynor
On 09/13/2018 01:22 PM, Igor Russkikh wrote: > Hello DPDK community! > > Aquantia would like to contribute PMD for aQtion AQC10X NIC family: > https://www.aquantia.com/products/aqtion/chips/ > These are 10G ethernet NICs with various features. > > We do base this work on parts of the existing nat

Re: [dpdk-dev] [PATCH v1] e1000: support dev reset

2018-09-21 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Tuesday, September 18, 2018 4:57 PM > To: dev@dpdk.org > Cc: Gaetan Rivet > Subject: [dpdk-dev] [PATCH v1] e1000: support dev reset > > Add support for passive device reset on IGB ports. >

Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update

2018-09-21 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Wednesday, September 12, 2018 4:29 PM > To: Ilya Maximets ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Laurent Hardy > ; Dai, Wei ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH] net/fm10k: add imissed stats

2018-09-21 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Xiao W > Sent: Tuesday, September 11, 2018 9:52 AM > To: Julien Meunier ; Zhang, Qi Z > > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/fm10k: add imissed stats > > Hi, > > -Original Message- > From: Julien Meunier [mailto:julien.meun...@nokia.

Re: [dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilities

2018-09-21 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Thursday, September 20, 2018 7:30 AM > To: Didier Pallard ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilities > > > > > -Original Message

Re: [dpdk-dev] [PATCH v2 01/21] net/atlantic: atlantic PMD driver skeleton

2018-09-21 Thread Ferruh Yigit
On 9/13/2018 12:35 PM, Igor Russkikh wrote: > From: Pavel Belous > > Makefile/meson build infrastructure, atl_ethdev minimal skeleton, > header with aquantia aQtion NIC device and vendor IDs. > > Signed-off-by: Igor Russkikh > --- > config/common_base| 9 + >

Re: [dpdk-dev] [PATCH v2 00/21] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver

2018-09-21 Thread Ferruh Yigit
On 9/13/2018 1:22 PM, Igor Russkikh wrote: > Hello DPDK community! > > Aquantia would like to contribute PMD for aQtion AQC10X NIC family: > https://www.aquantia.com/products/aqtion/chips/ > These are 10G ethernet NICs with various features. > > We do base this work on parts of the existing nativ

Re: [dpdk-dev] [PATCH v6 00/11] implement packed virtqueues

2018-09-21 Thread Jens Freimann
On Fri, Sep 21, 2018 at 08:32:22PM +0800, Tiwei Bie wrote: On Fri, Sep 21, 2018 at 12:32:57PM +0200, Jens Freimann wrote: This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs

Re: [dpdk-dev] [PATCH] net/i40e: update Rx checksum offload

2018-09-21 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, September 21, 2018 4:16 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: update Rx checksum offload > > > > > -Original Message- > > From: dev [mailto:dev-boun..

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-21 Thread Ferruh Yigit
On 9/20/2018 1:18 AM, Thomas Monjalon wrote: > When trying to include stdbool.h in DPDK base headers, there are a lot > of conflicts with drivers which redefine bool/true/false > in their compatibility layer. > > It is fixed by including stdbool.h in these drivers. > Some errors with usage of bool

Re: [dpdk-dev] [PATCH v3 0/8] Add Marvell NETA PMD

2018-09-21 Thread Ferruh Yigit
On 9/21/2018 12:59 PM, Andrzej Ostruszka wrote: > On 19.09.2018 19:39, Ferruh Yigit wrote: >> On 9/19/2018 4:07 PM, Andrzej Ostruszka wrote: >>> On 14.09.2018 18:20, Ferruh Yigit wrote: > [...] Can you also set a web page patch to add new hardware to supported hw list: http://core.dpdk.or

Re: [dpdk-dev] [PATCH v2 3/3] net/enetc: enable Rx and Tx

2018-09-21 Thread Ferruh Yigit
On 9/13/2018 10:42 AM, Gagandeep Singh wrote: > Add RX and TX queue setup, datapath functions > and enable the packet parsing > > Signed-off-by: Gagandeep Singh <...> > -LDLIBS += -lrte_eal > +LDLIBS += -lrte_eal -lrte_mempool > LDLIBS += -lrte_ethdev > LDLIBS += -lrte_bus_pci Isn't mbuf and

Re: [dpdk-dev] [PATCH v2 2/3] net/enetc: add ENETC PMD with basic operations

2018-09-21 Thread Ferruh Yigit
On 9/13/2018 10:42 AM, Gagandeep Singh wrote: > This patch introduces the enetc PMD with basic > initialisation functions includes probe, teardown, > hardware initialisation > > Signed-off-by: Gagandeep Singh <...> > @@ -0,0 +1,24 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2018

  1   2   >