Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

Hi Chas From: Chas Williams [mailto:3ch...@gmail.com] On Thu, Aug 2, 2018 at 1:33 > PM Matan Azrad wrote: > > > > > I suggest to do it like next, > > > To add one more parameter for LACP which means how to configure the > > LACP MC group - lacp_mc_grp_conf: > > > 1. rte_flow. > > > 2. flow direc

[dpdk-dev] [PATCH v2 2/2] net/bnx2x: bump PMD version to 1.0.6.1

Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 9cb9f21..642d03a 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -31,7 +31,7 @@ #d

[dpdk-dev] [PATCH v2 1/2] net/bnx2x: fix to poll link status

The PMD has been modified to invoke the polling function in the link management code which detects the peer speed/mode, configure the link and update the status accordingly. This patch is the fix for the link down issue seen when we do dev_stop() and dev_start() from an application. Fixes: 540a211

Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix to poll link status

Hi Thomas, >From: Thomas Monjalon >Sent: Thursday, August 02, 2018 12:58 PM > >Hi, > >There is a compilation error with this patch: > Sending v2 series to address it, please apply. Thanks! -Rasesh >25/07/2018 00:25, Rasesh Mody: >> + PMD_DRV_LOG(ERR, sc, "Unable to start

Re: [dpdk-dev] [PATCH v2] vhost: flush IOTLB cache on new mem table handling

On Thu, Aug 02, 2018 at 07:21:22PM +0200, Maxime Coquelin wrote: > IOTLB entries contain the host virtual address of the guest > pages. When receiving a new VHOST_USER_SET_MEM_TABLE request, > the previous regions get unmapped, so the IOTLB entries, if any, > will be invalid. It does cause the vhos

Re: [dpdk-dev] [PATCH] net/i40e: stop lldp before setting local lldp MIB

From: Chas Williams [mailto:3ch...@gmail.com] Sent: Friday, August 3, 2018 5:20 AM To: Zhang, Qi Z Cc: dev@dpdk.org; Xing, Beilei ; Chas Williams Subject: Re: [PATCH] net/i40e: stop lldp before setting local lldp MIB On Wed, Aug 1, 2018 at 10:16 PM Zhang, Qi Z mailto:qi.z.zh...@intel.com>>

Re: [dpdk-dev] [PATCH] eal/bsd: silence not supported error in interrupts

-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anatoly Burakov Sent: Friday, July 27, 2018 4:25 PM To: dev@dpdk.org Cc: Richardson, Bruce ; tho...@monjalon.net; Wu, ChangqingX Subject: [dpdk-dev] [PATCH] eal/bsd: silence not supported error in interrupts Curre

Re: [dpdk-dev] [PATCH] test: fix ethdev config offloads in bond unit test

-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Reshma Pattan Sent: Wednesday, August 1, 2018 8:19 PM To: dev@dpdk.org; Nicolau, Radu; Doherty, Declan Cc: Pattan, Reshma Subject: [dpdk-dev] [PATCH] test: fix ethdev config offloads in bond unit test From: Reshma Pa

Re: [dpdk-dev] [PATCH] net/i40e: stop lldp before setting local lldp MIB

On Wed, Aug 1, 2018 at 10:16 PM Zhang, Qi Z wrote: > > > > > *From:* Chas Williams [mailto:3ch...@gmail.com] > *Sent:* Wednesday, August 1, 2018 11:31 PM > *To:* Zhang, Qi Z > *Cc:* dev@dpdk.org; Xing, Beilei ; Chas Williams < > ch...@att.com> > *Subject:* Re: [PATCH] net/i40e: stop lldp before

Re: [dpdk-dev] [PATCH v2 1/2] net/bonding: in 8023ad mode enable all multicast rather than promiscuous

On Thu, Aug 2, 2018 at 6:03 AM Radu Nicolau wrote: > Signed-off-by: Radu Nicolau > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c > b/drivers/net/bonding/rte_eth_bond_802

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

On Thu, Aug 2, 2018 at 1:33 PM Matan Azrad wrote: > Hi Declan > > From: Doherty, Declan > > On 02/08/2018 3:24 PM, Matan Azrad wrote: > > > Hi > > > > > > From: Doherty, Declan > > >> On 02/08/2018 7:35 AM, Matan Azrad wrote: > > >>> Hi Chas, Radu > > >>> > > >>> From: Chas Williams > > On W

[dpdk-dev] [PATCH v2 2/2] net/mlx5: preserve allmulti flag for flow isolation mode

mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling allmulti mode as it can't be enabled in flow isolation mode. If the function pointers are null, librte APIs such as rte_eth_allmulticast_enable/disable() fail to set the flag (dev->data->all_multicast). The flag is used when starting tra

[dpdk-dev] [PATCH v2 1/2] net/mlx5: preserve promisc flag for flow isolation mode

mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling promiscuous mode as it can't be enabled in flow isolation mode. If the function pointers are null, librte APIs such as rte_eth_promiscuous_enable/disable() fail to set the flag (dev->data->promiscuous). The flag is used when starting tra

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

On Thu, Aug 2, 2018 at 10:24 AM Matan Azrad wrote: > Hi > > From: Doherty, Declan > > On 02/08/2018 7:35 AM, Matan Azrad wrote: > > > Hi Chas, Radu > > > > > > From: Chas Williams > > >> On Wed, Aug 1, 2018 at 9:48 AM Radu Nicolau > > >> wrote: > > >> > > >>> > > >>> > > >>> On 8/1/2018 2:34 PM,

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: preserve promisc flag for flow isolation mode

> On Aug 2, 2018, at 1:58 PM, Yongseok Koh wrote: > > mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling promiscuous > mode as it can't be enabled in flow isolation mode. If the function > pointers are null, librte APIs such as rte_eth_promiscuous_enable/disable() > fail to set the f

[dpdk-dev] [PATCH] net/mlx5: fix minimum number of Multi-Packet RQ buffers

If MPRQ is enabled, a PMD-private mempool is allocated. For ConnectX-4 Lx, the minimum number of strides is 512 which ConnectX-5 supports 8. This results in quite small number of elements for the MPRQ mempool. For example, if the size of Rx ring is configured as 512, only one MPRQ buffer can cover

[dpdk-dev] [PATCH 2/2] net/mlx5: preserve allmulti flag for flow isolation mode

mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling allmulti mode as it can't be enabled in flow isolation mode. If the function pointers are null, librte APIs such as rte_eth_allmulticast_enable/disable() fail to set the flag (dev->data->all_multicast). The flag is used when starting tra

[dpdk-dev] [PATCH 1/2] net/mlx5: preserve promisc flag for flow isolation mode

mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling promiscuous mode as it can't be enabled in flow isolation mode. If the function pointers are null, librte APIs such as rte_eth_promiscuous_enable/disable() fail to set the flag (dev->data->promiscuous). The flag is used when starting tra

[dpdk-dev] [PATCH] net/mlx5: prohibit wildcard match for GRE protocol

Currently, driver sets full mask (0x) for GRE protocol to device. Until it is changed, PMD can't support wildcard match. Fixes: f4b901a46aec ("net/mlx5: add flow GRE item") Cc: sta...@dpdk.org Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 8 ++-- 1 file changed, 6 inser

Re: [dpdk-dev] [PATCH] net/bnx2x: fix FW cmd timeout duting device stop

01/08/2018 20:19, Rasesh Mody: > This patch fixes firmware command timeout error seen during device stop > while stopping queues. It patially reverts an earlier preventive change > commit 91b7e432bcef ("net/bnx2x: disable fast path interrupts") to now > enable fast path interrupts. > > The origina

Re: [dpdk-dev] [PATCH 1/2] net/bnx2x: fix to poll link status

Hi, There is a compilation error with this patch: 25/07/2018 00:25, Rasesh Mody: > + PMD_DRV_LOG(ERR, sc, "Unable to start periodic" > +" timer rc %d", ret); drivers/net/bnx2x/bnx2x_ethdev.c:153:21: error: expected ‘)’ before ‘sc’

Re: [dpdk-dev] [PATCH 1/4] net/qede: fix handler in interrupt callback unregister

25/07/2018 00:18, Rasesh Mody: > From: Shahed Shaikh > > Commit 023d7a0449f11 ("net/qede: fix legacy interrupt mode") > added a handler for legacy interrupt mode but forgot to > unregister same handler in rte_intr_callback_unregister() > > Fixes: 245aec289338 ("net/qede: fix legacy interrupt mod

[dpdk-dev] [PATCH v2] ethdev: decrease log level for successful API

Change log level of messages from ERR to INFO where the post condition of the API is success, but no action was actually needed as the condition already existed. e.g. calling rte_eth_dev_start() for a device that is already started. Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dy

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

subject prefix not updated - will resend as [PATCH v2] On 08/02/2018 07:33 PM, Kevin Traynor wrote: > Change log level of messages from ERR to INFO where > the post condition of the API is success, but no action > was actually needed as the condition already existed. > e.g. calling rte_eth_dev_sta

[dpdk-dev] [PATCH] ethdev: decrease log level for successful API

Change log level of messages from ERR to INFO where the post condition of the API is success, but no action was actually needed as the condition already existed. e.g. calling rte_eth_dev_start() for a device that is already started. Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dy

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

On 08/02/2018 07:01 PM, Andrew Rybchenko wrote: > On 02.08.2018 19:14, Thomas Monjalon wrote: >> 02/08/2018 16:52, Kevin Traynor: >>> On 08/02/2018 03:41 PM, Andrew Rybchenko wrote: On 02.08.2018 17:09, Kevin Traynor wrote: > On 08/02/2018 02:52 PM, Andrew Rybchenko wrote: >> On 02.08.

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

On 02.08.2018 19:14, Thomas Monjalon wrote: 02/08/2018 16:52, Kevin Traynor: On 08/02/2018 03:41 PM, Andrew Rybchenko wrote: On 02.08.2018 17:09, Kevin Traynor wrote: On 08/02/2018 02:52 PM, Andrew Rybchenko wrote: On 02.08.2018 16:35, Kevin Traynor wrote: On 08/02/2018 01:59 PM, Andrew Rybc

Re: [dpdk-dev] [PATCH] net/tap: fix zeroed flow mask configurations

Hi Adrien From: Adrien Mazarguil > On Thu, Aug 02, 2018 at 10:33:00AM +, Matan Azrad wrote: > > The rte_flow meaning of zero flow mask configuration is to match all > > the range of the item value. > > For example, the flow eth / ipv4 dst spec 1.2.3.4 dst mask 0.0.0.0 > > should much all the i

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

Hi Declan From: Doherty, Declan > On 02/08/2018 3:24 PM, Matan Azrad wrote: > > Hi > > > > From: Doherty, Declan > >> On 02/08/2018 7:35 AM, Matan Azrad wrote: > >>> Hi Chas, Radu > >>> > >>> From: Chas Williams > On Wed, Aug 1, 2018 at 9:48 AM Radu Nicolau > wrote: > > > > >>>

[dpdk-dev] [PATCH v2] vhost: flush IOTLB cache on new mem table handling

IOTLB entries contain the host virtual address of the guest pages. When receiving a new VHOST_USER_SET_MEM_TABLE request, the previous regions get unmapped, so the IOTLB entries, if any, will be invalid. It does cause the vhost-user process to segfault. This patch introduces a new function to flus

Re: [dpdk-dev] [PATCH] vhost: flush IOTLB cache on new mem table handling

On 08/02/2018 07:09 PM, Stephen Hemminger wrote: On Thu, 2 Aug 2018 18:37:27 +0200 Maxime Coquelin wrote: +void +vhost_user_iotlb_flush_all(struct vhost_virtqueue *vq) +{ + vhost_user_iotlb_cache_remove_all(vq); + vhost_user_iotlb_pending_remove_all(vq); +} +

Re: [dpdk-dev] [PATCH] vhost: flush IOTLB cache on new mem table handling

On Thu, 2 Aug 2018 18:37:27 +0200 Maxime Coquelin wrote: > > +void > +vhost_user_iotlb_flush_all(struct vhost_virtqueue *vq) > +{ > + vhost_user_iotlb_cache_remove_all(vq); > + vhost_user_iotlb_pending_remove_all(vq); > +} > + Wrong indentation, you don't want two tabs

[dpdk-dev] [PATCH] app/crypto-perf: fix auth IV offset

Auth IV offset was not being set when creating the crypto session. Fixes: acf8616901b5 ("cryptodev: add auth IV") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- app/test-crypto-perf/cperf_ops.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-crypto-perf/cperf_ops.c b/app/t

[dpdk-dev] [PATCH] vhost: flush IOTLB cache on new mem table handling

IOTLB entries contain the host virtual address of the guest pages. When receiving a new VHOST_USER_SET_MEM_TABLE request, the previous regions get unmapped, so the IOTLB entries, if any, will be invalid. It does cause the vhost-user process to segfault. This patch introduces a new function to flus

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

02/08/2018 16:52, Kevin Traynor: > On 08/02/2018 03:41 PM, Andrew Rybchenko wrote: > > On 02.08.2018 17:09, Kevin Traynor wrote: > >> On 08/02/2018 02:52 PM, Andrew Rybchenko wrote: > >>> On 02.08.2018 16:35, Kevin Traynor wrote: > On 08/02/2018 01:59 PM, Andrew Rybchenko wrote: > > On 02.

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

On 02/08/2018 3:24 PM, Matan Azrad wrote: Hi From: Doherty, Declan On 02/08/2018 7:35 AM, Matan Azrad wrote: Hi Chas, Radu From: Chas Williams On Wed, Aug 1, 2018 at 9:48 AM Radu Nicolau wrote: On 8/1/2018 2:34 PM, Chas Williams wrote: On Wed, Aug 1, 2018 at 9:04 AM Radu Nicolau wro

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

On Thu, 2 Aug 2018 13:33:43 +0100 Kevin Traynor wrote: > Change log level of messages from ERR back to DEBUG where > existing API indicates that the condition is a success. > > This means applications using the API in its current form will > not get new ERR logs. > > Fixes: bea1e0c70cfc ("ethd

[dpdk-dev] [PATCH 0/2] common/qat: handle offset greater than first sgl segment

This patchset fixes buffer lengths and SGL filling to handle offset greater than first SGL segment. Tomasz Jozwiak (2): compress/qat: fix buffer lengths in offset case common/qat: fix offset greater than first sgl segment drivers/common/qat/qat_common.c | 77 +---

[dpdk-dev] [PATCH 1/2] compress/qat: fix buffer lengths in offset case

Fixed lengths for src and dest buffers Fixes: 32842f2a6d7d ("compress/qat: create FW request and process response") Signed-off-by: Tomasz Jozwiak Acked-by: Fiona Trahe --- drivers/compress/qat/qat_comp.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/compre

[dpdk-dev] [PATCH 2/2] common/qat: fix offset greater than first sgl segment

This patch fixes sgl filling to handle offset greater than first sgl segment Fixes: 1947bd18580b ("compress/qat: support scatter-gather buffers") Signed-off-by: Tomasz Jozwiak Acked-by: Fiona Trahe --- drivers/common/qat/qat_common.c | 77 + drivers/comm

Re: [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

On Thursday, August 08/02/18, 2018 at 05:05:34 +0530, Jack Min wrote: > > -Original Message- > > From: Rahul Lakkireddy > > Sent: July 10, 2018 21:14 > > To: Adrien Mazarguil > > Cc: Jack Min ; dev@dpdk.org; Shagun Agarwal > > ; Indranil Choudhury ; Nirranjan > > Kirubaharan ; Shahaf Shul

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

On 08/02/2018 03:41 PM, Andrew Rybchenko wrote: > On 02.08.2018 17:09, Kevin Traynor wrote: >> On 08/02/2018 02:52 PM, Andrew Rybchenko wrote: >>> On 02.08.2018 16:35, Kevin Traynor wrote: On 08/02/2018 01:59 PM, Andrew Rybchenko wrote: > On 02.08.2018 15:33, Kevin Traynor wrote: >> Ch

[dpdk-dev] [PATCH v2] event: fix check in ring init() in event ring code

This commit fixes a bug in a 32-bit environment where the generic ring_init() would fail, but given the interaction with memzones the next iteration of the event_ring_autotest would actually *pass* because the ring in question would exist already an be looked-up. This commit rightly error checks t

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

On 02.08.2018 17:09, Kevin Traynor wrote: On 08/02/2018 02:52 PM, Andrew Rybchenko wrote: On 02.08.2018 16:35, Kevin Traynor wrote: On 08/02/2018 01:59 PM, Andrew Rybchenko wrote: On 02.08.2018 15:33, Kevin Traynor wrote: Change log level of messages from ERR back to DEBUG where existing API

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix bitmap documentation

> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, August 1, 2018 4:56 PM > To: Dumitrescu, Cristian > Cc: sta...@dpdk.org; Jerin Jacob ; > dev@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] eal: fix bitmap documentation > > Cristian,

Re: [dpdk-dev] [PATCH] net/tap: fix zeroed flow mask configurations

On Thu, Aug 02, 2018 at 10:33:00AM +, Matan Azrad wrote: > The rte_flow meaning of zero flow mask configuration is to match all > the range of the item value. > For example, the flow eth / ipv4 dst spec 1.2.3.4 dst mask 0.0.0.0 > should much all the ipv4 traffic from the rte_flow API perspectiv

[dpdk-dev] [PATCH] kni: dynamically allocate memory for each KNI

Long time ago preallocation of memory for KNI was introduced in commit 0c6bc8e. It was done because of lack of ability to free previously allocated memzones, which led to memzone exhaustion. Currently memzones can be freed and this patch uses this ability for dynamic KNI memory allocation. Signed-

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

Hi From: Doherty, Declan > On 02/08/2018 7:35 AM, Matan Azrad wrote: > > Hi Chas, Radu > > > > From: Chas Williams > >> On Wed, Aug 1, 2018 at 9:48 AM Radu Nicolau > >> wrote: > >> > >>> > >>> > >>> On 8/1/2018 2:34 PM, Chas Williams wrote: > >>> > >>> > >>> > >>> On Wed, Aug 1, 2018 at 9:04 AM R

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

On 08/02/2018 02:52 PM, Andrew Rybchenko wrote: > On 02.08.2018 16:35, Kevin Traynor wrote: >> On 08/02/2018 01:59 PM, Andrew Rybchenko wrote: >>> On 02.08.2018 15:33, Kevin Traynor wrote: Change log level of messages from ERR back to DEBUG where existing API indicates that the condition

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

On 02.08.2018 16:35, Kevin Traynor wrote: On 08/02/2018 01:59 PM, Andrew Rybchenko wrote: On 02.08.2018 15:33, Kevin Traynor wrote: Change log level of messages from ERR back to DEBUG where existing API indicates that the condition is a success. This means applications using the API in its cur

Re: [dpdk-dev] [PATCH v5] net/bonding: fix slave add for mode 4

On 18/07/2018 2:21 PM, Radu Nicolau wrote: Moved the link status validity check from the slave add to the slave activation step. Otherwise slave add will fail for mode 4 if the ports are all stopped but only one of them checked. Removed activate slave call from slave add function. Fixes: b77d21

Re: [dpdk-dev] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

On 01/08/2018 2:18 PM, Radu Nicolau wrote: When a bonding port is stopped also stop and deactivate all slaves. Otherwise slaves will be still listed as active. Fixes: 69bce062132b ("net/bonding: do not clear active slave count") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

On 08/02/2018 01:59 PM, Andrew Rybchenko wrote: > On 02.08.2018 15:33, Kevin Traynor wrote: >> Change log level of messages from ERR back to DEBUG where >> existing API indicates that the condition is a success. >> >> This means applications using the API in its current form will >> not get new ERR

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

On 02/08/2018 7:35 AM, Matan Azrad wrote: Hi Chas, Radu From: Chas Williams On Wed, Aug 1, 2018 at 9:48 AM Radu Nicolau wrote: On 8/1/2018 2:34 PM, Chas Williams wrote: On Wed, Aug 1, 2018 at 9:04 AM Radu Nicolau wrote: Update the bonding promiscuous mode enable/disable functions as

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

On 02.08.2018 15:33, Kevin Traynor wrote: Change log level of messages from ERR back to DEBUG where existing API indicates that the condition is a success. This means applications using the API in its current form will not get new ERR logs. Fixes: bea1e0c70cfc ("ethdev: convert static log type

Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API

On 02.08.2018 15:33, Kevin Traynor wrote: Change log level of messages from ERR back to DEBUG where existing API indicates that the condition is a success. This means applications using the API in its current form will not get new ERR logs. Fixes: bea1e0c70cfc ("ethdev: convert static log type

[dpdk-dev] [PATCH] crypto/aesni_mb: fix possible array overrun

In order to process crypto operations in the AESNI MB PMD, they need to be sent to the buffer manager of the Multi-buffer library, through the "job" structure. Currently, it is checked if there are outstanding operations to process in the ring, before getting a new job. However, if there are no av

Re: [dpdk-dev] [PATCH] net/mlx5: fix VLAN ID matching on switch flow rules

Thursday, August 2, 2018 12:25 PM, Adrien Mazarguil: > Subject: [PATCH] net/mlx5: fix VLAN ID matching on switch flow rules > > VLAN ID is not properly translated to TC due to swapped byte order. > > Fixes: fdc4d0f4c7e1 ("net/mlx5: add VLAN item and actions to switch flow > rules") > > Signed-of

Re: [dpdk-dev] [PATCH] net/mlx5: fix VLAN POP action on switch flow rules

Thursday, August 2, 2018 1:21 PM, Adrien Mazarguil: > Subject: [PATCH] net/mlx5: fix VLAN POP action on switch flow rules > > TC message for VLAN POP is broken due to an unfinished nested attribute. > > Fixes: fdc4d0f4c7e1 ("net/mlx5: add VLAN item and actions to switch flow > rules") > > Signed

Re: [dpdk-dev] [PATCH] event: fix check in ring_init() in event ring code

-Original Message- > Date: Thu, 2 Aug 2018 09:36:04 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: Harry van Haaren , > bruce.richard...@intel.com, sta...@dpdk.org, tho...@monjalon.net, > jerin.ja...@caviumnetworks.com > Subject: [PATCH] event: fix check in ring_init() in event

[dpdk-dev] [PATCH] ethdev: decrease log level for successful API

Change log level of messages from ERR back to DEBUG where existing API indicates that the condition is a success. This means applications using the API in its current form will not get new ERR logs. Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic") Signed-off-by: Kevin Tra

[dpdk-dev] DPDK Release Status Meeting 02/08/2018

DPDK Release Status Meeting 02/08/2018 == Minutes from the weekly DPDK Release Status Meeting. The DPDK Release Status Meeting is intended for DPDK Committers to discuss the status of the master tree and sub-trees, and for project managers to track progress or

Re: [dpdk-dev] [PATCH] net/tap: fix zeroed flow mask configurations

> On Aug 2, 2018, at 5:33 AM, Matan Azrad wrote: > > The rte_flow meaning of zero flow mask configuration is to match all > the range of the item value. > For example, the flow eth / ipv4 dst spec 1.2.3.4 dst mask 0.0.0.0 > should much all the ipv4 traffic from the rte_flow API perspective. >

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS flow configuration crash

Thursday, August 2, 2018 2:19 PM, Adrien Mazarguil: > Subject: Re: [PATCH v2] net/mlx5: fix RSS flow configuration crash > > On Thu, Aug 02, 2018 at 11:41:07AM +0300, Moti Haimovsky wrote: > > This commit fixes a segmentation fault observed when configuring > > mlx5 with RSS flow rule containing i

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS flow configuration crash

On Thu, Aug 02, 2018 at 11:41:07AM +0300, Moti Haimovsky wrote: > This commit fixes a segmentation fault observed when configuring > mlx5 with RSS flow rule containing invalid queues indices such as > negative numbers, queue numbers bigger than the number Rx queues the > PMD or has no queues at all

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS flow configuration crash

Thursday, August 2, 2018 11:41 AM, Mordechay Haimovsky: > Subject: [PATCH v2] net/mlx5: fix RSS flow configuration crash > > This commit fixes a segmentation fault observed when configuring > mlx5 with RSS flow rule containing invalid queues indices such as negative > numbers, queue numbers bigger

Re: [dpdk-dev] [PATCH v2] mempool: check for invalid args on creation

On 02.08.2018 03:35, Pablo de Lara wrote: Currently, a mempool can be created if the number of objects is zero. However, in this scenario, rte_mempool_create should return NULL, as the mempool created is useless otherwise. Signed-off-by: Pablo de Lara Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix secondary process resource leakage

Wednesday, August 1, 2018 11:01 AM, Shahaf Shuler: > Subject: RE: [dpdk-dev] [PATCH v1] net/mlx5: fix secondary process resource > leakage > > Hi Ophir, > > Wednesday, August 1, 2018 1:38 AM, Ophir Munk: > > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix secondary process > > resource leakage > > >

Re: [dpdk-dev] [PATCH] net/mlx5: fix VLAN filtering

Tuesday, July 31, 2018 10:57 AM, Shahaf Shuler: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix VLAN filtering > > The below commit has added a graph based expansion logic for RSS rule to > satisfy Verbs requirements. With this logic, for example, the rule: > > flow create 0 ingress pattern eth / end

[dpdk-dev] [PATCH] net/tap: fix zeroed flow mask configurations

The rte_flow meaning of zero flow mask configuration is to match all the range of the item value. For example, the flow eth / ipv4 dst spec 1.2.3.4 dst mask 0.0.0.0 should much all the ipv4 traffic from the rte_flow API perspective. >From some kernel perspectives the above rule means to ignore all

Re: [dpdk-dev] [PATCH v2 1/2] net/bonding: in 8023ad mode enable all multicast rather than promiscuous

Hi Radu From: Radu Nicolau > Signed-off-by: Radu Nicolau > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c > b/drivers/net/bonding/rte_eth_bond_8023ad.c > index f8cea4b..7

[dpdk-dev] [PATCH] net/mlx5: fix VLAN POP action on switch flow rules

TC message for VLAN POP is broken due to an unfinished nested attribute. Fixes: fdc4d0f4c7e1 ("net/mlx5: add VLAN item and actions to switch flow rules") Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_nl_flow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5

Re: [dpdk-dev] [PATCH 0/5] bnxt patchset

26/07/2018 03:15, Ajit Khaparde: > This patchset against next-net fixes issues identified during QA testing. > Please apply. > > Ajit Khaparde (4): > net/bnxt: fix to free allocated memory > net/bnxt: fix to release lock when alloc fails in NVM write > net/bnxt: check access denied error for

Re: [dpdk-dev] [PATCH] test/test: properly clean up on exit

Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anatoly Burakov > Sent: Thursday, May 31, 2018 5:14 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] test/test: properly clean up on exit > > The test application didn't call rte_eal_cleanup() on exit, whic

[dpdk-dev] [PATCH v2 2/2] net/bonding: propagate promiscous mode in mode 4

Update the bonding promiscuous mode enable/disable functions as to propagate the change to all slaves instead of doing nothing. Signed-off-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_pmd.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/bonding/

[dpdk-dev] [PATCH v2 1/2] net/bonding: in 8023ad mode enable all multicast rather than promiscuous

Signed-off-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_8023ad.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index f8cea4b..730087f 100644 --- a/drivers/net/bonding/rte

Re: [dpdk-dev] [PATCH] net/cxgbevf: don't allocate control queues for VFs

26/07/2018 09:28, Rahul Lakkireddy: > From: Shagun Agrawal > > Control queues can not be allocated for VFs. So, add check to > only allocate control queues for PFs. This fixes adapter crash > when an attempt is made to allocate control queues for VFs. > > Fixes: 3a3aaabc ("net/cxgbe: add control

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

On Wednesday 01 August 2018 05:37 PM, Anatoly Burakov wrote: Due to the upcoming external memory support [1], some API and ABI changes will be required. In addition, although the changes called out in the deprecation notice are not yet present in form of code in the published RFC itself, they are

[dpdk-dev] [PATCH] net/mlx5: fix VLAN ID matching on switch flow rules

VLAN ID is not properly translated to TC due to swapped byte order. Fixes: fdc4d0f4c7e1 ("net/mlx5: add VLAN item and actions to switch flow rules") Signed-off-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_nl_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ne

Re: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Dai > Sent: Thursday, August 2, 2018 2:32 AM > To: Wu, Jingjing ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload > >

Re: [dpdk-dev] [PATCH] net/cxgbe: fix NULL deref in CLIP failure path

26/07/2018 10:19, Rahul Lakkireddy: > From: Shagun Agrawal > > Fixes: 3f2c1e20 ("net/cxgbe: add Compressed Local IP region") > Coverity issue: 302872 > > Signed-off-by: Shagun Agrawal > Signed-off-by: Rahul Lakkireddy Applied, thanks

Re: [dpdk-dev] [PATCH v4] doc: announce ethdev CRC strip flag deprecation

Wednesday, August 1, 2018 6:27 PM, Maxime Coquelin: > Subject: Re: [dpdk-dev] [PATCH v4] doc: announce ethdev CRC strip flag > deprecation > > > > On 04/17/2018 03:39 PM, Ferruh Yigit wrote: > > Make CRC stripping default behavior, deprecate flag > > DEV_RX_OFFLOAD_CRC_STRIP. > > > > Signed-off-

[dpdk-dev] [PATCH v2] mempool: check for invalid args on creation

Currently, a mempool can be created if the number of objects is zero. However, in this scenario, rte_mempool_create should return NULL, as the mempool created is useless otherwise. Signed-off-by: Pablo de Lara --- lib/librte_mempool/rte_mempool.c | 6 ++ 1 file changed, 6 insertions(+) diff

[dpdk-dev] [PATCH v2] net/mlx5: fix RSS flow configuration crash

This commit fixes a segmentation fault observed when configuring mlx5 with RSS flow rule containing invalid queues indices such as negative numbers, queue numbers bigger than the number Rx queues the PMD or has no queues at all. Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action") Cc: nelio.laran

[dpdk-dev] [PATCH] event: fix check in ring_init() in event ring code

This commit fixes a bug in a 32-bit environment where the generic ring_init() would fail, but given the interaction with memzones the next iteration of the event_ring_autotest would actually *pass* because the ring in question would exist already an be looked-up. This commit rightly error checks t

Re: [dpdk-dev] [PATCH v2] net/enic: reset the vxlan port during vNIC initialization

31/07/2018 23:26, John Daley: > From: Hyong Youb Kim > > The NIC persists the vxlan port number across vNIC init/de-init > (e.g. restart testpmd). So, explicitly reset the setting to the > default value (4789) as part of the initialization. > > Fixes: 8a4efd17410c ("net/enic: add handlers to add

Re: [dpdk-dev] [PATCH] net/enic: revert support for mbuf fast free offload

26/07/2018 04:30, John Daley: > From: Hyong Youb Kim > > This reverts the patch that enabled mbuf fast free. > > There are two main reasons. > > First, enic_fast_free_wq_bufs is broken. When > DEV_TX_OFFLOAD_MBUF_FAST_FREE is enabled, the driver calls this > function to free transmitted mbufs.

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

Hi everyone, > > > > > > > > In order to get this series accepted, we need more discussions > > > > with more people involved. > > > > So it will miss 18.08. > > > > > > > > It can be discussed in a more global discussion about examples > > > > maintenance. > > > > If discussion does not happen,

Re: [dpdk-dev] [PATCH 18.11 v2] pci/vfio: allow mapping MSI-X BARs if kernel allows it

On 02-Aug-18 7:47 AM, Takeshi Yoshimura wrote: 2018-07-31 20:28 GMT+09:00 Anatoly Burakov : Currently, DPDK will skip mapping some areas (or even an entire BAR) if MSI-X table happens to be in them but is smaller than page size. Kernels 4.16+ will allow mapping MSI-X BARs [1], and will report t

Re: [dpdk-dev] [PATCH] net/octeontx: fix stop clearing fastpath functions

> > On dev_stop the Rx/Tx_burst functions are being set to NULL, this causes > > a SEGFAULT in cases where control path calls stop and a paket is still > > being processed by a worker. > > Instead clear the fastpath functions in dev_close. > > > > Fixes: da6c687471a3 ("net/octeontx: add start and

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

On 08/01/2018 02:07 PM, Anatoly Burakov wrote: Due to the upcoming external memory support [1], some API and ABI changes will be required. In addition, although the changes called out in the deprecation notice are not yet present in form of code in the published RFC itself, they are based on c

Re: [dpdk-dev] [PATCH] mempool: check for invalid args on creation

On 01.08.2018 21:16, De Lara Guarch, Pablo wrote: Hi Andrew, -Original Message- From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Friday, July 20, 2018 4:49 PM To: De Lara Guarch, Pablo ; olivier.m...@6wind.com Cc: dev@dpdk.org Subject: Re: [PATCH] mempool: check for inval

[dpdk-dev] 回复: 回复: Re: Does lthread_cond_wait need a mutex?

Hi~ I would be appreciate it if you could provide your lthread code for me. I want to deep into the code. Regards, Wubenqing 发件人： wubenq...@ruijie.com.cn 发送时间： 2018-07-22 20:59 收件人： keith.wi...@intel.com

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix RSS

Tested-by: Peng, Yuan - Tested Commit: 23888166d99682b1491a917277e4ff0ff01639b2 - OS: 4.5.5-300.fc24.x86_64 - GCC: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Intel Corporation Device Fortville [8086:1583] - Default x86_64-native-linuxapp-gcc

Re: [dpdk-dev] [PATCH] ethdev: ownership change log message priority change

02/08/2018 08:40, Matan Azrad: > > From: Stephen Hemminger > > Changing ownership of a port is a normal event, and should not be logged at > > ERR priority. Downgrade to a DEBUG message. > > > > Signed-off-by: Stephen Hemminger > Acked-by: Matan Azrad Fixes: bea1e0c70cfc ("ethdev: convert stat