[dpdk-dev] [PATCH] net/i40e: fix max frame size checking

2018-07-25 Thread Yanglong Wu
No need to check max frame size in TX, the checking should be done in up layer protocal. This checking will lead to fail for TSO or other application cases. Fixes: bfeed0262b0c ("net/i40e: check illegal packets") Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_rxtx.c | 3 +-- 1 file change

[dpdk-dev] [PATCH v2] doc: add note for builtin-net-driver option

2018-07-25 Thread Marvin Liu
Option builtin-net-driver is used to demonstrate how to implement vhost-user driver based on vhost lib APIs. Unfortunately, very simple vhost driver in vhost sample is incompatible with QEMU as protocol feature not supported. Signed-off-by: Marvin Liu --- v2: * Updated descriptions. --- diff --gi

Re: [dpdk-dev] [PATCH v2] net/i40e: fix device arguments parsing error

2018-07-25 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Thursday, July 26, 2018 10:19 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Stillwell Jr, Paul M ; > sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix device arguments parsing error > > There's parsing error when using device argument supp

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix linkage error for glue lib

2018-07-25 Thread Shahaf Shuler
Wednesday, July 25, 2018 4:23 PM, Adrien Mazarguil: > Subject: Re: [PATCH v2] net/mlx5: fix linkage error for glue lib > > On Wed, Jul 25, 2018 at 04:18:54PM +0300, Shahaf Shuler wrote: > > From: Yaroslav Brustinov > > > > addressing a gcc 4.7.2 bug that cannot be reproduced with latter > > versi

Re: [dpdk-dev] [PATCH v3] examples/vhost: workaround qemu abort

2018-07-25 Thread Liu, Yong
> -Original Message- > From: Bie, Tiwei > Sent: Wednesday, July 25, 2018 2:39 PM > To: Liu, Yong > Cc: dev@dpdk.org > Subject: Re: [PATCH v3] examples/vhost: workaround qemu abort > > On Wed, Jul 25, 2018 at 06:25:56PM +0800, Marvin Liu wrote: > > Current qemu vhost net ring start has a

Re: [dpdk-dev] [PATCH] net/mlx5: fix count query when flow has not counters

2018-07-25 Thread Shahaf Shuler
Wednesday, July 25, 2018 8:25 PM, Yongseok Koh: > Subject: Re: [PATCH] net/mlx5: fix count query when flow has not counters > > > > On Jul 25, 2018, at 1:46 AM, Nelio Laranjeiro > wrote: > > > > Querying a counters on a flow without counter is ending with a > > segmentation fault. > > > > Fixes:

Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid network interface index value

2018-07-25 Thread Shahaf Shuler
Wednesday, July 25, 2018 8:05 PM, Yongseok Koh: > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid network interface > index value > > > > On Jul 25, 2018, at 4:24 AM, Adrien Mazarguil > wrote: > > > > Network interface indices being unsigned, an invalid index or error is > > normally expre

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix ixgbevf link status

2018-07-25 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Thursday, July 26, 2018 10:25 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Wang, Dong1 > ; Wu, Yanglong > Subject: [PATCH v3] net/ixgbe: fix ixgbevf link status > > ixgbevf can't get right link status unless it check PF link status in wait

[dpdk-dev] [PATCH] net/i40e: remove PF interrupt handler

2018-07-25 Thread Beilei Xing
Internal Rx interrupt/LSC/adminq share the same source, that will casue lots of CPU cycles wasted during receiving packets. So remove the PF interrupt handler just like i40e VF. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 64 +++--- 1 file

[dpdk-dev] [PATCH v3] net/ixgbe: fix ixgbevf link status

2018-07-25 Thread Yanglong Wu
ixgbevf can't get right link status unless it check PF link status in wait mode. Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF") Signed-off-by: Yanglong Wu --- v3: change to wait mode in ixgbevf --- v2: no need to set link status again --- drivers/net/ixgbe/ixgbe_ethdev.c | 3

[dpdk-dev] [PATCH] net/enic: revert support for mbuf fast free offload

2018-07-25 Thread John Daley
From: Hyong Youb Kim This reverts the patch that enabled mbuf fast free. There are two main reasons. First, enic_fast_free_wq_bufs is broken. When DEV_TX_OFFLOAD_MBUF_FAST_FREE is enabled, the driver calls this function to free transmitted mbufs. This function currently does not reset next and

[dpdk-dev] [PATCH v2] net/i40e: fix device arguments parsing error

2018-07-25 Thread Beilei Xing
There's parsing error when using device argument support-multi-driver or queue-num-per-vf or both. Error log is "PMD: Error parsing device, invalid key " and "PMD: Error parsing device, invalid key ". The root cause is that device argument will be parsed in different parsing functions with local va

Re: [dpdk-dev] [PATCH] vhost: fix return value

2018-07-25 Thread Tiwei Bie
On Wed, Jul 25, 2018 at 04:21:42PM +0800, Jiayu Hu wrote: > This patch fixes the incorrect return value for rte_vhost_dequeue_burst() > when virtqueue is not enabled or virtqueue address translation fails. > > Fixes: 62250c1d0978 ("vhost: extract split ring handling from Rx and Tx > functions") >

[dpdk-dev] [PATCH 2/2] vhost: release the locks when failed to make RARP packet

2018-07-25 Thread Tiwei Bie
Fixes: eefac9536a90 ("vhost: postpone device creation until rings are mapped") Cc: sta...@dpdk.org Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index

[dpdk-dev] [PATCH 1/2] vhost: fix overflow on shadow used ring

2018-07-25 Thread Tiwei Bie
The shadow used ring's size is the same as the vq's size, so we shouldn't try more than "vq size" times. Besides, the element pointed by avail->idx isn't available to the device, so we will return error when try "vq size" times. Fixes: 24e4844048e1 ("vhost: unify Rx mergeable and non-mergeable pat

[dpdk-dev] [PATCH 5/5] net/bnxt: fix to set proper reta size

2018-07-25 Thread Ajit Khaparde
The reta_size being indicated in the bnxt_dev_info_get_op was incorrect. Set it to the value supported by the hardware. Fixes: 0a6d2a720078 ("net/bnxt: get device infos") Cc: sta...@dpdk.org Reviewed-by: Scott Branden Reviewed-by: Randy Schacher Tested-by: Randy Schacher Signed-off-by: Ajit Kh

[dpdk-dev] [PATCH 0/5] bnxt patchset

2018-07-25 Thread Ajit Khaparde
This patchset against next-net fixes issues identified during QA testing. Please apply. Ajit Khaparde (4): net/bnxt: fix to free allocated memory net/bnxt: fix to release lock when alloc fails in NVM write net/bnxt: check access denied error for HWRM commands net/bnxt: fix to set proper re

[dpdk-dev] [PATCH 2/5] net/bnxt: fix to free allocated memory

2018-07-25 Thread Ajit Khaparde
In some cases we may not be freeing up memory allocated for certain NVM commands because the code might have bailed out before reaching rte_free(). This patch moves some code around to ensure the allocated memory is freed before exiting the function. Fixes: 19e6af01bb36 ("net/bnxt: support get/set

[dpdk-dev] [PATCH 4/5] net/bnxt: check access denied error for HWRM commands

2018-07-25 Thread Ajit Khaparde
Firmware can restrict access to certain resources in the hardware depending on various factors. In such cases when the PMD tries to configure these resources the firmware will return HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED error. Parse this and return the standard EACCES error to the applications. Fi

[dpdk-dev] [PATCH 1/5] net/bnxt: fix to remove element from the vnic's filter list

2018-07-25 Thread Ajit Khaparde
From: Somnath Kotur bnxt_clear_hwrm_vnic_filters() was removing the created filter from HW, but not clearing the internal data structures by removing it from the struct bnxt_vnic_info->filter list. Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops") Cc: sta...@dpdk.com Signed-off-by: Somn

[dpdk-dev] [PATCH 3/5] net/bnxt: fix to release lock when alloc fails in NVM write

2018-07-25 Thread Ajit Khaparde
In bnxt_hwrm_flash_nvram, before attempting to allocate a buffer we are grabbing the rte_spinlock. And if the allocation fails we are returning before releasing the spinlock. We avoid the situation by calling HWRM_PREP which grabs the lock after the buffer is allocated successfully. Fixes: 19e6af0

Re: [dpdk-dev] [PATCH v3] app/testpmd: removed softnic CLI modifications

2018-07-25 Thread Aaron Conole
Moti Haimovsky writes: > This patch reverts the testpmd CLI prompt routine modifications done > in order to support softnic. > The reason of doing so is due to testpmd abnormal exit observed on > several setups caused by the softnic modifications to this routine, > for example: When running testp

Re: [dpdk-dev] [PATCH v2 00/15] enic PMD fixes and performance improvements

2018-07-25 Thread John Daley (johndale)
Hi Kevin, Inline. -john > -Original Message- > From: Kevin Traynor > Sent: Wednesday, July 25, 2018 11:37 AM > To: John Daley (johndale) ; ferruh.yi...@intel.com > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 00/15] enic PMD fixes and performance > improvements >

Re: [dpdk-dev] [PATCH v4 0/6] compress: add Octeontx ZIP compression PMD

2018-07-25 Thread De Lara Guarch, Pablo
> -Original Message- > From: Ashish Gupta [mailto:ashish.gu...@caviumnetworks.com] > Sent: Wednesday, July 25, 2018 6:05 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; narayanaprasad.athr...@cavium.com; > mahipal.cha...@cavium.com; Trahe, Fiona ; Shally > Verma > Subject: [PATCH v4

[dpdk-dev] deprecation of rte_pci_ioport_unmap()

2018-07-25 Thread Kevin Wilson
Hi dpdk-dev, Shouldn't rte_pci_ioport_unmap() be deprecated ? No one calls this methods, still I did not find deprecation notice anywhere. Regards, Kevin

Re: [dpdk-dev] [PATCH v2 00/15] enic PMD fixes and performance improvements

2018-07-25 Thread Kevin Traynor
On 06/29/2018 10:29 AM, John Daley wrote: > Updated a few commits in the patchset per suggestions by Ferrus Yigit. > thanks, > John > > Hyong Youb Kim (12): > net/enic: fix receive packet types > net/enic: update the UDP RSS detection mechanism > net/enic: do not overwrite admin Tx queue lim

[dpdk-dev] [PATCH 4/4] ixgbe: remove mild profanity

2018-07-25 Thread Stephen Hemminger
At the tail end of comment about barriers (I feel your pain); remove mild profanity. Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_rxtx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 354

[dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails

2018-07-25 Thread Stephen Hemminger
There is no need to call rte_exit and crash the application here; better to let the application handle the error itself. Remove the gratuitous profanity which would be visible if the rte_exit was still there. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_proc.c | 10

[dpdk-dev] [PATCH 0/4] small cleanups

2018-07-25 Thread Stephen Hemminger
These were discovered when running internal policy checker to try and get rid of potentially offensive language in DPDK. After looking at a couple of these places, they were also places where some improvement could be made. Stephen Hemminger (4): arm: remove profanity in comment bnx2x: remove

Re: [dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue

2018-07-25 Thread Kevin Traynor
On 07/10/2018 11:37 AM, Shaopeng He wrote: > Currently, i40e_dev_tx_queue_setup_runtime checks simple tx and treats > mbuf fast free offloading as No-simple, which is classified as simple tx > in i40e_set_tx_function_flag. This inconsistent behavior causes tx queue > setup fail after queue was stop

[dpdk-dev] [PATCH 2/4] bnx2x: remove profanity

2018-07-25 Thread Stephen Hemminger
No need for profanity in comments. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/elink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c index 34a29373af3b..08fe817720a1 100644 --- a/drivers/net/bnx2x/elink.c

[dpdk-dev] [PATCH 1/4] arm: remove profanity in comment

2018-07-25 Thread Stephen Hemminger
Update comment to describe the problem better without risk of being offensive. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/include/arch/arm/rte_cycles_32.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/arch/arm/rte_cycles_32.

Re: [dpdk-dev] [PATCH] ethdev: remove unused forward declaration.

2018-07-25 Thread Andrew Rybchenko
On 25.07.2018 11:30, Rami Rosen wrote: The forward declaraion of rte_pci_device in rte_ethdev.h is not needed anymore. Fixes: cd8c7c7ce241 ("replace bus specific struct with generic dev") Signed-off-by: Rami Rosen Acked-by: Andrew Rybchenko

[dpdk-dev] [PATCH] doc: fix spelling error in vdev_netvsc

2018-07-25 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- doc/guides/nics/vdev_netvsc.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/vdev_netvsc.rst b/doc/guides/nics/vdev_netvsc.rst index e02ae9acbac6..d1da07118783 100644 --- a/doc/guides/nics/vdev_netvsc.rst +++ b/doc/guides

Re: [dpdk-dev] [PATCH] config: reduce memory requirements for DPDK

2018-07-25 Thread Kevin Traynor
On 07/24/2018 01:03 PM, Thomas Monjalon wrote: > 24/07/2018 13:04, Burakov, Anatoly: >> On 24-Jul-18 11:23 AM, Thomas Monjalon wrote: >>> 24/07/2018 12:03, Anatoly Burakov: It has been reported that current memory limitations do not work well on an 8-socket machines in default configurati

Re: [dpdk-dev] [PATCH 0/6] net/softnic: expose tmgr through firmware

2018-07-25 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, July 25, 2018 6:10 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH 0/6] net/softnic: expose tmgr through firmware > > This patchset provide the necessary Soft NIC firmware CLI commands to > control the

[dpdk-dev] [pull-request] next-pipeline 18.08 pre-rc2

2018-07-25 Thread Cristian Dumitrescu
The following changes since commit 9d6d5b4d470ba27243c42d1b369f098d8a6b9c60: app/crypto-perf: compile with -O3 (2018-07-24 01:48:10 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-pipeline for you to fetch changes up to d85cb1311a0068cd6177019649fc4ae5463e

Re: [dpdk-dev] [PATCH] net/mlx5: fix count query when flow has not counters

2018-07-25 Thread Yongseok Koh
> On Jul 25, 2018, at 1:46 AM, Nelio Laranjeiro > wrote: > > Querying a counters on a flow without counter is ending with a > segmentation fault. > > Fixes: 60bd8c9747e8 ("net/mlx5: add count flow action") > > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 56 +++

[dpdk-dev] [PATCH 5/6] net/softnic: add CLI command for tmgr hierarchy commit

2018-07-25 Thread Jasvinder Singh
From: Cristian Dumitrescu Add support for Traffic Manager (TMGR) hierarchy commit through firmware CLI script. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 47 +++ 1 file changed, 47 insertions(+)

[dpdk-dev] [PATCH 6/6] net/softnic: add CLI command for default tmgr hierarchy

2018-07-25 Thread Jasvinder Singh
From: Cristian Dumitrescu Add support for creating default Traffic Manager (TMGR) hierarchy through firmware CLI script. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 498 ++ 1 file changed, 498 in

[dpdk-dev] [PATCH 4/6] net/softnic: add CLI command for tmgr node addition

2018-07-25 Thread Jasvinder Singh
From: Cristian Dumitrescu Add support for adding Traffic Manager (TMGR) hierarchy node through firmware CLI script. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 171 ++ 1 file changed, 171 inserti

[dpdk-dev] [PATCH 3/6] net/softnic: add CLI command for tmgr shared shaper

2018-07-25 Thread Jasvinder Singh
From: Cristian Dumitrescu Add support to create Traffic Manager (TMGR) shared shaper through firmware CLI script. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 73 +++ 1 file changed, 73 insertions

[dpdk-dev] [PATCH 1/6] net/softnic: add CLI command for tmgr create

2018-07-25 Thread Jasvinder Singh
From: Cristian Dumitrescu Add support to create Traffic Manager (TMGR) object through firmware CLI script. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 17 +- drivers/net/softnic/rte_eth_softnic_cli.c | 32

[dpdk-dev] [PATCH 2/6] net/softnic: add CLI command for tmgr shaper profile

2018-07-25 Thread Jasvinder Singh
From: Cristian Dumitrescu Add support to create Traffic Manager (TMGR) shaper profile through firmware CLI script. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/parser.c | 18 ++ drivers/net/softnic/parser.h | 2 + d

[dpdk-dev] [PATCH 0/6] net/softnic: expose tmgr through firmware

2018-07-25 Thread Jasvinder Singh
This patchset provide the necessary Soft NIC firmware CLI commands to control the Traffic Manager (TMGR) through firmware. The Soft NIC TMGR function can now be controlled through either Soft NIC firmware or through the ethdev TM API (e.g. via test-pmd app). Cristian Dumitrescu (6): net/softnic

[dpdk-dev] [PATCH v6 3/4] test: add unit tests for latencystats library

2018-07-25 Thread Naga Suresh Somarowthu
Unit Test Cases added for latencystats library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan --- test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/test_latencystats.c | 216 ++ 3 files changed, 22

[dpdk-dev] [PATCH v6 0/4] add unit tests for bitrate, latency and pdump libraries

2018-07-25 Thread Naga Suresh Somarowthu
1/4: add ring pmd based packet helper functions for UT 2/4: unit test cases added for bitrate library 3/4: unit test cases added for latencystats library 4/4: unit test cases added for pdump library Patches 2/4,3/4 depends on 1/4 Patch 4/4 depends on 1/4 and the below patch http://patches.dpdk.org

[dpdk-dev] [PATCH v6 4/4] test: add unit test for pdump library

2018-07-25 Thread Naga Suresh Somarowthu
Unit test cases are added for pdump library. Primary process will act as server, forks a child secondary process. Secondary process acts as client. Server will do pdump init to serve any pdump client requests. Server will create a vdev, send/receive packets continuously in a separate thread. Client

[dpdk-dev] [PATCH v6 2/4] test: add unit tests for bitrate library

2018-07-25 Thread Naga Suresh Somarowthu
Unit Test Cases for BitRate library. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan Reviewed-by: Remy Horton --- test/test/Makefile| 1 + test/test/autotest_data.py| 6 ++ test/test/test_bitratestats.c | 227 ++ 3 fi

[dpdk-dev] [PATCH v6 1/4] test: add ring pmd based packet rx/tx for UT

2018-07-25 Thread Naga Suresh Somarowthu
Added ring pmd based packet rx/tx helper functions for verifying Latency, Bitrate and pdump lib UTs. Signed-off-by: Naga Suresh Somarowthu Reviewed-by: Reshma Pattan --- test/test/Makefile| 1 + test/test/sample_packet_forward.c | 115 ++ te

Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid network interface index value

2018-07-25 Thread Yongseok Koh
> On Jul 25, 2018, at 4:24 AM, Adrien Mazarguil > wrote: > > Network interface indices being unsigned, an invalid index or error is > normally expressed through a zero value (see if_nametoindex()). > > mlx5_ifindex() has a signed return type for negative values in case of > error. Since mlx5_

[dpdk-dev] [PATCH v4 6/6] usertools: update devbind for octeontx zip device

2018-07-25 Thread Ashish Gupta
From: Sunila Sahu Add the cavium octeontx zip pci device details. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- usertools/dpdk-devbind.py | 9 + 1 file changed, 9 insertions(+) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.p

[dpdk-dev] [PATCH v4 5/6] doc: add Octeonx zip guide

2018-07-25 Thread Ashish Gupta
Add Octeontx ZIP PMD feature specification and user guide with build and run instructions. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- MAINTAINERS | 2 + doc/guides/compressdevs/features/octeontx.ini | 10 +++ doc/

[dpdk-dev] [PATCH v4 4/6] compress/octeontx: support burst enqueue/dequeue

2018-07-25 Thread Ashish Gupta
Implement enqueue/dequeue APIs to perform compression/decompression operations Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- drivers/compress/octeontx/otx_zip.c | 47 +++ drivers/compress/octeontx/otx_zip.h | 96 +-

[dpdk-dev] [PATCH v4 3/6] compress/octeontx: create private xform

2018-07-25 Thread Ashish Gupta
Create non-shareable private xform for applications to perform stateless compression/decompression. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- drivers/compress/octeontx/otx_zip.h | 19 +++- drivers/compress/octeontx/otx_zip_pmd.c | 149 +

[dpdk-dev] [PATCH v4 0/6] compress: add Octeontx ZIP compression PMD

2018-07-25 Thread Ashish Gupta
From: Shally Verma This patch series add compression PMD for cavium octeontx ZIP module in DPDK compress drivers. Currently PMD only tested for deflate, stateless compression and decompression with direct memory buffers. Changes in v4: - removed scatter-gather implementation as not tested - revi

[dpdk-dev] [PATCH v4 1/6] compress/octeontx: add octeontx zip PMD

2018-07-25 Thread Ashish Gupta
From: Sunila Sahu Octentx zipvf PMD provides hardware acceleration for deflate and lzs compression and decompression operations using Octeontx zip co-processor, which provide 8 virtualized zip devices. This patch add basic initialization routine to register zip VFs to compressdev library. Signe

[dpdk-dev] [PATCH v4 2/6] compress/octeontx: add device setup PMD ops

2018-07-25 Thread Ashish Gupta
Add compression PMD device and queue pair setup ops. Signed-off-by: Ashish Gupta Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu --- drivers/compress/octeontx/otx_zip.c | 71 + drivers/compress/octeontx/otx_zip.h | 57 ++- drivers/compress/octeontx/otx_zip_pmd.c |

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

2018-07-25 Thread Yaroslav Brustinov (ybrustin)
Hi, Sounds good to me. Thanks, Yaroslav. -Original Message- From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] Sent: Wednesday, July 25, 2018 12:25 To: Yaroslav Brustinov (ybrustin) Cc: Shahaf Shuler ; Yongseok Koh ; dev@dpdk.org; sta...@dpdk.org; Nélio Laranjeiro ; Hanoch H

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

2018-07-25 Thread Yaroslav Brustinov (ybrustin)
+Hanoch I've added -std=c11 flag to our compilation to check. Without alignas(max_align_t): /usr/bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in src/dpdk/drivers/net/mlx5/mlx5_glue.c.11.o is smaller than 32 in src/dpdk/drivers/net/mlx5/mlx5_rxq.c.11.o With alignas(max_align_t): /usr/bin/

Re: [dpdk-dev] [PATCH] net/mlx5: fix linkage error for glue lib

2018-07-25 Thread Yaroslav Brustinov (ybrustin)
Hi, Are you OK with C11? I saw in file dpdk/drivers/net/mlx4/mlx4_utils.c: * C11 code would include stdalign.h and use alignof(max_align_t) however * we'll stick with C99 for the time being. :) As far as I understand, the issue is alignment of the pointer itself, not the struct. I'm

Re: [dpdk-dev] [PATCH v3] app/testpmd: removed softnic CLI modifications

2018-07-25 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Moti Haimovsky > Sent: Wednesday, July 25, 2018 4:30 PM > To: tho...@monjalon.net > Cc: Singh, Jasvinder ; dev@dpdk.org; > sta...@dpdk.org; Moti Haimovsky > Subject: [dpdk-dev] [PATCH v3] app/testpmd: removed so

[dpdk-dev] [PATCH v3] app/testpmd: removed softnic CLI modifications

2018-07-25 Thread Moti Haimovsky
This patch reverts the testpmd CLI prompt routine modifications done in order to support softnic. The reason of doing so is due to testpmd abnormal exit observed on several setups caused by the softnic modifications to this routine, for example: When running testpmd with tap interface (/app/testpmd

Re: [dpdk-dev] [PATCH v2] app/testpmd: removed softnic CLI modifications

2018-07-25 Thread Singh, Jasvinder
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 25, 2018 3:43 PM > To: Moti Haimovsky > Cc: dev@dpdk.org; sta...@dpdk.org; Singh, Jasvinder > ; Dumitrescu, Cristian > ; Ananyev, Konstantin > > Subject: Re: [PATCH v2] app/testpmd: removed

[dpdk-dev] [PATCH] net/mlx4: verify RSS supports num Rx Qs being used

2018-07-25 Thread Moti Haimovsky
This patch verifies that the number of Rx queues configured for RSS is supported by the device hardware. RSS support in mlx4 requires contiguous chunk of QPs to be reserved, there is a hardware limitation on the amount of contiguous QPs which is reported by the hardware. Ignoring this value will ca

Re: [dpdk-dev] [PATCH v2] app/testpmd: removed softnic CLI modifications

2018-07-25 Thread Thomas Monjalon
+Cc 25/07/2018 16:40, Moti Haimovsky: > This patch reverts the testpmd CLI prompt routine modifications done > in order to support softnic. > The reason of doing so is due to testpmd abnormal exit observed on > several setups caused by the softnic modifications to this routine, > for example: When

[dpdk-dev] [PATCH v2] app/testpmd: removed softnic CLI modifications

2018-07-25 Thread Moti Haimovsky
This patch reverts the testpmd CLI prompt routine modifications done in order to support softnic. The reason of doing so is due to testpmd abnormal exit observed on several setups caused by the softnic modifications to this routine, for example: When running testpmd with tap interface (/app/testpmd

[dpdk-dev] [PATCH v2] test: fix prefix discovery

2018-07-25 Thread Anatoly Burakov
Config file has moved, but the tests weren't updated to point to its new location. Update the code to find current prefix. Also, this function is duplicated across multiple tests, so move it into process.h and force compile failures for any attempts to use it on platforms other than Linux. Fixes:

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

2018-07-25 Thread Ananyev, Konstantin
> -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, July 25, 2018 1:41 PM > To: Ananyev, Konstantin ; Mordechay Haimovsky > ; Thomas Monjalon > ; Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; Pattan, > Reshma ; > olivier.m...@6wind.com; Van Haaren, Harry

Re: [dpdk-dev] [PATCH] app/eventdev: fix order test service init

2018-07-25 Thread Jerin Jacob
-Original Message- > Date: Fri, 13 Jul 2018 17:52:42 + > From: "Eads, Gage" > To: Pavan Nikhilesh , > "jerin.ja...@caviumnetworks.com" > CC: "dev@dpdk.org" , "sta...@dpdk.org" > Subject: RE: [dpdk-dev] [PATCH] app/eventdev: fix order test service init > > External Email > > >

Re: [dpdk-dev] [PATCH] event/octeontx: prefetch mbuf instead of wqe

2018-07-25 Thread Jerin Jacob
-Original Message- > Date: Tue, 17 Jul 2018 22:08:30 +0530 > From: santosh > To: Pavan Nikhilesh , > jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] event/octeontx: prefetch mbuf instead of wqe > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Geck

Re: [dpdk-dev] [PATCH] mk: fix application compilation with lmnl and mlx5

2018-07-25 Thread Shahaf Shuler
Wednesday, July 25, 2018 12:07 PM, Adrien Mazarguil: > Subject: Re: [PATCH] mk: fix application compilation with lmnl and mlx5 > > The approach of linking .a files instead of .so and still generate a dynamic > program also has drawbacks: duplication and link time issues with multiple > users. For

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: fix help string for tm commit cmd

2018-07-25 Thread Iremonger, Bernard
> -Original Message- > From: Krzysztof Kanas [mailto:krzysztof.ka...@caviumnetworks.com] > Sent: Wednesday, July 25, 2018 1:42 PM > To: Iremonger, Bernard ; > krzysztof.ka...@caviumnetworks.com; dev@dpdk.org; Lu, Wenzhuo > ; Wu, Jingjing > Cc: Nithin Dabilpuram ; Singh, Jasvinder > > S

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix linkage error for glue lib

2018-07-25 Thread Adrien Mazarguil
On Wed, Jul 25, 2018 at 04:18:54PM +0300, Shahaf Shuler wrote: > From: Yaroslav Brustinov > > addressing a gcc 4.7.2 bug that cannot be reproduced with latter > versions: > > "bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in > src/dpdk/drivers/net/mlx5/mlx5_glue.c.21.o is smaller than 16 in

Re: [dpdk-dev] [PATCH v3 1/2] app/testpmd: fix use of uninitialized field

2018-07-25 Thread Iremonger, Bernard
> -Original Message- > From: Krzysztof Kanas [mailto:krzysztof.ka...@caviumnetworks.com] > Sent: Wednesday, July 25, 2018 1:42 PM > To: Iremonger, Bernard ; > krzysztof.ka...@caviumnetworks.com; dev@dpdk.org; Lu, Wenzhuo > ; Wu, Jingjing > Cc: Nithin Dabilpuram ; Singh, Jasvinder > ; t...@

Re: [dpdk-dev] [PATCH v2] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

2018-07-25 Thread Gaëtan Rivet
Hi Konstantin, On Wed, Jul 25, 2018 at 09:11:30AM +, Ananyev, Konstantin wrote: > Hi Cody, > > > -Original Message- > > From: Cody Doucette [mailto:douce...@bu.edu] > > Sent: Thursday, July 19, 2018 4:58 PM > > To: Ananyev, Konstantin ; Olivier Matz > > ; Dumitrescu, Cristian > > >

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

2018-07-25 Thread Dumitrescu, Cristian
> -Original Message- > From: Van Haaren, Harry > Sent: Wednesday, July 25, 2018 1:27 PM > To: Ananyev, Konstantin ; Dumitrescu, > Cristian ; Mordechay Haimovsky > ; Thomas Monjalon ; > Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ; olivier.m...@6wind.com >

[dpdk-dev] [PATCH v2] net/mlx5: fix linkage error for glue lib

2018-07-25 Thread Shahaf Shuler
From: Yaroslav Brustinov addressing a gcc 4.7.2 bug that cannot be reproduced with latter versions: "bin/ld: Warning: alignment 8 of symbol `mlx5_glue' in src/dpdk/drivers/net/mlx5/mlx5_glue.c.21.o is smaller than 16 in src/dpdk/drivers/net/mlx5/mlx5_rxq.c.21.o" Fix it be forcing the alignment

Re: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port start and stop in Rx adapter

2018-07-25 Thread Jerin Jacob
-Original Message- > Date: Tue, 24 Jul 2018 21:08:04 +0530 > From: Jerin Jacob > To: Pavan Nikhilesh > Cc: dev@dpdk.org, sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] event/octeontx: remove unnecessary port > start and stop in Rx adapter > User-Agent: Mutt/1.10.1 (2018-07-13) > > --

Re: [dpdk-dev] [PATCH] net/mlx5: fix queue rollback when starting device

2018-07-25 Thread Shahaf Shuler
Monday, July 23, 2018 11:57 PM, Yongseok Koh: > Subject: [PATCH] net/mlx5: fix queue rollback when starting device > > mlx5_rxq_start() and mlx5_rxq_stop() must be strictly paired because > internal reference counter is increased or decreased inside. Also, > mlx5_rxq_get() must be paired with mlx5

Re: [dpdk-dev] [PATCH v4] app/eventdev: use proper teardown sequence

2018-07-25 Thread Jerin Jacob
-Original Message- > Date: Tue, 24 Jul 2018 21:09:50 +0530 > From: Jerin Jacob > To: Pavan Nikhilesh > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4] app/eventdev: use proper teardown > sequence > User-Agent: Mutt/1.10.1 (2018-07-13) > > -Original Message- > > Date: Tue,

Re: [dpdk-dev] [PATCH] net/mlx5: fix possible endless loop when clearing flow flags

2018-07-25 Thread Shahaf Shuler
Wednesday, July 25, 2018 9:59 AM, Nélio Laranjeiro: > Subject: Re: [PATCH] net/mlx5: fix possible endless loop when clearing flow > flags > > On Tue, Jul 24, 2018 at 09:47:19PM +, Yongseok Koh wrote: > > > > > On Jul 23, 2018, at 11:57 PM, Nélio Laranjeiro > wrote: > > > > > > On Mon, Jul 23,

[dpdk-dev] [PATCH v1] doc/samples: update vm power manager sample docs

2018-07-25 Thread David Hunt
Add information on the ability of guest app to sent a policy to the host app. Add information on the branch ratio out-of-band method of workload monitoring and power management. Signed-off-by: David Hunt --- .../sample_app_ug/vm_power_management.rst | 165 -- 1 file changed,

Re: [dpdk-dev] [PATCH] net/mlx5: fix count query when flow has not counters

2018-07-25 Thread Ori Kam
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nelio Laranjeiro > Sent: Wednesday, July 25, 2018 11:46 AM > To: dev@dpdk.org; Shahaf Shuler ; Yongseok Koh > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix count query when flow has not > counters > > Querying a

[dpdk-dev] [PATCH v3 1/2] app/testpmd: fix use of uninitialized field

2018-07-25 Thread Krzysztof Kanas
print_err_msg uses message field that may be not initialized causing segmentation fault. Fixes: 12f76f5247e2 ("app/testpmd: add command to resume a TM node") Cc: t...@semihalf.com Signed-off-by: Krzysztof Kanas --- v3: Fix the Fixes: commit message line --- app/test-pmd/cmdline_tm.c | 19 ++

[dpdk-dev] [PATCH v3 2/2] app/testpmd: fix help string for tm commit cmd

2018-07-25 Thread Krzysztof Kanas
Fixes: 996cb153af06 ("app/testpmd: add commands for TM nodes and hierarchy commit") Cc: jasvinder.si...@intel.com Signed-off-by: Krzysztof Kanas --- app/test-pmd/cmdline_tm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.

Re: [dpdk-dev] [PATCH] net/i40e: fix multiple device arguments parsing error

2018-07-25 Thread Zhang, Qi Z
Hi Beilei > -Original Message- > From: Xing, Beilei > Sent: Wednesday, July 25, 2018 2:37 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Stillwell Jr, Paul M ; > sta...@dpdk.org > Subject: [PATCH] net/i40e: fix multiple device arguments parsing error > > There will be parsing error when using

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

2018-07-25 Thread Dumitrescu, Cristian
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, July 25, 2018 1:18 PM > To: Dumitrescu, Cristian ; Mordechay > Haimovsky ; Thomas Monjalon > ; Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ; olivier.m...@6wind.com; Van > Haaren, Harry >

[dpdk-dev] [pull-request] next-eventdev 18.08 RC2

2018-07-25 Thread Jerin Jacob
The following changes since commit 711f43ba568acadf6cbccb9f8a29abf0fb3baa25: examples/vm_power: make branch ratio configurable (2018-07-21 00:00:43 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to f094d5a870e88536eab6

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

2018-07-25 Thread Van Haaren, Harry
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, July 25, 2018 1:18 PM > To: Dumitrescu, Cristian ; Mordechay Haimovsky > ; Thomas Monjalon ; Singh, Jasvinder > > Cc: dev@dpdk.org; Iremonger, Bernard ; Pattan, > Reshma ; olivier.m...@6wind.com; Van Haaren, Harry > > Sub

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

2018-07-25 Thread Ananyev, Konstantin
> -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, July 25, 2018 12:57 PM > To: Ananyev, Konstantin ; Mordechay Haimovsky > ; Thomas Monjalon > ; Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; Pattan, > Reshma ; > olivier.m...@6wind.com; Van Haaren, Harry

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

2018-07-25 Thread Dumitrescu, Cristian
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, July 25, 2018 12:39 PM > To: Dumitrescu, Cristian ; Mordechay > Haimovsky ; Thomas Monjalon > ; Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; > Pattan, Reshma ; olivier.m...@6wind.com; Van > Haaren, Harry >

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

2018-07-25 Thread Mordechay Haimovsky
This is how we reproduce the issue : app/testpmd -n 4 --vdev="net_tap0,iface=tap0,remote=eth1" -- --burst=64 --mbcache=512 -i --rxq=2 --txq=2 --txd=512 --rxd=512 --port-topology=chained --forward-mode=rxonly > -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan..

Re: [dpdk-dev] [PATCH] app/testpmd: fix testpmd exit using ctrl+d

2018-07-25 Thread Ananyev, Konstantin
> -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, July 25, 2018 10:36 AM > To: Ananyev, Konstantin ; Mordechay Haimovsky > ; Thomas Monjalon > ; Singh, Jasvinder > Cc: dev@dpdk.org; Iremonger, Bernard ; Pattan, > Reshma ; > olivier.m...@6wind.com > Subject: RE: [dpd

[dpdk-dev] [PATCH v2] doc: fix incorrect create bonding command in testpmd

2018-07-25 Thread Shreyansh Jain
Fixes: ac718398f477 ("doc: testpmd application user guide") Cc: bernard.iremon...@intel.com Cc: sta...@dpdk.org Signed-off-by: Shreyansh Jain Reviewed-by: Ferruh Yigit Acked-by: Bernard Iremonger --- v2: Update the Fixes line to represent the first commit rather than the formatting patch

[dpdk-dev] [PATCH] net/mlx5: fix invalid network interface index value

2018-07-25 Thread Adrien Mazarguil
Network interface indices being unsigned, an invalid index or error is normally expressed through a zero value (see if_nametoindex()). mlx5_ifindex() has a signed return type for negative values in case of error. Since mlx5_nl.c does not check for errors, these may be fed back as invalid interface

Re: [dpdk-dev] Accessing "device_id" from "rte_pci_device"

2018-07-25 Thread Rosen, Rami
Hi Santosh, My personal opinion is: Look at the patch in http://patchwork.dpdk.org/patch/37654/ Three lines were changes in rte_ethdev.c and rte_ethdev.h: lib/librte_ether/rte_ethdev.c | 1 + lib/librte_ether/rte_ethdev.h | 2 +- Take these changes as a basis, and add everythi

Re: [dpdk-dev] Accessing "device_id" from "rte_pci_device"

2018-07-25 Thread santhosh K.S
Hi Rami Rosen, et al, Thanks for the response. Yes I can see in the code that rte_device struct is part of rte_eth_dev_info. I tried to apply the patch you pointed o n 17.11.3. But it failed at many places. We don't want to migrate to 18.05 as it is not a s

[dpdk-dev] [PATCH] examples/ipsec-secgw: add 3des-cbc support

2018-07-25 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- doc/guides/sample_app_ug/ipsec_secgw.rst | 3 ++- examples/ipsec-secgw/esp.c | 3 +++ examples/ipsec-secgw/sa.c| 11 ++- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/doc/guides/sample_app_ug/ipsec_secgw.r

[dpdk-dev] [PATCH v2] net/bonding: fix race condition

2018-07-25 Thread Radu Nicolau
Race condition can appear in the bond_mode_8023ad_periodic_cb() callback when bonding port is stopped, reconfigured and restarted. Re-ordered calls in bond_ethdev_start() to have callback alarm set after slave ports are reconfigured. Fixes: 2efb58cbab6e ("bond: new link bonding library") Cc: sta.

  1   2   >