[dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue

2018-07-09 Thread Shaopeng He
Currently, i40e_dev_tx_queue_setup_runtime checks simple tx and treats mbuf fast free offloading as No-simple, which is classified as simple tx in i40e_set_tx_function_flag. This inconsistent behavior causes tx queue setup fail after queue was stopped. This patch fixes this bug. Fixes: 399421100e0

Re: [dpdk-dev] [PATCH] cryptodev: rename experimental private data APIs

2018-07-09 Thread Gujjar, Abhinandan S
Acked-by: Abhinandan Gujjar > -Original Message- > From: Trahe, Fiona > Sent: Friday, July 6, 2018 7:10 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Gujjar, Abhinandan S > Subject: [PATCH] cryptodev: rename experimental private data APIs > > The name private_dat

Re: [dpdk-dev] [PATCH] ethdev: fix queue mapping documentation

2018-07-09 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Jul 2018 16:45:33 +0100 > From: Ferruh Yigit > To: Andrew Rybchenko , Jerin Jacob > , dev@dpdk.org > CC: tho...@monjalon.net, sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix queue mapping documentation > User-Agent: Mozilla/5.0 (Windows NT 1

Re: [dpdk-dev] [PATCH v1 5/5] vhost: message handling implemented as a callback array

2018-07-09 Thread Tiwei Bie
On Tue, Jun 26, 2018 at 07:19:38PM +0300, Nikolay Nikolaev wrote: > Introduce vhost_message_handlers, which maps the message request > type to the message handler. Then replace the switch construct > with a map and call. > > Signed-off-by: Nikolay Nikolaev > --- > lib/librte_vhost/vhost_user.c |

Re: [dpdk-dev] [PATCH v1 4/5] vhost: unify message handling function signature

2018-07-09 Thread Tiwei Bie
On Tue, Jun 26, 2018 at 07:19:31PM +0300, Nikolay Nikolaev wrote: > Each vhost-user message handlign function will return an int result s/handlign/handling > which is described in the new enum vh_result: error, OK and reply. > All functions will now have two arguments, virtio_net double pointer >

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-09 Thread Verma, Shally
Hi Pablo >-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 10 July 2018 03:54 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Murthy, Nidadavolu >; Sahu, Sunila ; Gupta, >Ashish ; Kartha, >Umesh >Subject: RE: [PATCH v4 1/4

Re: [dpdk-dev] [PATCH] app/testpmd: fix little perf drop with XL710

2018-07-09 Thread Zhang, Qi Z
Hi Xiaoyun: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xiaoyun Li > Sent: Tuesday, July 10, 2018 10:28 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Li, Xiaoyun ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix little perf drop with XL710 > > Th

[dpdk-dev] [PATCH v3] rte_ring: clarify preemptible nature of ring algorithm

2018-07-09 Thread Honnappa Nagarahalli
rte_ring implementation is not preemptible only under certain circumstances. This clarification is helpful for data plane and control plane communication using rte_ring. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl --- v3: * Corrected known issues for rte

Re: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto device(CPT) driver

2018-07-09 Thread Anoob Joseph
Hi Pablo, Thanks for the review. We had made some architectural modifications to the PMD while addressing your comments. This is taking longer than expected and so we might as well defer the v2 to the next release cycle. Is that fine? Do you suggest submitting the patches as and when it is r

Re: [dpdk-dev] [PATCH v1 05/15] examples/l2fwd: add missing space

2018-07-09 Thread Anoob Joseph
Hi Pablo, On 10-07-2018 04:21, De Lara Guarch, Pablo wrote: External Email -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 14, 2018 12:49 PM To: Richardson, Bruce ; De Lara Guarch, Pablo Cc: Anoob Joseph ; Jerin Jacob ; Narayana Pra

Re: [dpdk-dev] [PATCH v1 09/15] examples/l2fwd: move drain buffers to new function

2018-07-09 Thread Anoob Joseph
Hi Pablo, On 10-07-2018 04:19, De Lara Guarch, Pablo wrote: External Email -Original Message- From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 14, 2018 11:18 AM To: Richardson, Bruce ; De Lara Guarch, Pablo Cc: Anoob Joseph ; Jerin Jacob ; Narayana Pra

Re: [dpdk-dev] [PATCH v1 01/15] examples/l2fwd: add new header to move common code

2018-07-09 Thread Anoob Joseph
Hi Pablo, I'll merge this patch with the next one. Will do the same with checkpatch fixes too. Since this is a common benchmarking application, I wanted to highlight all the changes introduced. That's the reason for small patches. Shall I send a v2 after doing this? Are there any other comme

[dpdk-dev] [PATCH] app/testpmd: fix little perf drop with XL710

2018-07-09 Thread Xiaoyun Li
There is about 1.8M perf drop with XL710. And it is because of a bitrate calculation in the datapath. So improve it by maintaining an array of port indexes in testpmd, which is updated with ethdev events. Fixes: 8728ccf37615 ("fix ethdev ports enumeration") Cc: sta...@dpdk.org Signed-off-by: Xiao

Re: [dpdk-dev] [PATCH v2] net/e1000: Support mtu set for igbvf.

2018-07-09 Thread Lu, Wenzhuo
Hi Ian, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ian Stokes > Sent: Friday, June 29, 2018 9:51 PM > To: dev@dpdk.org > Cc: Stokes, Ian ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/e1000: Support mtu set for igbvf. > > This patch enables settin

[dpdk-dev] [PATCH v4 16/16] docs/qat: refactor docs adding compression guide

2018-07-09 Thread Fiona Trahe
Extend QAT guide to cover crypto and compression and common information, particularly about kernel driver dependency. Update release note. Update compression feature list for qat. Signed-off-by: Fiona Trahe --- config/common_base | 2 +- doc/guides/compressdevs/features/q

[dpdk-dev] [PATCH v4 14/16] compress/qat: add fns to create and destroy the PMD

2018-07-09 Thread Fiona Trahe
Now that all the device operations are available, add the functions to create and destroy the pmd. Called on probe and remove of the qat pci device, these register the device with the compressdev API and plug in all the device functionality. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwia

[dpdk-dev] [PATCH v4 15/16] compress/qat: prevent device usage if incorrect firmware

2018-07-09 Thread Fiona Trahe
Previous check only causes op to fail on dequeue. This extends so once first fail is detected, application can no longer enqueue ops to the device and will also get an appropriate error if trying to reconfigure or setup the device. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- dr

[dpdk-dev] [PATCH v4 09/16] compress/qat: add fns to configure and clear device

2018-07-09 Thread Fiona Trahe
Add functions to configure and clear the qat comp device, including the creation and freeing of the xform pool and the freeing of queue-pairs. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 95 + drivers/com

[dpdk-dev] [PATCH v4 12/16] compress/qat: add device start and stop fns

2018-07-09 Thread Fiona Trahe
There are no specific actions needed to start/stop a QAT comp device so these are just trivial fns to satisfy the pmd API. Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp_pmd.c | 11 +++ drivers/compress/qat/qat_comp_pmd.h | 6 ++ 2 files changed, 17 insertions(+) diff

[dpdk-dev] [PATCH v4 13/16] compress/qat: create and populate the ops structure

2018-07-09 Thread Fiona Trahe
Create an ops structure and populate it with the qat-specific functions. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 38 - drivers/compress/qat/qat_comp_pmd.h | 30 - 2 files c

[dpdk-dev] [PATCH v4 10/16] compress/qat: add fn to return device info

2018-07-09 Thread Fiona Trahe
Add capabilities pointer to internal qat comp device and function to return this and other info. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 19 +++ drivers/compress/qat/qat_comp_pmd.h | 6 ++ 2 files changed, 25 insert

[dpdk-dev] [PATCH v4 11/16] compress/qat: add enqueue/dequeue functions

2018-07-09 Thread Fiona Trahe
Wrap generic qat enqueue/dequeue functions with compressdev enqueue and dequeue fns. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 14 ++ drivers/compress/qat/qat_comp_pmd.h | 8 2 files changed, 22 insertions(+) diff -

[dpdk-dev] [PATCH v4 05/16] compress/qat: create fw request and process response

2018-07-09 Thread Fiona Trahe
Add functions to create the request message to send to firmware and to process the firmware response. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 101 drivers/compress/qat/qat_comp.h | 8 +++ drive

[dpdk-dev] [PATCH v4 07/16] compress/qat: add stats functions

2018-07-09 Thread Fiona Trahe
Add functions to get and clear compression queue-pair statistics. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 35 +++ drivers/compress/qat/qat_comp_pmd.h | 7 +++ 2 files changed, 42 insertions(+) diff

[dpdk-dev] [PATCH v4 03/16] compress/qat: add meson build

2018-07-09 Thread Fiona Trahe
Add meson build files. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/common/qat/Makefile | 2 +- drivers/compress/meson.build | 2 +- drivers/compress/qat/meson.build | 18 ++ drivers/compress/qat/rte_pmd_qat_

[dpdk-dev] [PATCH v4 04/16] compress/qat: add xform processing

2018-07-09 Thread Fiona Trahe
Add code to process compressdev rte_comp_xforms, creating private qat_comp_xforms with prepared firmware message templates. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 239 drivers/compress/qat/qat_comp.

[dpdk-dev] [PATCH v4 08/16] compress/qat: setup queue-pairs for compression service

2018-07-09 Thread Fiona Trahe
Setup and clear queue-pairs for handling compression requests and responses. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.h | 2 ++ drivers/compress/qat/qat_comp_pmd.c | 61 + drivers/compress/qat/qat_comp_pm

[dpdk-dev] [PATCH v4 02/16] compress/qat: add makefiles for PMD

2018-07-09 Thread Fiona Trahe
Add Makefiles, directory and empty source files for compression PMD. Handle cases for building either symmetric crypto PMD or compression PMD or both and the common files both depend on. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- MAINTAINERS | 4

[dpdk-dev] [PATCH v4 06/16] compress/qat: check that correct firmware is in use

2018-07-09 Thread Fiona Trahe
Check bit in response message to verify that correct firmware is in use for compression. If not return an error. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 16 +++- drivers/compress/qat/qat_comp.h | 2 ++ 2 files changed, 17 inser

[dpdk-dev] [PATCH v4 01/16] common/qat: updated firmware headers

2018-07-09 Thread Fiona Trahe
Updated to latest firmware headers files for QuickAssist devices. Includes updates for symmetric crypto, PKE and Compression services. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_adf/icp_qat_fw.h | 69 +++- drivers/common/qat/qat_adf/icp_qat_fw_comp.h | 482 ++

[dpdk-dev] [PATCH v4 00/16] compress/qat: add compression PMD

2018-07-09 Thread Fiona Trahe
Create compression PMD for Intel QuickAssist devices Currently only the C62x and c3xxx devices are supported. The qat comp PMD supports - stateless compression and decompression using the Deflate algorithm with Fixed Huffman encoding. Dynamic huffman encoding is not supported, it will be

Re: [dpdk-dev] [PATCH v10 03/19] bus/pci: enable vfio unmap resource for secondary

2018-07-09 Thread Zhang, Qi Z
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, July 9, 2018 10:38 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > > Subject: Re: [PATCH v10 03/19] bus/p

Re: [dpdk-dev] [PATCH v2] rte_ring: clarify preemptible nature of ring algorithm

2018-07-09 Thread Honnappa Nagarahalli
-Original Message- From: Olivier Matz Sent: Monday, June 25, 2018 10:37 AM To: Honnappa Nagarahalli Cc: Burakov, Anatoly ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] rte_ring: clarify preemptible nature of ring algorithm Hi Honnappa, On Thu, May 31, 2018 at 04:53:01AM +, H

Re: [dpdk-dev] [PATCH 00/16] Adding Cavium's crypto device(CPT) driver

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, June 18, 2018 3:30 PM > To: Anoob Joseph ; Akhil Goyal > > Cc: Thomas Monjalon ; Ankur Dwivedi > ; Jerin Jacob > ; Murthy NSSR > ; Narayana Prasad > ; Nithin Dabilpuram > ; Ragothaman Jayaraman > ; Srisivasubramanian Srin

Re: [dpdk-dev] [PATCH v1 05/15] examples/l2fwd: add missing space

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Thursday, June 14, 2018 12:49 PM > To: Richardson, Bruce ; De Lara Guarch, Pablo > > Cc: Anoob Joseph ; Jerin Jacob > ; Narayana Prasad > ; dev@dpdk.org > Subject: [PATCH v1 05/15] examples/l2fwd:

Re: [dpdk-dev] [PATCH v1 09/15] examples/l2fwd: move drain buffers to new function

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Thursday, June 14, 2018 11:18 AM > To: Richardson, Bruce ; De Lara Guarch, Pablo > > Cc: Anoob Joseph ; Jerin Jacob > ; Narayana Prasad > ; dev@dpdk.org > Subject: [PATCH v1 09/15] examples/l2fwd:

Re: [dpdk-dev] [PATCH v1 06/15] examples/l2fwd: fix lines exceeding 80 char limit

2018-07-09 Thread De Lara Guarch, Pablo
Hi Anoob, > -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Thursday, June 14, 2018 11:18 AM > To: Richardson, Bruce ; De Lara Guarch, Pablo > > Cc: Anoob Joseph ; Jerin Jacob > ; Narayana Prasad > ; dev@dpdk.org > Subject: [PATCH v1 06/15] example

Re: [dpdk-dev] [PATCH v1 01/15] examples/l2fwd: add new header to move common code

2018-07-09 Thread De Lara Guarch, Pablo
Hi Anoob, > -Original Message- > From: Anoob Joseph [mailto:anoob.jos...@caviumnetworks.com] > Sent: Thursday, June 14, 2018 11:18 AM > To: Richardson, Bruce ; De Lara Guarch, Pablo > > Cc: Anoob Joseph ; Jerin Jacob > ; Narayana Prasad > ; dev@dpdk.org > Subject: [PATCH v1 01/15] example

Re: [dpdk-dev] [PATCH v7 7/7] igb_uio: fix uio release issue when hot unplug

2018-07-09 Thread Stephen Hemminger
On Mon, 9 Jul 2018 20:01:06 +0800 Jeff Guo wrote: > @@ -195,12 +205,22 @@ igbuio_pci_irqhandler(int irq, void *dev_id) > { > struct rte_uio_pci_dev *udev = (struct rte_uio_pci_dev *)dev_id; > struct uio_info *info = &udev->info; > + struct pci_dev *pdev = udev->pdev; > >

Re: [dpdk-dev] [PATCH v4 3/4] lib/cryptodev: add asymmetric crypto capability in cryptodev

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Tuesday, July 3, 2018 4:24 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > nmur...@caviumnetworks.com; Ashish Gupta > ; Sunila Sahu > ; Umesh Kartha > > Subject:

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Tuesday, July 3, 2018 4:24 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > nmur...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > ; Umesh Kartha > > Subject:

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-09 Thread De Lara Guarch, Pablo
Hi Shally, A few minor comments: > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Tuesday, July 3, 2018 4:24 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > nmur...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupt

Re: [dpdk-dev] [PATCH v4 2/2] test/crypto: add dh and dsa test application

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Thursday, July 5, 2018 4:54 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [PATCH v4 2/2] test/crypto: add dh and dsa te

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

2018-07-09 Thread Eads, Gage
> -Original Message- > From: Wiles, Keith > Sent: Monday, July 9, 2018 5:07 PM > To: Eads, Gage > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped > > > > > On Jul 9, 2018, at 5:00 PM, Wiles, Keith wrote: > > > > > > > >> On Jul 9, 2018, at 4

Re: [dpdk-dev] [PATCH v4 1/2] test/crypto: add rsa and mod test application

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Thursday, July 5, 2018 4:54 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [PATCH v4 1/2] test/crypto: add rsa and mod t

[dpdk-dev] [Bug 59] Cannot start secondary processes anyhow on Redhat EL7

2018-07-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=59 Ajit Khaparde (ajit.khapa...@broadcom.com) changed: What|Removed |Added Resolution|FIXED |INVALID --- Comment #6

[dpdk-dev] [Bug 59] Cannot start secondary processes anyhow on Redhat EL7

2018-07-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=59 Ajit Khaparde (ajit.khapa...@broadcom.com) changed: What|Removed |Added Status|CONFIRMED |RESOLVED

Re: [dpdk-dev] [PATCH] maintainers: update for Mellanox PMDs

2018-07-09 Thread Yongseok Koh
> On Jul 9, 2018, at 3:05 AM, Matan Azrad wrote: > > > > From: Adrien Mazarguil >> Shahaf and Matan volunteered to replace Nélio and myself as maintainers >> for >> mlx4 and mlx5 PMDs. Cheers! >> > > Thanks! Adrien and Nelio, I also want to express my deep gratitude for your pioneering the

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

2018-07-09 Thread Wiles, Keith
> On Jul 9, 2018, at 5:00 PM, Wiles, Keith wrote: > > > >> On Jul 9, 2018, at 4:51 PM, Eads, Gage wrote: >> >> >> +static int +tap_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) +{ + dev->data->rx_queue_state[rx_queue_id] = >>> RTE_ETH_QUEUE_STAT

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

2018-07-09 Thread Wiles, Keith
> On Jul 9, 2018, at 3:20 PM, Eads, Gage wrote: > > Set the rx and tx queue state appropriately when the queues or device are > started or stopped. > > Signed-off-by: Gage Eads Acked-by Keith Wiles Regards, Keith

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

2018-07-09 Thread Wiles, Keith
> On Jul 9, 2018, at 4:51 PM, Eads, Gage wrote: > > > >>> >>> +static int >>> +tap_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) >>> +{ >>> + dev->data->rx_queue_state[rx_queue_id] = >> RTE_ETH_QUEUE_STATE_STARTED; >> >> We need to verify the rx_queue_id is valid before s

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

2018-07-09 Thread Eads, Gage
> > > > +static int > > +tap_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) > > +{ > > + dev->data->rx_queue_state[rx_queue_id] = > RTE_ETH_QUEUE_STATE_STARTED; > > We need to verify the rx_queue_id is valid before setting the state. > > if (rx_queue_id < dev->data>nb_rx_queues

Re: [dpdk-dev] [PATCH] net/tap: set queue started and stopped

2018-07-09 Thread Wiles, Keith
> On Jul 9, 2018, at 3:20 PM, Eads, Gage wrote: > > Set the rx and tx queue state appropriately when the queues or device are > started or stopped. > > Signed-off-by: Gage Eads > --- > drivers/net/tap/rte_eth_tap.c | 56 +-- > 1 file changed, 54 inserti

Re: [dpdk-dev] [PATCH] net/bnx2x: move SPDX tags to source files

2018-07-09 Thread Thomas Monjalon
Hi, 08/07/2018 07:24, Rasesh Mody: > We were using LICENSE.bnx2x_pmd to reference inclusion of SPDX licensing > tag from all the source file. Remove the LICENSE.bnx2x_pmd file and > directly include SPDX tags in source files. > > Signed-off-by: Rasesh Mody > --- a/drivers/net/bnx2x/Makefile > ++

Re: [dpdk-dev] [PATCH] eal: add request to map reserved physical memory

2018-07-09 Thread Scott Branden
On 18-07-09 09:02 AM, Burakov, Anatoly wrote: On 07-Jun-18 1:15 PM, Burakov, Anatoly wrote: On 06-Jun-18 1:18 AM, Scott Branden wrote: Hi Anatoly, On 18-04-27 09:49 AM, Burakov, Anatoly wrote: On 27-Apr-18 5:30 PM, Scott Branden wrote: Hi Anatoly, We'd appreciate your input so we can co

[dpdk-dev] [PATCH] net/pcap: set queue started and stopped

2018-07-09 Thread Gage Eads
Set the rx and tx queue state appropriately when the queues or device are started or stopped. Signed-off-by: Gage Eads --- drivers/net/pcap/rte_eth_pcap.c | 42 + 1 file changed, 42 insertions(+) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/

[dpdk-dev] [PATCH] net/tap: set queue started and stopped

2018-07-09 Thread Gage Eads
Set the rx and tx queue state appropriately when the queues or device are started or stopped. Signed-off-by: Gage Eads --- drivers/net/tap/rte_eth_tap.c | 56 +-- 1 file changed, 54 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c

Re: [dpdk-dev] [PATCH v5] net/mlx4: support hardware TSO

2018-07-09 Thread Matan Azrad
Hi Moti I continue the discussion here in spite of the next version was out just to see the full discussions. From: Mordechay Haimovsky > inline > > > From: Matan Azrad > > Hi Moti > > > > Please see some comments below. > > > > From: Mordechay Haimovsky > > > Implement support for hardware TS

Re: [dpdk-dev] [PATCH v4 1/2] test/crypto: add rsa and mod test application

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Thursday, July 5, 2018 4:54 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [PATCH v4 1/2] test/crypto: add rsa and mod t

Re: [dpdk-dev] [dpdk-users] Traffic doesn't forward on virtual devices

2018-07-09 Thread Aaron Conole
Bala Sankaran writes: > Perfect! > > Thanks for the help. > > - Original Message - >> From: "Keith Wiles" >> To: "Bala Sankaran" >> Cc: us...@dpdk.org, "Aaron Conole" >> Sent: Thursday, July 5, 2018 11:41:46 AM >> Subject: Re: [dpdk-users] Traffic doesn't forward on virtual devices >>

[dpdk-dev] [PATCH v4 8/8] hash: add new API function to query the key count

2018-07-09 Thread Yipeng Wang
Add a new function, rte_hash_count, to return the number of keys that are currently stored in the hash table. Corresponding test functions are added into hash_test and hash_multiwriter test. Signed-off-by: Yipeng Wang Acked-by: Pablo de Lara --- lib/librte_hash/rte_cuckoo_hash.c| 24 +++

[dpdk-dev] [PATCH v4 5/8] hash: add read and write concurrency support

2018-07-09 Thread Yipeng Wang
The existing implementation of librte_hash does not support read-write concurrency. This commit implements read-write safety using rte_rwlock and rte_rwlock TM version if hardware transactional memory is available. Both multi-writer and read-write concurrency is protected by rte_rwlock now. The x8

[dpdk-dev] [PATCH v4 7/8] test: add test case for read write concurrency

2018-07-09 Thread Yipeng Wang
This commits add a new test case for testing read/write concurrency. Signed-off-by: Yipeng Wang Acked-by: Pablo de Lara --- test/test/Makefile | 1 + test/test/test_hash_readwrite.c | 637 2 files changed, 638 insertions(+) create mode 10

[dpdk-dev] [PATCH v4 2/8] hash: fix a multi-writer race condition

2018-07-09 Thread Yipeng Wang
Current multi-writer implementation uses Intel TSX to protect the cuckoo path moving but not the cuckoo path searching. After searching, we need to verify again if the same empty slot still exists at the begining of the TSX region. Otherwise another writer could occupy the empty slot before the TSX

[dpdk-dev] [PATCH v4 4/8] hash: make duplicated code into functions

2018-07-09 Thread Yipeng Wang
This commit refactors the hash table lookup/add/del code to remove some code duplication. Processing on primary bucket can also apply to secondary bucket with same code. Signed-off-by: Yipeng Wang Acked-by: Pablo de Lara --- lib/librte_hash/rte_cuckoo_hash.c | 182 +++---

[dpdk-dev] [PATCH v4 6/8] test: add tests in hash table perf test

2018-07-09 Thread Yipeng Wang
New code is added to support read-write concurrency for rte_hash. Due to the newly added code in critial path, the perf test is modified to show any performance impact. It is still a single-thread test. Signed-off-by: Yipeng Wang Acked-by: Pablo de Lara --- test/test/test_hash_perf.c | 36 +

[dpdk-dev] [PATCH v4 3/8] hash: fix key slot size accuracy

2018-07-09 Thread Yipeng Wang
This commit calculates the needed key slot size more accurately. The previous local cache fix requires the free slot ring to be larger than actually needed. The calculation of the value is inaccurate. Fixes: 5915699153d7 ("hash: fix scaling by reducing contention") Cc: sta...@dpdk.org Signed-off-

[dpdk-dev] [PATCH v4 0/8] Add read-write concurrency to rte_hash library

2018-07-09 Thread Yipeng Wang
This patch set adds the read-write concurrency support in rte_hash. A new flag value is added to indicate if read-write concurrency is needed during creation time. Test cases are implemented to do functional and performance tests. The new concurrency model is based on rte_rwlock. When Intel TSX is

[dpdk-dev] [PATCH v4 1/8] hash: fix multiwriter lock memory allocation

2018-07-09 Thread Yipeng Wang
When malloc for multiwriter_lock, the align should be RTE_CACHE_LINE_SIZE rather than LCORE_CACHE_SIZE. Also there should be check to verify the success of rte_malloc. Fixes: be856325cba3 ("hash: add scalable multi-writer insertion with Intel TSX") Cc: sta...@dpdk.org Signed-off-by: Yipeng Wang

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-09 Thread Verma, Shally
>-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 09 July 2018 22:46 >To: Verma, Shally ; Trahe, Fiona >; Doherty, Declan >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Murthy, Nidadavolu >; Sahu, Sunila ; Gupta, >Ashish ; Kartha, >Umesh

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-09 Thread De Lara Guarch, Pablo
Hi Shally, > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Monday, July 9, 2018 6:12 PM > To: Trahe, Fiona ; Doherty, Declan > ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Athreya, Narayana Prasad > ; Murthy, Nidadavolu > ; Sahu, Sunila ; > Gupta, Ashi

[dpdk-dev] [PATCH 1/2] ethdev: fix MAC changes when live change not supported

2018-07-09 Thread Alejandro Lucero
Current code assumes a MAC change can occur when the port has been started. In fact, there are some NICs which require this port state for being successful, but other NICs not always support MAC change in that case. This patch supports a new device flag for a device advertising this limitation, an

[dpdk-dev] [PATCH 2/2] net/nfp: fix live MAC changes not supported

2018-07-09 Thread Alejandro Lucero
Some NFP firmwares support live changes to the MAC address, but this is not always true and the firmware advertises it accordingly. This patch checks if firmware does not support live changes and sets RTE_ETH_DEV_NOLIVE_MAC_ADDR in that case. Fixes: af75078fece3 ("first public release") Cc: sta..

[dpdk-dev] [PATCH 0/2] support MAC changes when no live changes allowed

2018-07-09 Thread Alejandro Lucero
This is a patched to fix a functionality coming with the first public release: changing/setting MAC address. The original patch assumes all NICs can safely change or set the MAC in any case. However, this is not always true. NFP depends on the firmware capabilities and this is not always supported

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-09 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 09 July 2018 22:15 >To: Doherty, Declan ; Verma, Shally >; De Lara Guarch, Pablo > >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Murthy, Nidadavolu >; Sahu, Sunila ; Gupta, >Ashish ; Kartha, >Umesh ; Trahe,

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-09 Thread Trahe, Fiona
Hi Shally, Declan, Pablo, I'm concerned about rushing in significant last-minute changes, but would like to see this API in 18.08. So I suggest the patchset is applied with the caveat that it is experimental and will continue to be so for the next release, in which the remaining open issues sho

[dpdk-dev] [PATCH v6] net/mlx4: support hardware TSO

2018-07-09 Thread Moti Haimovsky
Implement support for hardware TSO. Signed-off-by: Moti Haimovsky --- v6: * Minor bug fixes from previous commit. * More optimizations on TSO data-segments creation routine. in reply to 1531132986-5054-1-git-send-email-mo...@mellanox.com v5: * Modification to the code according to review inputs

Re: [dpdk-dev] [PATCH v3 7/8] test: add test case for read write concurrency

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, July 6, 2018 8:47 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATCH v3 7/8] test: add

Re: [dpdk-dev] [PATCH v5] net/mlx4: support hardware TSO

2018-07-09 Thread Mordechay Haimovsky
inline > -Original Message- > From: Matan Azrad > Sent: Monday, July 9, 2018 4:07 PM > To: Mordechay Haimovsky ; Adrien Mazarguil > > Cc: dev@dpdk.org > Subject: RE: [PATCH v5] net/mlx4: support hardware TSO > > > > Hi Moti > > Please see some comments below. > > From: Mordechay Haim

Re: [dpdk-dev] [PATCH v3 8/8] hash: add new API function to query the key count

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, July 6, 2018 8:47 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATCH v3 8/8] hash: add

Re: [dpdk-dev] [PATCH] eal: add request to map reserved physical memory

2018-07-09 Thread Burakov, Anatoly
On 07-Jun-18 1:15 PM, Burakov, Anatoly wrote: On 06-Jun-18 1:18 AM, Scott Branden wrote: Hi Anatoly, On 18-04-27 09:49 AM, Burakov, Anatoly wrote: On 27-Apr-18 5:30 PM, Scott Branden wrote: Hi Anatoly, We'd appreciate your input so we can come to a solution of supporting the necessary memo

[dpdk-dev] [PATCH] net/cxgbe: fix init failure due to new flash parts

2018-07-09 Thread Rahul Lakkireddy
Add decode logic for new flash parts shipped with new Chelsio NICs to fix initialization failure on these NICs. Cc: sta...@dpdk.org Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/base/t4_hw.c | 97 -- 1 file changed, 84 insertions(+), 13 deletions(

Re: [dpdk-dev] [PATCH v3 6/8] test: add tests in hash table perf test

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, July 6, 2018 8:47 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATCH v3 6/8] test: add

Re: [dpdk-dev] [PATCH v10 04/19] vfio: remove uneccessary IPC for group fd clear

2018-07-09 Thread Burakov, Anatoly
On 09-Jul-18 4:36 AM, Qi Zhang wrote: Clear vfio_group_fd is not necessary to involve any IPC. Also, current IPC implementation for SOCKET_CLR_GROUP is not correct. rte_vfio_clear_group on secondary will always fail, that prevent device be detached correctly on a secondary process. The patch simp

Re: [dpdk-dev] [PATCH v2 19/20] net/mlx5: add flow MPLS item

2018-07-09 Thread Nélio Laranjeiro
On Fri, Jul 06, 2018 at 05:11:31PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 05:07:51PM +0200, Nelio Laranjeiro wrote: > > Signed-off-by: Nelio Laranjeiro > > --- >[...] > > + if (spec) { > > + memcpy(&mpls.val.label, spec, sizeof(mpls.val.label)); > > + memcpy(&mp

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-09 Thread Doherty, Declan
On 06/07/2018 3:28 PM, Verma, Shally wrote: Hi Declan -Original Message- From: Doherty, Declan [mailto:declan.dohe...@intel.com] Sent: 05 July 2018 20:24 To: Verma, Shally ; pablo.de.lara.gua...@intel.com Cc: dev@dpdk.org; Athreya, Narayana Prasad ; Murthy, Nidadavolu ; Sahu, Sunila ;

Re: [dpdk-dev] [PATCH v2 17/20] net/mlx5: add flow VXLAN-GPE item

2018-07-09 Thread Nélio Laranjeiro
On Fri, Jul 06, 2018 at 04:23:26PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 05:07:49PM +0200, Nelio Laranjeiro wrote: > > Signed-off-by: Nelio Laranjeiro > > --- > > drivers/net/mlx5/mlx5_flow.c | 123 ++- > > 1 file changed, 120 insertions(+), 3 deleti

Re: [dpdk-dev] [PATCH v10 03/19] bus/pci: enable vfio unmap resource for secondary

2018-07-09 Thread Burakov, Anatoly
On 09-Jul-18 4:36 AM, Qi Zhang wrote: Subroutine to unmap VFIO resource is shared by secondary and primary, and it does not work on the secondary process. The patch adds a dedicate function to handle the situation when a device is unmapped on a secondary process. Signed-off-by: Qi Zhang --- H

Re: [dpdk-dev] [PATCH v3 5/8] hash: add read and write concurrency support

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, July 6, 2018 8:47 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATCH v3 5/8] hash: add

Re: [dpdk-dev] [PATCH v3 4/8] hash: make duplicated code into functions

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, July 6, 2018 8:47 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATCH v3 4/8] hash: make

Re: [dpdk-dev] [PATCH v3 3/8] hash: fix to have more accurate key slot size

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, July 6, 2018 8:47 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATCH v3 3/8] hash: fix

Re: [dpdk-dev] [PATCH v3 2/8] hash: fix a multi-writer bug

2018-07-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Friday, July 6, 2018 8:47 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagaraha...@arm.com; > vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com > Subject: [PATCH v3 2/8] hash: fix

Re: [dpdk-dev] [PATCH v2 18/20] net/mlx5: add flow GRE item

2018-07-09 Thread Nélio Laranjeiro
Hi Yongseok, Only discussing here question, other comments are address, as I don't have any objection I'll make the modification for them. On Fri, Jul 06, 2018 at 04:46:11PM -0700, Yongseok Koh wrote: >[...] > > + > > /** Handles information leading to a drop fate. */ > > struct mlx5_flow_verb

Re: [dpdk-dev] [PATCH v7 6/7] eal: add failure handle mechanism for hotplug

2018-07-09 Thread Andrew Rybchenko
On 09.07.2018 15:01, Jeff Guo wrote: This patch introduces a failure handle mechanism to handle device hotplug removal event. First it can register sigbus handler when enable device event monitor. Once sigbus error be captured, it will check the failure address and accordingly remap the invalid

Re: [dpdk-dev] [PATCH v7 5/7] bus: add helper to handle sigbus

2018-07-09 Thread Andrew Rybchenko
On 09.07.2018 15:01, Jeff Guo wrote: This patch aim to add a helper to iterate all buses to find the corresponding bus to handle the sigbus error. Signed-off-by: Jeff Guo Acked-by: Shaopeng He --- v7->v6: no change --- lib/librte_eal/common/eal_common_bus.c | 42 +

Re: [dpdk-dev] [PATCH v2] librte_lpm: Improve performance of the delete and add functions

2018-07-09 Thread Bruce Richardson
On Mon, Jul 09, 2018 at 03:33:44PM +0300, Alex Kiselev wrote: > >> + int ret = rte_hash_lookup_data(lpm->rules_tbl, (void *) &rule_key, > >> + (void **) &rule); > >> + if (ret >= 0) { > >> + /* delete the rule */ > >> + rte_hash_del_key(lpm->rules_tbl, (v

Re: [dpdk-dev] [PATCH v3 1/4] ethdev: Add eal device event callback

2018-07-09 Thread Andrew Rybchenko
On 09.07.2018 14:46, Jeff Guo wrote: Implement a eal device event callback "rte_eth_dev_event_callback" in ethdev, it could let pmd driver have chance to manage the eal device event, such as process hotplug event.  > Signed-off-by: Jeff Guo --- v3->v2: add new callback in ethdev --- doc/guid

Re: [dpdk-dev] [PATCH v2 13/20] net/mlx5: add RSS flow action

2018-07-09 Thread Nélio Laranjeiro
On Fri, Jul 06, 2018 at 05:35:22PM +, Yongseok Koh wrote: > > > On Jul 6, 2018, at 8:59 AM, Nélio Laranjeiro > > wrote: > > > > Hi Yongseok, > > > > I am only addressing your questions concerns here, almost all other > > points I also agree with them. > > > > On Thu, Jul 05, 2018 at 07:16

Re: [dpdk-dev] [PATCH v5] net/mlx4: support hardware TSO

2018-07-09 Thread Matan Azrad
Hi Moti Please see some comments below. From: Mordechay Haimovsky > Implement support for hardware TSO. > > Signed-off-by: Moti Haimovsky > --- > v5: > * Modification to the code according to review inputs from Matan > Azrad. > * Code optimization to the TSO header copy routine. > * Rearr

Re: [dpdk-dev] [PATCH] net/i40e: fix fail to set TPID with AQ command

2018-07-09 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Thursday, July 5, 2018 3:03 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Wu, Jingjing ; Zheng, James > ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix fail to set TPID with AQ command > > TPID can be set by set_switch_config AdminQ comma

  1   2   >