Since now we can use driver to management the eal event for hotplug,
so no need to register dev event callback in app anymore. This patch
remove the related code.
Signed-off-by: Jeff Guo
---
v2->v1:
no change.
---
app/test-pmd/testpmd.c | 76 --
1
This patch aim to enable hotplug detect in i40e pmd driver. Firstly it
set the flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug
ability, and then use rte_dev_event_callback_register to register
the hotplug event callback to eal. When eal detect the hotplug event,
it will call the cal
This patch aim to enable hotplug detect in ixgbe pmd driver. Firstly it
set the flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug
ability, and then use rte_dev_event_callback_register to register
the hotplug event callback to eal. When eal detect the hotplug event,
it will call the ca
As we may know, we have eal event for rte device hotplug and ethdev event
for ethdev hotplug. Some ethdev need to use eal event to detect hotplug
behaviors, the privors way is register eal event callback in app, but
seems that it will have some race between these 2 event process. In oder
to fix the
This patch introduces a failure handle mechanism to handle device
hotplug removal event.
First it can register sigbus handler when enable device event monitor. Once
sigbus error be captured, it will check the failure address and accordingly
remap the invalid memory for the corresponding device. Be
When hotplug out device, the kernel will release the device resource in the
kernel side, such as the fd sys file will disappear, and the irq will be
released. At this time, if igb uio driver still try to release this
resource, it will cause kernel crash. On the other hand, something like
interrupt
This patch aim to add a helper to iterate all buses to find the
corresponding bus to handle the sigbus error.
Signed-off-by: Jeff Guo
Acked-by: Shaopeng He
---
v6->v5:
refine some coding style.
---
lib/librte_eal/common/eal_common_bus.c | 42 ++
lib/librte_eal/co
When device be hotplug out, if data path still read/write device, the
sigbus error will occur, this error need to be handled. So a handler
need to be here to capture the signal and handle it correspondingly.
This patch introduces a bus ops to handle sigbus error, it is a bus
specific behavior, so
This patch implements the ops of sigbus handler for PCI bus, it is
functional to find the corresponding pci device which is been hotplug
out, and then call the bus ops of hotplug failure handler to handle
the failure for the device.
Signed-off-by: Jeff Guo
Acked-by: Shaopeng He
---
v6->v5:
refin
This patch implements the ops of hotplug failure handler for PCI bus,
it is functional to remap a new dummy memory which overlap to the
failure memory to avoid MMIO read/write error.
Signed-off-by: Jeff Guo
Acked-by: Shaopeng He
---
v6->v5:
refine some typo
---
drivers/bus/pci/pci_common.c
As we know, hot plug is an importance feature, either use for the datacenter
device’s fail-safe, or use for SRIOV Live Migration in SDN/NFV. It could bring
the higher flexibility and continuality to the networking services in multiple
use cases in industry. So let we see, dpdk as an importance netw
When device be hotplug out, if app still continue to access device by mmio,
it will cause of memory failure and result the system crash.
This patch introduces a bus ops to handle device hotplug failure, it is a
bus specific behavior, so each kind of bus can implement its own logic case
by case.
S
CC Shreyansh
On 09.07.2018 09:01, Jeff Guo wrote:
This patch introduces a failure handle mechanism to handle device
hotplug removal event.
First it can register sigbus handler when enable device event monitor. Once
sigbus error be captured, it will check the failure address and accordingly
rema
Hi Rasesh,
There is a problem with these patches.
The SPDX shall be first line for *.c, *.h and Makefiles. It shall come before
the copyright statements.
Regards,
Hemant
diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile
index c30a867..45ad579 100644
--- a/drivers/net/q
On 09.07.2018 09:01, Jeff Guo wrote:
This patch aim to add a helper to iterate all buses to find the
corresponding bus to handle the sigbus error.
Signed-off-by: Jeff Guo
Acked-by: Shaopeng He
---
v6->v5:
refine some coding style.
---
lib/librte_eal/common/eal_common_bus.c | 42 +
When hotplug out device, the kernel will release the device resource in the
kernel side, such as the fd sys file will disappear, and the irq will be
released. At this time, if igb uio driver still try to release this
resource, it will cause kernel crash. On the other hand, something like
interrupt
This patch implements the ops of sigbus handler for PCI bus, it is
functional to find the corresponding pci device which is been hotplug
out, and then call the bus ops of hotplug failure handler to handle
the failure for the device.
Signed-off-by: Jeff Guo
Acked-by: Shaopeng He
---
v6->v5:
refin
This patch introduces a failure handle mechanism to handle device
hotplug removal event.
First it can register sigbus handler when enable device event monitor. Once
sigbus error be captured, it will check the failure address and accordingly
remap the invalid memory for the corresponding device. Be
This patch aim to add a helper to iterate all buses to find the
corresponding bus to handle the sigbus error.
Signed-off-by: Jeff Guo
Acked-by: Shaopeng He
---
v6->v5:
refine some coding style.
---
lib/librte_eal/common/eal_common_bus.c | 42 ++
lib/librte_eal/co
This patch implements the ops of hotplug failure handler for PCI bus,
it is functional to remap a new dummy memory which overlap to the
failure memory to avoid MMIO read/write error.
Signed-off-by: Jeff Guo
Acked-by: Shaopeng He
---
v6->v5:
refine some typo
---
drivers/bus/pci/pci_common.c
When device be hotplug out, if data path still read/write device, the
sigbus error will occur, this error need to be handled. So a handler
need to be here to capture the signal and handle it correspondingly.
This patch introduces a bus ops to handle sigbus error, it is a bus
specific behavior, so
When device be hotplug out, if app still continue to access device by mmio,
it will cause of memory failure and result the system crash.
This patch introduces a bus ops to handle device hotplug failure, it is a
bus specific behavior, so each kind of bus can implement its own logic case
by case.
S
As we know, hot plug is an importance feature, either use for the datacenter
device’s fail-safe, or use for SRIOV Live Migration in SDN/NFV. It could bring
the higher flexibility and continuality to the networking services in multiple
use cases in industry. So let we see, dpdk as an importance netw
HI Declan, Pablo
Could we please close on this asap?
Thanks
Shally
>-Original Message-
>From: Verma, Shally
>Sent: 06 July 2018 19:59
>To: 'Doherty, Declan' ;
>pablo.de.lara.gua...@intel.com
>Cc: dev@dpdk.org; Athreya, Narayana Prasad
>; Murthy, Nidadavolu
>; Sahu, Sunila ; Gupta,
>As
On 7/8/2018 9:46 PM, Andrew Rybchenko wrote:
On 05.07.2018 10:38, Jeff Guo wrote:
This patch introduces a failure handler mechanism to handle device
hot plug removal event.
First register sigbus handler, once sigbus error be captured, will
check the failure address and accordingly remap the
hi, andrew
Thanks for your reviewing.
On 7/8/2018 9:30 PM, Andrew Rybchenko wrote:
On 05.07.2018 10:38, Jeff Guo wrote:
This patch aim to add a helper to iterate all buses to find the
corresponding bus to handle the sigbus error.
Signed-off-by: Jeff Guo
---
v5->v4:
refine the errno restore l
hi, shaopeng
thanks for your review.
On 7/6/2018 11:22 PM, He, Shaopeng wrote:
-Original Message-
From: Guo, Jia
Sent: Thursday, July 5, 2018 3:39 PM
This patch aim to add a helper to iterate all buses to find the
corresponding bus to handle the sigbus error.
[...]
+ bus = r
hi, shaopeng
On 7/6/2018 11:17 PM, He, Shaopeng wrote:
-Original Message-
From: Guo, Jia
Sent: Thursday, July 5, 2018 3:39 PM
[...]
+ switch (pdev->kdrv) {
+ case RTE_KDRV_IGB_UIO:
+ case RTE_KDRV_UIO_GENERIC:
+ case RTE_KDRV_NIC_UIO:
+ /* mmio r
Update release notes for the new multi-process hotplug feature.
Signed-off-by: Qi Zhang
---
doc/guides/rel_notes/release_18_08.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/doc/guides/rel_notes/release_18_08.rst
b/doc/guides/rel_notes/release_18_08.rst
index bc0124295..12
The sample code demonstrates device (ethdev only) management
at a multi-process environment. The user can attach/detach a
device on primary process and see it is synced on secondary
process automatically.
How to start?
./hotplug_mp --proc-type=auto
Command Line Example:
>help
>list
/* attach a
Attach port from secondary should ignore devargs since the private
device is not necessary to support. Also previously, detach port on
a secondary process will mess primary process and cause the same
device can't be attached back again. A secondary process should use
rte_eth_release_port_private to
Attach port from secondary should ignore devargs since the private
device is not necessary to support. Also previously, detach port on
a secondary process will mess primary process and cause the same
device can't be attached back again. A secondary process should use
rte_eth_release_port_private to
Attach port from secondary should ignore devargs since the private
device is not necessary to support. Also previously, detach port on
a secondary process will mess primary process and cause the same
device can't be attached back again. A secondary process should use
rte_eth_release_port_private to
Attach port from secondary should ignore devargs since the private
device is not necessary to support. Also previously, detach port on
a secondary process will mess primary process and cause the same
device can't be attached back again. A secondary process should use
rte_eth_release_port_private to
Attach port from secondary should ignore devargs since the private
device is not necessary to support. Also previously, detach port on
a secondary process will mess primary process and cause the same
device can't be attached back again. A secondary process should use
rte_eth_release_port_private to
Attach port from secondary should ignore devargs since the private
device is not necessary to support. Also previously, detach port on
a secondary process will mess primary process and cause the same
device can't be attached back again. A secondary process should use
rte_eth_release_port_private to
Attach port from secondary should ignore devargs since the private
device is not necessary to support. Also previously, detach port on
a secondary process will mess primary process and cause the same
device can't be attached back again. A secondary process should use
rte_eth_release_port_private to
Previously, detach port on a secondary process will mess primary
process and cause the same device can't be attached back again.
A secondary process should use rte_eth_release_port_private to
release a port.
Signed-off-by: Qi Zhang
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++
1 file changed, 3
Attach port from secondary should ignore devargs since the private
device is not necessary to support. Also previously, detach port on
a secondary process will mess primary process and cause the same
device can't be attached back again. A secondary process should use
rte_eth_release_port_private to
Attach port from secondary should ignore devargs since the private
device is not necessary to support. Also previously, detach port on
a secondary process will mess primary process and cause the same
device can't be attached back again. A secondary process should use
rte_eth_release_port_private to
Previously, detach port on a secondary process will mess primary
process and cause the same device can't be attached back again.
A secondary process should use rte_eth_release_port_private to
release a port.
Signed-off-by: Qi Zhang
---
drivers/net/i40e/i40e_ethdev.c | 2 ++
1 file changed, 2 ins
This patch cover the multi-process hotplug case when a device
attach/detach request be issued from a secondary process
device attach on secondary:
a) secondary send sync request to the primary.
b) primary receive the request and attach the new device if
failed goto i).
c) primary forward attach
Clear vfio_group_fd is not necessary to involve any IPC.
Also, current IPC implementation for SOCKET_CLR_GROUP is not
correct. rte_vfio_clear_group on secondary will always fail,
that prevent device be detached correctly on a secondary process.
The patch simply removes all IPC related stuff in
rte_
When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr)
is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr
is valid. So compare the 8th byte will cause the unexpected result, which
happens when repeatedly attach/detach a device.
Fixes: c752998b5e2e ("pci: int
We are going to introduce the solution to handle hotplug in
multi-process, it includes the below scenario:
1. Attach a device from the primary
2. Detach a device from the primary
3. Attach a device from a secondary
4. Detach a device from a secondary
In the primary-secondary process model, we ass
Subroutine to unmap VFIO resource is shared by secondary and
primary, and it does not work on the secondary process.
The patch adds a dedicate function to handle the situation
when a device is unmapped on a secondary process.
Signed-off-by: Qi Zhang
---
drivers/bus/pci/linux/pci_vfio.c | 75
v10:
Since hotplug add/remove a vdev on a secondary process will sync on
all processes now, it is not necessary to support private vdev for
a secondary process which is identified by a not-NULL devargs in
"--vdev". So re-work on all vdev driver changes to simpified device
probe scenario o
Add driver API rte_eth_release_port_private to support the
case when an ethdev need to be detached on a secondary process.
Local state is set to unused and shared data will not be reset
so the primary process can still use it.
Signed-off-by: Qi Zhang
Reviewed-by: Andrew Rybchenko
Acked-by: Remy
On Fri, Jul 06, 2018 at 09:07:10AM +0200, Maxime Coquelin wrote:
[...]
> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> index bea6a0428..dca43ff00 100644
> --- a/lib/librte_vhost/vhost_user.c
> +++ b/lib/librte_vhost/vhost_user.c
> @@ -467,6 +467,27 @@ translate_ring_a
On Fri, Jul 06, 2018 at 09:04:44AM +0200, Maxime Coquelin wrote:
> This series is again preliminray work to ease packed ring
> layout integration.
>
> Main changes are using vector buffres also in the dequeue
> path, and perform IOVA to HVA translation at vectors fill
> time.
>
> I still have to
On Fri, Jul 06, 2018 at 09:07:07AM +0200, Maxime Coquelin wrote:
> This series is a handover from Jen's "[PATCH v4 00/20]
> implement packed virtqueues", which only implements the
> vhost side. Virtio PMD implementation will follow in a
> next series.
>
> The series applies on top of previous rew
Add an iterator over the LPM rules.
The iterator requires a prefix as a parameter and
lists all entries as long as the given prefix (or longer).
Signed-off-by: Qiaobin Fu
Reviewed-by: Cody Doucette
Reviewed-by: Michel Machado
---
lib/librte_lpm/rte_lpm.c | 99 +
Hi Ferruh,
Can you please send me the output of "gcc -v" on your system ?
Moti
> -Original Message-
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com]
> Sent: Wednesday, July 4, 2018 4:49 PM
> To: Mordechay Haimovsky ; Shahaf Shuler
>
> Cc: Adrien Mazarguil ; dev@dpdk.org
> Subject: R
On 05.07.2018 10:38, Jeff Guo wrote:
This patch introduces a failure handler mechanism to handle device
hot plug removal event.
First register sigbus handler, once sigbus error be captured, will
check the failure address and accordingly remap the invalid memory
for the corresponding device. Bese
On 05.07.2018 10:38, Jeff Guo wrote:
This patch aim to add a helper to iterate all buses to find the
corresponding bus to handle the sigbus error.
Signed-off-by: Jeff Guo
---
v5->v4:
refine the errno restore logic
---
lib/librte_eal/common/eal_common_bus.c | 36 +++
Sorry,
please disregard this mail and delete it.
Ori
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ori Kam
> Sent: Sunday, July 8, 2018 1:23 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] my git config file
>
> [orika@vnc1 ~]$ cat .gitconfig
> [user]
>
[orika@vnc1 ~]$ cat .gitconfig
[user]
email = or...@mellanox.com
[sendemail]
suppressfrom = true
confirm = always
suppresscc = self
envelopsender = or...@mellanox.com
smtpUser = or...@mellanox.com
smtpEncryption = tls
smtpServer = smt
Adrien, Nelio,
I will use this opportunity to thank you for all the hard work and investment
on those PMD.
You did a wonderful job maintaining those.
Thursday, July 5, 2018 12:20 PM, Adrien Mazarguil:
> Subject: [PATCH] maintainers: update for Mellanox PMDs
>
> Shahaf and Matan volunteered to
58 matches
Mail list logo
