[dpdk-dev] [PATCH v5] net/ixgbe: fix mask bits register set error for FDIR

2018-06-14 Thread Wei Zhao
MAC address bits in mask registers should be set to zero when the is mac mask is 0xFF, otherwise if it is 0x0 these bits should be to 0x3F. Fixes: 82fb702077f6 ("ixgbe: support new flow director modes for X550") Signed-off-by: Wei Zhao --- v2: -change mask bits set method to support more mac m

[dpdk-dev] [PATCH v3] net/i40e: illagel pactket checking

2018-06-14 Thread Yanglong Wu
Some illegal packets will lead to TX/RX hang and can't recover automatically. This pacth check those illegal packets and protect TX/RX from hanging. Signed-off-by: Yanglong Wu --- v2: fix coding style issue and error --- v3: rework as comments --- drivers/net/i40e/i40e_rxtx.c | 15 +++---

[dpdk-dev] [PATCH] event/octeontx: fix flush callback

2018-06-14 Thread Pavan Nikhilesh
When event queues are being flushed the getwork operation used to extract events should be a grouped getwork operation to the specific event queue. Fixes: 8384f0e039ea ("event/octeontx: support device stop flush callback") Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/ssovf_worker.c

Re: [dpdk-dev] [PATCH] crypto/virtio: fix iv physical address

2018-06-14 Thread Zhoujian (jay)
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, June 14, 2018 8:39 PM > To: Fan Zhang ; dev@dpdk.org > Cc: pablo.de.lara.gua...@intel.com; Zhoujian (jay) ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] crypto/virtio: fix iv physical a

[dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args

2018-06-14 Thread Pavan Nikhilesh
Currently, the only way of supplying device argument to a pci device is to whitelist it i.e. -w 000X:00:0X.0,self_test=1. This is not a very feasible method as whitelisting a device has its own side effects i.e only the whitelisted pci devices are probed. Add a new eal command line option --pci-ar

Re: [dpdk-dev] [PATCH] crypto/virtio: fix iv physical address

2018-06-14 Thread Zhoujian (jay)
Hi Fan, > -Original Message- > From: Fan Zhang [mailto:roy.fan.zh...@intel.com] > Sent: Thursday, June 14, 2018 7:03 PM > To: dev@dpdk.org > Cc: pablo.de.lara.gua...@intel.com; Zhoujian (jay) ; > sta...@dpdk.org > Subject: [PATCH] crypto/virtio: fix iv physical address > > The physical ad

[dpdk-dev] [PATCH] eventdev: update get id from name to include PCI devices

2018-06-14 Thread Pavan Nikhilesh
Currently, rte_event_dev_get_dev_id works only for virtual devices(vdev) update the function to include devices probed through pci. Signed-off-by: Pavan Nikhilesh --- lib/librte_eventdev/rte_eventdev.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/librt

[dpdk-dev] [PATCH v4] net/ixgbe: fix mask bits register set error for FDIR

2018-06-14 Thread Wei Zhao
MAC address bits in mask registers should be set to zero when the is mac mask is 0xFF, otherwise if it is 0x0 these bits should be to 0x3F. Fixes: 82fb702077f6 ("ixgbe: support new flow director modes for X550") Signed-off-by: Wei Zhao --- v2: -change mask bits set method to support more mac m

[dpdk-dev] [PATCH v3] net/ixgbe: fix mask bits register set error for FDIR

2018-06-14 Thread Wei Zhao
MAC address bits in mask registers should be set to zero when the is mac mask is 0xFF, otherwise if it is 0x0 these bits should be to 0x3F. Fixes: 82fb702077f6 ("ixgbe: support new flow director modes for X550") Signed-off-by: Wei Zhao --- v2: -change mask bits set method to support more mac m

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix tunnel type set error for FDIR

2018-06-14 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Zhao1, Wei > Sent: Thursday, June 14, 2018 4:17 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; sta...@dpdk.org; Zhao1, Wei > > Subject: [PATCH v3] net/ixgbe: fix tunnel type set error for FDIR > > Tunnel type format should be translated to ixgbe required form

Re: [dpdk-dev] [PATCH v2 1/2] testpmd: use RFC values for Tx address and port

2018-06-14 Thread Stephen Hemminger
On Thu, 14 Jun 2018 10:17:46 + "Iremonger, Bernard" wrote: > Hi Stephen, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen > > Hemminger > > Sent: Monday, June 11, 2018 7:25 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; Stephen > > Hemmin

Re: [dpdk-dev] [PATCH v2] net/pcap: rx_iface_in stream type support

2018-06-14 Thread Ido Goshen
I use "rx_iface","tx_iface" (and not just "iface") in order to have multiple TX queues I just gave a simplified setting with 1 queue My app does a full mesh between the ports (not fixed pairs like l2fwd) so all the forwarding lcores can tx to the same port simultaneously and as DPDK docs say: "M

Re: [dpdk-dev] [PATCH v2] net/pcap: rx_iface_in stream type support

2018-06-14 Thread Ido Goshen
I think we are starting to mix two things One is how to configure pcap eth dev with multiple queues and I totally agree it would have been nicer to just say something like "max_tx_queues =N" instead of needing to write "tx_iface" N times, but as it was already supported in that way (for any reas

Re: [dpdk-dev] [RFC] hot plug failure handle mechanism

2018-06-14 Thread Thomas Monjalon
Hi, I am sorry, it is very hard to be sure we understand correctly your thougths. I like the proposal, but I want to be sure my understanding was not biased by what I would like to read :) So I try to reword below. Please confirm it matches your intent. Hot unplug can happen when a hardware devic

Re: [dpdk-dev] [PATCH] drivers/bonding: fix bond mac address reset

2018-06-14 Thread Chas Williams
On Thu, Jun 14, 2018 at 12:49 PM Ferruh Yigit wrote: > On 5/23/2018 10:11 AM, Kiran Kumar wrote: > > Currently when resetting bond mac address, we are getting the > > persisted mac address from slave info considering primary port > > as index. But we need to compare the port id from slave info >

Re: [dpdk-dev] [PATCH] net/bonding: set dev_started later

2018-06-14 Thread Chas Williams
No. This was fixed by net/bonding: clear started state if start fails There are several error paths where the bonding device may not start. Clear dev_started before we return if we take one of these paths. Fixes: 2efb58cbab6e ("bond: new link bonding library") Cc: sta...@dpd

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: add sanity checks when retrieving xstats

2018-06-14 Thread Remy Horton
On 14/06/2018 11:55, Ferruh Yigit wrote: On 6/14/2018 7:39 AM, Remy Horton wrote: On 13/06/2018 16:39, Ferruh Yigit wrote: On 6/7/2018 9:15 AM, David Marchand wrote: Testpmd should not expect the xstats names and values arrays to be aligned: neither the arrays sizes, nor the order in which

Re: [dpdk-dev] [PATCH v2] net/pcap: rx_iface_in stream type support

2018-06-14 Thread Ferruh Yigit
On 6/14/2018 6:14 PM, Ido Goshen wrote: > I use "rx_iface","tx_iface" (and not just "iface") in order to have multiple > TX queues > I just gave a simplified setting with 1 queue > My app does a full mesh between the ports (not fixed pairs like l2fwd) so > all the forwarding lcores can tx to the

Re: [dpdk-dev] [PATCH v2 2/2] doc/guides: updated testpmd app user guide for vxlan/nvgre encap/decap

2018-06-14 Thread Ferruh Yigit
On 6/14/2018 6:14 PM, Ferruh Yigit wrote: > On 5/14/2018 4:42 PM, Mohammad Abdul Awal wrote: >> >> >> On 14/05/2018 11:35, Iremonger, Bernard wrote: >>> Hi Awal, >>> -Original Message- From: Awal, Mohammad Abdul Sent: Friday, May 11, 2018 6:14 PM To: dev@dpdk.org; Iremon

Re: [dpdk-dev] [PATCH v2 2/2] doc/guides: updated testpmd app user guide for vxlan/nvgre encap/decap

2018-06-14 Thread Ferruh Yigit
On 5/14/2018 4:42 PM, Mohammad Abdul Awal wrote: > > > On 14/05/2018 11:35, Iremonger, Bernard wrote: >> Hi Awal, >> >>> -Original Message- >>> From: Awal, Mohammad Abdul >>> Sent: Friday, May 11, 2018 6:14 PM >>> To: dev@dpdk.org; Iremonger, Bernard ; >>> adrien.mazarg...@6wind.com >>> S

Re: [dpdk-dev] [PATCH] net/bonding: set dev_started later

2018-06-14 Thread Ferruh Yigit
On 3/16/2018 4:34 PM, Chas Williams wrote: > From: "Charles (Chas) Williams" > > There are several error paths where the bonding device may not start. > Don't set dev_started until we know that we are sure start is going > to succeed. > > Fixes: 2efb58cbab ("bond: new link bonding library") > Cc

Re: [dpdk-dev] [PATCH 2/2] net/bonding: always update bonding link status

2018-06-14 Thread Ferruh Yigit
On 5/18/2018 12:22 AM, Chas Williams wrote: > From: Chas Williams > > When the first ETH_LINK_UP slave is added to a bonding device, it is > immediately activated. If these are polling slaves, there will be a > later link state event, when last_link_status doesn't match link_status. > But becaus

Re: [dpdk-dev] [PATCH] net/bonding: fix link properties with autoneg

2018-06-14 Thread Ferruh Yigit
On 4/16/2018 8:09 PM, Matan Azrad wrote: > Hi Chas > > From: Chas Williams, Monday, April 16, 2018 7:44 PM >> On Mon, Apr 16, 2018 at 4:06 AM, Matan Azrad >> wrote: >>> Hi Chas >>> >>> From: Chas Williams, Wednesday, February 14, 2018 12:55 AM If a link is carrier down and using autonegotiat

Re: [dpdk-dev] [PATCH] drivers/bonding: fix bond mac address reset

2018-06-14 Thread Ferruh Yigit
On 5/23/2018 10:11 AM, Kiran Kumar wrote: > Currently when resetting bond mac address, we are getting the > persisted mac address from slave info considering primary port > as index. But we need to compare the port id from slave info > with the primary port to get the primary slave index and get >

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] mbuf: fix RTE_ETH_IS_IPV6_HDR comment typo

2018-06-14 Thread Ferruh Yigit
On 6/14/2018 4:09 AM, Haiyue Wang wrote: > It should be IPv6, not IPv4. > > Cc: sta...@dpdk.org > > Signed-off-by: Haiyue Wang Reviewed-by: Ferruh Yigit cc'ed Olivier.

Re: [dpdk-dev] [PATCH v2 00/15] add meson support for more net drivers

2018-06-14 Thread Ferruh Yigit
On 6/8/2018 10:20 PM, Bruce Richardson wrote: > A number of net drivers require pretty minimal meson.build files to build > successfully with meson. This set adds support for 14 net drivers to the > build. > > V2: Small change to net/kni patch to ensure 32-bit builds ok. > > Bruce Richardson (15)

Re: [dpdk-dev] [PATCH v2] net/i40e: add a specific API to control the LLDP agent

2018-06-14 Thread Ferruh Yigit
On 5/24/2018 2:32 AM, Zijie Pan wrote: > Add a new API rte_pmd_i40e_set_lldp_cmd to control LLDP agent for i40e. > It supports the following i40e debug lldp commands: > - start/stop of the LLDP agent. > - get local/remote of the LLDP MIB (Management Information Base). > > Signed-off-by: La

Re: [dpdk-dev] Mlx meson build

2018-06-14 Thread Stephen Hemminger
On Thu, 14 Jun 2018 11:05:23 + Shahaf Shuler wrote: > Thursday, June 14, 2018 11:35 AM, Thomas Monjalon : > > Subject: Re: Mlx meson build > > > > 14/06/2018 10:15, Bruce Richardson: > > > On Wed, Jun 13, 2018 at 03:14:16PM -0700, Stephen Hemminger wrote: > > > > Is there any chance of g

Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools/test-meson-build: fix CC override for cross builds

2018-06-14 Thread Thomas Monjalon
08/06/2018 12:35, Bruce Richardson: > For cross-builds the CC environmental variable only applies for compiling > native binaries i.e. pmdinfogen, so setting it to a cross-build compiler > will only cause problems. Leave the value unset in the script to use the > platform-default compiler. > > Fix

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix crash when attaching a device

2018-06-14 Thread Ferruh Yigit
On 6/14/2018 3:56 PM, Iremonger, Bernard wrote: > > >> -Original Message- >> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] >> Sent: Wednesday, June 13, 2018 5:28 PM >> To: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> >> Cc: dev@dpdk.org; sta...@dpdk.org; Singh, Jasv

Re: [dpdk-dev] [PATCH 0/2] maintainers: updates for Vhost and Virtio

2018-06-14 Thread Thomas Monjalon
12/06/2018 10:01, Maxime Coquelin: > Hi, > > Since Jianfeng & Yuanhan resignation, I was the only active > maintainer for Vhost lib and PMD, and I had no backup for > managing the next-virtio tree. > > Contacted offline, Tetsuya has kindly accepted to remove > himself from the Vhost PMD maintaine

[dpdk-dev] [PATCH 1/2] app/testpmd: add VXLAN encap/decap support

2018-06-14 Thread Nelio Laranjeiro
Due to the complex VXLAN_ENCAP flow action and based on the fact testpmd does not allocate memory, this patch adds a new command in testpmd to initialise a global structure containing the necessary information to make the outer layer of the packet. This same global structure will then be used by t

[dpdk-dev] [PATCH 2/2] app/testpmd: add NVGRE encap/decap support

2018-06-14 Thread Nelio Laranjeiro
Due to the complex NVGRE_ENCAP flow action and based on the fact testpmd does not allocate memory, this patch adds a new command in testpmd to initialise a global structure containing the necessary information to make the outer layer of the packet. This same global structure will then be used by t

[dpdk-dev] [PATCH 0/2] implement VXLAN/NVGRE Encap/Decap in testpmd

2018-06-14 Thread Nelio Laranjeiro
This series adds an easy and maintainable configuration version support for those two actions for 18.08 by using global variables in testpmd to store the necessary information for the tunnel encapsulation. Those variables are used in conjunction of RTE_FLOW_ACTION_{VXLAN,NVGRE}_ENCAP action to cre

Re: [dpdk-dev] [PATCH] app/testpmd: fix crash when attaching a device

2018-06-14 Thread Iremonger, Bernard
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Wednesday, June 13, 2018 5:28 PM > To: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Cc: dev@dpdk.org; sta...@dpdk.org; Singh, Jasvinder > ; Xueming(steven) Li > > Subject: [PATCH] app/tes

Re: [dpdk-dev] [PATCH v2 06/15] net/ena: add to meson build

2018-06-14 Thread Ferruh Yigit
On 6/8/2018 10:20 PM, Bruce Richardson wrote: > CC: Marcin Wojtas > CC: Michal Krawczyk > CC: Guy Tzalik > CC: Evgeny Schemeilin > Signed-off-by: Bruce Richardson > --- > drivers/net/ena/meson.build | 8 > drivers/net/meson.build | 3 ++- > 2 files changed, 10 insertions(+), 1 de

Re: [dpdk-dev] [PATCH v2 00/15] add meson support for more net drivers

2018-06-14 Thread Ferruh Yigit
On 6/8/2018 10:20 PM, Bruce Richardson wrote: > A number of net drivers require pretty minimal meson.build files to build > successfully with meson. This set adds support for 14 net drivers to the > build. > > V2: Small change to net/kni patch to ensure 32-bit builds ok. > > Bruce Richardson (15)

Re: [dpdk-dev] [PATCH v2 05/15] net/cxgbe: add to meson build

2018-06-14 Thread Ferruh Yigit
On 6/8/2018 10:20 PM, Bruce Richardson wrote: > CC: Rahul Lakkireddy > Signed-off-by: Bruce Richardson > --- > drivers/net/cxgbe/meson.build | 11 +++ > drivers/net/meson.build | 2 +- > 2 files changed, 12 insertions(+), 1 deletion(-) > create mode 100644 drivers/net/cxgbe/meson

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the checksum forwarding engine

2018-06-14 Thread Iremonger, Bernard
Hi Jiayu, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jiayu Hu > Sent: Tuesday, May 29, 2018 8:41 AM > To: dev@dpdk.org > Cc: Ananyev, Konstantin ; Hu, Jiayu > > Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: enable UDP GSO in the > checksum forwarding engine

Re: [dpdk-dev] [PATCH v7 01/22] kvargs: build before EAL

2018-06-14 Thread Bruce Richardson
On Sun, Apr 15, 2018 at 05:07:30PM +0200, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > lib/Makefile | 3 +-- > lib/librte_eal/common/Makefile| 2 +- > lib/librte_kvargs/Makefile

Re: [dpdk-dev] [PATCH v2 0/5] crypto/qat: move to dynamic logging

2018-06-14 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Jozwiak > Sent: Thursday, June 14, 2018 12:03 PM > To: Trahe, Fiona ; Jozwiak, TomaszX > ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 0/5] crypto/qat: move to dynamic logging > > Note this patchset is t

[dpdk-dev] [PATCH v2 2/2] event/sw: support device stop flush callback

2018-06-14 Thread Gage Eads
This commit also adds a flush callback test to the sw eventdev's selftest suite. Signed-off-by: Gage Eads Acked-by: Harry van Haaren --- drivers/event/sw/sw_evdev.c | 114 ++- drivers/event/sw/sw_evdev_selftest.c | 81 - 2 files

[dpdk-dev] [PATCH v2 1/2] service: add mechanism for quiescing a service

2018-06-14 Thread Gage Eads
Existing service functions allow us to stop a service, but doing so doesn't guarantee that the service has finished running on a service core. This commit introduces rte_service_may_be_active(), which returns whether the service may be executing on one or more lcores currently, or definitely is not

[dpdk-dev] [PATCH v2 0/2] Improve service stop support

2018-06-14 Thread Gage Eads
Existing service functions allow us to stop a service, but doing so doesn't guarantee that the service has finished running on a service core. This patch set introduces a function, rte_service_may_be_active(), to check whether a stopped service is truly stopped. This is needed for flows that modif

[dpdk-dev] [PATCH v8] checkpatches.sh: Add checks for ABI symbol addition

2018-06-14 Thread Neil Horman
Recently, some additional patches were added to allow for programmatic marking of C symbols as experimental. The addition of these markers is dependent on the manual addition of exported symbols to the EXPERIMENTAL section of the corresponding libraries version map file. The consensus on review i

Re: [dpdk-dev] [PATCH] net/nfp: fix field initialization in TX descriptor

2018-06-14 Thread Alejandro Lucero
Hi Ferruh, On Thu, Jun 14, 2018 at 10:17 AM, Ferruh Yigit wrote: > On 6/11/2018 10:50 AM, Alejandro Lucero wrote: > > TX descriptor eop_offset field is not initialized and it could > > contain garbage. This patch fixes the potential problem setting > > EOP as the only subfield. The other subfiel

[dpdk-dev] [PATCH] rawdev: remove experimental flag

2018-06-14 Thread Shreyansh Jain
Besides the librawdev, removing experimental from skeleton_rawdev dummy driver as well. Signed-off-by: Shreyansh Jain --- Note: Dependent drivers, (dpaa2_cmdif, dpaa2_qdma and ifpga) cannot be updated in this patch as are dependent on some other symbols (rte_mem_virt2memseg and rte_e

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: add set topology on the fly command

2018-06-14 Thread Iremonger, Bernard
Hi Wisam, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wisam Jaddo > Sent: Wednesday, May 9, 2018 1:47 PM > To: Wu, Jingjing ; Lu, Wenzhuo > ; tho...@monjalon.net > Cc: rasl...@mellanox.com; dev@dpdk.org; shah...@mellanox.com; > wis...@mellanox.com > Subject:

Re: [dpdk-dev] [PATCH v3 1/2] app/testpmd: add custom topology command

2018-06-14 Thread Iremonger, Bernard
Hi Wisam, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wisam Jaddo > Sent: Wednesday, May 9, 2018 1:47 PM > To: Wu, Jingjing ; Lu, Wenzhuo > ; tho...@monjalon.net > Cc: rasl...@mellanox.com; dev@dpdk.org; shah...@mellanox.com; > wis...@mellanox.com > Subject:

Re: [dpdk-dev] [PATCH V21 4/4] app/testpmd: show example to handle hot unplug

2018-06-14 Thread Iremonger, Bernard
Hi Jeff, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo > Sent: Thursday, May 3, 2018 11:49 AM > To: step...@networkplumber.org; Richardson, Bruce > ; Yigit, Ferruh ; > Ananyev, Konstantin ; > gaetan.ri...@6wind.com; Wu, Jingjing ; > tho...@monjalon.ne

Re: [dpdk-dev] [PATCH v4 2/2] net/tap: support TSO (TCP Segment Offload)

2018-06-14 Thread Wiles, Keith
> On Jun 14, 2018, at 2:59 AM, Ophir Munk wrote: > > > >> -Original Message- >> From: Wiles, Keith [mailto:keith.wi...@intel.com] >> Sent: Wednesday, June 13, 2018 7:04 PM >> To: Ophir Munk >> Cc: DPDK ; Pascal Mazon ; >> Thomas Monjalon ; Olga Shern >> >> Subject: Re: [PATCH v4 2/

[dpdk-dev] Missing an increment on vq->log_cache_nb_elem ?

2018-06-14 Thread HePeng
Hi, In the latest dpdk master branch, in the function *vhost_log_cache_page*: static __rte_always_inline void vhost_log_cache_page(struct virtio_net *dev, struct vhost_virtqueue *vq, uint64_t page) { uint32_t bit_nr = page % (sizeof(unsigned long) << 3);

Re: [dpdk-dev] [PATCH] crypto/virtio: fix iv physical address

2018-06-14 Thread Akhil Goyal
On 6/14/2018 4:32 PM, Fan Zhang wrote: The physical address of IV required by Virtio was computed using crypto operations' physical address plus the offset. However not all crypto ops will have physical address field initialized and compute it runtimely is costly. This patch fixes this problem by

Re: [dpdk-dev] [RFC v2] eventdev: event tx adapter APIs

2018-06-14 Thread Rao, Nikhil
Hi Folks, Did you get a chance to review v2 ? Please let me know your feedback so I can proceed towards implementation. Thanks, Nikhil

Re: [dpdk-dev] [PATCH v3 0/2] testpmd: simulating noisy host environment

2018-06-14 Thread Maxime Coquelin
Hi Bernard, On 05/11/2018 01:50 PM, Iremonger, Bernard wrote: Hi Jens, Subject: [dpdk-dev] [PATCH v3 0/2] testpmd: simulating noisy host environment This series adds a new forwarding mode 'noisy'. It proposes enhancements to testpmd to simulate more realistic behavior of a guest machine en

Re: [dpdk-dev] [PATCH 2/7] bpf: fix 32-bit build support with meson

2018-06-14 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, June 8, 2018 5:38 PM > To: dev@dpdk.org > Cc: Richardson, Bruce > Subject: [dpdk-dev] [PATCH 2/7] bpf: fix 32-bit build support with meson > > The JIT is only supported on x86_6

Re: [dpdk-dev] [PATCH 0/2] add ifc driver to meson build

2018-06-14 Thread Ferruh Yigit
On 6/13/2018 12:32 PM, Xiao Wang wrote: > The first patch unifies the driver name in compiler flag, document. > The second patch adds ifc driver to meson build. > > Xiao Wang (2): > net/ifc: make driver name consistent > net/ifc: add to meson build Series applied to dpdk-next-net/master, than

[dpdk-dev] [PATCH v1 15/15] examples/l2fwd: improvements to the usage print

2018-06-14 Thread Anoob Joseph
Fixed alignment and split the usage print to aid easy addition of eventmode usage prints. Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/main.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/mai

[dpdk-dev] [PATCH v1 11/15] examples/l2fwd: move periodic tasks to new function

2018-06-14 Thread Anoob Joseph
Move the periodic operations (stats flush and drain buffers) to a new function. Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 83 --- examples/l2fwd/l2fwd_worker.h | 6 2 files changed,

[dpdk-dev] [PATCH v1 13/15] examples/l2fwd: move pkt send code to a new function

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index d6a5e90..bac1946 100644 --- a/

[dpdk-dev] [PATCH v1 10/15] examples/l2fwd: optimize check for master core

2018-06-14 Thread Anoob Joseph
Replacing the check for lcore_id & mastercore_id with the check for a flag. Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/exa

[dpdk-dev] [PATCH v1 12/15] examples/l2fwd: skip timer updates for non master cores

2018-06-14 Thread Anoob Joseph
The timer updates and checks are required only for stats printing by the master core. This can be entirely skipped for other cores. Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/l2fwd_worker.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --

[dpdk-dev] [PATCH v1 14/15] examples/l2fwd: use fprint instead of printf for usage print

2018-06-14 Thread Anoob Joseph
Following the convention of l3fwd, using fprintf instead of printf for printing usage. Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index 05f9d28..3b697d

[dpdk-dev] [PATCH v1 09/15] examples/l2fwd: move drain buffers to new function

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_worker.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index ad5468a..dfa78e

[dpdk-dev] [PATCH v1 06/15] examples/l2fwd: fix lines exceeding 80 char limit

2018-06-14 Thread Anoob Joseph
Fixes: e2366e74e029 ("examples: use buffered Tx") Fixes: af75078fece3 ("first public release") Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/main.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/examples/l2fwd/

[dpdk-dev] [PATCH v1 08/15] examples/l2fwd: remove unused header includes

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/l2fwd_worker.c | 12 1 file changed, 12 deletions(-) diff --git a/examples/l2fwd/l2fwd_worker.c b/examples/l2fwd/l2fwd_worker.c index 663c505..ad5468a 100644 --- a/examples/l2fwd/l2fwd_worker.c +++ b/examples/l2fwd/l2fw

[dpdk-dev] [PATCH v1 07/15] examples/l2fwd: move dataplane code to new file

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/Makefile | 1 + examples/l2fwd/l2fwd_worker.c | 233 ++ examples/l2fwd/l2fwd_worker.h | 10 ++ examples/l2fwd/main.c | 191 +--

[dpdk-dev] [PATCH v1 04/15] examples/l2fwd: move globally accessed vars to common header

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/l2fwd_common.h | 26 ++ examples/l2fwd/main.c | 41 + 2 files changed, 43 insertions(+), 24 deletions(-) diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l

[dpdk-dev] [PATCH v1 05/15] examples/l2fwd: add missing space

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd/main.c b/examples/l2fwd/main.c index a6089a1..6229a20 100644 --- a/examples/l2fwd/main.c +++ b/examples/l2fwd/main.c @@ -71,7 +71,7 @@ print_st

[dpdk-dev] [PATCH v1 03/15] examples/l2fwd: move structure definitions to common header

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * Replaced 'unsigned' with 'unsigned int' examples/l2fwd/l2fwd_common.h | 12 examples/l2fwd/main.c | 10 -- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l2fwd/l2fwd_comm

[dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions

2018-06-14 Thread Anoob Joseph
This patchset modularizes l2fwd application to prepare it for eventmode additions. This patchset doesn't change the code flow or logic, except for few minor improvements. Some of the newly added functions are used in just one place, but is added for efficient usage with eventmode. v1: * Fix all ch

[dpdk-dev] [PATCH v1 01/15] examples/l2fwd: add new header to move common code

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * No change examples/l2fwd/l2fwd_common.h | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 examples/l2fwd/l2fwd_common.h diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l2fwd/l2fwd_common.h new file mode 100644 index 000..15059f4 ---

[dpdk-dev] [PATCH v1 02/15] examples/l2fwd: move macro definitions to common header

2018-06-14 Thread Anoob Joseph
Signed-off-by: Anoob Joseph --- v1: * Retaining Intel license with copied code examples/l2fwd/l2fwd_common.h | 19 +++ examples/l2fwd/main.c | 16 ++-- 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/examples/l2fwd/l2fwd_common.h b/examples/l2

Re: [dpdk-dev] [PATCH v7 22/22] app/testpmd: add show device command

2018-06-14 Thread Gaƫtan Rivet
Hi Bernard, On Thu, Jun 14, 2018 at 10:59:09AM +, Iremonger, Bernard wrote: > Hi Gaetan, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > > Sent: Sunday, April 15, 2018 4:08 PM > > To: dev@dpdk.org > > Cc: Gaetan Rivet > > Subject: [dpd

Re: [dpdk-dev] [PATCH v2 1/2] testpmd: add forwarding mode to simulate a noisy neighbour

2018-06-14 Thread Iremonger, Bernard
Hi Jens, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jens Freimann > Sent: Friday, April 13, 2018 12:37 PM > To: dev@dpdk.org > Cc: ai...@redhat.com; jan.scheur...@ericsson.com; vkapl...@redhat.com; > Richardson, Bruce ; tho...@monjalon.net; > maxime.coque..

Re: [dpdk-dev] [PATCH 1/2] testpmd: add forwarding mode to simulate a noisy neighbour

2018-06-14 Thread Iremonger, Bernard
Hi Jens, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jens Freimann > Sent: Thursday, April 19, 2018 8:00 AM > To: dev@dpdk.org > Cc: ai...@redhat.com; jan.scheur...@ericsson.com; vkapl...@redhat.com; > Richardson, Bruce ; tho...@monjalon.net; > maxime.coqu

Re: [dpdk-dev] [PATCH v1 6/7] doc: add octeontx zip PMD documentation

2018-06-14 Thread Kovacevic, Marko
Acked-by: Marko Kovacevic

[dpdk-dev] [PATCH v2 3/3] crypto/qat: move common qat files to common dir

2018-06-14 Thread Tomasz Jozwiak
- moved common qat files to common/qat dir. - changed common/qat/Makefile, common/qat/meson.build, drivers/Makefile, crypto/Makefile to add possibility of using new files locations - added README file into crypto/qat to clarify where the build is made from - updated MAINT

[dpdk-dev] [PATCH] crypto/virtio: fix iv physical address

2018-06-14 Thread Fan Zhang
The physical address of IV required by Virtio was computed using crypto operations' physical address plus the offset. However not all crypto ops will have physical address field initialized and compute it runtimely is costly. This patch fixes this problem by adding iv field in virtio_crypto_op_cook

[dpdk-dev] [PATCH v2 1/3] crypto/qat: add weak functions

2018-06-14 Thread Tomasz Jozwiak
This patch adds following weak functions to facilitate conditional compilation of code for those services: - qat_sym_dev_create - qat_asym_dev_create - qat_comp_dev_create - qat_sym_dev_destroy - qat_asym_dev_destroy - qat_comp_dev_destroy and removes unused files with empty defin

[dpdk-dev] [PATCH v2 2/3] crypto/qat: add libcrypto detection to Makefile

2018-06-14 Thread Tomasz Jozwiak
This patch adds detection of libcrypto in qat/Makefile. Crypto QAT PMD is build, but only when this library is installed. Added description into qat.rst file. Signed-off-by: Tomasz Jozwiak Acked-by: Fiona Trahe --- config/common_base | 5 +++-- doc/guides/cryptodevs/qat.rst|

[dpdk-dev] [PATCH v2 0/3] crypto/qat: move files to drivers/common directory

2018-06-14 Thread Tomasz Jozwiak
This patchset depends on QAT dynamic logging patchset and should be targetig on 18.08. Patchset refactors the PMD in order that files are split into several places: common, crypto. New drivers/common/qat are added and files split between locations. Also added libcrypto detection and QAT PMD is bui

Re: [dpdk-dev] [PATCH] ethdev: force offloading API rules

2018-06-14 Thread Ferruh Yigit
On 6/13/2018 4:16 PM, Thomas Monjalon wrote: > 08/06/2018 22:01, Thomas Monjalon: >> 08/06/2018 21:51, Ferruh Yigit: >>> On 5/31/2018 1:44 PM, Ferruh Yigit wrote: The error path was disabled in previous release to let apps to be more flexible. But this release they are enabled,

Re: [dpdk-dev] Mlx meson build

2018-06-14 Thread Shahaf Shuler
Thursday, June 14, 2018 11:35 AM, Thomas Monjalon : > Subject: Re: Mlx meson build > > 14/06/2018 10:15, Bruce Richardson: > > On Wed, Jun 13, 2018 at 03:14:16PM -0700, Stephen Hemminger wrote: > > > Is there any chance of getting MLX drivers to build with meson? > > > It seems like it should be p

[dpdk-dev] [PATCH v2 5/5] doc/qat: document debug options

2018-06-14 Thread Tomasz Jozwiak
From: Fiona Trahe Signed-off-by: Fiona Trahe --- doc/guides/cryptodevs/qat.rst | 26 ++ 1 file changed, 26 insertions(+) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst index 22a2c71..b899985 100644 --- a/doc/guides/cryptodevs/qat.rst +++ b/do

[dpdk-dev] [PATCH v2 3/5] crypto/qat: rename log macro for non-dp logs

2018-06-14 Thread Tomasz Jozwiak
From: Fiona Trahe Rename PMD_DRV_LOG to the more appropriate name QAT_LOG. Signed-off-by: Fiona Trahe --- drivers/crypto/qat/qat_common.c | 12 ++--- drivers/crypto/qat/qat_device.c | 12 ++--- drivers/crypto/qat/qat_logs.h| 2 +- drivers/crypto/qat/qat_qp.c | 54 ++

[dpdk-dev] [PATCH v2 0/5] crypto/qat: move to dynamic logging

2018-06-14 Thread Tomasz Jozwiak
Note this patchset is targeting 18.08 release and depends on the qat refactoring patchset: http://dpdk.org/ml/archives/dev/2018-May/101306.html Move to dynamic logging and cleanup trace. Changes for v2: - fixed some bugs detected in patch 2/5 when using clang Fiona Trahe (2): crypto/qat: re

[dpdk-dev] [PATCH v2 2/5] crypto/qat: move to dynamic logging for non-dp trace

2018-06-14 Thread Tomasz Jozwiak
For all trace not on the data-path move to dynamic logging. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- config/common_base | 1 - drivers/crypto/qat/Makefile| 1 + drivers/crypto/qat/meson.build | 1 + drivers/crypto/qat/qat_logs.c | 17 + dr

[dpdk-dev] [PATCH v2 1/5] crypto/qat: cleanup unused and useless trace

2018-06-14 Thread Tomasz Jozwiak
Removed INIT_FUNC trace and other unused macros. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- config/common_base | 1 - drivers/crypto/qat/qat_logs.h| 31 --- drivers/crypto/qat/qat_qp.c | 11 +-- drivers/cr

[dpdk-dev] [PATCH v2 4/5] crypto/qat: move to dynamic logging for data-path trace

2018-06-14 Thread Tomasz Jozwiak
For all trace on the data-path move to dynamic logging. Add new QAT_DP_LOG macro to separate from non-dp trace. Use the overall RTE_LOG_DP_LEVEL to override and compile out debug data-path trace. Add "unlikely" in two appropriate error checks. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Tr

[dpdk-dev] [dpdk-announce] DPDK 16.11.7 (LTS) released

2018-06-14 Thread Luca Boccassi
Hi all, Here is a new stable release: http://fast.dpdk.org/rel/dpdk-16.11.7.tar.xz The git tree is at: http://dpdk.org/browse/dpdk-stable/ Luca Boccassi --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 36 +--

Re: [dpdk-dev] [PATCH v3 00/38] crypto/qat: refactor to support multiple services

2018-06-14 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Jozwiak > Sent: Wednesday, June 13, 2018 1:14 PM > To: Trahe, Fiona ; Jozwiak, TomaszX > ; dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 00/38] crypto/qat: refactor to support multiple > services > > From:

Re: [dpdk-dev] [PATCH v7 22/22] app/testpmd: add show device command

2018-06-14 Thread Iremonger, Bernard
Hi Gaetan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Sunday, April 15, 2018 4:08 PM > To: dev@dpdk.org > Cc: Gaetan Rivet > Subject: [dpdk-dev] [PATCH v7 22/22] app/testpmd: add show device > command > > A new interactive command is

Re: [dpdk-dev] [PATCH v1 1/2] lib/librte_power: traffic pattern aware power control

2018-06-14 Thread Hunt, David
Hi Liang On 8/6/2018 10:57 AM, Liang Ma wrote: 1. Abstract For packet processing workloads such as DPDK polling is continuous. This means CPU cores always show 100% busy independent of how much work those cores are doing. It is critical to accurately determine how busy a core is hugely import

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: add sanity checks when retrieving xstats

2018-06-14 Thread Ferruh Yigit
On 6/14/2018 7:39 AM, Remy Horton wrote: > > On 13/06/2018 16:39, Ferruh Yigit wrote: >> On 6/7/2018 9:15 AM, David Marchand wrote: >>> Testpmd should not expect the xstats names and values arrays to be >>> aligned: neither the arrays sizes, nor the order in which the values are. >> >> As far as I

Re: [dpdk-dev] [PATCH] app/testpmd: distribute queues to cores

2018-06-14 Thread Bruce Richardson
On Sat, May 26, 2018 at 11:15:20PM +0800, Xueming Li wrote: > Current topology distribute forwarding streams to lcores by port, this > make unbalanced loading when port number larger than 2: > lcore 0: P0Q0->P1Q0, P0Q1->P1Q1 > locre 1: P1Q0->P0Q0, P1Q1->P0Q1 > If only one port has traff

[dpdk-dev] [dpdk-announce] Reminder Call for speakers open last date June 15th

2018-06-14 Thread Tibrewala, Sujata
Call for speakers Open for: 1. June 30th, Bangalore: Packet Processing, Cloud and Edge Next Gen SDN/NFV Networks - Out of the Box Network Developers meet up (https://www.meetup.com/Out-of-the-Box-Network-Developers-Bangalore/events/251225679/) 2. June 28th, Taipei: Packet Processing an

[dpdk-dev] [PATCH V2] net/thunderx: add support for hardware first skip feature

2018-06-14 Thread rkudurumalla
This feature is used to create a hole between HEADROOM and actual data.Size of hole is specified in bytes as module param to pmd Signed-off-by: Rakesh Kudurumalla --- V1: https://dpdk.org/ml/archives/dev/2018-May/103058.html V2: Includes changes in thunder.rst to render outupt correctly in html

Re: [dpdk-dev] [PATCH v6 7/7] devtools: expand meson cross compiling coverage

2018-06-14 Thread Bruce Richardson
On Thu, Jun 14, 2018 at 05:51:27PM +0800, Gavin Hu wrote: > The default test script covers only default host cc compiler, either gcc or > clang, the fix is to cover both, gcc and clang. And also the build dirs are > changed to *-host-$c, indicating the difference of cc used. > > Fixes: a55277a788

Re: [dpdk-dev] [PATCH v3 6/6] doc: add asym crypto in cryptodev programmer guide

2018-06-14 Thread Kovacevic, Marko
<...> > +params or prime modulus data i.e. immutable across data sets. Crypto > +sessions cache this immutable data in a optimal way for the underlying PMD > and this allows further acceleration of the offload of Crypto workloads. > + > +Like symmetric, the Crypto device framework provides APIs to

  1   2   >