Re: [dpdk-dev] [PATCH 1/3] net/ixgbe: remove dependence on Tx queue flags

2018-05-02 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Thursday, May 3, 2018 9:49 AM > To: Ananyev, Konstantin ; Yigit, Ferruh > > Cc: Dai, Wei ; Lu, Wenzhuo ; > Wang, Xiao W ; dev@dpdk.org > Subject: RE: [PATCH 1/3] net/ixgbe: remove dependence on Tx queue flags > > Hi Konstantin: > > > ---

Re: [dpdk-dev] [v2,1/6] eventdev: introduce event crypto adapter

2018-05-02 Thread Gujjar, Abhinandan S
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Thursday, April 26, 2018 12:47 PM > To: Gujjar, Abhinandan S ; Akhil Goyal > ; jerin.ja...@caviumnetworks.com; > hemant.agra...@nxp.com; dev@dpdk.org > Cc: Vangati, Narender ; Rao, Nikhil > ; Eads, Gage > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [v2,1/6] eventdev: introduce event crypto adapter

2018-05-02 Thread Gujjar, Abhinandan S
> -Original Message- > From: Jerin Jacob > Sent: Sunday, April 29, 2018 9:39 PM > To: Gujjar, Abhinandan S > Cc: hemant.agra...@nxp.com; akhil.go...@nxp.com; dev@dpdk.org; Vangati, > Narender ; Rao, Nikhil ; > Eads, Gage > Subject: Re: [v2,1/6] eventdev: introduce event crypto adapter

[dpdk-dev] [PATCH] ethdev: convert Tx offloads to Tx queue config

2018-05-02 Thread Qi Zhang
Tx offload will be converted to txq_flags automatically during rte_eth_dev_info_get and rte_eth_tx_queue_info_get. So PMD can clean the code to get rid of txq_flags at all while keep old APP not be impacted. Signed-off-by: Qi Zhang --- lib/librte_ethdev/rte_ethdev.c | 32

Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 and sha2 family authentication algo

2018-05-02 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: Thomas Monjalon [mailto:tho...@monjalon.net] >> Sent: Monday, April 23, 2018 9:06 AM >> To: Kumar, Ravi1 >> Cc: De Lara Guarch, Pablo ; >> dev@dpdk.org; hemant.agra...@nxp.com >> Subject: Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu ba

Re: [dpdk-dev] [PATCH 1/2] net/tap: add tun support

2018-05-02 Thread Varghese, Vipin
Hi Ophir, Shall I investigate and implement the suggestion from Ferruh to use variable logic? Thanks Vipin Varghese > -Original Message- > From: Yigit, Ferruh > Sent: Monday, April 23, 2018 9:12 PM > To: Varghese, Vipin ; Ophir Munk > ; dev@dpdk.org; pascal.ma...@6wind.com; > Thomas Mon

[dpdk-dev] [PATCH 2/2] crypto/ccp: change to command line option from compile time

2018-05-02 Thread Ravi Kumar
CCP PMD supports authentication offload to either of CCP or CPU. The earlier version of patch provided this option as compile time. This patch changes this option from compile time to run time. User can pass "ccp_auth_opt=1" as an additional argument to vdev parameter to enable authentication opera

[dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default

2018-05-02 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- config/common_base | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common_base b/config/common_base index 03a8688..802035b 100644 --- a/config/common_base +++ b/config/common_base @@ -555,7 +555,7 @@ CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y #

Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix ethtool link setting call order

2018-05-02 Thread Shahaf Shuler
Tuesday, May 1, 2018 12:59 PM, Shahaf Shuler: > Subject: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix ethtool link setting call > order > > According to ethtool_link_setting API recommendation > ETHTOOL_GLINKSETTINGS should be called before ETHTOOL_GSET as the > later one deprecated. > > Fixes: f47ba8

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/mlx4: fix CRC stripping capability report

2018-05-02 Thread Shahaf Shuler
Hi Ophir, Monday, April 30, 2018 3:25 PM, Ophir Munk: > sta...@dpdk.org > Subject: [dpdk-stable] [PATCH v1] net/mlx4: fix CRC stripping capability > report > > There are two capabilities related to CRC stripping: > 1. mlx4 HW capability to perform CRC stripping on a recieved packet. > This capabi

Re: [dpdk-dev] [PATCH v6 1/5] iFPGA: Add Intel FPGA BUS Library

2018-05-02 Thread Tan, Jianfeng
For title prefix, use "bus/ifpga" instead. On 4/26/2018 5:43 PM, Xu, Rosen wrote: From: Rosen Xu Defined FPGA-BUS for Acceleration Drivers of AFUs 1. FPGA PCI Scan (1st Scan) follows DPDK UIO/VFIO PCI Scan Process, probe Intel FPGA Rawdev Driver. As I understand, this part is not covered in

[dpdk-dev] [PATCH] net/avf: fix Rx interrupt mapping

2018-05-02 Thread Jingjing Wu
Vector used for rx mapping is different if WB_ON_ITR is supported. The mapping table need to be updated. Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") Signed-off-by: Jingjing Wu Cc: sta...@dpdk.org --- drivers/net/avf/avf_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH] net/avf: fix Rx interrupt mapping

2018-05-02 Thread Jingjing Wu
Vector used for rx mapping is different if WB_ON_ITR is supported. The mapping table need to be updated. Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") Signed-off-by: Jingjing Wu Cc: sta...@dpdk.org --- drivers/net/avf/avf_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH V20 2/4] eal: add failure handler mechanism for hot plug

2018-05-02 Thread Guo, Jia
On 4/21/2018 12:16 AM, Ananyev, Konstantin wrote: + +static void sigbus_handler(int signum __rte_unused, siginfo_t *info, + void *ctx __rte_unused) +{ + int ret; + + RTE_LOG(ERR, EAL, "SIGBUS error, fault address:%p\n", info->si_addr); + ret = dev

Re: [dpdk-dev] [PATCH V20 2/4] eal: add failure handler mechanism for hot plug

2018-05-02 Thread Guo, Jia
On 4/20/2018 7:14 PM, Ananyev, Konstantin wrote: This patch introduces a failure handler mechanism to handle device hot unplug event. When device be hot plug out, the device resource become invalid, if this resource is still be unexpected read/write, system will crash. This patch let eal help

Re: [dpdk-dev] [PATCH V20 1/4] bus/pci: introduce device hot unplug handle

2018-05-02 Thread Guo, Jia
On 4/20/2018 6:32 PM, Ananyev, Konstantin wrote: Hi Jeff, As of device hot unplug, we need some preparatory measures so that we will not encounter memory fault after device be plug out of the system, and also let we could recover the running data path but not been break. This patch allows the

[dpdk-dev] [PATCH] net/i40e: fix Tx queue info get

2018-05-02 Thread Qi Zhang
Add missing Tx queue offload assignment in i40e_txq_info_get. Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c

[dpdk-dev] [PATCH v6] ethdev: check Rx/Tx offloads

2018-05-02 Thread Wei Dai
This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_configure( ) and [rt]x_conf->offloads to rte_e

Re: [dpdk-dev] [PATCH 1/3] net/ixgbe: remove dependence on Tx queue flags

2018-05-02 Thread Zhang, Qi Z
Hi Konstantin: > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, May 2, 2018 7:23 PM > To: Zhang, Qi Z ; Yigit, Ferruh > Cc: Dai, Wei ; Lu, Wenzhuo ; > Wang, Xiao W ; dev@dpdk.org > Subject: RE: [PATCH 1/3] net/ixgbe: remove dependence on Tx queue flags > > > > >

Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix queue offload initialize

2018-05-02 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, May 2, 2018 7:29 PM > To: Zhang, Qi Z ; Yigit, Ferruh > Cc: dev@dpdk.org; Xing, Beilei > Subject: RE: [PATCH v2 1/2] net/i40e: fix queue offload initialize > > > > > -Original Message- > > From: Zhang, Qi Z >

[dpdk-dev] [PATCH 3/3] net/mlx5: add Multi-Packet Rx support

2018-05-02 Thread Yongseok Koh
Multi-Packet Rx Queue (MPRQ a.k.a Striding RQ) can further save PCIe bandwidth by posting a single large buffer for multiple packets. Instead of posting a buffer per a packet, one large buffer is posted in order to receive multiple packets on the buffer. A MPRQ buffer consists of multiple fixed-siz

[dpdk-dev] [PATCH 2/3] net/mlx5: add a function to rdma-core glue

2018-05-02 Thread Yongseok Koh
mlx5dv_create_wq() is added for the Multi-Packet RQ (a.k.a Striding RQ). Signed-off-by: Yongseok Koh --- drivers/net/mlx5/Makefile| 5 + drivers/net/mlx5/mlx5_glue.c | 16 drivers/net/mlx5/mlx5_glue.h | 8 3 files changed, 29 insertions(+) diff --git a/driver

[dpdk-dev] [PATCH 1/3] net/mlx5: separate filling Rx flags

2018-05-02 Thread Yongseok Koh
Filling in fields of mbuf becomes a separate inline function so that this can be reused. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 84 +++- 1 file changed, 51 insertions(+), 33 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/

[dpdk-dev] [PATCH 0/3] net/mlx5: add Multi-Packet Rx support

2018-05-02 Thread Yongseok Koh
Multi-Packet Rx Queue (MPRQ a.k.a Striding RQ) can further save PCIe bandwidth by posting a single large buffer for multiple packets. Instead of posting a buffer per a packet, one large buffer is posted in order to receive multiple packets on the buffer. A MPRQ buffer consists of multiple fixed-siz

[dpdk-dev] [PATCH 5/5] net/mlx4: add new Memory Region support

2018-05-02 Thread Yongseok Koh
This is the new design of Memory Region (MR) for mlx PMD, in order to: - Accommodate the new memory hotplug model. - Support non-contiguous Mempool. Signed-off-by: Yongseok Koh --- drivers/net/mlx4/mlx4.c | 26 + drivers/net/mlx4/mlx4.h | 14 + drivers/net/mlx4/mlx4_mr.c | 1165 +

[dpdk-dev] [PATCH 4/5] net/mlx4: remove Memory Region support

2018-05-02 Thread Yongseok Koh
This patch removes current support of Memory Region (MR) in order to accommodate the dynamic memory hotplug patch. This patch can be compiled but traffic can't flow and HW will raise faults. Subsequent patches will add new MR support. Signed-off-by: Yongseok Koh --- config/common_base

[dpdk-dev] [PATCH 3/5] net/mlx5: add new Memory Region support

2018-05-02 Thread Yongseok Koh
This is the new design of Memory Region (MR) for mlx PMD, in order to: - Accommodate the new memory hotplug model. - Support non-contiguous Mempool. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 45 ++ drivers/net/mlx5/mlx5.h | 22 + drivers/net/mlx5/mlx5_defs.h

[dpdk-dev] [PATCH 2/5] net/mlx5: remove Memory Region support

2018-05-02 Thread Yongseok Koh
This patch removes current support of Memory Region (MR) in order to accommodate the dynamic memory hotplug patch. This patch can be compiled but traffic can't flow and HW will raise faults. Subsequent patches will add new MR support. Signed-off-by: Yongseok Koh --- config/common_base

[dpdk-dev] [PATCH 1/5] net/mlx5: trim debug messages for reference counters

2018-05-02 Thread Yongseok Koh
Remove debug messages when getting an object. When releasing an object, debug message will be printed only if the object is really freed. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_mr.c | 7 ++- drivers/net/mlx5/mlx5_rxq.c | 36 +--- drivers/net/m

[dpdk-dev] [PATCH 0/5] net/mlx: add new Memory Region support

2018-05-02 Thread Yongseok Koh
This is the new design of Memory Region (MR) for mlx PMD, in order to: - Accommodate the new memory hotplug model. - Support non-contiguous Mempool. This patchset should be applied after: net/mlx5: change device reference for secondary process Yongseok Koh (5): net/mlx5: trim debug messages f

[dpdk-dev] [PATCH v2] net/mlx5: change device reference for secondary process

2018-05-02 Thread Yongseok Koh
rte_eth_devices[] is not shared between primary and secondary process, but a static array to each process. The reverse pointer of device (priv->dev) is invalid. Instead, priv has the pointer to shared data of the device, struct rte_eth_dev_data *dev_data; Two macros are added, #define port_id(

Re: [dpdk-dev] vmxnet3 Maintainer?

2018-05-02 Thread Louis Luo
Hi Dave, The previous maintainer, Shri, has left VMware. Now Yong is taking the maintainer's role and I will work on the vmxnet3 driver. I haven't heard from Shri about the issue before. We can setup a testbed to reproduce the issue. Can you describe your setup? The issue reported by Paul in th

[dpdk-dev] [dpdk-announce] release candidate 18.05-rc2

2018-05-02 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://dpdk.org/browse/dpdk/tag/?id=v18.05-rc2 The release notes are not updated in this RC2: http://dpdk.org/doc/guides/rel_notes/release_18_05.html None of the features planned for RC2 is merged. It is a release candidate to fi

Re: [dpdk-dev] vmxnet3 Maintainer?

2018-05-02 Thread Thomas Monjalon
02/05/2018 22:38, David Harton (dharton): > I've encountered a couple scenarios with vmxnet3 (dpdk 2.2 and 16.07) that > look pretty much identical to this: > http://dpdk.org/ml/archives/users/2016-October/001063.html > > Do we have a maintainer for the vmxnet3 driver? I tried emailing the one

Re: [dpdk-dev] [PATCH v2 2/2] mem: unmap unneeded space

2018-05-02 Thread Thomas Monjalon
30/04/2018 14:50, Bruce Richardson: > On Mon, Apr 30, 2018 at 12:21:43PM +0100, Anatoly Burakov wrote: > > When we ask to reserve virtual areas, we usually include > > alignment in the mapping size, and that memory ends up > > being wasted. Wasting a gigabyte of VA space while trying to > > reserve

[dpdk-dev] vmxnet3 Maintainer?

2018-05-02 Thread David Harton (dharton)
I've encountered a couple scenarios with vmxnet3 (dpdk 2.2 and 16.07) that look pretty much identical to this: http://dpdk.org/ml/archives/users/2016-October/001063.html Do we have a maintainer for the vmxnet3 driver? I tried emailing the one listing in the MAINTAINERS file but the mail bounced

[dpdk-dev] [PATCH] mempool: fix alignment of memzone length when populating

2018-05-02 Thread Olivier Matz
When populating a mempool with the default function, if there is not enough virtually contiguous memory for the whole mempool, it will be populated with several chunks. A chunk of the maximum available length is requested with: mz = rte_memzone_reserve_aligned(..., len=0, ..., align=x) If align

Re: [dpdk-dev] ethdev new offloading API switch in PMDs

2018-05-02 Thread Shahaf Shuler
Wednesday, May 2, 2018 6:18 PM, Ferruh Yigit: > Subject: Re: [dpdk-dev] ethdev new offloading API switch in PMDs > > On 5/2/2018 2:44 PM, Shahaf Shuler wrote: > > Wednesday, May 2, 2018 4:28 PM, Ferruh Yigit: > >> Subject: Re: [dpdk-dev] ethdev new offloading API switch in PMDs > >> > >> On 5/2/20

Re: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure

2018-05-02 Thread Ferruh Yigit
On 5/2/2018 6:09 PM, Shahaf Shuler wrote: > Wednesday, May 2, 2018 1:06 PM, Thomas Monjalon: >> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure >> >> 02/05/2018 11:58, Xueming(Steven) Li: >>> From: Ferruh Yigit Or as Xueming suggested, we can take rss_hf config a

Re: [dpdk-dev] [PATCH] x86: fix atomic exchange for 32-bit

2018-05-02 Thread Thomas Monjalon
02/05/2018 18:44, Ferruh Yigit: > On 5/2/2018 2:58 PM, Konstantin Ananyev wrote: > > should break out of loop when rte_atomic64_cmpset() retruns non-zero. > > > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > > > Signed-off-by: Konstantin Ananyev > > Reviewed-by: Ferruh Y

[dpdk-dev] [PATCH v4 7/7] doc: add DPAA2 CMDIF rawdev guide

2018-05-02 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Acked-by: Marko Kovacevic --- MAINTAINERS| 1 + doc/guides/rawdevs/dpaa2_cmdif.rst | 144 + doc/guides/rawdevs/index.rst | 1 + doc/guides/rel_notes/release_18_05.rst | 11 +++ 4 files chang

[dpdk-dev] [PATCH v4 6/7] raw/dpaa2_cmdif: support enqueue dequeue operations

2018-05-02 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf | 1 + drivers/raw/dpaa2_cmdif/Makefile | 2 + drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 136 ++ drivers/raw/dpaa2_cmd

[dpdk-dev] [PATCH v4 3/7] bus/fslmc: keep Tx queues information for DPCI devices too

2018-05-02 Thread Nipun Gupta
The DPCI devices have oth Tx and Rx queues. Event devices use DPCI Rx queues only, but CMDIF (AIOP) uses both Tx and Rx queues. This patch enables Tx queues configuration too. Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- drivers/bus/fslmc/portal/dpaa2_hw_dpci.c | 86 +

[dpdk-dev] [PATCH v4 5/7] raw/dpaa2_cmdif: add attribute get functionality

2018-05-02 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c index e3e2b64..bdd7c16 100644 --- a/drivers/raw/dpaa2_cmdif/dpaa2_cmdi

[dpdk-dev] [PATCH v4 4/7] raw/dpaa2_cmdif: introduce DPAA2 command interface driver

2018-05-02 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- MAINTAINERS| 4 + config/common_base | 5 + config/common_linuxapp | 1 + drivers/raw/Makefile | 1 + drivers/raw/dpaa2_cmdif/Ma

[dpdk-dev] [PATCH v4 2/7] bus/fslmc: expose API to free dpci device

2018-05-02 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map index 70fb719..d433714 100644 --- a/drivers/bus/fslmc

[dpdk-dev] [PATCH v4 1/7] mempool/dpaa2: add functions exposed to DPDK applications

2018-05-02 Thread Nipun Gupta
There are two API's which are required by NXP specific Command Interface Application (AIOP CMDIF). This patch exposes these two API's. Signed-off-by: Nipun Gupta --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf | 1 + drivers/memp

[dpdk-dev] [PATCH v4 0/7] Introduce DPAA2 Command Interface raw driver

2018-05-02 Thread Nipun Gupta
This patch set introduces DPAA2 based Command Interface device driver. This driver is provides communication between the GPP and AIOP Firmware. This patchset is based on top of: https://dpdk.org/dev/patchwork/patch/39246/ Patches 1-3: Makes necessary changes and fixes in the DPAA2 bus and me

Re: [dpdk-dev] [PATCH] net/mlx4: fix compilation issues in glue mode

2018-05-02 Thread Ferruh Yigit
On 5/2/2018 4:28 PM, Adrien Mazarguil wrote: > Since the commit referenced below, compiling mlx4 along with its glue > library (CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS=y) triggers a compilation > failure due to undefined symbols. > > They are caused by Verbs calls made directly from the PMD instead of

[dpdk-dev] [PATCH v6 8/8] doc: add DPAA2 QDMA rawdev guide

2018-05-02 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- MAINTAINERS| 1 + doc/guides/index.rst | 1 + doc/guides/rawdevs/dpaa2_qdma.rst | 140 + doc/guides/rawdevs/index.rst | 14 doc/guides/re

[dpdk-dev] [PATCH v6 7/8] raw/dpaa2_qdma: support enq and deq operations

2018-05-02 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- drivers/raw/dpaa2_qdma/dpaa2_qdma.c| 333 + drivers/raw/dpaa2_qdma/dpaa2_qdma.h| 21 ++ drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h| 70 + .../raw/dpaa2_qdma/rte_pmd_dpaa2_qd

[dpdk-dev] [PATCH v6 5/8] raw/dpaa2_qdma: introduce the DPAA2 QDMA driver

2018-05-02 Thread Nipun Gupta
DPAA2 QDMA driver uses MC DPDMAI object. This driver enables the user (app) to perform data DMA without involving CPU in the DMA process Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- MAINTAINERS| 8 + config/common_base

[dpdk-dev] [PATCH v6 6/8] raw/dpaa2_qdma: support configuration APIs

2018-05-02 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf | 1 + drivers/raw/dpaa2_qdma/Makefile| 2 + drivers/raw/dpaa2_qdma/dpaa2_qdma.c| 375 +++

[dpdk-dev] [PATCH v6 4/8] bus/fslmc: add macros required by QDMA for FLE and FD

2018-05-02 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal Acked-by: Shreyansh Jain --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h index e081afb..0

[dpdk-dev] [PATCH v6 3/8] bus/fslmc: support scanning and probing of QDMA devices

2018-05-02 Thread Nipun Gupta
'dpdmai' devices detected on fsl-mc bus are represented by DPAA2 QDMA devices in DPDK. Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- drivers/bus/fslmc/fslmc_bus.c | 2 ++ drivers/bus/fslmc/fslmc_vfio.c | 1 + drivers/bus/fslmc/rte_fslmc.h | 2 ++ 3 files changed, 5 insertions(+) di

[dpdk-dev] [PATCH v6 2/8] bus/fslmc: support MC DPDMAI object

2018-05-02 Thread Nipun Gupta
This patch adds the DPDMAI (Data Path DMA Interface) object support in MC driver. Signed-off-by: Cristian Sovaiala Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- drivers/bus/fslmc/Makefile | 9 +- drivers/bus/fslmc/mc/dpdmai.c | 429 +++

[dpdk-dev] [PATCH v6 0/8] Introduce DPAA2 QDMA raw driver

2018-05-02 Thread Nipun Gupta
This patch set introduces DPAA2 based QDMA device driver. It provide means to initiate a DMA transaction from CPU. The initiated DMA is performed without CPU being involved in the actual DMA transaction. This patch series is rebased on dpdk master branch Patch 1: Support meson build in raw Pat

[dpdk-dev] [PATCH v6 1/8] raw: support meson build

2018-05-02 Thread Nipun Gupta
Signed-off-by: Shreyansh Jain Signed-off-by: Nipun Gupta --- drivers/meson.build | 3 ++- drivers/raw/meson.build | 7 +++ drivers/raw/skeleton_rawdev/meson.build | 8 3 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 drivers/ra

Re: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure

2018-05-02 Thread Shahaf Shuler
Wednesday, May 2, 2018 1:06 PM, Thomas Monjalon: > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix applications failure on configure > > 02/05/2018 11:58, Xueming(Steven) Li: > > From: Ferruh Yigit > > > Or as Xueming suggested, we can take rss_hf config as best effort and > not return error at all.

Re: [dpdk-dev] [dpdk-dev 1/3][PATCH v2] net/ixgbe: revert default PF PMD device name

2018-05-02 Thread Ferruh Yigit
On 5/2/2018 5:48 PM, Ferruh Yigit wrote: > On 5/2/2018 4:59 PM, Declan Doherty wrote: >> Changes introduced by cf80ba6e2038 modified the default name generated >> for the IXGBE PF PMD, this patch reverts the default name to the >> original PCI BDBF. >> >> Fixes: cf80ba6e2038 ("net/ixgbe: add suppor

Re: [dpdk-dev] [dpdk-dev 1/3][PATCH v2] net/ixgbe: revert default PF PMD device name

2018-05-02 Thread Ferruh Yigit
On 5/2/2018 4:59 PM, Declan Doherty wrote: > Changes introduced by cf80ba6e2038 modified the default name generated > for the IXGBE PF PMD, this patch reverts the default name to the > original PCI BDBF. > > Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") > Signed-off-by: Decl

Re: [dpdk-dev] [PATCH] x86: fix atomic exchange for 32-bit

2018-05-02 Thread Ferruh Yigit
On 5/2/2018 2:58 PM, Konstantin Ananyev wrote: > should break out of loop when rte_atomic64_cmpset() retruns non-zero. > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > Signed-off-by: Konstantin Ananyev Reviewed-by: Ferruh Yigit Tested-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 2/2] malloc: avoid padding elements on page deallocation

2018-05-02 Thread Thomas Monjalon
02/05/2018 17:38, Anatoly Burakov: > Currently, when deallocating pages, malloc will fixup other > elements' headers if there is not enough space to store a full > element in leftover space. This leads to race conditions because > there are some functions that check for pad size with an unlocked >

[dpdk-dev] [dpdk-dev 2/3][PATCH v2] net/ixgbe: default eth_da parameter

2018-05-02 Thread Declan Doherty
Initialise rte_ethdev_args parameters to zero to handle the case where no devargs are passed to the IXGBE PF on device probe, so that there is no invalid attempts to create representor ports. Coverity Issue: 277231 Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") Signed-off-by

[dpdk-dev] [dpdk-dev 1/3][PATCH v2] net/ixgbe: revert default PF PMD device name

2018-05-02 Thread Declan Doherty
Changes introduced by cf80ba6e2038 modified the default name generated for the IXGBE PF PMD, this patch reverts the default name to the original PCI BDBF. Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") Signed-off-by: Declan Doherty --- drivers/net/ixgbe/ixgbe_ethdev.c | 9 +

[dpdk-dev] [dpdk-dev 3/3][PATCH v2] net/ixgbe: add null pointer check for pf_ethdev

2018-05-02 Thread Declan Doherty
Add NULL parameter check for rte_eth_dev_allocated() API call to eth_ixgbe_pci_probe(). Coverity Issue: 277216 Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") Signed-off-by: Declan Doherty --- drivers/net/ixgbe/ixgbe_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 del

[dpdk-dev] [PATCH 2/2] malloc: avoid padding elements on page deallocation

2018-05-02 Thread Anatoly Burakov
Currently, when deallocating pages, malloc will fixup other elements' headers if there is not enough space to store a full element in leftover space. This leads to race conditions because there are some functions that check for pad size with an unlocked heap, expecting pad size to be constant. Fix

[dpdk-dev] [PATCH 1/2] malloc: set pad to 0 on free

2018-05-02 Thread Anatoly Burakov
The pad value is not used unless element is in pad state, but it will show up in heap dumps and may be confusing. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/malloc_elem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/common/malloc_elem.c b/lib/librte_eal/com

[dpdk-dev] [PATCH] net/mlx4: fix compilation issues in glue mode

2018-05-02 Thread Adrien Mazarguil
Since the commit referenced below, compiling mlx4 along with its glue library (CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS=y) triggers a compilation failure due to undefined symbols. They are caused by Verbs calls made directly from the PMD instead of going through the glue library. Fixes: ffc7411cabfe ("

Re: [dpdk-dev] [PATCH v3] eal: fix use-after-free issue on thread creation

2018-05-02 Thread Thomas Monjalon
02/05/2018 16:56, Olivier Matz: > On Wed, May 02, 2018 at 01:52:14PM +, Jianfeng Tan wrote: > > After below commit, we encounter some strange issue: > > 1) Dead lock as described here: > > http://dpdk.org/ml/archives/dev/2018-April/099806.html > > 2) SIGSEGV issue when starting a testp

Re: [dpdk-dev] ethdev new offloading API switch in PMDs

2018-05-02 Thread Ferruh Yigit
On 5/2/2018 2:44 PM, Shahaf Shuler wrote: > Wednesday, May 2, 2018 4:28 PM, Ferruh Yigit: >> Subject: Re: [dpdk-dev] ethdev new offloading API switch in PMDs >> >> On 5/2/2018 1:52 PM, Shahaf Shuler wrote: >>> Wednesday, May 2, 2018 11:47 AM, Ferruh Yigit: Subject: Re: [dpdk-dev] ethdev new of

Re: [dpdk-dev] [PATCH] eal: fix memory leak

2018-05-02 Thread Thomas Monjalon
02/05/2018 13:09, Olivier Matz: > On Wed, May 02, 2018 at 10:26:32AM +, Jianfeng Tan wrote: > > params is not freed if pthread_create() fails. The fix is > > straight-forward. > > > > Fixes: 3d09a6e26d8b ("eal: fix threads block on barrier") > > > > Reported-by: Olivier Matz > > Signed-off-b

Re: [dpdk-dev] [PATCH v3] eal: fix use-after-free issue on thread creation

2018-05-02 Thread Olivier Matz
On Wed, May 02, 2018 at 01:52:14PM +, Jianfeng Tan wrote: > After below commit, we encounter some strange issue: > 1) Dead lock as described here: > http://dpdk.org/ml/archives/dev/2018-April/099806.html > 2) SIGSEGV issue when starting a testpmd in VM. > > Considering below commit ch

Re: [dpdk-dev] [PATCH 1/2] ethdev: move log macro to header

2018-05-02 Thread Stephen Hemminger
On Wed, 2 May 2018 10:40:08 +0100 Ferruh Yigit wrote: > On 5/1/2018 7:56 PM, Thomas Monjalon wrote: > > 01/05/2018 19:28, Ferruh Yigit: > >> --- a/lib/librte_ethdev/rte_ethdev.c > >> +++ b/lib/librte_ethdev/rte_ethdev.c > >> -static int ethdev_logtype; > >> - > >> -#define ethdev_log(level, fmt

[dpdk-dev] [PATCH] net/mlx5: fix: flow validation

2018-05-02 Thread Nelio Laranjeiro
Item spec and last are wrongly compared to the NIC capability causing a validation failure when the mask is null. This validation function should only verify the user is not configuring unsupported matching fields. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") Cc: sta...@d

[dpdk-dev] [PATCH] x86: fix atomic exchange for 32-bit

2018-05-02 Thread Konstantin Ananyev
should break out of loop when rte_atomic64_cmpset() retruns non-zero. Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") Signed-off-by: Konstantin Ananyev --- lib/librte_eal/common/include/arch/x86/rte_atomic_32.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [dpdk-dev] [PATCH v2] eal: fix use-after-free issue on thread creation

2018-05-02 Thread Tan, Jianfeng
Hi Olivier, On 5/2/2018 7:24 PM, Olivier Matz wrote: Hi Jianfeng, On Wed, May 02, 2018 at 10:17:50AM +, Jianfeng Tan wrote: After below commit, we encounter some strange issue: 1) Dead lock as described here: http://dpdk.org/ml/archives/dev/2018-April/099806.html 2) SIGSEGV is

[dpdk-dev] [PATCH v3] eal: fix use-after-free issue on thread creation

2018-05-02 Thread Jianfeng Tan
After below commit, we encounter some strange issue: 1) Dead lock as described here: http://dpdk.org/ml/archives/dev/2018-April/099806.html 2) SIGSEGV issue when starting a testpmd in VM. Considering below commit changes to use dynamic memory instead of stack for memory barrier, we doubt

Re: [dpdk-dev] [PATCH v3 4/5] test/compress: add multi xform test

2018-05-02 Thread Daly, Lee
Hi Pablo, Feedback for a small change below. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, April 27, 2018 3:15 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; shally.ve...@cavium.com; > ahmed.mans...@nxp.com; ashish.gu...@cavium.com; D

Re: [dpdk-dev] ethdev new offloading API switch in PMDs

2018-05-02 Thread Shahaf Shuler
Wednesday, May 2, 2018 4:28 PM, Ferruh Yigit: > Subject: Re: [dpdk-dev] ethdev new offloading API switch in PMDs > > On 5/2/2018 1:52 PM, Shahaf Shuler wrote: > > Wednesday, May 2, 2018 11:47 AM, Ferruh Yigit: > >> Subject: Re: [dpdk-dev] ethdev new offloading API switch in PMDs > >> > >> On 5/2/2

Re: [dpdk-dev] [PATCH v3 1/5] test/compress: add initial unit tests

2018-05-02 Thread Daly, Lee
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, April 27, 2018 3:15 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; shally.ve...@cavium.com; > ahmed.mans...@nxp.com; ashish.gu...@cavium.com; De Lara Guarch, > Pablo ; Ashish Gupta > ; Sh

Re: [dpdk-dev] [PATCH v6 4/5] iFPGA: add meson build

2018-05-02 Thread Zhang, Tianfei
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Wednesday, May 2, 2018 5:47 PM > To: Xu, Rosen ; dev@dpdk.org; Yigit, Ferruh > > Cc: Doherty, Declan ; Richardson, Bruce > ; Ananyev, Konstantin > ; Zhang, Tianfei ; > Wu, Hao ; gaetan.ri...@6wind.com > Su

Re: [dpdk-dev] [PATCH v6 1/5] iFPGA: Add Intel FPGA BUS Library

2018-05-02 Thread Zhang, Tianfei
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Wednesday, May 2, 2018 9:14 PM > To: Xu, Rosen ; dev@dpdk.org > Cc: Doherty, Declan ; Richardson, Bruce > ; Yigit, Ferruh ; > Ananyev, Konstantin ; Zhang, Tianfei > ; Wu, Hao ; > gaetan.ri...@6wind.com > Su

Re: [dpdk-dev] ethdev new offloading API switch in PMDs

2018-05-02 Thread Ferruh Yigit
On 5/2/2018 1:52 PM, Shahaf Shuler wrote: > Wednesday, May 2, 2018 11:47 AM, Ferruh Yigit: >> Subject: Re: [dpdk-dev] ethdev new offloading API switch in PMDs >> >> On 5/2/2018 6:34 AM, Shahaf Shuler wrote: >>> Tuesday, May 1, 2018 5:01 PM, Ferruh Yigit: Subject: ethdev new offloading API swit

Re: [dpdk-dev] [PATCH v6 1/5] iFPGA: Add Intel FPGA BUS Library

2018-05-02 Thread Shreyansh Jain
On Thursday 26 April 2018 03:13 PM, Xu, Rosen wrote: From: Rosen Xu Defined FPGA-BUS for Acceleration Drivers of AFUs 1. FPGA PCI Scan (1st Scan) follows DPDK UIO/VFIO PCI Scan Process, probe Intel FPGA Rawdev Driver. 2. AFU Scan(2nd Scan) bind DPDK driver to FPGA Partial-Bitstream. This scan i

Re: [dpdk-dev] ethdev new offloading API switch in PMDs

2018-05-02 Thread Shahaf Shuler
Wednesday, May 2, 2018 11:47 AM, Ferruh Yigit: > Subject: Re: [dpdk-dev] ethdev new offloading API switch in PMDs > > On 5/2/2018 6:34 AM, Shahaf Shuler wrote: > > Tuesday, May 1, 2018 5:01 PM, Ferruh Yigit: > >> Subject: ethdev new offloading API switch in PMDs > >> > >> Hi, > >> > >> Following P

Re: [dpdk-dev] [PATCH] use SPDX license tag in Mellanox copyrighted files

2018-05-02 Thread Shahaf Shuler
Tuesday, May 1, 2018 11:07 PM, Thomas Monjalon: > Subject: [PATCH] use SPDX license tag in Mellanox copyrighted files > > Some files were left with full license and wrong copyright format. > They are switched to this format: > SPDX-License-Identifier: BSD-3-Clause > Copyright 2017 Mell

Re: [dpdk-dev] [PATCH 00/12] Vhost: CVE-2018-1059 fixes

2018-05-02 Thread Yao, Lei A
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, May 2, 2018 5:20 PM > To: Yao, Lei A ; dev@dpdk.org > Cc: Bie, Tiwei > Subject: Re: [dpdk-dev] [PATCH 00/12] Vhost: CVE-2018-1059 fixes > > Hi Lei, > > Thanks for the perf report. > > O

Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix queue offload initialize

2018-05-02 Thread Ananyev, Konstantin
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, May 2, 2018 4:57 AM > To: Yigit, Ferruh ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > > Subject: [PATCH v2 1/2] net/i40e: fix queue offload initialize > > Add missing queue offload initialization.

Re: [dpdk-dev] [PATCH v2] eal: fix use-after-free issue on thread creation

2018-05-02 Thread Olivier Matz
Hi Jianfeng, On Wed, May 02, 2018 at 10:17:50AM +, Jianfeng Tan wrote: > After below commit, we encounter some strange issue: > 1) Dead lock as described here: > http://dpdk.org/ml/archives/dev/2018-April/099806.html > 2) SIGSEGV issue when starting a testpmd in VM. > > Considering b

Re: [dpdk-dev] [PATCH 1/3] net/ixgbe: remove dependence on Tx queue flags

2018-05-02 Thread Ananyev, Konstantin
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, May 2, 2018 4:16 AM > To: Yigit, Ferruh > Cc: Dai, Wei ; Lu, Wenzhuo ; > Ananyev, Konstantin ; > Wang, Xiao W ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH 1/3] net/ixgbe: remove dependence on Tx queue flags > > Since we m

Re: [dpdk-dev] [PATCH] eal: fix memory leak

2018-05-02 Thread Olivier Matz
On Wed, May 02, 2018 at 10:26:32AM +, Jianfeng Tan wrote: > params is not freed if pthread_create() fails. The fix is > straight-forward. > > Fixes: 3d09a6e26d8b ("eal: fix threads block on barrier") > > Reported-by: Olivier Matz > Signed-off-by: Jianfeng Tan Reviewed-by: Olivier Matz

Re: [dpdk-dev] [PATCH] net/axgbe: fix coverity issue 277239

2018-05-02 Thread Ferruh Yigit
On 5/2/2018 9:47 AM, Ravi Kumar wrote: > Stored register value to enable jumbo frame was always > overwritten. Assigning value based on rx_buf_size. > > Signed-off-by: Ravi Kumar Updated as: net/axgbe: fix value always overwritten Stored register value to enable jumbo frame was always

Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix queue offload initialize

2018-05-02 Thread Ferruh Yigit
On 5/2/2018 4:56 AM, Qi Zhang wrote: > Add missing queue offload initialization. > > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") > Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API") > > Signed-off-by: Qi Zhang Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/vmxnet3: convert to new rx offload api

2018-05-02 Thread Ferruh Yigit
On 5/1/2018 10:22 PM, Louis Luo wrote: > Ethdev RX offloads API has changed since: commit ce17eddefc20 > ("ethdev: introduce Rx queue offloads API") > > This patch adopts the new RX Offload API in vmxnet3 driver. > > Signed-off-by: Louis Luo > Acked-by: Yong Wang Applied to dpdk-next-net/maste

Re: [dpdk-dev] New RC needed for stablility?

2018-05-02 Thread Ferruh Yigit
On 4/30/2018 2:02 PM, Thomas Monjalon wrote: > 30/04/2018 14:57, Bruce Richardson: >> Hi Thomas, Ferruh, all, >> >> Initial testing on RC1 from our System Test and Validation shows a lot of >> defects/issues, and from the list it appears others may be seeing issues >> too. These issues, as well as

[dpdk-dev] [PATCH] eal: fix memory leak

2018-05-02 Thread Jianfeng Tan
params is not freed if pthread_create() fails. The fix is straight-forward. Fixes: 3d09a6e26d8b ("eal: fix threads block on barrier") Reported-by: Olivier Matz Signed-off-by: Jianfeng Tan --- lib/librte_eal/common/eal_common_thread.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

Re: [dpdk-dev] pthread_barrier_deadlock in -rc1

2018-05-02 Thread Tan, Jianfeng
On 5/2/2018 6:08 PM, Olivier Matz wrote: On Wed, May 02, 2018 at 06:01:20PM +0800, Tan, Jianfeng wrote: Hi Olivier and Anatoly, [...] Below patch can fix another strange sigsegv issue in my VM. Please check if it works for you. I doubt it's use-after-free problem which could lead to differe

[dpdk-dev] [PATCH v2] eal: fix use-after-free issue on thread creation

2018-05-02 Thread Jianfeng Tan
After below commit, we encounter some strange issue: 1) Dead lock as described here: http://dpdk.org/ml/archives/dev/2018-April/099806.html 2) SIGSEGV issue when starting a testpmd in VM. Considering below commit changes to use dynamic memory instead of stack for memory barrier, we doubt

Re: [dpdk-dev] pthread_barrier_deadlock in -rc1

2018-05-02 Thread Olivier Matz
On Wed, May 02, 2018 at 06:01:20PM +0800, Tan, Jianfeng wrote: > Hi Olivier and Anatoly, > > [...] > > > > > Below patch can fix another strange sigsegv issue in my VM. Please check > > > > if it works for you. I doubt it's use-after-free problem which could > > > > lead to different issues in di

  1   2   >