[dpdk-dev] [PATCH v3 0/2] testpmd: simulating noisy host environment

2018-04-18 Thread Jens Freimann
This series adds a new forwarding mode 'noisy'. It proposes enhancements to testpmd to simulate more realistic behavior of a guest machine engaged in receiving and sending packets performing Virtual Network Function (VNF). The goal is to enable simple of measuring performance impact on cache and

Re: [dpdk-dev] [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow

2018-04-18 Thread Nélio Laranjeiro
On Thu, Apr 19, 2018 at 06:20:50AM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Nélio Laranjeiro > > Sent: Wednesday, April 18, 2018 11:09 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v4 03/11] net/mlx5: support L3 V

[dpdk-dev] [PATCH] net/i40e:fix checking offloading fail for Tx

2018-04-18 Thread Yanglong Wu
Missing "return -ENOTSUP" will alays leads to illegal offload passing through offload checking. Fixes: b43290f1ade2 ("net/i40e: convert to new Tx offloads API") Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_rxtx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/driv

[dpdk-dev] [PATCH] net/i40e:fix missing some offload capabilities

2018-04-18 Thread Yanglong Wu
MULTI_SEGS and JUMBO_FRAME offload capability should be exposed both VF and PF since i40e does support it. Fixes: fbf959fe61e7 ("net/i40e: convert to new Rx offloads API") Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_ethdev.c| 3 ++- drivers/net/i40e/i40e_ethdev_vf.c | 6 -- 2 fi

Re: [dpdk-dev] [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow

2018-04-18 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Wednesday, April 18, 2018 11:09 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow > > On Wed, Apr 18, 2018 at 02:43:30PM +, Xueming(Steven) Li wrote: >

Re: [dpdk-dev] [RFC 2/2] nfp: allow for non-root user

2018-04-18 Thread Alejandro Lucero
On Wed, Apr 18, 2018 at 1:32 PM, Aaron Conole wrote: > Alejandro Lucero writes: > > > On Tue, Apr 17, 2018 at 8:19 PM, Aaron Conole > wrote: > > > > Alejandro Lucero writes: > > > > > I was just wondering, if device device PCI sysfs resource files or > VFIO group /dev files > > require to c

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-18 Thread Alejandro Lucero
I do not completely understand the discussion, but I think the disagreement is due to how some devices interact with DPDK, at least Mellanox ones. I'm saying that because we have a DPDK app which starts with no device at all (--no-pci) and it relies on device plugging attach/detach for configuring

[dpdk-dev] [PATCH v4 08/11] eal: replace rte_panic instances in interrupts thread

2018-04-18 Thread Arnon Warshavsky
replace panic calls with log and retrun value. Thread function removes the noretrun attribute. Signed-off-by: Arnon Warshavsky --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linuxapp

[dpdk-dev] [PATCH v4 09/11] eal: replace rte_panic instances in ethdev

2018-04-18 Thread Arnon Warshavsky
Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- lib/librte_ether/rte_ethdev.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether

[dpdk-dev] [PATCH v4 11/11] devtools: prevent new instances of rte_panic and rte_exit

2018-04-18 Thread Arnon Warshavsky
This patch adds a new function that is called per every checked patch, and alerts for new instances of rte_panic/rte_exit. The check excludes comments, and alerts in the case of a positive balance between additions and removals. Signed-off-by: Arnon Warshavsky --- devtools/checkpatches.sh | 94 +

[dpdk-dev] [PATCH v4 10/11] eal: replace rte_panic instances in init sequence

2018-04-18 Thread Arnon Warshavsky
Local functions to this file, changing from void to int are non-abi-breaking. For handling the single function that cannot change from void to int due to abi, where this is the only place it is called in, I added a state variable that is being checked right after the call to this function. -- v4

[dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info

2018-04-18 Thread Arnon Warshavsky
replace panic calls with log and retrun value. v4 static size calculation function changed to return success/fail code in addition to filling the size result. Signed-off-by: Arnon Warshavsky --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 32 - 1 file changed, 21

[dpdk-dev] [PATCH v4 05/11] eal: replace rte_panic instances in eventdev

2018-04-18 Thread Arnon Warshavsky
replace panic calls with log and retrun value. -- v4 - fix split literal strings in log messages Signed-off-by: Arnon Warshavsky --- lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +--- lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +--- 2 files changed, 10 insertions(+), 6 deletions

[dpdk-dev] [PATCH v4 06/11] kni: replace rte_panic instances in kni

2018-04-18 Thread Arnon Warshavsky
replace panic calls with log and retrun value. Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- lib/librte_kni/rte_kni.c | 18 -- lib/librte_kni/rte_kni_fifo.h | 11 --- 2 files changed, 20 insertions(+),

[dpdk-dev] [PATCH v4 04/11] ixgbe: replace rte_panic instances in ixgbe driver

2018-04-18 Thread Arnon Warshavsky
replace panic calls with log and retrun value. Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 13 +

[dpdk-dev] [PATCH v4 00/11] eal: replace calls to rte_panic and refrain from new instances

2018-04-18 Thread Arnon Warshavsky
The purpose of this patch series is to cleanup the library code from paths that end up aborting the process, and move to checking error values, in order to allow the running process perform an orderly teardown or other mitigation of the event. This patch modifies the majority of rte_panic calls un

[dpdk-dev] [PATCH v4 01/11] crypto: replace rte_panic instances in crypto driver

2018-04-18 Thread Arnon Warshavsky
replace panic calls with log and return value. -- v2: - reformat error message to include literal string in a single line v4: replace -1 return value with -ENOMEM Signed-off-by: Arnon Warshavsky --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +--- drivers/crypto/dpaa_sec/dpaa_sec.c

[dpdk-dev] [PATCH v4 03/11] e1000: replace rte_panic instances in e1000 driver

2018-04-18 Thread Arnon Warshavsky
replace panic calls with log and retrun value. Local function to this file, changing from void to int is non-abi-breaking -- v4 - keep error message literal string in a singhle line Signed-off-by: Arnon Warshavsky --- drivers/net/e1000/e1000_ethdev.h | 2 +- drivers/net/e1000/igb_ethdev.c |

[dpdk-dev] [PATCH v4 02/11] bond: replace rte_panic instances in bonding driver

2018-04-18 Thread Arnon Warshavsky
replace panic calls with log and retrun value. Local functions to this file, changing from void to int are non-abi-breaking -- v4 - fix split literal strings in log messages Signed-off-by: Arnon Warshavsky --- drivers/net/bonding/rte_eth_bond_8023ad.c | 28 +++ driver

Re: [dpdk-dev] [PATCH v2 1/2] net/pcap: physical interface MAC support

2018-04-18 Thread Kuusisaari, Juhamatti
> >> Why a build time config option for this? Can we make it a runtime devarg? > > > > Sure, we can make it a devarg. Or do we even need that? Are there a lot of > test dependencies that would need to be fixed if we have it enabled by > default? > > Not test dependencies but this may be overkill f

Re: [dpdk-dev] [RFC] P4 enablement in DPDK

2018-04-18 Thread Kuusisaari, Juhamatti
Hello, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Cristian Dumitrescu > Sent: Wednesday, April 18, 2018 8:22 PM > To: dev@dpdk.org > Cc: dan.d...@intel.com > Subject: [dpdk-dev] [RFC] P4 enablement in DPDK > > P4 is a language for programming the data plan

Re: [dpdk-dev] [PATCH] test/tun: add new test for tun

2018-04-18 Thread Varghese, Vipin
Hi Ferruh, > Hi Vipin, > > Thanks for providing unit test for the feature you have added. *I believe we > need more unit test in DPDK.* > > Only a few questions: > 1- Should this be part of auto test? It would be really nice to do so, but only constrain is ping command requires least 5 secon

[dpdk-dev] [PATCH v4] kni: fix possible rx_q mbuf leaks and speed up alloc_q release

2018-04-18 Thread Yangchao Zhou
rx_q fifo can only be released by kernel thread. There may be mbuf leaks in rx_q because kernel threads are randomly stopped. When the kni is released and netdev is unregisterd, convert the physical address mbufs in rx_q to the virtual address in free_q. By the way, alloc_q can be processed togeth

[dpdk-dev] [PATCH v3] net/i40e:fix missing jumbo frame offload capability

2018-04-18 Thread Yanglong Wu
JUMBO_FRAME offload capability should be exposed since i40e does support it. Fixes: fbf959fe61e7 ("net/i40e: convert to new Rx offloads API") Signed-off-by: Yanglong Wu Acked-by: Qi Zhang --- v2: add fix commit --- v3: rework commit log --- drivers/net/i40e/i40e_ethdev.c | 3 ++- 1 file changed

[dpdk-dev] [PATCH] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload

2018-04-18 Thread Yanglong Wu
JUMBO_FRAME offload should be set as default, missing it will lead to start failing for I40e. Fixes: fbf959fe61e7 ("net/i40e: convert to new Rx offloads API") Signed-off-by: Yanglong Wu --- v2: add fix commit --- drivers/net/i40e/i40e_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

Re: [dpdk-dev] [PATCH V20 2/4] eal: add failure handler mechanism for hot plug

2018-04-18 Thread Zhang, Qi Z
Hi Jeff > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo > Sent: Wednesday, April 18, 2018 9:38 PM > To: step...@networkplumber.org; Richardson, Bruce > ; Yigit, Ferruh ; > Ananyev, Konstantin ; > gaetan.ri...@6wind.com; Wu, Jingjing ; > tho...@monjalon.

[dpdk-dev] [PATCH v3 1/2] mbuf: support attaching external buffer to mbuf

2018-04-18 Thread Yongseok Koh
This patch introduces a new way of attaching an external buffer to a mbuf. Attaching an external buffer is quite similar to mbuf indirection in replacing buffer addresses and length of a mbuf, but a few differences: - As refcnt of a direct mbuf is at least 2, the buffer area of a direct mbuf

[dpdk-dev] [PATCH v3 2/2] app/testpmd: conserve offload flags of mbuf

2018-04-18 Thread Yongseok Koh
If PMD delivers Rx packets with non-direct mbuf, ol_flags should not be overwritten. For mlx5 PMD, if Multi-Packet RQ is enabled, Rx packets could be externally attached mbufs. Signed-off-by: Yongseok Koh --- app/test-pmd/csumonly.c | 3 +++ app/test-pmd/macfwd.c | 3 +++ app/test-pmd/macswap.

Re: [dpdk-dev] [PATCH v6 2/2] net/vhost: update license to SPDX format

2018-04-18 Thread Takanari Hayama
On 2018/04/13 1:43, Junjie Chen wrote: > Update license to SPDX, also add Intel license. > > Signed-off-by: Junjie Chen > --- > drivers/net/vhost/rte_eth_vhost.c | 34 +++--- > drivers/net/vhost/rte_eth_vhost.h | 35 +++ > 2 files chan

[dpdk-dev] [PATCH v4 4/6] ethdev: add mark flow item to flow item types

2018-04-18 Thread Declan Doherty
Introduces a new action type RTE_FLOW_ITEM_TYPE_MARK which enables flow patterns to specify arbitrary integer values to match aginst which are set by the RTE_FLOW_ACTION_TYPE_MARK action in a previously matched flow from a higher prioriry group. Signed-off-by: Declan Doherty --- doc/guides/prog

[dpdk-dev] [PATCH v4 6/6] ethdev: add shared counter support to rte_flow

2018-04-18 Thread Declan Doherty
Add rte_flow_action_count action data structure to enable shared counters across multiple flows on a single port or across multiple flows on multiple ports within the same switch domain. Also this enables multiple count actions to be specified in a single flow. This patch also modifies the existin

[dpdk-dev] [PATCH v4 5/6] testpmd: add support for MARK flow item

2018-04-18 Thread Declan Doherty
Add support for specificaiton of new MARK flow item in testpmd's cli, and update testpmd documentation to describe new MARK flow item support. Signed-off-by: Declan Doherty --- app/test-pmd/cmdline_flow.c | 22 ++ doc/guides/testpmd_app_ug/testpmd_funcs.rst |

[dpdk-dev] [PATCH v4 3/6] testpmd: add jump action

2018-04-18 Thread Declan Doherty
Add support for specificaiton of new JUMP action to testpmd's flow cli, and update the testpmd documentation to describe this new action. Signed-off-by: Declan Doherty --- app/test-pmd/cmdline_flow.c | 23 +++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 +

[dpdk-dev] [PATCH v4 2/6] ethdev: Add jump action type to rte_flow

2018-04-18 Thread Declan Doherty
Add jump action type which defines an action which allows a matched flow to be redirect to the specified group. This allows physical and logical flow table/group hierarchies to be managed through rte_flow. Signed-off-by: Declan Doherty --- doc/guides/prog_guide/rte_flow.rst | 26

[dpdk-dev] [PATCH v4 1/6] ethdev: Add tunnel encap/decap actions

2018-04-18 Thread Declan Doherty
Add new flow action types and associated action data structure to support the encapsulation and decapsulation of VXLAN/NVGRE tunnel endpoints. The RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP or RTE_FLOW_ACTION_TYPE_NVGRE_ENCAP actions will cause the matching flow to be encapsulated in the tunnel endpoint ove

[dpdk-dev] [PATCH v4 0/6] additions to support tunnel encap/decap

2018-04-18 Thread Declan Doherty
This patchset contains the revised proposal to manage virtual tunnel endpoints hardware accleration based on community feedback on RFC (http://dpdk.org/ml/archives/dev/2017-December/084676.html). This proposal is purely enabled through rte_flow APIs with the additions of some new features which w

[dpdk-dev] [PATCH 0/2] small fixes for meson build

2018-04-18 Thread Bruce Richardson
couple of minor fixes for meson build, patch titles are largely self-explanatory. Bruce Richardson (2): build: fix kernel compile on cross-build build: fix check for libbsd in meson config/meson.build | 3 ++- meson.build| 6 +- 2 files changed, 7 insertions(+), 2 deletions(-) -

[dpdk-dev] [PATCH 2/2] build: fix check for libbsd in meson

2018-04-18 Thread Bruce Richardson
When we check for libbsd we were just checking for the library itself. However, on some distros, e.g. CentOS, libbsd will be found even though it's not usable by DPDK as it's missing the string header. Therefore we should check for both the library and the header file. Fixes: 5364de644a4b ("eal: s

[dpdk-dev] [PATCH 1/2] build: fix kernel compile on cross-build

2018-04-18 Thread Bruce Richardson
When cross-compiling, if no kernel_dir was specified, then the kernel modules were still being compiled for the build machine. Fix this by only building modules on cross-compile when we have a kernel_dir value set. Fixes: a52f4574f798 ("igb_uio: build with meson") Signed-off-by: Bruce Richardson

[dpdk-dev] [PATCH 1/2] net/bnx2x: fix for PCI FLR after ungraceful exit

2018-04-18 Thread Rasesh Mody
From: Rasesh Mody This patch provides a fix for PCI function level reset after an ungraceful exit from an application. The fix is to enable internal target read as part of device attach before getting device information from device config space, device itself and shared memory. In addition to tha

[dpdk-dev] [PATCH 2/2] net/bnx2x: make init and driver logtype names consistent

2018-04-18 Thread Rasesh Mody
From: Rasesh Mody Signed-off-by: Rasesh Mody --- doc/guides/nics/bnx2x.rst|1 + drivers/net/bnx2x/bnx2x_ethdev.c |4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/bnx2x.rst b/doc/guides/nics/bnx2x.rst index 31f146a..cecbfc2 100644 --- a/doc/

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-18 Thread Flavio Leitner
On Wed, Apr 18, 2018 at 11:17:47AM -0700, Stephen Hemminger wrote: > On Wed, 18 Apr 2018 11:11:01 -0300 > Flavio Leitner wrote: > > > On Sun, Apr 15, 2018 at 01:48:36AM +, Stephen Hemminger wrote: > > > My vote is to work with udev and not try to replace it. > > > > > > Driverctl works well.

Re: [dpdk-dev] Why packet replication is more efficient when done using memcpy( ) as compared to rte_mbuf_refcnt_update() function?

2018-04-18 Thread Wiles, Keith
> On Apr 18, 2018, at 11:43 AM, Shailja Pandey wrote: > > Hello, > > I am doing packet replication and I need to change the ethernet and IP header > field for each replicated packet. I did it in two different ways: > > 1. Share payload from the original packet using rte_mbuf_refcnt_update >

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-18 Thread Stephen Hemminger
On Wed, 18 Apr 2018 11:11:01 -0300 Flavio Leitner wrote: > On Sun, Apr 15, 2018 at 01:48:36AM +, Stephen Hemminger wrote: > > My vote is to work with udev and not try to replace it. > > > > Driverctl works well. Just not for bifurcated driver > > I second that. We also have other system

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: enable vector PMD for icc 32 bits

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 7:06 PM, Ferruh Yigit wrote: > On 4/17/2018 2:39 PM, Pablo de Lara wrote: >> IXGBE vector PMD was re-enabled for 32 bits, but only for gcc. >> This commit enables it for icc too. >> >> Fixes: e6672d2f0f88 ("net/ixgbe: enable ixgbe vector PMD for i686") >> Cc: sta...@dpdk.org >> >> Sign

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: enable vector PMD for icc 32 bits

2018-04-18 Thread Ferruh Yigit
On 4/17/2018 2:39 PM, Pablo de Lara wrote: > IXGBE vector PMD was re-enabled for 32 bits, but only for gcc. > This commit enables it for icc too. > > Fixes: e6672d2f0f88 ("net/ixgbe: enable ixgbe vector PMD for i686") > Cc: sta...@dpdk.org > > Signed-off-by: Pablo de Lara Reviewed-by: Ferruh Yi

[dpdk-dev] [PATCH v4 4/4] bus/vmbus and net/netvsc: add meson build support

2018-04-18 Thread Stephen Hemminger
Update meson build files for new netvsc and vmbus drivers. Signed-off-by: Stephen Hemminger --- config/meson.build | 7 +++ drivers/bus/meson.build| 2 +- drivers/bus/vmbus/meson.build | 16 drivers/net/meson.build| 2 +- drivers/net/netvsc/me

[dpdk-dev] [PATCH v4 2/4] net/netvsc: add hyper-v netvsc network device

2018-04-18 Thread Stephen Hemminger
From: Stephen Hemminger The driver supports Hyper-V networking directly like virtio for KVM or vmxnet3 for VMware. This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed). Signed-off-by: St

[dpdk-dev] [PATCH v4 3/4] net/netvsc: add documentation

2018-04-18 Thread Stephen Hemminger
Matching documentation for new netvsc device. Signed-off-by: Stephen Hemminger --- doc/guides/nics/features/netvsc.ini| 23 ++ doc/guides/nics/index.rst | 1 + doc/guides/nics/netvsc.rst | 97 ++ doc/guides/rel_notes/release_18_05.rst |

[dpdk-dev] [PATCH v4 0/4] Hyper-V Netvsc PMD (and VMBus)

2018-04-18 Thread Stephen Hemminger
This is a revised version of the Hyper-V native bus (VMBus) and network device (netvsc) drivers. This virtual device is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Onl

[dpdk-dev] [PATCH v4 1/4] bus/vmbus: add hyper-v virtual bus support

2018-04-18 Thread Stephen Hemminger
From: Stephen Hemminger This patch adds support for an additional bus type Virtual Machine BUS (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade. Only Linux is supported

[dpdk-dev] [PATCH] doc: update turbo software driver build instructions

2018-04-18 Thread Amr Mokhtar
* Download and build instructions for BBDEV turbo_sw driver in compliance with FlexRAN SDK 1.4.0 release. * Added a note to enable building as a shared lib * Minor update for test execution example instruction * Minor update for capabilities supported Signed-off-by: Amr Mokhtar --- doc/guides/bb

Re: [dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 6:55 PM, Pavan Nikhilesh wrote: > On Wed, Apr 18, 2018 at 06:43:11PM +0100, Ferruh Yigit wrote: >> On 4/18/2018 4:30 PM, Pavan Nikhilesh wrote: >>> Add macro to mark a variable to be mostly read only and place it in a >>> separate section. >>> >>> Signed-off-by: Pavan Nikhilesh >>> --

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: introduce generic IP/UDP tunnel checksum and TSO

2018-04-18 Thread Thomas Monjalon
18/04/2018 18:45, Ananyev, Konstantin: > From: Thomas Monjalon > > 18/04/2018 15:58, Xueming Li: > > > The new flag PKT_TX_TUNNEL_IP is redundant with PKT_TX_OUTER_IP_CKSUM. > > > The old flag PKT_TX_OUTER_IP_CKSUM can be deprecated and removed in > > > later release. > > > > > > Signed-off-by: Xue

Re: [dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-18 Thread Pavan Nikhilesh
On Wed, Apr 18, 2018 at 06:43:11PM +0100, Ferruh Yigit wrote: > On 4/18/2018 4:30 PM, Pavan Nikhilesh wrote: > > Add macro to mark a variable to be mostly read only and place it in a > > separate section. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > > > Group together mostly read only data

Re: [dpdk-dev] [PATCH] net/axgbe: fix incorrect cache alignment macro

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 6:17 PM, Ferruh Yigit wrote: > On 4/17/2018 9:04 PM, Pavan Nikhilesh wrote: >> Due to missing cacheline_aligned definition compiler treats it as a >> global variable replace it with proper cache alignment macro. >> >> Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup") >> >> Signed-

Re: [dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 4:30 PM, Pavan Nikhilesh wrote: > Add macro to mark a variable to be mostly read only and place it in a > separate section. > > Signed-off-by: Pavan Nikhilesh > --- > > Group together mostly read only data to avoid cacheline bouncing, also > useful for auditing purposes. > > lib

Re: [dpdk-dev] Retire x86 32 bit?

2018-04-18 Thread Jim Murphy
Same for our case. On Tue, Apr 17, 2018 at 2:18 PM, Roger B Melton wrote: > On 4/17/18 4:46 PM, Stephen Hemminger wrote: > >> On Tue, 17 Apr 2018 13:01:14 -0700 >> Jim Murphy wrote: >> >> Still used in certain memory constrained environments. >>> >>> >>> On Tue, Apr 17, 2018 at 11:39 AM, David

Re: [dpdk-dev] [PATCH v3 2/4] net/netvsc: add hyper-v netvsc network device

2018-04-18 Thread Stephen Hemminger
On Wed, 18 Apr 2018 14:19:52 +0100 Ferruh Yigit wrote: > > +/* enables testpmd to collect per queue stats. */ > > +static int > > +hn_queue_stats_mapping_set(__rte_unused struct rte_eth_dev *eth_dev, > > + __rte_unused uint16_t queue_id, > > + __r

[dpdk-dev] [RFC] P4 enablement in DPDK

2018-04-18 Thread Cristian Dumitrescu
P4 is a language for programming the data plane of network devices [1]. The P4 language is developed by p4.org which is joining ONF and Linux Foundation [2]. This API provides a way to program P4 capable devices through DPDK. The purpose of this API is to enable P4 compilers [3] to generate high p

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 10/11] ethdev: fix missing boolean values in flow command

2018-04-18 Thread Ferruh Yigit
On 4/17/2018 9:25 AM, Adrien Mazarguil wrote: > On Mon, Apr 16, 2018 at 07:17:44PM +, Matan Azrad wrote: >> Hi Adrien >> >> I think the title should be "app/testpmd: ..." ... > > Indeed, I'll update it in the next iteration, thanks. If this is the only issue, it can be fixed while applying. A

Re: [dpdk-dev] [PATCH] net/axgbe: fix incorrect cache alignment macro

2018-04-18 Thread Ferruh Yigit
On 4/17/2018 9:04 PM, Pavan Nikhilesh wrote: > Due to missing cacheline_aligned definition compiler treats it as a > global variable replace it with proper cache alignment macro. > > Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup") > > Signed-off-by: Pavan Nikhilesh Reviewed-by: Ferruh Yi

Re: [dpdk-dev] [PATCH v2] net/enic: fix uninitialized variable

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 1:00 AM, John Daley wrote: > A local variable was used without initialization and triggered a > coverity issue. > > Is is fixed here, but there is no ill effect of not initializing > the variable in this case. 'rxq_interrupt_offset' is irrelevant > if 'rxq_interrupt_enable' is not set

Re: [dpdk-dev] [PATCH] net/thunderx: fix MTU configuration for jumbo pkts

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 5:56 AM, Jerin Jacob wrote: > -Original Message- >> Date: Mon, 16 Apr 2018 10:44:47 + >> From: Nitin Saxena >> To: Jerin Jacob >> Cc: Nitin Saxena , Narayana Prasad >> , dev@dpdk.org >> Subject: [PATCH] net/thunderx: fix MTU configuration for jumbo pkts >> X-Mailer: git-

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent

2018-04-18 Thread Yong Wang
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, April 17, 2018 1:24 PM > To: Ferruh Yigit > Cc: Chas Williams <3ch...@gmail.com>; Chas Williams ; > dev@dpdk.org; skh...@vmware.com; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-

[dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-18 Thread Reshma Pattan
Copying source string of length equal to sizeof(profile->name) will not append the NULL in destination. Using strlcpy in place of strncpy fixes this issue as strlcpy guarantees NULL termination. Coverity issue: 272580 Fixes: 719374345c ("examples/ip_pipeline: add action profile objects") CC: jasv

[dpdk-dev] [PATCH] examples/ip_pipipeline: fix resource leak

2018-04-18 Thread Reshma Pattan
Close tap device fd before returning upon failures. Coverity issue: 272576 Fixes: 2f74ae28e2 ("examples/ip_pipeline: add tap object") CC: jasvinder.si...@intel.com Signed-off-by: Reshma Pattan --- examples/ip_pipeline/tap.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --

[dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-18 Thread Reshma Pattan
Copying source string of length equal to sizeof(kni->name) will not append the NULL to destination string. Using strlcpy in place of strncpy fixes this issue as strlcpy guarantees NULL termination. Coverity issue: 272562 Fixes: 9a408cc8ac ("examples/ip_pipeline: add KNI object") CC: jasvinder.si.

[dpdk-dev] [PATCH] examples/ip_pipeline: fixes uninitialized scalar variable

2018-04-18 Thread Reshma Pattan
Using uninitialized value p.thread_id when calling kni_create. Initialize the kni_params object to 0. Coverity issue: 272569 Fixes: 9a408cc8ac ("examples/ip_pipeline: add KNI object") CC: jasvinder.si...@intel.com Signed-off-by: Reshma Pattan --- examples/ip_pipeline/cli.c | 1 + 1 file changed

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: introduce generic IP/UDP tunnel checksum and TSO

2018-04-18 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, April 18, 2018 3:28 PM > To: Xueming Li > Cc: Lu, Wenzhuo ; Wu, Jingjing ; > Yongseok Koh ; Olivier MATZ > ; Shahaf Shuler ; Iremonger, > Bernard ; Yigit, Ferruh > ; dev@dpdk.

[dpdk-dev] Why packet replication is more efficient when done using memcpy( ) as compared to rte_mbuf_refcnt_update() function?

2018-04-18 Thread Shailja Pandey
Hello, I am doing packet replication and I need to change the ethernet and IP header field for each replicated packet. I did it in two different ways: 1. Share payload from the original packet using rte_mbuf_refcnt_update and allocate new mbuf for L2-L4 headers. 2. memcpy() payload from the

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent

2018-04-18 Thread Ferruh Yigit
On 4/17/2018 9:24 PM, Thomas Monjalon wrote: > 17/04/2018 21:25, Ferruh Yigit: >> On 4/5/2018 4:01 PM, Chas Williams wrote: >>> On Thu, Apr 5, 2018 at 6:03 AM, Thomas Monjalon wrote: 20/03/2018 15:12, Ferruh Yigit: > On 3/18/2018 1:45 AM, Chas Williams wrote: >> From: Chas Williams >

Re: [dpdk-dev] [PATCH v3 3/4] net/netvsc: add documentation

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 5:03 PM, Stephen Hemminger wrote: > On Wed, 18 Apr 2018 14:25:22 +0100 > Ferruh Yigit wrote: > >> On 4/17/2018 10:53 PM, Stephen Hemminger wrote: >>> Matching documentation for new netvsc device. >>> >>> Signed-off-by: Stephen Hemminger >>> --- >>> doc/guides/nics/index.rst

Re: [dpdk-dev] [PATCH v3 1/5] net/ixgbevf: set the inter-interrupt interval for EITR.

2018-04-18 Thread Ferruh Yigit
On 4/18/2018 2:01 AM, Tonghao Zhang wrote: > On Tue, Apr 17, 2018 at 7:00 PM, Ferruh Yigit wrote: >> On 3/22/2018 1:01 PM, xiangxia.m@gmail.com wrote: >>> From: Tonghao Zhang >>> >>> Set EITR interval as default. This patch can improve the >>> performance when we enable the rx-intrrupt to pro

Re: [dpdk-dev] [PATCH v3 2/4] net/netvsc: add hyper-v netvsc network device

2018-04-18 Thread Stephen Hemminger
> > +/* XXX Why is this not generic in RTE? */ > > +static int > > +hn_dev_atomic_write_link_status(struct rte_eth_dev *dev, > > + struct rte_eth_link *link) > > +{ > > It is indeed generic now thanks to you :) > Can you switch to your generic functions? Will change in v4. This driv

Re: [dpdk-dev] [PATCH v3 3/4] net/netvsc: add documentation

2018-04-18 Thread Stephen Hemminger
On Wed, 18 Apr 2018 14:25:22 +0100 Ferruh Yigit wrote: > On 4/17/2018 10:53 PM, Stephen Hemminger wrote: > > Matching documentation for new netvsc device. > > > > Signed-off-by: Stephen Hemminger > > --- > > doc/guides/nics/index.rst | 1 + > > doc/guides/nics/netvsc.rst

Re: [dpdk-dev] [PATCH v3 1/4] bus/vmbus: add hyper-v virtual bus support

2018-04-18 Thread Stephen Hemminger
On Wed, 18 Apr 2018 14:16:56 +0100 Ferruh Yigit wrote: > On 4/17/2018 10:53 PM, Stephen Hemminger wrote: > > From: Stephen Hemminger > > > > This patch adds support for an additional bus type Virtual Machine BUS > > (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 > > and Azure.

Re: [dpdk-dev] [PATCH] app/testpmd: handle unused variables

2018-04-18 Thread Thomas Monjalon
18/04/2018 17:31, Wisam Jaddo: > Unused variables will appear when setting RTE_LIBRTE_I40E_PMD > to be disabled. > > The fix was to move these variables to the I40E_PMD scope, > since only I40E_PMD is using it. > > Fixes: a9dbe1802226 ("fix ethdev port id validation") > > Signed-off-by: Wisam Ja

[dpdk-dev] [PATCH] app/testpmd: handle unused variables

2018-04-18 Thread Wisam Jaddo
Unused variables will appear when setting RTE_LIBRTE_I40E_PMD to be disabled. The fix was to move these variables to the I40E_PMD scope, since only I40E_PMD is using it. Fixes: a9dbe1802226 ("fix ethdev port id validation") Cc: tho...@monjalon.net Signed-off-by: Wisam Jaddo --- app/test-pmd/cm

[dpdk-dev] [PATCH 2/2] drivers: mark logtype variables as read mostly

2018-04-18 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- drivers/bus/dpaa/dpaa_bus.c | 8 drivers/bus/fslmc/fslmc_bus.c | 2 +- drivers/bus/vdev/vdev.c | 2 +- drivers/common/octeontx/octeontx_mbox.c | 2 +- drivers/crypto/dpaa2_sec/dpaa2_sec_dpsec

[dpdk-dev] [PATCH 1/2] eal: add macro to mark variable mostly read only

2018-04-18 Thread Pavan Nikhilesh
Add macro to mark a variable to be mostly read only and place it in a separate section. Signed-off-by: Pavan Nikhilesh --- Group together mostly read only data to avoid cacheline bouncing, also useful for auditing purposes. lib/librte_eal/common/include/rte_common.h | 5 + 1 file changed

Re: [dpdk-dev] [RFC] checkpatch: don't complain about SPDX tag format

2018-04-18 Thread Wiles, Keith
> On Apr 18, 2018, at 8:50 AM, Thomas Monjalon wrote: > > 18/04/2018 10:56, Bruce Richardson: >> On Wed, Apr 18, 2018 at 12:19:07AM +0200, Thomas Monjalon wrote: >>> 18/04/2018 00:11, Scott Branden: On 18-04-17 03:06 PM, Thomas Monjalon wrote: > 17/04/2018 23:49, Stephen Hemminger: >>>

Re: [dpdk-dev] [PATCH v5 0/4] introduce new tunnel types

2018-04-18 Thread Iremonger, Bernard
Hi Li > > > -Original Message- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xueming Li > > > Sent: Tuesday, April 17, 2018 4:04 PM > > > To: Lu, Wenzhuo ; Wu, Jingjing > > > ; Thomas Monjalon ; > > > Adrien Mazarguil > > > Cc: Xueming Li ; Nelio Laranjeiro > > > ; Shahaf S

Re: [dpdk-dev] [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow

2018-04-18 Thread Nélio Laranjeiro
On Wed, Apr 18, 2018 at 02:43:30PM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Nélio Laranjeiro > > Sent: Wednesday, April 18, 2018 2:49 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v4 03/11] net/mlx5: support L3 VX

Re: [dpdk-dev] [PATCH v4 04/11] net/mlx5: support Rx tunnel type identification

2018-04-18 Thread Nélio Laranjeiro
On Wed, Apr 18, 2018 at 02:33:01PM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Nélio Laranjeiro > > Sent: Wednesday, April 18, 2018 2:51 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v4 04/11] net/mlx5: support Rx tu

Re: [dpdk-dev] [PATCH 0/2] add MRVL MVPP2 PMD to meson

2018-04-18 Thread Bruce Richardson
On Fri, Apr 13, 2018 at 05:12:19PM +0100, Bruce Richardson wrote: > On Wed, Apr 11, 2018 at 01:45:05PM +0200, Tomasz Duszynski wrote: > > This patchseries adds MRVL MVPP2 PMD to meson build system. > > > > Tomasz Duszynski (2): > > net/mvpp2: rename the version file to standard > > net/mvpp2:

Re: [dpdk-dev] [PATCH v4 05/16] ethdev: alter behavior of flow API actions

2018-04-18 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 03:26:00PM +0300, Andrew Rybchenko wrote: > On 04/16/2018 07:22 PM, Adrien Mazarguil wrote: > > This patch makes the following changes to flow rule actions: > > > > - List order now matters, they are redefined as performed first to last > >instead of "all simultaneously

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 02:26:30PM +, Xueming(Steven) Li wrote: > +Olivier > > > -Original Message- > > From: Adrien Mazarguil > > Sent: Wednesday, April 18, 2018 10:17 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; Nelio Laranjeiro > > ; Wenzhuo Lu > > ; Jingjing Wu ; Thomas

Re: [dpdk-dev] [PATCH v2 0/3] net/mlx5: implement set_mc_addr devop

2018-04-18 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 03:50:03PM +0200, Nelio Laranjeiro wrote: > Support eth_dev_ops.set_mc_addr_list(). > > Changes in v2: > > Simplify the code and are even more verifications. > > Nelio Laranjeiro (3): > net/mlx5: more checks on MAC addresses > net/mlx5: split MAC address add/remove co

Re: [dpdk-dev] [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow

2018-04-18 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Wednesday, April 18, 2018 2:49 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow > > On Tue, Apr 17, 2018 at 11:14:28PM +0800, Xueming Li wrote: > > This p

Re: [dpdk-dev] [PATCH v4 04/11] net/mlx5: support Rx tunnel type identification

2018-04-18 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Wednesday, April 18, 2018 2:51 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v4 04/11] net/mlx5: support Rx tunnel type identification > > On Tue, Apr 17, 2018 at 11:14:29PM +0800, Xueming Li w

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 02:10:45PM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Adrien Mazarguil > > Sent: Wednesday, April 18, 2018 9:26 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; Nelio Laranjeiro > > ; Wenzhuo Lu > > ; Jingjing Wu ; Thomas > > Mon

Re: [dpdk-dev] [PATCH v6 1/2] ethdev: introduce generic IP/UDP tunnel checksum and TSO

2018-04-18 Thread Thomas Monjalon
18/04/2018 15:58, Xueming Li: > This patch introduce new TX offload flags for device that supports > IP or UDP tunneled packet L3/L4 checksum and TSO offload. > It will be used for non-standard tunnels. > > The support from the device is for inner and outer checksums on > IPV4/TCP/UDP and TSO for

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Xueming(Steven) Li
+Olivier > -Original Message- > From: Adrien Mazarguil > Sent: Wednesday, April 18, 2018 10:17 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; Nelio Laranjeiro > ; Wenzhuo Lu > ; Jingjing Wu ; Thomas Monjalon > ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: on

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Adrien Mazarguil
On Wed, Apr 18, 2018 at 01:54:20PM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Adrien Mazarguil > > Sent: Wednesday, April 18, 2018 9:26 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; Nelio Laranjeiro > > ; Wenzhuo Lu > > ; Jingjing Wu ; Thomas > > Mon

Re: [dpdk-dev] [PATCH v2] app/bbdev: remove improper WARNING printouts

2018-04-18 Thread Mokhtar, Amr
> -Original Message- > From: Chalupnik, KamilX > Sent: Wednesday 18 April 2018 10:26 > To: dev@dpdk.org > Cc: Mokhtar, Amr ; Chalupnik, KamilX > > Subject: [PATCH v2] app/bbdev: remove improper WARNING printouts > > Improper WARNING printouts in BBDev Test Application removed > > Signed

Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config supported RSS hash types

2018-04-18 Thread Xueming(Steven) Li
> -Original Message- > From: Adrien Mazarguil > Sent: Wednesday, April 18, 2018 9:26 PM > To: Xueming(Steven) Li > Cc: Shahaf Shuler ; Nelio Laranjeiro > ; Wenzhuo Lu > ; Jingjing Wu ; Thomas Monjalon > ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/2] app/testpmd: only config

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-18 Thread Flavio Leitner
On Sun, Apr 15, 2018 at 01:48:36AM +, Stephen Hemminger wrote: > My vote is to work with udev and not try to replace it. > > Driverctl works well. Just not for bifurcated driver I second that. We also have other system configs to care about like kernel parameters and hugepage configuration w

Re: [dpdk-dev] [PATCH] devtools: improve kernel script execution check

2018-04-18 Thread Thomas Monjalon
18/04/2018 16:06, Thomas Monjalon: > 18/04/2018 15:30, Ferruh Yigit: > > On 4/18/2018 1:21 PM, Juhamatti Kuusisaari wrote: > > > Handle properly a case where DPDK_PATCH_PATH is set > > > to point to a directory. > > > > > > Signed-off-by: Juhamatti Kuusisaari > > > > Acked-by: Ferruh Yigit > >

Re: [dpdk-dev] [PATCH] devtools: improve kernel script execution check

2018-04-18 Thread Thomas Monjalon
18/04/2018 15:30, Ferruh Yigit: > On 4/18/2018 1:21 PM, Juhamatti Kuusisaari wrote: > > Handle properly a case where DPDK_PATCH_PATH is set > > to point to a directory. > > > > Signed-off-by: Juhamatti Kuusisaari > > Acked-by: Ferruh Yigit Funny bug, I didn't thought that "test -x" is positive

  1   2   >