Hi,
When I used the mlx4 pmd, I meet a problem about mlx4 VF bond
switching which bond mod is backup-mode . The detail test is descripted below.
1.Test environmemt infomation:
a. Linux distribution: CentOS
b. dpdk version: dpdk-16.04
c. Ethernet device : mlx4 VF
d. pmd info: mlx4
>Hi Ravi,
>
>> -Original Message-
>> From: Kumar, Ravi1 [mailto:ravi1.ku...@amd.com]
>> Sent: Monday, April 2, 2018 6:50 AM
>> To: De Lara Guarch, Pablo ;
>> dev@dpdk.org
>> Cc: hemant.agra...@nxp.com
>> Subject: RE: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD
>>
>> >
>> >
>> >>
Signed-off-by: Yangchao Zhou
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
index ad6ce72..f2fcc4a 100644
--- a/drivers/net/nfp/nfpcore
Thanks for the reminder. Will fix it.
BRs,
Xiao
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Tuesday, April 17, 2018 2:07 AM
> To: Wang, Xiao W
> Cc: Yigit, Ferruh ; Burakov, Anatoly
> ; dev@dpdk.org; maxime.coque...@redhat.com;
> Wang, Zhihong ; Bie,
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, April 17, 2018 6:45 AM
> To: Xueming(Steven) Li
> Cc: dev@dpdk.org; Wenzhuo Lu ; Jingjing Wu
> ; Yongseok Koh
> ; Olivier MATZ ; Shahaf Shuler
> ;
> Ferruh Yigit
> Subject: Re: [dpdk-dev] [PATCH v4 3/4] app/testpmd: add mo
On Mon, Apr 16, 2018 at 11:40:17AM +0200, David Marchand wrote:
> Modified enic_del_mac_address() to get a return value from the vnic layer.
> Reused the .mac_addr_add and .mac_addr_del callbacks code to implement
> primary mac address handler.
>
> Signed-off-by: David Marchand
> ---
Thanks.
Th
Hi, Guys:
I have found the DPDK Xen Guideline and there have example and steps
About how DPDK supporting Linux Guest OS VM on Xen Hypervisor.
But I cannot find similar document about FreeBSD Guest OS VM on Xen Hypervisor.
For example,
1): there has xen_dom0.ko under librte_eal/linuxapp, but n
On Mon, Apr 16, 2018 at 05:10:24PM +0100, Ferruh Yigit wrote:
> On 4/14/2018 11:55 AM, Tiwei Bie wrote:
> > On Fri, Apr 13, 2018 at 10:53:55PM +0100, Ferruh Yigit wrote:
> >> On 4/10/2018 4:41 PM, Tiwei Bie wrote:
> >>> On Tue, Mar 13, 2018 at 06:05:34PM +, Ferruh Yigit wrote:
> Update lin
> -Original Message-
> From: Adrien Mazarguil
> Sent: Tuesday, April 17, 2018 12:03 AM
> To: Xueming(Steven) Li
> Cc: Nélio Laranjeiro ; Shahaf Shuler
> ; dev@dpdk.org;
> Olivier Matz
> Subject: Re: [PATCH v3 04/14] net/mlx5: support Rx tunnel type identification
>
> On Mon, Apr 16,
rx_q fifo can only be released by kernel thread. There may be
mbuf leaks in rx_q because kernel threads are randomly stopped.
When the kni is released and netdev is unregisterd, convert the
physical address mbufs in rx_q to the virtual address in free_q.
By the way, alloc_q can be processed toget
Hi Helin,
> -Original Message-
> From: Zhang, Helin
> Sent: Thursday, March 29, 2018 13:11
> To: Zhang, Qi Z ; Xu, Rosen ;
> Xing, Beilei
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] drivers/net/i40e/i40e_ethdev_vf.c: fix
> missing promiscuous disable at device stop
>
>
>
>
v3 updates:
===
- Move modification from device close to device disable
- i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous,
so unicast/multicast promiscuous disable should set before reset.
v2 updates:
===
- Add more comments
In scenario of Kernel Drive
> On Apr 11, 2018, at 5:30 AM, Anatoly Burakov
> wrote:
>
> Reduce dependency on internal details of EAL memory subsystem, and
> simplify code.
>
> Signed-off-by: Anatoly Burakov
> Tested-by: Santosh Shukla
> Tested-by: Hemant Agrawal
> Tested-by: Gowrishankar Muthukrishnan
> ---
> drivers
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jianfeng Tan
> Sent: Friday, April 6, 2018 1:45 AM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; Tan, Jianfeng
> Subject: [dpdk-dev] [PATCH v2 0/5] allow procinfo and pdump on eth vdev
>
> v2:
> - Add spinlock
> On Apr 11, 2018, at 5:30 AM, Anatoly Burakov
> wrote:
>
> Nothing uses this code yet. The bulk of it is copied from old
> memory allocation code (linuxapp eal_memory.c). We provide an
> EAL-internal API to allocate either one page or multiple pages,
> guaranteeing that we'll get contiguous VA
Since we are storing the mem_zone address for each ring created,
we are freeing the same address multiple times.
For example the memory zone created for Rx is being freed during
Rx ring cleanup, AGG ring cleanup and CQ cleanup.
Avoid this by storing the memory zone address in RXQ instead and
free i
From: Somnath Kotur
Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device")
Cc: ajit.khapa...@broadcom.com
Signed-off-by: Somnath Kotur
---
drivers/net/bnxt/bnxt_ethdev.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/
bnxt_hwrm_clear_l2_filter needs to be called only if the filter type
is L2 and not otherwise.
Also check for the return value of bnxt_hwrm_clear_l2_filter().
Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
Cc: sta...@dpdk.org
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_filt
Currently we have a single counter for mbuf alloc failure.
Make it per RxQ instead.
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt.h| 1 -
drivers/net/bnxt/bnxt_ethdev.c | 1 -
drivers/net/bnxt/bnxt_rxq.c| 1 +
drivers/net/bnxt/bnxt_rxq.h| 1 +
drivers/net/bnxt/bnxt_r
Use UINT64_MAX to initialize l2, ntuple, em filter_id fields
instead of hardcoded -1;
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_filter.c | 8
drivers/net/bnxt/bnxt_hwrm.c | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_fi
The hwrm_queue_qportcfg command has been extended to determine
the COS queue that a Tx ring needs to use. This patch adds code
to determine the information from the FW and use it while
creating the Tx rings.
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt.h| 2 +
drivers
Memory allocated to hold VF filter info is not being freed currently.
This can cause potential memory leak.
Fixes: 7a5b0874440e ("net/bnxt: support to add a VF MAC address")
Cc: sta...@dpdk.org
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_filter.c | 8
1 file changed, 8 insert
Set the RX_PROD_PKT_BD_FLAGS_EOP_PAD in Rx buffer descriptors.
Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code")
Cc: sta...@dpdk.org
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_rxr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_rxr.c b/
The fw_l2_filter_id for a ntuple filter is needed only for the lifetime
of the ntuple filter. Once the filter is free, reset the field.
The associated l2_filter will be freed as a part of its own cleanup.
Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
Cc: sta...@dpdk.org
Signed-off-by:
Fix Rx checksum status for tunnel frames as seen by hardware.
Current code does not handle cases for tunnel frames correctly.
Fixes: 7ec39d8c524b ("net/bnxt: update status of Rx IP/L4 CKSUM")
Cc: sta...@dpdk.org
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_rxr.h | 16
We are wrongly freeing up a filter in the driver while it is still
configured in the HW. This can cause incorrect L2 filter id to be
used for filters created subsequently.
This filter will be cleared on cleanup anyway.
Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
Cc: sta...@dpdk.org
Set the default log level to RTE_LOG_INFO from RTE_LOG_NOTICE.
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 1d4ff54b7..b7aab65ab 100644
---
We are wrongly setting the Rx path flag while creating the ntuple filter.
It needs to be set for L2 or Exact Match filters only.
Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
Cc: sta...@dpdk.org
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_filter.c | 3 ++-
1 file changed,
In bnxt_hwrm_vnic_alloc, use rte_cpu_to_le_32 while setting the flags.
Fixes: 2691827e82c0 ("net/bnxt: add HWRM VNIC alloc")
Cc: sta...@dpdk.org
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_hwrm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bn
patchset against dpdk-next-net.
Please apply.
Thanks
Ajit Khaparde (13):
net/bnxt: set default log level to informational
net/bnxt: set padding flags in Rx descriptor
net/bnxt: fix bnxt_hwrm_vnic_alloc
net/bnxt: fix incorrect ntuple flag setting
net/bnxt: fix Rx checksum flags for tunne
13/04/2018 18:16, Tan, Jianfeng:
>
> On 4/13/2018 11:55 PM, Anatoly Burakov wrote:
> > We are trying to notify sender that response from current process
> > should be ignored, but we didn't specify which request this response
> > was for. Fix by copying request name from the original message.
> >
Update meson build files for new netvsc and vmbus drivers.
Signed-off-by: Stephen Hemminger
---
config/meson.build | 7 +++
drivers/bus/meson.build| 2 +-
drivers/bus/vmbus/meson.build | 17 +
drivers/net/meson.build| 2 +-
drivers/net/netvsc/m
Matching documentation for new netvsc device.
Signed-off-by: Stephen Hemminger
---
doc/guides/nics/index.rst | 1 +
doc/guides/nics/netvsc.rst | 73 ++
doc/guides/rel_notes/release_18_05.rst | 6 +++
3 files changed, 80 insertions(+)
create mod
From: Stephen Hemminger
The driver supports Hyper-V networking directly like
virtio for KVM or vmxnet3 for VMware.
This code is based off of the FreeBSD driver. The file and variable
names are kept the same to help with understanding (with most of the
BSD style warts removed).
Signed-off-by: St
From: Stephen Hemminger
This patch adds support for an additional bus type Virtual Machine BUS
(VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016
and Azure. Most of this code was extracted from FreeBSD and some of
this is from earlier code donated by Brocade.
Only Linux is supported
This is a revised version of the Hyper-V native bus (VMbus)
and network device (netvsc) drivers. This virtual device
is used in Microsoft Hyper-V in Windows 10, Windows Server 2016
and Azure. Most of this code was extracted from FreeBSD and some of
this is from earlier code donated by Brocade.
Onl
13/04/2018 17:33, Tan, Jianfeng:
>
> On 4/13/2018 7:54 PM, Anatoly Burakov wrote:
> > Previously, we were adding synchronous requests to request list, we
> > were doing it after checking if request existed. However, we only
> > removed the request from the request list if we have succeeded in
> >
13/04/2018 17:24, Tan, Jianfeng:
>
> On 4/10/2018 11:28 PM, Anatoly Burakov wrote:
> > EAL did not stop processing further asynchronous requests on
> > encountering a request that should trigger the callback. This
> > resulted in erasing valid requests but not triggering them.
> >
> > Fix this by
09/04/2018 14:10, Xueming Li:
> Add supported RSS hash function check in device configuration to
> have better error verbosity for application developers.
In other words, you check whether the requested RSS type is supported.
I don't see any reason to not accept it.
Any other comment?
09/04/2018 14:10, Xueming Li:
> Only configure RSS hash functions supported by the device.
>
> Signed-off-by: Xueming Li
This commit message is too short.
Please explain what was the behaviour, and why you change it.
08/04/2018 14:32, Xueming Li:
> This patch introduced VXLAN-GPE support to csum forwarding engine by
> recognizing VXLAN-GPE UDP port and parsing tunnel payload according to
> next-protocol type.
>
> Signed-off-by: Xueming Li
This is not the right series for this patch.
It is already in the "new
08/04/2018 14:32, Xueming Li:
> This patch adds GRE checksum and sequence extension supports in addtion
> to key extension to csum forwarding engine.
>
> Signed-off-by: Xueming Li
This patch is also part of another series, isn't it?
("introduce new tunnel types")
08/04/2018 14:32, Xueming Li:
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -210,6 +210,8 @@ extern "C" {
> #define PKT_TX_TUNNEL_GENEVE (0x4ULL << 45)
> /**< TX packet with MPLS-in-UDP RFC 7510 header. */
> #define PKT_TX_TUNNEL_MPLSINUDP (0x5ULL << 45)
> +#define
13/04/2018 13:02, Xueming Li:
> Xueming Li (5):
> doc: remove RSS configuration change announcement
> ethdev: introduce new tunnel VXLAN-GPE
> ethdev: introduce tunnel type MPLS-in-GRE and MPLS-in-UDP
> app/testpmd: introduce new tunnel VXLAN-GPE
> app/testpmd: add more GRE extension supp
13/04/2018 13:02, Xueming Li:
> +struct vxlan_gpe_hdr {
> + uint8_t vx_flags; /**< flag (8). */
> + uint8_t reserved[2]; /**< Reserved (16). */
> + uint8_t proto; /**< next-protocol (8). */
> + uint32_t vx_vni; /**< VNI (24) + Reserved (8). */
> +} __attribute__((__packed__));
mi
16/04/2018 19:23, Ferruh Yigit:
> On 4/1/2018 8:10 AM, Shahaf Shuler wrote:
> > Thursday, March 29, 2018 4:32 PM, Ferruh Yigit:
> >> On 3/29/2018 8:56 AM, Shahaf Shuler wrote:
> >>> Thursday, March 29, 2018 10:43 AM, Thomas Monjalon:
> 29/03/2018 07:38, Shahaf Shuler:
> > Wednesday, March
From: Hyong Youb Kim
Recent NIC models support overlay offload. The overlay offload
feature enables the following on the NIC.
- Rx/Tx checksum offloads for both inner and outer packets.
- Rx inner packet type classification.
- TSO.
- Inner RSS.
TX descriptors do not require any changes, except t
16/04/2018 16:08, Fan Zhang:
> Fixes: d090c7f86a76 ("vhost/crypto: update makefile")
>
> Vhost-Crypto shall not be compiled if rte_cryptodev is disabled.
> This patch fix this by adding checking to Makefile.
>
> Signed-off-by: Fan Zhang
> ---
> lib/librte_vhost/Makefile | 11 ---
> 1 fi
13/04/2018 16:43, Konstantin Ananyev:
> Konstantin Ananyev (10):
> net: move BPF related definitions into librte_net
> bpf: add BPF loading and execution framework
> bpf: add more logic into bpf_validate()
> bpf: add JIT compilation for x86_64 ISA
> bpf: introduce basic RX/TX BPF filters
From: Scott Branden
Starting from Linux v3.16 pci_is_bridge() is in linux/pci.h,
in previous versions it is in drivers/pci/pci.h which is private header.
Fix build error when calling pci_is_bridge by not calling/supporting
pci_is_bridge with kernel versions before 3.16.
Signed-off-by: Scott Br
On Fri, Apr 13, 2018 at 02:19:28PM +0100, Ferruh Yigit wrote:
On 4/13/2018 12:37 PM, Jens Freimann wrote:
Signed-off-by: Jens Freimann
---
doc/guides/testpmd_app_ug/run_app.rst | 27 +++
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +--
2 files changed, 32
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Didier Pallard
> Sent: Wednesday, March 28, 2018 8:44 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 2/8] net/vmxnet3: return unknown IPv4
> extension len ptype
>
> Rather than parsing IP header to get proper p
Hi Adrien
I think the title should be "app/testpmd: ..." ...
From: Adrien Mazarguil, Monday, April 16, 2018 7:22 PM
> Original implementation lacks the on/off toggle.
>
> This patch shows up as a fix because it has been a popular request ever since
> the first DPDK release with the original impl
Hi Chas
From: Chas Williams, Monday, April 16, 2018 7:44 PM
> On Mon, Apr 16, 2018 at 4:06 AM, Matan Azrad
> wrote:
> > Hi Chas
> >
> > From: Chas Williams, Wednesday, February 14, 2018 12:55 AM
> >> If a link is carrier down and using autonegotiation, then the PMD may
> >> not have detected a sp
16/04/2018 18:36, Ferruh Yigit:
> Hi Xiao,
>
> Getting following build error for 32bit [1], can you please check them?
>
> [1]
> .../dpdk/drivers/net/ifc/ifcvf_vdpa.c: In function ‘ifcvf_dma_map’:
> .../dpdk/drivers/net/ifc/ifcvf_vdpa.c:24:3: error: format ‘%lx’ expects
> argument
> of type ‘lon
16/04/2018 18:57, Stephen Hemminger:
> Buried under this discussion is the fact that the Mellanox bifurcated driver
> behaves completely differently from every other driver. This makes coming to
> a common solution much harder. The bifurcated model has advantages and
> disadvantages,
> in this cas
Hi Stephen
From: Stephen Hemminger, Monday, April 16, 2018 8:19 PM
> On Mon, 16 Apr 2018 17:10:09 +
> Matan Azrad wrote:
>
> > Hi Stephen
> >
> > From: Stephen Hemminger, Monday, April 16, 2018 7:57 PM
> > > On Mon, 16 Apr 2018 16:11:12 +
> > > Matan Azrad wrote:
> > >
> > > > > If the
16/04/2018 19:09, Ferruh Yigit:
> icc flag is causing build error with gcc, build error:
> cc1: warning: unrecognized gcc debugging option: i
> cc1: warning: unrecognized gcc debugging option: g
> cc1: warning: unrecognized gcc debugging option: -
> cc1: warning: unrecognized gcc debugging option:
16/04/2018 14:13, Anatoly Burakov:
> Previously, VFIO functions were not compiled in and exported if
> VFIO compilation was disabled. Fix this by actually compiling
> all of the functions unconditionally, , and provide missing
> prototypes on Linux.
>
> Fixes: 279b581c897d ("vfio: expose functions
On 4/16/2018 5:21 PM, Ferruh Yigit wrote:
> On 4/16/2018 11:32 AM, Thomas Monjalon wrote:
>> Duplicated includes are found with devtools/check-dup-includes.sh
>>
>> Signed-off-by: Thomas Monjalon
>
> Reviewed-by: Ferruh Yigit
Applied to dpdk-next-net/master, thanks.
On 4/1/2018 8:10 AM, Shahaf Shuler wrote:
> Thursday, March 29, 2018 4:32 PM, Ferruh Yigit:
>> On 3/29/2018 8:56 AM, Shahaf Shuler wrote:
>>> Thursday, March 29, 2018 10:43 AM, Thomas Monjalon:
29/03/2018 07:38, Shahaf Shuler:
> Wednesday, March 21, 2018 9:48 PM, Ferruh Yigit:
>> DEV_R
On Mon, 16 Apr 2018 17:10:09 +
Matan Azrad wrote:
> Hi Stephen
>
> From: Stephen Hemminger, Monday, April 16, 2018 7:57 PM
> > On Mon, 16 Apr 2018 16:11:12 +
> > Matan Azrad wrote:
> >
> > > > If the device management is only managed in one place, i.e. not in
> > > > DPDK, then there
Hi Stephen
From: Stephen Hemminger, Monday, April 16, 2018 7:57 PM
> On Mon, 16 Apr 2018 16:11:12 +
> Matan Azrad wrote:
>
> > > If the device management is only managed in one place, i.e. not in
> > > DPDK, then there is no conflict to manage.
> >
> > I can't agree with this statement,
> >
icc flag is causing build error with gcc, build error:
cc1: warning: unrecognized gcc debugging option: i
cc1: warning: unrecognized gcc debugging option: g
cc1: warning: unrecognized gcc debugging option: -
cc1: warning: unrecognized gcc debugging option: d
cc1: warning: unrecognized gcc debugging
16/04/2018 15:39, Bruce Richardson:
> The new functions for Rx and Tx offloads should not be inside the
> conditional block for the vector driver, otherwise compile errors occur
> when vector driver is disabled. For example:
>
> ixgbe_ethdev.c:3636:36: error: implicit declaration of function
>
On Mon, 16 Apr 2018 16:11:12 +
Matan Azrad wrote:
> > If the device management is only managed in one place, i.e. not in DPDK,
> > then there is no conflict to manage.
>
> I can't agree with this statement,
> The essence of DPDK is to give a good alternative to managing network devices,
>
The destination string may not have a null termination if
the source string's length is equal to the sizeof(link->name).
Fix by replacing strncpy with strlcpy that guarantees NULL-termination.
Coverty issue: 272594
Fixes: 133c2c6565d6 ("examples/ip_pipeline: add link object")
Signed-off-by: Jasv
16/04/2018 15:39, Bruce Richardson:
> The new functions for Rx and Tx offloads should not be inside the
> conditional block for the vector driver, otherwise compile errors occur
> when vector driver is disabled. For example:
>
> ixgbe_ethdev.c:3636:36: error: implicit declaration of function
>
On Mon, Apr 16, 2018 at 4:06 AM, Matan Azrad wrote:
> Hi Chas
>
> From: Chas Williams, Wednesday, February 14, 2018 12:55 AM
>> If a link is carrier down and using autonegotiation, then the PMD may not
>> have detected a speed yet. In this case the best we can do is ignore the
>> link
>> speed a
On 4/16/2018 4:34 PM, Xiao Wang wrote:
> IFCVF driver
>
> The IFCVF vDPA (vhost data path acceleration) driver provides support for the
> Intel FPGA 100G VF (IFCVF). IFCVF's datapath is virtio ring compatible, it
> works as a HW vhost backend which can send/receive packets to/from virt
RTE_FLOW_ACTION_TYPE_PORT_ID brings the ability to inject matching traffic
into a different device, as identified by its DPDK port ID.
This is normally only supported when the target port ID has some kind of
relationship with the port ID the flow rule is created against, such as
being exposed by a
While RTE_FLOW_ITEM_TYPE_PORT refers to physical ports of the underlying
device using specific identifiers, these are often confused with DPDK port
IDs exposed to applications in the global name space.
Since this pattern item is seldom used, rename it RTE_FLOW_ITEM_PHY_PORT
for better clarity.
No
This patch adds the missing action counterpart to the PHY_PORT pattern
item, that is, the ability to directly inject matching traffic into a
physical port of the underlying device.
It breaks ABI compatibility for the following public functions:
- rte_flow_copy()
- rte_flow_create()
- rte_flow_que
VLAN TCI is a 16-bit field broken down as PCP (3b), DEI (1b) and VID (12b).
The default mask used by PMDs for the VLAN pattern when one isn't provided
by the application comprises the entire TCI, which is problematic because
most devices only support VID matching.
This forces applications to alwa
This new attribute enables applications to create flow rules that do not
simply match traffic whose origin is specified in the pattern (e.g. some
non-default physical port or VF), but actively affect it by applying the
flow rule at the lowest possible level in the underlying device.
It breaks ABI
Contrary to all other pattern items, these are inconsistently documented as
affecting traffic instead of simply matching its origin, without provision
for the latter.
This commit clarifies documentation and updates PMDs since the original
behavior now has to be explicitly requested using the new t
TPID handling in rte_flow VLAN and E_TAG pattern item definitions is not
consistent with the normal stacking order of pattern items, which is
confusing to applications.
Problem is that when followed by one of these layers, the EtherType field
of the preceding layer keeps its "inner" definition, an
RSS hash types (ETH_RSS_* macros defined in rte_ethdev.h) describe the
protocol header fields of a packet that must be taken into account while
computing RSS.
When facing encapsulated (e.g. tunneled) packets, there is an ambiguity as
to whether these should apply to inner or outer packets. Applica
By definition, RSS involves some kind of hash algorithm, usually Toeplitz.
Until now it could not be modified on a flow rule basis and PMDs had to
always assume RTE_ETH_HASH_FUNCTION_DEFAULT, which remains the default
behavior when unspecified (0).
This breaks ABI compatibility for the following
Since its inception, the rte_flow RSS action has been relying in part on
external struct rte_eth_rss_conf for compatibility with the legacy RSS API.
This structure lacks parameters such as the hash algorithm to use, and more
recently, a method to tell which layer RSS should be performed on [1].
Gi
This patch replaces C99-style flexible arrays in struct rte_flow_action_rss
and struct rte_flow_item_raw with standard pointers to the same data.
They proved difficult to use in the field (e.g. no possibility of static
initialization) and unsuitable for C++ applications.
Affected PMDs and example
This patch makes the following changes to flow rule actions:
- List order now matters, they are redefined as performed first to last
instead of "all simultaneously".
- Repeated actions are now supported (e.g. specifying QUEUE multiple times
now duplicates traffic among them). Previously only
Although pattern items and actions examples end with "and so on", these
lists include all existing definitions and as a result are updated almost
every time new types are added. This is cumbersome and pointless.
This patch also synchronizes Doxygen and external API documentation wording
with a sli
Upcoming changes in relation to the handling of actions list will make the
DUP action redundant as specifying several QUEUE actions will achieve the
same behavior. Besides, no PMD implements this action.
By removing an entry from enum rte_flow_action_type, this patch breaks ABI
compatibility for t
This section has become less relevant since the flow API (rte_flow) is now
a mature DPDK API with applications developed directly on top of it instead
of an afterthought.
This patch removes it for the following reasons:
- It has never been updated to track the latest changes in the legacy
filte
As summarized in a prior RFC [1], the flow API (rte_flow) was chosen as a
means to manage switch offloads supported by many devices (usually going by
names such as E-Switch or vSwitch) through user-specified flow rules.
Combined with the need to support encap/decap actions, this requires a
change
These enable more precise reporting of objects responsible for errors.
This breaks ABI compatibility for the following public functions:
- rte_flow_create()
- rte_flow_destroy()
- rte_flow_error_set()
- rte_flow_flush()
- rte_flow_isolate()
- rte_flow_query()
- rte_flow_validate()
Signed-off-by:
Original implementation lacks the on/off toggle.
This patch shows up as a fix because it has been a popular request ever
since the first DPDK release with the original implementation but was never
addressed.
Fixes: abc3d81aca1b ("app/testpmd: add item raw to flow command")
Cc: sta...@dpdk.org
Si
Fixes: b1a4b4cbc0a8 ("ethdev: introduce generic flow API")
Cc: sta...@dpdk.org
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
lib/librte_ether/rte_flow.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h
index 56c7334
The rss_conf field is defined as a pointer to struct rte_eth_rss_conf.
Even assuming it is permanently allocated and a pointer copy is safe,
pointed data may change and not reflect an applied flow rule anymore.
This patch aligns with testpmd by making a deep copy instead.
Fixes: 18da437b5f63 ("e
Users cannot override the default RSS settings when entering a RSS action,
only a list of queues can be provided.
This patch enables them to set a RSS hash key and types for a flow rule.
Fixes: 05d34c6e9d2c ("app/testpmd: add queue actions to flow command")
Cc: sta...@dpdk.org
Signed-off-by: Adr
Except for a list of queues, RSS configuration (hash key and fields) cannot
be specified from the flow command line and testpmd does not provide safe
defaults either.
In order to validate their implementation with testpmd, PMDs had to
interpret its NULL RSS configuration parameters somehow, howeve
The lack of a working completion for RSS queues was overlooked during
development; until now only "end" was displayed as a valid token.
Fixes: 05d34c6e9d2c ("app/testpmd: add queue actions to flow command")
Cc: sta...@dpdk.org
Signed-off-by: Adrien Mazarguil
Cc: Wenzhuo Lu
Cc: Jingjing Wu
---
Configuration structure is not optional with flow rule actions that expect
one; this pointer is not supposed to be NULL and PMDs should not have to
verify it.
Like pattern item spec/last/mask fields, it is currently set when at least
one configuration parameter is provided on the command line. Thi
Some values are interpreted without endian conversion and/or without
taking the proper mask into account.
Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
Cc: sta...@dpdk.org
Cc: Ajit Khaparde
Signed-off-by: Adrien Mazarguil
---
drivers/net/bnxt/bnxt_filter.c | 14 +-
1 fi
When memory cannot be allocated for a flow rule, its RSS context reference
is not dropped.
Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support")
Cc: sta...@dpdk.org
Signed-off-by: Adrien Mazarguil
Cc: Shahaf Shuler
---
drivers/net/mlx4/mlx4_flow.c | 5 -
1 file changed, 4 inse
The number of queues provided by the application is not checked against
parser's supported maximum.
Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule")
Cc: sta...@dpdk.org
Cc: Nelio Laranjeiro
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx5/mlx5_flow
When an unsupported hash type is part of a RSS configuration structure, it
is silently ignored instead of triggering an error. This may lead
applications to assume that such types are accepted, while they are in fact
not part of the resulting flow rules.
Fixes: 078b8b452e6b ("net/mlx4: add RSS flo
This series contains several fixes for rte_flow and its implementation in
PMDs and testpmd. Upcoming work on the flow API depends on it.
v5 changes:
- No change, rebased series to address conflicts.
v4 changes:
- Rebased again.
- The reliance on rte_eth_dev_rss_hash_conf_get() was removed from
On 4/16/2018 11:32 AM, Thomas Monjalon wrote:
> Duplicated includes are found with devtools/check-dup-includes.sh
>
> Signed-off-by: Thomas Monjalon
Reviewed-by: Ferruh Yigit
1 - 100 of 235 matches
Mail list logo
