[dpdk-dev] [PATCH v2] vhost: avoid populate guest memory

2018-03-27 Thread Jianfeng Tan
It's not necessary to populate guest memory from vhost side unless zerocopy is enabled or users want better performance. Update the doc for guest memory requirement clarification. Cc: maxime.coque...@redhat.com Signed-off-by: Jianfeng Tan --- doc/guides/prog_guide/vhost_lib.rst | 21 ++

[dpdk-dev] [PATCH v2] net/liquidio: move to new offload API

2018-03-27 Thread Shijith Thotton
Make use of new offloads member instead of bit fields in port Rx conf. Signed-off-by: Shijith Thotton --- v2: corrected commit log mail address. drivers/net/liquidio/lio_ethdev.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/liquidio/lio_ethdev.c b/drive

Re: [dpdk-dev] [PATCH] net/avf: fix link autoneg value

2018-03-27 Thread Zhang, Qi Z
Hi Ferruh: > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Saturday, March 10, 2018 1:57 AM > To: Wu, Jingjing ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Yigit, Ferruh ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/avf: fix link autoneg value

Re: [dpdk-dev] [PATCH] net/i40e: fix support DDP packages group 0xff

2018-03-27 Thread Zhang, Qi Z
> -Original Message- > From: Rybalchenko, Kirill > Sent: Friday, February 23, 2018 2:02 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Rybalchenko, Kirill ; > Chilikin, Andrey ; Xing, Beilei > ; Zhang, Qi Z ; Zhang, Helin > > Subject: [PATCH] net/i40e: fix support DDP packages group 0xff >

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: enforce RSS key length limitation

2018-03-27 Thread Shahaf Shuler
Monday, March 26, 2018 1:12 PM, Shahaf Shuler: > Subject: [dpdk-dev] [PATCH 1/2] net/mlx5: enforce RSS key length limitation > > RSS hash key must be 40 Bytes long. > > Cc: sta...@dpdk.org > > Signed-off-by: Shahaf Shuler > --- Series applied to next-net-mlx with ENOTSUP->EINVAL modification.

Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-27 Thread Shahaf Shuler
Monday, March 26, 2018 3:31 PM, Thomas Monjalon: > 26/03/2018 13:54, Adrien Mazarguil: > > On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: > > > On 3/25/2018 9:19 PM, Ophir Munk wrote: > > > > Previous to this commit mlx4 CRC stripping was executed by default > > > > and there was no

Re: [dpdk-dev] [PATCH v3 1/3] net/mlx5: use Netlink to add/remove MAC addresses

2018-03-27 Thread Shahaf Shuler
Thursday, March 22, 2018 12:29 PM, Nélio Laranjeiro: > On Thu, Mar 22, 2018 at 09:45:16AM +, Shahaf Shuler wrote: > > Thursday, March 22, 2018 11:05 AM, Nélio Laranjeiro: > > > > What if the DPDK process is terminated ungracefully? I think the > > > > MAC table will remain with all the MACs whi

[dpdk-dev] [PATCH 2/2] vhost: add pipe event for optimizing negotiating

2018-03-27 Thread xiangxia . m . yue
From: Tonghao Zhang When vhost—user connects qemu successfully, dpdk will call the vhost_user_add_connection to add unix socket fd to poll. And fdset_add only set the socket fd to a fdentry while poll may sleep now. In a general case, this is no problem. But if we use hot update for vhost-user, m

[dpdk-dev] [PATCH 0/2] add pipe event for optimizing negotiating

2018-03-27 Thread xiangxia . m . yue
From: Tonghao Zhang These patches depend on previous patches. 1. http://dpdk.org/dev/patchwork/patch/36440/ 2. http://dpdk.org/dev/patchwork/patch/36441/ Tonghao Zhang (2): vhost: move stdbool header file to vhost.h vhost: add pipe event for optimizing negotiating lib/librte_vhost/fd_man.c

[dpdk-dev] [PATCH 1/2] vhost: move stdbool header file to vhost.h

2018-03-27 Thread xiangxia . m . yue
From: Tonghao Zhang The vhost.h file uses bool type, but not include stdbool header file. If other c files include vhost.h directly, there will be a compile error. This patch will be used in the next patch. Signed-off-by: Tonghao Zhang --- lib/librte_vhost/socket.c | 1 - lib/librte_vhost/vho

[dpdk-dev] [PATCH] eal: add request to map reserved physical memory

2018-03-27 Thread Ajit Khaparde
From: Srinath Mannam Reserved physical memory is requested from kernel and it will be mapped to user space. This memory will be mapped to IOVA using VFIO. And this memory will be provided to SPDK to allocate NVMe CQs. Signed-off-by: Srinath Mannam Signed-off-by: Scott Branden Signed-off-by: Aj

Re: [dpdk-dev] [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates

2018-03-27 Thread Shahaf Shuler
Tuesday, March 27, 2018 10:02 AM, Rahul Lakkireddy: [...] > > > > > > Patch 13 adds compile time option to keep outer vlan tag in Q-in-Q > > > packet. > > > > We are trying to reduce the config options, is it possible to provide > > this functionality with a runtime option (devargs) ? > > > > Th

Re: [dpdk-dev] [PATCH V16 2/4] eal: add device event monitor framework

2018-03-27 Thread Tan, Jianfeng
> -Original Message- > From: Guo, Jia > Sent: Monday, March 26, 2018 7:21 PM > To: step...@networkplumber.org; Richardson, Bruce; Yigit, Ferruh; > Ananyev, Konstantin; gaetan.ri...@6wind.com; Wu, Jingjing; > tho...@monjalon.net; mo...@mellanox.com; Van Haaren, Harry; Tan, > Jianfeng > Cc:

Re: [dpdk-dev] [PATCH] net/i40evf: regression fix - reenable interrupts in handler

2018-03-27 Thread Zhang, Qi Z
Hi Jankowski: > -Original Message- > From: Jankowski, KonradX > Sent: Thursday, February 15, 2018 2:33 AM > To: Dai, Wei ; Xing, Beilei ; Zhang, > Qi Z ; Wu, Jingjing ; > dev@dpdk.org > Cc: Jankowski, KonradX > Subject: [PATCH] net/i40evf: regression fix - reenable interrupts in handler >

Re: [dpdk-dev] [PATCH] net/fm10k: convert to new Rx/Tx offloads API

2018-03-27 Thread Dai, Wei
Thank you, Zhang Qi for your feedback. > -Original Message- > From: Zhang, Qi Z > Sent: Monday, March 19, 2018 11:55 AM > To: Dai, Wei ; Wang, Xiao W > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/fm10k: convert to new Rx/Tx offloads API > > Hi Daiwei: > > > -Original Message- >

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-27 Thread Tan, Jianfeng
Hi Thomas , > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, March 28, 2018 12:34 AM > To: Burakov, Anatoly > Cc: dev@dpdk.org; Tan, Jianfeng; Ananyev, Konstantin; Van Haaren, Harry > Subject: Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous r

[dpdk-dev] [PATCH v2 2/2] net/i40e: convert to new Tx offloads API

2018-03-27 Thread Yanglong Wu
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_ethdev.c| 1 + drivers/net/i40e/i40e_ethdev_vf.c | 1 + drivers/net/i40e/i40e_rxtx.c

[dpdk-dev] [PATCH v2 1/2] net/i40e: convert to new Rx offloads API

2018-03-27 Thread Yanglong Wu
Ethdev Rx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_ethdev.c| 27 +++ drivers/net/i40e/i40e_ethdev_vf.c | 21 +++

Re: [dpdk-dev] [PATCH] net/i40e: add log when setting input set

2018-03-27 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Sunday, February 11, 2018 2:56 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [PATCH] net/i40e: add log when setting input set > > This patch adds log when setting input set since global configuration is > changed. > > Signed-off-by:

Re: [dpdk-dev] [PATCH] net/ixgbe: fix intr callback unregister by adding retry

2018-03-27 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of wangyunjian > Sent: Wednesday, March 21, 2018 8:28 PM > To: dev@dpdk.org > Cc: ca...@huawei.com; Yunjian Wang > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix intr callback unregister by adding > retry > > From: Yunji

[dpdk-dev] [PATCH 4/5] net/qede: fix device stop to remove primary MAC

2018-03-27 Thread Rasesh Mody
This fix is to remove primary MAC filter during dev stop. Without the fix device start attempt to add the primary MAC fails. Perform MAC set remove under IS_PF() check. Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net

[dpdk-dev] [PATCH 5/5] net/qede: fix to prevent overwriting packet type

2018-03-27 Thread Rasesh Mody
From: Harish Patil Fixes: 3f72dd780e10 ("net/qede: check tunnel L3 header") Cc: sta...@dpdk.org Signed-off-by: Harish Patil --- drivers/net/qede/qede_rxtx.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c inde

[dpdk-dev] [PATCH 3/5] net/qede: add devarg to disable NPAR Tx switching

2018-03-27 Thread Rasesh Mody
Added a run-time argument npar_tx_switching to enable/disable Tx switching for multi-fucntion devices (NPAR). Rename vf_txswitch option to vf_tx_switching. Sample usage to disable Tx switching for NPAR or VF is something like... -w 05:00.0,npar_tx_switching=0 -w 05:00.1,npar_tx_switching=0 -w 0

[dpdk-dev] [PATCH 2/5] net/qede: enable IPGRE offload support

2018-03-27 Thread Rasesh Mody
From: Harish Patil Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c | 49 ++-- drivers/net/qede/qede_ethdev.h |7 +++--- drivers/net/qede/qede_rxtx.c | 14 +--- drivers/net/qede/qede_rxtx.h |3 ++- 4 files changed, 54 ins

[dpdk-dev] [PATCH 1/5] net/qede: convert to new Rx/Tx offloads API

2018-03-27 Thread Rasesh Mody
From: Harish Patil Ethdev RX/TX offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This patch makes use of new offload flags as suggested and fix the default RX/TX configuration. Also ind

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-27 Thread Neil Horman
On Tue, Mar 27, 2018 at 08:48:01PM +, Richardson, Bruce wrote: > > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Tuesday, March 27, 2018 9:35 PM > > To: Richardson, Bruce > > Cc: Neil Horman ; dev@dpdk.org; Wiles, Keith > > > > Subject: Re:

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-27 Thread Neil Horman
On Tue, Mar 27, 2018 at 10:23:21PM +0200, Gaëtan Rivet wrote: > On Tue, Mar 27, 2018 at 03:04:13PM +0200, Gaëtan Rivet wrote: > > On Tue, Mar 27, 2018 at 02:40:00PM +0200, Gaëtan Rivet wrote: > > > On Tue, Mar 27, 2018 at 07:47:50AM -0400, Neil Horman wrote: > > > > On Tue, Mar 27, 2018 at 01:18:34

Re: [dpdk-dev] [PATCH] usertools: add support for AVP device

2018-03-27 Thread Thomas Monjalon
05/03/2018 10:32, Ferruh Yigit: > On 3/5/2018 9:16 AM, Xiaohua Zhang wrote: > > Signed-off-by: Xiaohua Zhang > > Acked-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] rte_kvargs:fix comments to use commas not semicolons

2018-03-27 Thread Thomas Monjalon
12/03/2018 12:16, Ferruh Yigit: > On 3/10/2018 4:24 PM, Keith Wiles wrote: > > Signed-off-by: Keith Wiles > > Acked-by: Ferruh Yigit Fixes: a8b97e3a1db0 ("devargs: use a comma instead of semicolon to separate key/values") Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-03-27 Thread Ferruh Yigit
On 3/5/2018 3:12 PM, Matan Azrad wrote: > Hi Ferruh > > From: Ferruh Yigit, Sent: Monday, March 5, 2018 5:07 PM >> On 3/5/2018 2:52 PM, Matan Azrad wrote: >>> HI >>> >>> From: Ferruh Yigit, Sent: Monday, March 5, 2018 1:24 PM On 1/18/2018 4:35 PM, Matan Azrad wrote: > rte_eth_dev_data str

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vdev: fix name comparison in find_vdev

2018-03-27 Thread Thomas Monjalon
12/03/2018 17:54, Nachiketa Prachanda: > Use strcmp to compare device names as the strncmp in original code > causes find_vdev to return -EEXIST for names that are prefix > of another. The creation of interfaces fails unpredictably based > on the order of their creation. An easy way hit this bug i

Re: [dpdk-dev] [PATCH] ip_frag: fix hash key usage

2018-03-27 Thread Thomas Monjalon
Hi, 21/02/2018 03:03, Sergey Alekseev: > --- > lib/librte_ip_frag/ip_frag_internal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Please we need an explanation and Signed-off-by. Could you send a v2? Do not hesitate to Cc Konstantin (maintainer of this lib) for reviews. Thanks >

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/procinfo: fix strncpy count issue

2018-03-27 Thread Thomas Monjalon
20/02/2018 15:16, Bruce Richardson: > On Tue, Feb 20, 2018 at 01:52:22PM +, Radu Nicolau wrote: > > Replace strncpy with snprintf to avoid overwriting the last > > NULL character. > > > > Fixes: 2deb6b5246d7 ("app/procinfo: add collectd format and host id") > > Coverity issue: 143252 > > > >

Re: [dpdk-dev] [PATCH] examples/exception_path: limit core count to 64

2018-03-27 Thread Thomas Monjalon
20/02/2018 13:05, Radu Nicolau: > Application doesn't support more that 64 lcores due to command > line limitation of using a coremask that is parsed as a 64bit > value, so changed it to reflect this limitation. > > Fixes: af75078fece3 ("first public release") > Coverity issue: 30688 > > Cc: sta.

Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.5

2018-03-27 Thread Thomas Monjalon
22/03/2018 19:07, Ferruh Yigit: > On 3/1/2018 11:20 PM, Lee Roberts wrote: > > Fix kni compilation under RHEL 7.5. > > > > Signed-off-by: Lee Roberts > > Acked-by: Ferruh Yigit > > > (Not tested on RHEL 7.5 but code looks good) > > Following patch title can be used for compatibility with old

Re: [dpdk-dev] [PATCH 00/13] build: fix library version in meson build

2018-03-27 Thread Thomas Monjalon
23/03/2018 22:50, Bruce Richardson: > On Tue, Mar 20, 2018 at 11:26:14AM +, Andrew Rybchenko wrote: > > Library version is specified in two places: Makefile and meson.build. > > It is out-of-sync in a number of cases. > > > > Andrew Rybchenko (13): > > net/bonding: fix library version in mes

[dpdk-dev] [PATCH] maintainers: call out subtree committers

2018-03-27 Thread Pablo de Lara
The MAINTAINERS file contains information of the maintainers of the different components on DPDK. However, it does not give any information on who maintains the different subtrees which accept new commits for these components. This commit adds a list of the subtree committers. Signed-off-by: Pabl

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-27 Thread Richardson, Bruce
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Tuesday, March 27, 2018 9:35 PM > To: Richardson, Bruce > Cc: Neil Horman ; dev@dpdk.org; Wiles, Keith > > Subject: Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device > iteration initialization > >

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-27 Thread Gaëtan Rivet
On Tue, Mar 27, 2018 at 09:28:07PM +0100, Bruce Richardson wrote: > On Tue, Mar 27, 2018 at 10:20:40PM +0200, Gaëtan Rivet wrote: > > On Tue, Mar 27, 2018 at 02:26:33PM -0400, Neil Horman wrote: > > > On Tue, Mar 27, 2018 at 02:40:00PM +0200, Gaëtan Rivet wrote: > > > > On Tue, Mar 27, 2018 at 07:4

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-27 Thread Bruce Richardson
On Tue, Mar 27, 2018 at 10:20:40PM +0200, Gaëtan Rivet wrote: > On Tue, Mar 27, 2018 at 02:26:33PM -0400, Neil Horman wrote: > > On Tue, Mar 27, 2018 at 02:40:00PM +0200, Gaëtan Rivet wrote: > > > On Tue, Mar 27, 2018 at 07:47:50AM -0400, Neil Horman wrote: > > > > On Tue, Mar 27, 2018 at 01:18:34A

Re: [dpdk-dev] [dpdk-stable] [PATCH 01/13] net/bonding: fix library version in meson build

2018-03-27 Thread Bruce Richardson
On Tue, Mar 27, 2018 at 06:43:48PM +0200, Thomas Monjalon wrote: > > --- a/drivers/net/bonding/meson.build > > +++ b/drivers/net/bonding/meson.build > > @@ -2,6 +2,7 @@ > > # Copyright(c) 2017 Intel Corporation > > > > name = 'bond' #, james bond :-) > > Ah ah ah, I had missed this important c

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-27 Thread Gaëtan Rivet
On Tue, Mar 27, 2018 at 03:04:13PM +0200, Gaëtan Rivet wrote: > On Tue, Mar 27, 2018 at 02:40:00PM +0200, Gaëtan Rivet wrote: > > On Tue, Mar 27, 2018 at 07:47:50AM -0400, Neil Horman wrote: > > > On Tue, Mar 27, 2018 at 01:18:34AM +0200, Gaetan Rivet wrote: > > > > Parse a device description. > >

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-27 Thread Gaëtan Rivet
On Tue, Mar 27, 2018 at 02:26:33PM -0400, Neil Horman wrote: > On Tue, Mar 27, 2018 at 02:40:00PM +0200, Gaëtan Rivet wrote: > > On Tue, Mar 27, 2018 at 07:47:50AM -0400, Neil Horman wrote: > > > On Tue, Mar 27, 2018 at 01:18:34AM +0200, Gaetan Rivet wrote: > > > > Parse a device description. > > >

Re: [dpdk-dev] [PATCH 0/3] net/sfc: add device parameter to choose FW variant

2018-03-27 Thread Ferruh Yigit
On 3/26/2018 1:50 PM, Andrew Rybchenko wrote: > Patch 'net/sfc: add device parameter to choose FW variant' has > checkpatches.sh warning since positive errno is used inside the driver. > > Gautam Dawar (1): > net/sfc/base: add support to choose firmware variant > > Roman Zhukov (2): > net/sfc

Re: [dpdk-dev] [PATCH v2] net/bnxt: fix flow director with same cmd different queue

2018-03-27 Thread Ferruh Yigit
On 3/26/2018 4:22 AM, Somnath Kotur wrote: > When user reissues same flow director cmd with a different queue > update the existing filter to redirect flow to the new desired > queue as destination just like the other filters like 5 tuple and > generic flow. > > Fixes: 2d64da097aa0 ("net/bnxt: sup

Re: [dpdk-dev] [PATCH v2] net/mrvl: rename PMD driver as mvpp2

2018-03-27 Thread Ferruh Yigit
On 3/26/2018 3:38 PM, Tomasz Duszynski wrote: > From: Natalie Samsonov > > The name "mrvl" for Marvell PMD driver for PPv2 Marvell PPv2 > (Packet Processor v2) 1/10 Gbps adapter is too generic and causes > problem for adding new PMD drivers for other Marvell devices. > Changed to "mvpp2" for spec

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix type of opaque pointer in perf profile handler

2018-03-27 Thread Ferruh Yigit
On 3/24/2018 6:42 AM, Andrew Rybchenko wrote: > From: Roman Zhukov > > The 'opaque' pointer in handler function is the last argument > of sfc_kvargs_process() function and it is pointer to the adapter > 'evq_flags' that has a uint32_t type. So 'value' must be pointer > to uint32_t. > > Fixes: c2

Re: [dpdk-dev] [PATCH] net/mrvl: fix build error with gcc

2018-03-27 Thread Ferruh Yigit
On 3/23/2018 7:52 AM, Tomasz Duszynski wrote: > On Thu, Mar 22, 2018 at 06:18:47PM +, Ferruh Yigit wrote: >> gcc version: >> aarch64-linux-gnu-gcc (Linaro GCC 7.2-2017.11) 7.2.1 20171011 >> >> build error: >> CC mrvl_qos.o >> .../drivers/net/mrvl/mrvl_qos.c: In function ‘mrvl_configure_rxqs’:

Re: [dpdk-dev] [PATCH v5] ethdev: return named opaque type instead of void pointer

2018-03-27 Thread Ferruh Yigit
On 3/21/2018 1:04 PM, Neil Horman wrote: > On Tue, Mar 20, 2018 at 04:34:04PM +, Ferruh Yigit wrote: >> "struct rte_eth_rxtx_callback" is defined as internal data structure and >> used as named opaque type. >> >> So the functions that are adding callbacks can return objects in this >> type inst

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: fix queue start

2018-03-27 Thread Ferruh Yigit
On 3/24/2018 12:06 PM, Ananyev, Konstantin wrote: > > >> >> Device must be started before start any queue. >> >> Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") >> Cc: sta...@dpdk.org >> >> Signed-off-by: Qi Zhang > Acked-by: Konstantin Ananyev Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/avp: conforming to new ethdev offload API

2018-03-27 Thread Ferruh Yigit
On 3/19/2018 1:48 PM, Allain Legacy wrote: > This change updates the AVP driver to conform with the new ethdev > offload API. As per these commits: > > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API")' > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")' > >

Re: [dpdk-dev] [PATCH v2 0/4] ethdev: add per-PMD tuning of RxTx parmeters

2018-03-27 Thread Ferruh Yigit
On 3/21/2018 2:27 PM, Remy Horton wrote: > The optimal values of several transmission & reception related parameters, > such as burst sizes, descriptor ring sizes, and number of queues, varies > between different network interface devices. This patchset allows individual > PMDs to specify their pre

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix mbuf data alignment calculation

2018-03-27 Thread Ferruh Yigit
On 3/19/2018 7:50 AM, Andrew Rybchenko wrote: > Unlike ffs() rte_bsf32() counts bit position from 0. > > Fixes: 0c7a0c35f24c ("net/sfc: calculate Rx buffer size which may be used") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] ethdev: remove unused struct forward declaration

2018-03-27 Thread Ferruh Yigit
On 3/16/2018 2:29 PM, Ferruh Yigit wrote: > On 3/16/2018 2:09 PM, Shreyansh Jain wrote: >> On Fri, Mar 16, 2018 at 4:44 PM, Ferruh Yigit wrote: >>> Signed-off-by: Ferruh Yigit >>> --- >>> lib/librte_ether/rte_ethdev.h | 2 -- >>> 1 file changed, 2 deletions(-) >>> >> >> With movement to rte_ethd

Re: [dpdk-dev] [PATCH] ethdev: support dynamic logging

2018-03-27 Thread Ferruh Yigit
On 3/13/2018 12:38 PM, Shreyansh Jain wrote: >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Tuesday, March 13, 2018 4:37 PM >> To: Thomas Monjalon >> Cc: dev@dpdk.org; Ferruh Yigit >> Subject: [dpdk-dev] [PATCH] ethdev: support dynamic

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-27 Thread Neil Horman
On Tue, Mar 27, 2018 at 02:40:00PM +0200, Gaëtan Rivet wrote: > On Tue, Mar 27, 2018 at 07:47:50AM -0400, Neil Horman wrote: > > On Tue, Mar 27, 2018 at 01:18:34AM +0200, Gaetan Rivet wrote: > > > Parse a device description. > > > Split this description in their relevant part for each layers. > > >

Re: [dpdk-dev] [PATCH] net/nfp: support new HW offloads API

2018-03-27 Thread Ferruh Yigit
On 3/15/2018 2:30 PM, Alejandro Lucero wrote: > In next 18.05 the old hw offload API will be removed. This patch adds > support for just the new hw offload API. > > Signed-off-by: Alejandro Lucero <...> > - if (rxmode->enable_scatter) { > + if (!(rxmode->offloads & DEV_RX_OFFLOAD_CRC_ST

Re: [dpdk-dev] [PATCH v3 01/20] kvargs: remove rte log dependency

2018-03-27 Thread Neil Horman
On Tue, Mar 27, 2018 at 01:18:25AM +0200, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > lib/librte_kvargs/rte_kvargs.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/lib/librte_kvargs/rte_kvargs.c b/lib/librte_kvargs/rte_kvargs.c > index 9662375e8

[dpdk-dev] [PATCH] net/mlx4: fix a typo in mlx4 header file.

2018-03-27 Thread Rami Rosen
This patch fixes a trivial typo in mlx4 header file. Signed-off-by: Rami Rosen --- drivers/net/mlx4/mlx4_rxtx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_rxtx.h b/drivers/net/mlx4/mlx4_rxtx.h index c12bd39a9..dd46ac006 100644 --- a/drivers/net/mlx4

[dpdk-dev] [PATCH] ethdev: replace bus specific struct with generic dev

2018-03-27 Thread Ferruh Yigit
Public struct rte_eth_dev_info has a "struct rte_pci_device" field in it although it is common for all ethdev in all buses. Replacing pci specific struct with generic device struct and updating places that are using pci device in a way to get this information from generic device. Signed-off-by: F

Re: [dpdk-dev] [PATCH] net/dpaa: prefer defines for link speed values

2018-03-27 Thread Ferruh Yigit
On 3/12/2018 5:28 AM, Shreyansh Jain wrote: >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Friday, March 9, 2018 11:29 PM >> To: Hemant Agrawal ; Shreyansh Jain >> >> Cc: dev@dpdk.org; Ferruh Yigit >> Subject: [PATCH] net/dpaa: prefer defines for link

Re: [dpdk-dev] [PATCH 00/13] cxgbe: add CXGBE VF PMD and updates

2018-03-27 Thread Ferruh Yigit
On 3/27/2018 8:01 AM, Rahul Lakkireddy wrote: > On Tuesday, March 03/27/18, 2018 at 02:21:56 +0530, Ferruh Yigit wrote: >> On 3/10/2018 10:48 PM, Rahul Lakkireddy wrote: >>> Patches 1 - 9 add support for cxgbe VF driver. Patches 10 - 12 fix >>> bugs and convert license in cxgbe files to SPDX Licen

Re: [dpdk-dev] [PATCH V2] igb_uio: fix uevent montior issue

2018-03-27 Thread Ferruh Yigit
On 3/27/2018 8:46 AM, Guo, Jia wrote: > > > On 3/27/2018 2:28 AM, Ferruh Yigit wrote: >> On 2/27/2018 7:20 AM, Jeff Guo wrote: >>> udev could not detect remove and add event of device when hotplug in >>> and out devices, that related with the fix about using pointer of >>> rte_uio_pci_dev as dev_

Re: [dpdk-dev] [PATCH v2] net/mlx5: setup RSS regardless of queue count

2018-03-27 Thread Shahaf Shuler
Monday, March 26, 2018 9:09 PM, Legacy, Allain > > -Original Message- > > From: Yongseok Koh [mailto:ys...@mellanox.com] > > Sent: Thursday, March 22, 2018 7:38 PM > <..> > > > > > > Signed-off-by: Allain Legacy > > > Signed-off-by: Nelio Laranjeiro > > > --- > > > > Dahir, Allain > > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH 01/13] net/bonding: fix library version in meson build

2018-03-27 Thread Thomas Monjalon
> --- a/drivers/net/bonding/meson.build > +++ b/drivers/net/bonding/meson.build > @@ -2,6 +2,7 @@ > # Copyright(c) 2017 Intel Corporation > > name = 'bond' #, james bond :-) Ah ah ah, I had missed this important comment! Unfortunately I think the real name is "bonding". Does it mean the full

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-27 Thread Thomas Monjalon
27/03/2018 15:59, Anatoly Burakov: > Under the hood, we create a separate thread to deal with replies to > asynchronous requests, that will just wait to be notified by the > main thread, or woken up on a timer. I really don't like that a library is creating a thread. We don't even know where the t

Re: [dpdk-dev] [PATCH v2] net/i40e: fix link_state update for i40e_ethdev_vf drv

2018-03-27 Thread Zhang, Helin
> -Original Message- > From: Tushar Mulkar [mailto:tmul...@sandvine.com] > Sent: Wednesday, February 14, 2018 8:00 PM > To: Zhang, Helin; dev@dpdk.org > Cc: Xing, Beilei; Zhang, Qi Z > Subject: [PATCH v2] net/i40e: fix link_state update for i40e_ethdev_vf drv > > The check for bool was a

Re: [dpdk-dev] [PATCH v6 1/2] eal: rename IPC sync request to pending request

2018-03-27 Thread Thomas Monjalon
27/03/2018 15:59, Anatoly Burakov: > Signed-off-by: Anatoly Burakov > Suggested-by: Jianfeng Tan > Acked-by: Jianfeng Tan You probably have a good explanation for this change. Please explain in the commit message. Generally speaking, every commits should have an explanation, it is a basic qual

Re: [dpdk-dev] [PATCH v6] eal: provide API for querying valid socket id's

2018-03-27 Thread Thomas Monjalon
22/03/2018 13:36, Anatoly Burakov: > --- a/lib/librte_eal/common/include/rte_eal.h > +++ b/lib/librte_eal/common/include/rte_eal.h > @@ -57,6 +57,9 @@ enum rte_proc_type_t { > struct rte_config { > uint32_t master_lcore; /**< Id of the master lcore */ > uint32_t lcore_count;

Re: [dpdk-dev] [PATCH v3 2/2] octeontx: move mbox to common folder

2018-03-27 Thread Thomas Monjalon
Hi, 26/03/2018 09:53, Pavan Nikhilesh: > Move commonly used functions across mempool, event and net devices to a > common folder in drivers. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/common/Makefile| 4 ++ > drivers/common/meson.build

[dpdk-dev] [PATCH v2 0/3] implement compression API

2018-03-27 Thread Fiona Trahe
With the vast amounts of data being transported around networks and stored in storage systems, reducing data size is becoming ever more important. There are both software libraries and hardware devices available that provide compression, but no common API. Such an API is proposed in this commit, w

Re: [dpdk-dev] [PATCH v3 1/2] drivers: add common folder

2018-03-27 Thread Thomas Monjalon
26/03/2018 09:53, Pavan Nikhilesh: > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -3,18 +3,19 @@ > > include $(RTE_SDK)/mk/rte.vars.mk > > +DIRS-y += common > DIRS-y += bus > DIRS-y += mempool > -DEPDIRS-mempool := bus > +DEPDIRS-mempool := bus common > DIRS-y += net > -DEPDIRS-net :=

[dpdk-dev] [PATCH v2 3/3] doc: update doxy and release note for compressdev

2018-03-27 Thread Fiona Trahe
Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf | 1 + doc/guides/rel_notes/release_18_05.rst | 6 ++ 3 files changed, 8 insertions(+) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-i

[dpdk-dev] [PATCH v2 2/3] compressdev: implement API

2018-03-27 Thread Fiona Trahe
Introduce: - compressdev device management APIs - ompression service APIs - APIs for PMDs to plug in and offer the compression service - build systems for all above Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- config/c

[dpdk-dev] [PATCH v2 1/3] compressdev: add structs and enum for compression service

2018-03-27 Thread Fiona Trahe
Introduce enums and structs to support the transforms and operations needed for a compression service. Signed-off-by: Fiona Trahe Signed-off-by: Pablo de Lara Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- MAINTAINERS | 7 + lib/librte_compressdev/rte_comp

Re: [dpdk-dev] [PATCH] net/e1000: fix flow RSS queue index error

2018-03-27 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Monday, March 26, 2018 9:37 AM > To: Zhao1, Wei; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix flow RSS queue index error > > Hi, > > > -Original Message- > > From: Zh

Re: [dpdk-dev] [PATCH] eal/vfio: export internal vfio functions

2018-03-27 Thread Thomas Monjalon
14/03/2018 09:00, Hemant Agrawal: > This patch moves some of the internal vfio functions from > eal_vfio.h to rte_vfio.h for common uses with "rte_" prefix. > > This patch also change the FSLMC bus usages from the internal > VFIO functions to external ones with "rte_" prefix > > Signed-off-by: He

[dpdk-dev] [PATCH v2] vhost: add virtio configuration space messages

2018-03-27 Thread Tomasz Kulasek
This patch adds new vhost user messages GET_CONFIG and SET_CONFIG used for get/set virtio device's configuration space. Signed-off-by: Changpeng Liu Signed-off-by: Tomasz Kulasek --- Changes in v2: - code cleanup lib/librte_vhost/rte_vhost.h | 4 lib/librte_vhost/vhost_user.c | 22

[dpdk-dev] [PATCH] vhost: add virtio configuration space messages

2018-03-27 Thread Tomasz Kulasek
This patch adds new vhost user messages GET_CONFIG and SET_CONFIG used for get/set virtio device's configuration space. Signed-off-by: Changpeng Liu Signed-off-by: Tomasz Kulasek --- lib/librte_vhost/rte_vhost.h | 4 lib/librte_vhost/vhost_user.c | 23 +++ lib/librte_

[dpdk-dev] [PATCH v2] event/opdl: fix atomic queue race condition issue

2018-03-27 Thread Liang Ma
If application link one atomic queue to multiple ports, and each worker core update flow_id, there will have a chance to hit race condition issue and lead to double processing same event. This fix solve the problem and eliminate the race condition issue. Fixes: 4236ce9bf5bf ("event/opdl: add OPDL

Re: [dpdk-dev] [PATCH v3] eal: replace rte_panic instances to return an error value

2018-03-27 Thread Arnon Warshavsky
I now have a set of several patches which pass the abi-validation , 1 patch of checkpatches.sh to prevent future panic instances and the set of abi-breaking changes which are included the init sequence. 1. I assume it is best to bundle all to a single patchset. Please correct me otherwise 2. Tryi

Re: [dpdk-dev] [PATCH] net/vhost: fix segfault when creating vdev dynamically

2018-03-27 Thread Tan, Jianfeng
On 3/27/2018 7:28 PM, Maxime Coquelin wrote: On 03/27/2018 11:42 AM, Tan, Jianfeng wrote: On 3/27/2018 5:24 PM, Chen, Junjie J wrote: On 3/28/2018 12:05 AM, Junjie Chen wrote: when creating vdev dynamically, vhost pmd driver start directly without checking TX/RX queues ready or not, and

[dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-27 Thread Anatoly Burakov
This API is similar to the blocking API that is already present, but reply will be received in a separate callback by the caller (callback specified at the time of request, rather than registering for it in advance). Under the hood, we create a separate thread to deal with replies to asynchronous

[dpdk-dev] [PATCH v6 1/2] eal: rename IPC sync request to pending request

2018-03-27 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov Suggested-by: Jianfeng Tan Acked-by: Jianfeng Tan --- lib/librte_eal/common/eal_common_proc.c | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/e

Re: [dpdk-dev] [PATCH v3] net/i40e: fix flow RSS configuration error

2018-03-27 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Monday, March 26, 2018 11:31 AM > To: Zhao1, Wei; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix flow RSS configuration error > > > -Original Message- > > From: Zhao1,

Re: [dpdk-dev] [PATCH] net/i40evf: add multicast MAC address filtering

2018-03-27 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Tuesday, March 27, 2018 9:52 PM > To: Olivier Matz; dev@dpdk.org; Xing, Beilei; Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH] net/i40evf: add multicast MAC address > filtering > > > > >

Re: [dpdk-dev] [PATCH] net/vhost: fix segfault when creating vdev dynamically

2018-03-27 Thread Tan, Jianfeng
On 3/27/2018 6:18 PM, Chen, Junjie J wrote: On 3/27/2018 5:24 PM, Chen, Junjie J wrote: On 3/28/2018 12:05 AM, Junjie Chen wrote: when creating vdev dynamically, vhost pmd driver start directly without checking TX/RX queues ready or not, and thus cause segmentation fault when vhost library ac

Re: [dpdk-dev] [PATCH] net/i40evf: add multicast MAC address filtering

2018-03-27 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Thursday, January 25, 2018 10:36 PM > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi Z > ; Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/i40evf: add multicast MAC address filtering > > Add suppo

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-27 Thread Wiles, Keith
> On Mar 27, 2018, at 7:40 AM, Gaëtan Rivet wrote: > > On Tue, Mar 27, 2018 at 07:47:50AM -0400, Neil Horman wrote: >> On Tue, Mar 27, 2018 at 01:18:34AM +0200, Gaetan Rivet wrote: >>> Parse a device description. >>> Split this description in their relevant part for each layers. >>> No dynamic

Re: [dpdk-dev] [PATCH] net/mlx5: fix ICC compilation

2018-03-27 Thread Shahaf Shuler
Wednesday, March 21, 2018 11:53 AM, Ferruh Yigit: > On 3/19/2018 10:42 AM, Nelio Laranjeiro wrote: > > Remove the second declaration of device_attr [1] inside the loop as > > well as the query_device_ex() which has already been done outside of the > loop. > > > > Fixes: 9a761de8ea14 ("net/mlx5: flo

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-27 Thread Gaëtan Rivet
On Tue, Mar 27, 2018 at 02:40:00PM +0200, Gaëtan Rivet wrote: > On Tue, Mar 27, 2018 at 07:47:50AM -0400, Neil Horman wrote: > > On Tue, Mar 27, 2018 at 01:18:34AM +0200, Gaetan Rivet wrote: > > > Parse a device description. > > > Split this description in their relevant part for each layers. > > >

[dpdk-dev] [PATCH v1 3/3] lib/cryptodev: add asymmetric algos in cryptodev

2018-03-27 Thread Shally Verma
Add rte_crypto_asym.h with supported algo enumerations and associated xforms and op structures. API currently supports: RSA, Modular Exponentiation, Modular Inverse, DSA, Deffie-hellman And op_types: Encryption, Decryption, Sign, Verify, Deffie-hellman private key exchange, Deffie-hellman public

[dpdk-dev] [PATCH v1 2/3] lib/cryptodev: add asymmetric crypto capability in cryptodev

2018-03-27 Thread Shally Verma
Extend cryptodev with asymmetric capability APIs and definitions. Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta --- lib/librte_cryptodev/rte_cryptodev.c | 96 ++ lib/librte_cryptodev/rte_cryptodev.h | 105 +++

[dpdk-dev] [PATCH v1 1/3] lib/cryptodev: add support for asymmetric crypto op

2018-03-27 Thread Shally Verma
Extend DPDK librte_cryptodev to: - define asym op type in rte_crypto_op_type and associated op APIs - define asym session and associated session APIs If PMD shows in its feature flag that it supports both sym and asym then it must support those on all its qps. Application may choose to direct al

[dpdk-dev] [PATCH v1 0/3] lib/cryptodev: add support of asymmetric crypto

2018-03-27 Thread Shally Verma
This patch series add support for asymmetric crypto API specification in DPDK librte_cryptodev library. It is based on review discussion on RFC v1 patch http://dpdk.org/patch/34308 Key changes from RFCv1 include: - removal of dedicated sym and asym qp setup, - remove asym qp count and attach/deta

Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: convert to new Rx offloads API

2018-03-27 Thread Zhang, Qi Z
> +static int > +i40e_check_rx_queue_offloads(struct rte_eth_dev *dev, uint64_t > +requested) { > + struct rte_eth_dev_info dev_info; > + uint64_t mandatory = dev->data->dev_conf.rxmode.offloads; > + uint64_t supported; /* All per port offloads */ > + > + dev->dev_ops->dev_infos_get

Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization

2018-03-27 Thread Gaëtan Rivet
On Tue, Mar 27, 2018 at 07:47:50AM -0400, Neil Horman wrote: > On Tue, Mar 27, 2018 at 01:18:34AM +0200, Gaetan Rivet wrote: > > Parse a device description. > > Split this description in their relevant part for each layers. > > No dynamic allocation is performed. > > > > Cc: Neil Horman > > Cc: "

[dpdk-dev] [PATCH v1] crypto/aesni_mb: support AES CMAC

2018-03-27 Thread Kovacevic, Marko
From: Marko Kovacevic Signed-off-by: Marko Kovacevic --- doc/guides/cryptodevs/aesni_mb.rst | 1 + doc/guides/cryptodevs/features/aesni_mb.ini| 2 +- doc/guides/cryptodevs/features/default.ini | 1 + doc/guides/rel_notes/release_18_05.rst | 6 ++

[dpdk-dev] [PATCH v1 1/2] crypto/aesni_mb: support IPsec MUlti-buffer lib v0.49

2018-03-27 Thread Kovacevic, Marko
From: Marko Kovacevic Signed-off-by: Marko Kovacevic --- devtools/test-build.sh | 2 -- doc/guides/cryptodevs/aesni_mb.rst | 13 ++--- drivers/crypto/aesni_mb/Makefile | 10 +- drivers/crypto/aesni_mb/aesni_mb_ops.h | 3 +-- drivers/cr

[dpdk-dev] [PATCH v1 2/2] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.49

2018-03-27 Thread Kovacevic, Marko
Signed-off-by: Marko Kovacevic --- devtools/test-build.sh | 3 --- doc/guides/cryptodevs/aesni_gcm.rst | 13 ++--- drivers/crypto/aesni_gcm/Makefile| 10 +- drivers/crypto/aesni_gcm/aesni_gcm_ops.h | 3 +-- mk/rte.app.mk

  1   2   >