[dpdk-dev] [PATCH] examples/flow_filtering: add delay during updating link status

2018-01-23 Thread Beilei Xing
Add up to 9s delay for getting link status to make sure NIC updates link status successfully, just like other applications such as testpmd and l2fwd. Signed-off-by: Beilei Xing --- examples/flow_filtering/main.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/exa

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-23 Thread Yuanhan Liu
On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > 23/01/2018 13:46, Yuanhan Liu: > > On Thu, Jan 18, 2018 at 10:46:23AM +0100, Gaëtan Rivet wrote: > > > On Thu, Jan 18, 2018 at 09:46:29AM +0100, Thomas Monjalon wrote: > > > > 18/01/2018 08:35, Yuanhan Liu: > > > > > On Wed, Jan 17,

Re: [dpdk-dev] Dynamic Logging Name Formatting

2018-01-23 Thread Andrew Rybchenko
On 01/23/2018 11:54 PM, Bruce Richardson wrote: On Tue, Jan 23, 2018 at 05:45:09PM +, Ferruh Yigit wrote: On 1/23/2018 5:31 PM, Van Haaren, Harry wrote: === Suggested Consistent Schema === === Libraries: lib..specialization Net PMDs: pmd..specializati

[dpdk-dev] [PATCH] examples/flow_filtering: fix incorrect port id size

2018-01-23 Thread Zhiyong Yang
Ethdev port id has been extended 16bits from 8bits in DPDK 17.11 release, the patch fixes mismatch use. Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow API") Cc: sta...@dpdk.org Cc: or...@mellanox.com Cc: ferruh.yi...@intel.com Cc: tho...@monjalon.net Signed-off-by: Zhiyong

Re: [dpdk-dev] [PATCH v3 3/3] doc: convert license headers to SPDX tags

2018-01-23 Thread Hemant Agrawal
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > 23/01/2018 16:19, Hemant Agrawal: > > > > > -Original Message- > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > 23/01/2018 14:08, Hemant Agrawal: > > > > This patch will be good if you on

Re: [dpdk-dev] [PATCH 1/7 v2] bus/dpaa: check flag in qman multi enqueue

2018-01-23 Thread Hemant Agrawal
> -Original Message- > From: Nipun Gupta [mailto:nipun.gu...@nxp.com] > A caller may/may not pass the flags in qman enqueue multi API. > This patch adds a check on that flag and only accesses it if passed by the > caller. > > Fixes: 43797e7b4774 ("bus/dpaa: support event dequeue and > co

Re: [dpdk-dev] [PATCH 1/3] bus/fslmc: create function to prefetch next DQRR entry

2018-01-23 Thread Hemant Agrawal
> -Original Message- > From: Nipun Gupta [mailto:nipun.gu...@nxp.com] > Subject: [PATCH 1/3] bus/fslmc: create function to prefetch next DQRR > Signed-off-by: Nipun Gupta > --- > drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h | 6 ++ > drivers/bus/fslmc/qbman/qbman_portal.c

[dpdk-dev] [PATCH 4/4] net/avf: fix VF RX queue interrupt enabling

2018-01-23 Thread Wenzhuo Lu
As UIO doesn't support multiple interrupt, and the interrupt is occupied by the control plane. PMD should not try to enable RX queue interrupt. Then APP can know the RX queue interrupt is not enabled and only choose the polling mode. Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") Signed-off-

[dpdk-dev] [PATCH 0/4] fix VF RX queue interrupt enabling

2018-01-23 Thread Wenzhuo Lu
If multiple interrupt not supported, the driver should not try to enable RX queue interrupt. Then APP can know the RX queue interrupt is not enabled and only choose the polling mode. Wenzhuo Lu (4): net/i40e: fix VF RX queue interrupt enabling net/ixgbe: fix VF RX queue interrupt enabling ne

[dpdk-dev] [PATCH 3/4] net/e1000: fix VF RX queue interrupt enabling

2018-01-23 Thread Wenzhuo Lu
When using UIO, after enabling the interrupt to get the PF message, VF RX queue interrupt is not working. It's expected, as UIO doesn't support multiple interrupt. So, PMD should not try to enable RX queue interrupt. Then APP can know the RX queue interrupt is not enabled and only choose the pollin

[dpdk-dev] [PATCH 2/4] net/ixgbe: fix VF RX queue interrupt enabling

2018-01-23 Thread Wenzhuo Lu
When using UIO, after enabling the interrupt to get the PF message, VF RX queue interrupt is not working. It's expected, as UIO doesn't support multiple interrupt. So, PMD should not try to enable RX queue interrupt. Then APP can know the RX queue interrupt is not enabled and only choose the pollin

[dpdk-dev] [PATCH 1/4] net/i40e: fix VF RX queue interrupt enabling

2018-01-23 Thread Wenzhuo Lu
When using UIO, after enabling the interrupt to get the PF message, VF RX queue interrupt is not working. It's expected, as UIO doesn't support multiple interrupt. So, PMD should not try to enable RX queue interrupt. Then APP can know the RX queue interrupt is not enabled and only choose the pollin

[dpdk-dev] [PATCH v1] net/mlx4: fix single port configuration

2018-01-23 Thread Ophir Munk
The number of mlx4 present ports is calculated as follows: conf.ports.present |= (UINT64_C(1) << device_attr.phys_port_cnt) - 1; That is - all ones sequence (due to -1 subtraction) When retrieving the number of ports, 1 must be added in order to obtain the correct number of ports to the power of 2

Re: [dpdk-dev] [RFC v2 00/23] Dynamic memory allocation for DPDK

2018-01-23 Thread Yongseok Koh
> On Dec 19, 2017, at 3:14 AM, Anatoly Burakov > wrote: [...] > Quick outline of all changes done as part of this patchset: > > * Malloc heap adjusted to handle holes in address space > * Single memseg list replaced by multiple expandable memseg lists > * VA space for hugepages is preallocated

[dpdk-dev] [PATCH v1] net/tap: use local eBPF definitions

2018-01-23 Thread Ophir Munk
eBPF has a graceful approach: it must successfully compile on all Linux distributions. If a specific kernel cannot support eBPF it will gracefully refuse the eBPF netlink message sent to it. The kernel header file linux/bpf.h (if present) on different Linux distributions may not include all definit

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Ananyev, Konstantin
> > 23/01/2018 16:18, Ananyev, Konstantin: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 23/01/2018 14:34, Ananyev, Konstantin: > > > > > If that' s the use case, then I think you need to set device >

Re: [dpdk-dev] Dynamic Logging Name Formatting

2018-01-23 Thread Bruce Richardson
On Tue, Jan 23, 2018 at 05:45:09PM +, Ferruh Yigit wrote: > On 1/23/2018 5:31 PM, Van Haaren, Harry wrote: > > === Suggested Consistent Schema === > > === > > > > Libraries: > > lib..specialization > > > > Net PMDs: > > pmd..specialization > > // one coul

[dpdk-dev] [PATCH v5 3/3] net/failsafe: add Rx interrupts

2018-01-23 Thread Moti Haimovsky
This patch is the last patch in the series of patches aimed to add support for registering and waiting for Rx interrupts in failsafe PMD. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. The failsafe PMD presents to the application a facade of a single

[dpdk-dev] [PATCH v5 2/3] net/failsafe: slaves Rx interrupts registration

2018-01-23 Thread Moti Haimovsky
This commit adds the following functionality to failsafe PMD: * Register and unregister slaves Rx interrupts. * Enable and Disable slaves Rx interrupts. The interrupts events generated by the slaves are not handled in this commit. Signed-off-by: Moti Haimovsky --- V5: Initial version of this patc

[dpdk-dev] [PATCH v5 0/3] net/failsafe: add Rx interrupts support

2018-01-23 Thread Moti Haimovsky
These three patches add support for registering and waiting for Rx interrupts in failsafe PMD. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. The failsafe PMD presents to the application a facade of a single device to be handled by the application w

[dpdk-dev] [PATCH v5 1/3] net/failsafe: regiter as an Rx interrupt mode PMD

2018-01-23 Thread Moti Haimovsky
This patch adds registering the Rx queues of the failsafe PMD with EAL Rx interrupts subsystem. Each failsafe RX queue is assigned with a unique eventfd and an enable interrupts flag. The PMD creates an interrupt vector containing the above eventfds and Registers it with EAL. The PMD also implemen

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-23 Thread Thomas Monjalon
23/01/2018 18:37, Gaëtan Rivet: > So your proposition is more flexible, but I do not see how "driver" will > be used for matching. I guess I'll see. For now, I am not sure there are real examples of driver-specific properties to match. An example in my mind: Napatech can have ports with the same P

Re: [dpdk-dev] Dynamic Logging Name Formatting

2018-01-23 Thread Ferruh Yigit
On 1/23/2018 5:31 PM, Van Haaren, Harry wrote: > === Suggested Consistent Schema === > === > > Libraries: > lib..specialization > > Net PMDs: > pmd..specialization > // one could argue consistency would be pmd.ethdev. > // but the change is larger than the

Re: [dpdk-dev] [PATCH] net/bonding: check dequeue result before proceeding

2018-01-23 Thread Mcnamara, John
> -Original Message- > From: Nicolau, Radu > Sent: Monday, January 22, 2018 4:44 PM > To: dev@dpdk.org > Cc: Kovacevic, Marko ; Mcnamara, John > ; Doherty, Declan ; > Yigit, Ferruh ; Nicolau, Radu > > Subject: [PATCH] net/bonding: check dequeue result before proceeding > > Fixes Coverit

Re: [dpdk-dev] [PATCH] examples/bond: add mbuf alloc check

2018-01-23 Thread Mcnamara, John
> -Original Message- > From: Nicolau, Radu > Sent: Monday, January 22, 2018 4:37 PM > To: dev@dpdk.org > Cc: Kovacevic, Marko ; Mcnamara, John > ; Doherty, Declan ; > Nicolau, Radu > Subject: [PATCH] examples/bond: add mbuf alloc check > > Fixes Coverity issue 257008 > Hi Radu, You s

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-23 Thread Gaëtan Rivet
On Tue, Jan 23, 2018 at 06:22:53PM +0100, Thomas Monjalon wrote: > 23/01/2018 17:08, Gaëtan Rivet: > > Hi Yuanhan, Thomas, > > > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > > > 23/01/2018 13:46, Yuanhan Liu: > > > > On Thu, Jan 18, 2018 at 10:46:23AM +0100, Gaëtan Rivet wr

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Thomas Monjalon
23/01/2018 16:18, Ananyev, Konstantin: > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 23/01/2018 14:34, Ananyev, Konstantin: > > > > If that' s the use case, then I think you need to set device ownership > > >

[dpdk-dev] Dynamic Logging Name Formatting

2018-01-23 Thread Van Haaren, Harry
Hi All, I'm looking at the output of app/test >> dump_log_types There are a number of naming systems, and I think it would be good to standardize on one (before we diverge further than we already have..) Below a summary of current state, which is becoming a little messy IMO. A proposed (hopef

Re: [dpdk-dev] [PATCH v3 3/3] doc: convert license headers to SPDX tags

2018-01-23 Thread Thomas Monjalon
23/01/2018 16:19, Hemant Agrawal: > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 23/01/2018 14:08, Hemant Agrawal: > > > This patch will be good if you only add SPDX to it and NOT remove the > > original license text. > > > i.e. only do following: >

[dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-01-23 Thread Ravi Kerur
Hi, I am running into an issue when DPDK is started with iommu on via GRUB command. Problem is not seen with regular kernel driver, error messages show when DPDK is started and happens for both PF and VF interfaces. I am using DPDK 17.05 so the patch proposed in the following link is available ht

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-23 Thread Thomas Monjalon
23/01/2018 17:08, Gaëtan Rivet: > Hi Yuanhan, Thomas, > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > > 23/01/2018 13:46, Yuanhan Liu: > > > On Thu, Jan 18, 2018 at 10:46:23AM +0100, Gaëtan Rivet wrote: > > > > On Thu, Jan 18, 2018 at 09:46:29AM +0100, Thomas Monjalon wrote:

[dpdk-dev] [PATCH 4/5] net/mlx5: fix memory registration cache last index

2018-01-23 Thread Shahaf Shuler
In case memory registration cache is full the new mempool will be inserted in the last index of the array. Update the last entry being hit to reflect it. Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86") Cc: sta...@dpdk.org Cc: ys...@mellanox.com Signed-off-by: Shahaf Shuler

Re: [dpdk-dev] [PATCH] examples: update copyrights and license

2018-01-23 Thread Bruce Richardson
On Tue, Jan 23, 2018 at 04:46:18PM +, Lee Daly wrote: > This updates the Intel, Cavium and Hasan Alayli license on files in examples > to be the standard BSD-3-Clause license used for the rest of DPDK, > bringing the files in compliance with the DPDK licensing policy. > > Signed-off-by: Lee Da

[dpdk-dev] [PATCH 5/5] net/mlx5: fix Memory Region boundary checks

2018-01-23 Thread Shahaf Shuler
Since commit f81ec748434b ("net/mlx5: fix memory region lookup") the memory regions (MR) are no longer overlaps. Comparing the end address of the MR should be exclusive, otherwise two contiguous MRs may cause wrong matching. Fixes: f81ec748434b ("net/mlx5: fix memory region lookup") Cc: ys...@mel

[dpdk-dev] [PATCH 2/5] net/mlx5: fix secondary process mempool registration

2018-01-23 Thread Shahaf Shuler
Secondary process is not allowed to register mempools on the flight. The code will return invalid memory key for such case. Fixes: 87ec44ce1651 ("net/mlx5: add operations for secondary process") Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler Signed-off-by: Xueming Li --- doc/guides/nics/mlx

[dpdk-dev] [PATCH 3/5] net/mlx5: assert for un-successful memory registration

2018-01-23 Thread Shahaf Shuler
Memory registration can fail, add the proper assert for such scenario for it at least to be visible in debug mode. Signed-off-by: Shahaf Shuler Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_rxtx.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drive

[dpdk-dev] [PATCH 1/5] net/mlx5: fix Memory Region cache lookup

2018-01-23 Thread Shahaf Shuler
The memory registration (MR) cache contains pointers to mlx5_mr. The MR cache indexes are filled when a new MR is created. As it is possible for MR to be created on the flight, an extra validation must be added to avoid segmentation fault. Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst

[dpdk-dev] [PATCH 0/5] fix Memory region lookups

2018-01-23 Thread Shahaf Shuler
The series contains multiple small patches which address various of issues with the Memory region lookup on the Transmit side. Xueming Li Shahaf Shuler (5): net/mlx5: fix Memory Region cache lookup net/mlx5: fix secondary process mempool registration net/mlx5: assert for un-successful memory

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: update copyright and license

2018-01-23 Thread Bruce Richardson
On Tue, Jan 23, 2018 at 04:44:25PM +, Lee Daly wrote: > This updates the Intel, Oliver Matz and Internet Software Consortium > license on files in examples to be the standard BSD-3-Clause license > used for the rest of DPDK,bringing the files in compliance with > the DPDK licensing policy. > >

[dpdk-dev] [PATCH] net/mlx5: fix link state on device start

2018-01-23 Thread Shahaf Shuler
Following commit c7bf62255edf ("net/mlx5: fix handling link status event") the link state must be up in order for the burst function to be set on the device ops. As the link may take time to move between down and up state it is possible the rte_eth_dev_start call will return with wrong burst funct

[dpdk-dev] [PATCH] examples: update copyrights and licenses

2018-01-23 Thread Lee Daly
This updates the Intel and Hasan Alayli license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- examples/performance-thread/common/arch/x86/ctx.c | 58 ++--

[dpdk-dev] [PATCH] examples: update copyrights and license

2018-01-23 Thread Lee Daly
This updates the Intel, Cavium and Hasan Alayli license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- .../performance-thread/common/arch/x86/stack.h | 61 ++-

[dpdk-dev] [PATCH] examples/l3fwd: update copyright and licenses

2018-01-23 Thread Lee Daly
This updates the Intel and Linaro Limited license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- examples/l3fwd/l3fwd_common.h | 32 ++---

[dpdk-dev] [PATCH] examples/l3fwd: update copyright and license

2018-01-23 Thread Lee Daly
This updates the Intel and IBM license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- examples/l3fwd/l3fwd_altivec.h | 37

[dpdk-dev] [PATCH] examples/ip_pipeline: update copyright and license

2018-01-23 Thread Lee Daly
This updates the Intel, Oliver Matz and Internet Software Consortium license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK,bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- examples/ip_pipeline/parser.c | 69 ++--

[dpdk-dev] [PATCH] examples/cmdline: update copyright and license

2018-01-23 Thread Lee Daly
This updates the license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- examples/cmdline/commands.c | 58 ++- examples/c

Re: [dpdk-dev] [PATCH] mk: fix libs installation when installing sdk

2018-01-23 Thread Olivier Matz
Hi Thomas, On Fri, Dec 15, 2017 at 12:00:01PM +0100, Thomas Monjalon wrote: > 15/12/2017 11:45, Olivier MATZ: > > On Fri, Dec 15, 2017 at 11:32:12AM +0100, Thomas Monjalon wrote: > > > 15/12/2017 11:25, Olivier MATZ: > > > > On Fri, Dec 15, 2017 at 11:19:57AM +0100, Thomas Monjalon wrote: > > > >

[dpdk-dev] [PATCH] net/octeontx: disable PMD for old compilers

2018-01-23 Thread Pavan Nikhilesh
Disable for clang < 4.0 as it doesn't support the following arm machine directives: .cpu This also disables event octeontx as it depends on net octeontx. Signed-off-by: Pavan Nikhilesh --- drivers/event/Makefile | 4 drivers/net/Makefile | 3 +++

[dpdk-dev] [PATCH] igb_uio: change the irq print type.

2018-01-23 Thread xiangxia . m . yue
From: Tonghao Zhang The kernel uses the '%d' or '%ld' to print irq num. But igb_uio may use the '%lx', then the log may confuse the user what irq num has been used. The log is show as below. igb_uio :00:03.0: irq 24 for MSI/MSI-X igb_uio :00:03.0: uio device registered with irq 18 kerne

Re: [dpdk-dev] [dpdk-stable] [PATCH] event/sw: fix debug logging config option

2018-01-23 Thread Thomas Monjalon
19/01/2018 11:07, Van Haaren, Harry: > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > align the config option name with config/common_base > > > > Fixes: aaa4a221da26 ("event/sw: add new software-only eventdev driver") > > > > Cc: sta...@dpdk.org > > Signed-off-by: Jerin Jacob >

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-23 Thread Gaëtan Rivet
Hi Yuanhan, Thomas, On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > 23/01/2018 13:46, Yuanhan Liu: > > On Thu, Jan 18, 2018 at 10:46:23AM +0100, Gaëtan Rivet wrote: > > > On Thu, Jan 18, 2018 at 09:46:29AM +0100, Thomas Monjalon wrote: > > > > 18/01/2018 08:35, Yuanhan Liu: > >

[dpdk-dev] [PATCH v3 3/4] net/virtio: rationalize queue flushing

2018-01-23 Thread Olivier Matz
Use the same kind of loop than in virtio_free_queues() and factorize common code. Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 57 -- 1 file changed, 24 insertions(+), 33 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/

[dpdk-dev] [PATCH v3 4/4] net/virtio: fix typo in function name

2018-01-23 Thread Olivier Matz
Fixes: c1f86306a026 ("virtio: add new driver") Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 2 +- drivers/net/virtio/virtqueue.c | 2 +- drivers/net/virtio/virtqueue.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/virtio/virtio

[dpdk-dev] [PATCH v3 1/4] net/virtio: fix queue flushing with vector Rx enabled

2018-01-23 Thread Olivier Matz
When using vector Rx mode (use_simple_rx = 1), vq->vq_descx[] is not kept up to date. To properly detach the mbufs in this case, browse sw_ring[] instead, as it's done in virtqueue_rxvq_flush(). Since we need virtio_get_queue_type(), also move this function in virtqueue.h as a static inline. Fixe

[dpdk-dev] [PATCH v3 2/4] net/virtio: fix memory leak when reinitializing device

2018-01-23 Thread Olivier Matz
Free the previous queues and the attached mbufs before initializing new ones. The function virtio_dev_free_mbufs() is now called when reconfiguring the device, so we also need to add a check to ensure that it won't crash for uninitialized queues. Cc: sta...@dpdk.org Fixes: 60e6f4707ef2 ("net/virt

[dpdk-dev] [PATCH v3 0/4] net/virtio: fix memory leak when reinitializing device

2018-01-23 Thread Olivier Matz
When devops->configure() is called, the queues may be reallocated if the features flag changed, but the previous are not freed. This patchset fixes this issue. To really point out the issue, I instrumented rte_malloc, rte_memzone_reserve, rte_mbuf_alloc to track the allocations and frees. For refe

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-01-23 Thread Doherty, Declan
On 11/01/2018 9:44 PM, John Daley (johndale) wrote: Hi, One comment on DECAP action and a "feature request". I'll also reply to the top of thread discussion separately. Thanks for the RFC Declan! Feature request associated with ENCAP action: VPP (and probably other apps) would like the abilit

[dpdk-dev] [PATCH v2] keepalive: fix keepalive state alignment

2018-01-23 Thread Andriy Berestovskyy
The __rte_cache_aligned was applied to the whole array, not the array elements. This leads to a false sharing between the monitored cores. Fixes: e70a61ad50ab ("keepalive: export states") Cc: remy.hor...@intel.com Signed-off-by: Andriy Berestovskyy --- Notes (changelog): V2 Changes: - f

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix index

2018-01-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Tuesday, January 23, 2018 3:29 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix index > > > > > -Original Message- >

Re: [dpdk-dev] [dpdk-stable] [PATCH] lib: fix wrong cast

2018-01-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of De Lara > Guarch, Pablo > Sent: Tuesday, January 23, 2018 3:31 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: Yigit, Ferruh ; tho...@monjalon.net; > sta...@dpdk.org; Doherty, Declan ; > akhil.go...@nxp.com; Yan

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-01-23 Thread Doherty, Declan
On 16/01/2018 8:22 AM, Shahaf Shuler wrote: Thursday, January 11, 2018 11:45 PM, John Daley: Hi Declan and Shahaf, I can't see how the existing ethdev API could be used for statistics as a single ethdev could be supporting may concurrent TEPs, therefore we would either need to use the extended

Re: [dpdk-dev] [dpdk-stable] [PATCH] lib: fix wrong cast

2018-01-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Zhiyong Yang > Sent: Tuesday, January 23, 2018 9:48 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; tho...@monjalon.net; > sta...@dpdk.org; Doherty, Declan ; > akhil.go...@nxp.com; Yang, Zhiyong > Subject: [dpd

Re: [dpdk-dev] [PATCH v2] app/test-crypto-perf: fix index

2018-01-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Zhang, Roy Fan > Sent: Tuesday, January 23, 2018 2:23 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [PATCH v2] app/test-crypto-perf: fix index > > Fixes: 27c2e7471961 ("app/crypto-perf: support IMIX") > > A bug caused index out-of-range error

Re: [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session

2018-01-23 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, January 23, 2018 3:05 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: RE: [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session > > > > -Original Message- > > From: dev [mailto:dev

Re: [dpdk-dev] [PATCH v3 3/3] doc: convert license headers to SPDX tags

2018-01-23 Thread Hemant Agrawal
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > 23/01/2018 14:08, Hemant Agrawal: > > This patch will be good if you only add SPDX to it and NOT remove the > original license text. > > i.e. only do following: > > > > > -.. BSD LICENSE > > > +.. SPDX-License-

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Tuesday, January 23, 2018 3:12 PM > To: Thomas Monjalon > Cc: Matan Azrad ; Gaëtan Rivet ; > Wu, Jingjing ; > dev@dpdk.org; Neil Horman ; Richardson, Bruce > > Subject: Re: [dpdk-de

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, January 23, 2018 2:19 PM > To: Ananyev, Konstantin > Cc: Matan Azrad ; Gaëtan Rivet ; > Wu, Jingjing ; > dev@dpdk.org; Neil Horman ; Richardson, Bruce > > Subject: Re: [PATCH v3 7/7] app/testpmd

Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: add and export MDIO APIs

2018-01-23 Thread Shweta Choudaha
Hi Helin, Thanks for the review. I 'll look at adding test cases too. In the meantime, updated this patch to reflect changes in patch 2 of the series. Thanks, Shweta On Thu, Dec 21, 2017 at 3:25 AM, Zhang, Helin wrote: > In general, I'd suggest to add two things together with this patch se

[dpdk-dev] [PATCH v3 2/2] net/ixgbe : backplane port MDIO support

2018-01-23 Thread Shweta Choudaha
From: Shweta Choudaha Initialize and implement MDIO read/write functions for backplane port (IXGBE_DEV_ID_X550EM_A_KR_L) to enable read/write registers via MDIO Signed-off-by: Shweta Choudaha Reviewed-by: Chas Williams Reviewed-by: Luca Boccassi --- drivers/net/ixgbe/base/ixgbe_x550.c | 54 +

[dpdk-dev] [PATCH v3 1/2] net/ixgbe: add and export MDIO APIs

2018-01-23 Thread Shweta Choudaha
From: Shweta Choudaha Add ixgbe MDIO access APIs to read and write PHY registers when being used as a backplane port. Export these APIs via the map file Signed-off-by: Shweta Choudaha Reviewed-by: Chas Williams Reviewed-by: Luca Boccassi --- drivers/net/ixgbe/rte_pmd_ixgbe.c | 53 +

Re: [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session

2018-01-23 Thread Nicolau, Radu
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fan Zhang > Sent: Tuesday, January 23, 2018 12:32 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] examples/ipsec_secgw: fix security session > > Fixes: 3da37f682173 ("examples/ipse

[dpdk-dev] [PATCH 2/3] event/dpaa2: prefetch the next DQRR entry

2018-01-23 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- drivers/event/dpaa2/dpaa2_eventdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 84ecd1b..c3e6fbf 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drive

[dpdk-dev] [PATCH 3/3] net/dpaa2: prefetch the annotation in event processing

2018-01-23 Thread Nipun Gupta
This patch adds software prefetching of the annotation which is accessed by the driver to fetch the parsing results. The changes also include as many instructions in between prefetching memory and using it. Signed-off-by: Nipun Gupta --- drivers/net/dpaa2/dpaa2_rxtx.c | 24 --

[dpdk-dev] [PATCH 1/3] bus/fslmc: create function to prefetch next DQRR entry

2018-01-23 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h | 6 ++ drivers/bus/fslmc/qbman/qbman_portal.c | 11 +++ drivers/bus/fslmc/rte_bus_fslmc_version.map| 1 + 3 files changed, 18 insertions(+) diff --git a/drivers/bus/fslmc/qbman/in

Re: [dpdk-dev] [PATCH v5] doc: add queue region feature info to release notes

2018-01-23 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mcnamara, John > Sent: Tuesday, January 23, 2018 6:22 PM > To: Zhao1, Wei; dev@dpdk.org > Cc: tho...@monjalon.net; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5] doc: add queue region feature info to > relea

Re: [dpdk-dev] [PATCH] doc: add i40e update

2018-01-23 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Mcnamara, John > Sent: Tuesday, January 23, 2018 6:18 PM > To: Xing, Beilei > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: add i40e update > > > > > -Original Message- > > Fr

Re: [dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2018-01-23 Thread Doherty, Declan
On 11/01/2018 9:45 PM, John Daley (johndale) wrote: Hi Declan and Shahaf, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Doherty, Declan Sent: Tuesday, January 09, 2018 9:31 AM To: Shahaf Shuler ; dev@dpdk.org Subject: Re: [dpdk-dev] [RFC] tunnel endpoint hw acc

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Matan Azrad
Hi Konstantin Please move the second thread, I'm feeling you and Gaetan have the same questions. From: Ananyev, Konstantin, Tuesday, January 23, 2018 3:35 PM > Hi Matan, > > > > > > > Hi Konstantin > > From: Ananyev, Konstantin, Monday, January 22, 2018 10:49 PM > > > Hi Matan, > > > > > > > --

Re: [dpdk-dev] [PATCH v3 3/3] doc: convert license headers to SPDX tags

2018-01-23 Thread Thomas Monjalon
23/01/2018 14:08, Hemant Agrawal: > This patch will be good if you only add SPDX to it and NOT remove the > original license text. > i.e. only do following: > > > -.. BSD LICENSE > > +.. SPDX-License-Identifier: BSD-3-Clause > > Around RC2 timeframe, I intend to do that. All the remaining but

Re: [dpdk-dev] questions about new offload ethdev api

2018-01-23 Thread Shahaf Shuler
Tuesday, January 23, 2018 3:53 PM, Olivier Matz: > Hi, > > I'm currently porting an application to the new ethdev offload api, and I have > two questions about it. > > 1/ inconsistent offload capa for PMDs using the old API? > > It is stated in struct rte_eth_txmode: > >/** > * Per-port

Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix set VF MAC address

2018-01-23 Thread Hunt, David
Hi David, On 23/1/2018 2:14 PM, David Coyle wrote: Current code only sets mac address of first VF. Fix code so that it continues through the loop and sets the mac address of each VF. Fixes: c9a4779135c9 ("examples/vm_power_mgr: set MAC address of VF") Signed-off-by: David Coyle --- examples

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Matan Azrad
Hi From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > > > > > Look, > > > > > > > Testpmd initiates some of its internal databases depends on > > > > > > > specific port iteration, In some time someone may take > > > > > > > ownership of Testpmd ports and testpmd will continue to touch > them

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-23 Thread Thomas Monjalon
23/01/2018 13:46, Yuanhan Liu: > On Thu, Jan 18, 2018 at 10:46:23AM +0100, Gaëtan Rivet wrote: > > On Thu, Jan 18, 2018 at 09:46:29AM +0100, Thomas Monjalon wrote: > > > 18/01/2018 08:35, Yuanhan Liu: > > > > On Wed, Jan 17, 2018 at 12:34:08PM +, Ferruh Yigit wrote: > > > > > So does it make se

[dpdk-dev] [PATCH v1] doc: remove TUN from TAP PMD guide

2018-01-23 Thread Marko Kovacevic
From: Vipin Varghese TUN PMD is not supported, removing the refrences from Network Interface Controller Driver Tun/Tap Poll Mode Driver section Signed-off-by: Vipin Varghese --- doc/guides/nics/tap.rst | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/

Re: [dpdk-dev] [PATCH] examples/vm_power_manager: fix set VF MAC address

2018-01-23 Thread Hunt, David
Replying to notify , which was missing from original mail. -Original Message- From: Coyle, David Sent: Tuesday, 23 January, 2018 2:14 PM To: dev@dpdk.org Cc: Hunt, David ; sta...@intel.com; Coyle, David Subject: [PATCH] examples/vm_power_manager: fix set VF MAC address Current code onl

[dpdk-dev] [PATCH v2 09/10] test: enable rawdev skeleton test

2018-01-23 Thread Shreyansh Jain
Skeleton rawdevice test cases are part of driver layer. This patch allows test cases to be executed using 'rawdev_autotest' command in test framework. Signed-off-by: Shreyansh Jain --- test/test/Makefile | 4 test/test/test_rawdev.c | 27 +++ 2 files changed, 3

[dpdk-dev] [PATCH v2] app/test-crypto-perf: fix index

2018-01-23 Thread Fan Zhang
Fixes: 27c2e7471961 ("app/crypto-perf: support IMIX") A bug caused index out-of-range error. This simple patch is to fix this. Signed-off-by: Fan Zhang --- v2: Removed unnecessary cdev_id assignment line. app/test-crypto-perf/main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) dif

[dpdk-dev] [PATCH v2 07/10] drivers/raw: introduce skeleton rawdev driver

2018-01-23 Thread Shreyansh Jain
Skeleton rawdevice driver, on the lines of eventdev skeleton, is for showcasing the rawdev library. This driver implements some of the operations of the library based on which a test module can be developed. Design of skeleton involves a virtual device which is plugged into VDEV bus on initializat

[dpdk-dev] [PATCH v2 08/10] drivers/raw: support for rawdev testcases

2018-01-23 Thread Shreyansh Jain
Patch introduces rawdev unit testcase for validation against the Skeleton rawdev dummy PMD implementation. Test cases are added along with the skeleton driver implementation. It can be enabled by using vdev argument to any DPDK binary: --vdev="rawdev_skeleton,self_test=1" In case 'self_test=1'

[dpdk-dev] [PATCH v2 01/10] rawdev: introduce raw device library support

2018-01-23 Thread Shreyansh Jain
Each device in DPDK has a type associated with it - ethernet, crypto, event etc. This patch introduces 'rawdevice' which is a generic type of device, not currently handled out-of-the-box by DPDK. A device which can be scanned on an installed bus (pci, fslmc, ...) or instantiated through devargs, c

[dpdk-dev] [PATCH v2 06/10] rawdev: add self test support

2018-01-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte_rawdev.c | 9 + lib/librte_rawdev/rte_rawdev.h | 12 lib/librte_rawdev/rte_rawdev_pmd.h | 11 +++ lib/librte_rawdev/rte_rawdev_version.map | 1 + 4 files changed, 33 insertions(+) dif

[dpdk-dev] [PATCH v2 03/10] rawdev: add buffer stream IO support

2018-01-23 Thread Shreyansh Jain
Introduce handlers for raw buffer enqueue and dequeue. A raw buffer is essentially a void object which is transparently passed via the library onto the driver. Using a context field as argument, any arbitrary meta information can be passed by application to the driver/implementation. This can be a

[dpdk-dev] [PATCH v2 04/10] rawdev: support for extended stats

2018-01-23 Thread Shreyansh Jain
Generic rawdev library cannot define a pre-defined set of stats for devices which are yet to be defined. This patch introduces the xstats support for rawdev so that any implementation can create its own statistics. Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte_rawdev.c | 75

[dpdk-dev] [PATCH v2 00/10] Introduce generic 'rawdevice' support

2018-01-23 Thread Shreyansh Jain
Change History ~~ v2: - restructure comments to prefix model - split patches pivoted on APIs introduced in library - moved test into drivers/rawdev/skeleton from test/test - removed unused RTE_MAX_RAWDEVPORTS and RTE_MAX_RAWDEVS - merge patch configurations - checkpatch fixes Raw

[dpdk-dev] [PATCH v2 02/10] rawdev: add attribute get and set support

2018-01-23 Thread Shreyansh Jain
A rawdevice can have various attributes. This patch introduce support for transparently setting attribute value or getting current attribute state. This is done by allowing an opaque set of key and value to be passed through rawdev library. Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte

[dpdk-dev] [PATCH v2 05/10] rawdev: support for firmware management

2018-01-23 Thread Shreyansh Jain
Some generic operations for firmware management can loading, unloading, starting, stopping and querying firmware of a device. This patch adds support for such generic operations. Signed-off-by: Shreyansh Jain --- lib/librte_rawdev/rte_rawdev.c | 43 lib/librte_raw

[dpdk-dev] [PATCH v2 10/10] maintainers: claim ownership of rawdev

2018-01-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5788ea004..c3a8769a2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -302,6 +302,12 @@ F: lib/librte_eventdev/*eth_rx_adapter* F: test/test/test_event_eth_rx_adap

[dpdk-dev] [PATCH] config: replace Intel license headers with SPDX tags

2018-01-23 Thread Bruce Richardson
Signed-off-by: Bruce Richardson --- config/common_base| 33 ++- config/common_bsdapp | 33 ++- config/common_linuxapp| 33 ++- config/defconfig_i686

[dpdk-dev] [PATCH] examples/vm_power_manager: fix set VF MAC address

2018-01-23 Thread David Coyle
Current code only sets mac address of first VF. Fix code so that it continues through the loop and sets the mac address of each VF. Fixes: c9a4779135c9 ("examples/vm_power_mgr: set MAC address of VF") Signed-off-by: David Coyle --- examples/vm_power_manager/main.c | 5 ++--- 1 file changed, 2 i

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-23 Thread Thomas Monjalon
23/01/2018 14:34, Ananyev, Konstantin: > If that' s the use case, then I think you need to set device ownership at > creation time - > inside dev_allocate(). > Again that would avoid such racing conditions inside testpmd. The devices must be allocated at a low level layer. When a new device appea

  1   2   >