[dpdk-dev] [PATCH] net/mlx5: fix Memory Region lookup

2018-01-18 Thread Yongseok Koh
This patch reverts: commit 3a6f2eb8c5c5 ("net/mlx5: fix Memory Region registration") Although granularity of chunks in a mempool is a cacheline, addresses are extended to align to page boundary for performance reason in device when registering a MR (Memory Region). This could make some reg

[dpdk-dev] [PATCH v4 2/3] net/i40e: add parser for IPV4FRAG and IPV6FRAG

2018-01-18 Thread Beilei Xing
There're new metadata IPV4FRAG and IPV6FRAG in PPP profile, this patch improves ptype parser to support IPV4FRAG and IPV6FRAG. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 44 +++--- 1 file changed, 28 insertions(+), 16 deletions(-) diff --

[dpdk-dev] [PATCH v4 0/3] net/i40e: change for ptype parser

2018-01-18 Thread Beilei Xing
This patchset is mainly for fixing fail to update SW ptype table and adding parser for IPV4FRAG and IPV6FRAG. v4 changes: - Slipt patchset and replace strncmp with strncasecmp. v3 changes: - Reorder IPv4 case. v2 changes: - Add parser for IPV4FRAG and IPV6FRAG. Beilei Xing (3): net/i40e: fix

[dpdk-dev] [PATCH v4 3/3] net/i40e: replace strncmp with strncasecmp

2018-01-18 Thread Beilei Xing
Replace strncmp with strncasecmp in i40e_update_customized_ptype function for compatibility. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 55 +++--- 1 file changed, 30 insertions(+), 25 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev

[dpdk-dev] [PATCH v4 1/3] net/i40e: fix fail to update ptype table

2018-01-18 Thread Beilei Xing
Fail to update SW ptype mapping table when loading PPP profile, though profile can be loaded successfully. It will cause fail to parse SW ptype during receiving packets. This patch fixes this issue. Fixes: 11556c915a08 ("net/i40e: improve packet type parser") Cc: sta...@dpdk.org Signed-off-by: Be

Re: [dpdk-dev] [PATCH v3 1/8] eal: introduce DMA memory barriers

2018-01-18 Thread Andrew Rybchenko
On 01/19/2018 03:44 AM, Yongseok Koh wrote: This commit introduces rte_dma_wmb() and rte_dma_rmb(), in order to guarantee the ordering of coherent shared memory between the CPU and a DMA capable device. Signed-off-by: Yongseok Koh Acked-by: Andrew Rybchenko It is already really good. Many t

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-18 Thread Matan Azrad
Hi Neil From: Neil Horman, Friday, January 19, 2018 3:41 AM > On Thu, Jan 18, 2018 at 08:21:34PM +, Matan Azrad wrote: > > Hi Neil. > > > > From: Neil Horman, Thursday, January 18, 2018 8:42 PM > > 1. What exactly do you want to improve?(in details) 2. Which API > > specifically do you want

Re: [dpdk-dev] [PATCH v2] app/testpmd: make txonly mode generate multiple flows

2018-01-18 Thread Yongseok Koh
> On Jan 18, 2018, at 4:21 AM, Ananyev, Konstantin > wrote: > > Hi, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh >> Sent: Wednesday, January 17, 2018 6:19 PM >> To: Lu, Wenzhuo ; Wu, Jingjing >> Cc: dev@dpdk.org; Yongseok Koh >> Subject

[dpdk-dev] [PATCH] vhost: fix ANY_LAYOUT declaration

2018-01-18 Thread Zhihong Wang
The VIRTIO_F_ANY_LAYOUT feature indicates the device accepts arbitrary descriptor layouts. The vhost-user lib already supports it, but the feature declaration is missing. This patch fixes the mismatch. Signed-off-by: Zhihong Wang --- lib/librte_vhost/vhost.h | 1 + 1 file changed, 1 insertion(+

Re: [dpdk-dev] [PATCH v5 0/6] TAP RSS eBPF cover letter

2018-01-18 Thread Pascal Mazon
Hi, It seems more logical to me to introduce tap_program (patch 3) before its compiled version (patch 2). Source code is indeed written down before compiling it. The doc section is a good addition. I'll be happy to see the upcoming utility for turning eBPF bytecode to C arrays. I'd have liked to

[dpdk-dev] [PATCH] net/sfc/base: fix unused argument warning

2018-01-18 Thread Andrew Rybchenko
From: Andy Moreton The type_data argument to ef10_rx_qcreate is only used in builds with EFSYS_OPT_RX_PACKED_STREAM. note this as an usued argument to avoid warnings in builds without packed stream support. Fixes: b749646dade4 ("net/sfc/base: add function to create packed stream RxQ") Signed-of

[dpdk-dev] [PATCH] event/sw: fix debug logging config option

2018-01-18 Thread Jerin Jacob
align the config option name with config/common_base Fixes: aaa4a221da26 ("event/sw: add new software-only eventdev driver") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob --- drivers/event/sw/sw_evdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/sw/sw_evd

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-18 Thread Yongseok Koh
> On Jan 18, 2018, at 8:13 AM, Olivier Matz wrote: > > On Thu, Jan 18, 2018 at 05:04:27PM +0100, Nélio Laranjeiro wrote: >> On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote: >>> On error, mlx5_dev_start() does not return a negative value >>> as it is supposed to do. The consequence is

[dpdk-dev] 答复: [PATCH v5] arch/arm: optimization for memcpy on AArch64

2018-01-18 Thread Herbert Guan
Yes, this is the target. I was in a 3-day meeting this week, and had limited time to update the patch. A new patch v6 was sent out just now. It's actually sent twice -- forgot to add version info and "--in-reply-to" in the first one. Please just ignore that and I'm sorry for the disturbanc

[dpdk-dev] [PATCH v6] arch/arm: optimization for memcpy on ARM64

2018-01-18 Thread Herbert Guan
This patch provides an option to do rte_memcpy() using 'restrict' qualifier, which can induce GCC to do optimizations by using more efficient instructions, providing some performance gain over memcpy() on some ARM64 platforms/enviroments. The memory copy performance differs between different ARM64

[dpdk-dev] [PATCH] arch/arm: optimization for memcpy on ARM64

2018-01-18 Thread Herbert Guan
This patch provides an option to do rte_memcpy() using 'restrict' qualifier, which can induce GCC to do optimizations by using more efficient instructions, providing some performance gain over memcpy() on some ARM64 platforms/enviroments. The memory copy performance differs between different ARM64

[dpdk-dev] [PATCH v3] net/i40e: fix fdir Rx resource defect

2018-01-18 Thread Beilei Xing
FDIR Rx ring isn't initialized and Rx queue HW tail isn't updated when there's error detected during programming FDIR flow. There'll be some potential risk. This patch updates FDIR Rx resource. Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director") Fixes: 05999aab4ca6 ("i40e: add or del

Re: [dpdk-dev] [PATCH v2] net/i40e: fix fdir Rx resource defect

2018-01-18 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Friday, January 19, 2018 10:50 AM > To: Zhang, Qi Z ; Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v2] net/i40e: fix fdir Rx resource defect > > FDIR Rx ring isn't initialized and Rx queue HW tail isn't updated > wh

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

2018-01-18 Thread Zhao1, Wei
Commit second time to cc sta...@dpdk.org https://dpdk.org/dev/patchwork/patch/34065/ > -Original Message- > From: Zhao1, Wei > Sent: Friday, January 19, 2018 11:15 AM > To: 'Thomas Monjalon' > Cc: Zhang, Helin ; dev@dpdk.org; Mcnamara, John > ; Yigit, Ferruh ; Xing, > Beilei > Subject:

[dpdk-dev] [PATCH v4] doc: add queue region feature info to release notes

2018-01-18 Thread Wei Zhao
This patch add inforation about i40e queue region realted to release notes, it has been missed before in v17.11 release notes. This feature has been implemented in v17.11. Signed-off-by: Wei Zhao --- v2: -change this information to v18.02 release notes. v3: -rework it on dpdk-next-net-intel su

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

2018-01-18 Thread Zhao1, Wei
Hi, Thomas Thank you! After discussion with Beilei, I have commit a new patch v4. https://dpdk.org/dev/patchwork/patch/33956/ Beilei also commit another new patch, we are waiting for review by Mcnamara, John. Do you think this is ok? > -Original Message- > From: Thomas Monjalon [ma

[dpdk-dev] [PATCH] net/i40e/avf/ixgbe: remove unnecessary mbuf field initialization in PMD

2018-01-18 Thread Rosen Xu
Set the value of m->refcnt to 1, m->nb_segs to 1 and m->next to NULL when the mbuf is initialized or stored inside the mempool (unused). All of these are done in rte_pktmbuf_pool_create() and rte_pktmbuf_prefree_seg(). So we remove the redundant code from i40e, ixgbe and avf module. Fixes: 8f094a

Re: [dpdk-dev] [PATCH V12 1/3] eal: add uevent monitor api and callback func

2018-01-18 Thread Guo, Jia
On 1/19/2018 9:13 AM, Thomas Monjalon wrote: 18/01/2018 05:12, Jeff Guo: + * It registers the callback for the specific device. + * Multiple callbacks cal be registered at the same time. + * + * @param device_name + * The device name, that is the param name of the struct rte_device, Why not

[dpdk-dev] [PATCH v2] net/i40e: fix fdir Rx resource defect

2018-01-18 Thread Beilei Xing
FDIR Rx ring isn't initialized and Rx queue HW tail isn't updated when there's error detected during programming FDIR flow. There'll be some potential risk. This patch updates FDIR Rx resource. Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director") Fixes: 05999aab4ca6 ("i40e: add or del

Re: [dpdk-dev] [PATCH v8 3/3] ring: introduce new header file to support C11 memory model

2018-01-18 Thread Jia He
On 1/19/2018 7:52 AM, Thomas Monjalon Wrote: 17/01/2018 10:09, Thomas Monjalon: 17/01/2018 09:47, Jia He: Hi Thomas On 1/17/2018 4:24 PM, Thomas Monjalon Wrote: 17/01/2018 05:03, Jia He: To support C11 memory model barrier, 2 options are suggested by Jerin: 1. use rte_smp_rmb 2. use load_a

[dpdk-dev] [PATCH v3] doc: fix link bonding PMD typo in prog guide

2018-01-18 Thread Zhiyong Yang
fix one typo and a grammatical mistake. Fixes: b0152b1b40fe ("doc: update bonding") Cc: sta...@dpdk.org Signed-off-by: Zhiyong Yang Acked-by: Marko Kovacevic --- Changes in V3: use "similar capabilities" instead of "the similar capabilities" Changes in V2: Fix the title and fixline format iss

Re: [dpdk-dev] [PATCH] doc: fix link bonding pmd typo in prog guide

2018-01-18 Thread Yang, Zhiyong
Thanks, V3 will be coming soon. > -Original Message- > From: Kovacevic, Marko > Sent: Monday, January 15, 2018 7:22 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: Mcnamara, John > Subject: RE: [dpdk-dev] [PATCH] doc: fix link bonding pmd typo in prog guide > > Actually just one more change

Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting VM2VM scenario

2018-01-18 Thread Yang, Zhiyong
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Thursday, January 18, 2018 5:04 PM > To: Yang, Zhiyong ; dev@dpdk.org; > y...@fridaylinux.org > Cc: Wang, Wei W ; Tan, Jianfeng > > Subject: Re: [PATCH 00/11] net/vhostpci: A new vhostpci P

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-18 Thread Neil Horman
On Thu, Jan 18, 2018 at 08:21:34PM +, Matan Azrad wrote: > Hi Neil. > > From: Neil Horman, Thursday, January 18, 2018 8:42 PM > > > > > > But thats not all. The determination of success or failure in > > > > claiming ownership is largely dependent on the behavior of other > > > > threads ac

Re: [dpdk-dev] [PATCH V12 1/3] eal: add uevent monitor api and callback func

2018-01-18 Thread Thomas Monjalon
18/01/2018 05:12, Jeff Guo: > + * It registers the callback for the specific device. > + * Multiple callbacks cal be registered at the same time. > + * > + * @param device_name > + * The device name, that is the param name of the struct rte_device, Why not using rte_device pointer? > + * null v

Re: [dpdk-dev] [PATCH V11 1/3] eal: add uevent monitor api and callback func

2018-01-18 Thread Thomas Monjalon
18/01/2018 05:23, Guo, Jia: > > On 1/18/2018 5:59 AM, Thomas Monjalon wrote: > > 15/01/2018 11:48, Jeff Guo: > >> + * It registers the callback for the specific event. Multiple > >> + * callbacks cal be registered at the same time. > >> + * > >> + * @param device_name > >> + * The device name. >

Re: [dpdk-dev] [PATCH v5 0/5] Introducing Wirless Base Band Device (bbdev) abstraction library

2018-01-18 Thread Thomas Monjalon
11/01/2018 20:23, Amr Mokhtar: > Hello, > Latest update for Wireless Device abstraction library. Applied with few changes: - fixed title formats - moved bbdev between ethdev and cryptodev in lists - added in test-build.sh - fixed compilation as shared library (must be better fixed in RC2)

[dpdk-dev] [PATCH v3 8/8] net/mlx5: fix synchonization on polling Rx completions

2018-01-18 Thread Yongseok Koh
Polling a new packet is basically sensing the generation bit in a completion entry. For some processors not having strongly-ordered memory model, there has to be an IO memory barrier between reading the generation bit and other fields of the entry in order to guarantee data is not stale. Fixes: 57

[dpdk-dev] [PATCH v3 6/8] net/mlx5: remove unnecessary memory barrier

2018-01-18 Thread Yongseok Koh
As rte_write64() has an IO barrier, there's no need to have a barrier before the call. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 950472754..11438c86a 100644 --- a/

[dpdk-dev] [PATCH v3 5/8] eal/arm64: define DMA memory barriers

2018-01-18 Thread Yongseok Koh
Cc: Thomas Speier Signed-off-by: Yongseok Koh Acked-by: Thomas Speier Acked-by: Jianbo Liu --- lib/librte_eal/common/include/arch/arm/rte_atomic_64.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_64.h b/lib/librte_eal/common/include

[dpdk-dev] [PATCH v3 7/8] net/mlx5: replace IO memory barrier with DMA memory barrier

2018-01-18 Thread Yongseok Koh
Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- drivers/net/mlx5/mlx5_rxtx.h | 2 +- drivers/net/mlx5/mlx5_rxtx_vec.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 3b8f71c28..

[dpdk-dev] [PATCH v3 4/8] eal/armv7: define DMA memory barriers

2018-01-18 Thread Yongseok Koh
Signed-off-by: Yongseok Koh Acked-by: Jianbo Liu --- lib/librte_eal/common/include/arch/arm/rte_atomic_32.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/common/include/arch/arm/rte_atomic_32.h b/lib/librte_eal/common/include/arch/arm/rte_atomic_32.h index 14c048640..a4

[dpdk-dev] [PATCH v3 3/8] eal/ppc64: define DMA memory barriers

2018-01-18 Thread Yongseok Koh
Signed-off-by: Yongseok Koh --- lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h index 150810cdb..46490f2b3 100644 --- a/l

[dpdk-dev] [PATCH v3 2/8] eal/x86: define DMA memory barriers

2018-01-18 Thread Yongseok Koh
Signed-off-by: Yongseok Koh --- lib/librte_eal/common/include/arch/x86/rte_atomic.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_eal/common/include/arch/x86/rte_atomic.h b/lib/librte_eal/common/include/arch/x86/rte_atomic.h index 36cfabc38..ae41e615f 100644 --- a/lib/librte

[dpdk-dev] [PATCH v3 1/8] eal: introduce DMA memory barriers

2018-01-18 Thread Yongseok Koh
This commit introduces rte_dma_wmb() and rte_dma_rmb(), in order to guarantee the ordering of coherent shared memory between the CPU and a DMA capable device. Signed-off-by: Yongseok Koh --- lib/librte_eal/common/include/generic/rte_atomic.h | 52 ++ 1 file changed, 52 insert

[dpdk-dev] [PATCH v3 0/8] introduce DMA memory barriers

2018-01-18 Thread Yongseok Koh
This patchset is to introduce DMA memory barriers, which could be more efficient for coherent memory between I/O device and CPU, especially for ARMv8. v3: * add more detailed comments about the new memory barriers. v2: * introduce DMA memory barriers. Yongseok Koh (8): eal: introduce DMA memor

Re: [dpdk-dev] [PATCH v5 3/5] bbdev: software turbo driver

2018-01-18 Thread Thomas Monjalon
11/01/2018 20:23, Amr Mokhtar: > +export DIR_WIRELESS_SDK=/FlexRAN-1.3.0/SDK-R1.3.0/sdk/ This variable looks to be unused. Adding this in test-build.sh (while applying): test -z "$FLEXRAN_SDK" || \ sed -ri 's,(BBDEV_TURBO_SW=)n,\1y,' $1/.config

Re: [dpdk-dev] [PATCH v6 08/23] eventtimer: add adapter start/stop definitions

2018-01-18 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Thursday, January 11, 2018 11:29 AM > To: Carrillo, Erik G ; > jerin.ja...@caviumnetworks.com; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v6 08/23] eve

Re: [dpdk-dev] [PATCH v5] arch/arm: optimization for memcpy on AArch64

2018-01-18 Thread Thomas Monjalon
Ping Are we targetting to integrate this optimization in DPDK 18.02? I am expecting a v6, thanks. 15/01/2018 12:37, Thomas Monjalon: > 15/01/2018 11:57, Herbert Guan: > > Hi Thomas, > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Hi, > > > > > > All the code is using ARM64, but

Re: [dpdk-dev] [PATCH v8 3/3] ring: introduce new header file to support C11 memory model

2018-01-18 Thread Thomas Monjalon
17/01/2018 10:09, Thomas Monjalon: > 17/01/2018 09:47, Jia He: > > > > Hi Thomas > > > > On 1/17/2018 4:24 PM, Thomas Monjalon Wrote: > > > 17/01/2018 05:03, Jia He: > > >> To support C11 memory model barrier, 2 options are suggested by Jerin: > > >> 1. use rte_smp_rmb > > >> 2. use load_acquire/

Re: [dpdk-dev] [PATCH v7 3/3] test: add tests for reciprocal based division

2018-01-18 Thread Thomas Monjalon
04/12/2017 14:22, Pavan Nikhilesh: > +/* > + * BSD LICENSE > + * > + * Copyright (C) Cavium, Inc. 2017. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * *

Re: [dpdk-dev] [PATCH 3/3] net: run-time function selection

2018-01-18 Thread Thomas Monjalon
11/12/2017 16:31, Bruce Richardson: > On Mon, Nov 06, 2017 at 10:05:43AM -0800, Elza Mathew wrote: > > Compile-time function selection can potentially lead to > > lower performance on generic builds done by distros. > > Replaced compile time flag checks with run-time > > function selection. > > >

Re: [dpdk-dev] [PATCH v2] member: fix memory leak on error

2018-01-18 Thread Thomas Monjalon
> >rte_member may have allocated a tailq entry or setum before failure, > >so free them. > > > >Fixes: 857ed6c68cf2 ("member: implement main API") Cc: sta...@dpdk.org > >Cc: yipeng1.w...@intel.com > >Signed-off-by: Anatoly Burakov > > Acked-by: Yipeng Wang Applied, thanks

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/failsafe: fix calling device during RMV events

2018-01-18 Thread Gaëtan Rivet
On Thu, Jan 18, 2018 at 11:22:51PM +0100, Thomas Monjalon wrote: > 29/11/2017 20:17, Ferruh Yigit: > > >>> On Thu, Oct 05, 2017 at 10:42:08PM +, Ophir Munk wrote: > > This commit prevents control path operations from failing after a sub > > device removal. > > > > Following

Re: [dpdk-dev] [dpdk-stable] [PATCH] mempool/octeontx: fix natural alignment being optimized out

2018-01-18 Thread Thomas Monjalon
18/01/2018 17:54, santosh: > On Thursday 18 January 2018 07:14 PM, Pavan Nikhilesh wrote: > > The mbox messages are naturally aligned and in some cases compiler > > optimization might disregard natural alignment. > > Use volatile key word to force compiler to disable optimizing and > > maintain ali

Re: [dpdk-dev] [PATCH] test/test_flow_classify: fix build warning

2018-01-18 Thread Thomas Monjalon
18/01/2018 16:18, Jasvinder Singh: > Move all static variables defined in header file to c file. > > error log: /usr/bin/ld: Warning: size of symbol 'count' changed > from 8 in test_pmd_perf.o to 24 in test_flow_classify.o > > Fixes: 50bdac5916d9 ("flow_classify: remove table id parameter from

Re: [dpdk-dev] [PATCH v2] mempool/dpaa: optimize phy to virt conversion

2018-01-18 Thread Thomas Monjalon
17/01/2018 09:51, Hemant Agrawal: > If the allocation is from a single memzone, optimize > the phy-virt address conversions. > > Signed-off-by: Hemant Agrawal > --- > v2: use register memory area instead of new flag in mempool Applied, thanks

Re: [dpdk-dev] [PATCH v4] mbuf: fix mbuf free performance with non atomic refcnt

2018-01-18 Thread Thomas Monjalon
08/12/2017 16:46, Olivier Matz: > When RTE_MBUF_REFCNT_ATOMIC=n, the decrement of the mbuf reference > counter uses an atomic operation. This is not necessary and impacts > the performance (seen with TRex traffic generator). > > We cannot replace rte_atomic16_add_return() by rte_mbuf_refcnt_update

Re: [dpdk-dev] [PATCH v6 15/23] eventtimer: add buffering of timer expiry events

2018-01-18 Thread Carrillo, Erik G
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Thursday, January 11, 2018 6:19 AM > To: Carrillo, Erik G ; > jerin.ja...@caviumnetworks.com; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v6 15/23] eventt

Re: [dpdk-dev] [PATCH v6 3/8] net/failsafe: add probed etherdev capture

2018-01-18 Thread Thomas Monjalon
18/01/2018 14:51, Matan Azrad: > Previous fail-safe code didn't support probed sub-devices capture and > failed when it tried to probe them. > > Skip fail-safe sub-device probing when it already was probed. > > Signed-off-by: Matan Azrad > Cc: Gaetan Rivet Was acked by Gaetan in v5.

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/failsafe: fix calling device during RMV events

2018-01-18 Thread Thomas Monjalon
29/11/2017 20:17, Ferruh Yigit: > >>> On Thu, Oct 05, 2017 at 10:42:08PM +, Ophir Munk wrote: > This commit prevents control path operations from failing after a sub > device removal. > > Following are the failure steps: > 1. The physical device is removed due to change

Re: [dpdk-dev] [PATCH v3 4/7] ethdev: synchronize port allocation

2018-01-18 Thread Thomas Monjalon
18/01/2018 21:52, Matan Azrad: > From: Thomas Monjalon, Thursday, January 18, 2018 10:44 PM > > 18/01/2018 17:35, Matan Azrad: > > > rte_eth_dev_allocate(const char *name) { > > > uint16_t port_id; > > > - struct rte_eth_dev *eth_dev; > > > + struct rte_eth_dev *eth_dev = NULL

Re: [dpdk-dev] [PATCH v3 3/7] ethdev: add port ownership

2018-01-18 Thread Thomas Monjalon
18/01/2018 17:35, Matan Azrad: > The ownership of a port is implicit in DPDK. > Making it explicit is better from the next reasons: > 1. It will define well who is in charge of the port usage synchronization. > 2. A library could work on top of a port. > 3. A port can work on top of another port. >

Re: [dpdk-dev] [PATCH v3 4/7] ethdev: synchronize port allocation

2018-01-18 Thread Matan Azrad
From: Thomas Monjalon, Thursday, January 18, 2018 10:44 PM > 18/01/2018 17:35, Matan Azrad: > > rte_eth_dev_allocate(const char *name) { > > uint16_t port_id; > > - struct rte_eth_dev *eth_dev; > > + struct rte_eth_dev *eth_dev = NULL; > > + > > + /* Synchronize share

Re: [dpdk-dev] [PATCH v3 4/7] ethdev: synchronize port allocation

2018-01-18 Thread Thomas Monjalon
18/01/2018 17:35, Matan Azrad: > rte_eth_dev_allocate(const char *name) > { > uint16_t port_id; > - struct rte_eth_dev *eth_dev; > + struct rte_eth_dev *eth_dev = NULL; > + > + /* Synchronize share data one time allocation between local threads. > */ I don't understand

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-18 Thread Matan Azrad
Hi Neil. From: Neil Horman, Thursday, January 18, 2018 8:42 PM > > > But thats not all. The determination of success or failure in > > > claiming ownership is largely dependent on the behavior of other > > > threads actions, not a function of the state of the system at the moment > ownership is

Re: [dpdk-dev] [PATCH v4 6/8] net/vdev_netvsc: skip routed netvsc probing

2018-01-18 Thread Thomas Monjalon
18/01/2018 19:26, Stephen Hemminger: > On Thu, 18 Jan 2018 08:43:44 + > Matan Azrad wrote: > > > NetVSC netdevices which are already routed should not be probed because > > they are used for management purposes by the HyperV. > > > > prevent routed netvsc devices probing. > > > > Signed-off

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-18 Thread Neil Horman
On Thu, Jan 18, 2018 at 05:20:31PM +, Matan Azrad wrote: > Hi Neil > > From: Neil Horman, Thursday, January 18, 2018 6:55 PM > > On Thu, Jan 18, 2018 at 02:00:23PM +, Matan Azrad wrote: > > > Hi Neil > > > > > > From: Neil Horman, Thursday, January 18, 2018 3:10 PM > > > > On Wed, Jan 17,

Re: [dpdk-dev] [PATCH v4 7/8] net/vdev_netvsc: add "force" parameter

2018-01-18 Thread Matan Azrad
From: Stephen Hemminger, Thursday, January 18, 2018 8:28 PM > On Thu, 18 Jan 2018 08:43:45 + > Matan Azrad wrote: > > > This parameter allows specifying any non-NetVSC interface or routed > > NetVSC interfaces to use with tap sub-devices for development purposes. > > > > Signed-off-by: Adri

Re: [dpdk-dev] [PATCH v4 5/8] net/vdev_netvsc: implement core functionality

2018-01-18 Thread Matan Azrad
From: Stephen Hemminger, Thursday, January 18, 2018 8:26 PM > On Thu, 18 Jan 2018 08:43:43 + > Matan Azrad wrote: > > > + > > +/** > > + * Alarm callback that regularly probes system network interfaces. > > + * > > + * This callback runs at a frequency determined by > > +VDEV_NETVSC_PROBE_M

Re: [dpdk-dev] [PATCH v4 7/8] net/vdev_netvsc: add "force" parameter

2018-01-18 Thread Stephen Hemminger
On Thu, 18 Jan 2018 08:43:45 + Matan Azrad wrote: > This parameter allows specifying any non-NetVSC interface or routed > NetVSC interfaces to use with tap sub-devices for development purposes. > > Signed-off-by: Adrien Mazarguil > Signed-off-by: Matan Azrad Might whitelist work for this?

Re: [dpdk-dev] [PATCH v4 6/8] net/vdev_netvsc: skip routed netvsc probing

2018-01-18 Thread Stephen Hemminger
On Thu, 18 Jan 2018 08:43:44 + Matan Azrad wrote: > NetVSC netdevices which are already routed should not be probed because > they are used for management purposes by the HyperV. > > prevent routed netvsc devices probing. > > Signed-off-by: Raslan Darawsheh > Signed-off-by: Matan Azrad J

Re: [dpdk-dev] [PATCH v4 5/8] net/vdev_netvsc: implement core functionality

2018-01-18 Thread Stephen Hemminger
On Thu, 18 Jan 2018 08:43:43 + Matan Azrad wrote: > + > +/** > + * Alarm callback that regularly probes system network interfaces. > + * > + * This callback runs at a frequency determined by VDEV_NETVSC_PROBE_MS as > + * long as an vdev_netvsc context instance exists. > + * > + * @param arg >

Re: [dpdk-dev] [PATCH v2 1/8] eal: introduce DMA memory barriers

2018-01-18 Thread Yongseok Koh
> On Jan 18, 2018, at 3:56 AM, Andrew Rybchenko > wrote: > > On 01/17/2018 09:39 PM, Yongseok Koh wrote: >>> On Jan 17, 2018, at 5:46 AM, Thomas Monjalon wrote: >>> >>> 16/01/2018 10:10, Jianbo Liu: The 01/16/2018 10:49, Andrew Rybchenko wrote: > On 01/16/2018 04:10 AM, Yongseok Koh

Re: [dpdk-dev] [PATCH v6 4/6] ethdev: adjust APIs removal error report

2018-01-18 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit, Thursday, January 18, 2018 7:31 PM > On 1/18/2018 11:27 AM, Matan Azrad wrote: > > rte_eth_dev_is_removed API was added to detect a device removal > > synchronously. > > > > When a device removal occurs during control command execution, many > > different errors can b

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: add devop to check removal status

2018-01-18 Thread Matan Azrad
Hi Ferruh From: Ferruh Yigit, Thursday, January 18, 2018 7:18 PM > On 1/18/2018 11:27 AM, Matan Azrad wrote: > > There is time between the physical removal of the device until PMDs > > get a RMV interrupt. At this time DPDK PMDs and applications still > > don't know about the removal. > > > > Curr

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: add devop to check removal status

2018-01-18 Thread Adrien Mazarguil
On Thu, Jan 18, 2018 at 05:18:22PM +, Ferruh Yigit wrote: > On 1/18/2018 11:27 AM, Matan Azrad wrote: > > There is time between the physical removal of the device until PMDs get > > a RMV interrupt. At this time DPDK PMDs and applications still don't > > know about the removal. > > > > Current

Re: [dpdk-dev] [PATCH v6 4/6] ethdev: adjust APIs removal error report

2018-01-18 Thread Ferruh Yigit
On 1/18/2018 11:27 AM, Matan Azrad wrote: > rte_eth_dev_is_removed API was added to detect a device removal > synchronously. > > When a device removal occurs during control command execution, many > different errors can be reported to the user. > > Adjust all ethdev APIs error reports to return -

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-18 Thread Matan Azrad
Hi Neil From: Neil Horman, Thursday, January 18, 2018 6:55 PM > On Thu, Jan 18, 2018 at 02:00:23PM +, Matan Azrad wrote: > > Hi Neil > > > > From: Neil Horman, Thursday, January 18, 2018 3:10 PM > > > On Wed, Jan 17, 2018 at 05:01:10PM +, Ananyev, Konstantin wrote: > > > > > > > > > > > >

Re: [dpdk-dev] [PATCH v6 1/6] ethdev: add devop to check removal status

2018-01-18 Thread Ferruh Yigit
On 1/18/2018 11:27 AM, Matan Azrad wrote: > There is time between the physical removal of the device until PMDs get > a RMV interrupt. At this time DPDK PMDs and applications still don't > know about the removal. > > Current removal detection is achieved only by registration to device RMV > event

Re: [dpdk-dev] [PATCH v3 2/7] ethdev: fix used portid allocation

2018-01-18 Thread Thomas Monjalon
18/01/2018 17:35, Matan Azrad: > rte_eth_dev_find_free_port() found a free port by state checking. > The state field are in local process memory, so other DPDK processes > may get the same port ID because their local states may be different. > > Replace the state checking by the ethdev port name c

Re: [dpdk-dev] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-01-18 Thread Thomas Monjalon
18/01/2018 17:35, Matan Azrad: > rte_eth_dev_data structure is allocated per ethdev port and can be > used to get a data of the port internally. > > rte_eth_dev_attach_secondary tries to find the port identifier using > rte_eth_dev_data name field comparison and may get an identifier of > invalid

Re: [dpdk-dev] [PATCH v6 3/6] net/mlx5: support a device removal check operation

2018-01-18 Thread Adrien Mazarguil
On Thu, Jan 18, 2018 at 11:27:11AM +, Matan Azrad wrote: > Add support to get removal status of mlx5 device. > It is not supported in secondary process. > > Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND

Re: [dpdk-dev] [PATCH v6 2/6] net/mlx4: support a device removal check operation

2018-01-18 Thread Adrien Mazarguil
On Thu, Jan 18, 2018 at 11:27:10AM +, Matan Azrad wrote: > Add support to get removal status of mlx4 device. > > Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-18 Thread Neil Horman
On Thu, Jan 18, 2018 at 02:00:23PM +, Matan Azrad wrote: > Hi Neil > > From: Neil Horman, Thursday, January 18, 2018 3:10 PM > > On Wed, Jan 17, 2018 at 05:01:10PM +, Ananyev, Konstantin wrote: > > > > > > > > > > -Original Message- > > > > From: Neil Horman [mailto:nhor...@tuxdriv

Re: [dpdk-dev] [PATCH] mempool/octeontx: fix natural alignment being optimized out

2018-01-18 Thread santosh
On Thursday 18 January 2018 07:14 PM, Pavan Nikhilesh wrote: > The mbox messages are naturally aligned and in some cases compiler > optimization might disregard natural alignment. > Use volatile key word to force compiler to disable optimizing and > maintain alignment. > > Fixes: aecb8e093b52 ("ev

Re: [dpdk-dev] [PATCH] test/test_flow_classify: fix build warning

2018-01-18 Thread Ferruh Yigit
On 1/18/2018 3:18 PM, Jasvinder Singh wrote: > Move all static variables defined in header file to c file. > > error log: /usr/bin/ld: Warning: size of symbol 'count' changed > from 8 in test_pmd_perf.o to 24 in test_flow_classify.o > > Fixes: 50bdac5916d9 ("flow_classify: remove table id param

Re: [dpdk-dev] [PATCH v2] net/thunderx: Convert ThunderX VNIC PMD to new offload API

2018-01-18 Thread Ferruh Yigit
On 1/18/2018 1:06 PM, maciej.cze...@caviumnetworks.com wrote: > From: Maciej Czekaj Author fixed as "Maciej Czekaj " s/caviunetworks/caviumnetworks > > This patch removes all references to old-style offload API > replacing them with new offload flags. > > Signed-off-by: Maciej Czekaj Applie

[dpdk-dev] [PATCH v3 6/7] net/failsafe: use ownership mechanism to own ports

2018-01-18 Thread Matan Azrad
Fail-safe PMD sub devices management is based on ethdev port mechanism. So, the sub-devices management structures are exposed to other DPDK entities which may use them in parallel to fail-safe PMD. Use the new port ownership mechanism to avoid multiple managments of fail-safe PMD sub-devices. Sig

[dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-18 Thread Matan Azrad
Testpmd should not use ethdev ports which are managed by other DPDK entities. Set Testpmd ownership to each port which is not used by other entity and prevent any usage of ethdev ports which are not owned by Testpmd. Signed-off-by: Matan Azrad --- app/test-pmd/cmdline.c | 89 ++

[dpdk-dev] [PATCH v3 5/7] net/failsafe: free an eth port by a dedicated API

2018-01-18 Thread Matan Azrad
Call dedicated ethdev API to free port in remove time as was done in other fail-safe places. Signed-off-by: Matan Azrad Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ether.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_ether.c b/d

[dpdk-dev] [PATCH v3 4/7] ethdev: synchronize port allocation

2018-01-18 Thread Matan Azrad
Ethernet port allocation was not thread safe, means 2 threads which tried to allocate a new port at the same time might get an identical port identifier and caused to memory overwrite. Actually, all the port configurations were not thread safe from ethdev point of view. The port ownership mechanis

[dpdk-dev] [PATCH v3 3/7] ethdev: add port ownership

2018-01-18 Thread Matan Azrad
The ownership of a port is implicit in DPDK. Making it explicit is better from the next reasons: 1. It will define well who is in charge of the port usage synchronization. 2. A library could work on top of a port. 3. A port can work on top of another port. Also in the fail-safe case, an issue has

[dpdk-dev] [PATCH v3 1/7] ethdev: fix port data reset timing

2018-01-18 Thread Matan Azrad
rte_eth_dev_data structure is allocated per ethdev port and can be used to get a data of the port internally. rte_eth_dev_attach_secondary tries to find the port identifier using rte_eth_dev_data name field comparison and may get an identifier of invalid port in case of this port was released by t

[dpdk-dev] [PATCH v3 0/7] Port ownership and syncronization

2018-01-18 Thread Matan Azrad
Add ownership mechanism to DPDK Ethernet devices to avoid multiple management of a device by different DPDK entities. The port ownership mechanism is a good point to redefine the synchronization rules in ethdev: 1. The port allocation and port release synchronization will be managed by

[dpdk-dev] [PATCH v3 2/7] ethdev: fix used portid allocation

2018-01-18 Thread Matan Azrad
rte_eth_dev_find_free_port() found a free port by state checking. The state field are in local process memory, so other DPDK processes may get the same port ID because their local states may be different. Replace the state checking by the ethdev port name checking, so, if the name is an empty stri

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-18 Thread Neil Horman
On Wed, Jan 17, 2018 at 05:01:10PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Neil Horman [mailto:nhor...@tuxdriver.com] > > Sent: Wednesday, January 17, 2018 2:00 PM > > To: Matan Azrad > > Cc: Ananyev, Konstantin ; Thomas Monjalon > > ; Gaetan Rivet > > ; W

Re: [dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd

2018-01-18 Thread Ferruh Yigit
On 1/18/2018 10:57 AM, Tomasz Duszynski wrote: > This patch-set contains a couple of changes which let the application > using pmd to set mtu and mac addresses before port is initialized. > > Tomasz Duszynski (2): > net/mrvl: allow changing MTU before port init > net/mrvl: allow adding ether a

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix allocation when no memory on device NUMA node

2018-01-18 Thread Nélio Laranjeiro
On Thu, Jan 18, 2018 at 02:00:43PM +0100, Olivier Matz wrote: > If there is no memory available on the same numa node than the > device, it is preferable to fallback on another socket instead > of failing. > > Fixes: 1e3a39f72d5d ("net/mlx5: allocate verbs object into shared memory") > Cc: sta...@

[dpdk-dev] [PATCH] examples/ipsec-secgw: try end in flow actions before fail

2018-01-18 Thread Radu Nicolau
After trying RSS and Queue also try End for flow action to allow for HW that don't support flow features with inline crypto. Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-18 Thread Olivier Matz
On Thu, Jan 18, 2018 at 05:04:27PM +0100, Nélio Laranjeiro wrote: > On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote: > > On error, mlx5_dev_start() does not return a negative value > > as it is supposed to do. The consequence is that the application > > (ex: testpmd) does not notice th

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-18 Thread Nélio Laranjeiro
On Thu, Jan 18, 2018 at 02:00:42PM +0100, Olivier Matz wrote: > On error, mlx5_dev_start() does not return a negative value > as it is supposed to do. The consequence is that the application > (ex: testpmd) does not notice that the port is not started > and begins the rxtx on an uninitialized port,

Re: [dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Olivier Matz
On Thu, Jan 18, 2018 at 11:48:09PM +0800, Tiwei Bie wrote: > On Thu, Jan 18, 2018 at 03:55:53PM +0100, Olivier Matz wrote: > > On Thu, Jan 18, 2018 at 10:05:49PM +0800, Tiwei Bie wrote: > > > On Thu, Jan 18, 2018 at 10:07:32AM +0100, Olivier Matz wrote: > > > > Rationalize the function virtio_dev_f

[dpdk-dev] [PATCH v3 3/3] examples/ipsec_secgw: create session mempools for ethdevs

2018-01-18 Thread Radu Nicolau
Also moved offloaded packets from cryptodev queues Signed-off-by: Radu Nicolau Reviewed-by: Akhil Goyal --- examples/ipsec-secgw/ipsec-secgw.c | 42 +- examples/ipsec-secgw/ipsec.c | 12 --- examples/ipsec-secgw/ipsec.h | 4 ++-- 3 files

[dpdk-dev] [PATCH v3 1/3] security: add get session size function

2018-01-18 Thread Radu Nicolau
Add function to get security session size. Signed-off-by: Radu Nicolau --- lib/librte_security/rte_security.c | 7 +++ lib/librte_security/rte_security.h | 12 lib/librte_security/rte_security_driver.h| 14 ++ lib/librte_security/rte_security

  1   2   3   >