Re: [dpdk-dev] [DPDK] lib/librte_ether: add comments RSS flags

2018-01-06 Thread Shahaf Shuler
Saturday, January 6, 2018 12:22 PM, Andrew Rybchenko: [..] > > #define ETH_RSS_PORT (1ULL << RTE_ETH_FLOW_PORT) > > +/** Enable RSS offload on VXLAN packets */ > > #define ETH_RSS_VXLAN (1ULL << RTE_ETH_FLOW_VXLAN) > > +/** Enable RSS offload on GENEVE packets */ >

[dpdk-dev] [PATCH v6 3/3] net/virtio: support GUEST ANNOUNCE

2018-01-06 Thread Xiao Wang
When live migration is done, for the backup VM, either the virtio frontend or the vhost backend needs to send out gratuitous RARP packet to announce its new network location. This patch enables VIRTIO_NET_F_GUEST_ANNOUNCE feature to support live migration scenario where the vhost backend doesn't h

[dpdk-dev] [PATCH v6 2/3] net/virtio: add packet injection method

2018-01-06 Thread Xiao Wang
This patch adds dev_pause, dev_resume and inject_pkts api to allow driver to pause the worker threads and inject special packets into Tx queue. The next patch will be based on this. Signed-off-by: Xiao Wang --- drivers/net/virtio/virtio_ethdev.c | 56 + drive

[dpdk-dev] [PATCH v6 0/3] net/virtio: support GUEST ANNOUNCE

2018-01-06 Thread Xiao Wang
v6: - Use rte_pktmbuf_alloc() instead of rte_mbuf_raw_alloc(). - Remove the 'len' parameter in calling virtio_send_command(). - Remove extra space between typo and var. - Improve comment and alignment. - Remove the unnecessary header file. - A better usage of 'unlikely' indication. v5: - Remove tx

[dpdk-dev] [PATCH v6 1/3] net/virtio: make control queue thread-safe

2018-01-06 Thread Xiao Wang
The virtio_send_command function may be called from app's configuration routine, but also from an interrupt handler called when live migration is done on the backup side. So this patch makes control queue thread-safe first. Signed-off-by: Xiao Wang --- drivers/net/virtio/virtio_ethdev.c | 7

Re: [dpdk-dev] [PATCH v5 2/3] net/virtio: add packet injection method

2018-01-06 Thread Wang, Xiao W
Hi, > -Original Message- > From: Bie, Tiwei > Sent: Saturday, January 6, 2018 2:01 AM > To: Wang, Xiao W > Cc: dev@dpdk.org; y...@fridaylinux.org; step...@networkplumber.org > Subject: Re: [PATCH v5 2/3] net/virtio: add packet injection method > > On Fri, Jan 05, 2018 at 08:46:56AM -0800

Re: [dpdk-dev] [PATCH v5 3/3] net/virtio: support GUEST ANNOUNCE

2018-01-06 Thread Wang, Xiao W
Hi > -Original Message- > From: Bie, Tiwei > Sent: Saturday, January 6, 2018 1:57 AM > To: Wang, Xiao W > Cc: dev@dpdk.org; y...@fridaylinux.org; step...@networkplumber.org > Subject: Re: [PATCH v5 3/3] net/virtio: support GUEST ANNOUNCE > > On Fri, Jan 05, 2018 at 08:46:57AM -0800, Xiao

Re: [dpdk-dev] [PATCH] doc: update IPSec Multi-buffer lib versioning

2018-01-06 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, December 19, 2017 9:28 AM > To: Mcnamara, John ; Doherty, Declan > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH] doc: update IPSec Multi-buffer lib versioning > > IPSec Multi-buffer library v0.48 has b

Re: [dpdk-dev] [PATCH v2 02/15] ethdev: add linkstatus get/set helper functions

2018-01-06 Thread Andrew Rybchenko
On 01/06/2018 05:24 PM, Stephen Hemminger wrote: On Sat, 6 Jan 2018 13:49:50 +0300 Andrew Rybchenko wrote: On 01/06/2018 04:06 AM, Stephen Hemminger wrote: +} + +void +_rte_eth_linkstatus_get(const struct rte_eth_dev *dev, + struct rte_eth_link *link) +{ + const ui

Re: [dpdk-dev] [PATCH v2 02/15] ethdev: add linkstatus get/set helper functions

2018-01-06 Thread Stephen Hemminger
On Sat, 6 Jan 2018 13:49:50 +0300 Andrew Rybchenko wrote: > On 01/06/2018 04:06 AM, Stephen Hemminger wrote: > > Many drivers are all doing copy/paste of the same code to atomically > > update the link status. Reduce duplication, and allow for future > > changes by having common function for this

Re: [dpdk-dev] [PATCH v1 1/5] rawdev: introduce raw device library support

2018-01-06 Thread Trahe, Fiona
Hi Shreyansh, This looks like a useful generic device, thanks. Some comments below. > -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Tuesday, January 2, 2018 12:58 PM > To: dev@dpdk.org > Cc: hemant.agra...@nxp.com; Trahe, Fiona ; Xu, Rosen > ; > Shreya

[dpdk-dev] [PATCH 9/9] tools: use SPDX tag for Cavium copyright files

2018-01-06 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- devtools/build-tags.sh | 30 ++ 1 file changed, 2 insertions(+), 28 deletions(-) diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh index 942da2bae..d775b17e9 100755 --- a/devtools/build-tags.sh +++ b/devtools/build-tags.sh @@

[dpdk-dev] [PATCH 8/9] config: use SPDX tag for Cavium copyright files

2018-01-06 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- config/common_armv8a_linuxapp| 31 ++-- config/defconfig_arm64-armv8a-linuxapp-clang | 31 ++-- config/defconfig_arm64-armv8a-linuxapp-gcc | 31 ++-- config/defconfig_arm64-thu

[dpdk-dev] [PATCH 7/9] doc: use SPDX tag for Cavium copyright files

2018-01-06 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- doc/guides/cryptodevs/armv8.rst| 31 ++-- doc/guides/eventdevs/octeontx.rst | 31 ++-- doc/guides/mempool/index.rst | 30 ++- doc/guides/mempool/octeontx.rst

[dpdk-dev] [PATCH 6/9] app: use SPDX tag for Cavium copyright files

2018-01-06 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- app/test-eventdev/Makefile| 30 ++ app/test-eventdev/evt_common.h| 32 ++-- app/test-eventdev/evt_main.c | 32 ++-- app/test-eventdev/evt_options.c

[dpdk-dev] [PATCH 4/9] examples: use SPDX tag for Cavium copyright files

2018-01-06 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- .../performance-thread/common/arch/arm64/ctx.c | 32 ++ .../performance-thread/common/arch/arm64/ctx.h | 32 ++ .../performance-thread/common/arch/arm64/stack.h | 32 ++ 3 files changed, 6 inserti

[dpdk-dev] [PATCH 3/9] lib: use SPDX tag for Cavium copyright files

2018-01-06 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- lib/librte_acl/acl_run_neon.c | 34 ++ lib/librte_acl/acl_run_neon.h | 34 ++ lib/librte_eal/common/arch/arm/rte_cycles.c| 32 ++-- .../common/include/arch/arm/

[dpdk-dev] [PATCH 5/9] drivers: use SPDX tag for Cavium copyright files

2018-01-06 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- drivers/crypto/armv8/Makefile | 32 ++- drivers/crypto/armv8/rte_armv8_pmd.c| 32 ++- drivers/crypto/armv8/rte_armv8_pmd_ops.c| 32 ++- drivers/crypto/armv8/rte_armv8_p

[dpdk-dev] [PATCH 2/9] mk: use SPDX tag for Cavium copyright files

2018-01-06 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- mk/arch/arm64/rte.vars.mk | 30 ++ mk/machine/armv8a/rte.vars.mk | 31 ++- mk/machine/thunderx/rte.vars.mk | 31 ++- mk/machine/xgene1/rte.vars.mk | 31 ++--

[dpdk-dev] [PATCH 1/9] test: use SPDX tag for Cavium copyright files

2018-01-06 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- test/test/test_bitmap.c| 32 ++-- test/test/test_eventdev.c | 32 ++-- test/test/test_eventdev_octeontx.c | 32 ++-- test/test/test_xmmt_ops.h | 33 ++--

Re: [dpdk-dev] [PATCH v2 09/15] sfc: use new rte_eth_linkstatus functions

2018-01-06 Thread Andrew Rybchenko
On 01/06/2018 04:06 AM, Stephen Hemminger wrote: Use the new API (_rte_eth_linkstatus_set) to handle link status update. Signed-off-by: Stephen Hemminger Many thanks. Good idea since the code is definitely shorter and easier to read/understand. The summary should be net/sfc:, not just sfc:.

Re: [dpdk-dev] [PATCH v2 02/15] ethdev: add linkstatus get/set helper functions

2018-01-06 Thread Andrew Rybchenko
On 01/06/2018 04:06 AM, Stephen Hemminger wrote: Many drivers are all doing copy/paste of the same code to atomically update the link status. Reduce duplication, and allow for future changes by having common function for this. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c

Re: [dpdk-dev] [DPDK] lib/librte_ether: add comments RSS flags

2018-01-06 Thread Andrew Rybchenko
On 01/04/2018 09:15 PM, Qiming Yang wrote: Detail the comment for RSS offload types and added comments for each type. Signed-off-by: Qiming Yang --- lib/librte_ether/rte_ethdev.h | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/lib/librte_eth