Re: [dpdk-dev] [PATCH v4 2/3] net/virtio: add packet injection method

2018-01-05 Thread Tiwei Bie
On Fri, Jan 05, 2018 at 12:27:37PM -0800, Stephen Hemminger wrote: > On Thu, 4 Jan 2018 07:59:37 -0800 > Xiao Wang wrote: > > > This patch adds dev_pause, dev_resume and inject_pkts api to allow > > driver to pause the worker thread and inject special packets into > > Tx queue. The next patch wi

Re: [dpdk-dev] [PATCH v2 03/15] virtio: use eth_linkstatus_set

2018-01-05 Thread Tiwei Bie
Hi Stephen, On Fri, Jan 05, 2018 at 05:06:44PM -0800, Stephen Hemminger wrote: > Use the new comon code in ethdev to handle link status update. Typo: comon -> common > > Signed-off-by: Stephen Hemminger [...] > static void > virtio_update_stats(struct rte_eth_dev *dev, struct rte_eth_stats *

[dpdk-dev] [PATCH v2 15/15] enic: use _rte_eth_linkstatus_set

2018-01-05 Thread Stephen Hemminger
This driver was not doing atomic update of link status information. And the return value was different than others. The hardware also does not do autonegotiation (at least on Linux). Signed-off-by: Stephen Hemminger --- drivers/net/enic/enic_ethdev.c | 5 ++--- drivers/net/enic/enic_main.c |

[dpdk-dev] [PATCH v2 14/15] octeontx: use rte_eth_linkstatus_set

2018-01-05 Thread Stephen Hemminger
Common function matches this drivers usage. Signed-off-by: Stephen Hemminger --- drivers/net/octeontx/octeontx_ethdev.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index bd24

[dpdk-dev] [PATCH v2 13/15] szedata: use _rte_eth_linkstatus_set

2018-01-05 Thread Stephen Hemminger
Yet another driver which was not returing correct value on link change. Since this driver can't be built on x86 could not even do a compile test. Signed-off-by: Stephen Hemminger --- drivers/net/szedata2/rte_eth_szedata2.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions

[dpdk-dev] [PATCH v2 11/15] liquidio: use _rte_eth_linkstatus_set

2018-01-05 Thread Stephen Hemminger
Use the new link update API, and cleanup the logic in the the link update routine. Tested-by: Shijith Thotton Signed-off-by: Stephen Hemminger --- drivers/net/liquidio/lio_ethdev.c | 54 ++- 1 file changed, 8 insertions(+), 46 deletions(-) diff --git a/drive

[dpdk-dev] [PATCH v2 10/15] i40e: use rte_eth_linkstatus functions

2018-01-05 Thread Stephen Hemminger
Use new rte_linkstatus update API Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev.c| 44 ++- drivers/net/i40e/i40e_ethdev_vf.c | 19 ++--- 2 files changed, 8 insertions(+), 55 deletions(-) diff --git a/drivers/net/i40e/i40e_e

[dpdk-dev] [PATCH v2 12/15] thunderx: use _rte_eth_linkstatus_set

2018-01-05 Thread Stephen Hemminger
Use new helper function. Signed-off-by: Stephen Hemminger --- drivers/net/thunderx/nicvf_ethdev.c | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c index d65d3cee727e..e41b379f3c9c 100

[dpdk-dev] [PATCH v2 09/15] sfc: use new rte_eth_linkstatus functions

2018-01-05 Thread Stephen Hemminger
Use the new API (_rte_eth_linkstatus_set) to handle link status update. Signed-off-by: Stephen Hemminger --- drivers/net/sfc/sfc_ethdev.c | 27 +++ drivers/net/sfc/sfc_ev.c | 23 --- 2 files changed, 11 insertions(+), 39 deletions(-) diff --git a/

[dpdk-dev] [PATCH v2 07/15] e1000: use rte_eth_linkstatus helpers

2018-01-05 Thread Stephen Hemminger
Use new rte_eth_linkstatus_get/set API. Signed-off-by: Stephen Hemminger --- drivers/net/e1000/em_ethdev.c | 70 +++-- drivers/net/e1000/igb_ethdev.c | 71 +++--- 2 files changed, 10 insertions(+), 131 deletions(-) diff --

[dpdk-dev] [PATCH v2 08/15] ixgbe: use rte_eth_linkstatus functions

2018-01-05 Thread Stephen Hemminger
Use the new helper functions from eth_dev for handling atomic link_info update. Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_ethdev.c | 99 +++- 1 file changed, 17 insertions(+), 82 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/

[dpdk-dev] [PATCH v2 06/15] nfp: use rte_eth_linkstatus functions

2018-01-05 Thread Stephen Hemminger
Use new _rte_eth_linkstatus_get/set helper function. Signed-off-by: Stephen Hemminger --- drivers/net/nfp/nfp_net.c | 75 +-- 1 file changed, 8 insertions(+), 67 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 050

[dpdk-dev] [PATCH v2 05/15] dpaa2: use rte_eth_linkstatus_set

2018-01-05 Thread Stephen Hemminger
Use new helper function to update the link status. As a good side effect this fixes a but because this driver was not returning correct status (should be -1 in link_status changed). Signed-off-by: Stephen Hemminger --- drivers/net/dpaa2/dpaa2_ethdev.c | 65 +--

[dpdk-dev] [PATCH v2 03/15] virtio: use eth_linkstatus_set

2018-01-05 Thread Stephen Hemminger
Use the new comon code in ethdev to handle link status update. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_ethdev.c | 67 -- 1 file changed, 14 insertions(+), 53 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/vi

[dpdk-dev] [PATCH v2 04/15] vmxnet3: use rte_eth_linkstatus_set

2018-01-05 Thread Stephen Hemminger
Use new _rte_eth_link_update helper. Also remove no longer necessary include of rte_atomic.h Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 85 +++- 1 file changed, 15 insertions(+), 70 deletions(-) diff --git a/drivers/net/vmxnet3/vm

[dpdk-dev] [PATCH v2 02/15] ethdev: add linkstatus get/set helper functions

2018-01-05 Thread Stephen Hemminger
Many drivers are all doing copy/paste of the same code to atomically update the link status. Reduce duplication, and allow for future changes by having common function for this. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 35 +++ lib/librt

[dpdk-dev] [PATCH v2 00/15] common ethdev linkstatus functions

2018-01-05 Thread Stephen Hemminger
While writing the hyperv driver, noticed a lot of unnecessary duplication of code in drivers for handling the eth_dev link status information. While consolidating this, it also became obvious that some drivers behave differently for no good reason. It also was a good chance to introduce atomic exc

[dpdk-dev] [PATCH v2 01/15] eal: introduce atomic exchange operation

2018-01-05 Thread Stephen Hemminger
To handle atomic update of link status (64 bit), every driver was doing its own version using cmpset. Atomic exchange is a useful primitive in its own right; therefore make it a EAL routine. Signed-off-by: Stephen Hemminger --- .../common/include/arch/x86/rte_atomic.h | 24 +++ ...

Re: [dpdk-dev] [PATCH] pci: don't use kernel version to determine MSIX defines

2018-01-05 Thread Thomas Monjalon
27/12/2017 19:25, Stephen Hemminger: > In real life, kernel version is only weakly corolated with presence > or absence of defines in header files. Instead, check directly if > the needed value is defined. > > Signed-off-by: Stephen Hemminger Applied, thanks

Re: [dpdk-dev] [PATCH] devtools: ignore checkpatch warning for maintainers file

2018-01-05 Thread Stephen Hemminger
On Fri, 5 Jan 2018 12:43:02 +0100 Thomas Monjalon wrote: > The script checkpatch.pl from Linux is enforcing a tab > in the MAINTAINERS file (Linux commit 628f91a28649). > It can be ignored in our wrapper checkpatches.sh. > > Suggested-by: Remy Horton > Signed-off-by: Thomas Monjalon > --- >

Re: [dpdk-dev] [PATCH 0/5] remove double parenthesis

2018-01-05 Thread Thomas Monjalon
15/12/2017 00:32, Stephen Hemminger: > Noticed in ethdev an obvious case of extra parenthesis so > went hunting for others as well. There seems to be some weird > coding standard that loves extra parenthesis (or developers > don't understand basic C precedence rules). > > Stephen Hemminger (5): >

Re: [dpdk-dev] [PATCH] ethdev: fix link autonegotiation value

2018-01-05 Thread Stephen Hemminger
On Fri, 5 Jan 2018 18:38:55 +0100 Thomas Monjalon wrote: > There are 3 kind of link data in ethdev: > - capabilities (rte_eth_dev_info) > - configuration (rte_eth_conf) > - status (rte_eth_link) > > A bit-field is used for capabilities (rte_eth_dev_info.speed_capa) and > confi

Re: [dpdk-dev] [PATCH v2 11/16] doc: add documents for AMD axgbe Ethernet PMD

2018-01-05 Thread Stephen Hemminger
On Fri, 5 Jan 2018 04:52:13 -0500 Ravi Kumar wrote: > Signed-off-by: Ravi Kumar > --- > doc/guides/nics/axgbe.rst | 211 > + > doc/guides/nics/features/axgbe.ini | 14 +++ > doc/guides/nics/index.rst | 1 + > 3 files changed, 226 insert

Re: [dpdk-dev] standardize device identification

2018-01-05 Thread Finn Christensen
>-Original Message- >From: Thomas Monjalon [mailto:tho...@monjalon.net] >Sent: 5. januar 2018 16:34 >To: Finn Christensen >Cc: dev@dpdk.org; Yuanhan Liu ; Adrien Mazarguil >; Ciara Loftus ; Kevin >Traynor ; step...@networkplumber.org; >ferruh.yi...@intel.com >Subject: Re: [dpdk-dev] stand

Re: [dpdk-dev] [PATCH v2 16/16] net/axgbe: add support for build 32-bit mode

2018-01-05 Thread Stephen Hemminger
On Fri, 5 Jan 2018 04:52:18 -0500 Ravi Kumar wrote: > Signed-off-by: Ravi Kumar > --- > doc/guides/nics/features/axgbe.ini | 1 + > drivers/net/axgbe/axgbe_common.h | 49 > ++ > drivers/net/axgbe/axgbe_ethdev.c | 10 > drivers/net/axgbe/axgbe_

Re: [dpdk-dev] [PATCH v4 02/15] net/avf: initialization of avf PMD

2018-01-05 Thread Stephen Hemminger
On Fri, 5 Jan 2018 16:21:32 +0800 Wenzhuo Lu wrote: > From: Jingjing Wu > > Signed-off-by: Jingjing Wu > --- > config/common_base | 5 + > drivers/net/Makefile| 1 + > drivers/net/avf/Makefile| 31 +++ > drivers/net/avf/avf.h

Re: [dpdk-dev] [PATCH v4 2/3] net/virtio: add packet injection method

2018-01-05 Thread Stephen Hemminger
On Thu, 4 Jan 2018 07:59:37 -0800 Xiao Wang wrote: > This patch adds dev_pause, dev_resume and inject_pkts api to allow > driver to pause the worker thread and inject special packets into > Tx queue. The next patch will be based on this. > > Signed-off-by: Xiao Wang Why is this needed? It isn

Re: [dpdk-dev] [PATCH v4 01/15] net/avf/base: add base code for avf PMD

2018-01-05 Thread Stephen Hemminger
O > diff --git a/drivers/net/avf/base/avf_adminq.c > b/drivers/net/avf/base/avf_adminq.c > new file mode 100644 > index 000..616e2a9 > --- /dev/null > +++ b/drivers/net/avf/base/avf_adminq.c > @@ -0,0 +1,1010 @@ > +/**

Re: [dpdk-dev] [RFC 00/14] link status API improvement and bugfixes

2018-01-05 Thread Stephen Hemminger
On Fri, 05 Jan 2018 15:29:09 +0100 Thomas Monjalon wrote: > 14/07/2017 20:30, Stephen Hemminger: > > While writing new driver, I noticed a lot of unnecessary duplication of > > code in drivers for handling the eth_dev link status information. While > > consolidating this, it also became obvious t

Re: [dpdk-dev] [RFC 01/14] ethdev: add link status read/write functions

2018-01-05 Thread Stephen Hemminger
On Fri, 05 Jan 2018 15:24:48 +0100 Thomas Monjalon wrote: > Stephen, > Qiming was suggesting a name change for the functions. > What do you think? > > 13/10/2017 17:12, Stephen Hemminger: > > On Wed, 11 Oct 2017 08:32:12 + > > "Yang, Qiming" wrote: > > > > > > From: dev [mailto:dev-boun.

Re: [dpdk-dev] [PATCH v2 04/10] app/testpmd: convert to new Ethdev Tx offloads API

2018-01-05 Thread Maciej Czekaj
-- Oryginal message -- Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") Convert the application to use the new API. This patch mandates the port to be stopped when configure the Tx offloads. This is because the PMD must be aware to the

Re: [dpdk-dev] [PATCH v5 2/3] net/virtio: add packet injection method

2018-01-05 Thread Tiwei Bie
On Fri, Jan 05, 2018 at 08:46:56AM -0800, Xiao Wang wrote: [...] > +/* > + * Recover hw state to let worker thread continue. > + */ > +void > +virtio_dev_resume(struct rte_eth_dev *dev) > +{ > + struct virtio_hw *hw = dev->data->dev_private; > + > + hw->started = 1; > + rte_spinlock_unl

Re: [dpdk-dev] [PATCH v5 3/3] net/virtio: support GUEST ANNOUNCE

2018-01-05 Thread Tiwei Bie
On Fri, Jan 05, 2018 at 08:46:57AM -0800, Xiao Wang wrote: [...] > +static int > +make_rarp_packet(struct rte_mbuf *rarp_mbuf, const struct ether_addr *mac) > +{ > + struct ether_hdr *eth_hdr; > + struct arp_hdr *rarp; Please just use one space between the type and var instead of two. >

[dpdk-dev] [PATCH] ethdev: fix link autonegotiation value

2018-01-05 Thread Thomas Monjalon
There are 3 kind of link data in ethdev: - capabilities (rte_eth_dev_info) - configuration (rte_eth_conf) - status (rte_eth_link) A bit-field is used for capabilities (rte_eth_dev_info.speed_capa) and configuration (rte_eth_conf.link_speeds). Bits are defined in ETH_LINK_SP

Re: [dpdk-dev] [PATCH] net/mlx4: verify Tx max sges

2018-01-05 Thread Adrien Mazarguil
On Thu, Jan 04, 2018 at 06:12:03PM +0200, Moti Haimovsky wrote: > Max number of Tx scatter-gather entries is a property of the device > and is queried at init. This value was not changed in a while and > most probably will not be changed in the future, Therefore and > in order to enhance Tx perform

Re: [dpdk-dev] [PATCHv3 0/4] dpdk: enhance EXPERIMENTAL api tagging

2018-01-05 Thread Neil Horman
On Fri, Jan 05, 2018 at 03:08:52PM +0100, Thomas Monjalon wrote: > 04/01/2018 13:56, Neil Horman: > > On Sat, Dec 30, 2017 at 12:15:17PM -0500, Neil Horman wrote: > > > Thomas- > > > I just noticed that the ci tests are failing on the intel compiler, > > > which > > > makes very little sense

Re: [dpdk-dev] standardize device identification

2018-01-05 Thread Thomas Monjalon
05/01/2018 15:14, Finn Christensen: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > >05/01/2018 12:09, Finn Christensen: > >> From: Thomas Monjalon > >> Which property can help to distinguish Napatech ports? > >> Can you use class=eth,dev_port=X ? > >> The dev_port property will

Re: [dpdk-dev] [PATCH] devtools: ignore checkpatch warning for maintainers file

2018-01-05 Thread Remy Horton
On 05/01/2018 11:43, Thomas Monjalon wrote: The script checkpatch.pl from Linux is enforcing a tab in the MAINTAINERS file (Linux commit 628f91a28649). It can be ignored in our wrapper checkpatches.sh. Suggested-by: Remy Horton Signed-off-by: Thomas Monjalon --- devtools/checkpatches.sh | 3

Re: [dpdk-dev] [RFC 02/14] virtio: use eth_link_read/write (and bug fix)

2018-01-05 Thread Thomas Monjalon
17/07/2017 18:28, Stephen Hemminger: > On Mon, 17 Jul 2017 19:14:16 +0300 > Andrew Rybchenko wrote: > > > On 07/17/2017 07:01 PM, Stephen Hemminger wrote: > > > On Sun, 16 Jul 2017 15:33:26 +0300 > > > Andrew Rybchenko wrote: > > > > > >>> + link.link_autoneg = ETH_LINK_SPEED_FIXED; >

Re: [dpdk-dev] [RFC 00/14] link status API improvement and bugfixes

2018-01-05 Thread Thomas Monjalon
14/07/2017 20:30, Stephen Hemminger: > While writing new driver, I noticed a lot of unnecessary duplication of > code in drivers for handling the eth_dev link status information. While > consolidating this, it also became obvious that several drivers have > bugs in this are because they don't retur

Re: [dpdk-dev] [RFC 01/14] ethdev: add link status read/write functions

2018-01-05 Thread Thomas Monjalon
Stephen, Qiming was suggesting a name change for the functions. What do you think? 13/10/2017 17:12, Stephen Hemminger: > On Wed, 11 Oct 2017 08:32:12 + > "Yang, Qiming" wrote: > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > > > Sent: Saturday, July 15, 2017

Re: [dpdk-dev] standardize device identification

2018-01-05 Thread Finn Christensen
>-Original Message- >From: Thomas Monjalon [mailto:tho...@monjalon.net] >Sent: 5. januar 2018 13:02 >To: Finn Christensen >Cc: dev@dpdk.org; Yuanhan Liu ; Adrien Mazarguil >; Ciara Loftus ; Kevin >Traynor ; step...@networkplumber.org; >ferruh.yi...@intel.com >Subject: Re: [dpdk-dev] stand

[dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode.

2018-01-05 Thread Tonghao Zhang
This patch adds the name for vhost-user reconnect thread. It can help us to know whether the thread is running. Signed-off-by: Tonghao Zhang --- lib/librte_vhost/socket.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index d44a0

[dpdk-dev] [PATCH 4/5] net/ixgbevf: add check for rte_intr_enable.

2018-01-05 Thread Tonghao Zhang
When we bind the ixgbevf to vfio and call the rte_eth_dev_rx_intr_enable and rte_eth_dev_rx_intr_disable frequently, the interrupt setting (msi_set_mask_bit) will take more CPU as show below. rte_intr_enable call the ioctl to map the fd to interrupts frequently. perf top: 5.45% [kernel] [k] msi

[dpdk-dev] [PATCH 3/5] net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance.

2018-01-05 Thread Tonghao Zhang
If dpdk APPs call the rte_eth_dev_rx_intr_enable or rte_eth_dev_rx_intr_disable frequently, and ixgbe vf will read the IXGBE_VTEIMS register everytime. We can optimize the driver function. The patch save the IXGBE_VTEIMS to mask to avoid read frequently. Signed-off-by: Tonghao Zhang --- drivers/

[dpdk-dev] [PATCH 2/5] net/ixgbevf: set the inter-interrupt interval for EITR.

2018-01-05 Thread Tonghao Zhang
Set EITR interval as default. This patch can improve the performance when we enable the rx-intrrupt to process the packets because we hope rx-intrrupt reduce CPU. The 200us value of EITR makes the performance better with the low CPU. Signed-off-by: Tonghao Zhang --- drivers/net/ixgbe/ixgbe_ethd

[dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-05 Thread Tonghao Zhang
When we bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the rx-interrupt, there will be more than one epoll_wait on intr_handle.fd. One is in "eal-intr-thread" thread, and the others are in the thread which call the "rte_epoll_wait". The problem is that sometiems "eal-intr-thread" thread w

Re: [dpdk-dev] [PATCHv3 0/4] dpdk: enhance EXPERIMENTAL api tagging

2018-01-05 Thread Thomas Monjalon
04/01/2018 13:56, Neil Horman: > On Sat, Dec 30, 2017 at 12:15:17PM -0500, Neil Horman wrote: > > Thomas- > > I just noticed that the ci tests are failing on the intel compiler, > > which > > makes very little sense to me, as the error is a permission error on a bash > > script that added in

[dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-05 Thread Tonghao Zhang
When we bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the rx-interrupt, there will be more than one epoll_wait on intr_handle.fd. One is in "eal-intr-thread" thread, and the others are in the thread which call the "rte_epoll_wait". The problem is that sometiems "eal-intr-thread" thread w

[dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode.

2018-01-05 Thread Tonghao Zhang
This patch adds the name for vhost-user reconnect thread. It can help us to know whether the thread is running. Signed-off-by: Tonghao Zhang Signed-off-by: Tonghao Zhang --- lib/librte_vhost/socket.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_vhost/socket.c b/lib/lib

[dpdk-dev] [PATCH 3/5] net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance.

2018-01-05 Thread Tonghao Zhang
If dpdk APPs call the rte_eth_dev_rx_intr_enable or rte_eth_dev_rx_intr_disable frequently, and ixgbe vf will read the IXGBE_VTEIMS register everytime. We can optimize the driver function. The patch save the IXGBE_VTEIMS to mask to avoid read frequently. Signed-off-by: Tonghao Zhang --- drivers/

[dpdk-dev] [PATCH 4/5] net/ixgbevf: add check for rte_intr_enable.

2018-01-05 Thread Tonghao Zhang
When we bind the ixgbevf to vfio and call the rte_eth_dev_rx_intr_enable and rte_eth_dev_rx_intr_disable frequently, the interrupt setting (msi_set_mask_bit) will take more CPU as show below. rte_intr_enable call the ioctl to map the fd to interrupts frequently. perf top: 5.45% [kernel] [k] msi

Re: [dpdk-dev] [PATCH 2/2] net: enable IOVA mode for PMDs

2018-01-05 Thread Maxime Coquelin
Hi Santosh On 01/05/2018 01:10 PM, santosh wrote: Hi Maxim, On Friday 05 January 2018 04:02 PM, Maxime Coquelin wrote: Hi Jianfeng, On 10/11/2017 12:33 PM, Jianfeng Tan wrote: If we want to enable IOVA mode, introduced by commit 93878cf0255e ("eal: introduce helper API for IOVA mode"), we n

Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change

2018-01-05 Thread Igor Ryzhov
Thank you for the patch! Comments inline. On Wed, Jan 3, 2018 at 5:29 PM, Olivier Matz wrote: > > drivers/net/i40e/i40e_ethdev.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ > ethdev.c > index 811c

Re: [dpdk-dev] [PATCH 2/2] net: enable IOVA mode for PMDs

2018-01-05 Thread santosh
Hi Maxim, On Friday 05 January 2018 04:02 PM, Maxime Coquelin wrote: > Hi Jianfeng, > > On 10/11/2017 12:33 PM, Jianfeng Tan wrote: >> If we want to enable IOVA mode, introduced by >> commit 93878cf0255e ("eal: introduce helper API for IOVA mode"), >> we need PMDs (for PCI devices) to expose this

Re: [dpdk-dev] [PATCH 2/2] net: enable IOVA mode for PMDs

2018-01-05 Thread Maxime Coquelin
On 01/05/2018 11:32 AM, Maxime Coquelin wrote: Hi Jianfeng, On 10/11/2017 12:33 PM, Jianfeng Tan wrote: If we want to enable IOVA mode, introduced by commit 93878cf0255e ("eal: introduce helper API for IOVA mode"), we need PMDs (for PCI devices) to expose this flag. Signed-off-by: Jianfeng T

Re: [dpdk-dev] standardize device identification

2018-01-05 Thread Thomas Monjalon
05/01/2018 12:09, Finn Christensen: > From: Thomas Monjalon > Which property can help to distinguish Napatech ports? > Can you use class=eth,dev_port=X ? > The dev_port property will use /sys/class/net/DEV/dev_port on Linux. Is it > OK for you? > > Actually, what we were thinking o

[dpdk-dev] [PATCH] devtools: ignore checkpatch warning for maintainers file

2018-01-05 Thread Thomas Monjalon
The script checkpatch.pl from Linux is enforcing a tab in the MAINTAINERS file (Linux commit 628f91a28649). It can be ignored in our wrapper checkpatches.sh. Suggested-by: Remy Horton Signed-off-by: Thomas Monjalon --- devtools/checkpatches.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

Re: [dpdk-dev] [PATCH] MAINTAINERS fix style

2018-01-05 Thread Thomas Monjalon
05/01/2018 11:46, Remy Horton: > Any idea when Checkpatch started to enforce this? Looks like it was > slipped in recently.. commit 628f91a28649d063a048629d9d15b3e5c4dcaa37 Author: Joe Perches Date: Mon Jul 10 15:52:07 2017 -0700 checkpatch: warn when a MAINTAINERS entry isn't [A-Z]:\t

Re: [dpdk-dev] standardize device identification

2018-01-05 Thread Finn Christensen
-Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: 5. januar 2018 09:40 To: Finn Christensen Cc: dev@dpdk.org; Yuanhan Liu ; Adrien Mazarguil ; Ciara Loftus ; Kevin Traynor ; step...@networkplumber.org; ferruh.yi...@intel.com Su

Re: [dpdk-dev] [PATCH] bus/fslmc: change the eqcr stashing threshold to 1

2018-01-05 Thread Shreyansh Jain
On Wednesday 03 January 2018 09:09 PM, Nipun Gupta wrote: Changing the EQCR stashing threshold boosts the performance of l3fwd application on LS2088 by more than 20% as it helps in burst packet processing at the Tx side. CPU is immediately informed about the empty EQCR entries once consumed by th

Re: [dpdk-dev] [PATCH v2 1/2] kni: convert license headers to SPDX tags

2018-01-05 Thread Thomas Monjalon
19/12/2017 01:05, Ferruh Yigit: > --- a/lib/librte_kni/rte_kni.c > +++ b/lib/librte_kni/rte_kni.c > @@ -1,34 +1,6 @@ > -/*- > - * BSD LICENSE > - * > - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > - * All rights reserved. > - * > - * Redistribution and use in source an

Re: [dpdk-dev] [PATCH] relicense various bits of the dpdk

2018-01-05 Thread Thomas Monjalon
04/12/2017 16:55, Neil Horman: > +#SPDX-License-Identifier:BSD-3-Clause > +#Copyright(c) 2015 Neil Horman. All rights reserved. > +#Copyright(c) 2017 6WIND S.A. > +#All rights reserved [...] > /*- > - * BSD LICENSE > + * SPDX-License-Identifier: BSD-3-Clause > * >

Re: [dpdk-dev] [PATCH 1/2] mempool: indicate the usages of multi memzones

2018-01-05 Thread santosh
On Tuesday 19 December 2017 04:32 PM, Olivier MATZ wrote: > On Tue, Dec 19, 2017 at 04:16:33PM +0530, Hemant Agrawal wrote: >> Hi Olivier, >> >> On 12/19/2017 3:54 PM, Olivier MATZ wrote: >>> Hi Hemant, >>> >>> On Wed, Dec 06, 2017 at 06:01:12PM +0530, Hemant Agrawal wrote: This is required f

Re: [dpdk-dev] [PATCH] MAINTAINERS fix style

2018-01-05 Thread Remy Horton
Any idea when Checkpatch started to enforce this? Looks like it was slipped in recently.. --ignore=MAINTAINERS_STYLE :) On 04/01/2018 23:48, Stephen Hemminger wrote: Checkpatch is complaining because the DPDK MAINTAINERS file style does not match the Linux style. Linux style is to always have

Re: [dpdk-dev] [PATCH 2/2] net: enable IOVA mode for PMDs

2018-01-05 Thread Maxime Coquelin
Hi Jianfeng, On 10/11/2017 12:33 PM, Jianfeng Tan wrote: If we want to enable IOVA mode, introduced by commit 93878cf0255e ("eal: introduce helper API for IOVA mode"), we need PMDs (for PCI devices) to expose this flag. Signed-off-by: Jianfeng Tan --- drivers/net/e1000/em_ethdev.c | 3 ++-

Re: [dpdk-dev] [PATCH v2] net: update licence for network headers

2018-01-05 Thread Thomas Monjalon
28/12/2017 12:42, Hemant Agrawal: > On 12/22/2017 9:29 PM, Olivier Matz wrote: > > To be compliant with the DPDK licensing guidelines, switch to > > BSD-3-Clause. It can be done safely since the BSD headers from which > > these files derive also exist as a BSD-3-Clause license in FreeBSD. > > > > L

[dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel

2018-01-05 Thread Zhike Wang
From: zhike wang The max_mtu is kept as zero in case no CRTL channel, which leads to failure when calling virtio_mtu_set(). Signed-off-by: Zhike Wang --- drivers/net/virtio/virtio_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/v

Re: [dpdk-dev] [PATCH] net/virtio: init MTU in case no control channel

2018-01-05 Thread Thomas Monjalon
05/01/2018 01:54, zhike wang: > The max_mtu is kept as zero in case no CRTL channel, which leads > to failure when calling virtio_mtu_set(). > > Signed-off-by: zhike wang Please use uppercases in your name: Zhike Wang Thanks

[dpdk-dev] [PATCH v2 16/16] net/axgbe: add support for build 32-bit mode

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- doc/guides/nics/features/axgbe.ini | 1 + drivers/net/axgbe/axgbe_common.h | 49 ++ drivers/net/axgbe/axgbe_ethdev.c | 10 drivers/net/axgbe/axgbe_ethdev.h | 8 +++ drivers/net/axgbe/axgbe_rxtx.c | 12 +

[dpdk-dev] [PATCH v2 15/16] net/axgbe: add generic transmit and receive status support

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- doc/guides/nics/axgbe.rst | 1 + doc/guides/nics/features/axgbe.ini | 1 + drivers/net/axgbe/axgbe_ethdev.c | 51 ++ 3 files changed, 53 insertions(+) diff --git a/doc/guides/nics/axgbe.rst b/doc/guides/nics/axgbe.rst

[dpdk-dev] [PATCH v2 12/16] net/axgbe: add link status update

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- doc/guides/nics/features/axgbe.ini | 1 + drivers/net/axgbe/axgbe_ethdev.c | 33 + 2 files changed, 34 insertions(+) diff --git a/doc/guides/nics/features/axgbe.ini b/doc/guides/nics/features/axgbe.ini index f644128..2dbff18 10064

[dpdk-dev] [PATCH v2 13/16] net/axgbe: add configure flow control while link adjustment

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_mdio.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/axgbe/axgbe_mdio.c b/drivers/net/axgbe/axgbe_mdio.c index 753dde9..07f4087 100644 --- a/drivers/net/axgbe/axgbe_mdio.c +++ b/drivers/net/axgbe/axgbe_mdio.c @

[dpdk-dev] [PATCH v2 14/16] net/axgbe: add promiscuous mode support

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- doc/guides/nics/axgbe.rst | 2 ++ doc/guides/nics/features/axgbe.ini | 2 ++ drivers/net/axgbe/axgbe_ethdev.c | 48 ++ 3 files changed, 52 insertions(+) diff --git a/doc/guides/nics/axgbe.rst b/doc/guides/nics/axgbe.r

[dpdk-dev] [PATCH v2 11/16] doc: add documents for AMD axgbe Ethernet PMD

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- doc/guides/nics/axgbe.rst | 211 + doc/guides/nics/features/axgbe.ini | 14 +++ doc/guides/nics/index.rst | 1 + 3 files changed, 226 insertions(+) create mode 100644 doc/guides/nics/axgbe.rst create mode 100

[dpdk-dev] [PATCH v2 09/16] net/axgbe: add DMA programming and dev start and stop apis

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_dev.c| 844 +++ drivers/net/axgbe/axgbe_ethdev.c | 96 + 2 files changed, 940 insertions(+) diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c index 528241e..a69a078 100644

[dpdk-dev] [PATCH v2 08/16] net/axgbe: add transmit and receive queue setup apis

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/Makefile | 1 + drivers/net/axgbe/axgbe_ethdev.c | 81 + drivers/net/axgbe/axgbe_ethdev.h | 36 drivers/net/axgbe/axgbe_rxtx.c | 363 +++ drivers/net/axgbe/axgbe_rxtx.h | 289 +++

[dpdk-dev] [PATCH v2 10/16] net/axgbe: add transmit and receive data path apis

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/Makefile | 1 + drivers/net/axgbe/axgbe_ethdev.c | 22 +- drivers/net/axgbe/axgbe_rxtx.c | 429 + drivers/net/axgbe/axgbe_rxtx.h | 19 ++ drivers/net/axgbe/axgbe_rxtx_vec_sse.c |

[dpdk-dev] [PATCH v2 07/16] net/axgbe: add interrupt handler for autonegotiation

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_ethdev.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index 0dc424d..daea0b2 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/

[dpdk-dev] [PATCH v2 06/16] net/axgbe: add phy programming apis

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_dev.c | 27 + drivers/net/axgbe/axgbe_mdio.c | 963 + drivers/net/axgbe/axgbe_phy_impl.c | 1397 3 files changed, 2387 insertions(+) diff --git a/drivers/net/axgbe/axgbe

[dpdk-dev] [PATCH v2 04/16] net/axgbe: add structures for MAC initialization and reset

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/Makefile | 1 + drivers/net/axgbe/axgbe_dev.c| 167 +++ drivers/net/axgbe/axgbe_ethdev.c | 301 - drivers/net/axgbe/axgbe_ethdev.h | 349 +++ 4 files cha

[dpdk-dev] [PATCH v2 05/16] net/axgbe: add phy initialization and related apis

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/Makefile | 3 + drivers/net/axgbe/axgbe_dev.c | 188 + drivers/net/axgbe/axgbe_ethdev.c | 11 + drivers/net/axgbe/axgbe_ethdev.h | 172 drivers/net/axgbe/axgbe_i2c.c | 453 + drivers/net/

[dpdk-dev] [PATCH v2 03/16] net/axgbe: add phy register map and helper macros

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_phy.h | 314 ++ 1 file changed, 314 insertions(+) create mode 100644 drivers/net/axgbe/axgbe_phy.h diff --git a/drivers/net/axgbe/axgbe_phy.h b/drivers/net/axgbe/axgbe_phy.h new file mode 100644 index

[dpdk-dev] [PATCH v2 01/16] net/axgbe: add minimal dev init and uninit support

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- MAINTAINERS | 6 + config/common_base | 6 + drivers/net/Makefile| 1 + drivers/net/axgbe/Makefile | 146 +++ drivers/net/axgbe/axgbe_common.h

[dpdk-dev] [PATCH v2 02/16] net/axgbe: add register map and related macros

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_common.h | 1644 ++ 1 file changed, 1644 insertions(+) diff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/axgbe/axgbe_common.h index 168dbb5..294f2e4 100644 --- a/drivers/net/axgbe/axgbe_common.h +

[dpdk-dev] [PATCH v2 19/20] test/crypto: add test for AMD CCP crypto poll mode driver

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- test/test/test_cryptodev.c | 161 +++ test/test/test_cryptodev.h | 1 + test/test/test_cryptodev_aes_test_vectors.h | 93 ++-- test/test/test_cryptodev_blockcipher.c | 9 +- test/test

[dpdk-dev] [PATCH v2 20/20] doc: add ccp crypto poll mode driver to release notes

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- MAINTAINERS| 6 ++ doc/guides/rel_notes/release_18_02.rst | 5 + 2 files changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f0baeb4..54734f7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -588,6 +588,12 @@ M: Pa

[dpdk-dev] [PATCH v2 17/20] crypto/ccp: add cpu based md5 and sha2 family auth algo support

2018-01-05 Thread Ravi Kumar
Auth operations can be performed on CPU without offloading to CCP if CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH is enabled in DPDK configuration. Signed-off-by: Ravi Kumar --- config/common_base | 1 + drivers/crypto/ccp/ccp_crypto.c | 278 ++- dr

[dpdk-dev] [PATCH v2 18/20] doc: add document for AMD CCP crypto poll mode driver

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- doc/guides/cryptodevs/ccp.rst | 127 + doc/guides/cryptodevs/features/ccp.ini | 57 + doc/guides/cryptodevs/features/default.ini | 12 +++ doc/guides/cryptodevs/index.rst| 1 + 4 files changed,

[dpdk-dev] [PATCH v2 15/20] crypto/ccp: add sha2 family auth algo support

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_crypto.c | 270 +++ drivers/crypto/ccp/ccp_crypto.h | 48 +++ drivers/crypto/ccp/ccp_pmd_ops.c | 168 3 files changed, 486 insertions(+) diff --git a/drivers/crypto/ccp/ccp_cr

[dpdk-dev] [PATCH v2 14/20] crypto/ccp: add sha1 auth algo support

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_crypto.c | 367 +++ drivers/crypto/ccp/ccp_crypto.h | 23 +++ drivers/crypto/ccp/ccp_pmd_ops.c | 42 + 3 files changed, 432 insertions(+) diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto

[dpdk-dev] [PATCH v2 16/20] crypto/ccp: add sha3 family auth algo support

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_crypto.c | 667 +- drivers/crypto/ccp/ccp_crypto.h | 22 ++ drivers/crypto/ccp/ccp_pmd_ops.c | 168 + lib/librte_cryptodev/rte_crypto_sym.h | 17 + 4 files changed, 873 insertions(+), 1

[dpdk-dev] [PATCH v2 10/20] crypto/ccp: add aes cipher algo support

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_crypto.c | 197 ++- drivers/crypto/ccp/ccp_crypto.h | 13 +++ drivers/crypto/ccp/ccp_dev.h | 53 +++ drivers/crypto/ccp/ccp_pmd_ops.c | 60 4 files changed, 321 insertions(+), 2

[dpdk-dev] [PATCH v2 13/20] crypto/ccp: add aes-gcm aead algo support

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_crypto.c | 240 ++- drivers/crypto/ccp/ccp_pmd_ops.c | 30 + 2 files changed, 266 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto/ccp/ccp_crypto.c index 6e59

[dpdk-dev] [PATCH v2 12/20] crypto/ccp: add aes-cmac auth algo aupport

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_crypto.c | 277 ++- drivers/crypto/ccp/ccp_pmd_ops.c | 21 +++ 2 files changed, 296 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/crypto/ccp/ccp_crypto.c index 066076

[dpdk-dev] [PATCH v2 11/20] crypto/ccp: add 3des cipher algo support

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_crypto.c | 132 ++- drivers/crypto/ccp/ccp_crypto.h | 3 + drivers/crypto/ccp/ccp_pmd_ops.c | 20 ++ 3 files changed, 154 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/ccp_crypto.c b/

[dpdk-dev] [PATCH v2 09/20] crypto/ccp: add ccp hwrng feature support

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_dev.c | 20 drivers/crypto/ccp/ccp_dev.h | 11 +++ 2 files changed, 31 insertions(+) diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/crypto/ccp/ccp_dev.c index fee90e3..d8c0ab4 100644 --- a/drivers/crypto/ccp/c

[dpdk-dev] [PATCH v2 08/20] crypto/ccp: add stats related crypto pmd ops support

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_pmd_ops.c | 34 -- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/ccp_pmd_ops.c b/drivers/crypto/ccp/ccp_pmd_ops.c index a02aa6f..d483a74 100644 --- a/drivers/crypto/ccp/ccp_pmd

[dpdk-dev] [PATCH v2 07/20] crypto/ccp: add support for RTE_CRYPTO_OP_SESSIONLESS

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/rte_ccp_pmd.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/rte_ccp_pmd.c b/drivers/crypto/ccp/rte_ccp_pmd.c index fb6d41e..011240b 100644 --- a/drivers/crypto/ccp/rte_ccp_

[dpdk-dev] [PATCH v2 06/20] crypto/ccp: add crypto enqueue and dequeue burst api support

2018-01-05 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_crypto.c | 359 +++ drivers/crypto/ccp/ccp_crypto.h | 35 drivers/crypto/ccp/ccp_dev.c | 27 +++ drivers/crypto/ccp/ccp_dev.h | 9 + drivers/crypto/ccp/rte_ccp_pmd.c | 64 ++- 5 files

  1   2   >