Re: [dpdk-dev] [PATCH 4/5] event/octeontx: implement dynamic logging

On Tuesday 19 December 2017 05:55 PM, Pavan Nikhilesh wrote: > Signed-off-by: Pavan Nikhilesh > --- same comment for otx_ssovf_init_log Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH 3/5] mempool/octeontx: implement dynamic logging

On Tuesday 19 December 2017 05:55 PM, Pavan Nikhilesh wrote: > Signed-off-by: Pavan Nikhilesh > --- Same nits comment for otx_pool_init_log Acked-by: santosh shukla

Re: [dpdk-dev] [PATCH 2/5] net/octeontx: implement dynamic logging

On Tuesday 19 December 2017 05:55 PM, Pavan Nikhilesh wrote: > Signed-off-by: Pavan Nikhilesh > --- nits: s / otx_net_init_log / octeontx_net_init_log Rest LGTM, Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH 1/5] net/thunderx: implement dynamic logging

On Tuesday 19 December 2017 05:55 PM, Pavan Nikhilesh wrote: > Signed-off-by: Pavan Nikhilesh > --- LGTM. Acked-by: Santosh Shukla

Re: [dpdk-dev] [PATCH 1/2] lib/net: add IPv6 header fields macros

On Sun, 31 Dec 2017 07:34:29 + Shachar Beiser wrote: > +/* IPv6 vtc_flow: IPv / TC / flow_label */ > +#define IPV6_HDR_FL_SHIFT (0) > +#define IPV6_HDR_TC_SHIFT (20) No parenthesis needed around simple numeric values. > +#define IPV6_HDR_FL_MASK ((1 << IPV6_HDR_TC_SHIFT) - 1) If you use ((

[dpdk-dev] [PATCH v1] [app/procinfo] fix memory leak - PCAP & service

When procinfo uses the PCAP PMD it is not detached. The library service also makes of memory but never releases at exit of application. These leads to memory leak, on multiple runs. The patch add check for libpcap PMD check and detaches the same. The patch also frees the service library memory too

[dpdk-dev] [PATCH v1] service: fix memory leak by rte_service_init

This patch fixes the memory leak created by rte_service_init, when run from secondary application. Running secondary application which shares the huge page memory from primary multiple times causes memory to be initialized but not free when application exit. The rte_service_deinit check if the ser