[dpdk-dev] [PATCH v2] app/testpmd: fix port_id alloction issue

2017-12-21 Thread Yanglong Wu
In the feature of increasing port_id range from 8 bits to 16 bits, vlan port_id allocation function was forget to substitute UINT8 with UINT16, so the vlan port_id was allocated as a inccrete number. Fixes:28caa76aea71 ("app/testpmd: fix port id type") Signed-off-by: Yanglong Wu --- v2: modified

Re: [dpdk-dev] [RFC v1] doc compression API for DPDK

2017-12-21 Thread Verma, Shally
Hi Fiona > -Original Message- > From: Trahe, Fiona [mailto:fiona.tr...@intel.com] > Sent: 20 December 2017 21:03 > To: Verma, Shally ; dev@dpdk.org > Cc: Athreya, Narayana Prasad ; > Gupta, Ashish ; Sahu, Sunila > ; De Lara Guarch, Pablo > ; Challa, Mahipal > ; Jain, Deepak K ; > Hemant Ag

[dpdk-dev] [PATCH v3 0/2] Support VxLAN GRO

2017-12-21 Thread Jiayu Hu
VxLAN is one of the most widely used tunneled protocols. Providing GRO support for VxLAN-encapsulated packets can benefit many per-packet based applications, like Open vSwitch. This patchset is to support VxLAN GRO. The first patch cleans up current gro codes for the sake of supporting tunneled GR

[dpdk-dev] [PATCH v3 2/2] gro: support VxLAN GRO

2017-12-21 Thread Jiayu Hu
This patch adds a framework that allows GRO on tunneled packets. Furthermore, it leverages that framework to provide GRO support for VxLAN-encapsulated packets. Supported VxLAN packets must have an outer IPv4 header, and contain an inner TCP/IPv4 packet. VxLAN GRO doesn't check if input packets ha

[dpdk-dev] [PATCH v3 1/2] gro: code cleanup

2017-12-21 Thread Jiayu Hu
- Remove needless check and variants - For better understanding, update the programmer guide and rename internal functions and variants - For supporting tunneled gro, move common internal functions from gro_tcp4.c to gro_tcp4.h - Comply RFC 6864 to process the IPv4 ID field Signed-off-by: Jiay

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix parsing fdir nvgre issue

2017-12-21 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, December 22, 2017 1:46 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH v2] net/ixgbe: fix parsing fdir nvgre issue > > There is some wrong of mask check in nvgre parser for flow API. > > Fixes: 11777435c727

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix parsing fdir nvgre issue

2017-12-21 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Friday, December 22, 2017 2:32 PM > To: Zhao1, Wei ; dev@dpdk.org > Subject: RE: [PATCH v2] net/ixgbe: fix parsing fdir nvgre issue > > > > > -Original Message- > > From: Zhao1, Wei > > Sent: Friday, December 22, 2017 1:46 PM > >

Re: [dpdk-dev] [PATCH] bus/dpaa/base: fix build when assert enabled

2017-12-21 Thread Shreyansh Jain
On Friday 22 December 2017 07:43 AM, Ferruh Yigit wrote: Enabling CONFIG_RTE_ENABLE_ASSERT cause build error because some fields protected by RTE_LIBRTE_DPAA_HWDEBUG macro accessed within DPAA_ASSERT. All DPAA_ASSERT macro usage causing the build error wrapped with RTE_LIBRTE_DPAA_HWDEBUG macro.

[dpdk-dev] [PATCH v2] app/testpmd: fix port_id alloction issue

2017-12-21 Thread Yanglong Wu
In the feature of increasing port_id range from 8 bits to 16 bits, vlan port_id allocation function was forget to substitute UINT8 with UINT16, so the vlan port_id was allocated as a invalid number. Signed-off-by: Yanglong Wu --- v2: modified commit message --- app/test-pmd/cmdline.c | 2 +- 1 f

Re: [dpdk-dev] standardize device identification

2017-12-21 Thread Shreyansh Jain
On Thursday 21 December 2017 03:32 AM, Thomas Monjalon wrote: Changing the title and adding more comments inline: 19/12/2017 00:05, Thomas Monjalon: Let's summarize and resume this thread. We need a generic syntax to describe a device. This syntax can be used - before initializing the

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix parsing fdir nvgre issue

2017-12-21 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, December 22, 2017 1:46 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH v2] net/ixgbe: fix parsing fdir nvgre issue > > There is some wrong of mask check in nvgre parser for flow API. > > Fixes: 11777435c727

Re: [dpdk-dev] [PATCH v2] net/i40e: add fdir nvgre parameters check

2017-12-21 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, December 22, 2017 1:11 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH v2] net/i40e: add fdir nvgre parameters check > > Add mask parameters check in nvgre parser for flow API. > > Fixes: 30965ca341278 ("net

[dpdk-dev] [PATCH] Create kern folder for Linux kernel modules

2017-12-21 Thread Hemant Agrawal
This patch moves the Linux kernel modules code to a common place. - Separate the kernel module code from user space code. - The GPL-2.0 licensed code is separated from the BSD-3 licensed userspace code Signed-off-by: Hemant Agrawal --- GNUmakefile

[dpdk-dev] [PATCH v2] net/ixgbe: fix parsing fdir nvgre issue

2017-12-21 Thread Wei Zhao
There is some wrong of mask check in nvgre parser for flow API. Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") Signed-off-by: Wei Zhao --- V2: -change c_k_s_rsvd0_ver mask check to 0x. --- drivers/net/ixgbe/ixgbe_flow.c | 22 +++--- 1 file changed, 19 inser

[dpdk-dev] [PATCH v2] net/i40e: add fdir nvgre parameters check

2017-12-21 Thread Wei Zhao
Add mask parameters check in nvgre parser for flow API. Fixes: 30965ca341278 ("net/i40e: add NVGRE flow parsing") Signed-off-by: Wei Zhao --- V2: -change c_k_s_rsvd0_ver mask check to 0x. --- drivers/net/i40e/i40e_flow.c | 35 +++ 1 file changed, 35 inserti

[dpdk-dev] [PATCH v2] net/ixgbe: fix parsing fdir nvgre issue

2017-12-21 Thread Wei Zhao
There is some wrong of mask check in nvgre parser for flow API. Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") Signed-off-by: Wei Zhao --- V2: -change c_k_s_rsvd0_ver mask check to 0x. --- drivers/net/ixgbe/ixgbe_flow.c | 22 +++--- 1 file changed, 19 inser

Re: [dpdk-dev] [PATCH] doc: add instructions on build using meson

2017-12-21 Thread Shreyansh Jain
Hi Bruce, some trivial comments inline... On Thursday 21 December 2017 09:42 PM, Bruce Richardson wrote: Add a document describing how to configure, build and install DPDK using meson and ninja. Document includes references to official installation docs using make, and points out the experiment

[dpdk-dev] [PATCH v3] net/i40e: support mac loopback

2017-12-21 Thread Yanglong Wu
According to loopback mode, setup loopback link or not. If loopback link is setted, packets in tx will be sent to rx directly. Loopback mode can be used to support testing task Signed-off-by: Yanglong Wu --- v2: fix coding style issue --- v3: update release DOC --- doc/guides/rel_notes/release_1

Re: [dpdk-dev] [PATCH v2 18/18] doc: remove devargs deprecation notices

2017-12-21 Thread Shreyansh Jain
Hello Gaetan, On Wednesday 13 December 2017 04:24 PM, Shreyansh Jain wrote: Hello Gaetan, -Original Message- From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] Sent: Wednesday, December 13, 2017 3:56 PM To: Shreyansh Jain Cc: dev@dpdk.org Subject: Re: [PATCH v2 18/18] doc: remove deva

[dpdk-dev] [PATCH v1] [net/pcap] fix the NUMA id display in logs.

2017-12-21 Thread Vipin Varghese
On single NUMA device the log information shows as boundary value instead of -1. The change brings in unsinged to signed. Signed-off-by: Vipin Varghese --- drivers/net/pcap/rte_eth_pcap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/dr

Re: [dpdk-dev] [PATCH] net/i40e: move RSS to flow API

2017-12-21 Thread Zhang, Qi Z
Hi Wei: Please check my comment below. Besides, there some line over 80 character warning need to fix Regards Qi > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Friday, November 24, 2017 4:43 PM > To: dev@dpdk.org > Cc:

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

2017-12-21 Thread Zhao1, Wei
Ok, I will commit a new patch as this way. > -Original Message- > From: Yigit, Ferruh > Sent: Friday, December 22, 2017 11:26 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Mcnamara, John ; Zhang, Helin > > Subject: Re: [dpdk-dev] [PATCH] doc: add queue region feature info to > release notes >

Re: [dpdk-dev] [PATCH v2] net/i40e: fix port segmentation fault when restart

2017-12-21 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Wednesday, November 15, 2017 1:55 PM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix port segmentation fault when > restart > > It will clear all queue region re

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

2017-12-21 Thread Ferruh Yigit
On 12/21/2017 5:36 PM, Zhao1, Wei wrote: > Ok, this will be updating in release notes for v18.02, > and have a mention that this feature has been implemented in v17.11? I think mentioning from first implemented release helps to reduce confusion, in case users interested in implementation details

Re: [dpdk-dev] [PATCH] ethdev: add notifications for probing and removal

2017-12-21 Thread Ferruh Yigit
On 11/28/2017 2:13 PM, Thomas Monjalon wrote: > When a PMD finishes probing, it creates the new port by calling > the function rte_eth_dev_allocate(). > A notification of the new port is sent there to the upper layer. > > When a PMD finishes removal of a port, it calls the function > rte_eth_dev_r

Re: [dpdk-dev] [PATCH] ethdev: remove useless parameter in callback process

2017-12-21 Thread Ferruh Yigit
On 11/28/2017 2:09 PM, Thomas Monjalon wrote: > The pointer to the user parameter of the callback registration is > automatically pass to the callback function. > There is no point to allow changing this user parameter by a caller. > That's why this parameter is always set to NULL by PMDs and set o

Re: [dpdk-dev] [PATCH] net/i40e: add fdir nvgre parameters check

2017-12-21 Thread Zhao1, Wei
Hi,zhangqi > -Original Message- > From: Zhang, Qi Z > Sent: Friday, December 22, 2017 10:11 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH] net/i40e: add fdir nvgre parameters check > > > > > -Original Message

Re: [dpdk-dev] [RFC PATCH 0/3] configurable max queue number per VF

2017-12-21 Thread Ferruh Yigit
On 7/31/2017 12:27 PM, Wenzhuo Lu wrote: > Currently, on i40e, the max queue number per VF is set by a macro. > It means the value is decided when compiling. It's not friendly to > the users. Because every time the users want to change the value, > the code need to be re-compiled. > > The reason o

Re: [dpdk-dev] [PATCH] net/i40e: add fdir nvgre parameters check

2017-12-21 Thread Zhao1, Wei
Hi,zhangqi > -Original Message- > From: Zhang, Qi Z > Sent: Friday, December 22, 2017 10:11 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH] net/i40e: add fdir nvgre parameters check > > > > > -Original Message

[dpdk-dev] [PATCH] bus/dpaa/base: fix build when assert enabled

2017-12-21 Thread Ferruh Yigit
Enabling CONFIG_RTE_ENABLE_ASSERT cause build error because some fields protected by RTE_LIBRTE_DPAA_HWDEBUG macro accessed within DPAA_ASSERT. All DPAA_ASSERT macro usage causing the build error wrapped with RTE_LIBRTE_DPAA_HWDEBUG macro. Fixes: f38f61e982f8 ("bus/dpaa: add BMAN hardware interfa

Re: [dpdk-dev] [PATCH] net/i40e: remove forward declaraion of i40e_xmit_pkts_simple

2017-12-21 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Monday, November 27, 2017 3:26 AM > To: dev@dpdk.org > Cc: Wu, Jingjing; Xing, Beilei; Rosen, Rami > Subject: [dpdk-dev] [PATCH] net/i40e: remove forward declaraion of > i40e_xmit_pkts_simple >

Re: [dpdk-dev] [PATCH] debug: update assertion macro

2017-12-21 Thread Ferruh Yigit
On 12/15/2017 11:56 AM, Ferruh Yigit wrote: > On 11/19/2017 6:41 AM, Ilya Matveychikov wrote: >> >> >>> On Nov 19, 2017, at 12:18 PM, Ilya Matveychikov >>> wrote: >>> >>> Update RTE_VERIFY macro to make it possible to use complex expressions >>> in RTE_ASSERT. >>> >>> Signed-off-by: Ilya V. Matve

Re: [dpdk-dev] [PATCH] net/i40e: add fdir nvgre parameters check

2017-12-21 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Friday, December 1, 2017 4:47 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Zhao1, Wei > Subject: [dpdk-dev] [PATCH] net/i40e: add fdir nvgre parameters check > > Add mask parameter

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

2017-12-21 Thread Zhao1, Wei
Ok, this will be updating in release notes for v18.02, and have a mention that this feature has been implemented in v17.11? > -Original Message- > From: Yigit, Ferruh > Sent: Friday, December 22, 2017 2:10 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Mcnamara, John > Subject: Re: [dpdk-dev

Re: [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue

2017-12-21 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Thursday, November 30, 2017 2:36 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: fix FDIR rule confiliction issue > > Failed to create two FDIR

Re: [dpdk-dev] [PATCH v6 0/2] add uevent monitor for hot plug

2017-12-21 Thread Guo, Jia
Moti, Hello and sorry for be reply late until now, definitely as gaetan said that there might be some change after the version, anyway I will create a new version to benefit you all to review and further test. Best regards, Jeff Guo -Original Message- From: Gaëtan Rivet [mailto:gaetan

Re: [dpdk-dev] [PATCH] member: fix memory leak on error

2017-12-21 Thread Wang, Yipeng1
Btw, Pablo, since I remember I refer to the EFD library on my membership implementation, does EFD have similar memory leakage issue that not releasing te when failure? Thanks >-Original Message- >From: Wang, Yipeng1 >Sent: Thursday, December 21, 2017 4:01 PM >To: Burakov, Anatoly ; dev@

Re: [dpdk-dev] [PATCH] member: fix memory leak on error

2017-12-21 Thread Wang, Yipeng1
Thank you Anatoly for finding this issue. In the code I tried to reuse the rte_member_free function to free memory but it may not be executed through. Because of this, I may not properly release setsum struct neither. I will post a fix for both soon. Thanks >-Original Message- >From:

[dpdk-dev] [RFC] tunnel endpoint hw acceleration enablement

2017-12-21 Thread Doherty, Declan
This RFC contains a proposal to add a new tunnel endpoint API to DPDK that when used in conjunction with rte_flow enables the configuration of inline data path encapsulation and decapsulation of tunnel endpoint network overlays on accelerated IO devices. The proposed new API would provide for th

Re: [dpdk-dev] [PATCH v3 1/8] event/opdl: add the opdl ring infrastructure library

2017-12-21 Thread Ma, Liang J
> > OPDL ring is the core infrastructure of OPDL PMD. OPDL ring library > provide the core data structure and core helper function set. The Ring > implements a single ring multi-port/stage pipelined packet distribution > mechanism. This mechanism has the following characteristics: > > • No multi

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-21 Thread Matan Azrad
> -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Thursday, December 21, 2017 10:14 PM > To: Matan Azrad > Cc: Thomas Monjalon ; dev@dpdk.org; Bruce > Richardson ; Ananyev, Konstantin > ; Gaëtan Rivet ; > Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH 2/5] eth

Re: [dpdk-dev] [RFC v2 00/23] Dynamic memory allocation for DPDK

2017-12-21 Thread Walker, Benjamin
On Tue, 2017-12-19 at 11:14 +, Anatoly Burakov wrote: > > Quick outline of all changes done as part of this patchset: > > * Malloc heap adjusted to handle holes in address space > * Single memseg list replaced by multiple expandable memseg lists > * VA space for hugepages is preallocated

Re: [dpdk-dev] [PATCH] vhost: introduce rte_vhost_vring_call()

2017-12-21 Thread Maxime Coquelin
Hi Stefan, On 12/21/2017 05:41 PM, Stefan Hajnoczi wrote: +int +rte_vhost_vring_call(int vid, uint16_t vring_idx) +{ + struct virtio_net *dev; + struct vhost_virtqueue *vq; + + dev = get_device(vid); + if (!dev) + return -1; + + if (vring_idx >= VHOST_

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-21 Thread Neil Horman
On Thu, Dec 21, 2017 at 07:37:06PM +, Matan Azrad wrote: > Hi > > > -Original Message- > > From: Neil Horman [mailto:nhor...@tuxdriver.com] > > Sent: Thursday, December 21, 2017 7:43 PM > > To: Thomas Monjalon > > Cc: dev@dpdk.org; Bruce Richardson ; Matan > > Azrad ; Ananyev, Konstan

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-21 Thread Matan Azrad
Hi > -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Thursday, December 21, 2017 7:43 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Bruce Richardson ; Matan > Azrad ; Ananyev, Konstantin > ; Gaëtan Rivet ; > Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH 2/5]

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix main MAC address handling

2017-12-21 Thread Ferruh Yigit
On 12/20/2017 1:52 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > There is a school of thought that rte_eth_dev_default_mac_addr_set() > must call the PMD callback first and then save the new MAC address > in dev->data->mac_addrs[0]. :) > If this concept gets approved, it will > break the

[dpdk-dev] [PATCH 2/3] test: fix copypaste error in memzone autotest

2017-12-21 Thread Anatoly Burakov
Fixes: b77b5639726e ("mem: add huge page sizes for IBM Power") Cc: chao...@linux.vnet.ibm.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_memzone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test/test_memzone.c b/test/test/test_memzone.c ind

[dpdk-dev] [PATCH 3/3] test: fix wrong test in memzone autotest

2017-12-21 Thread Anatoly Burakov
When reserving memzones in autotest, it makes no sense to expect a failed memzone reserve when we specify both size flags - instead, we should expect a memzone reserved with one of the two sizes. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov ---

[dpdk-dev] [PATCH 1/3] test: fix typo in memzone autotest

2017-12-21 Thread Anatoly Burakov
Fixes: 71330483a193 ("test/memzone: fix memory leak") Cc: radoslaw.bierna...@linaro.org Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_memzone.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test/test_memzone.c b/test/test/test_memzone.c ind

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

2017-12-21 Thread Ferruh Yigit
On 12/20/2017 7:52 PM, Wei Zhao wrote: > This patch add inforation about i40e queue region > realted to release notes, it has been missed before. > > Signed-off-by: Wei Zhao > --- > doc/guides/rel_notes/release_17_11.rst | 17 + I think we shouldn't update release notes once it h

[dpdk-dev] [PATCH] eal: fix memory leak in memzone when no room in config

2017-12-21 Thread Anatoly Burakov
We check if there's space in config after we allocated the memzone, but if there isn't, we never free it back. This patch adds memzone free if there's no room in memzone config. Fixes: ff909fe21f0a ("mem: introduce memzone freeing") Cc: sergio.gonzalez.mon...@intel.com Cc: sta...@dpdk.org Signed-o

Re: [dpdk-dev] [PATCH 01/11] avp: implement dynamic logging

2017-12-21 Thread Ferruh Yigit
On 12/20/2017 10:58 AM, Stephen Hemminger wrote: > On Tue, 19 Dec 2017 17:53:50 -0800 > Ferruh Yigit wrote: > >> On 12/18/2017 10:38 PM, Stephen Hemminger wrote: >>> All PMD should be using dynamic log levels. >>> >>> Signed-off-by: Stephen Hemminger <...> >>> @@ -2312,3 +2313,12 @@ avp_dev_st

[dpdk-dev] [PATCH] member: fix memory leak on error

2017-12-21 Thread Anatoly Burakov
rte_member may have allocated a tailq entry before failure, so free it. Fixes: 857ed6c68cf2 ("member: implement main API") Cc: yipeng1.w...@intel.com Signed-off-by: Anatoly Burakov --- lib/librte_member/rte_member.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_member/rte_member

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-21 Thread Neil Horman
On Thu, Dec 21, 2017 at 06:06:48PM +0100, Thomas Monjalon wrote: > 08/12/2017 13:31, Neil Horman: > > On Fri, Dec 08, 2017 at 12:35:18PM +0100, Thomas Monjalon wrote: > > > 05/12/2017 11:05, Bruce Richardson: > > > > > I think you suggest to make all the ethdev configuration race safe, it > > > > >

[dpdk-dev] [PATCH] eal: protect malloc stats with lock

2017-12-21 Thread Anatoly Burakov
When we're gathering statistics, we are traversing the freelist, which may change under our feet in multithreaded scenario. This is verified by occasional segfaults when running malloc autotest on a machine with big amount of cores. This patch protects malloc heap stats call with a lock. It change

[dpdk-dev] [PATCH v3 8/8] doc: add eventdev opdl pmd docuement

2017-12-21 Thread Liang Ma
Add the description about opdl pmd Signed-off-by: Liang Ma Signed-off-by: Peter Mccarthy --- doc/guides/eventdevs/index.rst | 1 + doc/guides/eventdevs/opdl.rst | 162 + 2 files changed, 163 insertions(+) create mode 100644 doc/guides/eventdevs/opdl.r

[dpdk-dev] [PATCH v3 7/8] doc:update 18.02 release notes

2017-12-21 Thread Liang Ma
add opdl pmd description Signed-off-by: Liang Ma Signed-off-by: Peter Mccarthy --- doc/guides/rel_notes/release_18_02.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst index 24b67bb..b2dc39c 1006

[dpdk-dev] [PATCH v3 6/8] maintainers: add the opdl pmd maintainer information

2017-12-21 Thread Liang Ma
Signed-off-by: Liang Ma Signed-off-by: Peter Mccarthy --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f0baeb4..1b8d617 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -700,6 +700,12 @@ F: doc/guides/eventdevs/sw.rst F: examples/eventdev_pi

[dpdk-dev] [PATCH v3 5/8] event/*: apply the three new capability flags for sw/dppa2/octeontx

2017-12-21 Thread Liang Ma
Signed-off-by: Liang Ma Signed-off-by: Peter Mccarthy --- drivers/event/dpaa2/dpaa2_eventdev.c | 6 +- drivers/event/octeontx/ssovf_evdev.c | 6 +- drivers/event/sw/sw_evdev.c | 5 - 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_ev

[dpdk-dev] [PATCH v3 4/8] lib/librte_eventdev: extend the eventdev capability flags

2017-12-21 Thread Liang Ma
this commitd add three new eventdev capability flags RTE_EVENT_DEV_CAP_NONSEQ_MODE Event device is capable of operating in none sequential mode. The path of the event is not necessary to be sequential. Application can change the path of event at runtime.if the flag is not set, then event each eve

[dpdk-dev] [PATCH v3 2/8] event/opdl: add the opdl pmd main body and helper function

2017-12-21 Thread Liang Ma
This commit adds a OPDL implementation of the eventdev API. The implementation here is intended to enable the community to use the OPDL infrastructure under eventdev API. The main components of the implementation is three files: - opdl_evdev.c Creation, configuration, etc - opdl_e

[dpdk-dev] [PATCH v3 3/8] eventdev/opdl: opdl eventdev pmd unit test function

2017-12-21 Thread Liang Ma
This commit adds unit test inside the OPDL PMD. There is a PMd parameter "self_test" can be used to triger the test when vdev bus probe opdl device e.g. sudo ./app/test --vdev="event_opdl0,self_test=1" Signed-off-by: Liang Ma Signed-off-by: Peter Mccarthy --- drivers/event/opdl/Makefile

[dpdk-dev] [PATCH v3 1/8] event/opdl: add the opdl ring infrastructure library

2017-12-21 Thread Liang Ma
OPDL ring is the core infrastructure of OPDL PMD. OPDL ring library provide the core data structure and core helper function set. The Ring implements a single ring multi-port/stage pipelined packet distribution mechanism. This mechanism has the following characteristics: • No multiple queue cost,

[dpdk-dev] [RFC v3 PATCH 0/8] event: eventdev OPDL PMD

2017-12-21 Thread Liang Ma
The OPDL (Ordered Packet Distribution Library) eventdev is a specific implementation of the eventdev API. It is particularly suited to packet processing workloads that have high throughput and low latency requirements. All packets follow the same path through the device. The order which packets f

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-21 Thread Thomas Monjalon
08/12/2017 13:31, Neil Horman: > On Fri, Dec 08, 2017 at 12:35:18PM +0100, Thomas Monjalon wrote: > > 05/12/2017 11:05, Bruce Richardson: > > > > I think you suggest to make all the ethdev configuration race safe, it > > > > is behind to this thread. Current ethdev implementation leave the > > > >

[dpdk-dev] [PATCH] eal: fix end for bounded malloc elements

2017-12-21 Thread Anatoly Burakov
In cases when alignment is bigger than boundary, we may incorrectly calculate end of a bounded malloc element. Consider this: suppose we are allocating a bounded malloc element that should be of 128 bytes in size, bounded to 128 bytes and aligned on a 256-byte boundary. Suppose our malloc element

[dpdk-dev] [PATCH] eal/x86: move header to standard BSD license

2017-12-21 Thread Bruce Richardson
This updates the license on the rte_rtm.h file to be the standard BSD-3-Clause license used for the rest of DPDK, thus bringing the file in compliance with the DPDK licensing policy. Signed-off-by: Bruce Richardson CC: Roman Dementiev CC: Andi Kleen --- lib/librte_eal/common/include/arch/x86/r

[dpdk-dev] [PATCH] vhost: introduce rte_vhost_vring_call()

2017-12-21 Thread Stefan Hajnoczi
Users of librte_vhost currently implement the vring call operation themselves. Each caller performs the operation slightly differently. This patch introduces a new librte_vhost API called rte_vhost_vring_call() that performs the operation so that vhost-user applications don't have to duplicate it

Re: [dpdk-dev] [PATCH] doc: add i40e update in release note

2017-12-21 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jingjing Wu > Sent: Thursday, December 21, 2017 2:04 PM > To: dev@dpdk.org > Cc: Zhang, Helin ; Xing, Beilei > > Subject: [dpdk-dev] [PATCH] doc: add i40e update in release note > > From: Beilei Xing > > Updat

Re: [dpdk-dev] [PATCH v1 2/3] net/hyperv: implement core functionality

2017-12-21 Thread Adrien Mazarguil
Disclaimer: I agree with Thomas's suggestions in his reply [1] to your message, I'm replying below as well to provide more details of my own and clarify the motivations behind this approach a bit more. On Tue, Dec 19, 2017 at 12:44:35PM -0800, Ferruh Yigit wrote: > On 12/19/2017 7:06 AM, Adrien Ma

[dpdk-dev] [PATCH] doc: add instructions on build using meson

2017-12-21 Thread Bruce Richardson
Add a document describing how to configure, build and install DPDK using meson and ninja. Document includes references to official installation docs using make, and points out the experimental nature of the build. Signed-off-by: Bruce Richardson --- INSTALL.meson | 177 ++

Re: [dpdk-dev] [PATCH v1 5/6] fix missing includes in exported headers

2017-12-21 Thread Bruce Richardson
On Thu, Dec 21, 2017 at 03:50:31PM +0100, Adrien Mazarguil wrote: > On Thu, Dec 21, 2017 at 02:12:57PM +, Bruce Richardson wrote: > > On Thu, Dec 21, 2017 at 02:00:04PM +0100, Adrien Mazarguil wrote: > > > Many exported headers rely on definitions found in rte_config.h without > > > including i

[dpdk-dev] [PATCH] test: fix uninitialized parameter in table autotest

2017-12-21 Thread Anatoly Burakov
delete_bulk() copies metadata to pointers provided by the entries parameter, but in the unit test, they are uninitialized, leading to rte_table attempting to memcpy into random garbage pointers. Memsetting pointer table to zero will prevent that from happening. Fixes: 48f2543cf0a8 ("app/test: add

[dpdk-dev] [PATCH] doc: remove UTF-8 BOM from programmer's guide

2017-12-21 Thread Anatoly Burakov
Fixes: 55694b2a9f64 ("doc: add membership documentation") Cc: yipeng1.w...@intel.com Signed-off-by: Anatoly Burakov --- doc/guides/prog_guide/member_lib.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/member_lib.rst b/doc/guides/prog_guide/member_lib

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/mlx5: fix Memory Region registration

2017-12-21 Thread Shahaf Shuler
Friday, December 15, 2017 3:59 AM, Yongseok Koh: > Althought granularity of chunks in a mempool is a cacheline, addresses are > extended to align to page boundary for performance reason in device when > registering a MR (Memory Region). This could make some regions overlap, > then can cause Tx comp

Re: [dpdk-dev] [RFC 0/5] Port Representor for control and monitoring of VF devices

2017-12-21 Thread Alex Rosenbaum
Declan, Mohammad, The submission [1] of steering action between switch ports clearly requires a switch model in DPDK. The Port Representor based on a virtual PMD broker on NIC ops (rte_dev_ops) does not provide the required functionality. Using NIC terminology and not Switch API's will lead to a d

Re: [dpdk-dev] [PATCH v1 5/6] fix missing includes in exported headers

2017-12-21 Thread Adrien Mazarguil
On Thu, Dec 21, 2017 at 02:12:57PM +, Bruce Richardson wrote: > On Thu, Dec 21, 2017 at 02:00:04PM +0100, Adrien Mazarguil wrote: > > Many exported headers rely on definitions found in rte_config.h without > > including it, as shown by the following command: > > > > grep -L '^#include ' -- \

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix VLAN configuration after port stop

2017-12-21 Thread Shahaf Shuler
Wednesday, December 13, 2017 4:03 PM, Shahaf Shuler: > Ethdev layer has an API to configure vlan setting on the flight, i.e. > when the port state is start. > > calling such API when the port is stopped may cause segmentation fault as > the related Verbs contexts has not been created yet. > > Fix

Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API

2017-12-21 Thread Shahaf Shuler
Wednesday, December 13, 2017 7:32 PM, Jerin Jacob: > > OK. I just suggested because adding the flag in PMD is harmless and we can > avoid an extra check(setting the DEV_TX_OFFLOAD_MBUF_FAST_FREE only > when PMD supports it) in application to hide warning as you pointed out. > No strong opinion on

Re: [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-21 Thread Adrien Mazarguil
On Thu, Dec 21, 2017 at 12:12:29PM +0200, Boris Pismenny wrote: > On 12/21/2017 10:06 AM, Anoob Joseph wrote: > > I can see the benefits of using rte_flow in both rx & tx, but this > > unnecessarily introduces hardware requirements for supporting inline. > > Rte_flow would do two operations: > >

Re: [dpdk-dev] [PATCHv4 0/4] dpdk: enhance EXPERIMENTAL api tagging

2017-12-21 Thread Neil Horman
On Wed, Dec 13, 2017 at 10:17:23AM -0500, Neil Horman wrote: > Hey all- > A few days ago, I was lamenting the fact that, when reviewing patches > I > would frequently complain about ABI changes that were actually considered safe > because they were part of the EXPERIMENTAL api set. John M

Re: [dpdk-dev] [PATCH v1 5/6] fix missing includes in exported headers

2017-12-21 Thread Bruce Richardson
On Thu, Dec 21, 2017 at 02:00:04PM +0100, Adrien Mazarguil wrote: > Many exported headers rely on definitions found in rte_config.h without > including it, as shown by the following command: > > grep -L '^#include ' -- \ > $(grep -Rl \ > $(sed -n '/^#define \([^ ]\+\).*$/{s//\1/;H;};${x;s/\

[dpdk-dev] [PATCH] doc: add i40e update in release note

2017-12-21 Thread Jingjing Wu
From: Beilei Xing Updates 17.11 release note to declare GTPU/GTPC support in i40e driver. Signed-off-by: Beilei Xing --- doc/guides/rel_notes/release_17_11.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release

Re: [dpdk-dev] [PATCH v2 05/39] examples/l3fwd: move to ethdev offloads API

2017-12-21 Thread Shahaf Shuler
>Looking at diff between v1 and v2, following lines are missing: > >- port_conf.rxmode.offloads &= dev_info.rx_offload_capa; >- port_conf.txmode.offloads &= dev_info.tx_offload_capa; > >I can see this change is consistent across all examples. Is it intent

Re: [dpdk-dev] [RFC v2 3/5] ether: Add flow timeout support

2017-12-21 Thread Alex Rosenbaum
On Thu, Dec 21, 2017 at 4:35 AM, Qi Zhang wrote: > Add new APIs to support flow timeout, application is able to > 1. Setup the time duration of a flow, the flow is expected to be deleted > automatically when timeout. Can you explain how the application (OVS) is expected to use this API? It will h

Re: [dpdk-dev] [PATCH v2 03/39] examples/l2fwd-jobstats: convert to new ethdev offloads API

2017-12-21 Thread Shahaf Shuler
Tuesday, December 19, 2017 2:33 PM, De Lara Guarch, Pablo: > > There is a compilation error when building for 32-bit targets: > > examples/l2fwd-jobstats/main.c:883:11: error: format '%lx' expects > argument of type 'long unsigned int', but argument 3 has type 'uint64_t {aka > long long unsigned

Re: [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: convert to new ethdev offloads API

2017-12-21 Thread Shahaf Shuler
Hi Pablo and maintainers of ipsec-secgw, Tuesday, December 19, 2017 2:39 PM, De Lara Guarch, Pablo > > diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec- > > secgw/ipsec-secgw.c index c98454a..1e8af8d 100644 > > --- a/examples/ipsec-secgw/ipsec-secgw.c > > +++ b/examples/ipsec-secgw

Re: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user

2017-12-21 Thread Wiles, Keith
> On Dec 21, 2017, at 10:53 AM, Vipin Varghese wrote: > > TAP speed is passed as user argument, but never set to interface. > New logic brings speed get and set to LOCAL and REMOTE interfaces. > > Updated the default PMD speeed to 10M as per Linux Kernel default > value. The problem in settin

Re: [dpdk-dev] [RFC v2 0/5] rte_flow extension for vSwitch acceleration

2017-12-21 Thread Alex Rosenbaum
On Thu, Dec 21, 2017 at 4:35 AM, Qi Zhang wrote: > This patch extend rte_flow API. > The purpose is to provide comfortable programming interface for virtual switch > software (such as OVS) to take advantage of incoming device's vSwitch > acceleration > capability when using DPDK as data plane. >

[dpdk-dev] [PATCH v1 6/6] net: fix rte_ether conflicts with libc

2017-12-21 Thread Adrien Mazarguil
Applications can't combine either net/ethernet.h or netinet/ether.h together with rte_ether.h due to the redefinition of struct ether_addr and various macros by the latter. This patch adapts rte_ether.h to rely on system definitions while maintaining DPDK additions. An unforeseen consequence of i

[dpdk-dev] [PATCH v1 4/6] member: fix issue in exported header

2017-12-21 Thread Adrien Mazarguil
Reported by check-includes.sh: [...]/rte_member.h:107:40: error: ISO C does not permit named variadic macros [-Werror=variadic-macros] #define RTE_MEMBER_LOG(level, fmt, args...) \ ^ Fixes: 857ed6c68cf2 ("member: implement main API") Cc: Yipeng Wan

[dpdk-dev] [PATCH v1 5/6] fix missing includes in exported headers

2017-12-21 Thread Adrien Mazarguil
Many exported headers rely on definitions found in rte_config.h without including it, as shown by the following command: grep -L '^#include ' -- \ $(grep -Rl \ $(sed -n '/^#define \([^ ]\+\).*$/{s//\1/;H;};${x;s/\n//;s/\n/\\|/g;p;}' \ build/include/rte_config.h) \ -- build/include

[dpdk-dev] [PATCH v1 2/6] net/i40e: fix issue in exported header

2017-12-21 Thread Adrien Mazarguil
Reported by check-includes.sh: [...]/rte_pmd_i40e.h:97:30: error: ISO C restricts enumerator values to range of `int' [-Werror=pedantic] RTE_PMD_I40E_PKG_INFO_MAX = 0x ^ Fixes: edeab742edac ("net/i40e: get information about DDP profile") Cc: Andrey

[dpdk-dev] [PATCH v1 3/6] flow_classify: fix issue in exported header

2017-12-21 Thread Adrien Mazarguil
Reported by check-includes.sh: [...]/rte_flow_classify.h:85:47: error: ISO C does not permit named variadic macros [-Werror=variadic-macros] #define RTE_FLOW_CLASSIFY_LOG(level, fmt, args...) \ ^ Fixes: be41ac2a330f ("flow_classify: introduc

[dpdk-dev] [PATCH v1 0/6] Address various issues with exported headers

2017-12-21 Thread Adrien Mazarguil
Exported header files are installed system-wide and must be as clean and self-sufficient as possible. In particular they must not conflict with other system headers and cannot assume specific command-line options will be provided to the compiler by users, unless their absence is detected and trigge

[dpdk-dev] [PATCH v1 1/6] devtools: update check-includes exceptions

2017-12-21 Thread Adrien Mazarguil
rte_eal_interrupts.h is an internal file not supposed to be included directly by applications. Signed-off-by: Adrien Mazarguil Cc: Bruce Richardson --- devtools/check-includes.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/devtools/check-includes.sh b/devtools/check-includes.sh index c4

Re: [dpdk-dev] [PATCH v4] vhost_user: protect active rings from async ring changes

2017-12-21 Thread Victor Kaplansky
- Original Message - > From: "Stephen Hemminger" > To: "Victor Kaplansky" > Cc: dev@dpdk.org, sta...@dpdk.org, "Jens Freimann" , > "Maxime Coquelin" > , "Yuanhan Liu" , "Tiwei > Bie" , "Jianfeng > Tan" > Sent: Wednesday, December 20, 2017 10:19:45 PM > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [RFC v2 1/5] ether: add flow action to redirect packet in a switch domain

2017-12-21 Thread Alex Rosenbaum
On Thu, Dec 21, 2017 at 4:35 AM, Qi Zhang wrote: > Add action RTE_FLOW_ACTION_TYPE_SWITCH_PORT, it can be used to redirect I guess the word "SWITCH" should be remove from commit message. you don't use it later in the patch. > > +Action: ``PORT`` > + > + > +Redirect packets to an

Re: [dpdk-dev] [PATCH 2/2] test/test: add return value to mark unit tests as skipped

2017-12-21 Thread Bruce Richardson
On Thu, Dec 21, 2017 at 10:48:22AM +, Van Haaren, Harry wrote: > > From: Richardson, Bruce > > Sent: Thursday, December 21, 2017 10:23 AM > > To: dev@dpdk.org; Doherty, Declan ; De Lara > > Guarch, Pablo > > Cc: Van Haaren, Harry > > Subject: Re: [PATCH 2/2] test/test: add return value to mar

[dpdk-dev] [PATCH 1/2] test: use env variable to run tests

2017-12-21 Thread Harry van Haaren
With this patch the test binary checks the DPDK_TEST environment variable and if set, the contents of the var are inserted on the test app command line, and run. Signed-off-by: Bruce Richardson Signed-off-by: Harry van Haaren --- Note that this patch is the combination of multiple patches that

  1   2   >