Re: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: fix usage of incorrect port

2017-12-11 Thread Akhil Goyal
Hi Anoob, One minor comment inline. Please correct it. Apart from that, Acked-by: Akhil Goyal Thanks. On 12/11/2017 9:05 PM, Anoob Joseph wrote: When security offload is enabled, the packet should be forwarded on the port configured in the SA. Security session will be configured on that port

Re: [dpdk-dev] [PATCH 0/3] generic channel for multi-process communication

2017-12-11 Thread Tan, Jianfeng
Hi Anatoly, > -Original Message- > From: Burakov, Anatoly > Sent: Monday, December 11, 2017 6:00 PM > To: Tan, Jianfeng; dev@dpdk.org > Cc: Richardson, Bruce; Ananyev, Konstantin; tho...@monjalon.net > Subject: Re: [PATCH 0/3] generic channel for multi-process communication > > On 30-Nov-

Re: [dpdk-dev] [PATCH] eventdev: use links_map to unlink queues

2017-12-11 Thread Pavan Nikhilesh Bhagavatula
On Mon, Dec 11, 2017 at 05:24:57PM +, Eads, Gage wrote: > > > -Original Message- > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Monday, December 11, 2017 9:05 AM > > To: Eads, Gage ; jerin.ja...@caviumnetworks.com; > > Richardson, Bruce ; nipun.gu...@nxp.co

Re: [dpdk-dev] [PATCH v3 8/8] doc: update app eventdev options

2017-12-11 Thread Pavan Nikhilesh Bhagavatula
On Mon, Dec 11, 2017 at 05:34:50PM +, Eads, Gage wrote: > Once the compilation errors are fixed: > (Series) Acked-by: Gage Eads > Thanks for the ack, The compilation issues have been fixed but for some reason patchworks failed to apply the patset Pavan.

[dpdk-dev] [PATCH] doc: add i40e limitation of DCB function

2017-12-11 Thread Beilei Xing
This patch adds limitation of DCB function. Signed-off-by: Beilei Xing --- doc/guides/nics/i40e.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index cd46874..2507d5f 100644 --- a/doc/guides/nics/i40e.rst +++ b/doc/guides/nics/i40e

Re: [dpdk-dev] [PATCH v3 1/2] examples/ipsec-secgw: fix missing ingress flow attribute

2017-12-11 Thread Anoob Joseph
On 12/11/2017 07:34 PM, Nelio Laranjeiro wrote: Generic flow API have both direction bits, ingress and egress for rules which may work on both sides. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: akhil.go...@nxp.com Signed-off-by: Nelio Laranjeiro Acked-by: Radu

Re: [dpdk-dev] [PATCH v1 2/8] bus: introduce opaque control framework

2017-12-11 Thread Shreyansh Jain
On Monday 11 December 2017 08:08 PM, Gaëtan Rivet wrote: On Mon, Dec 11, 2017 at 07:06:55PM +0530, Shreyansh Jain wrote: On Monday 11 December 2017 06:13 PM, Gaëtan Rivet wrote: On Mon, Dec 11, 2017 at 05:30:16PM +0530, Shreyansh Jain wrote: On Thursday 12 October 2017 01:48 PM, Gaetan Rivet w

Re: [dpdk-dev] [PATCH v4] examples/ipsec-secgw: fix usage of incorrect port

2017-12-11 Thread Anoob Joseph
Hi Akhil, Radu, I've updated the patch with the suggestions. But I think it will be better if we have two separate get_hop_for_offload_pkt() functions(for ipv4 & ipv6), since the return type etc is different. It might be cleaner that way. Thanks, Anoob On 12/11/2017 09:05 PM, Anoob Joseph

Re: [dpdk-dev] [PATCH v4 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-11 Thread Ladi Prosek
On Mon, Dec 11, 2017 at 4:14 PM, Maxime Coquelin wrote: > Hi, > > This fourth revision fixes patch 1 by not returning early in > SET_FEATURE handling if new features bitfield is same as previous > one. Indeed, as reported by Tiwei, in case negotiated features is 0, > it would return early whereas

Re: [dpdk-dev] [PATCH 14/39] examples/ip_reassembly: convert to new ethdev offloads API

2017-12-11 Thread Shahaf Shuler
Monday, December 11, 2017 5:04 PM, Ananyev, Konstantin: > > + if ((dev_info.tx_offload_capa & port_conf.txmode.offloads) > != > > + port_conf.txmode.offloads) { > > + printf("Some Tx offloads are not supported " > > + "by port %d: r

[dpdk-dev] check_port_config error

2017-12-11 Thread Pragash Vijayaragavan
Hi, I am trying to run dpdk app l3fwd but gives some errors. I bind my nics using dpdk-dev-bind script. I also set env variables correctly. The nb_ports is 0 when i tried printing that inside "check_port_config" function. Also I used "igb_uio" module but it still shows net_i40e can someone hel

Re: [dpdk-dev] [PATCH] vhost_user: protect active rings from async ring changes

2017-12-11 Thread Tan, Jianfeng
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Friday, December 8, 2017 6:12 PM > To: Tan, Jianfeng; Victor Kaplansky; dev@dpdk.org; y...@fridaylinux.org; Bie, > Tiwei > Cc: sta...@dpdk.org; jfrei...@redhat.com > Subject: Re: [PATCH] vhost_user: p

Re: [dpdk-dev] [PATCH 06/14] bus/fslmc: add braces for pointers in macros

2017-12-11 Thread Hemant Agrawal
On 12/12/2017 6:22 AM, Ferruh Yigit wrote: On 12/7/2017 9:21 PM, Hemant Agrawal wrote: From: Nipun Gupta Signed-off-by: Nipun Gupta Hi Hemant, Since patch sent by you, I assume you ack the patch but for further patches, can you please put explicit ack for the patches that author is not a m

Re: [dpdk-dev] [PATCH 08/14] net/dpaa2: add Rx queue count support

2017-12-11 Thread Hemant Agrawal
On 12/12/2017 6:58 AM, Stephen Hemminger wrote: On Fri, 8 Dec 2017 10:51:21 +0530 Hemant Agrawal wrote: @@ -1737,6 +1769,7 @@ static struct eth_dev_ops dpaa2_ethdev_ops = { I know this is not part of the patch, but this diff highlighted another thing to addreess in this family of driver. Th

Re: [dpdk-dev] [RFC v2] lib: add compressdev API

2017-12-11 Thread Verma, Shally
> -Original Message- > From: Trahe, Fiona [mailto:fiona.tr...@intel.com] > Sent: 11 December 2017 23:52 > To: Verma, Shally ; dev@dpdk.org > Cc: Athreya, Narayana Prasad ; > Challa, Mahipal ; De Lara Guarch, Pablo > ; Gupta, Ashish > ; Sahu, Sunila ; > Trahe, Fiona > Subject: RE: [RFC v2

Re: [dpdk-dev] [PATCH] net/i40e: do not turn on flexible payload on driver init

2017-12-11 Thread Xing, Beilei
> -Original Message- > From: Xing, Beilei > Sent: Monday, December 11, 2017 2:00 PM > To: Rybalchenko, Kirill ; dev@dpdk.org > Cc: Chilikin, Andrey ; Wu, Jingjing > > Subject: RE: [PATCH] net/i40e: do not turn on flexible payload on driver init > > > -Original Message- > > From:

Re: [dpdk-dev] [PATCH] igb_uio: allow multi-process access

2017-12-11 Thread Stephen Hemminger
On Fri, 8 Dec 2017 17:57:33 -0800 Xiao Wang wrote: > In some case, one device are accessed by different processes via > different BARs, so one uio device may be opened by more than one > process, for this case we just need to enable interrupt once, and > pci_clear_master only when the last proce

Re: [dpdk-dev] [PATCH] net/failsafe: add Rx interrupts

2017-12-11 Thread Stephen Hemminger
On Mon, 11 Dec 2017 14:41:47 +0200 Moti Haimovsky wrote: > + for (i = 0; i < n; i++) { > + rxq = (struct rxq *)events[i].epdata.data; Minor nit. events[i].epdata.data is "void *" therefore cast is unnecessary.

Re: [dpdk-dev] [PATCH 08/14] net/dpaa2: add Rx queue count support

2017-12-11 Thread Stephen Hemminger
On Fri, 8 Dec 2017 10:51:21 +0530 Hemant Agrawal wrote: > @@ -1737,6 +1769,7 @@ static struct eth_dev_ops dpaa2_ethdev_ops = { I know this is not part of the patch, but this diff highlighted another thing to addreess in this family of driver. The eth_dev_ops should be const if possible that re

[dpdk-dev] [PATCH v2] net/i40e: exclude LLDP packet count

2017-12-11 Thread Qi Zhang
When use port stats register to calculate the packet count, LLDP packets are counted in statistics which is not expected, the patch exclude this number from total number. Fixes: 763de290cbd1 ("net/i40e: fix packet count for PF") Cc sta...@dpdk.org Signed-off-by: Qi Zhang --- v2: - fix some typo

Re: [dpdk-dev] [PATCH] examples: remove unnecessary function calls

2017-12-11 Thread Prashant Bhole
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > > On 12/10/2017 11:31 PM, Prashant Bhole wrote: > > Removed rte_eth_dev_info_get() calls and declaration of struct > > rte_eth_dev_info where info is not used anymore > > > > Signed-off-by: Prashant Bhole > > R

Re: [dpdk-dev] [PATCH 00/14] DPAA2 PMD fixes and enhancements

2017-12-11 Thread Ferruh Yigit
On 12/7/2017 9:21 PM, Hemant Agrawal wrote: > > This patch set contains some basic fixes, enhancements and optimzations > for DPAA2 driver. > > > Ashish Jain (1): > net/dpaa2: align the frame size in MTU set > > Hemant Agrawal (8): > bus/fslmc: fix the cplusplus macro closure > drivers: c

Re: [dpdk-dev] [PATCH 03/14] bus/fslmc: add support for dynamic iova for DPAA2 devices

2017-12-11 Thread Ferruh Yigit
On 12/7/2017 9:21 PM, Hemant Agrawal wrote: > This patch add support for dynamic iova detection for DPAA2 > devices and use of virtual address in such cases. > > Signed-off-by: Hemant Agrawal > --- > drivers/bus/fslmc/fslmc_bus.c | 44 > + > drivers/bus

Re: [dpdk-dev] [PATCH 06/14] bus/fslmc: add braces for pointers in macros

2017-12-11 Thread Ferruh Yigit
On 12/7/2017 9:21 PM, Hemant Agrawal wrote: > From: Nipun Gupta > > Signed-off-by: Nipun Gupta Hi Hemant, Since patch sent by you, I assume you ack the patch but for further patches, can you please put explicit ack for the patches that author is not a maintainer? Thanks, ferruh

[dpdk-dev] [PATCH] l3fwd: set cli back to unix style

2017-12-11 Thread Stephen Hemminger
The l3fwd program became chatty, and the code looks cluttered in recent versions. DPDK programs should try for Unix (not VMS) style and not print messages for the options user selected. Also, errors should be printed on stderr. To make it easier to find code matching error messages; error strings s

[dpdk-dev] Fwd: Re: Poor OVS-DPDK performance

2017-12-11 Thread abhishek jain
-- Forwarded message -- From: "abhishek jain" Date: Dec 11, 2017 12:25 Subject: Re: Poor OVS-DPDK performance To: "Mooney, Sean K" Cc: "us...@dpdk.org" Hi Team I'm targeting phy-VM-phy numbers I'm having 8 core host with HT turned on with 16 threads.Below is the output desc

Re: [dpdk-dev] [PATCH 02/11] crypto/ccp: add support for AMD CCP crypto PMD

2017-12-11 Thread De Lara Guarch, Pablo
Hi Ravi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar > Sent: Thursday, November 30, 2017 1:12 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 02/11] crypto/ccp: add support for AMD CCP > crypto PMD > As I said in the another patch, you should

Re: [dpdk-dev] [PATCH 05/11] crypto/ccp: add support for CPU based authentication

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar > Sent: Thursday, November 30, 2017 1:12 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 05/11] crypto/ccp: add support for CPU based > authentication When enabling this, I got the following error:

[dpdk-dev] [PATCHv3 4/4] dpdk: add __experimental tag to appropriate api calls

2017-12-11 Thread Neil Horman
Append the __experimental tag to api calls appearing in the EXPERIMENTAL section of their libraries version map Signed-off-by: Neil Horman CC: Thomas Monjalon CC: "Mcnamara, John" CC: Bruce Richardson --- lib/librte_eal/common/eal_common_dev.c | 6 ++- lib/librte_eal/common/eal_c

[dpdk-dev] [PATCHv3 1/4] buildtools: Add tool to check EXPERIMENTAL api exports

2017-12-11 Thread Neil Horman
This tools reads the given version map for a directory, and checks to ensure that, for each symbol listed in the export list, the corresponding definition is tagged as __experimental, erroring out if its not. In this way, we can ensure that the EXPERIMENTAL api is kept in sync with the tags Signe

[dpdk-dev] [PATCHv3 3/4] Makefiles: Add experimental tag check and warnings to trigger on use

2017-12-11 Thread Neil Horman
Add checks during build to ensure that all symbols in the EXPERIMENTAL version map section have __experimental tags on their definitions, and enable the warnings needed to announce their use. Also add an ALLOW_EXPERIMENTAL_APIS define to allow individual libraries and files to declare the acceptab

[dpdk-dev] [PATCHv3 2/4] compat: Add __experimental macro

2017-12-11 Thread Neil Horman
The __experimental macro tags a given exported function as being part of the EXPERIMENTAL api. Use of this tag will cause any caller of the function (that isn't removed by dead code elimination) to emit a warning that the user is making use of an API whos stabilty isn't guaranteed. It also places

[dpdk-dev] [PATCHv3 0/4] dpdk: enhance EXPERIMENTAL api tagging

2017-12-11 Thread Neil Horman
Hey all- A few days ago, I was lamenting the fact that, when reviewing patches I would frequently complain about ABI changes that were actually considered safe because they were part of the EXPERIMENTAL api set. John M. asked me then what I might do to improve the situation, and the follow

Re: [dpdk-dev] [PATCH 07/11] doc: add document for AMD CCP crypto PMD

2017-12-11 Thread De Lara Guarch, Pablo
Hi Ravi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar > Sent: Thursday, November 30, 2017 1:12 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 07/11] doc: add document for AMD CCP crypto > PMD > > Signed-off-by: Ravi Kumar > --- > doc/guides/

Re: [dpdk-dev] [PATCH 11/11] crypto/ccp: update CCP PMD code-base

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar > Sent: Thursday, November 30, 2017 1:13 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 11/11] crypto/ccp: update CCP PMD code-base > > Signed-off-by: Ravi Kumar It looks like this is an incremen

Re: [dpdk-dev] [PATCH v3 5/5] bbdev: documentation

2017-12-11 Thread Ferruh Yigit
On 12/7/2017 1:40 PM, Amr Mokhtar wrote: > - Wireless Baseband Device Library Programmer’s Guide > - test-bbdev User Guide > - BBDEV Sample Application User Guides > - Baseband Device Drivers Guides > - Doxygen API > > Signed-off-by: Amr Mokhtar > --- > doc/api/doxy-api-index.md |

Re: [dpdk-dev] [PATCH v3 3/5] bbdev: test applications

2017-12-11 Thread Ferruh Yigit
On 12/7/2017 1:40 PM, Amr Mokhtar wrote: > - Full test suite for bbdev > - Test App works seamlessly on all PMDs registered with bbdev > framework > - A python script is provided to make our life easier Can you please describe what the script is for? > - Supports execution of tests by parsing Te

Re: [dpdk-dev] [PATCH v3 2/5] bbdev: PMD drivers (null/turbo_sw)

2017-12-11 Thread Ferruh Yigit
On 12/7/2017 1:40 PM, Amr Mokhtar wrote: > - bbdev 'null' PMD enabled by default > - bbdev 'turbo_sw' PMD disabled by default Can you please separate PMDs into their own patches. > - 'turbo_sw' requires the external FLEXRAN SDK libraries > > Signed-off-by: Amr Mokhtar <...> > +static const st

Re: [dpdk-dev] [PATCH 1/5] pmdinfogen: fix cross compilation for ARM BE

2017-12-11 Thread Neil Horman
On Mon, Dec 11, 2017 at 12:40:32PM +, Bruce Richardson wrote: > On Thu, Nov 02, 2017 at 03:38:51PM +0530, Hemant Agrawal wrote: > > cross compiling DPDK for BE mode on ARM results into errors > > > > "PMDINFO portal/dpaa2_hw_dpio.o.pmd.c No drivers registered" > > > > Fixes: 98b0fdb0ffc6 ("pm

Re: [dpdk-dev] [PATCHv2 3/4] Makefiles: Add experimental tag check and warnings to trigger on use

2017-12-11 Thread Neil Horman
On Mon, Dec 11, 2017 at 12:45:50PM +, Bruce Richardson wrote: > On Mon, Dec 11, 2017 at 07:40:43AM -0500, Neil Horman wrote: > > On Mon, Dec 11, 2017 at 11:35:57AM +, Bruce Richardson wrote: > > > On Fri, Dec 08, 2017 at 12:14:34PM -0500, Neil Horman wrote: > > > > Add checks during build t

Re: [dpdk-dev] [RFC v2] lib: add compressdev API

2017-12-11 Thread Trahe, Fiona
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Thursday, December 7, 2017 9:59 AM > To: Trahe, Fiona ; dev@dpdk.org > Cc: Athreya, Narayana Prasad ; Challa, > Mahipal > ; De Lara Guarch, Pablo > ; Gupta, > Ashish ; Sahu, Sunila > Subject: RE: [RFC v

Re: [dpdk-dev] [PATCH] examples: remove unnecessary function calls

2017-12-11 Thread Ferruh Yigit
On 12/10/2017 11:31 PM, Prashant Bhole wrote: > Removed rte_eth_dev_info_get() calls and declaration of struct > rte_eth_dev_info > where info is not used anymore > > Signed-off-by: Prashant Bhole Reviewed-by: Ferruh Yigit At any point in the history were they used? If so, can you please add

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: added switch_domain and representor port flag

2017-12-11 Thread Mohammad Abdul Awal
Hi Alex, On 11/12/2017 13:45, Alex Rosenbaum wrote: Mohammad, I did not see a v2 change log. did I miss it? please send. The V2 change is for vdev handling by the representor PMD as the vdev API location changed from DPDK 17.08 to 17.11. So, V2 patch mainly a rebased against DPDK 17.11. I

[dpdk-dev] [PATCH v2 2/2] event/sw: simplify credit scheme

2017-12-11 Thread Gage Eads
This commit modifies the sw PMD credit scheme such that credits are consumed when enqueueing a NEW event and released when an event is released -- typically, the beginning and end of a pipeline. Workers that simply forward events do not interact with the credit pool. Signed-off-by: Gage Eads Acke

[dpdk-dev] [PATCH v2 1/2] eventdev: add implicit release disable capability

2017-12-11 Thread Gage Eads
This commit introduces a capability for disabling the "implicit" release functionality for a port, which prevents the eventdev PMD from issuing outstanding releases for previously dequeued events when dequeuing a new batch of events. If a PMD does not support this capability, the application will

Re: [dpdk-dev] [PATCH] net: update licence for network headers

2017-12-11 Thread Ferruh Yigit
On 12/10/2017 9:27 PM, Hemant Agrawal wrote: > On 12/8/2017 11:52 PM, Andrew Rybchenko wrote: >> On 12/08/2017 08:29 PM, Ferruh Yigit wrote: >>> On 12/8/2017 2:28 AM, Olivier Matz wrote: To be compliant with the DPDK licensing guidelines, switch to BSD-3-Clause. It can be done safely sinc

Re: [dpdk-dev] [PATCH 1/2] eventdev: add implicit release disable capability

2017-12-11 Thread Eads, Gage
Sure, will make all suggested changes in v2. > -Original Message- > From: Van Haaren, Harry > Sent: Monday, December 11, 2017 6:36 AM > To: Eads, Gage ; dev@dpdk.org > Cc: jerin.ja...@caviumnetworks.com; Richardson, Bruce > ; hemant.agra...@nxp.com; > nipun.gu...@nxp.com; santosh.shu...@ca

Re: [dpdk-dev] [PATCH v3 8/8] doc: update app eventdev options

2017-12-11 Thread Eads, Gage
Once the compilation errors are fixed: (Series) Acked-by: Gage Eads > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Monday, December 11, 2017 9:14 AM > To: jerin.ja...@caviumnetworks.com; Richardson, Bruce > ; Van Haaren, Harry > ; Eads, Gage

Re: [dpdk-dev] [PATCH 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb()

2017-12-11 Thread Ananyev, Konstantin
Hi Bruce, > -Original Message- > From: Richardson, Bruce > Sent: Monday, December 11, 2017 5:11 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] eal/x86: Use lock-prefixed instructions > to reduce cost of rte_smp_mb() > > On Fri, Dec 01, 2017 at 11:1

Re: [dpdk-dev] [PATCH] eventdev: use links_map to unlink queues

2017-12-11 Thread Eads, Gage
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Monday, December 11, 2017 9:05 AM > To: Eads, Gage ; jerin.ja...@caviumnetworks.com; > Richardson, Bruce ; nipun.gu...@nxp.com; > santosh.shu...@caviumnetworks.com; Van Haaren, Harry > ; hemant.ag

Re: [dpdk-dev] [PATCH 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb()

2017-12-11 Thread Bruce Richardson
On Fri, Dec 01, 2017 at 11:12:51AM +, Konstantin Ananyev wrote: > On x86 it is possible to use lock-prefixed instructions to get > the similar effect as mfence. > As pointed by Java guys, on most modern HW that gives a better > performance than using mfence: > https://shipilev.net/blog/2014/on

Re: [dpdk-dev] [PATCH 1/2] test/test: introduce new test-case for rte_smp_mb()

2017-12-11 Thread Bruce Richardson
On Fri, Dec 01, 2017 at 11:12:50AM +, Konstantin Ananyev wrote: > Simple functional test for rte_smp_mb() implementations. > Also when executed on a single lcore could be used as rough > estimation how many cycles particular implementation of rte_smp_mb() > might take. > > Signed-off-by: Konst

Re: [dpdk-dev] [PATCH 2/3] eal: add synchronous multi-process communication

2017-12-11 Thread Ananyev, Konstantin
> > > > @@ -485,7 +508,8 @@ rte_eal_mp_sendmsg(const char *action_name, > >const void *params, > >int len_params, > >int fds[], > > - int fds_num) > > + int fds_num, > > + int need_ack) > > I think "need_ack" i

Re: [dpdk-dev] [PATCH 10/13] examples/eventdev: add single stage pipeline worker

2017-12-11 Thread Eads, Gage
Hi Pavan, > static int > @@ -265,6 +350,7 @@ worker_do_tx_burst_atq(void *arg) > worker_fwd_event(&ev[i], > cdata.queue_type); > } > + work(ev[i].mbuf); Please move this change

Re: [dpdk-dev] [PATCH 1/3] eal: add channel for multi-process communication

2017-12-11 Thread Ananyev, Konstantin
Hi Jianfeng, > -Original Message- > From: Tan, Jianfeng > Sent: Thursday, November 30, 2017 6:44 PM > To: dev@dpdk.org > Cc: Burakov, Anatoly ; Richardson, Bruce > ; Ananyev, Konstantin > ; tho...@monjalon.net; Tan, Jianfeng > > Subject: [PATCH 1/3] eal: add channel for multi-process co

Re: [dpdk-dev] [PATCH 39/39] examples/skeleton: convert to new ethdev offloads API

2017-12-11 Thread Bruce Richardson
On Thu, Nov 23, 2017 at 02:19:41PM +0200, Shahaf Shuler wrote: > Ethdev offloads API has changed since: > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > This commit support the new API. > > Signed-off-by: Sh

Re: [dpdk-dev] [PATCH 37/39] examples/rxtx_callbacks: convert to new ethdev offloads API

2017-12-11 Thread Bruce Richardson
On Thu, Nov 23, 2017 at 02:19:39PM +0200, Shahaf Shuler wrote: > Ethdev offloads API has changed since: > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > This commit support the new API. > > Signed-off-by: Sh

Re: [dpdk-dev] [PATCH 30/39] examples/distributor: convert to new ethdev offloads API

2017-12-11 Thread Bruce Richardson
On Thu, Nov 23, 2017 at 02:19:32PM +0200, Shahaf Shuler wrote: > Ethdev offloads API has changed since: > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > This commit support the new API. > > Signed-off-by: Sh

Re: [dpdk-dev] [PATCH 02/13] examples/eventdev: move common data into pipeline common

2017-12-11 Thread Eads, Gage
Hi Pavan, > @@ -2,6 +2,7 @@ > * BSD LICENSE > * > * Copyright(c) 2016-2017 Intel Corporation. All rights reserved. > + * Copyright 2016 Cavium, Inc. Should this be 2017? Same for the copyright dates in pipeline_common.h.

Re: [dpdk-dev] [PATCH 01/13] examples/eventdev: add Rx adapter support

2017-12-11 Thread Eads, Gage
Hi Pavan, > static inline void > schedule_devices(unsigned int lcore_id) { > if (fdata->rx_core[lcore_id] && (fdata->rx_single || > rte_atomic32_cmpset(&(fdata->rx_lock), 0, 1))) { > - producer(); > + rte_service_run_iter_on_app_lcore(fdata->rxadptr_ser

[dpdk-dev] [PATCH v2 3/4] examples/flow_classify: update sample application

2017-12-11 Thread Jasvinder Singh
Update the flow_classify sample app to adapt the changes. Signed-off-by: Jasvinder Singh --- v2: - use validate api to verify before adding flow rule examples/flow_classify/flow_classify.c | 36 +++--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/e

[dpdk-dev] [PATCH v2 4/4] doc: update documentation for flow classify lib

2017-12-11 Thread Jasvinder Singh
Updates the documentation for flow classification library and sample application. Signed-off-by: Jasvinder Singh --- v2: - replace parse flow function with validate API doc/guides/prog_guide/flow_classify_lib.rst | 59 - doc/guides/sample_app_ug/flow_classify.rst |

[dpdk-dev] [PATCH v2 2/4] test/test_flow_classify: update test to accomodate changes

2017-12-11 Thread Jasvinder Singh
Test have ben modified to adapt the flow_classify api changes. Signed-off-by: Jasvinder Singh --- v2: - add validate API tests test/test/test_flow_classify.c | 178 + test/test/test_flow_classify.h | 10 ++- 2 files changed, 135 insertions(+), 53 deleti

[dpdk-dev] [PATCH v2 1/4] lib/librte_flow_classify: remove table id parameter from apis

2017-12-11 Thread Jasvinder Singh
This patch removes table id parameter from all the flow classify apis to reduce the complexity alongwith some code cleanup. The validate api is exposed as public api to allow user to validate the flow before adding it to the classifier. Signed-off-by: Jasvinder Singh --- v2: - break the patche i

Re: [dpdk-dev] [PATCH v4 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-11 Thread Laszlo Ersek
On 12/11/17 16:14, Maxime Coquelin wrote: > Hi, > > This fourth revision fixes patch 1 by not returning early in > SET_FEATURE handling if new features bitfield is same as previous > one. Indeed, as reported by Tiwei, in case negotiated features is 0, > it would return early whereas it should set

Re: [dpdk-dev] [PATCH 3/3] doc: update documentation for flow classify lib

2017-12-11 Thread Singh, Jasvinder
> -Original Message- > From: Mcnamara, John > Sent: Monday, December 11, 2017 2:55 PM > To: Singh, Jasvinder ; dev@dpdk.org > Cc: Iremonger, Bernard > Subject: RE: [dpdk-dev] [PATCH 3/3] doc: update documentation for flow > classify lib > > > > > -Original Message- > > From: d

Re: [dpdk-dev] [PATCH 2/3] lib/librte_flow_classy: add run api for flow classification

2017-12-11 Thread Singh, Jasvinder
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, December 6, 2017 12:41 PM > To: Iremonger, Bernard ; Singh, Jasvinder > ; dev@dpdk.org > Subject: RE: [PATCH 2/3] lib/librte_flow_classy: add run api for flow > classification > > Hi Jasvinder, > > > > > > > -Origi

Re: [dpdk-dev] [PATCH 1/3] lib/librte_flow_classify: remove table id parameter from apis

2017-12-11 Thread Singh, Jasvinder
> -Original Message- > From: Iremonger, Bernard > Sent: Wednesday, December 6, 2017 12:34 PM > To: Iremonger, Bernard ; Singh, Jasvinder > ; dev@dpdk.org > Subject: RE: [PATCH 1/3] lib/librte_flow_classify: remove table id parameter > from apis > > Hi Jasvinder, > > > > > -Original

Re: [dpdk-dev] [PATCH 3/4] app/eventdev: add perf pipeline test

2017-12-11 Thread Jerin Jacob
-Original Message- > Date: Mon, 11 Dec 2017 15:20:34 + > From: Pavan Nikhilesh Bhagavatula > To: Jerin Jacob , > harry.van.haa...@intel.com, bruce.richard...@intel.com, > hemant.agra...@nxp.com, nipun.gu...@nxp.com, nikhil@intel.com, > gage.e...@intel.com > Cc: dev@dpdk.org > Su

[dpdk-dev] [PATCH v4] examples/ipsec-secgw: fix usage of incorrect port

2017-12-11 Thread Anoob Joseph
When security offload is enabled, the packet should be forwarded on the port configured in the SA. Security session will be configured on that port only, and sending the packet on other ports could result in unencrypted packets being sent out. This would have performance improvements too, as the p

Re: [dpdk-dev] [PATCH 3/3] net: run-time function selection

2017-12-11 Thread Bruce Richardson
On Mon, Nov 06, 2017 at 10:05:43AM -0800, Elza Mathew wrote: > Compile-time function selection can potentially lead to > lower performance on generic builds done by distros. > Replaced compile time flag checks with run-time > function selection. > > Signed-off-by: Elza Mathew > --- > lib/librte_

Re: [dpdk-dev] [PATCH v2 4/6] net/representor: Implement port representor PMD

2017-12-11 Thread Remy Horton
On 11/12/2017 15:11, Mohammad Abdul Awal wrote: [..] Remy, devargs will be passed by the application who uses the rte_representor_port_register API. We are not talking about the EAL args here. Ah ok - it hadn't quite clicked in that Port Representors were not going to be transparent to applica

Re: [dpdk-dev] [PATCH 2/2] doc: Fix typo

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Roy Franz > Sent: Friday, December 1, 2017 6:27 PM > To: dev@dpdk.org > Cc: Roy Franz > Subject: [dpdk-dev] [PATCH 2/2] doc: Fix typo > > Fix trivial typo (an -> and) in description of service core masks. > > S

Re: [dpdk-dev] [PATCH 3/4] app/eventdev: add perf pipeline test

2017-12-11 Thread Pavan Nikhilesh Bhagavatula
On Sun, Dec 10, 2017 at 06:03:07PM +0530, Jerin Jacob wrote: > -Original Message- > > Date: Thu, 30 Nov 2017 12:54:05 +0530 > > From: Pavan Nikhilesh > > To: jerin.jacobkollanukka...@cavium.com, gage.e...@intel.com, > > harry.van.haa...@intel.com, bruce.richard...@intel.com, > > hemant.a

[dpdk-dev] [PATCH v4 3/4] vhost: extract virtqueue cleaning and freeing functions

2017-12-11 Thread Maxime Coquelin
This patch extracts needed code for vhost_user.c to be able to clean and free virtqueues unitary. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 22 -- lib/librte_vhost/vhost.h | 3 +++ 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/lib/librt

[dpdk-dev] [PATCH v4 4/4] vhost: destroy unused virtqueues when multiqueue not negotiated

2017-12-11 Thread Maxime Coquelin
QEMU sends VHOST_USER_SET_VRING_CALL requests for all queues declared in QEMU command line before the guest is started. It has the effect in DPDK vhost-user backend to allocate vrings for all queues declared by QEMU. If the first driver being used does not support multiqueue, the device never chan

[dpdk-dev] [PATCH v4 2/4] vhost: propagate VHOST_USER_SET_FEATURES handling error

2017-12-11 Thread Maxime Coquelin
Not propagating VHOST_USER_SET_FEATURES request handling error may result in unpredictable behavior, as host and guests features may no more be synchronized. This patch fixes this by reporting the error to the upper layer, which would result in the device being destroyed and the connection with th

[dpdk-dev] [PATCH v4 1/4] vhost: prevent features to be changed while device is running

2017-12-11 Thread Maxime Coquelin
As section 2.2 of the Virtio spec states about features negotiation: "During device initialization, the driver reads this and tells the device the subset that it accepts. The only way to renegotiate is to reset the device." This patch implements a check to prevent illegal features change while the

[dpdk-dev] [PATCH v3 8/8] doc: update app eventdev options

2017-12-11 Thread Pavan Nikhilesh
Update documentation about new --prod_type_ethdev option in app/eventdev. Signed-off-by: Pavan Nikhilesh Acked-by: John McNamara Acked-by: Jerin Jacob --- doc/guides/tools/testeventdev.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/doc/guides/tools/testeventdev.rst b

[dpdk-dev] [PATCH v4 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-11 Thread Maxime Coquelin
Hi, This fourth revision fixes patch 1 by not returning early in SET_FEATURE handling if new features bitfield is same as previous one. Indeed, as reported by Tiwei, in case negotiated features is 0, it would return early whereas it should set the Vnet header len. The change consists in returning

[dpdk-dev] [PATCH v3 7/8] app/eventdev: add service core configuration

2017-12-11 Thread Pavan Nikhilesh
Add service core configuration for Rx adapter. The configuration picks the least used service core to run the service on. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_common.h | 41 app/test-eventdev/test_perf_atq.c| 12 +++ app/

[dpdk-dev] [PATCH v3 6/8] app/eventdev: add event Rx adapter setup

2017-12-11 Thread Pavan Nikhilesh
Add functions to setup and configure Rx adapter based on the number of ethdev ports setup. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v3 Changes: - Fix compilation issues for gcc version < 5 v2 Changes: - Used default eventdev config values instead of hardcoded values. ap

[dpdk-dev] [PATCH v3 5/8] app/eventdev: add ethernet device tear down

2017-12-11 Thread Pavan Nikhilesh
Add ethernet device destroy functions to stop and close ethdev ports if they are configured when prod_type_ethdev option is enabled. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test-eventdev/test_perf_atq.c| 1 + app/test-eventdev/test_perf_common.c | 13 + app

[dpdk-dev] [PATCH v3 4/8] app/eventdev: add ethernet device setup helpers

2017-12-11 Thread Pavan Nikhilesh
Add ethernet device setup functions to configure ethdev ports incase prod_type_ethdev option is enabled. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v2 Changes: - Removed unnecessary "\n" from evt_err, reworked ethernet queue setup. app/test-eventdev/test_perf_atq.c| 1 +

[dpdk-dev] [PATCH v3 3/8] app/eventdev: add pktmbuf pool for ethdev

2017-12-11 Thread Pavan Nikhilesh
Add pktmbuf pool creation used when configuring ethernet device as event producer. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v2 Changes: - Set cache size as 512. app/test-eventdev/test_perf_common.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff -

Re: [dpdk-dev] [PATCH] doc: fix a typo in programmer's guide

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gong Deli > Sent: Monday, November 27, 2017 9:02 AM > To: Dumitrescu, Cristian ; Mcnamara, John > > Cc: dev@dpdk.org; Gong Deli > Subject: [dpdk-dev] [PATCH] doc: fix a typo in programmer's guide > > Fix the mis

[dpdk-dev] [PATCH v3 2/8] app/eventdev: modify app setup to support ethdev

2017-12-11 Thread Pavan Nikhilesh
Modify app setup to accommodate event port and queue setup based on the number of ethernet ports. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v2 Changes: - Removed unnecessary RTE_SET_USED() macros. app/test-eventdev/test_perf_atq.c| 17 + app/test-eventde

[dpdk-dev] [PATCH v3 1/8] app/eventdev: add ethernet device producer option

2017-12-11 Thread Pavan Nikhilesh
Add command line option --prod_type_ethdev to specify that the events are generated by ethernet device. Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- v2 Changes: - Modified 'evt_parse_prod_type' to 'evt_parse_eth_prod_type' to accommodate other kinds of producers in future.

Re: [dpdk-dev] [PATCH v2 4/6] net/representor: Implement port representor PMD

2017-12-11 Thread Mohammad Abdul Awal
On 11/12/2017 10:08, Remy Horton wrote: int rte_representor_port_register(const char *devargs); Question is where this *devargs comes from - I don't think there is currently any commandline option to specify a parameter string for PFs. Remy, devargs will be passed by the application who us

[dpdk-dev] [PATCH] eventdev: use links_map to unlink queues

2017-12-11 Thread Pavan Nikhilesh
The octeontx event device doesn't store the queues to port mapping as a result it cannot return the exact number of queues unlinked from a port when application wants to unlink all the queues mapped (supplies queues param as NULL). Using links_map we can determine the exact queues mapped to a spec

Re: [dpdk-dev] [PATCH 14/39] examples/ip_reassembly: convert to new ethdev offloads API

2017-12-11 Thread Ananyev, Konstantin
Hi Shahaf, > + if ((dev_info.rx_offload_capa & port_conf.rxmode.offloads) != > + port_conf.rxmode.offloads) { > + printf("Some Rx offloads are not supported " > +"by port %d: requested 0x%lx supported 0x%lx\n", > +

Re: [dpdk-dev] [PATCH 2/2] doc: add description of raw mode in flow director in testpmd

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kirill Rybalchenko > Sent: Thursday, November 23, 2017 4:15 PM > To: dev@dpdk.org > Cc: Rybalchenko, Kirill ; Chilikin, Andrey > ; Xing, Beilei ; Wu, > Jingjing > Subject: [dpdk-dev] [PATCH 2/2] doc: add descript

Re: [dpdk-dev] [PATCH 12/39] examples/ip_fragmentation: convert to new offloads API

2017-12-11 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Thursday, November 23, 2017 12:19 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 12/39] examples/ip_fragmentation: convert to new > offloads API > > Ethdev offloads API has changed sinc

Re: [dpdk-dev] [PATCH 3/3] doc: update documentation for flow classify lib

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Thursday, November 23, 2017 11:32 AM > To: dev@dpdk.org > Cc: Iremonger, Bernard > Subject: [dpdk-dev] [PATCH 3/3] doc: update documentation for flow > classify lib > > Updates the docume

Re: [dpdk-dev] [PATCH 06/39] examples/l3fwd-acl: convert to new ethdev offloads API

2017-12-11 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Thursday, November 23, 2017 12:14 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 06/39] examples/l3fwd-acl: convert to new ethdev > offloads API > > Ethdev offloads API has changed sinc

Re: [dpdk-dev] [PATCH v1 2/8] bus: introduce opaque control framework

2017-12-11 Thread Gaëtan Rivet
On Mon, Dec 11, 2017 at 07:06:55PM +0530, Shreyansh Jain wrote: > On Monday 11 December 2017 06:13 PM, Gaëtan Rivet wrote: > > On Mon, Dec 11, 2017 at 05:30:16PM +0530, Shreyansh Jain wrote: > > > On Thursday 12 October 2017 01:48 PM, Gaetan Rivet wrote: > > [...] > > > > > diff --git a/lib/librt

Re: [dpdk-dev] [PATCH 08/11] crypto/ccp: rename CCP crypto driver id

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar > Sent: Thursday, November 30, 2017 1:13 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 08/11] crypto/ccp: rename CCP crypto driver id > > Signed-off-by: Ravi Kumar Hi Ravi, I think this patch i

Re: [dpdk-dev] [PATCH 10/11] test/test: add test for AMD CCP crypto PMD

2017-12-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar > Sent: Thursday, November 30, 2017 1:13 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 10/11] test/test: add test for AMD CCP crypto > PMD > > Signed-off-by: Ravi Kumar Hi Ravi, There is a comp

Re: [dpdk-dev] [PATCH] doc: update contribution guideline for dependent work

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 21, 2017 7:59 PM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev@dpdk.org; Yigit, Ferruh ; > techbo...@dpdk.org > Subject: [PATCH] doc: update contribution guideline for dependent work > > Changing some part of the

Re: [dpdk-dev] [PATCH 6/6] doc: add mbuf VLAN flag to PMD todo list

2017-12-11 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 21, 2017 1:43 AM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH 6/6] doc: add mbuf VLAN flag to PMD todo list > > To track modification: > 380a7aab1ae2 ("mbuf: rename depr

  1   2   >