Re: [dpdk-dev] [RFC 1/2] net/tap: add eBPF to TAP device

2017-12-04 Thread Pascal Mazon
Hi Ophir, I wrote that doc (rte_flow_tap) a while ago (10 months+), it is no longer accurate and would very much need updating. I might have written some of the code you propose, but I definitely didn't see this patch before you sent it, you shouldn't use my sign-off. That goes for the second patc

[dpdk-dev] [PATCH v3] bnxt: Support time_sync related APIs

2017-12-04 Thread Somnath Kotur
Implemented the 'time_sync' related APIs for supporting the PTP protocol. Signed-off-by: Somnath Kotur --- v3 Changes - Initialize the time counters correctly during timesync_enable - Use correct flag to check for PTP in Rx completion v2 Changes - Updated bnxt.ini to announce 'timesync' feature -

Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting VM2VM scenario

2017-12-04 Thread Yang, Zhiyong
Hi all, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang > Sent: Thursday, November 30, 2017 5:47 PM > To: dev@dpdk.org; y...@fridaylinux.org; maxime.coque...@redhat.com > Cc: Wang, Wei W ; Tan, Jianfeng > > Subject: [dpdk-dev] [PATCH 00/11] net/vho

Re: [dpdk-dev] [PATCH 2/5] app/testpmd: remove txqflags

2017-12-04 Thread Shahaf Shuler
Tuesday, December 5, 2017 12:31 AM, Ferruh Yigit: > On 11/23/2017 4:08 AM, Shahaf Shuler wrote: > > Since testpmd is now using the new Ethdev offloads API there is no > > need for the txqflags configuration. > > txqflag command-line option (--txqflags=0x) and command (port > config all txq

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: convert to new Ethdev offloads API

2017-12-04 Thread Shahaf Shuler
Tuesday, December 5, 2017 12:31 AM, Ferruh Yigit: > On 11/23/2017 4:08 AM, Shahaf Shuler wrote: > > Ethdev Rx/Tx offloads API has changed since: > > > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") commit > > cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > > > Conver

Re: [dpdk-dev] [PATCH] net/i40e: fix VF Tx error issue

2017-12-04 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Tuesday, December 5, 2017 10:41 AM > To: Wu, Jingjing ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix VF Tx error issue > > When using kernel PF + DPDK VF, if setting VLAN strip on or off in VF side >

Re: [dpdk-dev] [RFC v1 00/11] scapy/python extension

2017-12-04 Thread Xueming(Steven) Li
Sorry for spamming, something wrong to post patches. Please refer to https://github.com/steevenlee/dpdk/tree/master_scapy for code detail. > -Original Message- > From: Xueming Li [mailto:xuemi...@mellanox.com] > Sent: Tuesday, December 5, 2017 12:55 PM > To: w...@dev-r630-06.mtbc.labs.mln

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-04 Thread Matan Azrad
Hi Neil > -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Tuesday, December 5, 2017 12:31 AM > To: Matan Azrad > Cc: Ananyev, Konstantin ; Gaëtan Rivet > ; Thomas Monjalon ; > Wu, Jingjing ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev: add port

Re: [dpdk-dev] [PATCH 2/5] examples/kni: add optional parameter to enable LRO

2017-12-04 Thread Shahaf Shuler
Tuesday, December 5, 2017 1:25 AM, Ferruh Yigit: > On 11/24/2017 12:35 PM, Rasesh Mody wrote: > > From: Harish Patil > > > > Add an optional cmdline parameter to enable LRO. This is useful to > > test LRO feature by being able to run linux utils like iperf over KNI > > interface which generates co

[dpdk-dev] [PATCH v2] arch/arm: optimization for memcpy on AArch64

2017-12-04 Thread Herbert Guan
This patch provides an option to do rte_memcpy() using 'restrict' qualifier, which can induce GCC to do optimizations by using more efficient instructions, providing some performance gain over memcpy() on some AArch64 platforms/enviroments. The memory copy performance differs between different AAr

[dpdk-dev] [RFC v1 00/11] scapy/python extension

2017-12-04 Thread Xueming Li
Thiss patch introduces a set of new elements into DPDK: 1. python/scapy as a standard dpdk library, disabled by default. Could be used by any application to integrate powerful python features. 2. tx, rx and expect, blocking mode testpmd CLI command tx command send packets with scapy syntax te

[dpdk-dev] [RFC v1 00/11] scappy/pythoon extension

2017-12-04 Thread Xueming Li
This patch introduced a set of new elements into DPDK: 1. python/scapy as a standard dpdk library, disabled by default. Could be used by any application to integrate powerful python features. 2. tx, rx and expect, blocking mode testpmd CLI command tx command send packets with scapy syntax tem

[dpdk-dev] [RFC v1 00/11] scapy/python extension

2017-12-04 Thread Xueming Li
This patch introduces a set of new elements into DPDK: 1. python/scapy as a standard dpdk library, disabled by default. Could be used by any application to integrate powerful python features. 2. tx, rx and expect, blocking mode testpmd CLI command tx command send packets with scapy syntax tem

[dpdk-dev] [RFC v1 00/11] scapy/python extension

2017-12-04 Thread Xueming Li
Thiss patch introduces a set of new elements into DPDK: 1. python/scapy as a standard dpdk library, disabled by default. Could be used by any application to integrate powerful python features. 2. tx, rx and expect, blocking mode testpmd CLI command tx command send packets with scapy syntax te

[dpdk-dev] [RFC v1 00/11] scapy/python extension

2017-12-04 Thread Xueming Li
This patch introduced a set of new elements into DPDK: 1. python/scapy as a standard dpdk library, disabled by default. Could be used by any application to integrate powerful python features. 2. tx, rx and expect, blocking mode testpmd CLI command tx command send packets with scapy syntax tem

[dpdk-dev] [RFC v1 00/11] scapy/python extension

2017-12-04 Thread Xueming Li
This patch introduced a set of new elements into DPDK: 1. python/scapy as a standard dpdk library, disabled by default. Could be used by any application to integrate powerful python features. 2. tx, rx and expect, blocking mode testpmd CLI command tx command send packets with scapy syntax tem

[dpdk-dev] [RFC v1 00/11] scapy/python extension

2017-12-04 Thread Xueming Li
quick guide document: https://github.com/steevenlee/dpdk/blob/master_scapy/doc/guides/howto/scapy.rst github branch: https://github.com/steevenlee/dpdk/tree/master_scapy Xueming Li (11): lib/cmdline: support backspace key lib/cmdline: init parse result memeory lib/cmdline: add echo support

Re: [dpdk-dev] [PATCH] net/bnxt: Support time_sync related APIs

2017-12-04 Thread Somnath Kotur
Thank you for your comments Ferruh! Hope i got it right this time Thanks Som On Tue, Dec 5, 2017 at 5:35 AM, Ferruh Yigit wrote: > On 12/4/2017 4:03 PM, Ferruh Yigit wrote: >> On 11/30/2017 12:13 AM, Somnath Kotur wrote: >>> Implemented the 'time_sync' related APIs for supporting PTP. >>> Defin

[dpdk-dev] [PATCH v2] bnxt: Support time_sync related APIs

2017-12-04 Thread Somnath Kotur
Implemented the 'time_sync' related APIs for supporting the PTP protocol. Signed-off-by: Somnath Kotur --- v2 Changes - Updated bnxt.ini to announce 'timesync' feature - Added code to correctly detect PTP in the pkt and set corresponding ol_flags for PTP in Rx path doc/guides/nics/features/bn

Re: [dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behavior of device stop/start

2017-12-04 Thread Tiwei Bie
On Mon, Dec 04, 2017 at 07:46:07PM +0800, Fischetti, Antonio wrote: > > -Original Message- > > From: Bie, Tiwei > > Sent: Monday, December 4, 2017 7:20 AM > > To: Fischetti, Antonio > > Cc: dev@dpdk.org; y...@fridaylinux.org; maxime.coque...@redhat.com; > > jfreim...@redhat.com; sta...@dpd

[dpdk-dev] [PATCH] net/i40e: fix VF Tx error issue

2017-12-04 Thread Beilei Xing
When using kernel PF + DPDK VF, if setting VLAN strip on or off in VF side after setting VLAN for VF with ethtool in PF side, it will case VF Tx error. The root case is that setting VLAN for VF in kernel PF side is to set PVID, then Rx VLAN offload is not permitted. This patch fixes the issue by ch

Re: [dpdk-dev] [PATCH] net/fm10k: remove RSS restriction with num of queues

2017-12-04 Thread Zhang, Qi Z
> -Original Message- > From: zhouyangchao [mailto:zhouya...@gmail.com] > Sent: Monday, December 4, 2017 2:38 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhang, Qi Z > Subject: [PATCH] net/fm10k: remove RSS restriction with num of queues > > FM10K HW does not have such restrictions. > > E

Re: [dpdk-dev] [PATCH 6/7] devtools/test-build: add MRVL NET PMD to test-build

2017-12-04 Thread Ferruh Yigit
On 12/1/2017 7:19 AM, Tomasz Duszynski wrote: > Add MRVL NET PMD to test build tool. > > Signed-off-by: Tomasz Duszynski > --- > devtools/test-build.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/devtools/test-build.sh b/devtools/test-build.sh > index 092d3a7..78609c9 100755 > ---

Re: [dpdk-dev] [PATCH 01/16] net/axgbe: add minimal dev init and uninit support

2017-12-04 Thread Ferruh Yigit
On 11/30/2017 5:10 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar Hi Ravi, Did you tested shared library build? I am getting build error but I didn't dig it more... <...> > @@ -0,0 +1,146 @@ > +# > +# Copyright (c) 2017 Advanced Micro Devices, Inc. > +# All rights reserved. > +# > +#

Re: [dpdk-dev] [PATCH] net/bnxt: Support time_sync related APIs

2017-12-04 Thread Ferruh Yigit
On 12/4/2017 4:03 PM, Ferruh Yigit wrote: > On 11/30/2017 12:13 AM, Somnath Kotur wrote: >> Implemented the 'time_sync' related APIs for supporting PTP. >> Defined new FW structs, opcodes and cmds for the same. >> >> Signed-off-by: Somnath Kotur >> --- >> drivers/net/bnxt/bnxt.h|

Re: [dpdk-dev] [PATCH] net/bnxt: Support time_sync related APIs

2017-12-04 Thread Ferruh Yigit
On 11/30/2017 12:13 AM, Somnath Kotur wrote: > Implemented the 'time_sync' related APIs for supporting PTP. > Defined new FW structs, opcodes and cmds for the same. > > Signed-off-by: Somnath Kotur > --- > drivers/net/bnxt/bnxt.h| 49 +++ > drivers/net/bnxt/bnxt_ethdev.c

Re: [dpdk-dev] [PATCH] net/thunderx: fix multi segment xmit function return

2017-12-04 Thread Ferruh Yigit
On 11/28/2017 5:22 AM, Jerin Jacob wrote: > multi segment version of tx burst function was not > returning the actual number of packets sent out > in PMD xmit function. > > Fixes: 1c421f18e0 ("net/thunderx: add single and multi-segment Tx") > Cc: sta...@dpdk.org > > Signed-off-by: Jerin Jacob >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: configure default RSS reta table

2017-12-04 Thread Ferruh Yigit
On 11/24/2017 7:31 AM, Alejandro Lucero wrote: > Some apps can enable RSS but not update the reta table nor the hash. > This patch adds a default reta table setup based on total number of > configured rx queues. The hash key is dependent on how the app > configures the rx_conf struct. > > Signed-o

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix CRC strip check behaviour

2017-12-04 Thread Ferruh Yigit
On 11/24/2017 6:26 AM, Alejandro Lucero wrote: > NFP does CRC strip by default and it is not configurable. But, even > if an app requests not to do it, that should not be a reason for PMD > configuration failure. > > Fixes: defb9a5dd156 ("nfp: introduce driver initialization") > > Signed-off-by:

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix jumbo settings

2017-12-04 Thread Ferruh Yigit
On 11/24/2017 6:24 AM, Alejandro Lucero wrote: > When jumbo frames is configured, the hardware mtu needs to be updated to > the specified max_rx_pkt_len. Also, changing mtu should be avoided once > the PMD port started. > > Fixes: defb9a5dd156 ("nfp: introduce driver initialization") Cc: sta...@dp

Re: [dpdk-dev] [PATCH 2/5] examples/kni: add optional parameter to enable LRO

2017-12-04 Thread Ferruh Yigit
On 11/24/2017 12:35 PM, Rasesh Mody wrote: > From: Harish Patil > > Add an optional cmdline parameter to enable LRO. This is useful to test > LRO feature by being able to run linux utils like iperf over KNI interface > which generates consistent packet aggregations. > > Signed-off-by: Harish Pat

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-04 Thread Neil Horman
On Mon, Dec 04, 2017 at 06:10:56PM +, Matan Azrad wrote: > Hi Neil > > > -Original Message- > > From: Neil Horman [mailto:nhor...@tuxdriver.com] > > Sent: Monday, December 4, 2017 6:01 PM > > To: Matan Azrad > > Cc: Ananyev, Konstantin ; Gaëtan Rivet > > ; Thomas Monjalon ; > > Wu, Ji

Re: [dpdk-dev] [PATCH 1/5] app/testpmd: convert to new Ethdev offloads API

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 4:08 AM, Shahaf Shuler wrote: > Ethdev Rx/Tx offloads API has changed since: > > commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") > > Convert the application to use the new API. Hi Shahaf, As far as I

Re: [dpdk-dev] [PATCH 2/5] app/testpmd: remove txqflags

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 4:08 AM, Shahaf Shuler wrote: > Since testpmd is now using the new Ethdev offloads API there is no > need for the txqflags configuration. txqflag command-line option (--txqflags=0x) and command (port config all txqflags value) are way to dynamically provide Tx offload configu

Re: [dpdk-dev] 17.08.1 patches review and test

2017-12-04 Thread Patil, Harish
-Original Message- From: dev on behalf of Yuanhan Liu Date: Monday, November 27, 2017 at 4:21 AM To: dpdk stable Cc: "dev@dpdk.org" , "Xu, Qian Q" Subject: [dpdk-dev] 17.08.1 patches review and test >Hi all, > >Here is a list of patches targeted for stable release 17.08.1. Please >he

Re: [dpdk-dev] [PATCH v2 11/14] net/i40e: support AVF basic interface

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 10:33 PM, Jingjing Wu wrote: > Enable Virtchnl offload Caps negotiation and RSS_PF offload > to support AVF basic interface. > > Signed-off-by: Jingjing Wu > --- > config/common_base | 2 +- > drivers/net/i40e/i40e_ethdev.c | 64 +++ > drivers/net/i40

Re: [dpdk-dev] [PATCH v2 14/14] net/avf: enable Rx interrupt support

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 10:33 PM, Jingjing Wu wrote: > Signed-off-by: Jingjing Wu > --- > MAINTAINERS | 6 ++ Maintainers file update can be part of first patch. > doc/guides/nics/features/avf.ini | 38 +++ > doc/guides/nics/features/avf_vec.ini | 38 +++ > doc/gu

Re: [dpdk-dev] [PATCH v2 12/14] net/avf: enable sse vector Rx Tx func

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 10:33 PM, Jingjing Wu wrote: > Signed-off-by: Jingjing Wu <...> > @@ -233,6 +233,7 @@ CONFIG_RTE_LIBRTE_AVF_DEBUG_TX=n > CONFIG_RTE_LIBRTE_AVF_DEBUG_TX_FREE=n > CONFIG_RTE_LIBRTE_AVF_DEBUG_RX=n > CONFIG_RTE_LIBRTE_AVF_16BYTE_RX_DESC=n > +CONFIG_RTE_LIBRTE_AVF_INC_VECTOR=y Can y

Re: [dpdk-dev] [PATCH v2 07/14] net/avf: enable ops for MAC VLAN offload

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 10:33 PM, Jingjing Wu wrote: > - promiscuous_enable > - promiscuous_disable > - allmulticast_enable > - allmulticast_disable > - mac_addr_add > - mac_addr_remove > - mac_addr_set > - vlan_filter_set > - vlan_offload_set Patch title is misleading. > > Signed-off-by: Jingjin

Re: [dpdk-dev] [PATCH v2 06/14] net/avf: enable ops to get stats

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 10:33 PM, Jingjing Wu wrote: Title can be "net/avf: support stats"? > Signed-off-by: Jingjing Wu <...>

Re: [dpdk-dev] [PATCH v2 05/14] net/avf: enable link status update

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 10:33 PM, Jingjing Wu wrote: > Signed-off-by: Jingjing Wu > --- > drivers/net/avf/avf.h| 2 ++ > drivers/net/avf/avf_ethdev.c | 48 > > drivers/net/avf/avf_vchnl.c | 38 ++- Can you please update

Re: [dpdk-dev] [PATCH v2 04/14] net/avf: enable basic Rx Tx func

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 10:33 PM, Jingjing Wu wrote: > Signed-off-by: Wenzhuo Lu <...> > @@ -31,8 +31,8 @@ > * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > */ > > -#ifndef _AVF_LOGS_H_ > -#define _AVF_LOGS_H_ > +#ifndef _AVF_LOG_H_ > +#define _AVF_LOG_H_ Can you please s

Re: [dpdk-dev] [PATCH v2 03/14] net/avf: enable queue and device

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 10:33 PM, Jingjing Wu wrote: > enable device and queue setup ops like: > > - dev_configure > - dev_start > - dev_stop > - dev_close > - dev_infos_get > - rx_queue_start > - rx_queue_stop > - tx_queue_start > - tx_queue_stop > - rx_queue_setup > - rx_queue_release > - tx_q

Re: [dpdk-dev] [PATCH v2 02/14] net/avf: initilization of avf PMD

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 10:33 PM, Jingjing Wu wrote: > Signed-off-by: Jingjing Wu <...> > @@ -37,6 +37,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD),d) > endif > > DIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += af_packet > +DIRS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf Can you please add this alphabetica

Re: [dpdk-dev] [PATCH v2 01/14] net/avf/base: add base code for avf PMD

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 10:33 PM, Jingjing Wu wrote: > Signed-off-by: Jingjing Wu <...> > --- /dev/null > +++ b/drivers/net/avf/avf_log.h > @@ -0,0 +1,52 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright(c) 2017 Intel Corporation. All rights reserved. > + * All rights reserved. > + * > + * Redistr

Re: [dpdk-dev] [PATCH v2 00/14] add new avf PMD

2017-12-04 Thread Ferruh Yigit
On 11/23/2017 10:33 PM, Jingjing Wu wrote: > Adaptive Virtual Function (AVF) Driver is VF driver which supports > for all future Intel devices without requiring a VM update. > It promises the basic high speed connectivity. And since this happens > to be an adaptive VF driver, every new drop of the

Re: [dpdk-dev] [PATCH 1/7] ethdev: remove unused flag from header

2017-12-04 Thread Vlad Zolotarov
On 12/04/2017 12:54 PM, Ferruh Yigit wrote: On 12/1/2017 6:22 PM, Vlad Zolotarov wrote: On 12/01/2017 06:51 PM, Ferruh Yigit wrote: On 12/1/2017 2:17 PM, Vlad Zolotarov wrote: On 11/30/2017 09:29 PM, Ferruh Yigit wrote: remove RTE_ETHDEV_HAS_LRO_SUPPORT flag from header. Flag seems added

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-04 Thread Matan Azrad
Hi Neil > -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Monday, December 4, 2017 6:01 PM > To: Matan Azrad > Cc: Ananyev, Konstantin ; Gaëtan Rivet > ; Thomas Monjalon ; > Wu, Jingjing ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ow

Re: [dpdk-dev] [PATCH 1/7] ethdev: remove unused flag from header

2017-12-04 Thread Ferruh Yigit
On 12/1/2017 6:22 PM, Vlad Zolotarov wrote: > > > On 12/01/2017 06:51 PM, Ferruh Yigit wrote: >> On 12/1/2017 2:17 PM, Vlad Zolotarov wrote: >>> >>> On 11/30/2017 09:29 PM, Ferruh Yigit wrote: remove RTE_ETHDEV_HAS_LRO_SUPPORT flag from header. Flag seems added with the patch that

Re: [dpdk-dev] [PATCH 7/7] ethdev: use opaque user callback object

2017-12-04 Thread Ferruh Yigit
On 12/4/2017 2:31 AM, Bruce Richardson wrote: > On Fri, Dec 01, 2017 at 03:51:52PM -0800, Ferruh Yigit wrote: >> On 12/1/2017 5:17 AM, Bruce Richardson wrote: >>> On Fri, Dec 01, 2017 at 11:22:12AM +, Ananyev, Konstantin wrote: > -Original Message- > From: dev [mailto:

Re: [dpdk-dev] [PATCH] ethdev: increase flow type limit from 32 to 64

2017-12-04 Thread Adrien Mazarguil
Hi Kirill, On Mon, Nov 27, 2017 at 12:29:47PM +, Kirill Rybalchenko wrote: > Increase the internal limit for flow types from 32 to 64 > to support future flow type extensions. > Change type of variables from uint32_t[] to uint64_t[]: > rte_eth_fdir_info.flow_types_mask > rte_eth_hash_globa

Re: [dpdk-dev] [PATCH] net/mlx4: revert workaround for broken Verbs

2017-12-04 Thread Adrien Mazarguil
On Wed, Nov 29, 2017 at 09:21:26AM +, Matan Azrad wrote: > This workaround was needed to properly handle device removal with old > Mellanox OFED releases that are not supported by this PMD anymore. > > Starting from rdma-core v16 this removal issue shouldn't happen when > setting MLX4_DEVICE_F

Re: [dpdk-dev] [PATCH 2/3] lib/librte_flow_classy: add run api for flow classification

2017-12-04 Thread Iremonger, Bernard
Hi Jasvinder, > -Original Message- > From: Singh, Jasvinder > Sent: Thursday, November 23, 2017 11:32 AM > To: dev@dpdk.org > Cc: Iremonger, Bernard > Subject: [PATCH 2/3] lib/librte_flow_classy: add run api for flow > classification > > This patch extends the flow classification librar

Re: [dpdk-dev] [PATCH 1/3] lib/librte_flow_classify: remove table id parameter from apis

2017-12-04 Thread Iremonger, Bernard
Hi Jasvinder, > -Original Message- > From: Singh, Jasvinder > Sent: Thursday, November 23, 2017 11:32 AM > To: dev@dpdk.org > Cc: Iremonger, Bernard > Subject: [PATCH 1/3] lib/librte_flow_classify: remove table id parameter > from apis > > This patch removes table id parameter from all t

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-12-04 Thread Neil Horman
On Sun, Dec 03, 2017 at 01:46:49PM +, Matan Azrad wrote: > Hi Konstantine > > > -Original Message- > > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > > Sent: Sunday, December 3, 2017 1:10 PM > > To: Matan Azrad ; Neil Horman > > ; Gaëtan Rivet > > Cc: Thomas Monjalo

[dpdk-dev] [PATCH] relicense various bits of the dpdk

2017-12-04 Thread Neil Horman
Received a note the other day from the Linux Foundation governance board for DPDK indicating that several files I have copyright on need to be relicensed to be compliant with the DPDK licensing guidelines. I have some concerns with some parts of the request, but am not opposed to other parts. So,

[dpdk-dev] [PATCH v2] ethdev: allow all ports event registration

2017-12-04 Thread Matan Azrad
Add option to register event callback for all ports by one call to rte_eth_dev_callback_register using port_id=RTE_ETH_ALL. In this case the callback is also registered to invalid ports. Signed-off-by: Matan Azrad --- lib/librte_ether/rte_ethdev.c | 124 +

Re: [dpdk-dev] [RFC v1 1/5] ethdev: support rss level on tunnel

2017-12-04 Thread Nelio Laranjeiro
On Mon, Dec 04, 2017 at 02:24:53PM +, Xueming(Steven) Li wrote: > > > > > > const struct rte_eth_rss_conf *rss_conf; /**< RSS parameters. > > */ > > > > > + /** > > > > > + * RSS on tunnel level: > > > > > + * 0: outer RSS > > > > > + * 1: inner RSS > > > > > +

Re: [dpdk-dev] [PATCH 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-04 Thread Maxime Coquelin
On 12/04/2017 03:27 PM, Ladi Prosek wrote: On Mon, Dec 4, 2017 at 3:08 PM, Maxime Coquelin wrote: Having QEMU started with mq=on but guest driver not negotiating VIRTIO_NET_F_MQ feature ends up in the vhost device to never start. Indeed, more queues are created in the vhost backend than conf

Re: [dpdk-dev] [PATCH 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-04 Thread Ladi Prosek
On Mon, Dec 4, 2017 at 3:08 PM, Maxime Coquelin wrote: > Having QEMU started with mq=on but guest driver not negotiating > VIRTIO_NET_F_MQ feature ends up in the vhost device to never > start. Indeed, more queues are created in the vhost backend than > configured. > > Guest drivers known to not ad

Re: [dpdk-dev] [RFC v1 1/5] ethdev: support rss level on tunnel

2017-12-04 Thread Xueming(Steven) Li
> -Original Message- > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Monday, December 4, 2017 6:33 PM > To: Xueming(Steven) Li > Cc: Adrien Mazarguil ; Thomas Monjalon > ; dev@dpdk.org > Subject: Re: [RFC v1 1/5] ethdev: support rss level on tunnel > > Xueming, > >

Re: [dpdk-dev] [PATCH 1/4] vhost: prevent features to be changed while device is running

2017-12-04 Thread Maxime Coquelin
On 12/04/2017 03:17 PM, Ladi Prosek wrote: On Mon, Dec 4, 2017 at 3:08 PM, Maxime Coquelin wrote: As section 2.2 of the Virtio spec states about features negotiation: "During device initialization, the driver reads this and tells the device the subset that it accepts. The only way to renegot

Re: [dpdk-dev] [PATCH 1/4] vhost: prevent features to be changed while device is running

2017-12-04 Thread Ladi Prosek
On Mon, Dec 4, 2017 at 3:08 PM, Maxime Coquelin wrote: > As section 2.2 of the Virtio spec states about features > negotiation: > "During device initialization, the driver reads this and tells > the device the subset that it accepts. The only way to > renegotiate is to reset the device." > > This

[dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add target queues in flow actions

2017-12-04 Thread Nelio Laranjeiro
Mellanox INNOVA NIC needs to have final target queue actions to perform inline crypto. Signed-off-by: Nelio Laranjeiro --- Changes in v2: * Test the rule by PASSTHRU/RSS/QUEUE and apply the first one validated. --- examples/ipsec-secgw/ipsec.c | 81 ---

[dpdk-dev] [PATCH v2 1/2] examples/ipsec-secgw: fix missing ingress flow attribute

2017-12-04 Thread Nelio Laranjeiro
Generic flow API have both direction bits, ingress and egress for rules which may work on both sides. Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") Cc: akhil.go...@nxp.com Signed-off-by: Nelio Laranjeiro --- examples/ipsec-secgw/ipsec.c | 2 ++ 1 file changed, 2 inserti

[dpdk-dev] [PATCH 4/4] vhost: destroy unused virtqueues when multiqueue not negotiated

2017-12-04 Thread Maxime Coquelin
QEMU sends VHOST_USER_SET_VRING_CALL requests for all queues declared in QEMU command line before the guest is started. It has the effect in DPDK vhost-user backend to allocate vrings for all queues declared by QEMU. If the first driver being used does not support multiqueue, the device never chan

[dpdk-dev] [PATCH 2/4] vhost: propagate VHOST_USER_SET_FEATURES handling error

2017-12-04 Thread Maxime Coquelin
Not propagating VHOST_USER_SET_FEATURES request handling error may result in unpredictable behavior, as host and guests features may no more be synchronized. This patch fixes this by reporting the error to the upper layer, which would result in the device being destroyed and the connection with th

[dpdk-dev] [PATCH 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated

2017-12-04 Thread Maxime Coquelin
Having QEMU started with mq=on but guest driver not negotiating VIRTIO_NET_F_MQ feature ends up in the vhost device to never start. Indeed, more queues are created in the vhost backend than configured. Guest drivers known to not advertise the VIRTIO_NET_F_MQ feature are iPXE and OVMF Virtio-net dr

[dpdk-dev] [PATCH 3/4] vhost: extract virtqueue cleaning and freeing functions

2017-12-04 Thread Maxime Coquelin
This patch extracts needed code for vhost_user.c to be able to clean and free virtqueues unitary. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.c | 22 -- lib/librte_vhost/vhost.h | 3 +++ 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/lib/librt

[dpdk-dev] [PATCH 1/4] vhost: prevent features to be changed while device is running

2017-12-04 Thread Maxime Coquelin
As section 2.2 of the Virtio spec states about features negotiation: "During device initialization, the driver reads this and tells the device the subset that it accepts. The only way to renegotiate is to reset the device." This patch implements a check to prevent illegal features change while the

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: add GENEVE flow pattern item

2017-12-04 Thread Adrien Mazarguil
On Fri, Dec 01, 2017 at 10:43:15AM +, Andrew Rybchenko wrote: > From: Roman Zhukov > > Add new pattern item RTE_FLOW_ITEM_TYPE_GENEVE in flow API. > Add default mask for the item. > > Signed-off-by: Roman Zhukov > Signed-off-by: Andrew Rybchenko Just one remaining nit, please see below. W

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-12-04 Thread Yuanhan Liu
On Fri, Dec 01, 2017 at 10:47:50AM +0100, Gaëtan Rivet wrote: > On Thu, Nov 30, 2017 at 10:44:58PM +0100, Thomas Monjalon wrote: > > 30/11/2017 22:21, Stephen Hemminger: > > > On Thu, 30 Nov 2017 18:35:11 +0100 > > > Thomas Monjalon wrote: > > > > > > > 30/11/2017 18:15, Stephen Hemminger: > > >

Re: [dpdk-dev] [PATCH 1/2] doc: Clarify wording regarding actions and flow rules.

2017-12-04 Thread Adrien Mazarguil
On Fri, Dec 01, 2017 at 10:26:39AM -0800, Roy Franz wrote: > Current wording regarding actions and flow rules doesn't make sense. > > Signed-off-by: Roy Franz > --- > Maybe a better word than 'assigned' could be chosen? (attached, > associated with, etc) I'm happy to spin this if needed. Agre

[dpdk-dev] [PATCH v7 2/3] eal: add u64 bit variant for reciprocal

2017-12-04 Thread Pavan Nikhilesh
Currently, rte_reciprocal only supports unsigned 32bit divisors. This commit adds support for unsigned 64bit divisors. Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/common/include/rte_reciprocal.h | 46 + lib/librte_eal/common/rte_reciprocal.c | 89 +++

[dpdk-dev] [PATCH v7 1/3] eal: introduce integer divide through reciprocal

2017-12-04 Thread Pavan Nikhilesh
In some use cases of integer division, denominator remains constant and numerator varies. It is possible to optimize division for such specific scenarios. The librte_sched uses rte_reciprocal to optimize division so, moving it to eal/common would allow other libraries and applications to use it.

[dpdk-dev] [PATCH v7 3/3] test: add tests for reciprocal based division

2017-12-04 Thread Pavan Nikhilesh
This commit provides a set of tests for verifying the correctness and performance of both unsigned 32 and 64bit reciprocal based division. Signed-off-by: Pavan Nikhilesh --- test/test/Makefile| 2 + test/test/test_reciprocal_division.c | 190 +++

[dpdk-dev] Question/bug net/i40e i40e_pf_config_rss/reta API DPDK 17.11

2017-12-04 Thread Hanoch Haim (hhaim)
Hi All, I want to configure 4 RX queues when rx-queue=1 is masked by RSS So in case I have 4 rx-queues 0,1,2,3 I want to get packets only from 0,2,3 by RSS. Not so complex. 1) Enable RSS port_conf.rxmode.mq_mode = ETH_MQ_RX_RSS; port_conf.rx_adv_conf.rss_conf.rss_hf = E

Re: [dpdk-dev] [PATCH 00/39] convert examples to new ethdev offloads API

2017-12-04 Thread Shahaf Shuler
Thursday, November 23, 2017 2:14 PM, Shahaf Shuler: > This series is to convert DPDK examples to the new offloads API [1]. > > [1] > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpd > k.org%2Fml%2Farchives%2Fdev%2F2017- > October%2F077329.html&data=02%7C01%7Cshahafs%40mellanox

Re: [dpdk-dev] [PATCH v2 0/5] net/mlx4: restore inner VXLAN & UDP RSS support

2017-12-04 Thread Shahaf Shuler
Thursday, November 23, 2017 7:38 PM, Adrien Mazarguil: > Following the refactoring of the entire mlx4 PMD for DPDK 17.11, UDP RSS > support was left in a disabled state. Likewise, inner VXLAN RSS used to be > performed automatically by default but it's not the case anymore. > > This series brings

Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx checksum offloads

2017-12-04 Thread Shahaf Shuler
Wednesday, November 22, 2017 12:54 AM, Yongseok Koh: > > On Nov 20, 2017, at 7:35 AM, Nelio Laranjeiro > wrote: > > > > Tx checksum offloads are correctly handled in a single Tx burst > > function whereas the capability is always set. > > This causes VXLAN packet with checksum offloads request to

Re: [dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behavior of device stop/start

2017-12-04 Thread Fischetti, Antonio
> -Original Message- > From: Bie, Tiwei > Sent: Monday, December 4, 2017 7:20 AM > To: Fischetti, Antonio > Cc: dev@dpdk.org; y...@fridaylinux.org; maxime.coque...@redhat.com; > jfreim...@redhat.com; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behavi

Re: [dpdk-dev] [RFC v1 1/5] ethdev: support rss level on tunnel

2017-12-04 Thread Nelio Laranjeiro
Xueming, On Mon, Dec 04, 2017 at 09:05:22AM +, Xueming(Steven) Li wrote: > > > -Original Message- > > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > > Sent: Monday, December 4, 2017 4:11 PM > > To: Xueming(Steven) Li > > Cc: Adrien Mazarguil ; Thomas Monjalon > > ; dev@

Re: [dpdk-dev] [PATCH 7/7] ethdev: use opaque user callback object

2017-12-04 Thread Bruce Richardson
On Fri, Dec 01, 2017 at 03:51:52PM -0800, Ferruh Yigit wrote: > On 12/1/2017 5:17 AM, Bruce Richardson wrote: > > On Fri, Dec 01, 2017 at 11:22:12AM +, Ananyev, Konstantin wrote: > >> > >> > >>> -Original Message- > >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richards

Re: [dpdk-dev] [PATCH v3 1/2] lib/security: add support for get metadata

2017-12-04 Thread Anoob
Hi Akhil, See inline. Thanks, Anoob On 12/04/2017 02:58 PM, Akhil Goyal wrote: Hi Anoob, On 11/24/2017 5:52 PM, Anoob wrote: Hi Akhil, Radu PLease see inline. Thanks, Anoob On 11/24/2017 05:04 PM, Akhil Goyal wrote: Hi Radu, On 11/24/2017 4:47 PM, Radu Nicolau wrote: On 11/24/2017 1

Re: [dpdk-dev] [PATCH] bus/vdev: add custom scan hook

2017-12-04 Thread Thomas Monjalon
04/12/2017 09:08, Tan, Jianfeng: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Hi, > > > > 01/12/2017 06:48, Tan, Jianfeng: > > > Hi Thomas, > > > > > > Please help us to understand why we need this. > > > > > > > > > On 12/1/2017 8:36 AM, Thomas Monjalon wrote: > > > > The scan ca

Re: [dpdk-dev] [PATCH v3 1/2] lib/security: add support for get metadata

2017-12-04 Thread Akhil Goyal
Hi Anoob, On 11/24/2017 5:52 PM, Anoob wrote: Hi Akhil, Radu PLease see inline. Thanks, Anoob On 11/24/2017 05:04 PM, Akhil Goyal wrote: Hi Radu, On 11/24/2017 4:47 PM, Radu Nicolau wrote: On 11/24/2017 10:55 AM, Akhil Goyal wrote: On 11/24/2017 3:09 PM, Radu Nicolau wrote: Hi, Comme

Re: [dpdk-dev] [RFC v1 1/5] ethdev: support rss level on tunnel

2017-12-04 Thread Xueming(Steven) Li
> -Original Message- > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Monday, December 4, 2017 4:11 PM > To: Xueming(Steven) Li > Cc: Adrien Mazarguil ; Thomas Monjalon > ; dev@dpdk.org > Subject: Re: [RFC v1 1/5] ethdev: support rss level on tunnel > > Hi Xueming, >

Re: [dpdk-dev] [PATCH v2 2/2] net/virtio: support GUEST ANNOUNCE

2017-12-04 Thread Tiwei Bie
On Mon, Dec 04, 2017 at 06:02:08AM -0800, Xiao Wang wrote: > When live migration is done, for the backup VM, either the virtio > frontend or the vhost backend needs to send out gratuitous RARP packet > to announce its new network location. > To support GUEST ANNOUNCE, do we just need to send a RA

Re: [dpdk-dev] [PATCH v2 03/14] net/avf: enable queue and device

2017-12-04 Thread Xing, Beilei
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jingjing Wu > Sent: Friday, November 24, 2017 2:33 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Lu, Wenzhuo > > Subject: [dpdk-dev] [PATCH v2 03/14] net/avf: enable queue and device > > enable device and queue set

Re: [dpdk-dev] [PATCH] test/eventdev: use CPU event type

2017-12-04 Thread Pavan Nikhilesh Bhagavatula
On Mon, Dec 04, 2017 at 01:41:18PM +0530, Jerin Jacob wrote: > octeontx test application was using non RTE_EVENT_TYPE_CPU > event type to generate the event from CPU. Upon the introduction > of ethdev Rx adapter, RTE_EVENT_TYPE_ETHDEV has special > meaning. So avoid using non RTE_EVENT_TYPE_CPU ev

[dpdk-dev] [PATCH] test/eventdev: use CPU event type

2017-12-04 Thread Jerin Jacob
octeontx test application was using non RTE_EVENT_TYPE_CPU event type to generate the event from CPU. Upon the introduction of ethdev Rx adapter, RTE_EVENT_TYPE_ETHDEV has special meaning. So avoid using non RTE_EVENT_TYPE_CPU event types to inject events from CPU. Fixes: d0d654986018 ("net/octeo

Re: [dpdk-dev] [RFC v1 1/5] ethdev: support rss level on tunnel

2017-12-04 Thread Nelio Laranjeiro
Hi Xueming, On Sun, Dec 03, 2017 at 02:08:08PM +0800, Xueming Li wrote: > There was no RSS hash fields level definition on tunnel, implementations > default RSS on tunnel to outer or inner. Adding rss level enable users > to specifiy the tunnel level of RSS hash fields. > > 0: outer most, > 1:

Re: [dpdk-dev] [PATCH] bus/vdev: add custom scan hook

2017-12-04 Thread Tan, Jianfeng
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, December 1, 2017 4:42 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org > Subject: Re: [PATCH] bus/vdev: add custom scan hook > > Hi, > > 01/12/2017 06:48, Tan, Jianfeng: > > Hi Thomas, > > > > Please help

Re: [dpdk-dev] [PATCH V7 3/3] ring: introduce new header file to support C11 memory model

2017-12-04 Thread Jianbo Liu
The 12/03/2017 17:50, Jia He wrote: > To support C11 memory model barrier, 2 options are suggested by Jerin: > 1. use rte_smp_rmb > 2. use load_acquire/store_release(refer to [1]). > CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "y" > only on arm64 so far. > > The reason why p