[dpdk-dev] [PATCH] mmap(2) returns MAP_FAILED, not NULL, on failure

2017-11-30 Thread Michael McConville
Signed-off-by: Michael McConville --- lib/librte_eal/bsdapp/eal/eal_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_memory.c b/lib/librte_eal/bsdapp/eal/eal_memory.c index 6ba058578..2c8a4b592 100644 --- a/lib/librte_eal/bsdapp/eal/eal_mem

Re: [dpdk-dev] 17.08.1 patches review and test

2017-11-30 Thread Yuanhan Liu
On Thu, Nov 30, 2017 at 07:09:28PM +, Patil, Harish wrote: > Hi Yuanhan, > Thanks for the queuing the patches for stable release. > Could you please provide ETA? Is below what you are looking for? --yliu --- Hi all, Here is a list of patches targeted for stable release 1

Re: [dpdk-dev] [PATCH 3/7] ethdev: separate driver APIs

2017-11-30 Thread Shreyansh Jain
Hello Ferruh, (Somehow it seems that patch was not delivered to dev@dpdk ML). One comment below: [] > > There is no update in header content and since ethdev.h included by > ethdev_driver.h, nothing changed from driver point of view, only > logically grouping of APIs. From applications point o

[dpdk-dev] [PATCH] net/ixgbe: fix parsing fdir nvgre issue

2017-11-30 Thread Wei Zhao
There is some wrong of mask check in nvgre parser for flow API. Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") Signed-off-by: Wei Zhao --- drivers/net/ixgbe/ixgbe_flow.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/net/ixgbe/

Re: [dpdk-dev] [PATCH] bus/vdev: scan and probe vdev in secondary processes

2017-11-30 Thread Tan, Jianfeng
Hi Kyle, On 12/1/2017 6:27 AM, Kyle Larose wrote: Hey Jianfeng, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jianfeng Tan Sent: Thursday, November 30, 2017 1:59 PM To: dev@dpdk.org Cc: Jianfeng Tan Subject: [dpdk-dev] [PATCH] bus/vdev: scan and probe vdev in

Re: [dpdk-dev] [PATCH] eal: add option to force IOVA as PA mode

2017-11-30 Thread Hemant Agrawal
On 11/30/2017 8:27 AM, Chas Williams wrote: From: Chas Williams The IOMMU in some machines report that they can only support limited widths. IOVA virtual addresses may exceed this width making the use of IOVA virtual addresses difficult. The option CONFIG_RTE_LIBRTE_USE_PHYS_IOVA can used to

Re: [dpdk-dev] [PATCH] bus/vdev: add custom scan hook

2017-11-30 Thread Tan, Jianfeng
Hi Thomas, Please help us to understand why we need this. On 12/1/2017 8:36 AM, Thomas Monjalon wrote: The scan callback allows to spawn a vdev automatically given some custom scan rules. These two new APIs (rte_vdev_add_custom_scan and rte_vdev_remove_custom_scan) are called by application

Re: [dpdk-dev] [PATCH 4/7] ethdev: separate internal structures into own header

2017-11-30 Thread Hemant Agrawal
Hi Ferruh, This patch is not getting applied without PATCH 3/7, which is missing. I could not locate that in Patchwork also. Regards, Hemant

Re: [dpdk-dev] [PATCH 3/4] app/eventdev: add perf pipeline test

2017-11-30 Thread Pavan Nikhilesh Bhagavatula
Hi Gage, Thanks for the review, will clean it up in v2. On Thu, Nov 30, 2017 at 05:15:14PM +, Eads, Gage wrote: > Hi Pavan, > > > -Original Message- > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Thursday, November 30, 2017 1:24 AM > > To: jerin.jacobkoll

Re: [dpdk-dev] [RFC PATCH v4 3/4] eventtimer: add default software implementation stub

2017-11-30 Thread Pavan Nikhilesh Bhagavatula
On Thu, Nov 30, 2017 at 11:56:20PM +, Carrillo, Erik G wrote: > Hi Pavan, > > Response in-line: > > > -Original Message- > > From: Pavan Nikhilesh Bhagavatula > > [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Wednesday, November 29, 2017 4:35 AM > > To: Carrillo, Erik G > > Cc: de

Re: [dpdk-dev] [RFC PATCH v4 2/4] eventtimer: add common code

2017-11-30 Thread Pavan Nikhilesh Bhagavatula
On Thu, Nov 30, 2017 at 08:59:19PM +, Carrillo, Erik G wrote: > Hi Pavan, > > Thanks for the review; I'm working on addressing the comments and have the > following question (inline): > > <... snipped ...> > > > > + adapter->data->mz = mz; > > > + adapter->data->event_dev_id = conf->event_dev

Re: [dpdk-dev] [PATCH 5/7] net/mrvl: add extra error logs

2017-11-30 Thread Jianbo Liu
The 11/30/2017 14:32, Tomasz Duszynski wrote: > Add extra error logs in a few places. > > Signed-off-by: Tomasz Duszynski > --- > drivers/net/mrvl/mrvl_ethdev.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl

Re: [dpdk-dev] [PATCH 1/7] net/mrvl: sync compilation with musdk-17.10

2017-11-30 Thread Jianbo Liu
The 11/30/2017 14:32, Tomasz Duszynski wrote: > Followig changes are needed to switch to musdk-17.10: > > - With a new version of the musdk library it's no longer necessary to > explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT and > CONF_PP2_BPOOL_COOKIE_SIZE. > > Proper defines are autogenerat

[dpdk-dev] [PATCH 5/7] ethdev: reorder inline functions

2017-11-30 Thread Ferruh Yigit
Move all inline function to the end of the ethdev.h header file and move the ethdev_core.h just before inline functions. Since inline functions need data structures in ethdev_core.h, this reorder is to group them and make it clear where put further inline functions. Signed-off-by: Ferruh Yigit -

[dpdk-dev] [PATCH 6/7] ethdev: rename function parameter for consistency

2017-11-30 Thread Ferruh Yigit
Update "port" function argument variable to "port_id" in public header to be consistent in all APIs. No functional change. Signed-off-by: Ferruh Yigit --- lib/librte_ether/rte_ethdev.h | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/l

[dpdk-dev] [PATCH 7/7] ethdev: use opaque user callback object

2017-11-30 Thread Ferruh Yigit
"struct rte_eth_rxtx_callback" is defined as internal data structure but used in public APIs. Checking the API documentation shows that intention was using this object as opaque object. Data structure only used in delete APIs which doesn't require to know the internals of the data structure. Conv

[dpdk-dev] [PATCH 4/7] ethdev: separate internal structures into own header

2017-11-30 Thread Ferruh Yigit
rte_ethdev_core.h created. Internal data structures are moved here. These structures are mostly intended to be used by drivers, but they need to be in the public header file because of the inline functions in the ethdev.h header, and those inline functions are preferred to kept because of the perf

[dpdk-dev] [PATCH 1/7] ethdev: remove unused flag from header

2017-11-30 Thread Ferruh Yigit
remove RTE_ETHDEV_HAS_LRO_SUPPORT flag from header. Flag seems added with the patch that adds LRO support, and intention looks like giving a pointer to application that library supports LRO. Fixes: 8eecb3295aed ("ixgbe: add LRO support") Cc: vl...@cloudius-systems.com Signed-off-by: Ferruh Yigit

[dpdk-dev] [PATCH 2/7] ethdev: fix port id storage

2017-11-30 Thread Ferruh Yigit
port_id is now 16bits, update function parameter according. Fixes: 4c270218aa26 ("ethdev: support security APIs") Cc: sta...@dpdk.org Cc: declan.dohe...@intel.com Signed-off-by: Ferruh Yigit --- Cc: Boris Pismenny Cc: Aviad Yehezkel Cc: Radu Nicolau Cc: Declan Doherty --- lib/librte_ether/r

Re: [dpdk-dev] [PATCH] contigmem: include to fix FreeBSD build

2017-11-30 Thread kefu chai
+ Willem, he reported this issue On Thu, Nov 30, 2017 at 5:56 PM, Bruce Richardson wrote: > On Thu, Nov 30, 2017 at 02:00:38PM +0800, kefu chai wrote: >> otherwise the build fails with >> >> In file included from contigmem.c:57: >> /usr/srcs/head/src/sys/vm/vm_phys.h:122:10: error: use of undecla

Re: [dpdk-dev] [PATCH 1/2] net/virtio: make control queue thread-safe

2017-11-30 Thread Wang, Xiao W
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, November 30, 2017 10:59 AM > To: Wang, Xiao W > Cc: dev@dpdk.org; y...@fridaylinux.org > Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: make control queue thread- > safe > > On Fri, 24

Re: [dpdk-dev] [PATCH] bus/vdev: add custom scan hook

2017-11-30 Thread Thomas Monjalon
01/12/2017 01:36, Thomas Monjalon: > The scan callback allows to spawn a vdev automatically > given some custom scan rules. > It is especially useful to create a TAP device automatically > connected to a netdevice as remote. > > Signed-off-by: Thomas Monjalon > --- > warning: to be tested > --- >

[dpdk-dev] [PATCH] bus/vdev: add custom scan hook

2017-11-30 Thread Thomas Monjalon
The scan callback allows to spawn a vdev automatically given some custom scan rules. It is especially useful to create a TAP device automatically connected to a netdevice as remote. Signed-off-by: Thomas Monjalon --- warning: to be tested --- drivers/bus/vdev/rte_bus_vdev.h | 29

[dpdk-dev] [PATCH] net/bond: burst mode hash calculation

2017-11-30 Thread Declan Doherty
change the xmit_hash functions to handle bursts of packet instead of packet at a time. Updating effect tx_burst functions. Signed-off-by: Declan Doherty Signed-off-by: Keith Wiles --- drivers/net/bonding/rte_eth_bond_api.c | 3 - drivers/net/bonding/rte_eth_bond_pmd.c | 582 ++

Re: [dpdk-dev] [RFC PATCH v4 3/4] eventtimer: add default software implementation stub

2017-11-30 Thread Carrillo, Erik G
Hi Pavan, Response in-line: > -Original Message- > From: Pavan Nikhilesh Bhagavatula > [mailto:pbhagavat...@caviumnetworks.com] > Sent: Wednesday, November 29, 2017 4:35 AM > To: Carrillo, Erik G > Cc: dev@dpdk.org; nipun.gu...@nxp.com; hemant.agra...@nxp.com; Rao, > Nikhil ; jerin.jacob

[dpdk-dev] [PATCH] net/bond: don't drop lacpdu's on slaves tx failure

2017-11-30 Thread Declan Doherty
In message (http://dpdk.org/ml/archives/dev/2017-November/081557.html) it was noted that under congestion that the LACPDU's are dropped under load. This patch changes the drop logic to re-enqueue the LACPDU to the slaves control message queue. This will allow resend attempt's to be made in subsequ

Re: [dpdk-dev] [PATCH] bus/vdev: scan and probe vdev in secondary processes

2017-11-30 Thread Kyle Larose
Hey Jianfeng, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jianfeng Tan > Sent: Thursday, November 30, 2017 1:59 PM > To: dev@dpdk.org > Cc: Jianfeng Tan > Subject: [dpdk-dev] [PATCH] bus/vdev: scan and probe vdev in > secondary processes > > Base on primary

Re: [dpdk-dev] [PATCH] eal/x86: get hypervisor name

2017-11-30 Thread Stephen Hemminger
On Thu, 30 Nov 2017 23:03:57 +0100 Thomas Monjalon wrote: > 30/11/2017 22:55, Stephen Hemminger: > > On Thu, 30 Nov 2017 22:47:20 +0100 > > Thomas Monjalon wrote: > > > > > + for (int reg = 1; reg < 4; reg++) > > > + memcpy(name + (reg - 1) * 4, ®s[reg], 4); > > > + name[12] = '\0';

Re: [dpdk-dev] [PATCH] eal/x86: get hypervisor name

2017-11-30 Thread Thomas Monjalon
30/11/2017 22:55, Stephen Hemminger: > On Thu, 30 Nov 2017 22:47:20 +0100 > Thomas Monjalon wrote: > > > + for (int reg = 1; reg < 4; reg++) > > + memcpy(name + (reg - 1) * 4, ®s[reg], 4); > > + name[12] = '\0'; > > C99 style declarations are not generally used in DPDK. True :) It

Re: [dpdk-dev] [PATCH] eal/x86: get hypervisor name

2017-11-30 Thread Stephen Hemminger
On Thu, 30 Nov 2017 22:47:20 +0100 Thomas Monjalon wrote: > + for (int reg = 1; reg < 4; reg++) > + memcpy(name + (reg - 1) * 4, ®s[reg], 4); > + name[12] = '\0'; C99 style declarations are not generally used in DPDK.

[dpdk-dev] [PATCH] eal/x86: get hypervisor name

2017-11-30 Thread Thomas Monjalon
The CPUID instruction is catched by hypervisor which can return a flag indicating one is running, and its name. Suggested-by: Stephen Hemminger Signed-off-by: Thomas Monjalon --- warning: to be tested --- lib/librte_eal/common/arch/arm/rte_cpuflags.c | 6 + lib/librte_eal/common/arch/

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-11-30 Thread Thomas Monjalon
30/11/2017 22:21, Stephen Hemminger: > On Thu, 30 Nov 2017 18:35:11 +0100 > Thomas Monjalon wrote: > > > 30/11/2017 18:15, Stephen Hemminger: > > > Some thoughts. > > > 1) Not all devices are PCI; look at recent VMBUS > > > > Yes, we need a syntax which works for every devices. > > I suggest t

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-11-30 Thread Stephen Hemminger
On Thu, 30 Nov 2017 18:35:11 +0100 Thomas Monjalon wrote: > 30/11/2017 18:15, Stephen Hemminger: > > Some thoughts. > > 1) Not all devices are PCI; look at recent VMBUS > > Yes, we need a syntax which works for every devices. > I suggest to use the prefix "pci:" before the PCI id. > We need al

Re: [dpdk-dev] [RFC PATCH v4 2/4] eventtimer: add common code

2017-11-30 Thread Carrillo, Erik G
Hi Pavan, Thanks for the review; I'm working on addressing the comments and have the following question (inline): <... snipped ...> > > + adapter->data->mz = mz; > > + adapter->data->event_dev_id = conf->event_dev_id; > > + adapter->data->id = adapter_id; > > + adapter->data->socket_id

[dpdk-dev] [PATCH 2/2] net/softnic: add flow classification ops

2017-11-30 Thread Jasvinder Singh
To manage and configure flow rules, implements operations to validate, create, destroy and flush the flow rules. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_fc.c | 311 ++- 1 file changed, 307 insertions(+), 4 deletions(-) diff --git a/driv

[dpdk-dev] [PATCH 0/2] net/softnic: add flow classification support

2017-11-30 Thread Jasvinder Singh
This patchset extends the softnic device by implementing the software fallback for flow classification as defined using Flow APIs. When feature is enabled, softnic classifies and executes actions on the received packets based on flow rules specified using rte_flow.h. The motivation behind this fea

[dpdk-dev] [PATCH 1/2] net/softnic: enable flow classification function

2017-11-30 Thread Jasvinder Singh
Enables flow classification on softnic rx path so that proceding functions of the packet processing pipeline such as metering and policing could be implemented. Example: Create "soft" port for "hard" port ":02:00.1", enable the Flow Classification (FC) feature with default settings: --vdev '

[dpdk-dev] new EAL mechanism proposal for driver options

2017-11-30 Thread Matan Azrad
Hi all It may be convenient that DPDK drivers can work in several modes. Allowing driver option changes by the user can make the program more efficient. For Example: If user knows that all its Tx packets are 1 segment packets it can change the PMD mode to work with different tx_burst function whi

Re: [dpdk-dev] 17.08.1 patches review and test

2017-11-30 Thread Patil, Harish
-Original Message- From: dev on behalf of Yuanhan Liu Date: Monday, November 27, 2017 at 4:21 AM To: dpdk stable Cc: "dev@dpdk.org" , "Xu, Qian Q" Subject: [dpdk-dev] 17.08.1 patches review and test >Hi all, > >Here is a list of patches targeted for stable release 17.08.1. Please >he

[dpdk-dev] [PATCH] bus/vdev: scan and probe vdev in secondary processes

2017-11-30 Thread Jianfeng Tan
Base on primary/secondary communication channel [1], we add vdev action to scan virtual devices in secondary processes. [1] http://dpdk.org/dev/patchwork/patch/31838/ Signed-off-by: Jianfeng Tan --- drivers/bus/vdev/vdev.c | 104 ++-- 1 file changed

[dpdk-dev] [PATCH 1/3] eal: add channel for multi-process communication

2017-11-30 Thread Jianfeng Tan
Previouly, there are three channels for multi-process (i.e., primary/secondary) communication. 1. Config-file based channel, in which, the primary process writes info into a pre-defined config file, and the secondary process reads info out. 2. vfio submodule has its own channel based

[dpdk-dev] [PATCH 0/3] generic channel for multi-process communication

2017-11-30 Thread Jianfeng Tan
This patchset adds a generic channel for multi-process (primary/secondary) communication. Patch 1: addess the purpose and howto; Patch 2: add a syncrhonous way for those messages which need a response immediately. Patch 3: Rework vfio to use this generic communication channel. Jianfeng Tan (3):

[dpdk-dev] [PATCH 3/3] vfio: use the generic multi-process channel

2017-11-30 Thread Jianfeng Tan
Previously, vfio has its own channel for the secondary process to get container fd and group fd from the primary process. This patch changes to use the generic mp channel. Signed-off-by: Jianfeng Tan --- lib/librte_eal/linuxapp/eal/eal.c | 14 +- lib/librte_eal/linuxapp/eal/eal_vf

[dpdk-dev] [PATCH 2/3] eal: add synchronous multi-process communication

2017-11-30 Thread Jianfeng Tan
We need the synchronous way for multi-process communication, that is to say we need an immediate response after we send a message to the other side. We will stop the mp_handler thread, and after sending message, the send thread will wait there for reponse and process the respond. Suggested-by: An

[dpdk-dev] [PATCH v1] net/tap: allow user mac to be passed as args

2017-11-30 Thread Vipin Varghese
One of the uses cases from customer site is use TAP PMD to intake user specific MAC address during probe. This allows applications make use of interfaces with desired MAC. Extending MAC argumentinfrastructure for tap PMD; we pass custom MAC address in string format (sample - 11:22:33:44:55:66). S

Re: [dpdk-dev] net/i40e: latency issue due fix interrupt throttling setting in PF

2017-11-30 Thread Hanoch Haim (hhaim)
Igb_uio. I will try vfio. Is there a better workaround to force low_latency in Rx side (without our patch)? Hanoh Sent from my iPhone On 30 Nov 2017, at 19:47, Wu, Jingjing mailto:jingjing...@intel.com>> wrote: Hi, Hanoch Thanks a lot for the trying. Are you using igb_uio to bind the device?

Re: [dpdk-dev] net/i40e: latency issue due fix interrupt throttling setting in PF

2017-11-30 Thread Wu, Jingjing
Hi, Hanoch Thanks a lot for the trying. Are you using igb_uio to bind the device? I guess it would be because that fix is not complete, the overlap with Rx interrupt mode is not considered. We will look into it. And it would be great if you can have a try on vfio_pci cases. Thanks Jingjing Fr

Re: [dpdk-dev] [RFC PATCH 0/7] RFC:EventDev OPDL PMD

2017-11-30 Thread Jerin Jacob
-Original Message- > Date: Wed, 29 Nov 2017 17:15:12 + > From: "Ma, Liang" > To: Jerin Jacob > CC: "dev@dpdk.org" , "Van Haaren, Harry" > , "Richardson, Bruce" > , "Jain, Deepak K" , > "Mccarthy, Peter" > Subject: Re: [RFC PATCH 0/7] RFC:EventDev OPDL PMD > User-Agent: Mutt/1.9.1

Re: [dpdk-dev] [RFC 2/2] net/tap: add eBPF instructions

2017-11-30 Thread Thomas Monjalon
30/11/2017 18:20, Stephen Hemminger: > On Thu, 30 Nov 2017 18:05:22 +0100 > Thomas Monjalon wrote: > > > 30/11/2017 17:54, Stephen Hemminger: > > > Loading BPF is a could solution to doing dynamic flow matching. > > > It needs to be done differently to be accepted. > > > > > > Putting raw machin

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-11-30 Thread Thomas Monjalon
30/11/2017 18:15, Stephen Hemminger: > Some thoughts. > 1) Not all devices are PCI; look at recent VMBUS Yes, we need a syntax which works for every devices. I suggest to use the prefix "pci:" before the PCI id. We need also a prefix and ids for NXP buses. We could use "vmbus:" before VMBUS ids. H

Re: [dpdk-dev] [RFC 2/2] net/tap: add eBPF instructions

2017-11-30 Thread Stephen Hemminger
On Thu, 30 Nov 2017 18:05:22 +0100 Thomas Monjalon wrote: > 30/11/2017 17:54, Stephen Hemminger: > > Loading BPF is a could solution to doing dynamic flow matching. > > It needs to be done differently to be accepted. > > > > Putting raw machine instructions in source code is as bad as binary > >

Re: [dpdk-dev] [PATCH] [RFC] ether: standardize getting the port by name

2017-11-30 Thread Stephen Hemminger
On Thu, 30 Nov 2017 15:35:30 +0800 Yuanhan Liu wrote: > The ethdev name is taken from the "name" parameter from the helper > function rte_eth_dev_allocate(name). The name is given by the caller, > thus, there is no way to guarantee all the callers will follow the > same syntax, leaving us the por

Re: [dpdk-dev] [PATCH 3/4] app/eventdev: add perf pipeline test

2017-11-30 Thread Eads, Gage
Hi Pavan, > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Thursday, November 30, 2017 1:24 AM > To: jerin.jacobkollanukka...@cavium.com; Eads, Gage > ; Van Haaren, Harry ; > Richardson, Bruce ; hemant.agra...@nxp.com; > nipun.gu...@nxp.com; Rao

Re: [dpdk-dev] [RFC 2/2] net/tap: add eBPF instructions

2017-11-30 Thread Thomas Monjalon
30/11/2017 17:54, Stephen Hemminger: > Loading BPF is a could solution to doing dynamic flow matching. > It needs to be done differently to be accepted. > > Putting raw machine instructions in source code is as bad as binary > blobs. You need to provide original source of program and then have > b

Re: [dpdk-dev] [RFC 2/2] net/tap: add eBPF instructions

2017-11-30 Thread Stephen Hemminger
On Thu, 30 Nov 2017 08:01:10 + Ophir Munk wrote: > +static struct bpf_insn l2_src_hash_insns[] = { > + {0xbf, 7, 1, 0, 0x}, > + {0x61, 6, 7, 16, 0x}, > + {0x61, 9, 7, 76, 0x}, > + {0x61, 8, 7, 80, 0x}, > + {0x18, 1, 0, 0, 0x

Re: [dpdk-dev] [RFC 1/2] net/tap: add eBPF to TAP device

2017-11-30 Thread Thomas Monjalon
30/11/2017 17:47, Stephen Hemminger: > On Thu, 30 Nov 2017 08:01:09 + > Ophir Munk wrote: > > > diff --git a/drivers/net/tap/tap_bpf_elf.h b/drivers/net/tap/tap_bpf_elf.h > > new file mode 100644 > > index 000..f3db1bf > > --- /dev/null > > +++ b/drivers/net/tap/tap_bpf_elf.h > > @@ -0,0

Re: [dpdk-dev] [RFC 1/2] net/tap: add eBPF to TAP device

2017-11-30 Thread Stephen Hemminger
On Thu, 30 Nov 2017 08:01:09 + Ophir Munk wrote: > diff --git a/drivers/net/tap/tap_bpf_elf.h b/drivers/net/tap/tap_bpf_elf.h > new file mode 100644 > index 000..f3db1bf > --- /dev/null > +++ b/drivers/net/tap/tap_bpf_elf.h > @@ -0,0 +1,56 @@ > +/**

Re: [dpdk-dev] net/i40e: latency issue due fix interrupt throttling setting in PF

2017-11-30 Thread Hanoch Haim (hhaim)
Hi Jingjing, I did that and see the results, It does not work as expected TRex command: $sudo ./t-rex-64 -f astf/http_simple.py -m 1 -l 1000 -d 1000 --astf -c 1 1) with the issue (without the patch) *itr_idx << I40E_QINT_RQCTL_ITR_INDX_SHIFT | *#define RTE_LIBRTE_I40E_ITR_INTERVAL -1 late

[dpdk-dev] FW: [RFC v1] doc compression API for DPDK

2017-11-30 Thread Verma, Shally
Resend with +Pablo -Original Message- From: Verma, Shally Sent: 30 November 2017 16:43 To: 'Trahe, Fiona' ; dev@dpdk.org Cc: Athreya, Narayana Prasad ; Challa, Mahipal Subject: Re: [RFC v1] doc compression API for DPDK HI Fiona > -Original Message- > From: Trahe, Fiona [mailto

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-11-30 Thread Matan Azrad
Hi Gaetan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, November 30, 2017 5:10 PM > To: Matan Azrad > Cc: Neil Horman ; Thomas Monjalon > ; Jingjing Wu ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership > > On T

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-11-30 Thread Gaëtan Rivet
On Thu, Nov 30, 2017 at 02:30:20PM +, Matan Azrad wrote: > Hi all > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Thursday, November 30, 2017 3:25 PM > > To: Neil Horman > > Cc: Matan Azrad ; Thomas Monjalon > > ; Jingjing Wu ; > > dev@dpdk.or

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-11-30 Thread Matan Azrad
Hi all > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, November 30, 2017 3:25 PM > To: Neil Horman > Cc: Matan Azrad ; Thomas Monjalon > ; Jingjing Wu ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership > > Hello M

[dpdk-dev] [PATCH v4] crypto/aesni_mb: add AES-CCM support

2017-11-30 Thread Fan Zhang
Add support to AES-CCM, for 128, 192 and 256-bit keys. Signed-off-by: Fan Zhang --- v4: * Fixed bugs * Updated capabilities v3: * Update with changed names in the driver * Added test cases v2: * Fixed a few bugs doc/guides/cryptodevs/aesni_mb.rst | 4 + doc/guides/cryptodevs

Re: [dpdk-dev] DPDK techboard minutes of November 22

2017-11-30 Thread Bruce Richardson
On Thu, Nov 30, 2017 at 08:02:02PM +0800, Yuanhan Liu wrote: > Hi, > > Here are the minutes of the latest DPDK technical board meeting held on > 2017-11-22. > > Attendees: > - Bruce Richardson > - Hemant Agrawal > - Jerin Jacob > - Konstantin Ananyev > - Olivier Matz > - Stephen Hemminger > - Tho

[dpdk-dev] [PATCH 2/2] crypto/mrvl: update MRVL CRYPTO PMD documentation

2017-11-30 Thread Tomasz Duszynski
Update MRVL CRYPTO PMD documentation. Signed-off-by: Tomasz Duszynski --- doc/guides/cryptodevs/mrvl.rst | 28 doc/guides/nics/mrvl.rst | 2 ++ 2 files changed, 6 insertions(+), 24 deletions(-) diff --git a/doc/guides/cryptodevs/mrvl.rst b/doc/guides/cryptode

[dpdk-dev] [PATCH 7/7] net/mrvl: update MRVL NET PMD documentation

2017-11-30 Thread Tomasz Duszynski
Update MRVL NET PMD documentation. Signed-off-by: Tomasz Duszynski --- doc/guides/nics/mrvl.rst | 69 +++- 1 file changed, 45 insertions(+), 24 deletions(-) diff --git a/doc/guides/nics/mrvl.rst b/doc/guides/nics/mrvl.rst index fbfdf47..67b254c 100644

[dpdk-dev] [PATCH 1/2] crypto/mrvl: sync compilation with musdk-17.10

2017-11-30 Thread Tomasz Duszynski
With a new version of the musdk library it's no longer necessary to explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT. Proper defines are autogenerated by ./configure script based on passed options and available after mv_autogen_comp_flags.h inclusion. Signed-off-by: Tomasz Duszynski --- drivers/c

[dpdk-dev] [PATCH 0/2] Sync compilation with MUSDK-17.10

2017-11-30 Thread Tomasz Duszynski
This patchset comes with the following changes: o MUSDK-17.10 is the latest version of the library. Since it brings improvements and fixes switch is necessary. o Some minor updates to the documentation. Tomasz Duszynski (2): crypto/mrvl: sync compilation with musdk-17.10 crypto/mrvl: updat

[dpdk-dev] [PATCH 6/7] devtools/test-build: add MRVL NET PMD to test-build

2017-11-30 Thread Tomasz Duszynski
Add MRVL NET PMD to test build tool. Signed-off-by: Tomasz Duszynski --- devtools/test-build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/devtools/test-build.sh b/devtools/test-build.sh index 092d3a7..78609c9 100755 --- a/devtools/test-build.sh +++ b/devtools/test-build.sh @@ -197,6 +1

[dpdk-dev] [PATCH 5/7] net/mrvl: add extra error logs

2017-11-30 Thread Tomasz Duszynski
Add extra error logs in a few places. Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/mrvl/mrvl_ethdev.c b/drivers/net/mrvl/mrvl_ethdev.c index 92cc283..ed97831 100644 --- a/drivers/net/mr

[dpdk-dev] [PATCH 4/7] net/mrvl: check if ppio is initialized

2017-11-30 Thread Tomasz Duszynski
Uninitialized ppio cannot be passed to MUSDK library routines as application will crash. Fix this by first checking whether ppio has been initialized. Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 42 ++ 1 file changed, 42 insertion

[dpdk-dev] [PATCH 3/7] net/mrvl: do not enable port after setting MAC address

2017-11-30 Thread Tomasz Duszynski
Setting enabled port's mac address caused it to stop receiving packets. Now as that issue is fixed in library renabling port is no longer necessary. Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --gi

[dpdk-dev] [PATCH 2/7] net/mrvl: query link status using library API

2017-11-30 Thread Tomasz Duszynski
Up to now link status was updated unconditionally during link_up()/link_down() calls thus one was never sure about it's true status. Using dedicated library api makes sure the true link status is set. Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 16 +--- 1 fi

[dpdk-dev] [PATCH 1/7] net/mrvl: sync compilation with musdk-17.10

2017-11-30 Thread Tomasz Duszynski
Followig changes are needed to switch to musdk-17.10: - With a new version of the musdk library it's no longer necessary to explicitly define MVCONF_ARCH_DMA_ADDR_T_64BIT and CONF_PP2_BPOOL_COOKIE_SIZE. Proper defines are autogenerated by ./configure script based on passed options and ava

[dpdk-dev] [PATCH 0/7] Sync with MUSDK-17.10

2017-11-30 Thread Tomasz Duszynski
This patchset brings following changes: o Sync with MUSDK-17.10. Latest version of the library comes with many improvements and fixes thus switching to it is beneficial. o A few code and documentation updates. Tomasz Duszynski (7): net/mrvl: sync compilation with musdk-17.10 net/mrvl: quer

Re: [dpdk-dev] [PATCH 2/5] ethdev: add port ownership

2017-11-30 Thread Gaëtan Rivet
Hello Matan, Neil, I like the port ownership concept. I think it is needed to clarify some operations and should be useful to several subsystems. This patch could certainly be sub-divided however, and your current 1/5 should probably come after this one. Some comments inline. On Thu, Nov 30, 20

Re: [dpdk-dev] [PATCH] app/testpmd: link with virtio PMD when using shared libraries

2017-11-30 Thread Thomas Monjalon
30/11/2017 12:21, Timothy Redaelli: > Just a little question: if testpmd loads the pmds dynamically using > dlopen, why in app/test-pmd/Makefile some PMD are linked at > build time? Some PMD have an API. That's why they need to be directly linked by the applications calling these driver-specific f

[dpdk-dev] [PATCH 11/11] crypto/ccp: update CCP PMD code-base

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_dev.h | 1 + drivers/crypto/ccp/ccp_pci.h | 2 +- drivers/crypto/ccp/rte_ccp_pmd.c | 31 ++- 3 files changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/crypto/ccp/ccp_dev.h b/drivers/crypto/cc

[dpdk-dev] [PATCH 10/11] test/test: add test for AMD CCP crypto PMD

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- test/test/test_cryptodev.c | 161 +++ test/test/test_cryptodev.h | 1 + test/test/test_cryptodev_aes_test_vectors.h | 93 ++-- test/test/test_cryptodev_blockcipher.c | 9 +- test/test

[dpdk-dev] [PATCH 09/11] crypto/ccp: update queue-pair release to enable reset

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_pmd_ops.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/ccp/ccp_pmd_ops.c b/drivers/crypto/ccp/ccp_pmd_ops.c index 9e94dcf..daeb59c 100644 --- a/drivers/crypto/ccp/ccp_pmd_ops.c +++ b/drivers/crypto/cc

[dpdk-dev] [PATCH 07/11] doc: add document for AMD CCP crypto PMD

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- doc/guides/cryptodevs/ccp.rst | 124 + doc/guides/cryptodevs/features/ccp.ini | 57 +++ doc/guides/cryptodevs/index.rst| 1 + 3 files changed, 182 insertions(+) create mode 100644 doc/guides/cryptodevs/

[dpdk-dev] [PATCH 08/11] crypto/ccp: rename CCP crypto driver id

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_crypto.c | 28 ++-- drivers/crypto/ccp/ccp_crypto.h | 2 +- drivers/crypto/ccp/rte_ccp_pmd.c | 10 +- 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/crypto/ccp/ccp_crypto.c b/drivers/

[dpdk-dev] [PATCH 05/11] crypto/ccp: add support for CPU based authentication

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- config/common_base | 1 + drivers/crypto/ccp/ccp_crypto.c | 264 +++ drivers/crypto/ccp/ccp_crypto.h | 8 ++ drivers/crypto/ccp/ccp_pmd_ops.c | 23 +++ drivers/crypto/ccp/ccp_pmd_private.h | 4 +

[dpdk-dev] [PATCH 06/11] crypto/ccp: add support for SHA3 family authentication

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_crypto.c | 668 +++ drivers/crypto/ccp/ccp_crypto.h | 38 ++- drivers/crypto/ccp/ccp_pmd_ops.c | 168 ++ 3 files changed, 872 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/ccp_cryp

[dpdk-dev] [PATCH 04/11] crypto/ccp: add support for AES-CMAC

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_crypto.c | 272 +++ drivers/crypto/ccp/ccp_crypto.h | 3 + drivers/crypto/ccp/ccp_dev.c | 1 + drivers/crypto/ccp/ccp_pmd_ops.c | 21 +++ 4 files changed, 297 insertions(+) diff --git a/drivers/cr

[dpdk-dev] [PATCH 01/11] cryptodev: add compile support for AMD CCP crypto PMD

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- MAINTAINERS | 6 ++ config/common_base | 5 + drivers/crypto/Makefile | 1 + mk/rte.app.mk | 2 ++ 4 files changed, 14 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f0baeb4..daac82e 100644 --- a/MAINTAINERS +++ b/MAINT

[dpdk-dev] [PATCH 03/11] crypto: add macros for AES-CMAC and SHA3

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- doc/guides/cryptodevs/features/default.ini | 12 lib/librte_cryptodev/rte_crypto_sym.h | 18 ++ 2 files changed, 30 insertions(+) diff --git a/doc/guides/cryptodevs/features/default.ini b/doc/guides/cryptodevs/features/default.ini

[dpdk-dev] [PATCH 15/16] net/axgbe: add support for icc and clang build

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_rxtx.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/axgbe/axgbe_rxtx.h b/drivers/net/axgbe/axgbe_rxtx.h index 89bf9bc..6cac673 100644 --- a/drivers/net/axgbe/axgbe_rxtx.h +++ b/drivers/net/axgbe/axgbe_r

[dpdk-dev] [PATCH 16/16] net/axgbe: add support for build 32-bit mode

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_common.h| 49 +++--- drivers/net/axgbe/axgbe_ethdev.c| 10 +- drivers/net/axgbe/axgbe_ethdev.h| 8 +- drivers/net/axgbe/axgbe_rxtx.c | 12 +- drivers/net/axgbe/axgbe_rxtx.h | 4 +- drivers/net/axgbe/axgbe_rxtx.h.or

[dpdk-dev] [PATCH 14/16] doc: add documents for AMD axgbe Ethernet PMD

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- doc/guides/nics/axgbe.rst | 214 + doc/guides/nics/features/axgbe.ini | 18 doc/guides/nics/index.rst | 1 + 3 files changed, 233 insertions(+) create mode 100644 doc/guides/nics/axgbe.rst create mode 10

[dpdk-dev] [PATCH 13/16] net/axgbe: add generic transmit and receive stats support

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_ethdev.c | 51 1 file changed, 51 insertions(+) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index d476632..84adf96 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++

[dpdk-dev] [PATCH 12/16] net/axgbe: add promiscuous mode support

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_ethdev.c | 48 1 file changed, 48 insertions(+) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index dc012a0..d476632 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++

[dpdk-dev] [PATCH 11/16] net/axgbe: add configure flow control while link adjustment

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_mdio.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/axgbe/axgbe_mdio.c b/drivers/net/axgbe/axgbe_mdio.c index 753dde9..07f4087 100644 --- a/drivers/net/axgbe/axgbe_mdio.c +++ b/drivers/net/axgbe/axgbe_mdio.c @

[dpdk-dev] [PATCH 07/16] net/axgbe: add interrupt handler for autonegotiation

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_ethdev.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index 65a04f4..341808d 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/

[dpdk-dev] [PATCH 10/16] net/axgbe: add transmit and receive data path apis

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/Makefile | 1 + drivers/net/axgbe/axgbe_ethdev.c | 56 - drivers/net/axgbe/axgbe_rxtx.c | 427 + drivers/net/axgbe/axgbe_rxtx.h | 19 ++ drivers/net/axgbe/axgbe_rxtx_vec.c | 215 +

[dpdk-dev] [PATCH 08/16] net/axgbe: add transmit and receive queue setup apis

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/Makefile | 1 + drivers/net/axgbe/axgbe_ethdev.c | 82 + drivers/net/axgbe/axgbe_ethdev.h | 36 drivers/net/axgbe/axgbe_rxtx.c | 363 +++ drivers/net/axgbe/axgbe_rxtx.h | 283 +++

[dpdk-dev] [PATCH 09/16] net/axgbe: add DMA programming and dev start and stop apis

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_dev.c| 844 +++ drivers/net/axgbe/axgbe_ethdev.c | 97 - 2 files changed, 940 insertions(+), 1 deletion(-) diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c index 528241e..

[dpdk-dev] [PATCH 06/16] net/axgbe: add phy programming apis

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/axgbe_dev.c | 27 + drivers/net/axgbe/axgbe_mdio.c | 963 + drivers/net/axgbe/axgbe_phy_impl.c | 1397 3 files changed, 2387 insertions(+) diff --git a/drivers/net/axgbe/axgbe

[dpdk-dev] [PATCH 04/16] net/axgbe: add structures for MAC initialization and reset

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/Makefile | 1 + drivers/net/axgbe/axgbe_dev.c| 167 +++ drivers/net/axgbe/axgbe_ethdev.c | 291 drivers/net/axgbe/axgbe_ethdev.h | 349 +++ 4 files chan

[dpdk-dev] [PATCH 05/16] net/axgbe: add phy initialization and related apis

2017-11-30 Thread Ravi Kumar
Signed-off-by: Ravi Kumar --- drivers/net/axgbe/Makefile | 3 + drivers/net/axgbe/axgbe_dev.c | 188 + drivers/net/axgbe/axgbe_ethdev.c | 11 + drivers/net/axgbe/axgbe_ethdev.h | 172 drivers/net/axgbe/axgbe_i2c.c | 453 + drivers/net/

  1   2   >