Re: [dpdk-dev] [PATCH] vhost: support UDP Fragmentation Offload

2017-11-20 Thread Hu, Jiayu
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, November 21, 2017 3:13 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; y...@fridaylinux.org; Tan, Jianfeng > > Subject: Re: [dpdk-dev] [PATCH] vhost: support UDP Fragmentation Offload >

Re: [dpdk-dev] [PATCH] vhost: support UDP Fragmentation Offload

2017-11-20 Thread Stephen Hemminger
On Tue, 21 Nov 2017 14:56:52 +0800 Jiayu Hu wrote: > In virtio, UDP Fragmentation Offload (UFO) includes two parts: host UFO > and guest UFO. Guest UFO means the frontend can receive large UDP packets, > and host UFO means the backend can receive large UDP packets. This patch > supports host UFO

Re: [dpdk-dev] [PATCH] eal/common: better likely() and unlikely()

2017-11-20 Thread Aleksey Baulin
Sorry for late response. Jim had given the correct answer already. You won't get an extra instruction with compiler optimization turned on. Aleksey. On Mon, Nov 20, 2017 at 4:36 PM, Wiles, Keith wrote: > > > > On Nov 19, 2017, at 4:16 PM, Aleksey Baulin > wrote: > > > > A warning is issued whe

[dpdk-dev] [PATCH] vhost: support UDP Fragmentation Offload

2017-11-20 Thread Jiayu Hu
In virtio, UDP Fragmentation Offload (UFO) includes two parts: host UFO and guest UFO. Guest UFO means the frontend can receive large UDP packets, and host UFO means the backend can receive large UDP packets. This patch supports host UFO and guest UFO for vhost-user. Signed-off-by: Jiayu Hu ---

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF

2017-11-20 Thread Wu, Yanglong
Hi, Yes, I think so, we can change it. nb_rx_q just means the number of queue used for a port and RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool means max queue can be used. -Original Message- From: Ananyev, Konstantin Sent: Monday, November 20, 2017 6:44 PM To: Wu, Yanglong ; dev@dpdk.org Cc: Wu,

Re: [dpdk-dev] [PATCH 6/6] doc: add mbuf VLAN flag to PMD todo list

2017-11-20 Thread Ferruh Yigit
On 11/20/2017 5:42 PM, Ferruh Yigit wrote: > To track modification: > 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags") I recognized that almost all are by Olivier, cc'ed :) > Proposed deadline for PMDs is v18.02 > > Signed-off-by: Ferruh Yigit <...>

[dpdk-dev] [PATCH 6/6] doc: add mbuf VLAN flag to PMD todo list

2017-11-20 Thread Ferruh Yigit
To track modification: 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags") Proposed deadline for PMDs is v18.02 Signed-off-by: Ferruh Yigit --- doc/guides/nics/todo.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst index 61d

[dpdk-dev] [PATCH 4/6] doc: add descriptor status API to PMD todo list

2017-11-20 Thread Ferruh Yigit
To track modification: b1b700ce7d6f ("ethdev: add descriptor status API") Proposed deadline for PMDs is v19.02 Signed-off-by: Ferruh Yigit --- doc/guides/nics/todo.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst index 9733

[dpdk-dev] [PATCH 1/6] doc: add empty PMDs todo list

2017-11-20 Thread Ferruh Yigit
Some library modifications require extra checks or modifications in PMDs but currently we don't have a good way to trace these modifications. And number of these kind of updates increasing by time. This is an effort to document and track library updates that requires attention in PMDs. Although

[dpdk-dev] [PATCH 5/6] doc: add offload flag to PMD todo list

2017-11-20 Thread Ferruh Yigit
To track modification: ce17eddefc20 ("ethdev: introduce Rx queue offloads API") cba7f53b717d ("ethdev: introduce Tx queue offloads API") Proposed deadline for PMDs is v18.05 Signed-off-by: Ferruh Yigit --- doc/guides/nics/todo.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a

[dpdk-dev] [PATCH 2/6] doc: add mbuf reorg to PMD todo list

2017-11-20 Thread Ferruh Yigit
To track modification: 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") Proposed deadline for PMDs is v18.02 Signed-off-by: Ferruh Yigit --- doc/guides/nics/todo.rst | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/doc/guides/nics/todo.rst b/doc/guide

[dpdk-dev] [PATCH 3/6] doc: add dynamic logging to PMD todo list

2017-11-20 Thread Ferruh Yigit
To track modification: c1b5fa94a46f ("eal: support dynamic log types") Proposed deadline for PMDs is v18.08 Signed-off-by: Ferruh Yigit --- doc/guides/nics/todo.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst index b408fc6

[dpdk-dev] [RFC PATCH v3 1/1] eventtimer: introduce event timer adapter

2017-11-20 Thread Erik Gabriel Carrillo
Signed-off-by: Erik Gabriel Carrillo --- v3 - Reworked allocation and ops organization in common code based on feedback received from Jerin and Pavan. This will allow fast-path function pointers to be dereferenced with one level of indirection with pointers valid in primary and secondary pr

[dpdk-dev] [RFC PATCH v3 0/1] eventtimer: introduce event timer adapter

2017-11-20 Thread Erik Gabriel Carrillo
The following RFC patch contains a reworked version of the event timer adapter logic that would be common to both the software and hardware implementations. It contains an allocation scheme that separates the adapter state into two parts: one part that is local to a process, and another that is sh

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: added switch_domain and representor port flag

2017-11-20 Thread Ferruh Yigit
On 11/17/2017 6:42 AM, Mohammad Abdul Awal wrote: > switch_domain attribute has been added to specify that a rte_eth_dev > instance belongs to a switch domain in the software switch. > > RTE_ETH_DEV_REPRESENTOR_PORT has been defined to specify that a > rte_eth_dev instance is a representor device.

Re: [dpdk-dev] [PATCH 1/2] lib/security: add support for saving app cookie

2017-11-20 Thread Anoob Joseph
Hi See inline. On 20-11-2017 23:19, Radu Nicolau wrote: Hi On 11/20/2017 3:32 PM, Anoob wrote: Hi, Having something like "get_pkt_metadata" should be fine for inline protocol usage. But we will still need a "get cookie" call to get the cookie, as the application would need something it ca

Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print

2017-11-20 Thread Ferruh Yigit
On 11/17/2017 12:47 AM, Pavan Nikhilesh Bhagavatula wrote: > On Thu, Nov 16, 2017 at 11:48:14AM -0800, Ferruh Yigit wrote: >> On 11/16/2017 2:31 AM, Pavan Nikhilesh wrote: >>> Dynamic logs fail to print if the global log level is less than dynamic >>> loglevel. Example if the global log level is se

Re: [dpdk-dev] [PATCH 1/2] lib/security: add support for saving app cookie

2017-11-20 Thread Radu Nicolau
Hi On 11/20/2017 3:32 PM, Anoob wrote: Hi, Having something like "get_pkt_metadata" should be fine for inline protocol usage. But we will still need a "get cookie" call to get the cookie, as the application would need something it can interpret. Why can't you have a get_pkt_metadata that ret

Re: [dpdk-dev] [PATCH] eal/common: better likely() and unlikely()

2017-11-20 Thread Jim Thompson
> On Nov 20, 2017, at 7:36 AM, Wiles, Keith wrote: > >> On Nov 19, 2017, at 4:16 PM, Aleksey Baulin wrote: >> >> #ifndef unlikely >> -#define unlikely(x) __builtin_expect((x),0) >> +#define unlikely(x) __builtin_expect(!!(x), 0) > > I have not looked at the generated code, but does this add

[dpdk-dev] [PATCH 3/3] doc: add description of traffic metering and policing funcs in testpmd

2017-11-20 Thread Jasvinder Singh
Signed-off-by: Jasvinder Singh --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 173 1 file changed, 173 insertions(+) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 9789139..a8b7913 100644 --- a/doc/gui

[dpdk-dev] [PATCH 2/3] app/testpmd: add CLI for metering and policing API

2017-11-20 Thread Jasvinder Singh
Add following CLIs to testpmd application; - show port metering and policing capabilities. - enable/disable meter of the MTR object. - update the MTR object dscp table entries. Signed-off-by: Jasvinder Singh --- app/test-pmd/cmdline.c | 17 +++ app/test-pmd/cmdline_mtr.c | 325 +

[dpdk-dev] [PATCH 1/3] app/testpmd: metering and policing CLI clean up

2017-11-20 Thread Jasvinder Singh
This patch updates the metering and policing CLIs as follows: - change name of set port meter CLI to create port meter and add meter enable option, dscp table entries arguments, action mask, policer actions and previous meter color option as an input color - set the right metering algorithm in

[dpdk-dev] [PATCH] net/mlx5: fix Tx checksum offloads

2017-11-20 Thread Nelio Laranjeiro
Tx checksum offloads are correctly handled in a single Tx burst function whereas the capability is always set. This causes VXLAN packet with checksum offloads request to be ignored when the (E)MPS Tx functions are selected. Fixes: f5fde5205101 ("net/mlx5: add hardware checksum offload for tunnel

Re: [dpdk-dev] [PATCH 1/2] lib/security: add support for saving app cookie

2017-11-20 Thread Anoob
Hi, Having something like "get_pkt_metadata" should be fine for inline protocol usage. But we will still need a "get cookie" call to get the cookie, as the application would need something it can interpret. And, even though it seems both are symmetric operations(get & set pkt metadata), ther

[dpdk-dev] net/i40e: latency issue due fix interrupt throttling setting in PF

2017-11-20 Thread Hanoch Haim (hhaim)
Hi All, While integrating dpdk17.11 into TRex latest code a new latency issue is observed (i40e is very sensitive because it has very good resolution due to Qos configuration). git bitsec found the following commit. With this commit we observe high spikes of Rx latency (~40usec) vs (~8usec). Any

[dpdk-dev] [PATCH] net/tap: add Rx interrupts

2017-11-20 Thread Moti Haimovsky
This patch adds support for registering and waiting for Rx interrupts. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. Signed-off-by: Moti Haimovsky --- doc/guides/nics/features/tap.ini | 1 + drivers/net/tap/Makefile | 1 + drivers/net

Re: [dpdk-dev] [PATCH] eal/common: better likely() and unlikely()

2017-11-20 Thread Wiles, Keith
> On Nov 19, 2017, at 4:16 PM, Aleksey Baulin wrote: > > A warning is issued when using an argument to likely() or unlikely() > builtins which is evaluated to a pointer value, as __builtin_expect() > expects a 'long int' type for its first argument. With this fix > a pointer value is converted

Re: [dpdk-dev] [PATCH] vhost user: unlink sockaddr when poll sched fails

2017-11-20 Thread Ilya Maximets
Hi everyone, This issue is already discussed many times here and in OVS mail-lists. The basic restart issue was resolved by removing the sockets at exit in OVS. The crash scenario is not handled but you're able to remove all of the left files by some external script before restarting the OVS. Tha

Re: [dpdk-dev] [PATCH 1/2] lib/security: add support for saving app cookie

2017-11-20 Thread Radu Nicolau
Hi, Why not have something similar to rte_security_set_pkt_metadata, for example: void * rte_security_get_pkt_metadata(struct rte_security_ctx *instance,               struct rte_mbuf *mb); and keep internally in the PMD all the required references. The returned value will be device-spe

[dpdk-dev] [PATCH] net/liquidio: add support for queue re-configuration

2017-11-20 Thread Shijith Thotton
Support for re-configuration of number of queues per port and descriptor size. Renamed variable representing number of descriptors as nb_desc from max_count. Signed-off-by: Shijith Thotton --- drivers/net/liquidio/base/lio_23xx_vf.c | 54 +-- drivers/net/liquidio/base/lio_23xx_vf.h |

Re: [dpdk-dev] [RFC] Compression API in DPDK

2017-11-20 Thread Verma, Shally
Ok. Assume that will be self-contained unlike current which has references to crypto?! Thanks Shally > -Original Message- > From: Trahe, Fiona [mailto:fiona.tr...@intel.com] > Sent: 20 November 2017 17:04 > To: Verma, Shally ; dev@dpdk.org > Cc: Athreya, Narayana Prasad ; > Challa, Mahip

Re: [dpdk-dev] [RFC] Compression API in DPDK

2017-11-20 Thread Trahe, Fiona
Hi Shally, I'm aiming to get a v2 of the RFC out this week. Regards, Fiona > -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Monday, November 20, 2017 6:44 AM > To: Verma, Shally ; Trahe, Fiona > ; dev@dpdk.org > Cc: Athreya, Narayana Prasad ; Challa, >

Re: [dpdk-dev] [PATCH v3] net/i40e: determine number of queues per VF during run time

2017-11-20 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Dai > Sent: Sunday, November 19, 2017 2:08 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Dai, Wei > Subject: [dpdk-dev] [PATCH v3] net/i40e: determine number of queues per VF > during run time >

[dpdk-dev] [PATCH] net/sfc/base: remove Falcon-specific concurrency check

2017-11-20 Thread Andrew Rybchenko
From: Ivan Malov Falcon support has been withdrawn from libefx, however, there is still an obsolete Falcon-specific assertion that efx_mac_stats_upload() and efx_port_poll() aren't concurrent. To be consistent with an overall Falcon support revocation it's desirable to remove it. Fix debug build

Re: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF

2017-11-20 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yanglong Wu > Sent: Monday, November 20, 2017 2:40 AM > To: dev@dpdk.org > Cc: Wu, Yanglong > Subject: [dpdk-dev] [PATCH v4] net/ixgbe: fix l3fwd start failed on PF > > L3fwd start failed on PF, for tx_q check f

[dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: add support for inline protocol

2017-11-20 Thread Anoob Joseph
Adding support for inline protocol processing. In ingress side, application will receive regular IP packets, without any IPsec related info. Application will do a selector check (SP-SA check) by making use of the cookie it registers while creating the security session. In egress side, the plain p

[dpdk-dev] [PATCH 1/2] lib/security: add support for saving app cookie

2017-11-20 Thread Anoob Joseph
In case of inline protocol processed ingress traffic, the packet may not have enough information to determine the security parameters with which the packet was processed. In such cases, the application could register a cookie, which will be saved in the the security session. As the ingress packets

[dpdk-dev] [PATCH 0/2] add inline protocol support

2017-11-20 Thread Anoob Joseph
The series adds inline protocol support in ipsec-secgw application. First patch introduces changes in lib to enable applications to store and retrieve a 64 bit cookie. This is required for inline protocol processed ingress packets. For inline protocol processed ingress packets, the packet may not

Re: [dpdk-dev] [PATCH] app/testpmd: link with virtio PMD when using shared libraries

2017-11-20 Thread Eelco Chaudron
On 17/11/17 17:19, Timothy Redaelli wrote: testpmd is often used inside a VM to test the OVS PVP scenario. This commit makes testpmd to link to virtio PMD when DPDK is built as shared libraries too. Signed-off-by: Timothy Redaelli --- app/test-pmd/Makefile | 4 1 file changed, 4 inserti

Re: [dpdk-dev] [PATCH] app/testpmd: Remove xenvirt again

2017-11-20 Thread Eelco Chaudron
On 17/11/17 15:40, Timothy Redaelli wrote: Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding mode") Signed-off-by: Timothy Redaelli --- app/test-pmd/Makefile | 4 1 file changed, 4 deletions(-) diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index d21308fc

Re: [dpdk-dev] [PATCH] vhost user: unlink sockaddr when poll sched fails

2017-11-20 Thread Tan, Jianfeng
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gellert Babel > Sent: Monday, November 20, 2017 2:59 PM > To: y...@fridaylinux.org; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Jan Wickbom; Gellert Babel > Subject: [dpdk-dev] [PATCH] vhost user: unlink soc

[dpdk-dev] [PATCH 2/2] app/testpmd: support GENEVE pattern item in flow rules

2017-11-20 Thread Andrew Rybchenko
From: Roman Zhukov Add the ability to match a VNI field of GENEVE protocol header. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko --- app/test-pmd/cmdline_flow.c | 31 + app/test-pmd/config.c | 1 + doc/guides/tes

[dpdk-dev] [PATCH 0/2] ethdev: add GENEVE to flow API

2017-11-20 Thread Andrew Rybchenko
enum rte_flow_item_type states that items matching protocol headers must be stacked in the same order as the protocol layers to match. As the result the patch changes ABI since Geneve is added just after VXLAN (the closest protocol). In fact as far as I can see many items do not follow the require

[dpdk-dev] [PATCH 1/2] ethdev: add GENEVE flow pattern item

2017-11-20 Thread Andrew Rybchenko
From: Roman Zhukov Add new pattern item RTE_FLOW_ITEM_TYPE_GENEVE in flow API. This commit also adds default mask for these item. Signed-off-by: Roman Zhukov Signed-off-by: Andrew Rybchenko --- doc/guides/prog_guide/rte_flow.rst | 12 lib/librte_ether/rte_flow.c| 1 + li