[dpdk-dev] [PATCH] net/i40e: fix mirror for new FW

2017-10-30 Thread Qi Zhang
Value of I40E_GL_SWR_PRI_JOIN_MAP_0 need to be corrected or mirror does not work on latest firmware 6.0. Fixes: 77370db964f7 ("net/i40e: fix ethertype filter for new FW") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[dpdk-dev] [PATCH] net/i40e: fix received packets number for ARM vPMD

2017-10-30 Thread Jianbo Liu
Fix i40e stop receiving on ARM, as the statuses of RX descriptors are not consistent, which is caused by cacheable hugepages. Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") Cc: sta...@dpdk.org Signed-off-by: Jianbo Liu --- drivers/net/i40e/i40e_rxtx_vec_neon.c | 19 -

[dpdk-dev] [PATCH v2] doc: more clarification for i40e 16 bytes desc

2017-10-30 Thread Wenzhuo Lu
The description of i40e 16 bytes descriptor is not clear enough. Add more details. Signed-off-by: Wenzhuo Lu --- doc/guides/nics/i40e.rst | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index a0946e6..

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-30 Thread Jia He
Hi Jerin Do you think  next step whether I need to implement the load_acquire half barrier as per freebsd or find any other performance test case to compare the performance impact? Thanks for any suggestions. Cheers, Jia On 10/25/2017 9:26 PM, Jerin Jacob Wrote: -Original Message-

Re: [dpdk-dev] [ovs-dpdk bug] Failing to release memory when QEMU exits?

2017-10-30 Thread Sam
add dpdk 2017-10-31 10:43 GMT+08:00 Sam : > Hi all, > > I found in ovs-dpdk it is failing to release memory when QEMU exits. Is > this a clear bug in ovs-dpdk? If it is, when did this bug fixed? Detail is > bellow: > > > For qemu-2.6.0 and ovs-dpdk, in huge page (1G) environment, after kill the >

Re: [dpdk-dev] [PATCH] doc: more clarification for i40e 16 bytes desc

2017-10-30 Thread Lu, Wenzhuo
Hi Bruce, > -Original Message- > From: Richardson, Bruce > Sent: Wednesday, October 25, 2017 4:37 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: more clarification for i40e 16 bytes desc > > On Wed, Oct 25, 2017 at 10:54:53AM +0800, Wenzhuo Lu wrote: > > T

Re: [dpdk-dev] [PATCH] net/mlx5: fix add counter when dev not started

2017-10-30 Thread Ferruh Yigit
On 10/30/2017 12:41 AM, Nélio Laranjeiro wrote: > On Mon, Oct 30, 2017 at 09:32:24AM +0200, Ori Kam wrote: >> When adding count action to a drop flow rule while the device was not >> stated, the counter was not saved in the flow. >> >> Fixes: 9a761de8ea14 ("net/mlx5: flow counter support") >> Cc: o

Re: [dpdk-dev] [PATCH 1/4] testpmd: fix LACP ports to work with idle links

2017-10-30 Thread Ferruh Yigit
On 6/21/2017 6:25 PM, jingjing.wu at intel.com (Wu, Jingjing) wrote: >> -Original Message- >> From: rsanford2 at gmail.com >> Sent: Tuesday, August 2, 2016 4:43 AM >> Subject: [dpdk-dev] [PATCH 1/4] testpmd: fix LACP ports to work with idle >> links >> >> Problem: When there is little or n

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow director matching rules

2017-10-30 Thread Ferruh Yigit
On 10/26/2017 11:50 PM, Nelio Laranjeiro wrote: > Flow director API does not provide a layer 2 configuration when the filter > is for layer 3 and 4 causing the translation to generic flow API to be > wrong, as not providing a mask for layer ends by using the default one. In > this case, the Ethern

Re: [dpdk-dev] [PATCH] net/bnxt: fix fdir filter code

2017-10-30 Thread Ferruh Yigit
On 10/27/2017 8:53 AM, Ajit Khaparde wrote: > Set the filter_type before we match a new filter against existing > filters. Otherwise we are missing the existing filters. > > Fixes: 2d64da097aa0 ("net/bnxt: support FDIR") > > Signed-off-by: Ajit Khaparde Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/bnxt: fix HWRM command failures during VF unload

2017-10-30 Thread Ferruh Yigit
On 10/30/2017 9:08 AM, Ajit Khaparde wrote: > In some cases when a VF driver is unloaded after the PF driver, > certain HWRM commands are returned with an error. > Instead the PF can tell the FW to permit these commands in order > to allow a clean unload. > Signed-off-by: Ajit Khaparde Applied to

Re: [dpdk-dev] [PATCH] net/bnxt: donot set hash type unnecessarily

2017-10-30 Thread Ferruh Yigit
On 10/26/2017 7:30 PM, Ajit Khaparde wrote: > We are wrongly "OR-ing" the vnic->hash_type instead of assigning > the new hash type thereby wrongly configuring hash settings. > Fixing it. > > Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration") > > Signed-off-by: Ajit Khaparde Applied to

Re: [dpdk-dev] [PATCH] net/mlx5: fix RSS action for tunneled packets

2017-10-30 Thread Ferruh Yigit
On 10/26/2017 11:27 PM, Nélio Laranjeiro wrote: > On Thu, Oct 26, 2017 at 08:41:57PM +0300, Shahaf Shuler wrote: >> The flow engine in mlx5 searches for the most specific layer in the >> pattern in order to set the flow rule priority properly. >> >> Since the RSS can be currently performed only for

Re: [dpdk-dev] [PATCH v2 1/4] net/ixgbevf: unregister irq handler when other interrupts

2017-10-30 Thread Ferruh Yigit
On 10/26/2017 7:04 AM, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > When we bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the > rx-interrupt, there will be more than one epoll_wait on intr_handle.fd. > One is in "eal-intr-thread" thread, and the others are in the thread >

Re: [dpdk-dev] [PATCH] net/tap: fix invalid queue file descriptor

2017-10-30 Thread Ferruh Yigit
On 10/26/2017 2:51 AM, Pengzhen Liu wrote: > From: Keith Wiles > > Rx and Tx queues share the common tap file descriptor, but save this > value separately. > > Setting up Rx/Tx queue sets up both queues, release_queue close the > tap file but update file descriptor only for that queue. > > This

Re: [dpdk-dev] vfio-pci blocking issue

2017-10-30 Thread Ferruh Yigit
On 10/30/2017 1:14 AM, Gaëtan Rivet wrote: > Hi Xueqin, > > Thank you for the thorough test report. > Multiple filings for this bug, please refer to the thread > > http://dpdk.org/ml/archives/dev/2017-October/080746.html > > Which will focus discussion. A first fix and a new proposition are > av

[dpdk-dev] LINUX VF

2017-10-30 Thread Nishant Verma
Hi, I am trying to configure SRIOV on my SUPERMICRO BLADES. I assigned 10G NIC to igb_uio. After that created 4 VF's. Out of 4 VF's, 3 are used by DPDK App and one I am assigning to Linux kernel. Now when I am assigning IP to a virtual interface on top of Linux VF after PF is up. The first time i

[dpdk-dev] [PATCH v4] bus/pci: fix vfio mode

2017-10-30 Thread Ferruh Yigit
Revert back to using VFIO_PRESENT as a marker to enable compilation of VFIO-related segments. VFIO_PRESENT is the combination of user configuration RTE_EAL_VFIO and kernel version support check. eal_vfio.h VFIO_PRESENT related check ordered to be compatible with rte_vfio.h one, no functional modi

Re: [dpdk-dev] [PATCH v3 6/7] net/mlx4: mitigate Tx path memory barriers

2017-10-30 Thread Matan Azrad
Hi Adrien > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Monday, October 30, 2017 4:24 PM > To: Matan Azrad > Cc: dev@dpdk.org; Ophir Munk > Subject: Re: [PATCH v3 6/7] net/mlx4: mitigate Tx path memory barriers > > On Mon, Oct 30, 2017 at 10:0

Re: [dpdk-dev] [PATCH v3 1/2] bus/pci: fix vfio mode

2017-10-30 Thread Ferruh Yigit
On 10/30/2017 10:26 AM, Ferruh Yigit wrote: > On 10/30/2017 9:36 AM, Gaetan Rivet wrote: >> From: Jerin Jacob >> >> Revert back to using VFIO_PRESENT as a marker to enable compilation >> of VFIO-related segments. >> >> Fixes: 279b581c897d ("vfio: expose functions") >> >> Signed-off-by: Jerin Jacob

Re: [dpdk-dev] [PATCH v3 5/7] net/mlx4: separate Tx segment cases

2017-10-30 Thread Matan Azrad
Hi Adrien > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Monday, October 30, 2017 4:24 PM > To: Matan Azrad > Cc: dev@dpdk.org; Ophir Munk > Subject: Re: [PATCH v3 5/7] net/mlx4: separate Tx segment cases > > On Mon, Oct 30, 2017 at 10:07:27AM

Re: [dpdk-dev] [PATCH v3 3/7] net/mlx4: merge Tx path functions

2017-10-30 Thread Matan Azrad
Ok, thanks! > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Monday, October 30, 2017 4:24 PM > To: Matan Azrad > Cc: dev@dpdk.org; Ophir Munk > Subject: Re: [PATCH v3 3/7] net/mlx4: merge Tx path functions > > On Mon, Oct 30, 2017 at 10:07:25AM

Re: [dpdk-dev] [PATCH v3 1/7] net/mlx4: remove error flows from Tx fast path

2017-10-30 Thread Matan Azrad
Hi Adrien > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Monday, October 30, 2017 4:23 PM > To: Matan Azrad > Cc: dev@dpdk.org; Ophir Munk > Subject: Re: [PATCH v3 1/7] net/mlx4: remove error flows from Tx fast path > > On Mon, Oct 30, 2017 at

Re: [dpdk-dev] [PATCH] eventdev: remove experimental label

2017-10-30 Thread Jerin Jacob
-Original Message- > Date: Mon, 23 Oct 2017 18:27:52 + > From: "Eads, Gage" > To: Jerin Jacob , "dev@dpdk.org" > > CC: "Richardson, Bruce" , "Van Haaren, Harry" > , Hemant Agrawal , > Nipun Gupta , "Rao, Nikhil" , > Pavan Nikhilesh , Thomas Monjalon > > Subject: RE: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v3 2/2] eal: warn user that VFIO is disabled

2017-10-30 Thread Ferruh Yigit
On 10/30/2017 9:36 AM, Gaetan Rivet wrote: > If VFIO is not compatible with the kernel used, print a soft warning to > the user if RTE_EAL_VFIO was still enabled in the configuration. > > Signed-off-by: Gaetan Rivet > --- > lib/librte_eal/linuxapp/eal/eal_vfio.h | 2 ++ > 1 file changed, 2 inser

Re: [dpdk-dev] [PATCH v3 1/2] bus/pci: fix vfio mode

2017-10-30 Thread Ferruh Yigit
On 10/30/2017 9:36 AM, Gaetan Rivet wrote: > From: Jerin Jacob > > Revert back to using VFIO_PRESENT as a marker to enable compilation > of VFIO-related segments. > > Fixes: 279b581c897d ("vfio: expose functions") > > Signed-off-by: Jerin Jacob > Signed-off-by: Gaetan Rivet Tested-by: Ferruh

Re: [dpdk-dev] [PATCH] bus/pci: fix vfio mode

2017-10-30 Thread Gaëtan Rivet
On Mon, Oct 30, 2017 at 09:57:08AM -0700, Ferruh Yigit wrote: > On 10/30/2017 4:24 AM, Thomas Monjalon wrote: > > 30/10/2017 10:27, Thomas Monjalon: > >> 30/10/2017 10:17, Gaëtan Rivet: > >>> Hi Ferruh, > >>> > >>> On Mon, Oct 30, 2017 at 02:00:43AM -0700, Ferruh Yigit wrote: > On 10/30/2017 1

Re: [dpdk-dev] [PATCH] bus/pci: fix vfio mode

2017-10-30 Thread Ferruh Yigit
On 10/30/2017 4:24 AM, Thomas Monjalon wrote: > 30/10/2017 10:27, Thomas Monjalon: >> 30/10/2017 10:17, Gaëtan Rivet: >>> Hi Ferruh, >>> >>> On Mon, Oct 30, 2017 at 02:00:43AM -0700, Ferruh Yigit wrote: On 10/30/2017 1:06 AM, Gaëtan Rivet wrote: > Hi Jerin, > > On Sat, Oct 28, 2017

[dpdk-dev] [PATCH v3 2/2] eal: warn user that VFIO is disabled

2017-10-30 Thread Gaetan Rivet
If VFIO is not compatible with the kernel used, print a soft warning to the user if RTE_EAL_VFIO was still enabled in the configuration. Signed-off-by: Gaetan Rivet --- lib/librte_eal/linuxapp/eal/eal_vfio.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_vf

[dpdk-dev] [PATCH v3 1/2] bus/pci: fix vfio mode

2017-10-30 Thread Gaetan Rivet
From: Jerin Jacob Revert back to using VFIO_PRESENT as a marker to enable compilation of VFIO-related segments. Fixes: 279b581c897d ("vfio: expose functions") Signed-off-by: Jerin Jacob Signed-off-by: Gaetan Rivet --- In addition to simply re-defining VFIO_PRESENT, the previous #ifdef remove

[dpdk-dev] [PATCH] net/bnxt: fix HWRM command failures during VF unload

2017-10-30 Thread Ajit Khaparde
In some cases when a VF driver is unloaded after the PF driver, certain HWRM commands are returned with an error. Instead the PF can tell the FW to permit these commands in order to allow a clean unload. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 ins

Re: [dpdk-dev] [PATCH] net/mlx4: enhance Rx packet type offloads

2017-10-30 Thread Adrien Mazarguil
Hi Moti, On Mon, Oct 30, 2017 at 01:34:16PM +0200, Moti Haimovsky wrote: > This patch enhances the Rx packet type offload to also report the L4 > protocol information in the hw ptype filled by the PMD for each received > packet. > > Signed-off-by: Moti Haimovsky > --- > drivers/net/mlx4/mlx4.c

Re: [dpdk-dev] [PATCH v3 7/7] net/mlx4: remove empty Tx segment support

2017-10-30 Thread Adrien Mazarguil
On Mon, Oct 30, 2017 at 10:07:29AM +, Matan Azrad wrote: > Move empty segment case processing to debug mode. > > Signed-off-by: Matan Azrad Whoa, I think there's a misunderstanding here. Nothing prevents applications from attempting to send zero-length segments, and the PMD must survive this

Re: [dpdk-dev] [PATCH v3 6/7] net/mlx4: mitigate Tx path memory barriers

2017-10-30 Thread Adrien Mazarguil
On Mon, Oct 30, 2017 at 10:07:28AM +, Matan Azrad wrote: > Replace most of the memory barriers by compiler barriers since they are > all targeted to the DRAM; This improves code efficiency for systems > which force store order between different addresses. > > Only the doorbell record store sho

Re: [dpdk-dev] [PATCH v3 5/7] net/mlx4: separate Tx segment cases

2017-10-30 Thread Adrien Mazarguil
On Mon, Oct 30, 2017 at 10:07:27AM +, Matan Azrad wrote: > Since single segment packets shouldn't use additional memory to > save segments byte count we can prevent additional memory > unnecessary usage in this case; Prevent loop management. > Sorry for asking but I really don't understand th

Re: [dpdk-dev] [PATCH v3 4/7] net/mlx4: remove completion counter in Tx burst

2017-10-30 Thread Adrien Mazarguil
On Mon, Oct 30, 2017 at 10:07:26AM +, Matan Azrad wrote: > Remove usage of variable which count the packets for completion and > doesn't add more information than packets counter. > > Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND

Re: [dpdk-dev] [PATCH v3 3/7] net/mlx4: merge Tx path functions

2017-10-30 Thread Adrien Mazarguil
On Mon, Oct 30, 2017 at 10:07:25AM +, Matan Azrad wrote: > Merge tx_burst and mlx4_post_send functions to prevent > double asking about WQ remain space. > > Signed-off-by: Matan Azrad Except for one nit below, Acked-by: Adrien Mazarguil > --- > drivers/net/mlx4/mlx4_rxtx.c | 357 > +

Re: [dpdk-dev] [PATCH v3 2/7] net/mlx4: associate MR to MP in a short function

2017-10-30 Thread Adrien Mazarguil
On Mon, Oct 30, 2017 at 10:07:24AM +, Matan Azrad wrote: > From: Ophir Munk > > Associate memory region to mempool (on data path) > in a short function. > Handle the less common case of adding a new memory > region to mempool in a separate function. > > Signed-off-by: Ophir Munk Thanks for

Re: [dpdk-dev] [PATCH v3 1/7] net/mlx4: remove error flows from Tx fast path

2017-10-30 Thread Adrien Mazarguil
On Mon, Oct 30, 2017 at 10:07:23AM +, Matan Azrad wrote: > Move unnecessary error flows to DEBUG mode. > > Signed-off-by: Matan Azrad > Acked-by: Adrien Mazarguil I missed a couple of details while reviewing the original version, the first one being mlx4_post_send()'s return value is still

Re: [dpdk-dev] [PATCH] doc: update release notes for rte_security

2017-10-30 Thread Thomas Monjalon
30/10/2017 13:27, Akhil Goyal: > Removed the deprication notice for ABI breakage and updated > release notes for rte_security. > > Signed-off-by: Akhil Goyal > --- > +.. _security_library: > + > Security Library > [...] > +* **Added the Security Offload Library.** > + > + Adde

[dpdk-dev] [PATCH v2 1/2] bus/pci: fix vfio mode

2017-10-30 Thread Gaetan Rivet
From: Jerin Jacob Revert back to using VFIO_PRESENT as a marker to enable compilation of VFIO-related segments. Fixes: 279b581c897d ("vfio: expose functions") Signed-off-by: Jerin Jacob Signed-off-by: Gaetan Rivet --- In addition to simply re-defining VFIO_PRESENT, the previous #ifdef remove

[dpdk-dev] [PATCH v2 2/2] eal: warn user that VFIO is disabled

2017-10-30 Thread Gaetan Rivet
If VFIO is not compatible with the kernel used, print a soft warning to the user if RTE_EAL_VFIO was still enabled in the configuration. Signed-off-by: Gaetan Rivet --- lib/librte_eal/linuxapp/eal/eal_vfio.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_vf

[dpdk-dev] [PATCH] net/mlx5: fix counter set destroy order

2017-10-30 Thread Ori Kam
The counter set should be destroyed only after the flow was destroyed. Fixes: 9a761de ("net/mlx5: flow counter support") Cc: or...@mellanox.com Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx

[dpdk-dev] [PATCH] doc: update release notes for rte_security

2017-10-30 Thread Akhil Goyal
Removed the deprication notice for ABI breakage and updated release notes for rte_security. Signed-off-by: Akhil Goyal --- doc/guides/prog_guide/rte_security.rst | 2 ++ doc/guides/rel_notes/deprecation.rst | 10 -- doc/guides/rel_notes/release_17_11.rst | 33 +

Re: [dpdk-dev] [PATCH v2] doc: update mlx5 guide

2017-10-30 Thread Nélio Laranjeiro
On Mon, Oct 30, 2017 at 12:58:25PM +0200, Shahaf Shuler wrote: > Signed-off-by: Shahaf Shuler > --- > doc/guides/nics/mlx5.rst | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst > index cdb880a4c..f82aef

[dpdk-dev] [PATCH] net/mlx4: enhance Rx packet type offloads

2017-10-30 Thread Moti Haimovsky
This patch enhances the Rx packet type offload to also report the L4 protocol information in the hw ptype filled by the PMD for each received packet. Signed-off-by: Moti Haimovsky --- drivers/net/mlx4/mlx4.c | 2 + drivers/net/mlx4/mlx4_prm.h | 16 +++ drivers/net/mlx4/mlx4_rxtx.c | 264

Re: [dpdk-dev] rte_security deprecation

2017-10-30 Thread Akhil Goyal
Hi Thomas, On 10/30/2017 4:36 PM, Thomas Monjalon wrote: Hi, The deprecation notice for rte_security was not removed: http://dpdk.org/commit/be7c7cce25 Please submit a patch to remove it and explain what was really done. The API and ABI changes must be described in the release notes. T

Re: [dpdk-dev] [PATCH] bus/pci: fix vfio mode

2017-10-30 Thread Thomas Monjalon
30/10/2017 10:27, Thomas Monjalon: > 30/10/2017 10:17, Gaëtan Rivet: > > Hi Ferruh, > > > > On Mon, Oct 30, 2017 at 02:00:43AM -0700, Ferruh Yigit wrote: > > > On 10/30/2017 1:06 AM, Gaëtan Rivet wrote: > > > > Hi Jerin, > > > > > > > > On Sat, Oct 28, 2017 at 11:50:52AM +0530, Jerin Jacob wrote:

[dpdk-dev] rte_security deprecation

2017-10-30 Thread Thomas Monjalon
Hi, The deprecation notice for rte_security was not removed: http://dpdk.org/commit/be7c7cce25 Please submit a patch to remove it and explain what was really done. The API and ABI changes must be described in the release notes. Thanks

[dpdk-dev] [PATCH v2] doc: update mlx5 guide

2017-10-30 Thread Shahaf Shuler
Signed-off-by: Shahaf Shuler --- doc/guides/nics/mlx5.rst | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index cdb880a4c..f82aef15c 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -

[dpdk-dev] [PATCH v3 7/7] net/mlx4: remove empty Tx segment support

2017-10-30 Thread Matan Azrad
Move empty segment case processing to debug mode. Signed-off-by: Matan Azrad --- drivers/net/mlx4/mlx4_rxtx.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx4/mlx4_rxtx.c b/drivers/net/mlx4/mlx4_rxtx.c index 482c399..c005a41 100644 --- a/drivers/net/m

[dpdk-dev] [PATCH v3 6/7] net/mlx4: mitigate Tx path memory barriers

2017-10-30 Thread Matan Azrad
Replace most of the memory barriers by compiler barriers since they are all targeted to the DRAM; This improves code efficiency for systems which force store order between different addresses. Only the doorbell record store should be protected by memory barrier since it is targeted to the PCI memo

[dpdk-dev] [PATCH v3 5/7] net/mlx4: separate Tx segment cases

2017-10-30 Thread Matan Azrad
Since single segment packets shouldn't use additional memory to save segments byte count we can prevent additional memory unnecessary usage in this case; Prevent loop management. Call a dedicated function for handling multi segments case. Signed-off-by: Matan Azrad Signed-off-by: Ophir Munk ---

[dpdk-dev] [PATCH v3 4/7] net/mlx4: remove completion counter in Tx burst

2017-10-30 Thread Matan Azrad
Remove usage of variable which count the packets for completion and doesn't add more information than packets counter. Signed-off-by: Matan Azrad --- drivers/net/mlx4/mlx4_rxtx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/mlx4/mlx4_rxtx.c b/drivers/net/mlx

[dpdk-dev] [PATCH v3 3/7] net/mlx4: merge Tx path functions

2017-10-30 Thread Matan Azrad
Merge tx_burst and mlx4_post_send functions to prevent double asking about WQ remain space. Signed-off-by: Matan Azrad --- drivers/net/mlx4/mlx4_rxtx.c | 357 +-- 1 file changed, 172 insertions(+), 185 deletions(-) diff --git a/drivers/net/mlx4/mlx4_rxtx.

[dpdk-dev] [PATCH v3 1/7] net/mlx4: remove error flows from Tx fast path

2017-10-30 Thread Matan Azrad
Move unnecessary error flows to DEBUG mode. Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_rxtx.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/net/mlx4/mlx4_rxtx.c b/drivers/net/mlx4/mlx4_rxtx.c index 67dc712..4f8

[dpdk-dev] [PATCH v3 0/7] Tx path improvements

2017-10-30 Thread Matan Azrad
v1: This series is a follow-up of the new datapath implementation introduced in RC1. It is dedicated to Tx and improves the performance. v2: Change uint32_t be_lkey to rte_be32_t lkey v3: Rebase to 17.11-rc2. Remove "net/mlx4: save lkey in big-endian format" patch which degrade performance. Merg

[dpdk-dev] [PATCH v3 2/7] net/mlx4: associate MR to MP in a short function

2017-10-30 Thread Matan Azrad
From: Ophir Munk Associate memory region to mempool (on data path) in a short function. Handle the less common case of adding a new memory region to mempool in a separate function. Signed-off-by: Ophir Munk --- drivers/net/mlx4/mlx4.h | 2 ++ drivers/net/mlx4/mlx4_mr.c | 46 +++

Re: [dpdk-dev] [PATCH v2 0/6] Remove RTE_ETH_DEV_DETACHABLE

2017-10-30 Thread Alejandro Lucero
Hi guys, i have been on PTO since the 19th of October. I will test this patch asap, but I'm aware this has already been accepted. On Wed, Oct 25, 2017 at 6:37 PM, Ferruh Yigit wrote: > On 10/24/2017 5:35 AM, Thomas Monjalon wrote: > > 24/10/2017 12:35, Gaetan Rivet: > >> Gaetan Rivet (6): > >>

Re: [dpdk-dev] [PATCH] bus/pci: fix vfio mode

2017-10-30 Thread Thomas Monjalon
30/10/2017 10:17, Gaëtan Rivet: > Hi Ferruh, > > On Mon, Oct 30, 2017 at 02:00:43AM -0700, Ferruh Yigit wrote: > > On 10/30/2017 1:06 AM, Gaëtan Rivet wrote: > > > Hi Jerin, > > > > > > On Sat, Oct 28, 2017 at 11:50:52AM +0530, Jerin Jacob wrote: > > >> The definition of VFIO_PRESENT is "eal_vfio

Re: [dpdk-dev] [PATCH] bus/pci: fix vfio mode

2017-10-30 Thread Gaëtan Rivet
Hi Ferruh, On Mon, Oct 30, 2017 at 02:00:43AM -0700, Ferruh Yigit wrote: > On 10/30/2017 1:06 AM, Gaëtan Rivet wrote: > > Hi Jerin, > > > > On Sat, Oct 28, 2017 at 11:50:52AM +0530, Jerin Jacob wrote: > >> The definition of VFIO_PRESENT is "eal_vfio.h", Fail to > >> include eal_vfio.h will result

Re: [dpdk-dev] [PATCH] doc: update mlx5 guide

2017-10-30 Thread Shahaf Shuler
Monday, October 30, 2017 10:22 AM, Nélio Laranjeiro: > On Sun, Oct 29, 2017 at 01:49:42PM +0200, Shahaf Shuler wrote: > > @@ -353,8 +355,10 @@ releases. > > RMDA Core with Linux Kernel > > ^^^ > > > > -- Minimal kernel version : 4.13-rc4 (see `Linux installation > > docume

Re: [dpdk-dev] [PATCH] bus/pci: fix vfio mode

2017-10-30 Thread Jerin Jacob
-Original Message- > Date: Mon, 30 Oct 2017 09:06:54 +0100 > From: Gaëtan Rivet > To: Jerin Jacob > Cc: dev@dpdk.org, tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix vfio mode > User-Agent: Mutt/1.5.23 (2014-03-12) > > Hi Jerin, Hi Gaëtan, > > On Sat, Oct 28, 2017 a

Re: [dpdk-dev] [PATCH] bus/pci: fix vfio mode

2017-10-30 Thread Ferruh Yigit
On 10/30/2017 1:06 AM, Gaëtan Rivet wrote: > Hi Jerin, > > On Sat, Oct 28, 2017 at 11:50:52AM +0530, Jerin Jacob wrote: >> The definition of VFIO_PRESENT is "eal_vfio.h", Fail to >> include eal_vfio.h will result in disabling vfio. >> >> Fixes: 279b581c897d ("vfio: expose functions") >> > > Thank

Re: [dpdk-dev] vfio-pci blocking issue

2017-10-30 Thread Lin, Xueqin
Hi Rivet, Using your patch to include "eal_vfio.h" header file, vfio-pci could work normally on my environment. Thanks. http://dpdk.org/ml/archives/dev/2017-October/080746.html Best regards, Xueqin -Original Message- From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] Sent: Monday, Octob

[dpdk-dev] [PATCH v11 4/4] bus/vdev: change log type

2017-10-30 Thread Jianfeng Tan
Use specialized dynamic log type for vdev bus logging. Suggested-by: Gaetan Rivet Suggested-by: Shreyansh Jain Signed-off-by: Jianfeng Tan --- drivers/bus/vdev/vdev.c | 20 drivers/bus/vdev/vdev_logs.h | 45 2 files changed

[dpdk-dev] [PATCH v11 3/4] bus/vdev: move to vdev bus to drivers/bus

2017-10-30 Thread Jianfeng Tan
Move the vdev bus from lib/librte_eal to drivers/bus. As the crypto vdev helper function refers to data structure in rte_vdev.h, so we move those helper function into drivers/bus too. Signed-off-by: Jianfeng Tan --- config/common_base | 5 + doc/guides/rel_notes/relea

[dpdk-dev] [PATCH v11 2/4] eal: remove dependency on vdev

2017-10-30 Thread Jianfeng Tan
We can call bus->plug() to avoid calling rte_vdev_init() explicitly. Signed-off-by: Jianfeng Tan --- lib/librte_eal/common/eal_common_dev.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/

[dpdk-dev] [PATCH v11 0/4] move vdev into drivers/bus

2017-10-30 Thread Jianfeng Tan
v11: - Rename rte_vdev.h to rte_bus_vdev.h as suggested by Thomas. v10: - Rebase on 17.11-rc2. v9: - Avoid bumping library version (eal, crypto) as other commits in this release already do that as suggested by Pablo. - Move vdev's dir dependency to its own folder as suggested by Gaeta

[dpdk-dev] [PATCH v11 1/4] cryptodev: remove crypto vdev init API

2017-10-30 Thread Jianfeng Tan
Remove rte_cryptodev_create_vdev() for duplication. Signed-off-by: Jianfeng Tan Acked-by: Pablo de Lara --- doc/guides/rel_notes/deprecation.rst | 5 - doc/guides/rel_notes/release_17_11.rst | 2 ++ lib/librte_cryptodev/rte_cryptodev.c | 6 -- lib/librte_c

Re: [dpdk-dev] [PATCH] doc: update mlx5 guide

2017-10-30 Thread Nélio Laranjeiro
On Sun, Oct 29, 2017 at 01:49:42PM +0200, Shahaf Shuler wrote: > Signed-off-by: Shahaf Shuler > --- > doc/guides/nics/mlx5.rst | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst > index cdb880a4c..0aaf8

Re: [dpdk-dev] [PATCH v2 7/7] net/mlx4: separate Tx for multi-segments

2017-10-30 Thread Ophir Munk
Hi, Please see inline. On Wednesday, October 25, 2017 7:50 PM Adrien Mazarguil wrote: > > Hi Ophir, > > On Mon, Oct 23, 2017 at 02:22:00PM +, Ophir Munk wrote: > > This commit optimizes handling of one segment and calls a dedicated > > function for handling multi segments > > > > Signed-off-

Re: [dpdk-dev] vfio-pci blocking issue

2017-10-30 Thread Gaëtan Rivet
Hi Xueqin, Thank you for the thorough test report. Multiple filings for this bug, please refer to the thread http://dpdk.org/ml/archives/dev/2017-October/080746.html Which will focus discussion. A first fix and a new proposition are available, please tell us if it works for you or if there are a

Re: [dpdk-dev] [PATCH] bus/pci: fix vfio mode

2017-10-30 Thread Gaëtan Rivet
Hi Jerin, On Sat, Oct 28, 2017 at 11:50:52AM +0530, Jerin Jacob wrote: > The definition of VFIO_PRESENT is "eal_vfio.h", Fail to > include eal_vfio.h will result in disabling vfio. > > Fixes: 279b581c897d ("vfio: expose functions") > Thanks for the fix, sorry for VFIO. I tried to let go of VFIO

Re: [dpdk-dev] [PATCH] net/mlx5: fix add counter when dev not started

2017-10-30 Thread Nélio Laranjeiro
On Mon, Oct 30, 2017 at 09:32:24AM +0200, Ori Kam wrote: > When adding count action to a drop flow rule while the device was not > stated, the counter was not saved in the flow. > > Fixes: 9a761de8ea14 ("net/mlx5: flow counter support") > Cc: or...@mellanox.com > > Signed-off-by: Ori Kam > --- >

Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix NEON instructions

2017-10-30 Thread Jianbo Liu
The 10/30/2017 13:01, Guduri Prathyusha wrote: > To group consecutive packets with same destination port in bursts of 4 > neon intrinsic data types dp1 and dp2 are calculated such that if > dst_port[]={a,b,c,d,e,f,g,h,i...} dp1 should contain: and > dp2 should contain: in the first iteration. dp1

[dpdk-dev] [PATCH] net/mlx5: fix add counter when dev not started

2017-10-30 Thread Ori Kam
When adding count action to a drop flow rule while the device was not stated, the counter was not saved in the flow. Fixes: 9a761de8ea14 ("net/mlx5: flow counter support") Cc: or...@mellanox.com Signed-off-by: Ori Kam --- drivers/net/mlx5/mlx5_flow.c |4 ++-- 1 files changed, 2 insertions(+

[dpdk-dev] [PATCH v2] examples/l3fwd: fix NEON instructions

2017-10-30 Thread Guduri Prathyusha
To group consecutive packets with same destination port in bursts of 4 neon intrinsic data types dp1 and dp2 are calculated such that if dst_port[]={a,b,c,d,e,f,g,h,i...} dp1 should contain: and dp2 should contain: in the first iteration. dp1 should be and dp2 should be in the next iteration.

Re: [dpdk-dev] vfio-pci blocking issue

2017-10-30 Thread Xu, Qian Q
We have found the blocking issue about vfio-pci in RC2, which blocked many test cases. It is a blocking issue for 17.11 release. Please help check. Add more failed case as below: it will also cause the VF port can't be probed. ? Components version dpdk 17.11 rc2 ? Defect component version (rel

Re: [dpdk-dev] [PATCH] examples/l3fwd: fix NEON instructions

2017-10-30 Thread Guduri Prathyusha
On Mon, Oct 30, 2017 at 02:27:09PM +0800, Jianbo Liu wrote: > The 10/29/2017 13:18, Guduri Prathyusha wrote: > > To group consecutive packets with same destination port in bursts of 4 > > neon intrinsic data types dp1 and dp2 are calculated such that if > > dst_port[]={a,b,c,d,e,f,g,h,i...} dp1 sho

[dpdk-dev] [PATCH] lib/librte_distributor: Fix a couple typos

2017-10-30 Thread Pavel Shirshov
Signed-off-by: Pavel Shirshov --- lib/librte_distributor/rte_distributor.c | 2 +- lib/librte_distributor/rte_distributor_v20.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c index 20b