[dpdk-dev] [PATCH] net/failsafe: fix Rx clean race

2017-10-21 Thread Matan Azrad
In case of plug out, the RMV interrupt callback sets the remove flag of the removed sub-device. The next hotplug alarm cycle should read this flag and if the data path are clean it should remove the sub-device. In case of fail-safe RX burst calling from application, fail-afe tries to call to all S

Re: [dpdk-dev] [PATCH v4 1/3] doc: add platform device

2017-10-21 Thread Thomas Monjalon
21/10/2017 11:41, Jerin Jacob: > > +Platform Device Drivers > > +=== > > IMO, We should not limit to Platform specific drivers. I think, all > platform specific information can go here. For x86 case, may be x86 tuning > guide can be moved here from QSG. +1 It must become a p

[dpdk-dev] [PATCH v3 2/2] net/failsafe: add timestamp to stats snapshot

2017-10-21 Thread Matan Azrad
Fail-safe attempts to read an ultimate statistics on removal time; if that fails, it uses the latest recorded snapshot. This patch adds timestamp for each stats snapshot to allow a time report since the last snapshot in case of the above failure. By this way, the user can estimate the stats read

[dpdk-dev] [PATCH v3 1/2] net/failsafe: improve stats accuracy

2017-10-21 Thread Matan Azrad
The stats_get API was changed to signal a potential failure to read stats. Furthermore, some PMDs are able to provide statistics even after a removal event occurred. Considering this, the fail-safe can try to access the latest statistics of a PMD to improve statistics accuracy. Attempt an ultimat

Re: [dpdk-dev] [PATCH v4 08/12] doc: add details of rte_flow security actions

2017-10-21 Thread Akhil Goyal
On 10/20/2017 4:30 PM, Thomas Monjalon wrote: This patch could be merged with the previous one, adding the action in the rte_flow code. ok.

Re: [dpdk-dev] [PATCH v4 06/12] ethdev: support security APIs

2017-10-21 Thread Akhil Goyal
On 10/20/2017 4:28 PM, Thomas Monjalon wrote: 15/10/2017 00:17, Akhil Goyal: --- a/lib/librte_ether/rte_ethdev_version.map +++ b/lib/librte_ether/rte_ethdev_version.map @@ -194,5 +194,6 @@ DPDK_17.11 { rte_eth_dev_pool_ops_supported; rte_eth_dev_reset; rte_flow_error_s

Re: [dpdk-dev] [PATCH v4 04/12] net: add ESP header to generic flow steering

2017-10-21 Thread Akhil Goyal
On 10/20/2017 3:45 PM, Thomas Monjalon wrote: 15/10/2017 00:17, Akhil Goyal: --- a/doc/api/doxy-api-index.md +++ b/doc/api/doxy-api-index.md @@ -111,7 +111,8 @@ The public API headers are grouped by topics: [LPM IPv6 route] (@ref rte_lpm6.h), [ACL](@ref rte_acl.h),

Re: [dpdk-dev] [PATCH v4 02/12] doc: add details of rte security

2017-10-21 Thread Akhil Goyal
On 10/20/2017 3:11 PM, Thomas Monjalon wrote: 15/10/2017 00:17, Akhil Goyal: --- a/doc/api/doxy-api-index.md +++ b/doc/api/doxy-api-index.md @@ -58,7 +58,8 @@ The public API headers are grouped by topics: [ixgbe] (@ref rte_pmd_ixgbe.h), [i40e] (@ref rte_pmd_i40

Re: [dpdk-dev] [PATCH v4 01/12] lib/rte_security: add security library

2017-10-21 Thread Akhil Goyal
On 10/20/2017 3:09 PM, Thomas Monjalon wrote: 20/10/2017 11:37, Thomas Monjalon: 15/10/2017 00:17, Akhil Goyal: lib/librte_security/Makefile | 53 +++ lib/librte_security/rte_security.c | 149 lib/librte_security/rte_security.h | 535 +++

Re: [dpdk-dev] [PATCH v4 01/12] lib/rte_security: add security library

2017-10-21 Thread Akhil Goyal
On 10/20/2017 3:07 PM, Thomas Monjalon wrote: 15/10/2017 00:17, Akhil Goyal: lib/librte_security/Makefile | 53 +++ lib/librte_security/rte_security.c | 149 lib/librte_security/rte_security.h | 535 +++ lib/librte_securi

Re: [dpdk-dev] [PATCH v4 09/12] mk: add rte security into build system

2017-10-21 Thread Akhil Goyal
Hi Thomas, On 10/20/2017 4:36 PM, Thomas Monjalon wrote: Why not merging this patch with the first one? There are some code changes in ethdev and cryptodev(subsequent patches) which are used in the first patch. This would break compilation. So compilation of the lib is done in the last to avoi

Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event queue config

2017-10-21 Thread Jerin Jacob
-Original Message- > Date: Sat, 21 Oct 2017 00:39:28 +0530 > From: Pavan Nikhilesh Bhagavatula > To: "Van Haaren, Harry" > CC: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event > queue config > User-Agent: Mutt/1.5.24 (2015-08-30) > > On Fri, Oct 20,

Re: [dpdk-dev] [PATCH 01/11] examples/ipsec-secgw: updated MAINTAINERS file

2017-10-21 Thread Akhil Goyal
On 10/17/2017 6:47 PM, De Lara Guarch, Pablo wrote: -Original Message- From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] Sent: Tuesday, October 17, 2017 1:37 PM To: De Lara Guarch, Pablo ; Aviad Yehezkel ; Gonzalez Monroy, Sergio ; dev@dpdk.org; avia...@mellanox.com Cc: bor...@mella

Re: [dpdk-dev] [PATCH v2 6/7] eventdev: remove eventdev schedule API

2017-10-21 Thread Jerin Jacob
-Original Message- > Date: Fri, 13 Oct 2017 22:06:49 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > harry.van.haa...@intel.com > Cc: dev@dpdk.org, Pavan Bhagavatula > Subject: [dpdk-dev] [PATCH v2 6/7] eventdev: remove eventdev schedule API

Re: [dpdk-dev] [PATCH v2 3/7] app/test-eventdev: update app to use service cores

2017-10-21 Thread Jerin Jacob
-Original Message- > Date: Fri, 13 Oct 2017 22:06:46 +0530 > From: Pavan Nikhilesh > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > harry.van.haa...@intel.com > Cc: dev@dpdk.org, Pavan Bhagavatula > Subject: [dpdk-dev] [PATCH v2 3/7] app/test-eventdev: update app to use >

Re: [dpdk-dev] [PATCH v4 00/12] introduce security offload library

2017-10-21 Thread Akhil Goyal
Hi Thomas, On 10/20/2017 3:02 PM, Thomas Monjalon wrote: 16/10/2017 12:44, Thomas Monjalon: 15/10/2017 00:17, Akhil Goyal: This patchset introduce the rte_security library in DPDK. This also includes the sample implementation of drivers and changes in ipsec gateway application to demonstrate it

Re: [dpdk-dev] [RFC PATCH 0/2] using scapy to generate packet templates

2017-10-21 Thread Xueming(Steven) Li
Beside generating packets, there are more things can be done here with scapy/python, might be useful for developing: 1. generate limited packet and send: tx {pattern} {port} {count} 2. parse and dump packet from binary to Scapy format. rx {pattern} {port} 3. loopback send and rec

Re: [dpdk-dev] [PATCH v4 06/12] ethdev: support security APIs

2017-10-21 Thread Akhil Goyal
Hi Konstantin, On 10/19/2017 2:53 PM, Ananyev, Konstantin wrote: Hi guys, -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Saturday, October 14, 2017 11:17 PM To: dev@dpdk.org Cc: Doherty, Declan ; De Lara Guarch, Pablo ; hemant.agra...@nxp.com; Nicolau, Radu ;

Re: [dpdk-dev] [PATCH] doc: add event eth Rx adapter library

2017-10-21 Thread Jerin Jacob
-Original Message- > Date: Wed, 18 Oct 2017 14:51:41 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org > Subject: [PATCH] doc: add event eth Rx adapter library > X-Mailer: git-send-email 2.7.4 > > Signed-off-by: Nikhil Rao > --- > doc/guides/rel_notes/rele

Re: [dpdk-dev] [PATCH v2] doc: add event eth Rx adapter programmer's guide

2017-10-21 Thread Jerin Jacob
-Original Message- > Date: Wed, 18 Oct 2017 15:28:10 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org > Subject: [PATCH v2] doc: add event eth Rx adapter programmer's guide > X-Mailer: git-send-email 2.7.4 > > Add programmer's guide doc to explain the use o

Re: [dpdk-dev] [PATCH v4 01/12] lib/rte_security: add security library

2017-10-21 Thread Akhil Goyal
On 10/19/2017 3:00 PM, Ananyev, Konstantin wrote: + +/** + * Security context for crypto/eth devices + * + * Security instance for each driver to register security operations. + * The application can get the security context from the crypto/eth device id + * using the APIs rte_cryptodev_get_se

Re: [dpdk-dev] [PATCH v3 03/12] cryptodev: support security APIs

2017-10-21 Thread Akhil Goyal
Hi Pablo, On 10/10/2017 7:13 PM, De Lara Guarch, Pablo wrote: -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Friday, October 6, 2017 7:12 PM To: dev@dpdk.org Cc: Doherty, Declan ; De Lara Guarch, Pablo ; hemant.agra...@nxp.com; Nicolau, Radu ; bor...@mellanox.c

Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event queue config

2017-10-21 Thread Jerin Jacob
-Original Message- > Date: Fri, 20 Oct 2017 16:38:57 + > From: "Van Haaren, Harry" > To: Pavan Nikhilesh Bhagavatula > CC: "dev@dpdk.org" > Subject: Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event > queue config > > > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagav

Re: [dpdk-dev] [PATCH v8 1/4] librte_flow_classify: add flow classify library

2017-10-21 Thread Iremonger, Bernard
Hi Jasvinder > > > > > + > > > +struct acl_keys { > > > + struct rte_table_acl_rule_add_params key_add; /**< add key */ > > > + struct rte_table_acl_rule_delete_params key_del; /**< delete > > > key */ > > > +}; > > > + > > > +struct rte_flow_classify_rule { > > > + uint32_t id; /**< unique ID o

Re: [dpdk-dev] [PATCH v4 3/5] drivers: add net as dependency for event drivers

2017-10-21 Thread Jerin Jacob
-Original Message- > Date: Tue, 17 Oct 2017 22:08:32 +0530 > From: Nipun Gupta > To: dev@dpdk.org > CC: hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com, > nikhil@intel.com, Nipun Gupta > Subject: [PATCH v4 3/5] drivers: add net as dependency for event drivers > X-Mailer: git-s

Re: [dpdk-dev] [PATCH v1 1/2] mempool/octeontx: move mbox from event to mempool

2017-10-21 Thread Jerin Jacob
-Original Message- > Date: Tue, 17 Oct 2017 15:19:26 +0530 > From: Hemant Agrawal > To: Santosh Shukla , dev@dpdk.org > CC: olivier.m...@6wind.com, tho...@monjalon.net, > jerin.ja...@caviumnetworks.com > Subject: Re: [PATCH v1 1/2] mempool/octeontx: move mbox from event to > mempool > Us

Re: [dpdk-dev] [PATCH v1] mempool/octeontx: remove dead code from gpool2handle

2017-10-21 Thread Jerin Jacob
-Original Message- > Date: Fri, 20 Oct 2017 15:39:58 + > From: Santosh Shukla > To: dev@dpdk.org > Cc: tho...@monjalon.net, jerin.ja...@caviumnetworks.com, Santosh Shukla > > Subject: [PATCH v1] mempool/octeontx: remove dead code from gpool2handle > X-Mailer: git-send-email 2.13.0 >

Re: [dpdk-dev] [PATCH v4 3/3] doc: use correct mempool ops handle name

2017-10-21 Thread Jerin Jacob
-Original Message- > Date: Fri, 20 Oct 2017 20:51:24 +0530 > From: Santosh Shukla > To: dev@dpdk.org > Cc: tho...@monjalon.net, jerin.ja...@caviumnetworks.com, > john.mcnam...@intel.com, Santosh Shukla > > Subject: [PATCH v4 3/3] doc: use correct mempool ops handle name > X-Mailer: git-

Re: [dpdk-dev] [PATCH v4 1/3] doc: add platform device

2017-10-21 Thread Jerin Jacob
-Original Message- > Date: Fri, 20 Oct 2017 20:51:22 +0530 > From: Santosh Shukla > To: dev@dpdk.org > Cc: tho...@monjalon.net, jerin.ja...@caviumnetworks.com, > john.mcnam...@intel.com, Santosh Shukla > > Subject: [PATCH v4 1/3] doc: add platform device > X-Mailer: git-send-email 2.14.

Re: [dpdk-dev] [PATCH] doc: add basic howto for flow API

2017-10-21 Thread Ori Kam
Hi John, Thanks for your comments and time. Please see my comments inline. > -Original Message- > From: Mcnamara, John [mailto:john.mcnam...@intel.com] > Sent: Thursday, October 19, 2017 1:06 PM > To: Ori Kam ; Adrien Mazarguil > > Cc: dev@dpdk.org > Subject: RE: [PATCH] doc: add basic

Re: [dpdk-dev] [PATCH 2/2] doc: add flow_filtering example documentation

2017-10-21 Thread Ori Kam
Hi John, > -Original Message- > From: Mcnamara, John [mailto:john.mcnam...@intel.com] > Sent: Friday, October 20, 2017 7:33 PM > To: Ori Kam ; Adrien Mazarguil > ; Thomas Monjalon > > Cc: dev@dpdk.org > Subject: RE: [PATCH 2/2] doc: add flow_filtering example documentation > > > > > --