[dpdk-dev] TSO with Vmxnet3 driver

2017-10-19 Thread Manam Rajasekhar
Hello Experts, I am using VMXNET3 driver for one of the application i am developing, i was trying to enable TSO on vmxnet3 driver to send traffic out of the application. LRO enabled on ingress interface. On the TX interface (another vmxnet3) connected to different VDS, i enabled TSO offload. It

Re: [dpdk-dev] [PATCH v2 4/6] examples/ipsec-secgw: add correct padding to tunnel mode

2017-10-19 Thread Sergio Gonzalez Monroy
Hi Aviad, I think you missed my question on v1 for this patch. Could you provide an example where the pad calculation with the current code is wrong? Thanks, Sergio On 19/10/2017 19:53, avia...@dev.mellanox.co.il wrote: From: Aviad Yehezkel Issue: None Signed-off-by: Aviad Yehezkel -- v2

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-19 Thread Jerin Jacob
-Original Message- > Date: Fri, 20 Oct 2017 09:57:58 +0800 > From: Jia He > To: "Ananyev, Konstantin" , "Zhao, Bing" > , Jerin Jacob > Cc: Olivier MATZ , "dev@dpdk.org" , > "jia...@hxt-semitech.com" , > "jie2@hxt-semitech.com" , > "bing.z...@hxt-semitech.com" , "Richardson, > Bru

Re: [dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behavior of device stop/start

2017-10-19 Thread Yuanhan Liu
On Fri, Oct 20, 2017 at 10:09:28AM +0800, Tiwei Bie wrote: > After starting a device, the driver shouldn't deliver the > packets that already existed before the device is started > to applications. Otherwise it will lead to incorrect packet > collection for port state. This patch fixes this issue b

[dpdk-dev] [PATCH] net/i40e: fix flow director issue

2017-10-19 Thread Beilei Xing
For L3 or L4 packets, PCtype is parsed wrongly when input set is VLAN only. This patch fixes the issue. Fixes: 15018d79f0be ("net/i40e: add FDIR support for GTP-C and GTP-U") Fixes: 7d83c152a207 ("net/i40e: parse flow director filter") Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_flow.c

[dpdk-dev] [PATCH v2] net/e1000: always enable receive and transmit

2017-10-19 Thread Chas Williams
From: Chas Williams The transmit and receive controller state machines are only enabled after receiving an interrupt and the link status is now valid. If an adapter is being used in conjunction with NC-SI, network controller sideband interface, the adapter may never get a link state change inter

[dpdk-dev] [PATCH] net/i40e: update parsing inner packet info

2017-10-19 Thread Beilei Xing
Since meta data in profile is updated, parsing inner packet information needs to be updated, too. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/

[dpdk-dev] [PATCH] net/i40e: fix string overflow issue

2017-10-19 Thread Beilei Xing
This patch fixes the coverity STRING_OVERFLOW issue. Coverity issue: 195002 Fixes: e163c18a15b0 ("net/i40e: update ptype and pctype info") Reported-by: John McNamara Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH v2] net/virtio: fix an incorrect behavior of device stop/start

2017-10-19 Thread Tiwei Bie
After starting a device, the driver shouldn't deliver the packets that already existed before the device is started to applications. Otherwise it will lead to incorrect packet collection for port state. This patch fixes this issue by flushing the Rx queues when starting the device. Fixes: a85786dc

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-19 Thread Jia He
On 10/20/2017 4:02 AM, Ananyev, Konstantin Wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin Sent: Thursday, October 19, 2017 3:15 PM To: Zhao, Bing ; Jia He ; Jerin Jacob Cc: Olivier MATZ ; dev@dpdk.org; jia...@hxt-semitech.com; jie

[dpdk-dev] Requirement of minimum Rx burst size for PMDs

2017-10-19 Thread Yongseok Koh
Hi, In some rx_burst functions, especially for vectorized ones (e.g. i40e_rxtx_vec* or mlx5_rxtx_vec*), there's actually a requirement of min burst size. As it manipulates 4 packets simultaneously in a loop, if nb_pkts of rte_eth_rx_burst() is less than 4, it just returns without sending a packet

Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations

2017-10-19 Thread Ferruh Yigit
On 10/19/2017 3:43 PM, Patil, Harish wrote: > -Original Message- > From: Harish Patil > Date: Tuesday, October 17, 2017 at 9:50 PM > To: Thomas Monjalon , Ferruh Yigit > > Cc: "dev@dpdk.org" , Jianfeng Tan , > Jingjing Wu , "Thotton, Shijith" > , Gregory Etelson , George > Prekas , "sta..

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Li, Xiaoyun
> -Original Message- > From: Richardson, Bruce > Sent: Thursday, October 19, 2017 17:30 > To: Thomas Monjalon > Cc: Li, Xiaoyun ; Ananyev, Konstantin > ; dev@dpdk.org; Lu, Wenzhuo > ; Zhang, Helin ; > ophi...@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatc

[dpdk-dev] [PATCH 3/3] ethdev: fix negative return values in xstats

2017-10-19 Thread Ferruh Yigit
Some function calls in xstat functions can return negative values to indicate the error, check return values for those cases. Coverity issue: 195028, 195026 Fixes: 8c49d5f1c219 ("ethdev: rework xstats retrieve by id") Signed-off-by: Ferruh Yigit --- Cc: Lee Daly --- lib/librte_ether/rte_ethdev

[dpdk-dev] [PATCH 2/3] ethdev: fix xstats get by id APIS

2017-10-19 Thread Ferruh Yigit
ethdev xstat get by id APIs: rte_eth_xstats_get_names_by_id() rte_eth_xstats_get_by_id() Works on ids calculated as "basic stats + device specific stats" When an application asking for id less than "basic stats count", it is indeed asking basic stats nothing specific to device stats. The dev_ops

[dpdk-dev] [PATCH 1/3] ethdev: extract xstat basic stat count calculation

2017-10-19 Thread Ferruh Yigit
Extract into static inline function so that can be used by other functions. Signed-off-by: Ferruh Yigit --- lib/librte_ether/rte_ethdev.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c in

Re: [dpdk-dev] [PATCH] igb_uio: revert open and release operations

2017-10-19 Thread Patil, Harish
-Original Message- From: Harish Patil Date: Tuesday, October 17, 2017 at 9:50 PM To: Thomas Monjalon , Ferruh Yigit Cc: "dev@dpdk.org" , Jianfeng Tan , Jingjing Wu , "Thotton, Shijith" , Gregory Etelson , George Prekas , "sta...@dpdk.org" Subject: Re: [PATCH] igb_uio: revert open and rel

[dpdk-dev] [PATCH v3] net/failsafe: fix PCI devices init

2017-10-19 Thread Raslan Darawsheh
When trying to attach a port as a sub-device, the ethdev port was compared with devargs. In the case of a PCI device, the name in devargs is the PCI address. And since DPDK 17.08, the devargs name of the underlying device was used to match an ethdev port: a1e7c17555e8 ("ethdev: use device n

[dpdk-dev] [PATCH v2] net/failsafe: fix PCI devices init

2017-10-19 Thread Raslan Darawsheh
When trying to attach a port as a sub-device, the ethdev port was compared with devargs. In the case of a PCI device, the name in devargs is the PCI address. And since DPDK 17.08, the devargs name of the underlying device was used to match an ethdev port: a1e7c17555e8 ("ethdev: use device n

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-19 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Thursday, October 19, 2017 3:15 PM > To: Zhao, Bing ; Jia He ; Jerin Jacob > > Cc: Olivier MATZ ; dev@dpdk.org; > jia...@hxt-semitech.com; jie2@hxt-semitech.com; bing.zhao@hxt- >

Re: [dpdk-dev] [PATCH 0/6] net/mlx5: fixes

2017-10-19 Thread Yongseok Koh
> On Oct 19, 2017, at 5:51 AM, Nelio Laranjeiro > wrote: > > Some fixes on bugs and wrong behaviors. > > This series applies on top of: > https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdpdk.org%2Fpatch%2F30351&data=02%7C01%7Cyskoh%40mellanox.com%7C2a536ed7e66541c8c0d308d516f

Re: [dpdk-dev] Can xenvirt pmd work in xen guest (aka DomU) without xen-vhost in Dom0 ?

2017-10-19 Thread Konrad Rzeszutek Wilk
On Mon, Oct 09, 2017 at 12:13:47AM +0800, Tan, Jianfeng wrote: > Hi, > > > On 10/8/2017 12:54 PM, Bill Bonaparte wrote: > > Thanks Jianfeng for taking time to reply. > > > > please allow me to briefly explain why I want to run dpdk on xen. > > our system is based on dpdk, which means we use dpdk

Re: [dpdk-dev] [PATCH] crypto/mrvl: update copyright holders

2017-10-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > Sent: Wednesday, October 18, 2017 9:59 AM > To: dev@dpdk.org > Cc: m...@semihalf.com; Tomasz Duszynski > Subject: [dpdk-dev] [PATCH] crypto/mrvl: update copyright holders > > Add Marvell Inter

Re: [dpdk-dev] [PATCH v2 1/1] cryptodev: fix build with Ofast.

2017-10-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: Stokes, Ian > Sent: Tuesday, October 17, 2017 4:17 PM > To: De Lara Guarch, Pablo ; > dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v2 1/1] cryptodev: fix build with Ofast. > > > > -Original Message- > > > From: Stokes, Ian > > > Sent: Tues

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: set ip6_plen to the proper value

2017-10-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Wednesday, October 18, 2017 5:18 PM > To: Tomasz Duszynski ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: set ip6_plen to the > proper value > > On 13/10/2

Re: [dpdk-dev] [PATCH v2] examples/l2fwd-crypto: fix port id type

2017-10-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang > Sent: Thursday, October 19, 2017 3:57 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; De Lara Guarch, Pablo > ; Yang, Zhiyong > > Subject: [dpdk-dev] [PATCH v2] examples/l2fwd-crypto: fix port id type

[dpdk-dev] [PATCH v2 6/6] examples/ipsec-secgw: config ethernet MACs dynamically

2017-10-19 Thread aviadye
From: Aviad Yehezkel Issue: None Signed-off-by: Aviad Yehezkel -- v2: * Fix commit message --- examples/ipsec-secgw/Makefile | 1 + examples/ipsec-secgw/ep0.cfg | 6 + examples/ipsec-secgw/ep1.cfg | 6 + examples/ipsec-secgw/eth.c | 238 +++

[dpdk-dev] [PATCH] app/testpmd: compile even if ixgbe anf bnxt pmds are not compiling

2017-10-19 Thread aviadye
From: Aviad Yehezkel Signed-off-by: Aviad Yehezkel Signed-off-by: Nicolai Radu --- app/test-pmd/cmdline.c | 13 ++--- app/test-pmd/config.c | 12 +++- 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index bb01e98.

[dpdk-dev] [PATCH v2 5/6] examples/ipsec-secgw: iv should be be64

2017-10-19 Thread aviadye
From: Aviad Yehezkel According to rfc4106 the IV should be unique and can be implemented as counter. The changed was created because putting an analyzer on wire and comparing packets generated by this application and Linux kernel. Linux kernel sets IV as BE, so it is worth to do the same for futu

[dpdk-dev] [PATCH v2 3/6] examples/ipsec-secgw: fix aad_len for for aes-gcm

2017-10-19 Thread aviadye
From: Aviad Yehezkel This cause auth failure issue Fixes: 501e9c226adf ("examples/ipsec-secgw: add AEAD parameters") Cc: pablo.de.lara.gua...@intel.com Issue: None Signed-off-by: Aviad Yehezkel -- v2: * Fix commit message --- examples/ipsec-secgw/sa.c | 2 +- 1 file changed, 1 insertion(+), 1

[dpdk-dev] [PATCH v2 2/6] examples/ipsec-secgw: fix create session also for aead

2017-10-19 Thread aviadye
From: Aviad Yehezkel Search for session also with aead key Issue: None Signed-off-by: Aviad Yehezkel -- v2: * Fix commit message. * Addressed feedback. --- examples/ipsec-secgw/ipsec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/examples/ipsec-secgw/ipsec.c b/ex

[dpdk-dev] [PATCH v2 1/6] examples/ipsec-secgw: fix initialization of aead crypto devices

2017-10-19 Thread aviadye
From: Aviad Yehezkel Fixes: 501e9c226adf ("examples/ipsec-secgw: add AEAD parameters") Cc: pablo.de.lara.gua...@intel.com Issue: None Signed-off-by: Aviad Yehezkel -- v2: * Fix commit message. * Address feedbacks. --- examples/ipsec-secgw/ipsec-secgw.c | 13 +++-- examples/ipsec-secgw/

[dpdk-dev] [PATCH v2 4/6] examples/ipsec-secgw: add correct padding to tunnel mode

2017-10-19 Thread aviadye
From: Aviad Yehezkel Issue: None Signed-off-by: Aviad Yehezkel -- v2: * Fix commit message --- examples/ipsec-secgw/esp.c | 51 ++ 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/examples/ipsec-secgw/esp.c b/examples/ipsec-secgw/esp.c

Re: [dpdk-dev] [PATCH 09/11] examples/ipsec-secgw: Fixed ip length in case of transport

2017-10-19 Thread Aviad Yehezkel
Solved that issue, this was an issue with mlx5 PMD with the new inline ipsec code. The PMD wasn't updating mbuf->data_len correctly. Thanks! On 10/16/2017 3:03 PM, Sergio Gonzalez Monroy wrote: On 16/10/2017 12:44, Aviad Yehezkel wrote: On 10/16/2017 12:43 PM, Sergio Gonzalez Monroy wrote:

Re: [dpdk-dev] [PATCH 05/11] examples/ipsec-secgw: Fixed transport

2017-10-19 Thread Aviad Yehezkel
Yes, just finished my testing. Will send v2 in a moment and Akhil will send v5 rebased above them for rte_security. Thanks! On 10/19/2017 9:16 PM, De Lara Guarch, Pablo wrote: -Original Message- From: Aviad Yehezkel [mailto:avia...@dev.mellanox.co.il] Sent: Monday, October 16, 201

Re: [dpdk-dev] [PATCH 05/11] examples/ipsec-secgw: Fixed transport

2017-10-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: Aviad Yehezkel [mailto:avia...@dev.mellanox.co.il] > Sent: Monday, October 16, 2017 11:42 AM > To: Gonzalez Monroy, Sergio ; > dev@dpdk.org; De Lara Guarch, Pablo ; > avia...@mellanox.com > Cc: bor...@mellanox.com; akhil.go...@nxp.com; > hemant.agra...@nxp.com

Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API

2017-10-19 Thread Ferruh Yigit
On 10/19/2017 8:03 AM, Ivan Malov wrote: > On Thu, Oct 19, 2017 at 11:06:37AM +, Van Haaren, Harry wrote: >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >>> Sent: Wednesday, October 18, 2017 10:49 PM >>> To: Ivan Malov ; Daly, Lee ; >>> tho...@monjalon.net >>> Cc: dev@dpd

Re: [dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files

2017-10-19 Thread Bruce Richardson
On Thu, Oct 19, 2017 at 05:36:24PM +0100, Bruce Richardson wrote: > Both Linux and BSD EALs should provide exactly the same set of functions > to the user, even if in some cases the function is a stub returning > ENOTSUP. Because of this we should only need a single version.map file for > all of EA

[dpdk-dev] [PATCH 5/5] eal: use a single version map file

2017-10-19 Thread Bruce Richardson
Since the functions exported by DPDK EAL on all OS's should be identical, we should not need separate function version files for each OS. Therefore move existing version files to the top-level EAL directory. Signed-off-by: Bruce Richardson --- lib/librte_eal/bsdapp/eal/Makefile |

[dpdk-dev] [PATCH 1/5] eal/bsdapp: align interrupt include file with Linux version

2017-10-19 Thread Bruce Richardson
The bsdapp-specific rte_interrupts.h file does not need to be different from the linuxapp one, as there is nothing Linux specific in the APIs or data structures. This will then allow us to merge the files in a common location to avoid duplication. Signed-off-by: Bruce Richardson --- .../bsdapp/e

[dpdk-dev] [PATCH 4/5] eal: mark internal interrupts file as such to doxygen

2017-10-19 Thread Bruce Richardson
Put a file-level comment on rte_eal_interrupts.h to mark it as an internal only header. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/include/rte_eal_interrupts.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_eal/common/include/rte_eal_interrupts.h b/lib/lib

[dpdk-dev] [PATCH 3/5] eal: merge bsdapp and linuxapp interrupt headers

2017-10-19 Thread Bruce Richardson
The linuxapp and bsdapp interrupt header files are now identical, so merge them into a common file in common/include. Signed-off-by: Bruce Richardson --- lib/librte_eal/bsdapp/eal/Makefile | 2 +- lib/librte_eal/common/Makefile | 3 +- .../include/rte_eal_

[dpdk-dev] [PATCH 2/5] eal/bsdapp: fix missing interrupt stub functions

2017-10-19 Thread Bruce Richardson
A number of interrupt functions only existed on Linux. Adding in stubs for these functions corrects this omission, and allows the map files for both Linux and FreeBSD to be identical. CC: sta...@dpdk.org Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") Signed-off-by: Bruce Richardson --- l

[dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files

2017-10-19 Thread Bruce Richardson
Both Linux and BSD EALs should provide exactly the same set of functions to the user, even if in some cases the function is a stub returning ENOTSUP. Because of this we should only need a single version.map file for all of EAL - not one each for Linux and FreeBSD. Unfortunately, there was some inc

Re: [dpdk-dev] DPDK 1705 on libpcap drivers has drops?

2017-10-19 Thread Ferruh Yigit
On 10/19/2017 1:03 AM, Kuusisaari, Juhamatti wrote: > > Hi, > >> We are testing on 1705 over libpcap driver and unfortunately we are seeing >> surprisingly large drops. They are seen with low rate/ping randomly and with >> high rate the throughput is very limited (even 30 % drops seen) compared t

Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API

2017-10-19 Thread Ivan Malov
On 10/12/2017 2:31 PM, Lee Daly wrote: > From: Lee > > Fix xstats functions, rte_eth_xstats_get_names_by_id() > and rte_eth_xstats_get_by_id(), in current implementation > ethdev level reads all xstat values and filters out > the ones requested by the application. This behavior doesn't > benefit f

Re: [dpdk-dev] [PATCH v3] examples/ipsec_secgw: support jumbo frames

2017-10-19 Thread Aviad Yehezkel
On 10/19/2017 6:58 PM, Radu Nicolau wrote: Added cmdline option for jumbo frames. Switched port initialization to the new offload API. Signed-off-by: Radu Nicolau --- v2: updated commit message v3: addressed feedback doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +- examples/ipsec-sec

Re: [dpdk-dev] [PATCH 2/2] ethdev: pre-emptively document rte_eth_dev_reset error code

2017-10-19 Thread Luca Boccassi
On Thu, 2017-10-19 at 15:53 +0100, Remy Horton wrote: > On 19/10/2017 14:48, luca.bocca...@gmail.com wrote: > > Document it immediately even if it's not yet supported, so that > > users > > and developers can already take into account about this use case, > > and > > thus avoid an API-incompatible

[dpdk-dev] [PATCH v1 3/4] net/mlx4: fix indirection table error rollback

2017-10-19 Thread Adrien Mazarguil
In case of error occurring while setting up indirection table and related RSS context resources, intermediate objects are not cleaned up. Moreover although unlikely, an error other than EINVAL (e.g. ENOMEM) may be returned. A description of mlx4_rss_attach()'s return value is also missing. Fixes

[dpdk-dev] [PATCH v1 4/4] net/mlx4: relax Rx queue configuration order

2017-10-19 Thread Adrien Mazarguil
Various hardware limitations apply to RSS indirection tables, one of them being they must be an exact 1:1 mapping of the configured Rx queue indices. While this restriction is enforced when creating RSS flow rules, it is not the case when Rx queues themselves are created; underlying WQ numbers are

[dpdk-dev] [PATCH v1 2/4] net/mlx4: fix useless flow rules synchronization

2017-10-19 Thread Adrien Mazarguil
According to the original commit, Rx queues cannot be created nor destroyed while the device is started. Synchronizing flow rules during such events is unnecessary as it occurs later when starting the device. Fixes: 79770826499b ("net/mlx4: drop live queue reconfiguration support") Signed-off-by:

[dpdk-dev] [PATCH v1 0/4] net/mlx4: RSS fixes

2017-10-19 Thread Adrien Mazarguil
This series enforces WQ creation order to make sure WQNs are assigned sequentially to Rx queues and fixes a few minor issues related to initialization code. This addresses l3fwd-power startup issues. Adrien Mazarguil (4): net/mlx4: use dedicated list iterator net/mlx4: fix useless flow rules

[dpdk-dev] [PATCH v1 1/4] net/mlx4: use dedicated list iterator

2017-10-19 Thread Adrien Mazarguil
Dumb unconditional iteration on flow rules should be performed using the dedicated macro. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/mlx4_flow.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net

[dpdk-dev] [PATCH v3] examples/ipsec_secgw: support jumbo frames

2017-10-19 Thread Radu Nicolau
Added cmdline option for jumbo frames. Switched port initialization to the new offload API. Signed-off-by: Radu Nicolau --- v2: updated commit message v3: addressed feedback doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 35 +

Re: [dpdk-dev] [PATCH v2] examples/ipsec_secgw: support jumbo frames

2017-10-19 Thread Nicolau, Radu
Hi, I did, sorry :) Working on them now. > -Original Message- > From: De Lara Guarch, Pablo > Sent: Thursday, October 19, 2017 4:40 PM > To: Nicolau, Radu ; dev@dpdk.org > Cc: Gonzalez Monroy, Sergio > Subject: RE: [PATCH v2] examples/ipsec_secgw: support jumbo frames > > Hi Radu, > > >

Re: [dpdk-dev] [PATCH v2] examples/ipsec_secgw: support jumbo frames

2017-10-19 Thread De Lara Guarch, Pablo
Hi Radu, > -Original Message- > From: Nicolau, Radu > Sent: Thursday, October 19, 2017 4:26 PM > To: dev@dpdk.org > Cc: Gonzalez Monroy, Sergio ; De Lara > Guarch, Pablo ; Nicolau, Radu > > Subject: [PATCH v2] examples/ipsec_secgw: support jumbo frames > > Added cmdline option for jumbo

[dpdk-dev] [PATCH v2] examples/ipsec_secgw: support jumbo frames

2017-10-19 Thread Radu Nicolau
Added cmdline option for jumbo frames. Switched port initialization to the new offload API. Signed-off-by: Radu Nicolau --- v2: updated commit message doc/guides/sample_app_ug/ipsec_secgw.rst | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 32 +--- 2 files ch

Re: [dpdk-dev] [RFC PATCH 0/2] using scapy to generate packet templates

2017-10-19 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xueming Li > Sent: Thursday, October 19, 2017 3:07 PM > To: Wu, Jingjing > Cc: Xueming Li ; dev@dpdk.org > Subject: [dpdk-dev] [RFC PATCH 0/2] using scapy to generate packet templates Hi, First off - cool to make DPDK more dynamic with Scapy

Re: [dpdk-dev] [PATCH v2] net/failsafe: improve stats accuracy

2017-10-19 Thread Gaëtan Rivet
Hello Matan, Adding the time delta should have been done in a separate commit. Can you please divide this patch in two? The first one will only attempt the ultimate stat read, the second one would add the delay warning. Small nit below for your v3. On Thu, Oct 19, 2017 at 02:31:54PM +, Mata

Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API

2017-10-19 Thread Ivan Malov
On Thu, Oct 19, 2017 at 11:06:37AM +, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > > Sent: Wednesday, October 18, 2017 10:49 PM > > To: Ivan Malov ; Daly, Lee ; > > tho...@monjalon.net > > Cc: dev@dpdk.org; Kozak, KubaX > > Subject: Re: [dpdk

Re: [dpdk-dev] [PATCH 2/2] ethdev: pre-emptively document rte_eth_dev_reset error code

2017-10-19 Thread Remy Horton
On 19/10/2017 14:48, luca.bocca...@gmail.com wrote: Document it immediately even if it's not yet supported, so that users and developers can already take into account about this use case, and thus avoid an API-incompatible change later on. I'm not sure about documenting unimplemented features,

Re: [dpdk-dev] [PATCH 1/2] ethdev: document rte_eth_dev_reset return codes

2017-10-19 Thread Remy Horton
On 19/10/2017 14:48, luca.bocca...@gmail.com wrote: From: Luca Boccassi This new function returns 0 on success and various error codes on different failures. Attempt to document them. Signed-off-by: Luca Boccassi --- lib/librte_ether/rte_ethdev.h | 8 1 file changed, 8 insertions(+

Re: [dpdk-dev] Does cxgbe support multiple processes mode

2017-10-19 Thread Rahul Lakkireddy
On Tuesday, October 10/17/17, 2017 at 23:26:19 -0700, He JianJun wrote: > Does cxgbe support multiple processes mode? If not, how can we implement it? > > I tried with 17.08 code, secondary process will crash at sge.c line 1098. > t4_eth_xmit() > because txq->eth_dev->data is NULL. > > I am guess

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> > > > > > >>> > > > >>> + > > > >>> +static int > > > >>> +ixgbe_crypto_update_mb(void *device __rte_unused, > > > >>> + struct rte_security_session *session, > > > >>> +struct rte_mbuf *m, void *params __rte_unused) > > { > > > > > > > > > >

Re: [dpdk-dev] [PATCH branch-16.11] net/i40e: return errno when interrupt setup fails

2017-10-19 Thread Aaron Conole
Yuanhan Liu writes: > On Thu, Oct 19, 2017 at 09:22:30AM -0400, Aaron Conole wrote: >> From: Michał Mirosław >> >> Signed-off-by: Michał Mirosław >> Reviewed-by: Jingjing Wu >> --- >> This is cherry picked from commit d75547718c87 ("net/i40e: return errno >> when interrupt setup fails") and a

[dpdk-dev] [PATCH v2] net/failsafe: improve stats accuracy

2017-10-19 Thread Matan Azrad
The stats_get API was changed to signal a potential failure to read stats. Furthermore, some PMDs are able to provide statistics even after a removal event occurred. Considering this, the fail-safe can try to access the latest statistics of a PMD to improve statistics accuracy. Attempt an ultimat

Re: [dpdk-dev] [PATCH v8 1/4] librte_flow_classify: add flow classify library

2017-10-19 Thread Singh, Jasvinder
> + > +struct acl_keys { > + struct rte_table_acl_rule_add_params key_add; /**< add key */ > + struct rte_table_acl_rule_delete_params key_del; /**< delete > key */ > +}; > + > +struct rte_flow_classify_rule { > + uint32_t id; /**< unique ID of classify rule */ > + enum rte_flow_

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Nicolau, Radu
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 19, 2017 2:23 PM > To: Nicolau, Radu ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; > sand

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-19 Thread Ananyev, Konstantin
> > Hi, > > On 2017/10/19 18:02, Ananyev, Konstantin wrote: > > > > Hi Jia, > > > >> > >> Hi > >> > >> > >> On 10/13/2017 9:02 AM, Jia He Wrote: > >>> Hi Jerin > >>> > >>> > >>> On 10/13/2017 1:23 AM, Jerin Jacob Wrote: > -Original Message- > > Date: Thu, 12 Oct 2017 17:05:50 +00

[dpdk-dev] [RFC PATCH 2/2] app/testpmd: add scapy command as pkt template

2017-10-19 Thread Xueming Li
Invoke scapy to generate packet templates for each queue of specific port, command format: scapy Example: scapy 0 Ether()/IP()/GRE()/IP()/UDP(dport=(2,5))/"cool" Signed-off-by: Xueming Li --- app/test-pmd/Makefile | 5 +++ app/test-pmd/cmdline.c | 99 +

[dpdk-dev] [RFC PATCH 1/2] app/testpmd: add packet template

2017-10-19 Thread Xueming Li
Txonly forwarding mode will check templates, if avaialbe, use templates for each queue. Signed-off-by: Xueming Li --- app/test-pmd/testpmd.c | 3 +++ app/test-pmd/testpmd.h | 1 + app/test-pmd/txonly.c | 42 ++ 3 files changed, 30 insertions(+), 16 dele

[dpdk-dev] [RFC PATCH 0/2] using scapy to generate packet templates

2017-10-19 Thread Xueming Li
The target is to make testpmd flexible to generate all kinds of packet in just one line. Examples: # send UDP packet to port 0 queue 0 testpmd> scapy 0 Ether()/IP()/UDP()/"hello_world" # send 4 L3 VXLAN packets with inner UDP dport 1-4 to port 1 queue 1-4, one packet per queue testpmd> scapy 1

Re: [dpdk-dev] [PATCH branch-16.11] net/i40e: return errno when interrupt setup fails

2017-10-19 Thread Yuanhan Liu
On Thu, Oct 19, 2017 at 09:22:30AM -0400, Aaron Conole wrote: > From: Michał Mirosław > > Signed-off-by: Michał Mirosław > Reviewed-by: Jingjing Wu > --- > This is cherry picked from commit d75547718c87 ("net/i40e: return errno > when interrupt setup fails") and applies cleanly. This is just a

Re: [dpdk-dev] [PATCH] net/virtio: fix an incorrect behavior of device stop/start

2017-10-19 Thread Yuanhan Liu
On Fri, Sep 01, 2017 at 03:14:26PM +0800, Tiwei Bie wrote: > > > > On Tue, Aug 29, 2017 at 04:26:01PM +0800, Tiwei Bie wrote: > > > > > After starting a device, the driver shouldn't deliver the > > > > > packets that already existed in the device before it is > > > > > started to the applications.

[dpdk-dev] [PATCH 1/2] ethdev: document rte_eth_dev_reset return codes

2017-10-19 Thread luca . boccassi
From: Luca Boccassi This new function returns 0 on success and various error codes on different failures. Attempt to document them. Signed-off-by: Luca Boccassi --- lib/librte_ether/rte_ethdev.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/lib

[dpdk-dev] [PATCH 2/2] ethdev: pre-emptively document rte_eth_dev_reset error code

2017-10-19 Thread luca . boccassi
From: Luca Boccassi When VF reset will be supported by drivers, the API will most likely have to return -EAGAIN to avoid blocking when the VF cannot be reset because the PF is down. Document it immediately even if it's not yet supported, so that users and developers can already take into account

[dpdk-dev] [PATCH branch-16.11] net/i40e: return errno when interrupt setup fails

2017-10-19 Thread Aaron Conole
From: Michał Mirosław Signed-off-by: Michał Mirosław Reviewed-by: Jingjing Wu --- This is cherry picked from commit d75547718c87 ("net/i40e: return errno when interrupt setup fails") and applies cleanly. This is just a backport request. drivers/net/i40e/i40e_ethdev.c | 5 +++--

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> -Original Message- > From: Nicolau, Radu > Sent: Thursday, October 19, 2017 2:14 PM > To: Ananyev, Konstantin ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; > s

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Radu Nicolau
On 10/19/2017 1:29 PM, Ananyev, Konstantin wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin Sent: Thursday, October 19, 2017 1:17 PM To: Nicolau, Radu ; Akhil Goyal ; dev@dpdk.org Cc: Doherty, Declan ; De Lara Guarch, Pablo ; hemant.

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Radu Nicolau
On 10/19/2017 1:16 PM, Ananyev, Konstantin wrote: -Original Message- From: Nicolau, Radu Sent: Thursday, October 19, 2017 12:57 PM To: Ananyev, Konstantin ; Akhil Goyal ; dev@dpdk.org Cc: Doherty, Declan ; De Lara Guarch, Pablo ; hemant.agra...@nxp.com; bor...@mellanox.com; avia...@

[dpdk-dev] [PATCH 5/6] net/mlx5: fix mark action with drop action

2017-10-19 Thread Nelio Laranjeiro
Marking a packet which will not be received by the NIC is useless, even if this action remains possible, it blocks the creation of the flow counter which embed a mark action to a drop queue to be created. Fixes: 31ba9997f11a ("net/mlx5: fully convert a flow to verbs in validate") Signed-off-by: N

[dpdk-dev] [PATCH 4/6] net/mlx5: fix flow director drop action

2017-10-19 Thread Nelio Laranjeiro
Flow director drop action as not been brought back with the new implementation on top of rte flow. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 25 - 1 file changed, 16

[dpdk-dev] [PATCH 2/6] net/mlx5: fix work queue array size

2017-10-19 Thread Nelio Laranjeiro
Indirection table size must be in log to communicate with verbs when the number of queue is not a power of two, the maximum indirection table size is use, but not converted to log2. This makes a memory corruption. Fixes: 4c7a0f5ff876 ("net/mlx5: make indirection tables shareable") Signed-off-by:

[dpdk-dev] [PATCH 1/6] net/mlx5: fix segfault on flow creation

2017-10-19 Thread Nelio Laranjeiro
When ports are stopped, the hash Rx queue should not be created. Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net

[dpdk-dev] [PATCH 3/6] net/mlx5: fix drop flows when port is stopped

2017-10-19 Thread Nelio Laranjeiro
Fix the drop queue rule creation when the port is stopped. Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[dpdk-dev] [PATCH 6/6] net/mlx5: fix allmulti mode

2017-10-19 Thread Nelio Laranjeiro
All multi is not adding unicast flows which cause unicast packets to be dropped by the NIC. Fixes: 6a6b6828fe6a ("net/mlx5: use flow to enable all multi mode") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_trigger.c | 131 1 file changed, 66

[dpdk-dev] [PATCH 0/6] net/mlx5: fixes

2017-10-19 Thread Nelio Laranjeiro
Some fixes on bugs and wrong behaviors. This series applies on top of: http://dpdk.org/patch/30351 Nelio Laranjeiro (6): net/mlx5: fix segfault on flow creation net/mlx5: fix work queue array size net/mlx5: fix drop flows when port is stopped net/mlx5: fix flow director drop action net/

Re: [dpdk-dev] [PATCH] ipsec_secgw: added cmdline option for jumbo frames and switched to the new offload API.

2017-10-19 Thread De Lara Guarch, Pablo
Hi Radu, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Wednesday, October 18, 2017 12:55 PM > To: dev@dpdk.org > Cc: Gonzalez Monroy, Sergio ; > Nicolau, Radu > Subject: [dpdk-dev] [PATCH] ipsec_secgw: added cmdline option for jumbo > fra

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Thursday, October 19, 2017 1:17 PM > To: Nicolau, Radu ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com;

Re: [dpdk-dev] [PATCH] examples/power: add turbo commands to help text

2017-10-19 Thread Hunt, David
Hi Marko, On 19/10/2017 10:34 AM, Marko Kovacevic wrote: From: David Hunt Fixes: d191f0853378 ("examples/vm_power_manager: add per-core turbo CLI") Signed-off-by: Marko Kovacevic --- examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> -Original Message- > From: Nicolau, Radu > Sent: Thursday, October 19, 2017 12:57 PM > To: Ananyev, Konstantin ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; >

[dpdk-dev] [PATCH v9 1/2] doc: add generic compilation doc for all sample apps

2017-10-19 Thread Marko Kovacevic
From: Herakliusz Lipiec Moved duplicated, and occasionally outdated, doc sections from each of the sample app guides chapters to a common chapter at the start. This reduces the duplication in the docs and provides a single point of reference for compiling the sample apps. Signed-off-by: Herakli

[dpdk-dev] [PATCH v9 2/2] doc: add new introduction to sample app guides

2017-10-19 Thread Marko Kovacevic
Add new Introduction Section into the sample app guides. Signed-off-by: Marko Kovacevic --- doc/guides/sample_app_ug/intro.rst | 153 +++-- 1 file changed, 113 insertions(+), 40 deletions(-) diff --git a/doc/guides/sample_app_ug/intro.rst b/doc/guides/sample_app

Re: [dpdk-dev] [PATCH] maintainers: updated ipsec_secgw

2017-10-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Wednesday, October 18, 2017 5:19 PM > To: Nicolau, Radu ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] maintainers: updated ipsec_secgw > > On 18/10/2017 13:06, Radu Nicolau wro

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Nicolau, Radu
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 19, 2017 12:04 PM > To: Nicolau, Radu ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; > san

Re: [dpdk-dev] [PATCH] pci: fix check uio bind

2017-10-19 Thread Gaëtan Rivet
Hi Jianfeng, On Thu, Oct 19, 2017 at 11:18:29AM +, Jianfeng Tan wrote: > When checking if any devices bound to uio, we did not exclud > those which are blacklisted (or in the case that a whitelist > is specified). > > This patch fixes it by only checking whitelisted devices. > > Fixes: 815c7

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-10-19 Thread Zhao, Bing
Hi, On 2017/10/19 18:02, Ananyev, Konstantin wrote: Hi Jia, Hi On 10/13/2017 9:02 AM, Jia He Wrote: Hi Jerin On 10/13/2017 1:23 AM, Jerin Jacob Wrote: -Original Message- Date: Thu, 12 Oct 2017 17:05:50 + [...] On the same lines, Jia He, jie2.liu, bing.zhao, Is this pa

[dpdk-dev] [PATCH] pci: fix check uio bind

2017-10-19 Thread Jianfeng Tan
When checking if any devices bound to uio, we did not exclud those which are blacklisted (or in the case that a whitelist is specified). This patch fixes it by only checking whitelisted devices. Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux") Signed-off-by: Jianfeng Tan --- lib/librte_ea

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> > > >> > >> + > >> +static int > >> +ixgbe_crypto_update_mb(void *device __rte_unused, > >> + struct rte_security_session *session, > >> + struct rte_mbuf *m, void *params __rte_unused) > >> +{ > >> + struct ixgbe_crypto_session *ic_session = > >> + g

Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API

2017-10-19 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Wednesday, October 18, 2017 10:49 PM > To: Ivan Malov ; Daly, Lee ; > tho...@monjalon.net > Cc: dev@dpdk.org; Kozak, KubaX > Subject: Re: [dpdk-dev] [PATCH v2] ethdev: fix xstats retrieve by id API > > On 10/18/2017 4:10

  1   2   >