Re: [dpdk-dev] [PATCH v4 02/16] net/mrvl: add mrvl net pmd driver skeleton

On Wed, Oct 11, 2017 at 03:38:36PM +0200, Thomas Monjalon wrote: > Hi, > > 09/10/2017 17:00, Tomasz Duszynski: > > # > > +# Compile Marvell PMD driver > > +# > > +CONFIG_RTE_LIBRTE_MRVL_PMD=n > > +CONFIG_RTE_LIBRTE_MRVL_DEBUG=n > > +CONFIG_RTE_MRVL_MUSDK_DMA_MEMSIZE=41943040 > > We are trying to r

[dpdk-dev] [PATCH v2] examples/vhost_scsi: fix buffer not terminated

Use snprintf instead strncpy to get safe null string termination. There was possible to get not terminated string after strncpy operation. Coverity issue: 158631 Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app") Cc: changpeng@intel.com Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [BUG-REPORT] Need to add mutex on vhost_devices[] in virtio-net.c in DPDK-2.2?

Hi all, I'm running vhostuser part code of dpdk, and I found a crash, which is caused by call NULL pointer. Then I debug code and I found I use NULL pointer which is got from vhost_devices[]. I read code of virtio-net.c, and I found there is no lock on vhost_devices[] !!! vhost_devices[] is used

Re: [dpdk-dev] [PATCH] doc: add build steps to mrvl NIC guide

On Thu, Oct 12, 2017 at 04:37:45AM +0200, Thomas Monjalon wrote: > Show how to compile MUSDK and enable compilation of the mrvl PMD. > > The build test tool is also updated to support this new PMD. > > Signed-off-by: Thomas Monjalon > --- > devtools/test-build.sh | 4 > doc/guides/nics/mr

Re: [dpdk-dev] [PATCH v4 00/16] add net mrvl pmd driver

On Thu, Oct 12, 2017 at 02:51:19AM +0100, Ferruh Yigit wrote: > On 10/9/2017 9:59 PM, Ferruh Yigit wrote: > > On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: > >> Hello, > >> > >> This patch series introduces the net driver for Marvell Armada 7k/8k > >> SoCs along with documentation. > >> > >> Below

Re: [dpdk-dev] [PATCH v2 2/2] igb_uio: fix interrupt enablement after FLR in VM

Hi, Shjith Could you help to review and verify if this fix can meet your requirement? Thanks Jingjing > -Original Message- > From: Wu, Jingjing > Sent: Tuesday, October 10, 2017 6:09 AM > To: Yigit, Ferruh ; Tan, Jianfeng > ; shijith.thot...@caviumnetworks.com; > greg...@weka.io; Xing, B

Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail

Hello Aaron, On Tuesday 10 October 2017 09:30 PM, Aaron Conole wrote: Shreyansh Jain writes: Hello Don, [snip] These practical problems confirm to me that the failure of a bus scan is more of a strategic issue: when asking "which devices can I use?", "none" is a perfectly valid answer t

Re: [dpdk-dev] [PATCH] examples/ip_reassembly: use pktmbuf to create pool

Hi Konstantin, Please review? Regards, Hemant On 9/6/2017 3:04 PM, Hemant Agrawal wrote: From: Ashish Jain Use of rte_mempool_create() with the helper provided in librte_mbuf: rte_pktmbuf_pool_create(). This is the preferred way to create a mbuf pool else it may not work on implementa

Re: [dpdk-dev] [PATCH v7 6/6] mk: install symlinks before build step

05/09/2017 22:51, luca.bocca...@gmail.com: > .PHONY: install > +ifeq ($(SYMLINK-FILES-y),) > install: build _postinstall > +else > +install: _preinstall build _postinstall > +endif I think you cannot be sure that "_preinstall" will be finished before the "build" target starts in parallel make. A

[dpdk-dev] [PATCH] doc: add build steps to mrvl NIC guide

Show how to compile MUSDK and enable compilation of the mrvl PMD. The build test tool is also updated to support this new PMD. Signed-off-by: Thomas Monjalon --- devtools/test-build.sh | 4 doc/guides/nics/mrvl.rst | 15 +++ 2 files changed, 19 insertions(+) diff --git a/de

Re: [dpdk-dev] [PATCH v5 3/5] bus: introduce new log type for bus drivers

On 10/11/2017 7:20 PM, Shreyansh Jain wrote: On Wednesday 11 October 2017 04:12 PM, Tan, Jianfeng wrote: On 10/11/2017 2:54 PM, Shreyansh Jain wrote: Hello Jianfeng, On Monday 09 October 2017 04:57 PM, Jianfeng Tan wrote: [...] -#define PMD_DRV_LOG(level, fmt, args...) \ -PMD_DRV_L

Re: [dpdk-dev] [PATCH v4 16/16] doc: add mrvl net pmd documentation

11/10/2017 16:27, Thomas Monjalon: > 09/10/2017 17:00, Tomasz Duszynski: > > +- MUSDK (Marvell User-Space SDK) sources available > > + `here > > `__. > > + > > +MUSDK is a light-weight library that provides di

Re: [dpdk-dev] [PATCH v4 00/16] add net mrvl pmd driver

On 10/9/2017 9:59 PM, Ferruh Yigit wrote: > On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: >> Hello, >> >> This patch series introduces the net driver for Marvell Armada 7k/8k >> SoCs along with documentation. >> >> Below you can find the list of features which net pmd supports: >> * Speed capabilit

Re: [dpdk-dev] [PATCH] mempool/dpaa2: improve error handling

10/10/2017 16:12, Hemant Agrawal: > Reverting the config on encountering errors. > > Signed-off-by: Hemant Agrawal Applied, thanks

Re: [dpdk-dev] [PATCH v6 0/5] increase port_id range

Hi ferruh, > >> Zhiyong Yang (5): > >> net/bonding: remove bonding APIs using ABI versioning > >> ethdev: increase port_id range > >> examples: increase port_id range > >> test: increase port_id range > >> librte_mbuf: modify port initialization value > > > > Series applied to dpdk-next-

Re: [dpdk-dev] [PATCH] mempool: remove get capability debug print

10/10/2017 16:28, santosh: > > On Tuesday 10 October 2017 07:47 PM, Hemant Agrawal wrote: > > This is not required to be printed for every mempool call. > > > > Signed-off-by: Hemant Agrawal > > --- > > Will print only in debug mode though, But ok with patch. > > Reviewed-by: Santosh Shukla >

[dpdk-dev] [PATCH] doc: remove fm10k features description for SSE

The features described for scalar fm10k and its vector implementations are the same. No need to distinguish them in features description. Signed-off-by: Thomas Monjalon --- doc/guides/nics/features/fm10k_vec.ini| 35 --- doc/guides/nics/features/fm10k_vf_vec.ini |

Re: [dpdk-dev] [PATCH v9 0/9] Policy Based Power Control for Guest

On 10/11/2017 5:18 PM, David Hunt wrote: > Policy Based Power Control for Guest > > This patchset adds the facility for a guest VM to send a policy down to the > host that will allow the host to scale up/down cpu frequencies > depending on the policy criteria independently of the DPDK app running

Re: [dpdk-dev] [PATCH v8 1/5] net/softnic: add softnic PMD

10/10/2017 12:18, Jasvinder Singh: > +ifeq ($(CONFIG_RTE_LIBRTE_SCHED),y) > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SOFTNIC) += -lrte_pmd_softnic > +endif Why linking softnic only if sched is enabled? Please, can you fix it for RC2?

Re: [dpdk-dev] [PATCH] app/testpmd: remove unnecessary cast

On 10/11/2017 11:56 PM, Ferruh Yigit wrote: > On 10/11/2017 7:59 AM, Zhiyong Yang wrote: >> Signed-off-by: Zhiyong Yang > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] app/testpmd: remove unnecessary cast

On 10/11/2017 11:56 PM, Ferruh Yigit wrote: > On 10/11/2017 7:59 AM, Zhiyong Yang wrote: >> Signed-off-by: Zhiyong Yang > > Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] app/testpmd: remove unnecessary cast

On 10/11/2017 7:59 AM, Zhiyong Yang wrote: > Signed-off-by: Zhiyong Yang Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH] net/ixgbe: fix uninitialized variable

On 10/11/2017 3:57 AM, Lu, Wenzhuo wrote: > Hi, > >> -Original Message- >> From: Yong Wang [mailto:wang.yon...@zte.com.cn] >> Sent: Tuesday, September 19, 2017 11:17 AM >> To: Lu, Wenzhuo >> Cc: dev@dpdk.org; Yong Wang >> Subject: [PATCH] net/ixgbe: fix uninitialized variable >> >> In fu

Re: [dpdk-dev] [PATCH] ethdev: revert use device name from device structure

On 10/11/2017 10:56 PM, Thomas Monjalon wrote: > 22/09/2017 16:57, Adrien Mazarguil: >> On Fri, Sep 22, 2017 at 12:30:07PM +0100, Ferruh Yigit wrote: >>> This reverts commit a1e7c17555e8f77d520ba5f06ed26c00e77a2bd1. >>> >>> Original commit assumes there is 1:1 mapping between physical device and >>

Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail

10/10/2017 18:00, Aaron Conole: > Shreyansh Jain writes: > > > Hello Don, > > > > On Monday 09 October 2017 11:51 PM, Don Provan wrote: > >>> -Original Message- > >>> From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > >>> Sent: Monday, October 09, 2017 4:10 AM > >>> To: Jan Blunck ; T

Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail

11/10/2017 02:03, Don Provan: > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > > > > ... > > > > > From the application's point of view, the potential error here > > > is that the device it wants to use isn't available. I don't see that > > > either the init function or the probe function

Re: [dpdk-dev] [PATCH v5 1/4] ethdev: add support for raw flow type for flow director

Hi, 10/10/2017 22:28, Kirill Rybalchenko: > Add new structure rte_eth_raw_flow to the union rte_eth_fdir_flow > to support filter for raw flow type. > > Signed-off-by: Kirill Rybalchenko This description does not explain why you add this new flow director type. It seems you are allowing a new f

Re: [dpdk-dev] [PATCH v1 09/29] mem: add iovec-like allocation wrappers

On 10/11/2017 10:58 PM, Ferruh Yigit wrote: > On 10/11/2017 3:35 PM, Adrien Mazarguil wrote: >> These wrappers implement the ability to allocate room for several disparate >> objects as a single contiguous allocation while complying with their >> respective alignment constraints. >> >> This is usua

Re: [dpdk-dev] [PATCH v1 09/29] mem: add iovec-like allocation wrappers

On 10/11/2017 3:35 PM, Adrien Mazarguil wrote: > These wrappers implement the ability to allocate room for several disparate > objects as a single contiguous allocation while complying with their > respective alignment constraints. > > This is usually more efficient than allocating and freeing the

Re: [dpdk-dev] [PATCH] ethdev: revert use device name from device structure

22/09/2017 16:57, Adrien Mazarguil: > On Fri, Sep 22, 2017 at 12:30:07PM +0100, Ferruh Yigit wrote: > > This reverts commit a1e7c17555e8f77d520ba5f06ed26c00e77a2bd1. > > > > Original commit assumes there is 1:1 mapping between physical device and > > ethdev port, so that device name can be used pe

Re: [dpdk-dev] [PATCH v6 0/5] increase port_id range

On 10/6/2017 3:15 AM, Ferruh Yigit wrote: > On 9/29/2017 8:17 AM, Zhiyong Yang wrote: >> port_id is currently defined as uint8_t, which is limited to the range >> 0 to 255. A larger range is required for vdev scalability. >> >> It is necessary for a redefinition of port_id to extend it from >> 1 by

Re: [dpdk-dev] [PATCH v8 0/2] net/i40e: API to configure queue regions for RSS

On 10/11/2017 9:55 AM, Wei Zhao wrote: > The patches mainly finish following functions: > 1) Command line for input queue region configure parameters. > 2) Set or flush queue region configutation. > > v2: > -fix bug for packet into queue region code. > -change code style for DPDK C programing. > -

Re: [dpdk-dev] [PATCH 1/2] reorder: fix ready buffers not being nulled out

12/09/2017 17:06, Pavan Nikhilesh: > The ready buffers should be set to NULL when drained else it might result > in double free (mempool put) when rte_reorder_free is called. > > Fixes: b70b56032bff ("reorder: new library") > > Signed-off-by: Pavan Nikhilesh Anyone to review, please?

Re: [dpdk-dev] [dpdk-stable] [PATCH] timer: move 64bit specific code under ARCH64

13/08/2017 14:33, Jerin Jacob: > 64bit load and store will be an atomic operation on all the > 64bit processors. > Change RTE_ARCH_X86_64 to RTE_ARCH_64 to reflect the case. > > Fixes: 9b15ba895b9f ("timer: use a skip list") > Cc: sta...@dpdk.org > Signed-off-by: Jerin Jacob Applied, thanks

Re: [dpdk-dev] [PATCH v4 0/3] timer library enhancement

This patchset is waiting for review. Robert, are you available? 19/09/2017 19:02, Erik Gabriel Carrillo: > In the current implementation of the DPDK timer library, timers can be > created and set to be handled by a target lcore by adding it to a > skiplist that corresponds to that lcore. However

Re: [dpdk-dev] [PATCH v3] timer: allow timer reset on service cores

21/09/2017 22:10, Pavan Nikhilesh: > From: Pavan Bhagavatula > > The rte_timer_reset function should be able to register timers on service > lcores as they are EAL threads. > > Signed-off-by: Pavan Nikhilesh > Acked-by: Harry van Haaren Applied, thanks

Re: [dpdk-dev] [PATCH v3] eal: add function to check lcore role

21/09/2017 12:59, Pavan Nikhilesh: > From: Pavan Bhagavatula > > This function can be used to check the role of a specific lcore. > > Signed-off-by: Pavan Nikhilesh > Acked-by: Harry van Haaren Applied, thanks

Re: [dpdk-dev] [PATCH] eal/x86: use cpuid builtin

05/10/2017 01:39, Ferruh Yigit: > On 8/23/2017 4:00 PM, Sergio Gonzalez Monroy wrote: > > GCC does have the __get_cpuid_count builtin which checks for maximum > > supported leaf, but implementations differ between CLANG and GCC. > > > > This change provides an implementation compatible with both G

Re: [dpdk-dev] [PATCH v2 5/5] eal/timer: honor architecture specific rdtsc hz function

11/10/2017 20:57, Jerin Jacob: > From: Thomas Monjalon > > 22/09/2017 10:25, Gowrishankar: > > > From: Jerin Jacob > > > > > > When calibrating the tsc frequency, first, probe the architecture specific > > > rdtsc hz function. if not available, use the existing calibrate scheme > > > to calibrat

Re: [dpdk-dev] [PATCH v1 1/7] ethdev: expose flow API error helper

Adrien Mazarguil writes: > On Wed, Oct 11, 2017 at 11:23:12AM +0200, Thomas Monjalon wrote: >> 05/10/2017 11:49, Adrien Mazarguil: >> > rte_flow_error_set() is a convenient helper to initialize error objects. >> > >> > Since there is no fundamental reason to prevent applications from using it, >

Re: [dpdk-dev] Issue with pktgen-dpdk replaying >1500bytes pcap on MCX4

On Thu, Sep 28, 2017 at 08:44:26PM +, Wiles, Keith wrote: > > > On Sep 26, 2017, at 8:09 AM, Damien Clabaut > > wrote: > > > > Hello Keith and thank you for your answer, > > > > The goal is indeed to generate as much traffic per machine as possible (we > > use pktgen-dpdk to benchmark dat

Re: [dpdk-dev] [PATCH v2 5/5] eal/timer: honor architecture specific rdtsc hz function

-Original Message- > Date: Wed, 11 Oct 2017 19:36:11 +0200 > From: Thomas Monjalon > To: Gowrishankar , Jerin Jacob > > Cc: dev@dpdk.org, Chao Zhu , Bruce Richardson > , Konstantin Ananyev > , vikto...@rehivetech.com, > jianbo@linaro.org > Subject: Re: [dpdk-dev] [PATCH v2 5/5] ea

Re: [dpdk-dev] [PATCH] ethdev: fix xstats retrieve by id API

On 10/11/2017 8:22 AM, Lee Daly wrote: > From: Lee > > Fix xstats functions, rte_eth_xstats_get_names_by_id() > and rte_eth_xstats_get_by_id(), in current implementation > ethdev level reads all xstat values and filters out > the ones requested by the application. This behavior doesn't > benefit

[dpdk-dev] [PATCH v5 4/5] net/mlx4: restore Rx offloads

From: Moti Haimovsky This patch adds hardware offloading support for IPV4, UDP and TCP checksum verification, including inner/outer checksums on supported tunnel types. It also restores packet type recognition support. Signed-off-by: Vasily Philipov Signed-off-by: Moti Haimovsky Acked-by: Adr

[dpdk-dev] [PATCH v5 5/5] net/mlx4: add loopback Tx from VF

From: Moti Haimovsky This patch adds loopback functionality used when the chip is a VF in order to enable packet transmission between VFs and PF. Signed-off-by: Moti Haimovsky Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_rxtx.c | 33 + drivers/net/mlx4/

[dpdk-dev] [PATCH v5 3/5] net/mlx4: restore Tx checksum offloads

From: Moti Haimovsky This patch adds hardware offloading support for IPv4, UDP and TCP checksum calculation, including inner/outer checksums on supported tunnel types. Signed-off-by: Moti Haimovsky Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.c| 11 +++ drivers/net/mlx

[dpdk-dev] [PATCH v5 1/5] net/mlx4: add Tx bypassing Verbs

From: Moti Haimovsky Modify PMD to send single-buffer packets directly to the device bypassing the Verbs Tx post and poll routines. Tx gather support: add support for transmitting packets spanning over multiple buffers. Take into consideration the amount of entries a packet occupies in the TxQ

[dpdk-dev] [PATCH v5 2/5] net/mlx4: add Rx bypassing Verbs

From: Moti Haimovsky This patch adds support for accessing the hardware directly when handling Rx packets eliminating the need to use Verbs in the Rx data path. Rx scatter support: calculate the number of scatters on the fly according to the maximum expected packet size. Signed-off-by: Vasily P

[dpdk-dev] [PATCH v5 0/5] new mlx4 datapath bypassing ibverbs

Hopefully the last iteration for this series. v5 (Ophir & Adrien): - Merged Rx scatter/Tx gather code back into individual Rx/Tx commits for consistency due to a couple of issues with gather-less Tx. - Rebased on top of the latest mlx4 control path changes (RSS support). v4 (Ophir): - Split "ne

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VFIO interrupt mapping in VF

On 10/11/2017 4:16 AM, Lu, Wenzhuo wrote: > Hi, > >> -Original Message- >> From: Dai, Wei >> Sent: Thursday, September 28, 2017 10:29 AM >> To: Lu, Wenzhuo ; Ananyev, Konstantin >> ; Liang, Cunming >> ; Ma, Jianwei >> Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org >> Subject: [PATCH v2] net

Re: [dpdk-dev] [PATCH] net/ixgbe: fix Rx queue interrupt mapping in VF

On 10/11/2017 4:13 AM, Lu, Wenzhuo wrote: > Hi, > >> -Original Message- >> From: Dai, Wei >> Sent: Wednesday, September 20, 2017 6:18 PM >> To: Lu, Wenzhuo ; Ananyev, Konstantin >> >> Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org >> Subject: [PATCH] net/ixgbe: fix Rx queue interrupt mappin

Re: [dpdk-dev] [PATCH v1 0/7] Flow API helpers enhancements

On 10/11/2017 10:57 AM, Adrien Mazarguil wrote: > On Tue, Oct 10, 2017 at 07:05:30PM +0100, Ferruh Yigit wrote: >> On 10/6/2017 9:05 AM, Adrien Mazarguil wrote: >>> On Fri, Oct 06, 2017 at 02:13:14AM +0100, Ferruh Yigit wrote: On 10/5/2017 10:49 AM, Adrien Mazarguil wrote: > This series br

Re: [dpdk-dev] [PATCH 1/2] net/sfc: invert positive errno used internally on return

On 10/11/2017 8:06 AM, Andrew Rybchenko wrote: > Fixes: a4b090d0284b ("ethdev: add return value to stats get dev op") > > Signed-off-by: Andrew Rybchenko Series squashed into relevant commit in next-net, thanks.

Re: [dpdk-dev] [PATCH v2 5/5] eal/timer: honor architecture specific rdtsc hz function

22/09/2017 10:25, Gowrishankar: > From: Jerin Jacob > > When calibrating the tsc frequency, first, probe the architecture specific > rdtsc hz function. if not available, use the existing calibrate scheme > to calibrate the tsc frequency. > > Signed-off-by: Jerin Jacob I agree on the idea. The

Re: [dpdk-dev] [PATCH] doc: fix description of traffic management function in testpmd

On 10/11/2017 6:11 PM, Jasvinder Singh wrote: > Fixes: 983fac0a7cdf ("doc: add description of traffic management functions in > testpmd") > > Signed-off-by: Jasvinder Singh Squashed into relevant commit in next-net, thanks. Commit: bca2738e4cf1 ("app/testpmd: add traffic management forwarding

Re: [dpdk-dev] [PATCH 1/3] net/octeontx: fix 32bit build with driver debug enabled

On 10/11/2017 12:30 PM, Jerin Jacob wrote: > squash this to next-next > > Fixes: 7c025f92e9f4 ("net/octeontx/base: add base PKO operations") > > Reported-by: Thomas Monjalon > Signed-off-by: Jerin Jacob Series squashed into relevant commits in next-net, thanks.

[dpdk-dev] [PATCH] doc: fix description of traffic management function in testpmd

Fixes: 983fac0a7cdf ("doc: add description of traffic management functions in testpmd") Signed-off-by: Jasvinder Singh --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/

[dpdk-dev] [PATCH v9 9/9] examples/vm_power_mgr: set MAC address of VF

We need to set vf mac from the host, so that they will be in sync on the guest and the host. Otherwise, we'll have a random mac on the guest, and a 00:00:00:00:00:00 mac on the host. Signed-off-by: David Hunt Reviewed-by: Santosh Shukla Acked-by: Konstantin Ananyev --- examples/vm_power_manage

[dpdk-dev] [PATCH v9 8/9] examples/guest_cli: add send policy to host

From: "Sexton, Rory" Here we're adding an example of setting up a policy, and allowing the vm_cli_guest app to send it to the host using the cli command "send_policy now" Signed-off-by: Nemanja Marjanovic Signed-off-by: Rory Sexton Signed-off-by: David Hunt Reviewed-by: Santosh Shukla Acked-

[dpdk-dev] [PATCH v9 6/9] examples/vm_power_mgr: add port initialisation

We need to initialise the port's we're monitoring to be able to see the throughput. Signed-off-by: Nemanja Marjanovic Signed-off-by: David Hunt Reviewed-by: Santosh Shukla Acked-by: Konstantin Ananyev --- examples/vm_power_manager/main.c | 220 +++ 1 file c

[dpdk-dev] [PATCH v9 5/9] examples/vm_power_mgr: add policy to channels

From: "Sexton, Rory" Signed-off-by: Nemanja Marjanovic Signed-off-by: Rory Sexton Signed-off-by: David Hunt Reviewed-by: Santosh Shukla Acked-by: Konstantin Ananyev --- examples/vm_power_manager/Makefile | 16 ++ examples/vm_power_manager/channel_monitor.c | 321 ++

[dpdk-dev] [PATCH v9 7/9] power: add send channel msg function to map file

Adding new wrapper function to existing private (but unused 'till now) function with an rte_power_ prefix. The plan is to clean up all the header files in the next release so that only the intended public functions are in the map file and only the relevant headers have the rte_ prefix so that only

[dpdk-dev] [PATCH v9 3/9] examples/vm_power_mgr: add vcpu to pcpu mapping

Signed-off-by: Nemanja Marjanovic Signed-off-by: Rory Sexton Signed-off-by: David Hunt Reviewed-by: Santosh Shukla Acked-by: Konstantin Ananyev --- examples/vm_power_manager/channel_manager.c | 67 + examples/vm_power_manager/channel_manager.h | 25 +++ 2 f

[dpdk-dev] [PATCH v9 4/9] examples/vm_power_mgr: add scale to medium freq fn

Signed-off-by: Nemanja Marjanovic Signed-off-by: Rory Sexton Signed-off-by: David Hunt Reviewed-by: Santosh Shukla Acked-by: Konstantin Ananyev --- examples/vm_power_manager/power_manager.c | 32 ++- examples/vm_power_manager/power_manager.h | 13 + 2 f

[dpdk-dev] [PATCH v9 2/9] lib/librte_power: add extra msg type for policies

Signed-off-by: Nemanja Marjanovic Signed-off-by: Rory Sexton Signed-off-by: David Hunt Reviewed-by: Santosh Shukla Acked-by: Konstantin Ananyev --- lib/librte_power/channel_commands.h | 42 + 1 file changed, 42 insertions(+) diff --git a/lib/librte_power/c

[dpdk-dev] [PATCH v9 1/9] net/i40e: add API to convert VF MAC to VF id

From: "Sexton, Rory" Need a way to convert a vf id to a pf id on the host so as to query the pf for relevant statistics which are used for the frequency changes in the vm_power_manager app. Used when profiles are passed down from the guest to the host, allowing the host to map the vfs to pfs. Si

[dpdk-dev] [PATCH v9 0/9] Policy Based Power Control for Guest

Policy Based Power Control for Guest This patchset adds the facility for a guest VM to send a policy down to the host that will allow the host to scale up/down cpu frequencies depending on the policy criteria independently of the DPDK app running in the guest. This differs from the previous vm_po

[dpdk-dev] [PATCH v6 2/2] doc: add new introduction to sample app guides

Add new Introduction Section into the sample app guides. Signed-off-by: Marko Kovacevic Reviewed-by: John McNamara --- doc/guides/faq/faq.rst | 2 +- doc/guides/sample_app_ug/dist_app.rst | 2 + doc/guides/sample_app_ug/exception_path.rst|

[dpdk-dev] [PATCH v6 1/2] doc: add generic compilation doc for all sample apps

From: Herakliusz Lipiec Moved duplicated, and occasionally outdated, doc sections from each of the sample app guides chapters to a common chapter at the start. This reduces the duplication in the docs and provides a single point of reference for compiling the sample apps. Signed-off-by: Herakli

Re: [dpdk-dev] [PATCH v3 3/4] cryptodev: rework dependency on vdev header

Hi Jan, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, October 10, 2017 1:50 PM > To: Jan Blunck > Cc: dev@dpdk.org; Doherty, Declan > Subject: RE: [PATCH v3 3/4] cryptodev: rework dependency on vdev header > > > > > -Original Message- > > From: jblu...@gm

[dpdk-dev] [PATCH v1 11/29] net/mlx4: allocate drop flow resources on demand

Verbs QP and CQ resources for drop flow rules do not need to be permanently allocated, only when at least one rule needs them. Besides, struct rte_flow_drop is outside the mlx4 PMD name space and should never have been defined there. struct rte_flow is currently the only exception to this rule. S

[dpdk-dev] [pull-request] next-pipeline 17.11 pre-rc1

The following changes since commit d65b3b1668f2037745407c3909c43d85a18692a6: vhost: fix false-positive warning from clang 5 (2017-10-11 13:56:34 +0200) are available in the git repository at: http://dpdk.org/git/next/dpdk-next-pipeline for you to fetch changes up to 5ba29c202060c8edadbc36d

[dpdk-dev] [PATCH v1 29/29] net/mlx4: add RSS support outside flow API

Bring back support for automatic RSS with the default flow rules when not in isolated mode. Balancing is done according to unspecified default settings, as was the case before this entire rework. Since the number of queues part of RSS contexts is limited to power of two values, the number of confi

Re: [dpdk-dev] [PATCH] devtools: rename build dependency of mlx drivers

On Wed, Oct 11, 2017 at 03:28:58PM +0200, Thomas Monjalon wrote: > The Mellanox drivers were requiring MOFED at compilation time. > It is now possible to use the upstream rdma-core package. > So the dependency option is renamed in the build tool. > > Fixes: 43e9d9794cde ("net/mlx5: support upstrea

[dpdk-dev] [PATCH v1 27/29] net/mlx4: add RSS flow rule action support

This patch dissociates single-queue indirection tables and hash QP objects from Rx queue structures to relinquish their control to users through the RSS flow rule action, while simultaneously allowing multiple queues to be associated with RSS contexts. Flow rules share identical RSS contexts (hash

[dpdk-dev] [PATCH v1 28/29] net/mlx4: disable UDP support in RSS flow rules

When part of the RSS hash calculation, UDP packets are discarded (not received on any queue) likely due to an issue with the kernel implementation. Temporarily disable UDP RSS support until this issue is resolved. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/

[dpdk-dev] [PATCH v1 26/29] net/mlx4: remove unnecessary check

Device operation callbacks are not supposed to handle a missing private data structure. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/mlx4_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/mlx4/mlx4_ethdev.c b/drivers/net/mlx4/mlx4_ethde

[dpdk-dev] [PATCH v1 25/29] net/mlx4: convert Rx path to work queues

Work queues (WQs) are lower-level than standard queue pairs (QPs). They are dedicated to one traffic direction and have to be used in conjunction with indirection tables and special "hash" QPs to get the same level of functionality. These extra objects however are the building blocks for RSS suppo

[dpdk-dev] [PATCH v1 23/29] net/mlx4: drop live queue reconfiguration support

DPDK ensures that setup functions are never called on configured queues, or only if they have previously been released. PMDs therefore do not need to deal with the unexpected reconfiguration of live queues which may fail with no easy way to recover. Dropping support for this scenario greatly simpl

[dpdk-dev] [PATCH v1 24/29] net/mlx4: allocate queues and mbuf rings together

Since live Tx and Rx queues cannot be reused anymore without being destroyed first, mbuf ring sizes are fixed and known from the start. This allows a single allocation for queue data structures and mbuf ring together, saving space and bringing them closer in memory. Signed-off-by: Adrien Mazargui

[dpdk-dev] [PATCH v1 22/29] net/mlx4: fix invalid errno value sign

Tx queue elements allocation function sets rte_errno properly and returns its negative version. Reassigning this value to rte_errno is thus both invalid and unnecessary. Fixes: c3e1f93cdf88 ("net/mlx4: standardize on negative errno values") Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranje

[dpdk-dev] [PATCH v1 21/29] net/mlx4: update Rx/Tx callbacks consistently

Although their "removed" version acts as a safety against unexpected bursts while queues are being modified by the control path, these callbacks are set per device instead of per queue. It makes sense to update them during start/stop/close cycles instead of queue setup. As a side effect, this comm

[dpdk-dev] [PATCH v1 19/29] net/mlx4: add flow support for multicast traffic

Give users the ability to create flow rules that match all multicast traffic. Like promiscuous flow rules, they come with restrictions such as not allowing additional matching criteria. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- doc/guides/nics/features/mlx4.ini | 1 + driv

[dpdk-dev] [PATCH v1 20/29] net/mlx4: restore promisc and allmulti support

Implement promiscuous and all multicast through internal flow rules automatically generated according to the configured mode. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- doc/guides/nics/features/mlx4.ini | 2 + drivers/net/mlx4/mlx4.c | 4 ++ drivers/net/mlx4/mlx4

[dpdk-dev] [PATCH v1 17/29] net/mlx4: add MAC addresses configuration support

This commit brings back support for configuring up to 128 MAC addresses on a port through internal flow rules automatically generated on demand. Unlike its previous incarnation, the necessary extra flow rule for broadcast traffic does not consume an entry from the MAC array anymore. Signed-off-by

[dpdk-dev] [PATCH v1 18/29] net/mlx4: add VLAN filter configuration support

This commit brings back VLAN filter configuration support without any artificial limitation on the number of simultaneous VLANs that can be configured (previously 127). Also thanks to the fact it does not rely on fixed per-queue arrays for potential Verbs flow handle storage anymore, this version

[dpdk-dev] [PATCH v1 16/29] net/mlx4: refactor flow item validation code

Since flow rule validation and creation have been refactored into a common two-pass function, having separate callback functions to validate and convert individual items seems redundant. The purpose of these item validation functions is to reject partial masks as those are not supported by hardwar

[dpdk-dev] [PATCH v1 15/29] net/mlx4: simplify trigger code for flow rules

Since flow rules synchronization function mlx4_flow_sync() takes into account the state of the device (whether it is started), trigger functions mlx4_flow_start() and mlx4_flow_stop() are redundant. Standardize on mlx4_flow_sync(). Use this opportunity to enhance this function with better error re

[dpdk-dev] [PATCH v1 14/29] net/mlx4: generalize flow rule priority support

Since both internal and user-defined flow rules are handled by a common implementation, flow rule priority overlaps are easier to detect. No need to restrict their use to isolated mode only. With this patch, only the lowest priority level remains inaccessible to users outside isolated mode. Also,

[dpdk-dev] [PATCH v1 13/29] net/mlx4: refactor internal flow rules

When not in isolated mode, a flow rule is automatically configured by the PMD to receive traffic addressed to the MAC address of the device. This somewhat duplicates flow API functionality. Remove legacy support for internal flow rules to instead handle them through the flow API implementation. S

[dpdk-dev] [PATCH v1 12/29] net/mlx4: relax check on missing flow rule target

Creating a flow rule targeting a missing (unconfigured) queue is not possible. However, nothing really prevents the destruction of a queue with existing flow rules still pointing at it, except currently the port must be in a stopped state in order to avoid crashing. Problem is that the port cannot

[dpdk-dev] [PATCH v1 10/29] net/mlx4: merge flow creation and validation code

These functions share a significant amount of code and require extra internal objects to parse and build flow rule handles. All this can be simplified by relying directly on the internal rte_flow structure definition, whose QP pointer (destination Verbs queue) is replaced by a DPDK queue ID and ot

[dpdk-dev] [PATCH v1 09/29] mem: add iovec-like allocation wrappers

These wrappers implement the ability to allocate room for several disparate objects as a single contiguous allocation while complying with their respective alignment constraints. This is usually more efficient than allocating and freeing them individually if they are not expected to be reallocated

[dpdk-dev] [PATCH v1 08/29] net/mlx4: compact flow rule error reporting

Relying on rte_errno is not necessary where the return value of rte_flow_error_set() can be used directly. A related minor change is switching from RTE_FLOW_ERROR_TYPE_HANDLE to RTE_FLOW_ERROR_TYPE_UNSPECIFIED when no rte_flow handle is involved in the error, specifically when none is allocated ye

[dpdk-dev] [PATCH v1 07/29] net/mlx4: tidy up flow rule handling code

- Remove unnecessary casts. - Replace consecutive if/else blocks with switch statements. - Use proper big endian definitions for mask values. - Make end marker checks of item and action lists less verbose since they are explicitly documented as being equal to 0. - Remove unnecessary NULL check on

[dpdk-dev] [PATCH v1 06/29] net/mlx4: clarify flow objects naming scheme

In several instances, "items" refers either to a flow pattern or a single item, and "actions" either to the entire list of actions or only one of them. The fact the target of a rule (struct mlx4_flow_action) is also named "action" and item-processing objects (struct mlx4_flow_items) as "cur_item"

[dpdk-dev] [PATCH v1 05/29] net/mlx4: expose support for flow rule priorities

This PMD supports up to 4096 flow rule priority levels (0 to 4095). Applications were not allowed to use them until now due to overlaps with the default flows (e.g. MAC address, promiscuous mode). This is not an issue in isolated mode when such flows do not exist. Signed-off-by: Adrien Mazarguil

[dpdk-dev] [PATCH v1 04/29] net/mlx4: enhance header files comments

Add missing comments and fix those not Doxygen-friendly. Since the private structure definition is modified, use this opportunity to add one remaining missing include required by one of its fields (sys/queue.h for LIST_HEAD()). Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- dri

[dpdk-dev] [PATCH v1 03/29] net/mlx4: remove Rx QP initializer function

There is no benefit in having this as a separate function. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/mlx4_rxq.c | 59 1 file changed, 18 insertions(+), 41 deletions(-) diff --git a/drivers/net/mlx4/mlx4_rxq.c b/driv

[dpdk-dev] [PATCH v1 02/29] net/mlx4: replace bit-field type

Make clear it's 32-bit wide. Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx4/mlx4.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h index 9bd2acc..71cbced 100644 --- a/drivers/net/mlx4/

  1   2   3   >