Re: [dpdk-dev] [PATCH v3 00/30] net/mlx5: cleanup for isolated mode

2017-10-09 Thread Nélio Laranjeiro
On Mon, Oct 09, 2017 at 07:35:01PM +0100, Ferruh Yigit wrote: > On 10/9/2017 6:17 PM, Yongseok Koh wrote: > > > >> On Oct 9, 2017, at 7:44 AM, Nelio Laranjeiro > >> wrote: > >> > >> This series cleanups the control plane part and the way it uses the > >> different > >> kind of objects (DPDK que

Re: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value

2017-10-09 Thread Yang, Zhiyong
Hi,kubax, When you form the patch , you should add v2 and changes in v2. Besides that, please be free to add Acked-by: zhiyong yang Thanks Zhiyong > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kuba Kozak > Sent: Tuesday, October 3, 2017 7:48 PM > To: Anany

[dpdk-dev] [PATCH] bus/dpaa: fix memory allocation during bus scan

2017-10-09 Thread Shreyansh Jain
Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations") Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup") Cc: shreyansh.j...@nxp.com With the IOVA auto detection changes, bus scan is performed before memory initialization. DPAA bus scan must not use rte_malloc in its path.

Re: [dpdk-dev] [PATCH v7 1/2] net/i40e: queue region set and flush

2017-10-09 Thread Zhao1, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, October 4, 2017 1:55 AM > To: Zhao1, Wei ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 1/2] net/i40e: queue region set and flush > > On 9/29/2017 10:16 AM, Wei Zhao wrote: > > This feature enable queue regions configurati

Re: [dpdk-dev] [PATCH v4 00/16] add net mrvl pmd driver

2017-10-09 Thread Tomasz Duszynski
On Mon, Oct 09, 2017 at 09:59:27PM +0100, Ferruh Yigit wrote: > On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: > > Hello, > > > > This patch series introduces the net driver for Marvell Armada 7k/8k > > SoCs along with documentation. > > > > Below you can find the list of features which net pmd supp

Re: [dpdk-dev] [PATCH v4 16/16] doc: add mrvl net pmd documentation

2017-10-09 Thread Tomasz Duszynski
On Mon, Oct 09, 2017 at 09:54:20PM +0100, Ferruh Yigit wrote: > On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: > > Add documentation for the MRVL NET PMD driver. > > > > Signed-off-by: Jacek Siuda > > Signed-off-by: Tomasz Duszynski > > I guess this should be "Tomasz Duszynski " :) Good nitpick!

Re: [dpdk-dev] [PATCH v4 15/16] maintainers: add maintainers for the mrvl net pmd

2017-10-09 Thread Tomasz Duszynski
On Mon, Oct 09, 2017 at 08:02:07PM +0100, Ferruh Yigit wrote: > On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: > > Signed-off-by: Jacek Siuda > > Signed-off-by: Tomasz Duszynski > > Congratulations!, > > this is the 3. patch in patchwork: 30k patch and series applied, double win. > http://dp

Re: [dpdk-dev] [PATCH v4] ethdev: allow returning error on VLAN offload configuration

2017-10-09 Thread Ferruh Yigit
On 9/1/2017 3:36 AM, David Harton wrote: > Some devices may not support or fail setting VLAN offload > configuration based on dynamic circurmstances so the > vlan_offload_set_t vector is modified to return an int so > the caller can determine success or not. > > rte_eth_dev_set_vlan_offload is upd

[dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD

2017-10-09 Thread Qi Zhang
vPMD tx does not set sw_ring's mbuf to NULL after free it. So to prevent same mbuf be free again, we need more carefully check in i40e_tx_queue_release_mbufs. Fixes: b4669bb95038 ("i40e: add vector Tx") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- v2: - fix at i40e_tx_queue_release_mbufs so n

[dpdk-dev] [PATCH v2 2/2] igb_uio: fix interrupt enablement after FLR in VM

2017-10-09 Thread Jingjing Wu
If pass-through a VF by vfio-pci to a Qemu VM, after FLR in VM, the interrupt setting is not recoverd correctly to host as below: in VM guest: Capabilities: [70] MSI-X: Enable+ Count=5 Masked- in Host: Capabilities: [70] MSI-X: Enable+ Count=5 Masked- That was because in pci_rese

[dpdk-dev] [PATCH v2 1/2] net/i40e: fix VF initialization error

2017-10-09 Thread Jingjing Wu
In igb_uio, FLR is issued during open device file. i40evf is trying to initialize admin queue when driver probe, while the FLR is not done by host driver. That will cause initialization fail. This patch is adding the checking if VF reset is done before adimin queue initialization. Fixes: b58eedfc

[dpdk-dev] [PATCH v2] doc: add virtio lsc note

2017-10-09 Thread Zhiyong Yang
Virtio PMD has already supported link status change(lsc), but VM which must be created by qemu 2.7.0 and above can support it when vhost user disconnects, since the capability to detect vhost user disconnection is introduced in qemu 2.7.0. The patch updates doc to let user know that. Signed-off-by

Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail

2017-10-09 Thread Shreyansh Jain
Hello Don, On Monday 09 October 2017 11:51 PM, Don Provan wrote: -Original Message- From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] Sent: Monday, October 09, 2017 4:10 AM To: Jan Blunck ; Thomas Monjalon Cc: dev ; Hemant Agrawal Subject: Re: [dpdk-dev] [PATCH] eal: bus scan and pr

Re: [dpdk-dev] [PATCH v4 15/16] maintainers: add maintainers for the mrvl net pmd

2017-10-09 Thread Ferruh Yigit
On 10/10/2017 4:20 AM, Jianbo Liu wrote: > On 9 October 2017 at 23:00, Tomasz Duszynski wrote: >> Signed-off-by: Jacek Siuda >> Signed-off-by: Tomasz Duszynski >> --- >> MAINTAINERS | 10 ++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 1b74f9

[dpdk-dev] [PATCH 2/2] igb_uio: fix interrupt enablement after FLR in VM

2017-10-09 Thread Jingjing Wu
If pass-through a VF by vfio-pci to a Qemu VM, after FLR in VM, the interrupt setting is not recoverd correctly to host as below: in VM guest: Capabilities: [70] MSI-X: Enable+ Count=5 Masked- in Host: Capabilities: [70] MSI-X: Enable+ Count=5 Masked- That was because in pci_rese

[dpdk-dev] [PATCH 1/2] net/i40e: fix VF initialization error

2017-10-09 Thread Jingjing Wu
In igb_uio, FLR is issued during open device file. i40evf is trying to initialize admin queue when driver probe, while the FLR is not done by host driver. That will cause initialization fail. This patch is adding the checking if VF reset is done before adimin queue initialization. Fixes: b58eedfc

Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix VFIO interrupt mapping in VF

2017-10-09 Thread Dai, Wei
Hi, Jianwei How about your test result ? Hi Wenzhuo Would you please review this patch ? Thanks a lot ! > -Original Message- > From: Dai, Wei > Sent: Thursday, September 28, 2017 10:29 AM > To: Lu, Wenzhuo ; Ananyev, Konstantin > ; Liang, Cunming > ; Ma, Jianwei > Cc: dev@dpdk.org; Dai

Re: [dpdk-dev] [PATCH] net/ixgbe: fix Rx queue interrupt mapping in VF

2017-10-09 Thread Dai, Wei
Hi, Jianwei How about your test result ? Hi, Wenzhuo Would you please review this patch ? Thanks a lot ! > -Original Message- > From: Dai, Wei > Sent: Wednesday, September 20, 2017 6:18 PM > To: Lu, Wenzhuo ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject

Re: [dpdk-dev] [PATCH] maintainers: update the email for ARM

2017-10-09 Thread Jerin Jacob
-Original Message- > Date: Tue, 10 Oct 2017 11:11:37 +0800 > From: Jianbo Liu > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Jianbo Liu > Subject: [PATCH] maintainers: update the email for ARM > X-Mailer: git-send-email 1.9.1 > > Update my email to jianbo@arm.com. > > Sign

Re: [dpdk-dev] [PATCH v4 15/16] maintainers: add maintainers for the mrvl net pmd

2017-10-09 Thread Jianbo Liu
On 9 October 2017 at 23:00, Tomasz Duszynski wrote: > Signed-off-by: Jacek Siuda > Signed-off-by: Tomasz Duszynski > --- > MAINTAINERS | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 1b74f98..5c78477 100644 > --- a/MAINTAINERS > +++ b/MAINT

Re: [dpdk-dev] [PATCH v3] rte_vhost: added user callbacks for socket open/close

2017-10-09 Thread Yuanhan Liu
On Wed, Aug 30, 2017 at 12:50:58PM +0200, Dariusz Stojaczyk wrote: > Added new callbacks to notify about socket connection status. > As destroy_device is used for virtqueue processing *pause* as well as > connection close, the user has no distinction between those. > > Consider the following scena

[dpdk-dev] [PATCH] maintainers: update the email for ARM

2017-10-09 Thread Jianbo Liu
Update my email to jianbo@arm.com. Signed-off-by: Jianbo Liu --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1b74f98..7c6ec95 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -148,13 +148,13 @@ F: test/test/test_service_cor

Re: [dpdk-dev] [PATCH v7 2/2] app/testpmd: add API for configuration of queue region

2017-10-09 Thread Zhao1, Wei
Hi,Ferruh > -Original Message- > From: Zhao1, Wei > Sent: Tuesday, October 10, 2017 10:56 AM > To: Yigit, Ferruh ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v7 2/2] app/testpmd: add API for > configuration of queue region > > Hi, > > > -Original Message- > > From: Yigit, Ferr

Re: [dpdk-dev] [PATCH v7 2/2] app/testpmd: add API for configuration of queue region

2017-10-09 Thread Zhao1, Wei
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, October 4, 2017 2:04 AM > To: Zhao1, Wei ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/testpmd: add API for > configuration of queue region > > On 9/29/2017 10:16 AM, Wei Zhao wrote: > > This patch add a API

Re: [dpdk-dev] [PATCH] doc: virtio lsc hint

2017-10-09 Thread Yuanhan Liu
On Mon, Oct 09, 2017 at 11:56:16AM +0800, Zhiyong Yang wrote: > Virtio PMD has already the ability to support link status change(lsc), > but qemu 2.7.0 introduce the capability to detect vhost user > disconnection. So, virtio PMD which works with qemu 2.7.0 and above > can receive lsc when vhost us

Re: [dpdk-dev] [PATCH 0/2] Vhost-user IOMMU support pull-request fixes

2017-10-09 Thread Yuanhan Liu
On Mon, Oct 09, 2017 at 02:07:32PM +0200, Maxime Coquelin wrote: > Hi Yuanhan, > > As discussed, please find the 32bits compilation fixes. That's handy. Applied. Thanks. --yliu > > Regards, > Maxime > > Maxime Coquelin (2): > fixup! vhost-user: iommu: postpone device creation until

Re: [dpdk-dev] [PATCH v7 2/2] app/testpmd: add API for configuration of queue region

2017-10-09 Thread Zhao1, Wei
HI, Ferruh I will rework code as your comments in v8. > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, October 4, 2017 2:04 AM > To: Zhao1, Wei ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/testpmd: add API for > configuration of queue region > > On 9/29/20

Re: [dpdk-dev] [PATCH v7 1/2] net/i40e: queue region set and flush

2017-10-09 Thread Zhao1, Wei
HI, jingjing I will rework code as your comments in v8. > -Original Message- > From: Wu, Jingjing > Sent: Friday, September 29, 2017 8:23 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH v7 1/2] net/i40e: queue region set and flush > > > > + /*

Re: [dpdk-dev] Can xenvirt pmd work in xen guest (aka DomU) without xen-vhost in Dom0 ?

2017-10-09 Thread Tan, Jianfeng
for me, the most important thing at the moment, is to run our system on xen guest (aka DomU), with the full functions. the performance could be a secondary consideration. most of time, for our guests, full functions, with the acceptable performance, is fine. do we have plan to support xen net

Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD

2017-10-09 Thread Zhang, Qi Z
Hi Konstantin: > -Original Message- > From: Ananyev, Konstantin > Sent: Monday, October 9, 2017 8:44 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix unexpected mbuf free in vPMD > > Hi

Re: [dpdk-dev] [PATCH v4 00/16] add net mrvl pmd driver

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 9:59 PM, Ferruh Yigit wrote: > On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: >> Hello, >> >> This patch series introduces the net driver for Marvell Armada 7k/8k >> SoCs along with documentation. >> >> Below you can find the list of features which net pmd supports: >> * Speed capabilit

Re: [dpdk-dev] [PATCH 1/2] ethdev: add return value to stats get dev op

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 5:12 PM, Matan Azrad wrote: > The stats_get dev op API doesn't include return value, so PMD cannot > return an error in case of failure at stats getting process time. > > Since PCI devices can be removed and there is a time between the > physical removal to the RMV interrupt, the user

Re: [dpdk-dev] [PATCH v2] doc: add use of mlockall to programmers guide

2017-10-09 Thread Ferruh Yigit
On 10/2/2017 11:11 AM, Mcnamara, John wrote: > > >> -Original Message- >> From: Eelco Chaudron [mailto:echau...@redhat.com] >> Sent: Monday, October 2, 2017 11:02 AM >> To: Mcnamara, John >> Cc: dev@dpdk.org >> Subject: [PATCH v2] doc: add use of mlockall to programmers guide >> >> When

Re: [dpdk-dev] [PATCH v2] app/testpmd: adds mlockall() to avoid pages being swapped out

2017-10-09 Thread Ferruh Yigit
On 9/29/2017 9:11 AM, Eelco Chaudron wrote: > v2: > * Moved mlockall() after rte_eal_init() to allow rte_log() to be used > * Check for mlockall() return value, and add an rte_log() > > Call the mlockall() function, to attempt to lock all of its process > memory into physical RAM, and preventing t

Re: [dpdk-dev] [PATCH] ethdev: increase length device internal name

2017-10-09 Thread Ferruh Yigit
On 10/10/2017 12:12 AM, Ferruh Yigit wrote: > On 9/27/2017 10:23 AM, Stephen Hemminger wrote: >> Allow sufficicent space for UUID in string form (36+1). >> Needed to use UUID with Hyper-V. This was in deprecation notice >> for previous release and make it so in 17.11. >> >> Signed-off-by: Stephen H

Re: [dpdk-dev] [PATCH] ethdev: increase length device internal name

2017-10-09 Thread Ferruh Yigit
On 9/27/2017 10:23 AM, Stephen Hemminger wrote: > Allow sufficicent space for UUID in string form (36+1). > Needed to use UUID with Hyper-V. This was in deprecation notice > for previous release and make it so in 17.11. > > Signed-off-by: Stephen Hemminger Except from below note, Reviewed-by: Fe

Re: [dpdk-dev] [PATCH v6] ethdev: add return code to rte_eth_stats_reset()

2017-10-09 Thread Ferruh Yigit
On 9/20/2017 5:56 PM, Ferruh Yigit wrote: > On 9/20/2017 3:11 PM, David C Harton wrote: >> From: David Harton >> >> Some devices do not support reset of eth stats. An application may >> need to know not to clear shadow stats if the device cannot. >> >> rte_eth_stats_reset is updated to provide a

Re: [dpdk-dev] [PATCH] ethdev: fix the comment for rte_eth_conf.

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 11:38 PM, Ferruh Yigit wrote: > On 9/19/2017 6:24 AM, Tonghao Zhang wrote: >> We have change the type of rx_adv_conf, so change the >> comment for it. >> >> Signed-off-by: Tonghao Zhang > > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] ethdev: fix the comment for rte_eth_conf.

2017-10-09 Thread Ferruh Yigit
On 9/19/2017 6:24 AM, Tonghao Zhang wrote: > We have change the type of rx_adv_conf, so change the > comment for it. > > Signed-off-by: Tonghao Zhang Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v8 0/9] Policy Based Power Control for Guest

2017-10-09 Thread Ferruh Yigit
On 10/5/2017 3:34 PM, David Hunt wrote: > Policy Based Power Control for Guest > > This patchset adds the facility for a guest VM to send a policy down to the > host that will allow the host to scale up/down cpu frequencies > depending on the policy criteria independently of the DPDK app running i

[dpdk-dev] [PATCH v3] kni: fix build on SLE12 SP3

2017-10-09 Thread Ferruh Yigit
From: Nirmoy Das compilation error: build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error: ‘struct net_device’ has no member named ‘trans_start’ dev->trans_start = jiffies; Signed-off-by: Nirmoy Das Signed-off-by: Ferruh Yigit --- lib/librte_eal/linuxapp/kni/compat.h | 31 +++

Re: [dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for masking MSI-X

2017-10-09 Thread Patrick MacArthur
Hi, Markus, This commit appears to cause a regression on CentOS 7.4 with the in-box Linux 3.10.0-639-2.2.el7.x86_64 kernel. Although the kernel module appears to build correctly, when I attempt to load the module with insmod, it fails and I see the following errors in dmesg: [620323.805125]

Re: [dpdk-dev] [PATCH] eal: Copy raw strings taken from command line

2017-10-09 Thread Thomas Monjalon
04/09/2017 12:12, Sergio Gonzalez Monroy: > On 04/08/2017 19:53, Patrick MacArthur wrote: > > Normally, command line argument strings are considered immutable, but > > SPDK [1] and urdma [2] construct argv arrays to pass to rte_eal_init(). > > These strings are allocated using malloc() and freed af

Re: [dpdk-dev] [PATCH v3] eal/linuxapp: check mmap return value MAP_FAILED

2017-10-09 Thread Thomas Monjalon
29/08/2017 10:31, Sergio Gonzalez Monroy: > On 28/08/2017 22:49, Seth Howell wrote: > > If mmap fails, it will return the value MAP_FAILED. Checking for this > > return code allows us to properly identify mmap failures and report > > them as such to the calling function. > > > > Signed-off-by: Seth

Re: [dpdk-dev] [PATCH 2/2] doc: update stats get API change

2017-10-09 Thread Thomas Monjalon
09/10/2017 18:12, Matan Azrad: > Updated change info in release_17.11. > > Signed-off-by: Matan Azrad > --- > doc/guides/rel_notes/release_17_11.rst | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/doc/guides/rel_notes/release_17_11.rst > b/doc/guides/rel_notes/r

Re: [dpdk-dev] [PATCH v2] eal: add config option to enable asserts

2017-10-09 Thread Thomas Monjalon
24/08/2017 10:23, Xueming Li: > Currently, enabling assertion have to set CONFIG_RTE_LOG_LEVEL to > RTE_LOG_DEBUG. CONFIG_RTE_LOG_LEVEL is the default log level of control > path, RTE_LOG_DP_LEVEL is the log level of data path. It's a little bit > hard to understand literally that assertion is deci

Re: [dpdk-dev] [PATCH v4 00/16] add net mrvl pmd driver

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: > Hello, > > This patch series introduces the net driver for Marvell Armada 7k/8k > SoCs along with documentation. > > Below you can find the list of features which net pmd supports: > * Speed capabilities > * Link status > * MTU update > * Jumbo fram

Re: [dpdk-dev] [PATCH v3 2/2] eal/malloc: fix RTE malloc element free

2017-10-09 Thread Thomas Monjalon
13/09/2017 14:06, Sergio Gonzalez Monroy: > On 09/09/2017 08:33, Xueming Li wrote: > > malloc_elem_free() is clearing(setting to 0) the trailer cookie when > > RTE_MALLOC_DEBUG is enabled. In case of joining free neighbor element, > > part of joined memory is not getting cleared due to missing the

Re: [dpdk-dev] [PATCH v4 16/16] doc: add mrvl net pmd documentation

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: > Add documentation for the MRVL NET PMD driver. > > Signed-off-by: Jacek Siuda > Signed-off-by: Tomasz Duszynski I guess this should be "Tomasz Duszynski " :) Fixing accordingly while applying. <...>

Re: [dpdk-dev] [RFC PATCH v2 0/1] eventtimer: introduce event timer adapter

2017-10-09 Thread Carrillo, Erik G
> > > > The second big change is to replace API parameters specifying pointer > > to rte_event_timer_adapter with ids, which seems more common > > throughout DPDK. > > > > Other changes include: > > - removed rte_event_timer_adapter_lookup() function, since APIs no > longer > >accept pointer t

Re: [dpdk-dev] [PATCH v7 1/5] net/softnic: add softnic PMD

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 1:58 PM, Jasvinder Singh wrote: > Add SoftNIC PMD to provide SW fall-back for ethdev APIs. > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Jasvinder Singh > > Acked-by: Cristian Dumitrescu > Acked-by: Thomas Monjalon <...> > --- a/doc/guides/rel_notes/release_17_11.rst

Re: [dpdk-dev] [PATCH v7 5/5] app/testpmd: add traffic management forwarding mode

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 1:58 PM, Jasvinder Singh wrote: > This commit extends the testpmd application with new forwarding engine > that demonstrates the use of ethdev traffic management APIs and softnic > PMD for QoS traffic management. > > In this mode, 5-level hierarchical tree of the QoS scheduler is buil

Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail

2017-10-09 Thread Thomas Monjalon
09/10/2017 20:21, Don Provan: > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > >... > > This is where I have disagreement/doubt. > > Reporting error code from rte_bus_scan would do two things: > > > > 1. rte_eal_init is not designed to ignore/log-only these errors - it > > would quit initi

Re: [dpdk-dev] [PATCH v7 3/3] net/mlx5: add Rx HW timestamp

2017-10-09 Thread Ferruh Yigit
On 10/8/2017 9:24 AM, Raslan Darawsheh wrote: > Expose Rx HW timestamp to packet mbufs. > > Signed-off-by: Raslan Darawsheh > --- > Changes in v7: > - Rebasing the work on top ot c814b93b ("net/mlx5: add vectorized Rx/Tx burst > for ARM") Hi Raslan, Since dependent patches merged into next-net

Re: [dpdk-dev] [PATCH v4 15/16] maintainers: add maintainers for the mrvl net pmd

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 8:09 PM, Marcin Wojtas wrote: > 2017-10-09 21:02 GMT+02:00 Ferruh Yigit : >> On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: >>> Signed-off-by: Jacek Siuda >>> Signed-off-by: Tomasz Duszynski >> >> Congratulations!, >> >> this is the 3. patch in patchwork: >> http://dpdk.org/dev/pa

Re: [dpdk-dev] [PATCH v2 0/7] net/mlx5: add vectorized Rx/Tx burst for ARM

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 7:46 PM, Yongseok Koh wrote: > Add dataplane functions using ARM NEON instructions. To modularize vectorized > functions for different architectures, the existing files having x86 SSE > support > is reorganized. > > Yongseok Koh (7): > net/mlx5: cleanup memory barriers > net/mlx5

Re: [dpdk-dev] [PATCH v4 15/16] maintainers: add maintainers for the mrvl net pmd

2017-10-09 Thread Marcin Wojtas
2017-10-09 21:02 GMT+02:00 Ferruh Yigit : > On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: >> Signed-off-by: Jacek Siuda >> Signed-off-by: Tomasz Duszynski > > Congratulations!, > > this is the 3. patch in patchwork: > http://dpdk.org/dev/patchwork/patch/3/ There's no other option now, bu

Re: [dpdk-dev] [PATCH v4 15/16] maintainers: add maintainers for the mrvl net pmd

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 4:00 PM, Tomasz Duszynski wrote: > Signed-off-by: Jacek Siuda > Signed-off-by: Tomasz Duszynski Congratulations!, this is the 3. patch in patchwork: http://dpdk.org/dev/patchwork/patch/3/ 2 was here: http://dpdk.org/ml/archives/dev/2017-January/056354.html 10K patches

[dpdk-dev] [PATCH v6 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit

2017-10-09 Thread Jasvinder Singh
Add following CLIs in testpmd application for device traffic management; - commands to add TM hierarchy nodes (leaf and nonleaf). - command for runtime update of node weight. - command to commit the TM hierarchy Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- v5 change: - add sh

[dpdk-dev] [PATCH v6 1/3] app/test-pmd: add CLI for TM capability and stats

2017-10-09 Thread Jasvinder Singh
Add following CLIs to testpmd application for device traffic management; - commands to display TM capability information. (per port, per hierarchy level and per hierarchy node) - command to display hiearchy node type - stats collection Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitresc

[dpdk-dev] [PATCH v6 2/3] app/test-pmd: add CLI for shaper and wred profiles

2017-10-09 Thread Jasvinder Singh
Add following CLIs in testpmd application for device traffic management; - commands to add/del shaper profile for TM hieraqrchy nodes. - commands to add/update shared shapers - commands to add/del WRED profiles for TM hiearchy leaf nodes. Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitres

[dpdk-dev] [PATCH v2 5/7] net/mlx5: match Rx completion entry size to cacheline

2017-10-09 Thread Yongseok Koh
The size of Rx completion entry should match the size of a cacheline. This is already reflected in struct mlx5_cqe by adding 64bytes padding if a cacheline is 128bytes. Some ARM CPUs have 128bytes cacheline. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 3 +++ 1 file changed, 3 inser

[dpdk-dev] [PATCH v2 7/7] net/mlx5: add vectorized Rx/Tx burst for ARM

2017-10-09 Thread Yongseok Koh
Brings vectorization through NEON instructions. Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/Makefile |3 +- drivers/net/mlx5/mlx5_rxtx_vec.c |4 +- drivers/net/mlx5/mlx5_rxtx_vec.h |4 + drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 10

[dpdk-dev] [PATCH v2 6/7] net/mlx5: fix configuration of Rx CQE compression

2017-10-09 Thread Yongseok Koh
With the upstream rdma-core, to enable Rx CQE compression, mlx5dv_create_cq() in Direct Verbs has to be used instead of regular Verbs call (ibv_create_cq()). And if the size of CQE is 128 bytes, compression is supported only by certain devices. Thus, it has to be decided by checking the capabilitiy

[dpdk-dev] [PATCH v2 4/7] net/mlx5: separate shareable vector functions

2017-10-09 Thread Yongseok Koh
Considering more architecture (e.g. ARM and PowerPC) will be added for vectorized Rx/Tx burst, all the shareable functions which don't use any vector instrinsics need to be separated from architecture-dependent functions. All the vector functions for x86 SSE are moved to a new header file - mlx5_rx

[dpdk-dev] [PATCH v2 3/7] net/mlx5: use static assert for compile-time sanity checks

2017-10-09 Thread Yongseok Koh
Replace compile-time sanity check with static_assert() as c11 standard has been set. Add mlx5_rxtx_vec.h and move the sanity checks to the file. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx_vec.c | 32 +-- drivers/net/mlx5/mlx5_rxtx_vec.h | 87 ++

[dpdk-dev] [PATCH v2 2/7] net/mlx5: rename a file of SSE Rx/Tx

2017-10-09 Thread Yongseok Koh
Rename mlx5_rxtx_vec_sse.c to mlx5_rxtx_vec.c to separate shareable vector functions. Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/Makefile | 2 +- drivers/net/mlx5/{mlx5_rxtx_vec_sse.c => mlx5_rxtx_vec.c} | 0 2 files changed, 1 in

[dpdk-dev] [PATCH v2 1/7] net/mlx5: cleanup memory barriers

2017-10-09 Thread Yongseok Koh
Updating a consumer index to HW doesn't require a memory barrier in case that there's no updated data to be posted to HW, but a compiler barrier is sufficient. rte_wmb() is replaced with rte_io_wmb() when it makes changes visible to HW, not other core. Signed-off-by: Yongseok Koh Acked-by: Shahaf

[dpdk-dev] [PATCH v2 0/7] net/mlx5: add vectorized Rx/Tx burst for ARM

2017-10-09 Thread Yongseok Koh
Add dataplane functions using ARM NEON instructions. To modularize vectorized functions for different architectures, the existing files having x86 SSE support is reorganized. Yongseok Koh (7): net/mlx5: cleanup memory barriers net/mlx5: rename a file of SSE Rx/Tx net/mlx5: use static assert

Re: [dpdk-dev] [PATCH v3 00/30] net/mlx5: cleanup for isolated mode

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 6:17 PM, Yongseok Koh wrote: > >> On Oct 9, 2017, at 7:44 AM, Nelio Laranjeiro >> wrote: >> >> This series cleanups the control plane part and the way it uses the different >> kind of objects (DPDK queues, Verbs Queues, ...). It has three goals: >> >> 1. Reduce the memory usage by

Re: [dpdk-dev] [PATCH v2 12/30] net/mlx5: add reference counter on DPDK Tx queues

2017-10-09 Thread Ferruh Yigit
On 10/5/2017 1:49 PM, Nelio Laranjeiro wrote: > Use the same design for DPDK queue as for Verbs queue for symmetry, this > also helps in fixing some issues like the DPDK release queue API which is > not expected to fail. With such design, the queue is released when the > reference counters reaches

Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail

2017-10-09 Thread Don Provan
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Monday, October 09, 2017 4:10 AM > To: Jan Blunck ; Thomas Monjalon > > Cc: dev ; Hemant Agrawal > Subject: Re: [dpdk-dev] [PATCH] eal: bus scan and probe never fail > >... > This is where I have disagree

Re: [dpdk-dev] [PATCH v1 0/7] net/mlx5: add vectorized Rx/Tx burst for ARM

2017-10-09 Thread Olga Shern
> > > > next-net-mlx sound like good idea :) Any comment on this? > I agree on your idea! > Yes, Ferruh, let's do it for the next release Best Regards, Olga

Re: [dpdk-dev] [PATCH v7 1/3] eal/x86: run-time dispatch over memcpy

2017-10-09 Thread Thomas Monjalon
05/10/2017 14:33, Xiaoyun Li: > +/** > + * Macro for copying unaligned block from one location to another with > constant load offset, > + * 47 bytes leftover maximum, > + * locations should not overlap. > + * Requirements: > + * - Store is aligned > + * - Load offset is , which must be immediate

Re: [dpdk-dev] [PATCH] app/testpmd: fix compilation with I40E disabled

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 3:38 PM, Kirill Rybalchenko wrote: > Precompiler instructions #ifdef RTE_LIBRTE_I40E_PMD ... #endif > were not placed correctly, which caused number of > compilation errors if I40E PMD is disabled. > > Fixes: 5a4806d304e0 ("app/testpmd: support updating pctype mapping") > > Signed-of

Re: [dpdk-dev] [PATCH v1 0/7] net/mlx5: add vectorized Rx/Tx burst for ARM

2017-10-09 Thread Yongseok Koh
On Mon, Oct 09, 2017 at 03:39:47AM +0100, Ferruh Yigit wrote: > On 10/6/2017 12:00 AM, Yongseok Koh wrote: > > Add dataplane functions using ARM NEON instructions. To modularize > > vectorized > > functions for different architectures, the existing files having x86 SSE > > support > > is reorgani

Re: [dpdk-dev] [PATCH v7 0/3] run-time Linking support

2017-10-09 Thread Thomas Monjalon
Hi, 05/10/2017 14:33, Xiaoyun Li: > create mode 100644 lib/librte_eal/common/include/arch/x86/rte_memcpy.c > create mode 100644 lib/librte_eal/common/include/arch/x86/rte_memcpy_avx2.c > create mode 100644 > lib/librte_eal/common/include/arch/x86/rte_memcpy_avx512f.c > create mode 100644 > l

Re: [dpdk-dev] [PATCH] net/bnxt: fix compilation

2017-10-09 Thread Ferruh Yigit
On 10/9/2017 2:59 PM, Mark Kavanagh wrote: > As of 5ef3b79fdfe6f, compilation of DPDK fails with the following > error message: > "bnxt_filter.c:960:117: error: ‘vnic’ may be used uninitialized in this > function [-Werror=maybe-uninitialized]". > > Resolve this by initializing 'vnic' to NULL; > >

Re: [dpdk-dev] [PATCH] lib/lib_eal:add mellanox kernel driver type

2017-10-09 Thread Thomas Monjalon
23/08/2017 10:04, Gaëtan Rivet: > Hi, > > On Wed, Aug 23, 2017 at 10:48:01AM +0800, Rongqiang XIE wrote: > > When use bond function in mellanox driver environment, we call the > > find_port_id_by_pci_addr() function,if we don't add mellanox kernel > > driver type in enum rte_kernel_driver, the fun

Re: [dpdk-dev] [PATCH v3 00/30] net/mlx5: cleanup for isolated mode

2017-10-09 Thread Yongseok Koh
> On Oct 9, 2017, at 7:44 AM, Nelio Laranjeiro > wrote: > > This series cleanups the control plane part and the way it uses the different > kind of objects (DPDK queues, Verbs Queues, ...). It has three goals: > > 1. Reduce the memory usage by sharing all possible objects. > > 2. Leave the c

Re: [dpdk-dev] How to update the sequence number in TCP packets using DPDK-pktgen?

2017-10-09 Thread Wiles, Keith
> On Oct 9, 2017, at 8:42 AM, Shailja Pandey wrote: > > Hi, > > In the DPDK application, I am maintaining some state and due to that I need > to generate the packets with monotonically increasing sequence numbers. As > shown in the code below, > > /tip->tcp.seq= htonl(DEFAULT_PKT_NU

Re: [dpdk-dev] [PATCH v5 2/2] doc: add new introduction to sample app guides

2017-10-09 Thread Mcnamara, John
> -Original Message- > From: Kovacevic, Marko > Sent: Monday, October 9, 2017 5:19 PM > To: Mcnamara, John > Cc: dev@dpdk.org; Kovacevic, Marko > Subject: [PATCH v5 2/2] doc: add new introduction to sample app guides > > Add new Introduction Section into the sample app guides. > > Sig

Re: [dpdk-dev] [PATCH v5 1/2] doc: add generic compilation doc for all sample apps

2017-10-09 Thread Mcnamara, John
> -Original Message- > From: Kovacevic, Marko > Sent: Monday, October 9, 2017 5:19 PM > To: Mcnamara, John > Cc: dev@dpdk.org; Kovacevic, Marko ; Herakliusz > Lipiec > Subject: [PATCH v5 1/2] doc: add generic compilation doc for all sample > apps > > From: Herakliusz Lipiec > > Moved

Re: [dpdk-dev] Can xenvirt pmd work in xen guest (aka DomU) without xen-vhost in Dom0 ?

2017-10-09 Thread Bill Bonaparte
On Mon, Oct 9, 2017 at 12:13 AM, Tan, Jianfeng wrote: > Hi, > > On 10/8/2017 12:54 PM, Bill Bonaparte wrote: > > Thanks Jianfeng for taking time to reply. > > please allow me to briefly explain why I want to run dpdk on xen. > our system is based on dpdk, which means we use dpdk as packet > recei

[dpdk-dev] [PATCH v5 1/2] doc: add generic compilation doc for all sample apps

2017-10-09 Thread Marko Kovacevic
From: Herakliusz Lipiec Moved duplicated, and occasionally outdated, doc sections from each of the sample app guides chapters to a common chapter at the start. This reduces the duplication in the docs and provides a single point of reference for compiling the sample apps. Signed-off-by: Herakli

[dpdk-dev] [PATCH v5 2/2] doc: add new introduction to sample app guides

2017-10-09 Thread Marko Kovacevic
Add new Introduction Section into the sample app guides. Signed-off-by: Marko Kovacevic Reviewed-by: John McNamara --- v5: All changes to your comments have been dealt with (John) doc/guides/faq/faq.rst | 2 +- doc/guides/sample_app_ug/dist_app.rst

[dpdk-dev] [PATCH 2/2] doc: update stats get API change

2017-10-09 Thread Matan Azrad
Updated change info in release_17.11. Signed-off-by: Matan Azrad --- doc/guides/rel_notes/release_17_11.rst | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst index 36139e5..b62083d 100644 --

[dpdk-dev] [PATCH 1/2] ethdev: add return value to stats get dev op

2017-10-09 Thread Matan Azrad
The stats_get dev op API doesn't include return value, so PMD cannot return an error in case of failure at stats getting process time. Since PCI devices can be removed and there is a time between the physical removal to the RMV interrupt, the user may get invalid stats without any indication. Thi

Re: [dpdk-dev] [PATCH] Sort list of entries in examples.dox

2017-10-09 Thread Luca Boccassi
On Mon, 2017-10-09 at 16:36 +0200, Bernhard M. Wiedemann wrote: > On 2017-10-09 15:51, Luca Boccassi wrote: > > If you are interested in reproducible builds please have a look at > > this > > patch series I submitted a while ago: > > > > http://dpdk.org/dev/patchwork/patch/28386/ > > > > I have v

Re: [dpdk-dev] [PATCH v5 0/4] Introducing NXP dpaa_sec based cryptodev pmd

2017-10-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: akhil.go...@nxp.com [mailto:akhil.go...@nxp.com] > Sent: Monday, October 9, 2017 3:22 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; Mcnamara, > John > Subject: [PATCH v5 0/4] Introducing NXP dpaa_sec based cry

[dpdk-dev] [PATCH v4 01/16] app: link the whole rte_cfgfile library

2017-10-09 Thread Tomasz Duszynski
MRVL net pmd needs rte_cfgfile to parse QoS configuration file thus librte_pmd_mrvl.a contains undefined symbols from librte_cfgfile.a. As a result linking applications under app/ directory will fail because librte_cfgfile.a comes before librte_pmd_mrvl.a during the linking stage. Linking the who

[dpdk-dev] [PATCH v4 16/16] doc: add mrvl net pmd documentation

2017-10-09 Thread Tomasz Duszynski
Add documentation for the MRVL NET PMD driver. Signed-off-by: Jacek Siuda Signed-off-by: Tomasz Duszynski --- doc/guides/nics/features/mrvl.ini | 2 + doc/guides/nics/index.rst | 1 + doc/guides/nics/mrvl.rst | 256 ++ 3 files changed, 25

[dpdk-dev] [PATCH v4 15/16] maintainers: add maintainers for the mrvl net pmd

2017-10-09 Thread Tomasz Duszynski
Signed-off-by: Jacek Siuda Signed-off-by: Tomasz Duszynski --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1b74f98..5c78477 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -392,6 +392,16 @@ F: drivers/net/mlx5/ F: doc/guides/nics/mlx

[dpdk-dev] [PATCH v4 14/16] net/mrvl: add basic stats support

2017-10-09 Thread Tomasz Duszynski
Add support for both per queue and overall basic statistics. Signed-off-by: Jacek Siuda Signed-off-by: Tomasz Duszynski --- doc/guides/nics/features/mrvl.ini | 1 + drivers/net/mrvl/mrvl_ethdev.c| 142 +- 2 files changed, 142 insertions(+), 1 deletion(-

[dpdk-dev] [PATCH v4 13/16] net/mrvl: add packet type parsing support.

2017-10-09 Thread Tomasz Duszynski
Add packet type parsing support. Signed-off-by: Jacek Siuda Signed-off-by: Tomasz Duszynski --- doc/guides/nics/features/mrvl.ini | 1 + drivers/net/mrvl/mrvl_ethdev.c| 28 2 files changed, 29 insertions(+) diff --git a/doc/guides/nics/features/mrvl.ini b/doc

[dpdk-dev] [PATCH v4 12/16] net/mrvl: add crc, l3 and l4 offloads support

2017-10-09 Thread Tomasz Duszynski
Add support for crc offload and l3/l4 checksum offloads. Signed-off-by: Jacek Siuda Signed-off-by: Tomasz Duszynski --- doc/guides/nics/features/mrvl.ini | 3 + drivers/net/mrvl/mrvl_ethdev.c| 204 +- 2 files changed, 205 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH v4 11/16] net/mrvl: add support for vlan filtering

2017-10-09 Thread Tomasz Duszynski
Add support for vlan filtering. Signed-off-by: Jacek Siuda Signed-off-by: Tomasz Duszynski --- doc/guides/nics/features/mrvl.ini | 1 + drivers/net/mrvl/mrvl_ethdev.c| 39 ++- drivers/net/mrvl/mrvl_ethdev.h| 1 + 3 files changed, 40 insertions(+), 1

[dpdk-dev] [PATCH v4 10/16] net/mrvl: add rss hashing support

2017-10-09 Thread Tomasz Duszynski
Add support for rss hashing on rx. Signed-off-by: Jacek Siuda Signed-off-by: Tomasz Duszynski --- doc/guides/nics/features/mrvl.ini | 1 + drivers/net/mrvl/mrvl_ethdev.c| 116 +- drivers/net/mrvl/mrvl_ethdev.h| 1 + 3 files changed, 115 insertions

[dpdk-dev] [PATCH v4 09/16] net/mrvl: add support for mac filtering

2017-10-09 Thread Tomasz Duszynski
Add support for unicast and multicast mac filters. Signed-off-by: Jacek Siuda Signed-off-by: Tomasz Duszynski --- doc/guides/nics/features/mrvl.ini | 2 + drivers/net/mrvl/mrvl_ethdev.c| 95 ++- drivers/net/mrvl/mrvl_ethdev.h| 1 + 3 files changed,

[dpdk-dev] [PATCH v4 08/16] net/mrvl: add support for promiscuous and allmulticast modes

2017-10-09 Thread Tomasz Duszynski
Add support for promiscuous and allmulticast modes. Signed-off-by: Jacek Siuda Signed-off-by: Tomasz Duszynski --- doc/guides/nics/features/mrvl.ini | 2 ++ drivers/net/mrvl/mrvl_ethdev.c| 72 +++ 2 files changed, 74 insertions(+) diff --git a/doc/guide

  1   2   3   >