Re: [dpdk-dev] [PATCH v5 1/3] ethdev: add Rx HW timestamp capability

2017-10-02 Thread Yongseok Koh
> On Oct 2, 2017, at 11:40 PM, Andrew Rybchenko > wrote: > > On 10/03/2017 09:33 AM, Raslan Darawsheh wrote: >> Add a new offload capability flag for Rx HW >> timestamp and enabling/disabling this via rte_eth_rxmode. >> >> Signed-off-by: Raslan Darawsheh >> >> >> --- >> This patch should be

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: add Rx HW timestamp capability

2017-10-02 Thread Andrew Rybchenko
On 10/03/2017 09:33 AM, Raslan Darawsheh wrote: Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh --- This patch should be applied after after this series: http://dpdk.org/dev/patchwork/patch/29368/ --- doc/gu

[dpdk-dev] [PATCH v5 3/3] net/mlx5: add Rx HW timestamp

2017-10-02 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rxq.c | 6 +- drivers/net/mlx5/mlx5_rxtx.c | 5 + drivers/net/mlx5/mlx5_rxtx.h | 3 ++- drivers/net/mlx5/mlx5_rxtx_

[dpdk-dev] [PATCH v5 1/3] ethdev: add Rx HW timestamp capability

2017-10-02 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh --- This patch should be applied after after this series: http://dpdk.org/dev/patchwork/patch/29368/ --- doc/guides/nics/features.rst | 11 +++ lib/librt

[dpdk-dev] [PATCH v5 2/3] app/testpmd: add Rx HW timestamp

2017-10-02 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2 ++ app/test-pmd/testpmd.c

Re: [dpdk-dev] [PATCH v2 2/4] net/mrvl: add mrvl net pmd driver

2017-10-02 Thread Tomasz Duszynski
On Mon, Oct 02, 2017 at 12:08:39PM +0100, Bruce Richardson wrote: > On Fri, Sep 29, 2017 at 08:38:00AM -0700, Stephen Hemminger wrote: > > On Thu, 28 Sep 2017 12:22:36 +0200 > > Tomasz Duszynski wrote: > > > > > + > > > +struct mrvl_rxq; > > > +struct mrvl_txq; > > > > These forward decl should no

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: introduce Rx queue offloads API

2017-10-02 Thread Shahaf Shuler
Hi Ferruh, Tuesday, October 3, 2017 3:32 AM, Ferruh Yigit: > On 9/28/2017 7:54 PM, Shahaf Shuler wrote: > > Introduce a new API to configure Rx offloads. > > > > In the new API, offloads are divided into per-port and per-queue > > offloads. The PMD reports capability for each of them. > > Offloads

Re: [dpdk-dev] [PATCH v2 2/4] net/mrvl: add mrvl net pmd driver

2017-10-02 Thread Tomasz Duszynski
On Fri, Sep 29, 2017 at 08:38:00AM -0700, Stephen Hemminger wrote: > On Thu, 28 Sep 2017 12:22:36 +0200 > Tomasz Duszynski wrote: > > > + > > +struct mrvl_rxq; > > +struct mrvl_txq; > > These forward decl should not be nececessary ACK > > +static inline int > > +mrvl_get_bpool_size(intpp2_id,

[dpdk-dev] DPDK 1705 on libpcap drivers has drops?

2017-10-02 Thread Kuusisaari, Juhamatti
Hello, We are testing on 1705 over libpcap driver and unfortunately we are seeing surprisingly large drops. They are seen with low rate/ping randomly and with high rate the throughput is very limited (even 30 % drops seen) compared to our reference system on DPDK 1.7.1. The only thing changed

[dpdk-dev] [PATCH v5 6/7] test/member: add functional and perf tests

2017-10-02 Thread Yipeng Wang
This patch adds functional and performance tests for membership library. Signed-off-by: Yipeng Wang --- MAINTAINERS | 1 + test/test/Makefile | 3 + test/test/test_member.c | 744 +++ test/test/test_member_perf.c | 654 +

[dpdk-dev] [PATCH v5 5/7] member: enable the library

2017-10-02 Thread Yipeng Wang
This patch enables the Membership library. Signed-off-by: Yipeng Wang --- MAINTAINERS| 6 +- config/common_base | 5 + lib/librte_member/Makefile | 2 ++ mk/rte.app.mk | 2 ++ 4 files changed, 14 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS

[dpdk-dev] [PATCH v5 3/7] member: implement vBF mode

2017-10-02 Thread Yipeng Wang
Bloom Filter (BF) [1] is a well-known space-efficient probabilistic data structure that answers set membership queries. Vector of Bloom Filters (vBF) is an extension to traditional BF that supports multi-set membership testing. Traditional BF will return found or not-found for each key. vBF will al

[dpdk-dev] [PATCH v5 4/7] member: add AVX for HT mode

2017-10-02 Thread Yipeng Wang
For key search, the signatures of all entries are compared against the signature of the key that is being looked up. Since all signatures are contiguously put in a bucket, they can be compared with vector instructions (AVX2), achieving higher lookup performance. This patch adds AVX2 implementation

[dpdk-dev] [PATCH v5 1/7] member: implement main API

2017-10-02 Thread Yipeng Wang
Membership library is an extension and generalization of a traditional filter (for example Bloom Filter and cuckoo filter) structure. In general, the Membership library is a data structure that provides a "set-summary" and responds to set-membership queries of whether a certain element belongs to a

[dpdk-dev] [PATCH v5 2/7] member: implement HT mode

2017-10-02 Thread Yipeng Wang
One of the set-summary structures is hash-table based set-summary (HTSS). One example is cuckoo filter [1]. Comparing to a traditional hash table, HTSS has a much more compact structure. For each element, only one signature and its corresponding set ID is stored. No key comparison is required duri

[dpdk-dev] [PATCH v5 0/7] Add Membership Library

2017-10-02 Thread Yipeng Wang
DPDK Membership Library provides an API that can be used by many DPDK applications to conduct one or more set-membership tests (we mention some possible use cases below, but interested readers can refer to [1] for a wider survey of use cases). The basic functionalities of the Membership Library in

Re: [dpdk-dev] [PATCH v4 3/7] member: implement vBF mode

2017-10-02 Thread Wang, Yipeng1
Please see one comment inlined: > -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, October 2, 2017 8:44 AM > To: Wang, Yipeng1 ; dev@dpdk.org > Cc: tho...@monjalon.net; Tai, Charlie ; Gobriel, > Sameh ; Mcnamara, John > > Subject: RE: [PATCH v4 3/7] member: implement vBF m

Re: [dpdk-dev] [PATCH v4 2/7] member: implement HT mode

2017-10-02 Thread Wang, Yipeng1
Thank you very much Pablo. I agree with you on most of your comments and I will address them soon. But please find some explanations inlined for certain questions you raised. > -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, October 2, 2017 6:31 AM > To: Wang, Yipeng1 ;

Re: [dpdk-dev] [PATCH 1/3] ethdev: add Rx HW timestamp capability

2017-10-02 Thread Yongseok Koh
> On Oct 2, 2017, at 11:48 AM, Ferruh Yigit wrote: > > On 10/2/2017 3:50 PM, Raslan Darawsheh wrote: >> Add a new offload capability flag for Rx HW >> timestamp and enabling/disabling this via rte_eth_rxmode. >> >> Signed-off-by: Raslan Darawsheh >> Acked-by: Yongseok Koh > > Hi Raslan, > >

Re: [dpdk-dev] [PATCH v5 1/3] ethdev: introduce Rx queue offloads API

2017-10-02 Thread Ferruh Yigit
On 9/28/2017 7:54 PM, Shahaf Shuler wrote: > Introduce a new API to configure Rx offloads. > > In the new API, offloads are divided into per-port and per-queue > offloads. The PMD reports capability for each of them. > Offloads are enabled using the existing DEV_RX_OFFLOAD_* flags. > To enable per

[dpdk-dev] [PATCH] usertools/dpdk-devbind.py: fix broken Python 3 support

2017-10-02 Thread Mor, Omri
When using Python 3, dpdk-devbind.py fails to detect modules other than igb_uio.

Re: [dpdk-dev] [PATCH v2] app/testpmd: port info prints dynamically mapped flow types

2017-10-02 Thread Ferruh Yigit
On 9/20/2017 4:06 PM, Kirill Rybalchenko wrote: > Port info command prints information about all supported flow types, > including dynamically mapped ones. > > Signed-off-by: Kirill Rybalchenko > Reviewed-by: Jingjing Wu Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v3] net/bonding: support bifurcated driver in eal cli using --vdev

2017-10-02 Thread Ferruh Yigit
On 10/2/2017 12:06 PM, Doherty, Declan wrote: > On 20/09/2017 7:04 PM, Gowrishankar wrote: >> From: Gowrishankar Muthukrishnan >> >> At present, creating bonding devices using --vdev is broken for PMD like >> mlx5 as it is neither UIO nor VFIO based and hence PMD driver is unknown >> to find_port_

Re: [dpdk-dev] [PATCH v4 1/3] eal/x86: run-time dispatch over memcpy

2017-10-02 Thread Li, Xiaoyun
Hi > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, October 3, 2017 00:39 > To: Li, Xiaoyun ; Richardson, Bruce > > Cc: Lu, Wenzhuo ; Zhang, Helin > ; dev@dpdk.org > Subject: RE: [PATCH v4 1/3] eal/x86: run-time dispatch over memcpy > > > > > -Original Message-

Re: [dpdk-dev] [PATCH v6 00/40] Introduce NXP DPAA Bus, Mempool and PMD

2017-10-02 Thread Ferruh Yigit
On 9/28/2017 1:29 PM, Shreyansh Jain wrote: > Change Log: > > > v6: > - rebased over net-next/master (9d660ac) > - fixed mk/rte.app.mk (Thomas's comment). It had incorrect >style of adding library linking > - changed from manual memcpy of etheraddr to ether_addr_copy >as s

Re: [dpdk-dev] [PATCH 1/2] bus/dpaa: fix incorrect ccsr mem allocation

2017-10-02 Thread Ferruh Yigit
On 9/28/2017 3:10 PM, Shreyansh Jain wrote: > Fixes: 5ad2d123be48 "(bus/dpaa: introducing FMan configurations)" > > Signed-off-by: Shreyansh Jain Series squashed into relevant commit in next-net, thanks.

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/vmxnet3: fix dereference before null check

2017-10-02 Thread Ferruh Yigit
On 10/2/2017 10:39 PM, Ferruh Yigit wrote: > On 9/29/2017 2:04 PM, Michal Jastrzebski wrote: >> Coverity reports check_after_deref: >> Null-checking rq suggests that it may be null, but it >> has already been dereferenced on all paths leading to >> the check. >> This patch removes NULL checking of

Re: [dpdk-dev] [PATCH v2] net/vmxnet3: fix dereference before null check

2017-10-02 Thread Ferruh Yigit
On 9/29/2017 2:04 PM, Michal Jastrzebski wrote: > Coverity reports check_after_deref: > Null-checking rq suggests that it may be null, but it > has already been dereferenced on all paths leading to > the check. > This patch removes NULL checking of "rq" from function > vmxnet3_dev_rx_queue_reset as

Re: [dpdk-dev] [PATCH] mk: add silvermont to replace atom as a target

2017-10-02 Thread Ferruh Yigit
On 9/8/2017 10:07 AM, Bruce Richardson wrote: > On Fri, Sep 08, 2017 at 11:28:52AM +0800, Xiaoyun Li wrote: >> The -march=atom flag is for older atom CPUs and don't support SSE4 which >> is the minimum reqiurement for DPDK. And in fact, the current atom CPUs >> support SSE4. So this patch removes a

Re: [dpdk-dev] [PATCH v4 00/24] bnxt patchset

2017-10-02 Thread Ferruh Yigit
On 9/28/2017 10:43 PM, Ajit Khaparde wrote: > This patch set includes some bug fixes and also adds > support for new dev_ops like rx_queue_count, > rx/tx_descriptor_status, get/set_eeprom > and rx_queue_intr_enable/disable. > It also adds support for the flow_filter funciton to add > Flow API funct

[dpdk-dev] Inter-PMD dependencies when building shared libraries

2017-10-02 Thread Eads, Gage
I believe I've spotted an issue in the way inter-PMD dependencies are handled when building shared libraries. The depdirs_rule in mk/rte.subdir.mk relies on DEPDIRS-xyz containing the names of subdirectories that xyz depends on. In mk/rte.lib.mk, these DEPDIRS are converted into LDLIBS. This wor

Re: [dpdk-dev] [PATCH] eal: add doc for constructor macros

2017-10-02 Thread Ferruh Yigit
On 10/2/2017 3:59 PM, Thomas Monjalon wrote: > It is a reminder that the constructors without priority > get the lowest priority. > > Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 1/3] ethdev: add Rx HW timestamp capability

2017-10-02 Thread Ferruh Yigit
On 10/2/2017 3:50 PM, Raslan Darawsheh wrote: > Add a new offload capability flag for Rx HW > timestamp and enabling/disabling this via rte_eth_rxmode. > > Signed-off-by: Raslan Darawsheh > Acked-by: Yongseok Koh Hi Raslan, Is this v4? There are two versions sent today without version informat

Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open

2017-10-02 Thread Shijith Thotton
On Fri, Sep 29, 2017 at 12:57:22PM +, Wu, Jingjing wrote: > Hi, Shijith > > Only removing the PCI reset in uio device open function is not enough. > > We faced an issue like: > > 1. Here is a FVL NIC, generate VF on one port, and then pass-through the VF > by vfio-pci to VM: > For example:

Re: [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map

2017-10-02 Thread Thomas Monjalon
02/10/2017 18:25, Hunt, David: > Hi Thomas, > > > On 2/10/2017 4:39 PM, Thomas Monjalon wrote: > > 02/10/2017 17:06, Hunt, David: > >> On 2/10/2017 3:55 PM, Thomas Monjalon wrote: > >>> +DPDK_17.11 { > +global: > + > +rte_power_acpi_turbo_status; > >>> Is it really

Re: [dpdk-dev] [PATCH v4 3/3] efd: run-time dispatch over x86 EFD functions

2017-10-02 Thread Ananyev, Konstantin
> -Original Message- > From: Li, Xiaoyun > Sent: Monday, October 2, 2017 5:13 PM > To: Ananyev, Konstantin ; Richardson, Bruce > > Cc: Lu, Wenzhuo ; Zhang, Helin ; > dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH v4 3/3] efd: run-time dispatch over x86 EFD functions > > This patch dynam

[dpdk-dev] [PATCH v6 6/6] doc: add GSO programmer's guide

2017-10-02 Thread Mark Kavanagh
Add programmer's guide doc to explain the design and use of the GSO library. Signed-off-by: Mark Kavanagh Signed-off-by: Jiayu Hu --- MAINTAINERS| 6 + .../generic_segmentation_offload_lib.rst | 256 +++ .../prog_guide/img/gso-output-s

[dpdk-dev] [PATCH v6 5/6] app/testpmd: enable TCP/IPv4, VxLAN and GRE GSO

2017-10-02 Thread Mark Kavanagh
From: Jiayu Hu This patch adds GSO support to the csum forwarding engine. Oversized packets transmitted over a GSO-enabled port will undergo segmentation (with the exception of packet-types unsupported by the GSO library). GSO support is disabled by default. GSO support may be toggled on a per-p

[dpdk-dev] [PATCH v6 3/6] gso: add VxLAN GSO support

2017-10-02 Thread Mark Kavanagh
This patch adds a framework that allows GSO on tunneled packets. Furthermore, it leverages that framework to provide GSO support for VxLAN-encapsulated packets. Supported VxLAN packets must have an outer IPv4 header (prepended by an optional VLAN tag), and contain an inner TCP/IPv4 packet (with an

[dpdk-dev] [PATCH v6 4/6] gso: add GRE GSO support

2017-10-02 Thread Mark Kavanagh
This patch adds GSO support for GRE-tunneled packets. Supported GRE packets must contain an outer IPv4 header, and inner TCP/IPv4 headers. They may also contain a single VLAN tag. GRE GSO doesn't check if all input packets have correct checksums and doesn't update checksums for output packets. Addi

[dpdk-dev] [PATCH v6 2/6] gso: add TCP/IPv4 GSO support

2017-10-02 Thread Mark Kavanagh
From: Jiayu Hu This patch adds GSO support for TCP/IPv4 packets. Supported packets may include a single VLAN tag. TCP/IPv4 GSO doesn't check if input packets have correct checksums, and doesn't update checksums for output packets (the responsibility for this lies with the application). Additional

[dpdk-dev] [PATCH v6 1/6] gso: add Generic Segmentation Offload API framework

2017-10-02 Thread Mark Kavanagh
From: Jiayu Hu Generic Segmentation Offload (GSO) is a SW technique to split large packets into small ones. Akin to TSO, GSO enables applications to operate on large packets, thus reducing per-packet processing overhead. To enable more flexibility to applications, DPDK GSO is implemented as a st

[dpdk-dev] [PATCH v6 0/6] Support TCP/IPv4, VxLAN, and GRE GSO in DPDK

2017-10-02 Thread Mark Kavanagh
Generic Segmentation Offload (GSO) is a SW technique to split large packets into small ones. Akin to TSO, GSO enables applications to operate on large packets, thus reducing per-packet processing overhead. To enable more flexibility to applications, DPDK GSO is implemented as a standalone library.

Re: [dpdk-dev] [PATCH v4 1/3] eal/x86: run-time dispatch over memcpy

2017-10-02 Thread Ananyev, Konstantin
> -Original Message- > From: Li, Xiaoyun > Sent: Monday, October 2, 2017 5:13 PM > To: Ananyev, Konstantin ; Richardson, Bruce > > Cc: Lu, Wenzhuo ; Zhang, Helin ; > dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH v4 1/3] eal/x86: run-time dispatch over memcpy > > This patch dynamically

Re: [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map

2017-10-02 Thread Hunt, David
Hi Thomas, On 2/10/2017 4:39 PM, Thomas Monjalon wrote: 02/10/2017 17:06, Hunt, David: On 2/10/2017 3:55 PM, Thomas Monjalon wrote: +DPDK_17.11 { + global: + + rte_power_acpi_turbo_status; Is it really the function you want to expose? rte_power_turbo_status seems more generic.

Re: [dpdk-dev] [PATCH v4 6/7] test/member: add functional and perf tests

2017-10-02 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Wednesday, September 27, 2017 6:41 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Tai, Charlie ; Gobriel, > Sameh ; De Lara Guarch, Pablo > ; Mcnamara, John > ; Wang, Yipeng1 > Subject: [PATCH v4 6/7] test/member: add functional and pe

Re: [dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings

2017-10-02 Thread Adrien Mazarguil
On Mon, Oct 02, 2017 at 02:46:24PM +0100, Bruce Richardson wrote: > On Mon, Oct 02, 2017 at 01:53:17PM +0200, Adrien Mazarguil wrote: > > Hi Stephen, > > > > On Fri, Sep 29, 2017 at 08:37:49AM -0700, Stephen Hemminger wrote: > > > The Linux kernel style policy about strings is that strings should

[dpdk-dev] [PATCH v4 3/3] efd: run-time dispatch over x86 EFD functions

2017-10-02 Thread Xiaoyun Li
This patch dynamically selects x86 EFD functions at run-time. This patch uses function pointer and binds it to the relative function based on CPU flags at constructor time. Signed-off-by: Xiaoyun Li --- lib/librte_efd/rte_efd_x86.h | 41 ++--- 1 file changed,

[dpdk-dev] [PATCH v4 2/3] app/test: run-time dispatch over memcpy perf test

2017-10-02 Thread Xiaoyun Li
This patch modifies assignment of alignment unit from build-time to run-time based on CPU flags that machine supports. Signed-off-by: Xiaoyun Li --- test/test/test_memcpy_perf.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/test/te

[dpdk-dev] [PATCH v4 1/3] eal/x86: run-time dispatch over memcpy

2017-10-02 Thread Xiaoyun Li
This patch dynamically selects functions of memcpy at run-time based on CPU flags that current machine supports. This patch uses function pointers which are bind to the relative functions at constrctor time. In addition, AVX512 instructions set would be compiled only if users config it enabled and

[dpdk-dev] [PATCH v4 0/3] run-time Linking support

2017-10-02 Thread Xiaoyun Li
This patchset dynamically selects functions at run-time based on CPU flags that current machine supports. This patchset modifies mempcy, memcpy perf test and x86 EFD, using function pointers and bind them at constructor time. Then in the cloud environment, users can compiler once for the minimum ta

Re: [dpdk-dev] [PATCH v4 5/7] member: enable the library

2017-10-02 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Wednesday, September 27, 2017 6:41 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Tai, Charlie ; Gobriel, > Sameh ; De Lara Guarch, Pablo > ; Mcnamara, John > ; Wang, Yipeng1 > Subject: [PATCH v4 5/7] member: enable the library > > Th

Re: [dpdk-dev] [PATCH v4 3/7] member: implement vBF mode

2017-10-02 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Wednesday, September 27, 2017 6:41 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Tai, Charlie ; Gobriel, > Sameh ; De Lara Guarch, Pablo > ; Mcnamara, John > ; Wang, Yipeng1 > Subject: [PATCH v4 3/7] member: implement vBF mode > > Bl

Re: [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map

2017-10-02 Thread Thomas Monjalon
02/10/2017 17:06, Hunt, David: > On 2/10/2017 3:55 PM, Thomas Monjalon wrote: >> +DPDK_17.11 { > >> + global: > >> + > >> + rte_power_acpi_turbo_status; > > Is it really the function you want to expose? > > rte_power_turbo_status seems more generic. > > Not really, it was in there for completene

[dpdk-dev] [PATCH v2] power: add turbo functions to map file

2017-10-02 Thread David Hunt
Fixes: 94608a0f7f45 ("power: add per-core turbo boost API") Signed-off-by: David Hunt --- lib/librte_power/rte_power_version.map | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_power/rte_power_version.map b/lib/librte_power/rte_power_version.map index db75ff3..ec512ea 1006

[dpdk-dev] [PATCH v4 5/5] ethdev: remove unnecessary check for new flow type

2017-10-02 Thread Kirill Rybalchenko
Remove unnecessary check for new flow type for rss hash filter update. Signed-off-by: Kirill Rybalchenko --- lib/librte_ether/rte_ethdev.c | 8 1 file changed, 8 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index 1849a3b..f3bf3e5 100644 --- a/

[dpdk-dev] [PATCH v4 3/5] net/i40e: add new functions to manipulate with pctype mapping table

2017-10-02 Thread Kirill Rybalchenko
Add new functions which allow modify, return or reset to default the contents of flow type to pctype dynamic mapping table. v3: Function rte_pmd_i40e_flow_type_mapping_get returns now full mapping table. v4: Fix typo in rte_pmd_i40e_version.map file. Signed-off-by: Kirill Rybalchenko --- drive

[dpdk-dev] [PATCH v4 2/5] net/i40e: implement dynamic mapping of sw flow types to hw pctypes

2017-10-02 Thread Kirill Rybalchenko
Implement dynamic mapping of software flow types to hardware pctypes. This allows to add new flow types and pctypes for DDP without changing API of the driver. The mapping table is located in private data area for particular network adapter and can be individually modified with set of appropriate f

[dpdk-dev] [PATCH v4 4/5] app/testpmd: add new commands to manipulate with pctype mapping

2017-10-02 Thread Kirill Rybalchenko
Add new commands to manipulate with dynamic flow type to pctype mapping table in i40e PMD. Commands allow to print table, modify it and reset to default value. v3: changed command syntax from 'pctype mapping...' to 'port config pctype mapping...' and 'show port pctype mapping' v4: Fix typos in cm

[dpdk-dev] [PATCH v4 0/5] net/i40e: implement dynamic mapping of flow types to pctypes

2017-10-02 Thread Kirill Rybalchenko
Implement dynamic mapping of software flow types to hardware pctypes. This allows to map new flow types to pctypes without changing API of the driver. v2: Remove unnecessary check for new flow types. Re-arrange patchset to avoid compillation errors. Remove unnecessary usage of statically defined f

[dpdk-dev] [PATCH v4 1/5] net/i40e: remove unnecessary bit operations

2017-10-02 Thread Kirill Rybalchenko
Remove unnecessary bit operations in I40E_PFQF_HENA and I40E_VFQF_HENA registers Signed-off-by: Kirill Rybalchenko --- drivers/net/i40e/i40e_ethdev.c| 21 +++-- drivers/net/i40e/i40e_ethdev_vf.c | 22 -- 2 files changed, 7 insertions(+), 36 deletions(-) d

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated

2017-10-02 Thread Maxime Coquelin
On 10/02/2017 03:50 PM, Jastrzebski, MichalX K wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Jastrzebski Sent: Friday, September 22, 2017 3:08 PM To: y...@fridaylinux.org; maxime.coque...@redhat.com Cc: dev@dpdk.org; Jain, Deepak K ; Piasecki, Jac

Re: [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map

2017-10-02 Thread Hunt, David
Hi Thomas On 2/10/2017 3:55 PM, Thomas Monjalon wrote: Hi, I have some comments about the API scope and some formatting. Suggested title: power: add turbo functions to map file 02/10/2017 14:20, David Hunt: allows vm_power_manager example to be built against shared libraries Fixes:

[dpdk-dev] [PATCH] eal: add doc for constructor macros

2017-10-02 Thread Thomas Monjalon
It is a reminder that the constructors without priority get the lowest priority. Signed-off-by: Thomas Monjalon --- lib/librte_eal/common/include/rte_eal.h | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/incl

Re: [dpdk-dev] [PATCH] lib/power: add turbo functions to version.map

2017-10-02 Thread Thomas Monjalon
Hi, I have some comments about the API scope and some formatting. Suggested title: power: add turbo functions to map file 02/10/2017 14:20, David Hunt: > allows vm_power_manager example to be built against shared libraries Fixes: 94608a0f7f45 ("power: add per-core turbo boost API") > Si

[dpdk-dev] [PATCH 3/3] net/mlx5: add Rx HW timestamp

2017-10-02 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by :Raslan Darawsheh Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rxq.c | 6 +- drivers/net/mlx5/mlx5_rxtx.c | 5 + drivers/net/mlx5/mlx5_rxtx.h | 3 ++- dri

[dpdk-dev] [PATCH 2/3] app/testpmd: add Rx HW timestamp

2017-10-02 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2 ++ ap

[dpdk-dev] [PATCH 1/3] ethdev: add Rx HW timestamp capability

2017-10-02 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- This patch should be applied after after this series: http://dpdk.org/dev/patchwork/patch/29368/ --- doc/guides/nics/features.rst | 1

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: get the supported pool for a port

2017-10-02 Thread Olivier MATZ
On Sun, Oct 01, 2017 at 02:44:40PM +0530, Santosh Shukla wrote: > Now that dpdk supports more than one mempool drivers and > each mempool driver works best for specific PMD, example: > - sw ring based mempool for Intel PMD drivers. > - dpaa2 HW mempool manager for dpaa2 PMD driver. > - fpa HW mempo

Re: [dpdk-dev] [PATCH v5 1/2] eal: allow user to override default pool handle

2017-10-02 Thread Olivier MATZ
On Sun, Oct 01, 2017 at 02:44:39PM +0530, Santosh Shukla wrote: > DPDK has support for both sw and hw mempool and > currently user is limited to use ring_mp_mc pool. > In case user want to use other pool handle, > need to update config RTE_MEMPOOL_OPS_DEFAULT, then > build and run with desired pool

Re: [dpdk-dev] [PATCH v7 8/8] mempool: notify memory area to pool

2017-10-02 Thread Olivier MATZ
On Sun, Oct 01, 2017 at 02:59:02PM +0530, Santosh Shukla wrote: > HW pool manager e.g. Octeontx SoC demands s/w to program start and end > address of pool. Currently, there is no such api in external mempool. > Introducing rte_mempool_ops_register_memory_area api which will let HW(pool > manager) t

Re: [dpdk-dev] [PATCH v7 7/8] mempool: introduce block size align flag

2017-10-02 Thread Olivier MATZ
On Sun, Oct 01, 2017 at 02:59:01PM +0530, Santosh Shukla wrote: > Some mempool hw like octeontx/fpa block, demands block size > (/total_elem_sz) aligned object start address. > > Introducing an MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS flag. > If this flag is set: > - Align object start address(vaddr) to

Re: [dpdk-dev] [PATCH] acl: fix unchecked return value

2017-10-02 Thread Ananyev, Konstantin
> -Original Message- > From: Kozak, KubaX > Sent: Wednesday, September 20, 2017 11:02 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Kozak, KubaX ; sta...@dpdk.org > Subject: [PATCH] acl: fix unchecked return value > > Add return value check and error handling for fseek call. > > Cov

Re: [dpdk-dev] [PATCH] vhost: fix unchecked return value

2017-10-02 Thread Jastrzebski, MichalX K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kuba Kozak > Sent: Friday, September 22, 2017 2:18 PM > To: y...@fridaylinux.org; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Kozak, KubaX ; > jan.wick...@ericsson.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH v2] eal: fix resource leak

2017-10-02 Thread Jastrzebski, MichalX K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Daniel Mrzyglod > Sent: Friday, September 22, 2017 4:48 PM > To: tho...@monjalon.net > Cc: dev@dpdk.org; Mrzyglod, DanielX T > Subject: [dpdk-dev] [PATCH v2] eal: fix resource leak > > Memory allocated in strdup i

Re: [dpdk-dev] [PATCH] acl: fix unchecked return value

2017-10-02 Thread Jastrzebski, MichalX K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kuba Kozak > Sent: Wednesday, September 20, 2017 12:02 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; Kozak, KubaX ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] acl: fix unchecked return value > > Add return

Re: [dpdk-dev] [PATCH] examples/performance-thread: fix out-of-bounds read

2017-10-02 Thread Jastrzebski, MichalX K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slawomir > Mrozowicz > Sent: Wednesday, September 20, 2017 9:48 AM > To: Mcnamara, John > Cc: dev@dpdk.org; Mrozowicz, SlawomirX > ; ian.be...@intel.com; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] examples/perfo

[dpdk-dev] [PATCH 3/3] net/mlx5: add Rx HW timestamp

2017-10-02 Thread Raslan Darawsheh
Expose Rx HW timestamp to packet mbufs. Signed-off-by :Raslan Darawsheh Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 3 ++- drivers/net/mlx5/mlx5_rxq.c | 6 +- drivers/net/mlx5/mlx5_rxtx.c | 5 + drivers/net/mlx5/mlx5_rxtx.h | 3 ++- dri

[dpdk-dev] [PATCH 1/3] ethdev: add Rx HW timestamp capability

2017-10-02 Thread Raslan Darawsheh
Add a new offload capability flag for Rx HW timestamp and enabling/disabling this via rte_eth_rxmode. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- This patch should be applied after after this series: http://dpdk.org/dev/patchwork/patch/29368/ --- doc/guides/nics/features.rst | 1

[dpdk-dev] [PATCH 2/3] app/testpmd: add Rx HW timestamp

2017-10-02 Thread Raslan Darawsheh
Add enabling/disabling Rx HW timestamp from command line and parameter. Signed-off-by: Raslan Darawsheh Acked-by: Yongseok Koh --- app/test-pmd/cmdline.c| 15 --- app/test-pmd/config.c | 8 app/test-pmd/parameters.c | 5 + app/test-pmd/rxonly.c | 2 ++ ap

Re: [dpdk-dev] [PATCH v2] net/vmxnet3: fix dereference before null check

2017-10-02 Thread Jastrzebski, MichalX K
> -Original Message- > From: Jastrzebski, MichalX K > Sent: Friday, September 29, 2017 3:04 PM > To: skh...@vmware.com > Cc: dev@dpdk.org; Jain, Deepak K ; Yigit, Ferruh > ; Jastrzebski, MichalX K > ; yongw...@vmware.com; > sta...@dpdk.org; Kulasek, TomaszX > Subject: [PATCH v2] net/vmxnet

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated

2017-10-02 Thread Jastrzebski, MichalX K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Jastrzebski > Sent: Friday, September 22, 2017 3:10 PM > To: y...@fridaylinux.org; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Jain, Deepak K ; Piasecki, > JacekX ; Liu, Changpeng > ; sta...@dpdk.org > Sub

Re: [dpdk-dev] [PATCH] examples/vhost_scsi: fix buffer not terminated

2017-10-02 Thread Jastrzebski, MichalX K
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Jastrzebski > Sent: Friday, September 22, 2017 3:08 PM > To: y...@fridaylinux.org; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Jain, Deepak K ; Piasecki, > JacekX ; Liu, Changpeng > ; sta...@dpdk.org > Sub

Re: [dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings

2017-10-02 Thread Bruce Richardson
On Mon, Oct 02, 2017 at 01:53:17PM +0200, Adrien Mazarguil wrote: > Hi Stephen, > > On Fri, Sep 29, 2017 at 08:37:49AM -0700, Stephen Hemminger wrote: > > The Linux kernel style policy about strings is that strings should > > be always put on one line. This makes sense since a typical use case > >

Re: [dpdk-dev] [PATCH v4 2/7] member: implement HT mode

2017-10-02 Thread De Lara Guarch, Pablo
> -Original Message- > From: Wang, Yipeng1 > Sent: Wednesday, September 27, 2017 6:40 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Tai, Charlie ; Gobriel, > Sameh ; De Lara Guarch, Pablo > ; Mcnamara, John > ; Wang, Yipeng1 > Subject: [PATCH v4 2/7] member: implement HT mode > ...

[dpdk-dev] [PATCH] lib/power: add turbo functions to version.map

2017-10-02 Thread David Hunt
allows vm_power_manager example to be built against shared libraries Signed-off-by: David Hunt --- lib/librte_power/rte_power_version.map | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/librte_power/rte_power_version.map b/lib/librte_power/rte_power_version.map index db75ff3..9

Re: [dpdk-dev] [PATCH v3 1/3] eal/x86: run-time dispatch over memcpy

2017-10-02 Thread Konstantin Ananyev
Hi Xiaoyun, Just to be a bit more specific about what I suggest - here is a draft patch below. It still needs more testing and probably polishing, but I suppose gives you an idea. Konstantin --- lib/librte_eal/bsdapp/eal/Makefile | 20 + lib/librte_eal/common/arch/x86/rte_memcpy

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: add GTP items to support flow API

2017-10-02 Thread Adrien Mazarguil
On Fri, Sep 29, 2017 at 10:29:55AM +0100, Sean Harte wrote: > On 29 September 2017 at 09:54, Xing, Beilei wrote: > >> > /** > >> > + * RTE_FLOW_ITEM_TYPE_GTP. > >> > + * > >> > + * Matches a GTPv1 header. > >> > + */ > >> > +struct rte_flow_item_gtp { > >> > + /** > >> > +* Version

Re: [dpdk-dev] [PATCH v3] net/bonding: support bifurcated driver in eal cli using --vdev

2017-10-02 Thread Gaƫtan Rivet
Hi Gowrishankar, There will be a trivial conflict with my PCI patchset on the pci_addr_cmp function. I don't know the best way to solve this. It depends on my patchset being accepted as-is or not, and which address namespace has precedence over the other. You could rename pci_addr_cmp with a ref

Re: [dpdk-dev] [PATCH] checkpatch: re-enable warnings about split long strings

2017-10-02 Thread Adrien Mazarguil
Hi Stephen, On Fri, Sep 29, 2017 at 08:37:49AM -0700, Stephen Hemminger wrote: > The Linux kernel style policy about strings is that strings should > be always put on one line. This makes sense since a typical use > case is for a user to type the error message into a search engine > or grep, and i

Re: [dpdk-dev] [PATCH v3] eal/x86: implement x86 specific tsc hz

2017-10-02 Thread Sergio Gonzalez Monroy
On 02/10/2017 12:24, Jerin Jacob wrote: -Original Message- Date: Mon, 2 Oct 2017 12:17:38 +0100 From: Sergio Gonzalez Monroy To: dev@dpdk.org CC: harry.van.haa...@intel.com, bruce.richard...@intel.com Subject: [dpdk-dev] [PATCH v3] eal/x86: implement x86 specific tsc hz X-Mailer: git-se

Re: [dpdk-dev] [PATCH v3] eal/x86: implement x86 specific tsc hz

2017-10-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Oct 2017 12:17:38 +0100 > From: Sergio Gonzalez Monroy > To: dev@dpdk.org > CC: harry.van.haa...@intel.com, bruce.richard...@intel.com > Subject: [dpdk-dev] [PATCH v3] eal/x86: implement x86 specific tsc hz > X-Mailer: git-send-email 2.9.5 > > First, try

[dpdk-dev] [PATCH v3] eal/x86: implement x86 specific tsc hz

2017-10-02 Thread Sergio Gonzalez Monroy
First, try to use CPUID Time Stamp Counter and Nominal Core Crystal Clock Information Leaf to determine the tsc hz on platforms that supports it (does not require privileged user). If the CPUID leaf is not available, then try to determine the tsc hz by reading the MSR 0xCE (requires privileged use

Re: [dpdk-dev] [PATCH v2 2/4] net/mrvl: add mrvl net pmd driver

2017-10-02 Thread Bruce Richardson
On Fri, Sep 29, 2017 at 08:38:00AM -0700, Stephen Hemminger wrote: > On Thu, 28 Sep 2017 12:22:36 +0200 > Tomasz Duszynski wrote: > > > + > > +struct mrvl_rxq; > > +struct mrvl_txq; > > These forward decl should not be nececessary > > +static inline int > > +mrvl_get_bpool_size(intpp2_id, in

Re: [dpdk-dev] [PATCH v3] net/bonding: support bifurcated driver in eal cli using --vdev

2017-10-02 Thread Doherty, Declan
On 20/09/2017 7:04 PM, Gowrishankar wrote: From: Gowrishankar Muthukrishnan At present, creating bonding devices using --vdev is broken for PMD like mlx5 as it is neither UIO nor VFIO based and hence PMD driver is unknown to find_port_id_by_pci_addr(), as below. testpmd --vdev 'net_bonding0,m

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 2 Oct 2017 15:58:56 +0530 > From: "Rao, Nikhil" > To: Jerin Jacob > CC: bruce.richard...@intel.com, gage.e...@intel.com, dev@dpdk.org, > tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra...@nxp.com, > nipun.gu...@nxp.com, narender.vang...@intel

Re: [dpdk-dev] [PATCH v4 4/4] eventdev: Add tests for event eth Rx adapter APIs

2017-10-02 Thread Jerin Jacob
-Original Message- > Date: Sun, 24 Sep 2017 23:54:38 +0530 > From: "Rao, Nikhil" > To: Jerin Jacob > CC: bruce.richard...@intel.com, gage.e...@intel.com, dev@dpdk.org, > tho...@monjalon.net, harry.van.haa...@intel.com, hemant.agra...@nxp.com, > nipun.gu...@nxp.com, narender.vang...@inte

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-02 Thread Rao, Nikhil
On 9/25/2017 8:29 AM, Rao, Nikhil wrote: On 9/24/2017 11:46 PM, Rao, Nikhil wrote: On 9/22/2017 2:40 PM, Jerin Jacob wrote: When we worked on a prototype, we figured out that we need a separate event type for RX adapter. Probably RTE_EVENT_TYPE_ETHDEV_RX_ADAPTER? The Reason is: - In the HW ba

Re: [dpdk-dev] [PATCH] doc: Adds reference to use mlockall() in the Programmer's guide

2017-10-02 Thread Eelco Chaudron
On 29/09/17 17:44, Mcnamara, John wrote: Hi Eelco, Thanks for that. It is always good to get doc improvements. Some minor comments below. Thanks for pointing out the below issues, and I send out a V2. The title should be lowercase (except for known acronyms), <= 50 characters and the verb s

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-10-02 Thread Rao, Nikhil
On 9/22/2017 11:38 AM, santosh wrote: In general api comment: Fix missing param definition like *service_id* above and pl. remove other unnecessary params description from api above. OK. +static inline int +valid_id(uint8_t id) +{ + return id < RTE_MAX_EVENT_ETH_RX_ADAPTER_INSTANCE

  1   2   >