Re: [dpdk-dev] [PATCH v3 21/40] maintainers: claim ownership of DPAA Mempool driver

2017-09-21 Thread Thomas Monjalon
22/09/2017 08:47, Shreyansh Jain: > On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote: > > 23/08/2017 16:11, Shreyansh Jain: > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -409,6 +409,7 @@ NXP dpaa > >> M: Hemant Agrawal > >> M: Shreyansh Jain > >> F: drivers/bus/dpaa/ > >>

Re: [dpdk-dev] [PATCH v3 24/40] config: enable NXP DPAA PMD compilation

2017-09-21 Thread Shreyansh Jain
On Friday 22 September 2017 03:33 AM, Thomas Monjalon wrote: 23/08/2017 16:11, Shreyansh Jain: --- a/config/defconfig_arm64-dpaa-linuxapp-gcc +++ b/config/defconfig_arm64-dpaa-linuxapp-gcc +# +# Compile Environment Abstraction Layer +# +CONFIG_RTE_MAX_LCORE=4 +CONFIG_RTE_MAX_NUMA_NODES=1 +CONFIG

Re: [dpdk-dev] [PATCH v3 26/40] net/dpaa: add support for MTU update

2017-09-21 Thread Shreyansh Jain
On Friday 22 September 2017 03:37 AM, Thomas Monjalon wrote: 23/08/2017 16:11, Shreyansh Jain: Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 21 + It is very good to update f

Re: [dpdk-dev] [PATCH v3 21/40] maintainers: claim ownership of DPAA Mempool driver

2017-09-21 Thread Shreyansh Jain
On Friday 22 September 2017 03:26 AM, Thomas Monjalon wrote: 23/08/2017 16:11, Shreyansh Jain: --- a/MAINTAINERS +++ b/MAINTAINERS @@ -409,6 +409,7 @@ NXP dpaa M: Hemant Agrawal M: Shreyansh Jain F: drivers/bus/dpaa/ +F: drivers/mempool/dpaa/ F: doc/guides/nics/dpaa.rst F: doc/guides

Re: [dpdk-dev] [PATCH v4 00/41] Introduce NXP DPAA Bus, Mempool and PMD

2017-09-21 Thread Thomas Monjalon
22/09/2017 08:25, Shreyansh Jain: > > It is a very long series introducing 3 different subsystems. > > I think everybody was scared about reviewing it. > > Well, then Ferruh is quite a brave man - I got loads of comments from > him. :D He is :) > > Why you did not split it? > > All the compone

Re: [dpdk-dev] [PATCH v3 20/40] drivers: enable compilation of DPAA Mempool driver

2017-09-21 Thread Shreyansh Jain
On Friday 22 September 2017 03:25 AM, Thomas Monjalon wrote: 23/08/2017 16:11, Shreyansh Jain: +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL_DEBUG=n Please could you try to remove this kind of option? We are going to remove them from DPDK. OK. I will revisit and remove which are not impacting the performa

[dpdk-dev] [PATCH v2] app/testpmd: fix stats period can't quit normally in container

2017-09-21 Thread Phil Yang
In container, the process cannot be terminated by SIGINT/SIGTERM when execute with 'stats-period' option. Fixed by adding a flag to exit stats period loop after received either SIGINT or SIGTERM. Signed-off-by: Phil Yang --- app/test-pmd/testpmd.c | 13 - 1 file changed, 12 insertion

Re: [dpdk-dev] [PATCH v4 00/41] Introduce NXP DPAA Bus, Mempool and PMD

2017-09-21 Thread Shreyansh Jain
Hi Thomas, Thanks for comments. I will reply soon to those on v3 as well. On Friday 22 September 2017 03:40 AM, Thomas Monjalon wrote: 09/09/2017 13:20, Shreyansh Jain: DPAA, or Datapath Acceleration Architecture [R2], is a set of hardware components designed for high-speed network packet proc

[dpdk-dev] [PATCH v2] app/testpmd: fix stats period can't quit normally in container

2017-09-21 Thread Phil Yang
In container, the process cannot be terminated by SIGINT/SIGTERM when execute with 'stats-period' option. Fixed by adding a flag to exit stats period loop after received SIGINT/SIGTERM. Signed-off-by: Phil Yang --- app/test-pmd/testpmd.c | 13 - 1 file changed, 12 insertions(+), 1 de

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-21 Thread santosh
On Friday 22 September 2017 02:47 AM, Nikhil Rao wrote: > Add common APIs for configuring packet transfer from ethernet Rx > queues to event devices across HW & SW packet transfer mechanisms. > A detailed description of the adapter is contained in the header's > comments. > > The adapter implement

Re: [dpdk-dev] [PATCH] vhost: fix vhost_user_set_mem_table error

2017-09-21 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yi Yang > Sent: Wednesday, September 20, 2017 4:32 PM > To: y...@fridaylinux.org > Cc: dev@dpdk.org; Yang, Yi Y > Subject: [dpdk-dev] [PATCH] vhost: fix vhost_user_set_mem_table error > > Usually vhost_user messa

Re: [dpdk-dev] [PATCH v4 2/4] eventdev: Add ethernet Rx adapter caps function to eventdev SW PMD

2017-09-21 Thread santosh
On Friday 22 September 2017 02:47 AM, Nikhil Rao wrote: > Signed-off-by: Nikhil Rao > --- Reviewed-by: Santosh Shukla

Re: [dpdk-dev] [PATCH v4 2/4] eventdev: Add ethernet Rx adapter caps function to eventdev SW PMD

2017-09-21 Thread Jerin Jacob
-Original Message- > Date: Fri, 22 Sep 2017 02:47:12 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com > CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, > harry.van.haa...@intel.com, hemant.agra...@nxp.com, nipun.gu...@nxp.com, > narend

Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open

2017-09-21 Thread Yang, Qiming
> -Original Message- > From: Shijith Thotton [mailto:shijith.thot...@caviumnetworks.com] > Sent: Tuesday, September 19, 2017 6:24 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Thomas Monjalon > ; Yang, Qiming ; Patil, Harish > ; Zhang, Helin ; Gregory > Etelson ; Tan, Jianfeng ; Hu, > Xuekun

Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix clear xstats bug in vf port

2017-09-21 Thread Zhao1, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, September 22, 2017 2:16 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix clear xstats bug in vf > port > > On 9/21/2017 4:11 AM, Zhao1, Wei wrote: > > Hi,Ferruh > > > >

Re: [dpdk-dev] [PATCH 10/12] vhost: support to kick in secondary process

2017-09-21 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Thursday, September 21, 2017 5:18 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; maxime.coque...@redhat.com; mtetsu...@gmail.com > Subject: Re: [PATCH 10/12] vhost: support to kick in secondary process > > On Thu,

Re: [dpdk-dev] [PATCH v4 1/5] net/bonding: remove bonding APIs using ABI versioning

2017-09-21 Thread Yang, Zhiyong
Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, September 21, 2017 6:37 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: tho...@monjalon.net > Subject: Re: [PATCH v4 1/5] net/bonding: remove bonding APIs using ABI > versioning > > On 9/21/2017 9:32 AM, Zhiyong Yang wrote:

Re: [dpdk-dev] [PATCH v4 00/41] Introduce NXP DPAA Bus, Mempool and PMD

2017-09-21 Thread Thomas Monjalon
09/09/2017 13:20, Shreyansh Jain: > DPAA, or Datapath Acceleration Architecture [R2], is a set of hardware > components designed for high-speed network packet processing. This > architecture provides the infrastructure to support simplified sharing of > networking interfaces and accelerators by mul

Re: [dpdk-dev] [PATCH v4 00/41] Introduce NXP DPAA Bus, Mempool and PMD

2017-09-21 Thread Thomas Monjalon
09/09/2017 13:20, Shreyansh Jain: > v4: > - Some checkpatch fixes which were reported by checkpatch@dpdk > - adding support for extended stats (patch 41) Sorry, I did some comments on v3 instead of v4. But I think they apply anyway.

Re: [dpdk-dev] [PATCH v3 26/40] net/dpaa: add support for MTU update

2017-09-21 Thread Thomas Monjalon
23/08/2017 16:11, Shreyansh Jain: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain > --- > doc/guides/nics/features/dpaa.ini | 1 + > drivers/net/dpaa/dpaa_ethdev.c| 21 + It is very good to update features matrix and code in the same patch. History tracki

Re: [dpdk-dev] [PATCH v3 24/40] config: enable NXP DPAA PMD compilation

2017-09-21 Thread Thomas Monjalon
23/08/2017 16:11, Shreyansh Jain: > --- a/config/defconfig_arm64-dpaa-linuxapp-gcc > +++ b/config/defconfig_arm64-dpaa-linuxapp-gcc > +# > +# Compile Environment Abstraction Layer > +# > +CONFIG_RTE_MAX_LCORE=4 > +CONFIG_RTE_MAX_NUMA_NODES=1 > +CONFIG_RTE_CACHE_LINE_SIZE=64 > +CONFIG_RTE_PKTMBUF_HE

Re: [dpdk-dev] [PATCH v3 21/40] maintainers: claim ownership of DPAA Mempool driver

2017-09-21 Thread Thomas Monjalon
23/08/2017 16:11, Shreyansh Jain: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -409,6 +409,7 @@ NXP dpaa > M: Hemant Agrawal > M: Shreyansh Jain > F: drivers/bus/dpaa/ > +F: drivers/mempool/dpaa/ > F: doc/guides/nics/dpaa.rst > F: doc/guides/nics/features/dpaa.ini This kind of patch can be

Re: [dpdk-dev] [PATCH v3 20/40] drivers: enable compilation of DPAA Mempool driver

2017-09-21 Thread Thomas Monjalon
23/08/2017 16:11, Shreyansh Jain: > +CONFIG_RTE_LIBRTE_DPAA_MEMPOOL_DEBUG=n Please could you try to remove this kind of option? We are going to remove them from DPDK. For control path, no need of removing logs at compilation time. For data path, compilation of logs is controlled by CONFIG_RTE_LOG

[dpdk-dev] [PATCH v2 9/9] test/crypto: add AES-CCM tests

2017-09-21 Thread Pablo de Lara
Added AES-CCM tests for Intel QAT PMD and OpenSSL PMD. Signed-off-by: Pablo de Lara Signed-off-by: Arek Kusztal --- test/test/test_cryptodev.c | 290 --- test/test/test_cryptodev_aead_test_vectors.h | 401 +++ 2 files changed, 657 insert

[dpdk-dev] [PATCH v2 8/9] test/crypto: rename GCM test code

2017-09-21 Thread Pablo de Lara
Before adding AES-CCM tests, some test code used for AES-GCM can be renamed, so it can be reused for AES-CCM, as both need similar parameters. Signed-off-by: Pablo de Lara --- test/test/test_cryptodev.c | 245 +++-- ...ectors.h => test_cryptodev_aead_test_

[dpdk-dev] [PATCH v2 7/9] crypto/qat: add AES-CCM support

2017-09-21 Thread Pablo de Lara
From: Arek Kusztal This patch adds AES-CCM AEAD cipher and hash algorithm to Intel QuickAssist Technology driver. Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_adf/icp_qat_hw.h | 20 +++ drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 28 drivers/crypto/qat/qat_cryp

[dpdk-dev] [PATCH v2 5/9] crypto/openssl: init GCM key at session creation

2017-09-21 Thread Pablo de Lara
When creating a session for AES-GCM, since the key is going to be constant, the OpenSSL context can initialize the key at that moment, leaving the setting of the IV for the operation handling. Signed-off-by: Pablo de Lara --- drivers/crypto/openssl/rte_openssl_pmd.c | 208 +++

[dpdk-dev] [PATCH v2 6/9] crypto/openssl: add AES-CCM support

2017-09-21 Thread Pablo de Lara
Add support to AES-CCM, for 128, 192 and 256-bit keys. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/features/default.ini | 3 + doc/guides/cryptodevs/features/openssl.ini | 3 + doc/guides/cryptodevs/openssl.rst| 1 + doc/guides/rel_notes/release_17_11.rst |

[dpdk-dev] [PATCH v2 2/9] examples/l2fwd-crypto: add AES-CCM support

2017-09-21 Thread Pablo de Lara
According to the API, AES-CCM has special requirements when setting IV and AAD fields. The L2fwd-crypto app is updated to set the nonce (IV) and AAD in the right positions in these two fields (1 byte after start of IV field and 18 bytes after start of AAD). Signed-off-by: Pablo de Lara --- examp

[dpdk-dev] [PATCH v2 3/9] app/crypto-perf: add AES-CCM support

2017-09-21 Thread Pablo de Lara
According to the API, AES-CCM has special requirements when setting IV and AAD fields. The L2fwd-crypto app is updated to set the nonce (IV) and AAD in the right positions in these two fields (1 byte after start of IV field and 18 bytes after start of AAD). Signed-off-by: Pablo de Lara --- app/t

[dpdk-dev] [PATCH v2 4/9] crypto/openssl: fix AEAD parameters

2017-09-21 Thread Pablo de Lara
When using AES-GCM with OpenSSL, cipher direction and authentication operation were being set incorrectly, as the PMD was looking at the cipher and authentication transform, instead of the new AEAD. Fixes: b79e4c00af0e ("cryptodev: use AES-GCM/CCM as AEAD algorithms") Cc: sta...@dpdk.org Signed-o

[dpdk-dev] [PATCH v2 1/9] cryptodev: clarify API for AES-CCM

2017-09-21 Thread Pablo de Lara
AES-CCM algorithm has some restrictions when handling nonce (IV) and AAD information. As the API stated, the nonce needs to be place 1 byte after the start of the IV field. This field needs to be 16 bytes long, regardless the length of the nonce, but it is important to clarify that the first byte

[dpdk-dev] [PATCH v2 0/9] Add support for AES-CCM

2017-09-21 Thread Pablo de Lara
AES-CCM support is added in the OpenSSL and QAT PMDs. The PMDs and the test code have been reworked, to avoid duplications with AES-GCM code, as both algorithms are quite similar (both are AEAD algorithms). Also, an optimization for AES-GCM (and AES-CCM after the last patch) has been introduced,

Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix clear xstats bug in vf port

2017-09-21 Thread Ferruh Yigit
On 9/21/2017 7:16 PM, Ferruh Yigit wrote: > On 9/21/2017 4:11 AM, Zhao1, Wei wrote: >> Hi,Ferruh >> >>> -Original Message- >>> From: Yigit, Ferruh >>> Sent: Thursday, September 14, 2017 9:31 PM >>> To: Zhao1, Wei ; dev@dpdk.org >>> Cc: Wu, Jingjing >>> Subject: Re: [dpdk-dev] [PATCH v2 1/2

[dpdk-dev] [PATCH] hash: fix incorrect eviction counter

2017-09-21 Thread Pablo de Lara
When adding a new entry in a hash table, there is a maximum number of evictions that can be performed. When the counter of these evictions reaches this maximum, the entry cannot be added, as it is considered that the algorithm has encountered an infinite loop. The problem with the current implemen

[dpdk-dev] [PATCH v3] timer: allow timer reset on service cores

2017-09-21 Thread Pavan Nikhilesh
From: Pavan Bhagavatula The rte_timer_reset function should be able to register timers on service lcores as they are EAL threads. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- This patch depends on http://dpdk.org/dev/patchwork/patch/29056/ v3 changes: -updated the API as

Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and flush

2017-09-21 Thread Chilikin, Andrey
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Friday, September 15, 2017 4:13 AM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and flush > > This feature enable queue regions configuration

[dpdk-dev] [PATCH] test/logs: fix dynamic log levels testing

2017-09-21 Thread Radoslaw Biernacki
This patch fixes the dynamic log levels testing in logs_autotest. Introduction of rte_log_set_level() in patch c1b5fa94a46f was done with parameter RTE_LOG_EMERG which caused all RTE_LOG() calls an early return due to all given levels were far below EMERG. If first two logs supposed to show up on c

Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix clear xstats bug in vf port

2017-09-21 Thread Ferruh Yigit
On 9/21/2017 4:11 AM, Zhao1, Wei wrote: > Hi,Ferruh > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, September 14, 2017 9:31 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: Wu, Jingjing >> Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/i40e: fix clear xstats bug in vf >> port >> >

Re: [dpdk-dev] [PATCH 07/11] ethdev: add rte flow action for crypto

2017-09-21 Thread Boris Pismenny
Hi Jern, > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Thursday, September 21, 2017 12:16 > To: Akhil Goyal > Cc: dev@dpdk.org; declan.dohe...@intel.com; > pablo.de.lara.gua...@intel.com; hemant.agra...@nxp.com; > radu.nico...@intel.com; Boris Pi

Re: [dpdk-dev] [PATCH v2] vfio: fix close unchecked file descriptor

2017-09-21 Thread Patrick MacArthur
On 09/21/2017 09:49 AM, Michal Jastrzebski wrote: From: Kuba Kozak Add file descriptor value check before calling close() function. Coverity issue: 141297 Fixes: 811b6b25060f ("vfio: fix file descriptor leak in multi-process") Cc: patr...@patrickmacarthur.net Cc: sta...@dpdk.org Signed-off-by

[dpdk-dev] [PATCH v2] librte_eal: fix wrong assert for arm and ppc

2017-09-21 Thread Lukasz Majczak
The assertion of return value from the open() function is done against 0, while it is a correct value - open() returns -1 in case of an error. It causes problems while trying to run as a daemon, in which case, this call to open() will return 0 as a valid descriptor. Fixes: b94e5c9406b5 ("eal/arm: a

Re: [dpdk-dev] [PATCH v4 1/4] eventdev: Add caps API and PMD callbacks for rte_event_eth_rx_adapter

2017-09-21 Thread Jerin Jacob
-Original Message- > Date: Fri, 22 Sep 2017 02:47:11 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com > CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, > harry.van.haa...@intel.com, hemant.agra...@nxp.com, nipun.gu...@nxp.com, > narend

Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and flush

2017-09-21 Thread Ferruh Yigit
On 9/21/2017 8:26 AM, Zhao1, Wei wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, September 21, 2017 3:10 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: queue region set and flush >> >> On 9/21/2017 7:48 AM, Zhao1, Wei wro

Re: [dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-21 Thread Pavan Nikhilesh Bhagavatula
Hi Nikhil, Few comments Inline On Fri, Sep 22, 2017 at 02:47:13AM +0530, Nikhil Rao wrote: > Add common APIs for configuring packet transfer from ethernet Rx > queues to event devices across HW & SW packet transfer mechanisms. > A detailed description of the adapter is contained in the header's >

Re: [dpdk-dev] [PATCH v4] devtools: rework abi checker script

2017-09-21 Thread Neil Horman
On Wed, Sep 20, 2017 at 11:12:53AM +0200, Olivier Matz wrote: > The initial version of the script had some limitations: > - cannot work on a non-clean workspace > - environment variables are not documented > - no compilation log in case of failure > - return success even it abi is incompatible > >

[dpdk-dev] Cannot allocate mempool with --no-huge since DPDK 16.07

2017-09-21 Thread tom . barbette
Hi all, I get a EINVAL since DPDK 16.07 when trying to allocate a mempool with rte_pktmbuf_pool_create. This is when I use --no-huge --vdev=eth_ring0. But this happens before accessing the virtual device in any ways. Which, btw shows the documentation is wrong as it indicates : EINVAL - cache

Re: [dpdk-dev] [PATCH] librte_eal: fix wrong assert for arm and ppc

2017-09-21 Thread Jan Viktorin
On Thu, 21 Sep 2017 15:04:04 +0200 Lukasz Majczak wrote: > The assertion of return value from the open() function is done against > 0, while it is a correct value - open() returns -1 in case of an error. > It causes problems while trying to run as a daemon, in which case, this > call to open() wi

[dpdk-dev] [PATCH] eal/bsdapp: add FreeBSD module compilation to meson build

2017-09-21 Thread Bruce Richardson
Support compiling the FreeBSD kernel modules using meson and ninja. Signed-off-by: Bruce Richardson --- config/rte_config.h | 5 lib/librte_eal/bsdapp/BSDmakefile.meson | 42 + lib/librte_eal/bsdapp/contigmem/meson.build | 32

Re: [dpdk-dev] [RFC] Wireless Base Band Device (bbdev)

2017-09-21 Thread Thomas Monjalon
25/08/2017 15:46, Amr Mokhtar: > +/** > + * Configure a device. > + * This function must be called on a device before setting up the queues and > + * starting the device. It can also be called when a device is in the stopped > + * state. If any device queues have been configured their configuration

Re: [dpdk-dev] [PATCH v4] net/af_packet: make bypass configurable

2017-09-21 Thread Ferruh Yigit
On 9/21/2017 10:57 AM, Chas Williams wrote: > From: "Charles (Chas) Williams" > > In certain situations, low speed interfaces, it may be desirable to > have the flow control provided by the kernel queueing disciplines. > > Signed-off-by: Chas Williams Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [RFC] Wireless Base Band Device (bbdev)

2017-09-21 Thread Thomas Monjalon
25/08/2017 15:46, Amr Mokhtar: > This RFC describes a proposal for the Wireless Base Band Device (bbdev) in > DPDK > that abstracts HW accelerators based on FPGA and/or Fixed Function > Accelerators > that assist with LTE Physical Layer processing. Furthermore, it decouples the > application f

Re: [dpdk-dev] [PATCH v3 1/3] eal: move bitmap from lib sched

2017-09-21 Thread Dumitrescu, Cristian
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Thursday, September 21, 2017 12:50 PM > To: Dumitrescu, Cristian ; > step...@networkplumber.org > Cc: dev@dpdk.org; Pavan Bhagavatula > > Subject: [dpdk-dev] [PATCH v3 1/3] eal: move bitmap from

[dpdk-dev] [PATCH v2] vfio: fix close unchecked file descriptor

2017-09-21 Thread Michal Jastrzebski
From: Kuba Kozak Add file descriptor value check before calling close() function. Coverity issue: 141297 Fixes: 811b6b25060f ("vfio: fix file descriptor leak in multi-process") Cc: patr...@patrickmacarthur.net Cc: sta...@dpdk.org Signed-off-by: Kuba Kozak Acked-by: Anatoly Burakov --- v2:

Re: [dpdk-dev] [PATCH 0/3] rte_mtr: generic ethdev API for metering and policing

2017-09-21 Thread Thomas Monjalon
26/08/2017 02:06, Cristian Dumitrescu: > This patch set introduces an ethdev-based generic API for Traffic > Metering and Policing (MTR), which is yet another standard RX offload for > Ethernet devices. Thanks for bringing yet another offload API. What are the expected devices to implement this A

Re: [dpdk-dev] [PATCH 2/3] ethdev: add new rte_mtr API for traffic metering and policing

2017-09-21 Thread Thomas Monjalon
26/08/2017 02:06, Cristian Dumitrescu: > +DPDK_17.11 { > + global: > + > + rte_eth_dev_mtr_ops_get; > + rte_mtr_meter_profile_add; > + rte_mtr_meter_profile_delete; > + rte_mtr_create; > + rte_mtr_destroy; > + rte_mtr_meter_profile_update; > + rte_mtr

Re: [dpdk-dev] [PATCH v4 41/41] net/dpaa: support for extended statistics

2017-09-21 Thread Shreyansh Jain
On Monday 18 September 2017 08:27 PM, Ferruh Yigit wrote: On 9/9/2017 12:21 PM, Shreyansh Jain wrote: From: Hemant Agrawal Signed-off-by: Hemant Agrawal <...> +static int +dpaa_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats, + unsigned int n) +{ +

Re: [dpdk-dev] [PATCH v4 40/41] net/dpaa: support for firmware version get API

2017-09-21 Thread Shreyansh Jain
On Monday 18 September 2017 08:27 PM, Ferruh Yigit wrote: On 9/9/2017 12:21 PM, Shreyansh Jain wrote: From: Hemant Agrawal Signed-off-by: Hemant Agrawal <...> +static int +dpaa_fw_version_get(struct rte_eth_dev *dev __rte_unused, +char *fw_version, +

Re: [dpdk-dev] [PATCH v4 36/41] net/dpaa: add support for packet type parsing

2017-09-21 Thread Shreyansh Jain
On Monday 18 September 2017 08:26 PM, Ferruh Yigit wrote: On 9/9/2017 12:21 PM, Shreyansh Jain wrote: Add support for parsing the packet type and L2/L3 checksum offload capability information. Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini

[dpdk-dev] [PATCH] librte_eal: fix wrong assert for arm and ppc

2017-09-21 Thread Lukasz Majczak
The assertion of return value from the open() function is done against 0, while it is a correct value - open() returns -1 in case of an error. It causes problems while trying to run as a daemon, in which case, this call to open() will return 0 as a valid descriptor. Signed-off-by: Lukasz Majczak

Re: [dpdk-dev] [PATCH v4 28/41] net/dpaa: add support for link status update

2017-09-21 Thread Shreyansh Jain
On Monday 18 September 2017 08:26 PM, Ferruh Yigit wrote: On 9/9/2017 12:21 PM, Shreyansh Jain wrote: Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain <...> +static int dpaa_eth_link_update(struct rte_eth_dev *dev, + int wait_to_complete __rte_unuse

Re: [dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup

2017-09-21 Thread Shreyansh Jain
On Monday 18 September 2017 08:25 PM, Ferruh Yigit wrote: On 9/9/2017 12:21 PM, Shreyansh Jain wrote: Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain <...> + +/* Handle all mbufs on an external pool (non-dpaa2) */ minor typo, but is intention dpaa ? Yes, this is 'dpaa'.

Re: [dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup

2017-09-21 Thread Shreyansh Jain
Hello Ferruh, Apologies for delay in response for these, I am already working to get the next version based on your comments. Meanwhile, some comments inline... On Monday 18 September 2017 08:25 PM, Ferruh Yigit wrote: On 9/9/2017 12:21 PM, Shreyansh Jain wrote: Signed-off-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v2] service: fix build error "ids uninitialized in rte_service_map_lcore_set"

2017-09-21 Thread Thomas Monjalon
21/09/2017 13:55, Van Haaren, Harry: > > From: Yang, Yi Y > > Sent: Thursday, September 21, 2017 2:51 AM > > To: dev@dpdk.org > > Cc: Van Haaren, Harry ; Yang, Yi Y > > > > Subject: [PATCH v2] service: fix build error "ids uninitialized in > > rte_service_map_lcore_set" > > > > v1->v2 > > - Cha

[dpdk-dev] [PATCH v4 4/4] eventdev: Add tests for event eth Rx adapter APIs

2017-09-21 Thread Nikhil Rao
Add unit tests for rte_event_eth_rx_adapter_xxx() APIs Signed-off-by: Nikhil Rao --- test/test/test_event_eth_rx_adapter.c | 399 ++ test/test/Makefile| 1 + 2 files changed, 400 insertions(+) create mode 100644 test/test/test_event_eth_rx_a

[dpdk-dev] [PATCH v4 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-21 Thread Nikhil Rao
Add common APIs for configuring packet transfer from ethernet Rx queues to event devices across HW & SW packet transfer mechanisms. A detailed description of the adapter is contained in the header's comments. The adapter implementation uses eventdev PMDs to configure the packet transfer if HW supp

[dpdk-dev] [PATCH v4 0/4] eventdev: cover letter: ethernet Rx queue event adapter

2017-09-21 Thread Nikhil Rao
Eventdev-based networking applications require a component to dequeue packets from NIC Rx queues and inject them into eventdev queues[1]. While some platforms (e.g. Cavium Octeontx) do this operation in hardware, other platforms use software. This patchset introduces an ethernet Rx event adapter t

[dpdk-dev] [PATCH v4 2/4] eventdev: Add ethernet Rx adapter caps function to eventdev SW PMD

2017-09-21 Thread Nikhil Rao
Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rte_eventdev_pmd.h | 6 ++ drivers/event/sw/sw_evdev.c| 15 +++ 2 files changed, 21 insertions(+) diff --git a/lib/librte_eventdev/rte_eventdev_pmd.h b/lib/librte_eventdev/rte_eventdev_pmd.h index 89990d1c4..de411fdf

[dpdk-dev] [PATCH v4 1/4] eventdev: Add caps API and PMD callbacks for rte_event_eth_rx_adapter

2017-09-21 Thread Nikhil Rao
The caps API allows application to get information needed to configure the ethernet receive adapter for the eventdev and ethdev pair. The PMD callbacks are used by the rte_event_eth_rx_xxx() APIs to configure and control the ethernet receive adapter if packet transfers from the ethdev to eventdev

Re: [dpdk-dev] [PATCH v3 0/4] eventdev: cover letter: ethernet Rx queue event adapter

2017-09-21 Thread Jerin Jacob
-Original Message- > Date: Tue, 12 Sep 2017 17:59:25 +0530 > From: Nikhil Rao > To: jerin.ja...@caviumnetworks.com, bruce.richard...@intel.com > CC: gage.e...@intel.com, dev@dpdk.org, tho...@monjalon.net, > harry.van.haa...@intel.com, hemant.agra...@nxp.com, nipun.gu...@nxp.com, > narend

Re: [dpdk-dev] [PATCH] app/testpmd: adds mlockall() to fix pages

2017-09-21 Thread Eelco Chaudron
On 19/09/17 09:28, Olivier MATZ wrote: Hi, On Thu, Sep 14, 2017 at 09:22:38AM +0200, Eelco Chaudron wrote: On 13/09/17 11:39, Thomas Monjalon wrote: 12/09/2017 15:08, Eelco Chaudron: Call the mlockall() function, to attempt to lock all of its process memory into physical RAM, and preventing t

Re: [dpdk-dev] [PATCH] eal: fix TSC resolution in hz for ppc_64 architecture

2017-09-21 Thread Jerin Jacob
-Original Message- > Date: Thu, 21 Sep 2017 17:11:26 +0530 > From: Gowrishankar > To: dev@dpdk.org > CC: Chao Zhu , Bruce Richardson > , Konstantin Ananyev > , Jerin Jacob > , Gowrishankar Muthukrishnan > > Subject: [PATCH] eal: fix TSC resolution in hz for ppc_64 architecture > X-Mai

Re: [dpdk-dev] [PATCH] eal: fix service array initialisation

2017-09-21 Thread Nélio Laranjeiro
Hi Harry, On Thu, Sep 21, 2017 at 11:53:48AM +, Van Haaren, Harry wrote: > > From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > > Sent: Thursday, September 21, 2017 12:48 PM > > To: dev@dpdk.org > > Cc: Van Haaren, Harry > > Subject: [PATCH] eal: fix service array initialisation > >

Re: [dpdk-dev] [PATCH v2] service: fix build error "ids uninitialized in rte_service_map_lcore_set"

2017-09-21 Thread Van Haaren, Harry
> From: Yang, Yi Y > Sent: Thursday, September 21, 2017 2:51 AM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Yang, Yi Y > > Subject: [PATCH v2] service: fix build error "ids uninitialized in > rte_service_map_lcore_set" > > v1->v2 > - Change title to more descriptive one > - Add issue reprodu

Re: [dpdk-dev] [PATCH] eal: fix service array initialisation

2017-09-21 Thread Van Haaren, Harry
> From: Nelio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Thursday, September 21, 2017 12:48 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry > Subject: [PATCH] eal: fix service array initialisation > > GCC is complaining on variable used without being initialised. > > dpdk.org/lib/libr

[dpdk-dev] [PATCH v3 3/3] maintainers: add maintainer for bitmap

2017-09-21 Thread Pavan Nikhilesh
From: Pavan Bhagavatula Signed-off-by: Pavan Nikhilesh --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a0cd75e..3522497 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -143,6 +143,11 @@ F: lib/librte_eal/common/rte_service.c F: doc/guides/

[dpdk-dev] [PATCH v3 2/3] test: add test for bitmap operations

2017-09-21 Thread Pavan Nikhilesh
From: Pavan Bhagavatula This patch adds a test for verifying the bitmap operations. Signed-off-by: Pavan Nikhilesh --- test/test/Makefile | 1 + test/test/test_bitmap.c | 192 2 files changed, 193 insertions(+) create mode 100644 test/te

[dpdk-dev] [PATCH v3 1/3] eal: move bitmap from lib sched

2017-09-21 Thread Pavan Nikhilesh
From: Pavan Bhagavatula The librte_sched uses rte_bitmap to manage large arrays of bits in an optimized method so, moving it to eal/common would allow other libraries and applications to use it. Signed-off-by: Pavan Nikhilesh --- v3 changes: - address review comments v2 changes: - undo rte_

Re: [dpdk-dev] [PATCH v4 2/5] ethdev: increase port_id range

2017-09-21 Thread Adrien Mazarguil
On Thu, Sep 21, 2017 at 04:32:40PM +0800, Zhiyong Yang wrote: > Extend port_id definition from uint8_t to uint16_t in lib and drivers > data structures, specifically rte_eth_dev_data. Modify the APIs, > drivers and app using port_id at the same time. > > Fix some checkpatch issues from the origina

[dpdk-dev] [PATCH] eal: fix service array initialisation

2017-09-21 Thread Nelio Laranjeiro
GCC is complaining on variable used without being initialised. dpdk.org/lib/librte_eal/common/rte_service.c: In function ‘rte_service_start_with_defaults’: dpdk.org/lib/librte_eal/common/rte_service.c:449:9: error: ‘ids[0]’ may be used uninitialized in this function [-Werror=maybe-uninitializ

[dpdk-dev] [PATCH] eal: fix TSC resolution in hz for ppc_64 architecture

2017-09-21 Thread Gowrishankar
From: Gowrishankar Muthukrishnan In ppc_64, rte_rdtsc() returns timebase register value which increments at independent timebase frequency and hence not related to lcore cpu frequency to derive into. In this patch, we fix get_tsc_freq() to not depend upon rte_rdtsc(), but obtain cpu current frequ

[dpdk-dev] [PATCH v3] eal: add function to check lcore role

2017-09-21 Thread Pavan Nikhilesh
From: Pavan Bhagavatula This function can be used to check the role of a specific lcore. Signed-off-by: Pavan Nikhilesh Acked-by: Harry van Haaren --- v3 changes: - moved changes to eal_common_thread.c - addressed coding style issues v2 changes: - removed ack due to significant changes in

Re: [dpdk-dev] [PATCH] app/testpmd: Fix relative rpath for drivers

2017-09-21 Thread Bruce Richardson
On Wed, Sep 20, 2017 at 06:41:28PM +0200, Timothy Redaelli wrote: > This commit fixes the setting of relative rpath on dpdk-testpmd for drivers > ($libdir/dpdk/drivers) to the correct absolute rpath > ($prefix$libdir/dpdk/drivers) > > Fixes: d123bba2dfbe ("build: add initial infrastructure for me

Re: [dpdk-dev] [PATCH v2 1/3] eal: move bitmap from lib sched

2017-09-21 Thread Pavan Nikhilesh Bhagavatula
On Thu, Sep 21, 2017 at 10:25:18AM +, Dumitrescu, Cristian wrote: Hi Cristian, > Hi Pavan, > > Thank you, just a couple of minor issues below: > Sure will spin up a v3 with the mentioned changes. Thanks, Pavan > > -Original Message- > > From: Pavan Nikhilesh [mailto:pbhagavat...@cavium

Re: [dpdk-dev] [PATCH v4 1/5] net/bonding: remove bonding APIs using ABI versioning

2017-09-21 Thread Ferruh Yigit
On 9/21/2017 9:32 AM, Zhiyong Yang wrote: > There are two bonding APIs using ABI versioning, and both have > port_id as parameter. Since we are already breaking ABI, no need > to keep older versions of APIs. > > Signed-off-by: Zhiyong Yang <...> > -int > -rte_eth_bond_8023ad_conf_get_v1708(uint

[dpdk-dev] [dpdk-announce] integration deadline for 17.11 features will move

2017-09-21 Thread Thomas Monjalon
As discussed with other maintainers, we need to move the integration deadline by one week: October 6 (instead of September 29) It will give us some time to work and review the features after the discussions which will happen during the summit (next week). When this change will be accepted

Re: [dpdk-dev] [PATCH v2 1/3] eal: move bitmap from lib sched

2017-09-21 Thread Dumitrescu, Cristian
Hi Pavan, Thank you, just a couple of minor issues below: > -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Wednesday, September 20, 2017 4:37 PM > To: Dumitrescu, Cristian ; > step...@networkplumber.org > Cc: dev@dpdk.org; Pavan Bhagavatula >

Re: [dpdk-dev] [PATCH] event/sw: rename map file to standard name

2017-09-21 Thread Jerin Jacob
-Original Message- > Date: Thu, 14 Sep 2017 16:23:36 + > From: "Van Haaren, Harry" > To: Jerin Jacob > CC: "dev@dpdk.org" , "Richardson, Bruce" > > Subject: RE: [PATCH] event/sw: rename map file to standard name > > > From: Richardson, Bruce > > Sent: Thursday, September 14, 2017 3

[dpdk-dev] [PATCH v2] examples/l3fwd: optimised packet processing on powerpc

2017-09-21 Thread Gowrishankar
From: Gowrishankar Muthukrishnan This patch adds altivec support for lpm packet processing in powerpc. Signed-off-by: Gowrishankar Muthukrishnan --- v2: * coding style standards MAINTAINERS| 1 + examples/l3fwd/l3fwd_altivec.h | 284 +

Re: [dpdk-dev] [PATCH] event/sw: remove spare newline from error logs

2017-09-21 Thread Jerin Jacob
-Original Message- > Date: Mon, 18 Sep 2017 14:42:20 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Harry van Haaren > > Subject: [PATCH] event/sw: remove spare newline from error logs > X-Mailer: git-send-email 2.7.4 > > This commit removes extr

Re: [dpdk-dev] [PATCH v2] eal: add function to check lcore role

2017-09-21 Thread Pavan Nikhilesh Bhagavatula
On Thu, Sep 21, 2017 at 09:41:29AM +, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Thursday, September 21, 2017 9:58 AM > > To: Van Haaren, Harry ; tho...@monjalon.net > > Cc: dev@dpdk.org; Pavan Bhagavatula > > Subject: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH] igb_uio: remove PCI reset during uio device open

2017-09-21 Thread Luca Boccassi
On Tue, 2017-09-19 at 15:54 +0530, Shijith Thotton wrote: > Issuing reset during uio device open caused PMD init failure for some > NIC VFs (i40, ixgbe, qede) in host. So this initial reset is removed. > Bus master enable is kept as part of open since we disable it in uio > device release. > > Fix

[dpdk-dev] [PATCH v4] net/af_packet: make bypass configurable

2017-09-21 Thread Chas Williams
From: "Charles (Chas) Williams" In certain situations, low speed interfaces, it may be desirable to have the flow control provided by the kernel queueing disciplines. Signed-off-by: Chas Williams --- drivers/net/af_packet/rte_eth_af_packet.c | 24 ++-- 1 file changed, 18 in

Re: [dpdk-dev] [PATCH v4 0/4] eventdev: add attribute based get APIs

2017-09-21 Thread Jerin Jacob
-Original Message- > Date: Fri, 15 Sep 2017 06:14:26 + > From: Nipun Gupta > To: Harry van Haaren , "dev@dpdk.org" > > CC: "jerin.ja...@caviumnetworks.com" > Subject: RE: [dpdk-dev] [PATCH v4 0/4] eventdev: add attribute based get > APIs > > > > > -- > > 2.7.4 > > Changes look

Re: [dpdk-dev] [PATCH] vfio: fix close unchecked file descriptor

2017-09-21 Thread Kozak, KubaX
Hi, Referring to Patrick suggestion I'll prepare patch with (fd >= 0) condition. Thanks, Kuba > -Original Message- > From: Patrick MacArthur [mailto:patr...@patrickmacarthur.net] > Sent: Thursday, September 21, 2017 04:28 > To: Burakov, Anatoly ; Kozak, KubaX > > Cc: dev@dpdk.org; sta

Re: [dpdk-dev] [PATCH v2] eal: add function to check lcore role

2017-09-21 Thread Van Haaren, Harry
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Thursday, September 21, 2017 9:58 AM > To: Van Haaren, Harry ; tho...@monjalon.net > Cc: dev@dpdk.org; Pavan Bhagavatula > Subject: [dpdk-dev] [PATCH v2] eal: add function to check lcore role > > From: Pavan Bhagavatula >

Re: [dpdk-dev] [PATCH v3] net/af_packet: make bypass configurable

2017-09-21 Thread Ferruh Yigit
On 9/21/2017 4:25 AM, Chas Williams wrote: > From: "Charles (Chas) Williams" > > In certain situations, low speed interfaces, it may be desirable to > have the flow control provided by the kernel queueing disciplines. > > Signed-off-by: Chas Williams > --- > drivers/net/af_packet/rte_eth_af_pa

Re: [dpdk-dev] [PATCH 10/12] vhost: support to kick in secondary process

2017-09-21 Thread Yuanhan Liu
On Thu, Sep 21, 2017 at 03:04:39PM +0800, Tan, Jianfeng wrote: > >On Fri, Aug 25, 2017 at 09:40:50AM +, Jianfeng Tan wrote: > >>To support kick in secondary process, we propose callfd_pri and > >>kickfd_pri to store the value in primary process; and by a new > >>API, rte_vhost_set_vring_effecti

Re: [dpdk-dev] [PATCH 07/11] ethdev: add rte flow action for crypto

2017-09-21 Thread Jerin Jacob
-Original Message- > Date: Thu, 14 Sep 2017 13:56:47 +0530 > From: Akhil Goyal > To: dev@dpdk.org > CC: declan.dohe...@intel.com, pablo.de.lara.gua...@intel.com, > hemant.agra...@nxp.com, radu.nico...@intel.com, bor...@mellanox.com, > avia...@mellanox.com, tho...@monjalon.net, sandeep.ma

Re: [dpdk-dev] [PATCH v5 2/5] cfgfile: change existing API functions

2017-09-21 Thread Kozak, KubaX
Hi Thomas, Yes we can wait to 18.02. I'll prepare v6 patchset without these changes. Best regards, Kuba > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, September 19, 2017 23:27 > To: Kozak, KubaX > Cc: dev@dpdk.org; Richardson, Bruce ; Jain, >

  1   2   >