Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-17 Thread Shijith Thotton
On Mon, Sep 18, 2017 at 03:50:30AM +, Yang, Qiming wrote: > Sorry, Gregory and Shijith > > I misunderstand your advice. > If we only remove PCI reset at igbuio_pci_open, not include > igbuio_pci_release, I think it is a good solution. > It reserve the functional of this patch and we have test

[dpdk-dev] [PATCH v3 2/3] net/i40e: add statistics protect for vf clear xstats

2017-09-17 Thread Wei Zhao
The diff_pkts_rx and diff_pkts_tx statistic data will be wrong when the first time after clear xstats command if there is no protect. Signed-off-by: Wei Zhao --- app/test-pmd/config.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/

[dpdk-dev] [PATCH v3 3/3] net/i40e: add support of reset stats in vf port

2017-09-17 Thread Wei Zhao
Add a new support of reset stats statics in vf port. Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_ethdev_vf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 806ff9e..13c472f 100644 --- a/drivers/net/i40e/i40e_

[dpdk-dev] [PATCH v3 1/3] net/i40e: fix clear xstats bug in vf port

2017-09-17 Thread Wei Zhao
There is a bug in vf clear xstats command, it do not record the statics data in offset struct member.So, vf need to keep record of xstats data from pf and update the statics according to offset. Fixes: da61cd0849766 ("i40evf: add extended stats") Signed-off-by: Wei Zhao --- Changes in v2: fi

Re: [dpdk-dev] [PATCH v2] net/liquidio: fix uninitialized variable

2017-09-17 Thread Shijith Thotton
On Fri, Sep 15, 2017 at 07:48:28AM -0400, Yong Wang wrote: > In func lio_dev_link_update(), "link.link_autoneg" is used in func call > lio_dev_atomic_write_link_status(), but is uninitialized. > > v2: > * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED' > to 'ETH_LINK_AUTONE

Re: [dpdk-dev] [PATCH v2 0/5] Optimize memcpy for AVX512 platforms

2017-09-17 Thread Wang, Zhihong
> Hi Zhihong Wang > > I test avx512 rte_memcpy found the performanc for ovs dpdk is lower than > avx2 rte_memcpy. Hi Haifeng, AVX512 memcpy is marked as experimental and disabled by default, its benefit varies from case to case. So enable it only when the case (SW + HW setup with expected data p

Re: [dpdk-dev] [PATCH 3/4] eventdev: Add eventdev ethernet Rx adapter

2017-09-17 Thread Rao, Nikhil
On 9/15/2017 11:37 AM, Nipun Gupta wrote: -Original Message- From: Nikhil Rao [mailto:nikhil@intel.com] +static inline void +fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter, + uint8_t dev_id, + uint16_t rx_queue_id, + struct rte_mbuf **mbufs, +

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-17 Thread Yang, Qiming
Sorry, Gregory and Shijith I misunderstand your advice. If we only remove PCI reset at igbuio_pci_open, not include igbuio_pci_release, I think it is a good solution. It reserve the functional of this patch and we have test on FVL 10G/40G/25G, all work fine. Qiming > -Original Message-

[dpdk-dev] [PATCH] app/testpmd: fix stats period can't quit normally in container

2017-09-17 Thread Phil Yang
While running testpmd in container with stats-period option, it can't quit normally after received SIGINT. Signed-off-by: Phil Yang --- app/test-pmd/testpmd.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index e097ee0.

Re: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush

2017-09-17 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, September 6, 2017 5:11 PM > To: Zhao1, Wei ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush > > On 9/1/2017 3:38 AM, Zhao1, Wei wrote: > > HI, Ferruh > > > >> -Original M

[dpdk-dev] [PATCH] app/testpmd: fix stats period can't quit normally in container

2017-09-17 Thread Phil Yang
While running testpmd in container with stats-period option, it can't quit normally after received SIGINT. Signed-off-by: Phil Yang --- app/test-pmd/testpmd.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index e097ee0.

[dpdk-dev] [PATCH] app/testpmd: fix stats period can't quit normally in container

2017-09-17 Thread Phil Yang
While running testpmd in container with stats-period option, it can't quit normally after received SIGINT. Signed-off-by: Phil Yang --- app/test-pmd/testpmd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index e097ee0..a4

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-17 Thread Zhang, Helin
Hi guys May I suggest to revert the patch first, as it blocks existing functionalities. Then the original authors can add it back with a fix? Regards, Helin -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yang, Qiming Sent: Monday, September 18, 2017 10:21 AM To:

Re: [dpdk-dev] vf init issue with patch igb_uio: issue FLR during open and release of device file

2017-09-17 Thread Yang, Qiming
Yes, I have tried, and it works. But I think removing this function also makes the patch meaningless. Qiming From: Gregory Etelson [mailto:greg...@weka.io] Sent: Sunday, September 17, 2017 10:50 AM To: Yang, Qiming Cc: tho...@monjalon.net; dev@dpdk.org; Tan, Jianfeng ; Thotton, Shijith ; Hu, Xu

[dpdk-dev] vmxnet3 ethernet driver

2017-09-17 Thread Mukunda Naresh
Hi All, Need your inputs on below functions. Vmxnet3 driver in dpdk does not have the whitelist filter for unicast mac addresses. So addition/removal of MAC addresses using rte_eth_dev_mac_addr_add and rte_eth_dev_mac_addr_remove will always fail in case of vmxnet3. These functions will always re

Re: [dpdk-dev] [PATCH 06/11] ethdev: extend ethdev to support security APIs

2017-09-17 Thread Shahaf Shuler
Hi Declan, Thursday, September 14, 2017 11:27 AM, Akhil Goyal: > > From: Declan Doherty > > rte_flow_action type and ethdev updated to support rte_security sessions > for crypto offload to ethernet device. > > Signed-off-by: Boris Pismenny > Signed-off-by: Aviad Yehezkel > Signed-off-by: Rad

Re: [dpdk-dev] [PATCH 01/11] lib/rte_security: add security library

2017-09-17 Thread Boris Pismenny
Hi Hemant, On 9/15/2017 8:33 AM, Hemant Agrawal wrote: > > Hi, > > On 9/14/2017 1:56 PM, Akhil Goyal wrote: > .. > > > diff --git a/lib/librte_security/rte_security.c > > b/lib/librte_security/rte_security.c > > new file mode 100644 > > index 000..5776246 > > --- /dev/null > > +++ b/lib/lib

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix rte flow egress

2017-09-17 Thread Boris Pismenny
This patch ensures that the egress flag is set for outbound inline flows. Signed-off-by: Boris Pismenny --- examples/ipsec-secgw/ipsec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index 3d241a2..b3694a5 100644 --- a/examples

[dpdk-dev] [PATCH 0/2] Document rte_flow security action

2017-09-17 Thread Boris Pismenny
This series updates the documentation regarding the use of rte_flow security actions for configuring crypto offload. This documentation attempts to provide guidelines for the use of security sessions with inline and protocol offloads. The documentation relfects my understanding of the current stat

[dpdk-dev] [PATCH 2/2] ethdev: update documentation for security action

2017-09-17 Thread Boris Pismenny
Signed-off-by: Boris Pismenny --- lib/librte_ether/rte_flow.h | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h index dce92ca..48d4fca 100644 --- a/lib/librte_ether/rte_flow.h +++ b/lib/librte_et

[dpdk-dev] [PATCH 1/2] doc: add details of rte_flow security actions

2017-09-17 Thread Boris Pismenny
Signed-off-by: Boris Pismenny --- doc/guides/prog_guide/rte_flow.rst | 83 +- 1 file changed, 81 insertions(+), 2 deletions(-) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 662a912..62da436 100644 --- a/doc/guides/

[dpdk-dev] [PATCH v4 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification

2017-09-17 Thread Shachar Beiser
Fixes: 3cf87e68d97b ("net/mlx5: remove old MLNX OFED 3.3 verification") Cc: sta...@dpdk.org Signed-off-by: Shachar Beiser --- I have rebased last patch [PATCH v3 2/2] net/mlx5: fix TSO MLNX OFED 3.3 verification --- drivers/net/mlx5/mlx5_prm.h | 3 --- 1 file changed, 3 deletions(-) diff --git

[dpdk-dev] [PATCH v4 1/2] net/mlx5: replace network to host macros

2017-09-17 Thread Shachar Beiser
Signed-off-by: Shachar Beiser --- I have rebased [PATCH v3 1/2] net/mlx5: replace network to host macros I have fixed a rebase conflict in mlx5_rxtx.h in line 609 -rte_wmb(); +rte_io_wmb(); --- drivers/net/mlx5/mlx5_mac.c | 8 +- drivers/net/mlx5/mlx5_mr.c | 2 +- drivers/

[dpdk-dev] [PATCH v6] net/mlx5: support upstream rdma-core

2017-09-17 Thread Shachar Beiser
This removes the dependency on specific Mellanox OFED libraries by using the upstream rdma-core and linux upstream community code. --- a. Compile with rdma-core commit f11292efd541 ("Merge pull request #202") b. Tested with linux kernel 4.13-rc4 c. For performance testing recommended to wait till

[dpdk-dev] [PATCH] net/mlx5: fix TSO segment size verification

2017-09-17 Thread Shahaf Shuler
TSO segment size must be larger then 0. Fixes: 3f13f8c23a7c ("net/mlx5: support hardware TSO") Cc: sta...@dpdk.org Signed-off-by: Shahaf Shuler Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_

Re: [dpdk-dev] [PATCH v5] net/mlx5: support upstream rdma-core

2017-09-17 Thread Shachar Beiser
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, September 14, 2017 4:47 PM > To: Shachar Beiser ; dev@dpdk.org > Cc: Adrien Mazarguil ; Nélio Laranjeiro > > Subject: Re: [dpdk-dev] [PATCH v5] net/mlx5: support upstream rdma-core > > On 9/14/20

Re: [dpdk-dev] [PATCH 04/11] lib/librte_net: add ESP header to generic flow steering

2017-09-17 Thread Boris Pismenny
Hi Hemant, > On 9/15/2017 07:51 AM, Hemant Agrawal wrote: > Hi Boris, > > On 9/14/2017 1:56 PM, Akhil Goyal wrote: > > From: Boris Pismenny > > > > The ESP header is required for IPsec crypto actions. > > > > > Signed-off-by: Boris Pismenny > > Signed-off-by: Aviad Yehezkel > > --- > > doc/a