[dpdk-dev] [PATCH 2/2] app/testpmd: get information about protocols defined in ddp profile

2017-08-29 Thread Kirill Rybalchenko
Update 'ddp get info' command to display protocols defined in a profile Signed-off-by: Kirill Rybalchenko --- app/test-pmd/cmdline.c | 94 +- 1 file changed, 93 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdli

[dpdk-dev] [PATCH 0/2] net/i40e: get information about protocols defined in ddp profile

2017-08-29 Thread Kirill Rybalchenko
This patch adds ability to request information about protocols defined in dynamic device personalization profile Kirill Rybalchenko (2): net/i40e: get information about protocols defined in ddp profile app/testpmd: get information about protocols defined in ddp profile app/test-pmd/cmdline.

[dpdk-dev] [PATCH 1/2] net/i40e: get information about protocols defined in ddp profile

2017-08-29 Thread Kirill Rybalchenko
This patch adds new package info types to get list of protocols, pctypes and ptypes defined in a profile Signed-off-by: Kirill Rybalchenko --- drivers/net/i40e/rte_pmd_i40e.c | 155 drivers/net/i40e/rte_pmd_i40e.h | 25 +++ 2 files changed, 180 inser

Re: [dpdk-dev] [PATCH v2] vhost: added user callbacks for socket open/close

2017-08-29 Thread Jens Freimann
On Tue, Aug 29, 2017 at 06:08:45AM +, Stojaczyk, DariuszX wrote: Hi Jens, I'm still not sure I understand the use case. So just for my understanding: users need to distinct between "the device is going away temporarily, keep the connection" and "we're shutting down for good", is that it?

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-29 Thread Shahaf Shuler
Tuesday, August 29, 2017 3:55 PM, Ferruh Yigit: > >> Considering the re-configuration is risky, and without other ideas I will > need to fall back to the error flow case. > >> Are we OK with that? > > > > I think we can take the risk of keeping this call to > > rte_eth_dev_configure() in the middle

Re: [dpdk-dev] [RFC PATCH 2/4] ethdev: introduce Rx queue offloads API

2017-08-29 Thread Shahaf Shuler
Tuesday, August 29, 2017 3:50 PM, Ferruh Yigit: > On 8/7/2017 11:54 AM, Shahaf Shuler wrote: > > Introduce a new API to configure Rx offloads. > > > > The new API will re-use existing DEV_RX_OFFLOAD_* flags to enable the > > different offloads. This will ease the process of adding a new Rx > > offl

Re: [dpdk-dev] [PATCH] net/failsafe: fix exec parameter parsing error flow

2017-08-29 Thread Matan Azrad
Hi Gaetan > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Tuesday, August 29, 2017 7:34 PM > To: Matan Azrad > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: Re: [PATCH] net/failsafe: fix exec parameter parsing error flow > > Hi Matan,

Re: [dpdk-dev] [PATCH 2/2] eal: add u64 bit variant for reciprocal

2017-08-29 Thread Pavan Nikhilesh Bhagavatula
On Tue, Aug 29, 2017 at 12:38:00PM -0700, Stephen Hemminger wrote: > On Wed, 30 Aug 2017 00:16:18 +0530 > Pavan Nikhilesh wrote: > Hi Stephen, > > +static inline uint64_t > > +mullhi_u64(uint64_t x, uint64_t y) > > { > > - uint32_t t = (uint32_t)(((uint64_t)a * R.m) >> 32); > > + __uint128_t

[dpdk-dev] [PATCH] net/bonding: strengthen the judgment of lacp packets

2017-08-29 Thread ZengGanghui
When the nic does not support vlan rx offload may be wrong, resulting in lacp packets will not be processed. Signed-off-by: ZengGanghui --- drivers/net/bonding/rte_eth_bond_pmd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/

[dpdk-dev] [PATCH] net/bonding: strengthen the judgment of lacp packets

2017-08-29 Thread ZengGanghui
When the nic does not support vlan rx offload may be wrong, resulting in lacp packets will not be processed. --- drivers/net/bonding/rte_eth_bond_pmd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_b

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-29 Thread Jiayu Hu
Hi Konstantin, Thanks for your important suggestions. My feedbacks are inline. On Wed, Aug 30, 2017 at 09:38:33AM +0800, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Hu, Jiayu > > Sent: Thursday, August 24, 2017 3:16 PM > > To: dev@dpdk.org > > Cc: Kavanagh, Mark B ;

Re: [dpdk-dev] [dpdk-stable] 17.05.2 patches review and test

2017-08-29 Thread Yuanhan Liu
On Wed, Aug 30, 2017 at 01:10:01AM +, Li, Xiaoyun wrote: > Hi! > About : net/i40e: revert fix of PF notify when VF not up > Since the previous patch which will cause a big issue wasn't accepted in > dpdk-stable. > I think there is no need to include the revert patch. Thanks for the note. This

Re: [dpdk-dev] [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support

2017-08-29 Thread Ananyev, Konstantin
> -Original Message- > From: Hu, Jiayu > Sent: Thursday, August 24, 2017 3:16 PM > To: dev@dpdk.org > Cc: Kavanagh, Mark B ; Ananyev, Konstantin > ; Tan, Jianfeng > ; Hu, Jiayu > Subject: [PATCH 2/5] gso/lib: add TCP/IPv4 GSO support > > This patch adds GSO support for TCP/IPv4 packets

Re: [dpdk-dev] [PATCH 1/5] lib: add Generic Segmentation Offload API framework

2017-08-29 Thread Ananyev, Konstantin
Hi Jiayu, > > Generic Segmentation Offload (GSO) is a SW technique to split large > packets into small ones. Akin to TSO, GSO enables applications to > operate on large packets, thus reducing per-packet processing overhead. > > To enable more flexibility to applications, DPDK GSO is implemented

Re: [dpdk-dev] [PATCH 0/5] Support TCP/IPv4, VxLAN and GRE GSO in DPDK

2017-08-29 Thread Ananyev, Konstantin
Hi Jiayu, Few questions/comments from me below in in next few mails. Thanks Konstantin > > Generic Segmentation Offload (GSO) is a SW technique to split large > packets into small ones. Akin to TSO, GSO enables applications to > operate on large packets, thus reducing per-packet processing overh

Re: [dpdk-dev] [dpdk-stable] 17.05.2 patches review and test

2017-08-29 Thread Li, Xiaoyun
Hi! About : net/i40e: revert fix of PF notify when VF not up Since the previous patch which will cause a big issue wasn't accepted in dpdk-stable. I think there is no need to include the revert patch. Best Regards, Xiaoyun Li -Original Message- From: stable [mailto:stable-boun...@dpd

Re: [dpdk-dev] [PATCH 04/12] vdev: move to drivers/bus

2017-08-29 Thread Tan, Jianfeng
Hi Gaetan, On 8/29/2017 6:04 AM, Gaëtan Rivet wrote: On Fri, Aug 25, 2017 at 09:40:44AM +, Jianfeng Tan wrote: Move the vdev bus from lib/librte_eal to drivers/bus. As the crypto vdev helper function refers to data structure in rte_vdev.h, so we move those helper function into drivers/bus

Re: [dpdk-dev] [PATCH 05/12] bus/vdev: change log type from EAL to PMD

2017-08-29 Thread Tan, Jianfeng
On 8/29/2017 5:54 AM, Gaëtan Rivet wrote: On Fri, Aug 25, 2017 at 09:40:45AM +, Jianfeng Tan wrote: Signed-off-by: Jianfeng Tan --- drivers/bus/vdev/vdev.c | 10 ++ drivers/bus/vdev/vdev_logs.h | 40 2 files changed, 46 insertions(

Re: [dpdk-dev] [PATCH 02/12] eal: avoid calling rte_vdev_init()

2017-08-29 Thread Tan, Jianfeng
Hi Gaetan, On 8/29/2017 5:50 AM, Gaëtan Rivet wrote: Hi, On Fri, Aug 25, 2017 at 09:40:42AM +, Jianfeng Tan wrote: We can call bus->plug() to avoid calling rte_vdev_init() explicitly. Signed-off-by: Jianfeng Tan --- lib/librte_eal/common/eal_common_dev.c | 21 + 1

Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets

2017-08-29 Thread David Harton (dharton)
> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Tuesday, August 29, 2017 3:29 PM > To: David Harton (dharton) > Cc: dev@dpdk.org > Subject: RE: [PATCH] ixgbe: add counter to track sw tx packets > > > > > -Original Message- > > From

Re: [dpdk-dev] [PATCH 2/2] eal: add u64 bit variant for reciprocal

2017-08-29 Thread Stephen Hemminger
On Wed, 30 Aug 2017 00:16:18 +0530 Pavan Nikhilesh wrote: > +static inline uint64_t > +mullhi_u64(uint64_t x, uint64_t y) > { > - uint32_t t = (uint32_t)(((uint64_t)a * R.m) >> 32); > + __uint128_t xl = x; > + __uint128_t yl = y; > + __uint128_t rl = xl * yl; > + return (uint

Re: [dpdk-dev] [PATCH 2/2] eal: add u64 bit variant for reciprocal

2017-08-29 Thread Stephen Hemminger
On Wed, 30 Aug 2017 00:16:18 +0530 Pavan Nikhilesh wrote: > +/* > + * libdivide > + * Copyright (C) 2010 ridiculous_fish > + * This software is provided 'as-is', without any express or implied > + * warranty. In no event will the authors be held liable for any damages > + * arising from the use

Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets

2017-08-29 Thread Ananyev, Konstantin
> -Original Message- > From: David Harton [mailto:dhar...@cisco.com] > Sent: Tuesday, August 29, 2017 4:51 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; David Harton > Subject: [PATCH] ixgbe: add counter to track sw tx packets > > Add counter to track packets transmitted at the soft

Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets

2017-08-29 Thread David Harton (dharton)
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, August 29, 2017 2:43 PM > To: David Harton (dharton) > Cc: konstantin.anan...@intel.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets > > On Tu

[dpdk-dev] [PATCH 2/2] eal: add u64 bit variant for reciprocal

2017-08-29 Thread Pavan Nikhilesh
Currently, rte_reciprocal only supports unsigned 32bit divisors. This commit adds support for unsigned 64bit divisors. Rename unsigned 32bit specific functions appropriately and update librte_sched accordingly. Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/bsdapp/eal/rte_eal_version.map |

[dpdk-dev] [PATCH 1/2] eal: introduce integer divide through reciprocal

2017-08-29 Thread Pavan Nikhilesh
In some use cases of integer division, denominator remains constant and numerator varies. It is possible to optimize division for such specific scenarios. The librte_sched uses rte_reciprocal to optimize division so, moving it to eal/common would allow other libraries and applications to use it.

Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets

2017-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2017 11:50:56 -0400 David Harton wrote: > Add counter to track packets transmitted at the software layer > to help isolate output errors not reported otherwise. > > Signed-off-by: David Harton > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 98 > -

Re: [dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets

2017-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2017 11:50:56 -0400 David Harton wrote: > + if (n < (IXGBEVF_NB_XSTATS + IXGBE_NB_SW_STATS)) > + return (IXGBEVF_NB_XSTATS + IXGBE_NB_SW_STATS); Please don't use BSD style. Return does not need parenthesis.

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/failsafe: fix parameters parsing

2017-08-29 Thread Ferruh Yigit
On 8/28/2017 8:52 AM, Gaëtan Rivet wrote: > Hi Matan, > > thanks > > On Sun, Aug 27, 2017 at 10:23:14AM +0300, Matan Azrad wrote: >> The corrupted code used wrongly snprintf return value as the >> number of characters actually copied, in spite of the meanning >> is the number of characters which

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: specify correct scale table size on Rx start

2017-08-29 Thread Ferruh Yigit
On 8/28/2017 1:53 PM, Andrew Rybchenko wrote: > From: Ivan Malov > > efx_rx_scale_tbl_set() takes the number of entries in the scale table > to be set, not the size of the table in bytes; currently this bug does > not make any damage since the size argument is used to wrap the loop > on the input

Re: [dpdk-dev] [PATCH v2 0/2] mlx5 high latency observed on send operations

2017-08-29 Thread Ferruh Yigit
On 8/27/2017 7:47 AM, Shahaf Shuler wrote: > from s...@grimberg.me: > > When measuring latency when running a latency critical workload on mlx5 pmd > drivers we noticed high latency can occur due to delayed doorbell record > update flush. > > This can be reproduced using the simple program [1]

Re: [dpdk-dev] [PATCH] net/failsafe: fix exec parameter parsing error flow

2017-08-29 Thread Gaëtan Rivet
Hi Matan, On Tue, Aug 29, 2017 at 05:59:08PM +0300, Matan Azrad wrote: > The corrupted code returns success value in case of the > execution process output stream is empty(EOF). > It causes to segmentation fault while failsafe polls > this command line again, than gets success and tries to > do ho

Re: [dpdk-dev] [PATCH] ixgbe: eliminate duplicate filterlist symbols

2017-08-29 Thread Ferruh Yigit
On 8/28/2017 6:13 PM, David Harton (dharton) wrote: > > >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Monday, August 28, 2017 9:27 AM >> To: David Harton (dharton) ; >> konstantin.anan...@intel.com >> Cc: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATC

[dpdk-dev] [PATCH] bus: skip useless iterations in rte_bus_find

2017-08-29 Thread Gaetan Rivet
The starting point is known. The iterator can be directly set to it. The function rte_bus_find can easily be used with a comparison function always returning True. This would make it a regular bus iterator. Users doing so would however accomplish such iteration in O(N * N/2) = O(N^2) Which c

Re: [dpdk-dev] [PATCH 8/8] net/bnxt: add support for flow filter ops

2017-08-29 Thread Ferruh Yigit
On 8/24/2017 5:29 PM, Ajit Khaparde wrote: > This patch adds support for flow validate/create/destroy/flush ops. Can you please update feature file [1] to document flow API support and for supported filters. Also I believe this worth mentioning in release notes [2]. [1] doc/guides/nics/features/

Re: [dpdk-dev] [PATCH v2 1/3] timer: add per-installer pending lists for each lcore

2017-08-29 Thread Carrillo, Erik G
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, August 29, 2017 5:57 AM > To: Carrillo, Erik G ; rsanf...@akamai.com > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 1/3] timer: add per-installer pending lists > for each lcore > > Hi Gabriel, > > >

Re: [dpdk-dev] [PATCH 7/8] net/bnxt: fix HWRM_*() macros and locking

2017-08-29 Thread Ferruh Yigit
On 8/24/2017 5:29 PM, Ajit Khaparde wrote: > Obtain the spinlock in HWRM_PREP() > Eliminate two unnecessary arguments in HWRM_PREP(). > Unlock the spinlock before returning in HWRM_ERROR_CHECK() > Add new HWRM_UNLOCK() macro > Update usage of the thre macros. > > Signed-off-by: Ajit Khaparde <..

Re: [dpdk-dev] [PATCH 5/8] net/bnxt: add support for tx_descriptor_status

2017-08-29 Thread Ferruh Yigit
On 8/24/2017 5:29 PM, Ajit Khaparde wrote: > add support for tx_descriptor_status dev_op > Signed-off-by: Ajit Khaparde <...> > +static int > +bnxt_tx_descriptor_status_op(void *tx_queue, uint16_t offset) > +{ > + struct bnxt_tx_queue *txq = (struct bnxt_tx_queue *)tx_queue; > + struct b

Re: [dpdk-dev] [PATCH 4/8] net/bnxt: add support for rx_descriptor_done

2017-08-29 Thread Ferruh Yigit
On 8/24/2017 5:29 PM, Ajit Khaparde wrote: > add support for rx_descriptor_done dev_op > Signed-off-by: Ajit Khaparde <...> > @@ -1615,6 +1637,7 @@ static const struct eth_dev_ops bnxt_dev_ops = { > .xstats_get_names_by_id = bnxt_dev_xstats_get_names_by_id_op, > .rx_queue_count = bnx

Re: [dpdk-dev] [PATCH 3/8] net/bnxt: add support for rx_descriptor_status

2017-08-29 Thread Ferruh Yigit
On 8/24/2017 5:29 PM, Ajit Khaparde wrote: > add support for rx_descriptor_status dev_op > Signed-off-by: Ajit Khaparde <...> > +static int > +bnxt_rx_descriptor_status_op(void *rx_queue, uint16_t offset) > +{ > + struct bnxt_rx_queue *rxq = (struct bnxt_rx_queue *)rx_queue; > + struct b

Re: [dpdk-dev] [PATCH 2/8] net/bnxt: add support for rx_queue_count

2017-08-29 Thread Ferruh Yigit
On 8/24/2017 5:29 PM, Ajit Khaparde wrote: > add support for rx_queue_count dev_op > Signed-off-by: Ajit Khaparde <...> > +static uint32_t > +bnxt_rx_queue_count_op(struct rte_eth_dev *dev, uint16_t rx_queue_id) > +{ > + uint32_t desc = 0, raw_cons = 0, cons; > + struct bnxt_cp_ring_info

Re: [dpdk-dev] [PATCH 1/8] net/bnxt: add support for xstats get by id

2017-08-29 Thread Ferruh Yigit
On 8/24/2017 5:29 PM, Ajit Khaparde wrote: > This patch adds support for xstats_get_by_id/xstats_get_names_by_id. > Signed-off-by: Ajit Khaparde <...> > + > +int bnxt_dev_xstats_get_by_id_op(struct rte_eth_dev *dev, const uint64_t > *ids, > + uint64_t *values, unsigned int limit) >

Re: [dpdk-dev] [RFC PATCH 0/1] eventtimer: introduce event timer wheel

2017-08-29 Thread Jerin Jacob
-Original Message- > Date: Tue, 29 Aug 2017 17:48:58 +0200 > From: Thomas Monjalon > To: Jerin Jacob > Cc: "Carrillo, Erik G" , dev@dpdk.org, > "Richardson, Bruce" , "Van Haaren, Harry" > , "hemant.agra...@nxp.com" > , "Eads, Gage" , > "nipun.gu...@nxp.com" , "Vangati, Narender" > ,

[dpdk-dev] [PATCH] ixgbe: add counter to track sw tx packets

2017-08-29 Thread David Harton
Add counter to track packets transmitted at the software layer to help isolate output errors not reported otherwise. Signed-off-by: David Harton --- drivers/net/ixgbe/ixgbe_ethdev.c | 98 drivers/net/ixgbe/ixgbe_ethdev.h | 9 drivers/net/ixgbe/ixgbe

Re: [dpdk-dev] [RFC PATCH 0/1] eventtimer: introduce event timer wheel

2017-08-29 Thread Thomas Monjalon
29/08/2017 17:41, Jerin Jacob: > From: Thomas Monjalon > > 25/08/2017 12:25, Jerin Jacob: > > > From: "Carrillo, Erik G" > > [...] > > > > In summary, it looks like our solutions align fairly well, and I > > > > propose that we take on the software implementation if there are no > > > > objecti

Re: [dpdk-dev] [RFC PATCH 0/1] eventtimer: introduce event timer wheel

2017-08-29 Thread Jerin Jacob
-Original Message- > Date: Tue, 29 Aug 2017 17:02:43 +0200 > From: Thomas Monjalon > To: Jerin Jacob , "Carrillo, Erik G" > > Cc: dev@dpdk.org, "Richardson, Bruce" , "Van > Haaren, Harry" , "hemant.agra...@nxp.com" > , "Eads, Gage" , > "nipun.gu...@nxp.com" , "Vangati, Narender" > ,

[dpdk-dev] [PATCH 2/2] net/mlx5: improve stack usage during link update

2017-08-29 Thread Nelio Laranjeiro
Allocate no more memory than necessary for the second call to ETHTOOL_GLINKSETTINGS. Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_ethdev.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/dri

[dpdk-dev] [PATCH 1/2] net/mlx5: fix clang compilation

2017-08-29 Thread Nelio Laranjeiro
On redhat 7.2 clang reports the following error: CC mlx5_rxmode.o /drivers/net/mlx5/mlx5_ethdev.c:820:32: error: field 'edata' with variable sized type 'struct ethtool_link_settings' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]

Re: [dpdk-dev] [dpdk-techboard] next techboard meeting (29th, August)

2017-08-29 Thread Jerin Jacob
-Original Message- > Date: Mon, 28 Aug 2017 16:04:10 +0100 > From: Bruce Richardson > To: Jerin Jacob > CC: techbo...@dpdk.org, dev@dpdk.org > Subject: Re: [dpdk-techboard] next techboard meeting (29th, August) > User-Agent: Mutt/1.8.3 (2017-05-23) > > On Sun, Aug 27, 2017 at 06:54:35PM

Re: [dpdk-dev] [PATCH v2] kni: fix build on SLE12 SP3

2017-08-29 Thread Stephen Hemminger
On Tue, 29 Aug 2017 17:06:13 +0200 Nirmoy Das wrote: > compilation error: > build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error: > ‘struct net_device’ has no member named ‘trans_start’ > dev->trans_start = jiffies; > > Signed-off-by: Nirmoy Das > --- > lib/librte_eal/linuxapp/kni/compat

Re: [dpdk-dev] [PATCH 1/3] timer: add per-installer pending lists for each lcore

2017-08-29 Thread Stephen Hemminger
On Wed, 23 Aug 2017 09:47:22 -0500 Gabriel Carrillo wrote: > __TIMER_STAT_ADD(manage, 1); > - /* optimize for the case where per-cpu list is empty */ > - if (priv_timer[lcore_id].pending_head.sl_next[0] == NULL) > - return; > - cur_time = rte_get_timer_cycles(); > +

[dpdk-dev] [PATCH v2] kni: fix build on SLE12 SP3

2017-08-29 Thread Nirmoy Das
compilation error: build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error: ‘struct net_device’ has no member named ‘trans_start’ dev->trans_start = jiffies; Signed-off-by: Nirmoy Das --- lib/librte_eal/linuxapp/kni/compat.h | 32 +++- 1 file changed, 31 insertions

Re: [dpdk-dev] [RFC PATCH 0/1] eventtimer: introduce event timer wheel

2017-08-29 Thread Thomas Monjalon
25/08/2017 12:25, Jerin Jacob: > From: "Carrillo, Erik G" [...] > > In summary, it looks like our solutions align fairly well, and I propose > > that we take on the software implementation if there are no objections. > > Sure, no objection. Good to see such a basic function generalized for NPU

[dpdk-dev] [PATCH] net/failsafe: fix exec parameter parsing error flow

2017-08-29 Thread Matan Azrad
The corrupted code returns success value in case of the execution process output stream is empty(EOF). It causes to segmentation fault while failsafe polls this command line again, than gets success and tries to do hotplug add to the sub device by uninitialized pointer dereferencing. Morever, when

Re: [dpdk-dev] [RFC PATCH 0/1] IPSec Inline and look aside crypto offload

2017-08-29 Thread Thomas Monjalon
Hi, I try to understand how things are connected, but too many things are not clear for someone not involved in security. 25/07/2017 13:21, Akhil Goyal: > struct rte_security_session * > rte_security_session_create(struct rte_mempool *mempool); What is the usage of this mempool? [...] > These a

Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore` API.

2017-08-29 Thread Pavan Nikhilesh Bhagavatula
On Tue, Aug 29, 2017 at 01:17:18PM +, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Monday, August 28, 2017 4:43 PM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_i

Re: [dpdk-dev] [RFC PATCH 3/5] rte_security: updates and enabled security operations for ethdev

2017-08-29 Thread Akhil Goyal
Hi Radu, On 8/29/2017 6:43 PM, Radu Nicolau wrote: @@ -70,9 +70,9 @@ struct rte_security_ipsec_tunnel_param {   } ipv4; /**< IPv4 header parameters */     struct { -    struct in6_addr *src_addr; +    struct in6_addr src_addr;   /**< IPv6 source address

Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore` API.

2017-08-29 Thread Van Haaren, Harry
> From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@caviumnetworks.com] > Sent: Monday, August 28, 2017 4:43 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] eal: added new `rte_lcore_is_service_lcore` > API. > > On Mon, Aug 28, 2017 at 03:24:06PM +, Van H

Re: [dpdk-dev] [PATCH v4] service: add API for service count per lcore

2017-08-29 Thread Van Haaren, Harry
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Tuesday, August 29, 2017 1:33 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v4] service: add API for service count per lcore > > This new API returns the number of services that

Re: [dpdk-dev] [RFC PATCH 3/5] rte_security: updates and enabled security operations for ethdev

2017-08-29 Thread Radu Nicolau
Hi, On 8/29/2017 1:14 PM, Akhil Goyal wrote: Hi Radu, On 8/25/2017 8:27 PM, Radu Nicolau wrote: Signed-off-by: Radu Nicolau --- lib/Makefile | 1 + lib/librte_cryptodev/rte_cryptodev_pmd.h | 4 +-- lib/librte_cryptodev/rte_cryptodev_version.map |

Re: [dpdk-dev] [RFC PATCH 2/4] ethdev: introduce Rx queue offloads API

2017-08-29 Thread Ferruh Yigit
On 8/7/2017 11:54 AM, Shahaf Shuler wrote: > Introduce a new API to configure Rx offloads. > > The new API will re-use existing DEV_RX_OFFLOAD_* flags > to enable the different offloads. This will ease the process > of adding a new Rx offloads, as no ABI breakage is involved. > In addition, the of

Re: [dpdk-dev] [RFC PATCH 4/5] ixgbe: enable inline ipsec

2017-08-29 Thread Radu Nicolau
Hi, I will try to address all issues in the next iteration; and some comments inline. Regards, Radu On 8/28/2017 6:47 PM, Ananyev, Konstantin wrote: Hi Radu, Few questions comments from me below. Thanks Konstantin Signed-off-by: Radu Nicolau --- config/common_base |

Re: [dpdk-dev] [PATCH 04/12] vdev: move to drivers/bus

2017-08-29 Thread Gaëtan Rivet
On Fri, Aug 25, 2017 at 09:40:44AM +, Jianfeng Tan wrote: > Move the vdev bus from lib/librte_eal to drivers/bus. > > As the crypto vdev helper function refers to data structure > in rte_vdev.h, so we move those helper function into drivers/bus > too. > > Signed-off-by: Jianfeng Tan > --- >

Re: [dpdk-dev] [PATCH v1 0/10] Policy Based Power Control for Guest

2017-08-29 Thread Ananyev, Konstantin
Hi Dave, > This patchset adds the facility for a guest VM to send a policy down to > the host that will allow the host to scale up/down cpu frequencies > depending on the policy criteria independently of the DPDK app running in > the guest. This differs from the previous vm_power implementation

Re: [dpdk-dev] [RFC PATCH 0/5] Enable IPSec Inline for IXGBE PMD

2017-08-29 Thread Boris Pismenny
Hi Radu, In the our previous RFC, I got the impression that we had a consensus about using rte_flow for inline and full protocol offload to net PMDs. However, this patchset doesn't follow this convention. The rte_flow API allows for all future encapsulations of these protocols to be expressed with

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-29 Thread Ferruh Yigit
On 8/25/2017 2:26 PM, Thomas Monjalon wrote: > 24/08/2017 09:12, Shahaf Shuler: >> Thursday, August 24, 2017 1:06 AM, Thomas Monjalon: >>> 23/08/2017 15:13, Shahaf Shuler: Wednesday, August 23, 2017 3:29 PM, Ananyev, Konstantin: > From: Shahaf Shuler >> In order to enable PMDs to suppo

Re: [dpdk-dev] [PATCH 05/12] bus/vdev: change log type from EAL to PMD

2017-08-29 Thread Gaëtan Rivet
On Fri, Aug 25, 2017 at 09:40:45AM +, Jianfeng Tan wrote: > Signed-off-by: Jianfeng Tan > --- > drivers/bus/vdev/vdev.c | 10 ++ > drivers/bus/vdev/vdev_logs.h | 40 > 2 files changed, 46 insertions(+), 4 deletions(-) > create mode 100644

Re: [dpdk-dev] [PATCH 02/12] eal: avoid calling rte_vdev_init()

2017-08-29 Thread Gaëtan Rivet
Hi, On Fri, Aug 25, 2017 at 09:40:42AM +, Jianfeng Tan wrote: > We can call bus->plug() to avoid calling rte_vdev_init() explicitly. > > Signed-off-by: Jianfeng Tan > --- > lib/librte_eal/common/eal_common_dev.c | 21 + > 1 file changed, 5 insertions(+), 16 deletions(-)

Re: [dpdk-dev] [RFC PATCH 2/4] ethdev: introduce Rx queue offloads API

2017-08-29 Thread Ferruh Yigit
On 8/7/2017 11:54 AM, Shahaf Shuler wrote: > Introduce a new API to configure Rx offloads. > > The new API will re-use existing DEV_RX_OFFLOAD_* flags > to enable the different offloads. This will ease the process > of adding a new Rx offloads, as no ABI breakage is involved. > In addition, the of

[dpdk-dev] [PATCH v4] service: add API for service count per lcore

2017-08-29 Thread Pavan Nikhilesh
This new API returns the number of services that are running on a specific service core. It allows an application to decide which service core to run a new service on. Signed-off-by: Pavan Nikhilesh --- v4 changes: - fix doxygen errors v3 changes: - fix compilation issues with .map files v2

Re: [dpdk-dev] [PATCH v3] service: add API for service count per lcore

2017-08-29 Thread Pavan Nikhilesh Bhagavatula
On Tue, Aug 29, 2017 at 12:05:12PM +, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Tuesday, August 29, 2017 12:00 PM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [dpdk-dev] [PATCH v3] service: add API for

Re: [dpdk-dev] [RFC PATCH 3/5] rte_security: updates and enabled security operations for ethdev

2017-08-29 Thread Akhil Goyal
Hi Radu, On 8/25/2017 8:27 PM, Radu Nicolau wrote: Signed-off-by: Radu Nicolau --- lib/Makefile | 1 + lib/librte_cryptodev/rte_cryptodev_pmd.h | 4 +-- lib/librte_cryptodev/rte_cryptodev_version.map | 10 lib/librte_cryptodev/rte_security.

Re: [dpdk-dev] [PATCH v3] service: add API for service count per lcore

2017-08-29 Thread Van Haaren, Harry
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Tuesday, August 29, 2017 12:00 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v3] service: add API for service count per lcore > > This new API returns the number of services tha

Re: [dpdk-dev] [RFC PATCH 5/5] examples/ipsec-secgw: enabled inline ipsec

2017-08-29 Thread Akhil Goyal
Hi Radu, On 8/25/2017 8:27 PM, Radu Nicolau wrote: Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/esp.c | 26 -- examples/ipsec-secgw/ipsec.c | 61 +++-- examples/ipsec-secgw/ipsec.h | 2 ++ examples/ipsec-secgw/sa.c| 65 +

[dpdk-dev] [PATCH v3] service: add API for service count per lcore

2017-08-29 Thread Pavan Nikhilesh
This new API returns the number of services that are running on a specific service core. It allows an application to decide which service core to run a new service on. Signed-off-by: Pavan Nikhilesh --- v3 changes: - fix compilation issues with .map files v2 changes: - reword the commit tit

Re: [dpdk-dev] [PATCH v2 1/3] timer: add per-installer pending lists for each lcore

2017-08-29 Thread Ananyev, Konstantin
Hi Gabriel, > > Instead of each priv_timer struct containing a single skiplist, this > commit adds a skiplist for each enabled lcore to priv_timer. In the case > that multiple lcores repeatedly install timers on the same target lcore, > this change reduces lock contention for the target lcore's s

Re: [dpdk-dev] [PATCH v2] service: add API for service count per lcore

2017-08-29 Thread Pavan Nikhilesh Bhagavatula
On Tue, Aug 29, 2017 at 09:57:11AM +, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Monday, August 28, 2017 5:07 PM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [dpdk-dev] [PATCH v2] service: add API for s

Re: [dpdk-dev] [PATCH v2] service: add API for service count per lcore

2017-08-29 Thread Van Haaren, Harry
> From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Monday, August 28, 2017 5:07 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v2] service: add API for service count per lcore > > This new API returns the number of services that

[dpdk-dev] [PATCH] examples/l2fwd-cat: fix build according to API changes

2017-08-29 Thread Vladimir Kuramshin
Current version is compatible with PQOS version 1.3 but not compatible with higher versions. This change makes l2fwd-cat example compatible with versions since 1.4 Signed-off-by: Vladimir Kuramshin --- examples/l2fwd-cat/Makefile | 5 +--- examples/l2fwd-cat/cat.c| 60 ++

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-29 Thread Ananyev, Konstantin
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Tuesday, August 29, 2017 7:27 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Subject: RE: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the > new offloads API > > Monday, August 28, 2017 5:12 PM,

[dpdk-dev] 17.05.2 patches review and test

2017-08-29 Thread Yuanhan Liu
Hi all, Here is a list of patches targeted for stable release 17.05.2. Please help review and test. The planned date for the final release is 7th, Sep. Before that, please let me know if anyone has objections with these patches being applied. These patches are located at branch 17.05 of dpdk-stab

Re: [dpdk-dev] [PATCH v3] net/failsafe: fix failsafe bus uninit return value

2017-08-29 Thread Gaëtan Rivet
On Tue, Aug 29, 2017 at 12:08:08PM +0300, Raslan Darawsheh wrote: > fs_bus_uninit is always returning 0 no matter what was the status > of each sub device bus_uninit value. > > Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") > No need to send another version, but for next time: you could hav

[dpdk-dev] [PATCH v3] net/failsafe: fix failsafe bus uninit return value

2017-08-29 Thread Raslan Darawsheh
fs_bus_uninit is always returning 0 no matter what was the status of each sub device bus_uninit value. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh --- drivers/net/failsafe/failsafe_eal.c | 19 +-- 1 file changed, 9 insertions(+), 10 deleti

Re: [dpdk-dev] [PATCH v2] net/failsafe: fix failsafe bus uninit return value

2017-08-29 Thread Gaëtan Rivet
On Tue, Aug 29, 2017 at 11:55:45AM +0300, Raslan Darawsheh wrote: > fs_bus_uninit is always returning 0 no matter what was the status > of each sub device bus_uninit value. > > Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") > > Signed-off-by: Raslan Darawsheh > --- > drivers/net/failsafe/f

[dpdk-dev] [PATCH v2] net/failsafe: fix failsafe bus uninit return value

2017-08-29 Thread Raslan Darawsheh
fs_bus_uninit is always returning 0 no matter what was the status of each sub device bus_uninit value. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh --- drivers/net/failsafe/failsafe_eal.c | 20 ++-- 1 file changed, 10 insertions(+), 10 dele

Re: [dpdk-dev] [PATCH v3] eal/linuxapp: check mmap return value MAP_FAILED

2017-08-29 Thread Sergio Gonzalez Monroy
On 28/08/2017 22:49, Seth Howell wrote: If mmap fails, it will return the value MAP_FAILED. Checking for this return code allows us to properly identify mmap failures and report them as such to the calling function. Signed-off-by: Seth Howell --- lib/librte_eal/linuxapp/eal/eal_memory.c | 2 +

[dpdk-dev] [PATCH v2] net/mlx5: support device removal event

2017-08-29 Thread Matan Azrad
Extend the LSC event handling to support the device removal as well. The Verbs library may send several related events, which are different from LSC event. The mlx5 event handling has been made capable of receiving and signaling several event types at once. This support includes next: 1. Removal

[dpdk-dev] [PATCH] net/virtio: fix an incorrect behavior of device stop/start

2017-08-29 Thread Tiwei Bie
After starting a device, the driver shouldn't deliver the packets that already existed in the device before it is started to the applications. This patch fixes this issue by flushing the Rx queues when starting the device. Fixes: a85786dc816f ("virtio: fix states handling during initialization") C

Re: [dpdk-dev] [PATCH] net/failsafe: fix failsafe bus uninit return value

2017-08-29 Thread Gaëtan Rivet
Hi Raslan, On Tue, Aug 29, 2017 at 10:51:29AM +0300, Raslan Darawsheh wrote: > fs_bus_uninit is always returning 0 no matter what was the status > of each sub device bus_uninit value. An error on fs_bus_uninit should not stop failsafe_eal_uninit from finishing its operation. So for the sake of i

[dpdk-dev] [PATCH] net/failsafe: fix failsafe bus uninit return value

2017-08-29 Thread Raslan Darawsheh
fs_bus_uninit is always returning 0 no matter what was the status of each sub device bus_uninit value. Will now return the first sub device fail value in case it fails. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh --- drivers/net/failsafe/failsafe_eal.c |

Re: [dpdk-dev] using rte_flow via tespmd with Intel X552

2017-08-29 Thread Adrien Mazarguil
On Tue, Aug 08, 2017 at 09:57:34AM +0100, Ferruh Yigit wrote: > On 8/2/2017 2:41 PM, Adrien Mazarguil wrote: > > Hi Wenzhuo, > > > > On Wed, Aug 02, 2017 at 01:00:47PM +, Lu, Wenzhuo wrote: > >> Hi, > >> > >>> -Original Message- > >>> From: Zhao1, Wei > >>> Sent: Wednesday, August 2, 2

[dpdk-dev] [PATCH v2] crypto/openssl: add openssl path for cross compile

2017-08-29 Thread Akhil Goyal
OPENSSL_PATH should be defined in case openssl driver is cross compiled Signed-off-by: Akhil Goyal --- changes in v2: made changes to support shared build also. doc/guides/cryptodevs/openssl.rst | 4 drivers/crypto/openssl/Makefile | 3 ++- mk/rte.app.mk | 2 +- 3 fil

[dpdk-dev] [PATCH v2 1/2] crypto/openssl: replace evp APIs with HMAC APIs

2017-08-29 Thread Akhil Goyal
in case of HMAC the openssl APIs HMAC_XXX give better performance for all HMAC cases as compared with EVP_XXX Signed-off-by: Akhil Goyal --- changes in v2: patch split in two patches as per Pablo's recommendations drivers/crypto/openssl/rte_openssl_pmd.c | 37 +--- d

[dpdk-dev] [PATCH v2 2/2] crypto/openssl: performance improvements

2017-08-29 Thread Akhil Goyal
key and algo are added in the openssl ctx during session initialization instead of adding it for each packet. Signed-off-by: Akhil Goyal --- drivers/crypto/openssl/rte_openssl_pmd.c | 58 ++-- 1 file changed, 41 insertions(+), 17 deletions(-) diff --git a/drivers/cry