Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-08-15 Thread Rao, Nikhil
On 8/14/2017 4:41 PM, Jerin Jacob wrote: -Original Message- Date: Mon, 14 Aug 2017 14:18:15 +0530 From: "Rao, Nikhil" To: Jerin Jacob , "Eads, Gage" CC: "dev@dpdk.org" , "tho...@monjalon.net" , "Richardson, Bruce" , "Van Haaren, Harry" , "hemant.agra...@nxp.com" , "nipun.gu...@

[dpdk-dev] 答复: Re: [PATCH] app/testpmd:add bond type description

2017-08-15 Thread xie . rongqiang
I am sorry to reply so late for some reason. And i figure out two ways to implement this kind of things inside the bonding code, First,if can the function rte_eth_bond_mode_get() return string, so we can print the bond mode straight, but in this way, we need fix the other c source where call

[dpdk-dev] [PATCH] eal/linuxapp: check mmap return value MAP_FAILED

2017-08-15 Thread Seth Howell
If mmap fails, it will return the value MAP_FAILED. Checking for this return code allows us to properly identify mmap failures and report them as such to the calling function. Signed-off-by: Seth Howell --- lib/librte_eal/linuxapp/eal/eal_memory.c | 2 ++ 1 file changed, 2 insertions(+) diff --

Re: [dpdk-dev] [PATCH] net/i40e: fix flow control watermark mismatch

2017-08-15 Thread Kevin Traynor
On 08/13/2017 01:05 AM, Zhang, Qi Z wrote: > Hi Kevin: > >> -Original Message- >> From: Kevin Traynor [mailto:ktray...@redhat.com] >> Sent: Thursday, August 10, 2017 11:16 PM >> To: Zhang, Qi Z ; Wu, Jingjing >> Cc: dev@dpdk.org; sta...@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] net/i40e

[dpdk-dev] [PATCH] app: fix gcc -O3 compiler errors

2017-08-15 Thread Keith Wiles
When using EXTRA_CFLAGS="-g -O3" in the build the -O3 causes compiler warnings for these two applications. Using Ubuntu 17.04 gcc compiler. Signed-off-by: Keith Wiles --- app/proc_info/main.c | 4 +++- app/test-crypto-perf/cperf_test_verify.c | 2 ++ 2 files changed, 5 insert

[dpdk-dev] [PATCH 6/8] service: rework unregister api to use integers

2017-08-15 Thread Harry van Haaren
This commit reworks the unregister API to accept an integer. Signed-off-by: Harry van Haaren --- .../common/include/rte_service_component.h | 2 +- lib/librte_eal/common/rte_service.c| 25 ++ test/test/test_service_cores.c | 10 +++

[dpdk-dev] [PATCH 8/8] service: clarify documentation for register

2017-08-15 Thread Harry van Haaren
This commit adds a section to the service register function to make it clear that when registering a service, it must not call any other service core APIs (eg: adding lcores or mappings). The reason for this is that it breaks the abstraction that the services represent a task or work-item to be pe

[dpdk-dev] [PATCH 7/8] service: rework get by name function to use id

2017-08-15 Thread Harry van Haaren
This commit reworks the service_get_by_name() function to accept an integer, and removes the service_get_by_id() function. All functions now accept an integer argument representing the service, so it is no longer required to expose the service_spec pointers to the application. Signed-off-by: Harr

[dpdk-dev] [PATCH 2/8] service: rework lcore to service map functions

2017-08-15 Thread Harry van Haaren
This commit updates the APIs exposed to map service cores and services. The previous APIs required a pointer to a service, and used two seperate functions for enable and disable. The new API uses an integer ID for the service and has a parameter for map or unmap. Unit tests are updated and passing,

[dpdk-dev] [PATCH 5/8] service: rework service stats functions

2017-08-15 Thread Harry van Haaren
This commit reworks the statistics functions to use integer ids for services instead of pointers. Passing UINT32_MAX to the dump function prints all info, similar to passing NULL previously. Signed-off-by: Harry van Haaren --- lib/librte_eal/common/include/rte_service.h | 14 -- lib/

[dpdk-dev] [PATCH 3/8] service: rework register to return service id

2017-08-15 Thread Harry van Haaren
This commit reworks the service register function to accept an extra parameter. The parameter is a uint32_t *, which when provided will be set to the integer service_id that the newly registered service is represented by. This is useful for services that wish to validate settings at a later point

[dpdk-dev] [PATCH 4/8] service: rework service start stop to runstate

2017-08-15 Thread Harry van Haaren
This commit reworks the API to move from two seperate start and stop functions, to a "runstate" API which allows setting the runstate. The is_running API is replaced with an function to query the runstate. The runstate functions take a id value for service. Unit tests and the eventdev sw pmd are up

[dpdk-dev] [PATCH 1/8] service: rework probe and get name to use ids

2017-08-15 Thread Harry van Haaren
This commit adds a macro to easily validate a service ID, and then lookup the service pointer, or return a user-specified error code. This marco will be heavily used in the following patches as it will be ID based instead of pointer-based. The probe_capability function is reworked to use an intege

[dpdk-dev] [PATCH 0/8] service: rework for usability

2017-08-15 Thread Harry van Haaren
This patchset reworks the service apis to be more user friendly. In particular, the various rte_service_* functions now take an integer id parameter instead of a service pointer. This both reduces the API surface (no service_get_from_id()), and allows easier debugging (gdb function calls with integ

Re: [dpdk-dev] [RFCv2 00/40] Building DPDK with meson and ninja

2017-08-15 Thread Bruce Richardson
On Tue, Aug 15, 2017 at 11:56:38AM +0100, Luca Boccassi wrote: > On Mon, 2017-08-14 at 10:51 +0100, Bruce Richardson wrote: > > Following on from previous RFC [http://dpdk.org/dev/patchwork/patch/2 > > 5104/] > > here is a second draft implementation for building DPDK with meson > > and > > ninja.

Re: [dpdk-dev] [RFC PATCH 1/4] rte_security: API definitions

2017-08-15 Thread Radu Nicolau
On 8/15/2017 7:35 AM, Akhil Goyal wrote: Detailed description is added in the coverletter Signed-off-by: Akhil Goyal --- lib/librte_cryptodev/rte_security.c | 171 +++ lib/librte_cryptodev/rte_security.h | 409 2 files changed, 580 insertion

Re: [dpdk-dev] [RFC] Add RIB library

2017-08-15 Thread Vladimir Medvedkin
Moreover rte_rib_v4_node could contain app specific extension (.ext field). For example you can implement PIC (prefix independent convergence) by linking rte_rib_v4_node with similar next hop together and precalculate feasible next hop for each. Something like: struct rte_rib_pic_nh { struct *r

Re: [dpdk-dev] [RFCv2 00/40] Building DPDK with meson and ninja

2017-08-15 Thread Luca Boccassi
On Mon, 2017-08-14 at 10:51 +0100, Bruce Richardson wrote: > Following on from previous RFC [http://dpdk.org/dev/patchwork/patch/2 > 5104/] > here is a second draft implementation for building DPDK with meson > and > ninja. While still not building all of DPDK, and needing patch > cleanup so > that

Re: [dpdk-dev] [RFC] Add RIB library

2017-08-15 Thread Vladimir Medvedkin
The advantage is in increasing control plane operations speed. I tested with my fullview + internal routes. It had 650030 prefixes(shuffled) with 1000 specific (longer /24) prefixes within 73 /24 networks. Every prefix had unique next hop. In this test the speed of inserting new routes was increase

[dpdk-dev] [PATCH] kni: fix build on SLE12 SP3

2017-08-15 Thread Nirmoy Das
compilation error: build/lib/librte_eal/linuxapp/kni/kni_net.c:215:5: error: ‘struct net_device’ has no member named ‘trans_start’ dev->trans_start = jiffies; Signed-off-by: Nirmoy Das --- lib/librte_eal/linuxapp/kni/compat.h | 32 +++- 1 file changed, 31 insertion

Re: [dpdk-dev] [PATCH v3] net/i40e: fix PF notify issue when VF is not up

2017-08-15 Thread Xing, Beilei
> -Original Message- > From: Li, Xiaoyun > Sent: Tuesday, August 15, 2017 3:40 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; dev@dpdk.org; Li, Xiaoyun > ; sta...@dpdk.org > Subject: [PATCH v3] net/i40e: fix PF notify issue when VF is not up > > This patch stops PF from sending message to V

Re: [dpdk-dev] [PATCH] doc: add i40e firmware upgrade guide

2017-08-15 Thread Ferruh Yigit
On 8/15/2017 4:26 AM, Qiming Yang wrote: > This patch adds one link to DPDK i40e doc, which is for > users on how to upgrade firmware. Does it make sense to add a link to download the FW too? > > Signed-off-by: Qiming Yang > --- > doc/guides/nics/i40e.rst | 2 ++ > 1 file changed, 2 insertions

Re: [dpdk-dev] [RFC] Add RIB library

2017-08-15 Thread Bruce Richardson
On Tue, Aug 15, 2017 at 01:28:26AM +0300, Vladimir Medvedkin wrote: > 2017-08-14 13:51 GMT+03:00 Bruce Richardson : > > > On Tue, Jul 11, 2017 at 07:33:04PM +, Medvedkin Vladimir wrote: > > > Hi, > > > > > > I want to introduce new library for ip routing lookup that have some > > advantages >

[dpdk-dev] [PATCH v3 0/2] Dynamically configure mempool handle

2017-08-15 Thread Santosh Shukla
v3: - Rebased on top of v17.11-rc0 - Updated version.map entry to v17.11. v2: DPDK has support for hw and sw mempool. Those mempool can work optimal for specific PMD's. Example: sw ring based PMD for Intel NICs. HW mempool manager dpaa2 for dpaa2 PMD. HW mempool manager fpa for octeontx PMD.

[dpdk-dev] [PATCH v3 1/2] eal: allow user to override default pool handle

2017-08-15 Thread Santosh Shukla
DPDK has support for both sw and hw mempool and currently user is limited to use ring_mp_mc pool. In case user want to use other pool handle, need to update config RTE_MEMPOOL_OPS_DEFAULT, then build and run with desired pool handle. Introducing eal option to override default pool handle. Now use

[dpdk-dev] [PATCH v3 2/2] ethdev: allow pmd to advertise pool handle

2017-08-15 Thread Santosh Shukla
Now that dpdk supports more than one mempool drivers and each mempool driver works best for specific PMD, example: - sw ring based mempool for Intel PMD drivers - dpaa2 HW mempool manager for dpaa2 PMD driver. - fpa HW mempool manager for Octeontx PMD driver. Application like to know `preferred me

[dpdk-dev] [PATCH v3] net/i40e: fix PF notify issue when VF is not up

2017-08-15 Thread Xiaoyun Li
This patch stops PF from sending message to VF when VF's admin queue isn't enabled, namely VF isn't up. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun Li --- v3: * Modify the code to be more concise. * Don't modify vf's state since it isn't used in

Re: [dpdk-dev] [PATCH] crypto/openssl: performance improvements

2017-08-15 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, August 15, 2017 7:45 AM > To: De Lara Guarch, Pablo ; > dev@dpdk.org; Doherty, Declan > Cc: hemant.agra...@nxp.com > Subject: Re: [PATCH] crypto/openssl: performance improvements > > On 8/14/2017 7

[dpdk-dev] [PATCH v2] net/i40e: fix PF notify issue when VF is not up

2017-08-15 Thread Xiaoyun Li
This patch stops PF from sending message to VF when VF's admin queue isn't enabled, namely VF isn't up and modifies VF state to active when VF reset is completed. Fixes: 4861cde46116 ("i40e: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun Li --- v2: * Modify the abbreviation to

[dpdk-dev] [PATCH] net/failsafe: fix tx sub device deactivating

2017-08-15 Thread Matan Azrad
The corrupted code couldn't recognize that all sub devices were not ready for tx traffic when failsafe PMD was trying to switch device because of an unreachable condition using. Hence, the current tx sub device variable was not updated correctly. The fix removed the unreachable condition and adds