Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-08-10 Thread Rao, Nikhil
On 8/1/2017 10:12 PM, Jerin Jacob wrote: I have had the application specify the name. so that it can call struct rte_service_spec *rte_service_get_by_name(const char *name); OK. I was thinking like there will be fixed name for the rx_adapter service like "eth_rx_adapter_%d"(%d for adapter id)

[dpdk-dev] [PATCH] virtio: use pointer to replace memcpy

2017-08-10 Thread Zhiyong Yang
To use pointer instead of memcpy can save many cycles in the funciton virtio_send_command. cc: maxime.coque...@redhat.com cc: y...@fridaylinux.org Signed-off-by: Zhiyong Yang --- drivers/net/virtio/virtio_ethdev.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v5 4/6] mk: sort source files before passing them to the compiler

2017-08-10 Thread luca . boccassi
From: Luca Boccassi In order to achieve reproducible builds, always use the same order when listing files for compilation. Signed-off-by: Luca Boccassi --- drivers/net/cxgbe/Makefile| 2 +- drivers/net/e1000/Makefile| 2 +- drivers/net/fm10k/Makefile| 2 +- drivers/net/i40e/Makefil

[dpdk-dev] [PATCH v5 6/6] mk: set -ISCDIR before -IRTE_OUT/include in CFLAGS

2017-08-10 Thread luca . boccassi
From: Luca Boccassi A race condition can happen during parallel builds, where a header might be installed in RTE_OUT/include before CFLAGS is recursively expanded. This causes GCC to sometimes pick the header path as SRCDIR/... and sometimes as RTE_OUT/include/... making the build unreproducible,

[dpdk-dev] [PATCH v5 5/6] mk: sort object files when building deps lists

2017-08-10 Thread luca . boccassi
From: Luca Boccassi In order to achieve reproducible builds, always use the same order when listing object files to build dependencies lists. Signed-off-by: Luca Boccassi --- mk/rte.app.mk | 4 ++-- mk/rte.hostapp.mk | 4 ++-- mk/rte.shared.mk | 4 ++-- 3 files changed, 6 insertions(+), 6

[dpdk-dev] [PATCH v5 3/6] mk: sort headers before wildcard inclusion

2017-08-10 Thread luca . boccassi
From: Luca Boccassi In order to achieve fully reproducible builds, always use the same inclusion order for headers in the Makefiles. Signed-off-by: Luca Boccassi --- examples/ip_pipeline/Makefile | 2 +- examples/multi_process/client_server_mp/mp_server/Makefile |

[dpdk-dev] [PATCH v5 2/6] mk: sort list of files in examples.dox

2017-08-10 Thread luca . boccassi
From: Luca Boccassi The result of find might not be stable depending on external conditions. Pipe it through LC_ALL=C sort to ensure reproducible results when generating examples.dox. Signed-off-by: Luca Boccassi --- mk/rte.sdkdoc.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v5 0/6] Reproducible build

2017-08-10 Thread luca . boccassi
From: Luca Boccassi In the past couple of years a concerted effort among almost all Linux distros has been striving toward achieving reproducible builds. [1] This involves changes to the toolchain, new tools and CI systems. [2] v1 fixed the documentation, examples and linker script generation. v

[dpdk-dev] [PATCH v5 1/6] mk: sort list of shared objects in linker script

2017-08-10 Thread luca . boccassi
From: Luca Boccassi The output of wildcard might not be stable and depend on the filesystem and other factors. This means the content libdpdk.so linker script might change between builds from the same sources. Run the list through sort to ensure reproducibility. Signed-off-by: Luca Boccassi ---

Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues

2017-08-10 Thread Jerin Jacob
-Original Message- > Date: Wed, 9 Aug 2017 19:24:30 + > From: "Eads, Gage" > To: Jerin Jacob > CC: "Rao, Nikhil" , "dev@dpdk.org" , > "tho...@monjalon.net" , "Richardson, Bruce" > , "Van Haaren, Harry" > , "hemant.agra...@nxp.com" > , "nipun.gu...@nxp.com" , > "Vangati, Narender"

Re: [dpdk-dev] [PATCH] atm: Remove machine definition

2017-08-10 Thread Bruce Richardson
On Thu, Aug 10, 2017 at 11:15:27AM -0400, Neil Horman wrote: > On Thu, Aug 10, 2017 at 02:04:00PM +, Richardson, Bruce wrote: > > > > > > > -Original Message- > > > From: Neil Horman [mailto:nhor...@tuxdriver.com] > > > Sent: Thursday, August 10, 2017 12:34 PM > > > To: Richardson, Br

Re: [dpdk-dev] [PATCH] net/i40e: fix flow control watermark mismatch

2017-08-10 Thread Kevin Traynor
On 08/10/2017 11:48 AM, Qi Zhang wrote: > Flow control watermark is not read out correctly, > that may cause an application who not intend to change > watermark but does change it with a rte_eth_dev_flow_ctrl_set > call right after rte_eth_dev_flow_ctrl_get. > > Fixes: f53577f06925 ("i40e: support

Re: [dpdk-dev] [PATCH] atm: Remove machine definition

2017-08-10 Thread Neil Horman
On Thu, Aug 10, 2017 at 02:04:00PM +, Richardson, Bruce wrote: > > > > -Original Message- > > From: Neil Horman [mailto:nhor...@tuxdriver.com] > > Sent: Thursday, August 10, 2017 12:34 PM > > To: Richardson, Bruce > > Cc: dev@dpdk.org; Thomas Monjalon > > Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH] atm: Remove machine definition

2017-08-10 Thread Richardson, Bruce
> -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Thursday, August 10, 2017 12:34 PM > To: Richardson, Bruce > Cc: dev@dpdk.org; Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH] atm: Remove machine definition > > On Thu, Aug 10, 2017 at 09:34:18AM +0100,

[dpdk-dev] [PATCH v4 2/2] doc: Update ABI Change for rte_eth_stats_reset

2017-08-10 Thread David Harton
Signed-off-by: David Harton --- v4: * Added requested release note about ABI change. doc/guides/rel_notes/release_17_11.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst index 170f4f9..e329f8a 100644 --- a/do

[dpdk-dev] [PATCH v4 1/2] ethdev: add return code to rte_eth_stats_reset()

2017-08-10 Thread David Harton
Some devices do not support reset of eth stats. An application may need to know not to clear shadow stats if the device cannot. rte_eth_stats_reset is updated to provide a return code to share whether the device supports reset or not. Signed-off-by: David Harton --- v4: * commented return valu

Re: [dpdk-dev] [PATCH] atm: Remove machine definition

2017-08-10 Thread Neil Horman
On Thu, Aug 10, 2017 at 09:34:18AM +0100, Bruce Richardson wrote: > On Wed, Aug 09, 2017 at 04:24:25PM -0400, Neil Horman wrote: > > With the new updated requirement for SSE4.2, dpdk no longer supports > > building on atom machines, as they only support up to SSE3. Remove > > the machine definitio

Re: [dpdk-dev] Use rte_malloc in application

2017-08-10 Thread Rohit Saini (Stellus)
Thanks Sergio. It helped. There was a mistake the way I was linking dpdk with my application. Thanks, Rohit -Original Message- From: Sergio Gonzalez Monroy [mailto:sergio.gonzalez.mon...@intel.com] Sent: Thursday, August 03, 2017 1:59 PM To: Rohit Saini (Stellus) ; 'dev@dpdk.org' Subj

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: support the heavywight mode GRO

2017-08-10 Thread Ferruh Yigit
On 8/10/2017 3:50 AM, Jiayu Hu wrote: > The GRO library provides two reassembly modes: lightweight mode and > heavyweight mode. This patch is to support the heavyweight mode in > csum forwarding engine. > > With the command "gro (heavymode|lightmode) (on|off) ", users > can select the lightweight

[dpdk-dev] [PATCH] net/i40e: fix return code not checked

2017-08-10 Thread Daniel Mrzyglod
Calling i40e_vsi_delete_mac without checking return value (as is done elsewhere 5 out of 6 times) Coverity issue: 140735 Fixes: 43c89d5a4fde ("net/i40e: set VF MAC from PF") Signed-off-by: Daniel Mrzyglod --- drivers/net/i40e/rte_pmd_i40e.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(

Re: [dpdk-dev] [PATCH] atm: Remove machine definition

2017-08-10 Thread Bruce Richardson
On Wed, Aug 09, 2017 at 04:24:25PM -0400, Neil Horman wrote: > With the new updated requirement for SSE4.2, dpdk no longer supports > building on atom machines, as they only support up to SSE3. Remove > the machine definition. > > Signed-off-by: Neil Horman CC: Thomas Monjalon > --- mk/machine/

[dpdk-dev] [PATCH] version: 17.11-rc0

2017-08-10 Thread Thomas Monjalon
Signed-off-by: Thomas Monjalon --- Patch applied. Let's start a new release cycle! --- lib/librte_eal/common/include/rte_version.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/include/rte_version.h b/lib/librte_eal/common/include/rte_version.

Re: [dpdk-dev] [PATCH v2] doc: add template release notes for 17.11

2017-08-10 Thread Thomas Monjalon
09/08/2017 10:22, John McNamara: > Add template release notes for DPDK 17.11 with inline > comments and explanations of the various sections. > > Signed-off-by: John McNamara Applied, thanks