Re: [dpdk-dev] [PATCH v2 5/5] app/testpmd: add command to test NIC restoration

2017-06-28 Thread Dai, Wei
Thanks for your feedback. V3 patch set will follow your guide. > -Original Message- > From: Wu, Jingjing > Sent: Wednesday, June 28, 2017 5:05 PM > To: Dai, Wei ; tho...@monjalon.net; Lu, Wenzhuo > ; Ananyev, Konstantin > ; Zhang, Helin > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 5/5] app

Re: [dpdk-dev] [PATCH 00/20 v2] next-eventdev: NXP DPAA2 eventdev PMD

2017-06-28 Thread Jerin Jacob
-Original Message- > Date: Wed, 28 Jun 2017 13:51:02 + > From: Nipun Gupta > To: "jerin.ja...@caviumnetworks.com" > CC: Hemant Agrawal , "harry.van.haa...@intel.com" > , "bruce.richard...@intel.com" > , "gage.e...@intel.com" , > Shreyansh Jain , "dev@dpdk.org" > Subject: RE: [PATC

Re: [dpdk-dev] [PATCH v10 0/2] Balanced allocation of hugepages

2017-06-28 Thread Jerin Jacob
-Original Message- > Date: Thu, 29 Jun 2017 08:59:18 +0300 > From: Ilya Maximets > To: dev@dpdk.org, David Marchand , Sergio > Gonzalez Monroy , Thomas Monjalon > > CC: Heetae Ahn , Yuanhan Liu > , Jianfeng Tan , Neil Horman > , Yulong Pei , Bruce > Richardson , Jerin Jacob > , Hema

Re: [dpdk-dev] [PATCH v2 0/5] Support NIC reset and keep same port id

2017-06-28 Thread Dai, Wei
Many thanks to Yuan for your test support. Your test show the code changes for rte_ether and driver/net can work as expected. I'll update a v3 patch set according to feedback from Wu Jingjing and your test. In v3 patch, only code in testpmd will be changed but with similar test method. > -Ori

Re: [dpdk-dev] [PATCH] vhost: fix checking of device features

2017-06-28 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ivan Dyukov > Sent: Wednesday, June 28, 2017 8:41 PM > To: y...@fridaylinux.org; maxime.coque...@redhat.com; dev@dpdk.org > Cc: i.maxim...@samsung.com; heetae82@samsung.com; Ivan Dyukov; > sta...@dpdk.org > Su

Re: [dpdk-dev] [PATCH v9 1/2] mem: balanced allocation of hugepages

2017-06-28 Thread Ilya Maximets
On 29.06.2017 08:48, Ilya Maximets wrote: > On 29.06.2017 08:32, Hemant Agrawal wrote: >> On 6/27/2017 3:54 PM, Ilya Maximets wrote: >>> Currently EAL allocates hugepages one by one not paying attention >>> from which NUMA node allocation was done. >>> >>> Such behaviour leads to allocation failure

Re: [dpdk-dev] [PATCH] vhost: fix checking of device features

2017-06-28 Thread Ivan Dyukov
On 06/28/2017 03:54 PM, Maxime Coquelin wrote: On 06/28/2017 02:40 PM, Ivan Dyukov wrote: To compare enabled features in current device we must use bit mask instead of bit position. CC: sta...@dpdk.org Fixes: c843af3aa13e ("vhost: access header only") Signed-off-by: Ivan Dyukov --- lib/li

[dpdk-dev] [PATCH v10 2/2] config: enable vhost numa awareness by default

2017-06-28 Thread Ilya Maximets
It is safe to enable LIBRTE_VHOST_NUMA by default for all configurations where libnuma is already a default dependency. DPDK_DEP_NUMA not needed anymore. Signed-off-by: Ilya Maximets Acked-by: Hemant Agrawal --- config/common_linuxapp| 1 + config/defconfig_arm-armv7a-linux

[dpdk-dev] [PATCH v10 1/2] mem: balanced allocation of hugepages

2017-06-28 Thread Ilya Maximets
Currently EAL allocates hugepages one by one not paying attention from which NUMA node allocation was done. Such behaviour leads to allocation failure if number of available hugepages for application limited by cgroups or hugetlbfs and memory requested not only from the first socket. Example:

[dpdk-dev] [PATCH v10 0/2] Balanced allocation of hugepages

2017-06-28 Thread Ilya Maximets
Version 10: * Fixed typo in DPAA2 config. Version 9: * Removed DPDK_DEP_NUMA from test-build.sh . Not needed anymore. * Fixed out of bound write to essential_memory in case where socket-mem not specified and SIGBUS occured. Version 8: * helper f

Re: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode parameter

2017-06-28 Thread Wu, Jingjing
> > > > Should it block the app startup if isolated-mode setting fails? > > > > > > if isolated mode cannot be enabled on any port, that port cannot be > > > initialized and that causes testpmd to quit, at least it won't go > > > against the user's wishes > > > > If so, I prefer the isolated_mode t

Re: [dpdk-dev] [PATCH v9 1/2] mem: balanced allocation of hugepages

2017-06-28 Thread Ilya Maximets
On 29.06.2017 08:32, Hemant Agrawal wrote: > On 6/27/2017 3:54 PM, Ilya Maximets wrote: >> Currently EAL allocates hugepages one by one not paying attention >> from which NUMA node allocation was done. >> >> Such behaviour leads to allocation failure if number of available >> hugepages for applicat

Re: [dpdk-dev] [PATCH] app/testpmd: fix io fwd mode to forward VLAN packets

2017-06-28 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ajit Khaparde > Sent: Thursday, June 29, 2017 11:06 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix io fwd mode to forward VLAN > packets > > In io fwd mode, while the received VLAN packets a

Re: [dpdk-dev] [PATCH v9 1/2] mem: balanced allocation of hugepages

2017-06-28 Thread Hemant Agrawal
On 6/27/2017 3:54 PM, Ilya Maximets wrote: Currently EAL allocates hugepages one by one not paying attention from which NUMA node allocation was done. Such behaviour leads to allocation failure if number of available hugepages for application limited by cgroups or hugetlbfs and memory requested

Re: [dpdk-dev] [PATCH v9 2/2] config: enable vhost numa awareness by default

2017-06-28 Thread Hemant Agrawal
On 6/27/2017 3:54 PM, Ilya Maximets wrote: It is safe to enable LIBRTE_VHOST_NUMA by default for all configurations where libnuma is already a default dependency. DPDK_DEP_NUMA not needed anymore. Signed-off-by: Ilya Maximets --- config/common_linuxapp| 1 + config/defconf

Re: [dpdk-dev] [PATCH v2] net/i40e: fix division by 0 error

2017-06-28 Thread Wu, Jingjing
> -Original Message- > From: Yong Wang [mailto:wang.yon...@zte.com.cn] > Sent: Friday, June 23, 2017 6:58 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Yong Wang > Subject: [PATCH v2] net/i40e: fix division by 0 error > > In function i40e_vsi_config_tc_queue_mapping(), if 'enabled_tcmap' i

Re: [dpdk-dev] [PATCH 00/21 v3] next-eventdev: NXP DPAA2 eventdev PMD

2017-06-28 Thread Hemant Agrawal
On 6/28/2017 8:45 PM, Nipun Gupta wrote: The following patch set adds NXP DPAA2 HW based eventdev implementation to the next-eventdev tree. The patchset consists of the following: - DPCON support required by DPAA2 eventdev - DPCI support in fslmc bus - Interrupt support in QBMAN - Implemetation

[dpdk-dev] [PATCH v3 0/2] add uevent api for hot plug

2017-06-28 Thread Jeff Guo
From: "Guo, Jia" This patch set aim to add a variable "uevent_fd" in structure "rte_intr_handle" for enable kernel object uevent monitoring, and add some uevent API in rte eal interrupt, that is “rte_uevent_connect” and “rte_uevent_get”. The patch use i40e for example, the driver could use these

[dpdk-dev] [PATCH v3 1/2] eal: add uevent api for hot plug

2017-06-28 Thread Jeff Guo
From: "Guo, Jia" This patch aim to add a variable "uevent_fd" in structure "rte_intr_handle" for enable kernel object uevent monitoring, and add some uevent API in rte eal interrupt, that is “rte_uevent_connect” and “rte_uevent_get”, so that all driver could use these API to monitor and read out

[dpdk-dev] [PATCH v3 2/2] net/i40e: add hot plug monitor in i40e

2017-06-28 Thread Jeff Guo
From: "Guo, Jia" This patch enable the hot plug feature in i40e, by monitoring the hot plug uevent of the device. When remove event got, call the app callback function to handle the detach process. Signed-off-by: Guo, Jia --- v3->v2: refine the return issue if device remove --- drivers/net/i40

Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e

2017-06-28 Thread Wu, Jingjing
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Thursday, June 29, 2017 11:35 AM > To: Guo, Jia > Cc: Zhang, Helin ; Wu, Jingjing > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e > > On Wed, 28 Ju

[dpdk-dev] [PATCH v3 2/2] net/i40e: add hot plug monitor in i40e

2017-06-28 Thread Jeff Guo
From: "Guo, Jia" This patch enable the hot plug feature in i40e, by monitoring the hot plug uevent of the device. When remove event got, call the app callback function to handle the detach process. Signed-off-by: Guo, Jia --- v3->v2: refine the return issue if device remove --- drivers/net/i40

[dpdk-dev] [PATCH v3 1/2] eal: add uevent api for hot plug

2017-06-28 Thread Jeff Guo
From: "Guo, Jia" This patch aim to add a variable "uevent_fd" in structure "rte_intr_handle" for enable kernel object uevent monitoring, and add some uevent API in rte eal interrupt, that is “rte_uevent_connect” and “rte_uevent_get”, so that all driver could use these API to monitor and read out

[dpdk-dev] [PATCH v3 0/2] add uevent api for hot plug

2017-06-28 Thread Jeff Guo
From: "Guo, Jia" This patch set aim to add a variable "uevent_fd" in structure "rte_intr_handle" for enable kernel object uevent monitoring, and add some uevent API in rte eal interrupt, that is “rte_uevent_connect” and “rte_uevent_get”. The patch use i40e for example, the driver could use these

Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e

2017-06-28 Thread Guo, Jia
Yes, if got remove uevent might be directly return to avoid invalid i/o. but if got other uevent such as add and change, must be go done to keep the interrupt process in device. I will refine this part, thanks. Best regards, Jeff Guo -Original Message- From: Wu, Jingjing Sent: Thursd

Re: [dpdk-dev] [PATCH v2 1/2] eal: add uevent api for hot plug

2017-06-28 Thread Guo, Jia
The buf have contain lot of consistent '/0', so it is why I need to check that. anyway I will refine that and other return issue in v3. Thanks jingjing . Best regards, Jeff Guo -Original Message- From: Wu, Jingjing Sent: Thursday, June 29, 2017 10:25 AM To: Guo, Jia ; Zhang, Helin Cc

[dpdk-dev] [PATCH v3 20/20] net/ixgbe: support committing TM hierarchy

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_hierarchy_commit. When calling this API, the driver tries to enable the TM configuration on HW. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_ethdev.c | 15 ++--- drivers/net/ixgbe/ixgbe_ethdev.h | 2 ++ drivers/net/ixgbe/ixgbe_t

[dpdk-dev] [PATCH v3 19/20] net/ixgbe: support getting TM node capability

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_node_capabilities_get. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_tm.c | 61 1 file changed, 61 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_tm.c b/drivers/net/ixgbe/ixgbe_tm.c in

[dpdk-dev] [PATCH v3 17/20] net/ixgbe: support getting TM node type

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_node_type_get. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_tm.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_tm.c b/drivers/net/ixgbe/ixgbe_tm.c index ee0f639..df56

[dpdk-dev] [PATCH v3 18/20] net/ixgbe: support getting TM level capability

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_level_capabilities_get. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_tm.c | 74 1 file changed, 74 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_tm.c b/drivers/net/ixgbe/ixgbe_tm.c i

[dpdk-dev] [PATCH v3 16/20] net/ixgbe: support deleting TM node

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_node_delete. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_tm.c | 67 1 file changed, 67 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_tm.c b/drivers/net/ixgbe/ixgbe_tm.c index bec901

[dpdk-dev] [PATCH v3 15/20] net/ixgbe: support adding TM node

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_node_add. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 + drivers/net/ixgbe/ixgbe_ethdev.h | 47 + drivers/net/ixgbe/ixgbe_tm.c | 436 +++ 3 files changed, 488 insertions(+)

[dpdk-dev] [PATCH v3 13/20] net/ixgbe: support adding TM shaper profile

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_shaper_profile_add. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++ drivers/net/ixgbe/ixgbe_ethdev.h | 21 +++ drivers/net/ixgbe/ixgbe_tm.c | 123 +++ 3 files changed, 150

[dpdk-dev] [PATCH v3 14/20] net/ixgbe: support deleting TM shaper profile

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_shaper_profile_delete. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_tm.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_tm.c b/drivers/net/ixgbe/ixgbe_tm.c index dcc

[dpdk-dev] [PATCH v3 11/20] net/ixgbe: support getting TM ops

2017-06-28 Thread Wenzhuo Lu
To support QoS scheduler APIs, create a new C file for the TM (Traffic Management) ops but without any function implemented. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/Makefile | 1 + drivers/net/ixgbe/ixgbe_ethdev.c | 1 + drivers/net/ixgbe/ixgbe_ethdev.h | 2 ++ drivers/net/ixgbe

[dpdk-dev] [PATCH v3 12/20] net/ixgbe: support getting TM capability

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_capabilities_get. Signed-off-by: Wenzhuo Lu --- drivers/net/ixgbe/ixgbe_tm.c | 91 +++- 1 file changed, 90 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_tm.c b/drivers/net/ixgbe/ixg

[dpdk-dev] [PATCH v3 10/20] net/i40e: support committing TM hierarchy

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_hierarchy_commit. When calling this API, the driver tries to enable the TM configuration on HW. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c | 5 ++ drivers/net/i40e/i40e_ethdev.h | 9 +++ drivers/net/i40e/i40e_tm.c

[dpdk-dev] [PATCH v3 08/20] net/i40e: support getting TM level capability

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_level_capabilities_get. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_tm.c | 74 ++ 1 file changed, 74 insertions(+) diff --git a/drivers/net/i40e/i40e_tm.c b/drivers/net/i40e/i40e_tm.c index

[dpdk-dev] [PATCH v3 09/20] net/i40e: support getting TM node capability

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_node_capabilities_get. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_tm.c | 61 ++ 1 file changed, 61 insertions(+) diff --git a/drivers/net/i40e/i40e_tm.c b/drivers/net/i40e/i40e_tm.c index

[dpdk-dev] [PATCH v3 07/20] net/i40e: support getting TM node type

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_node_type_get. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_tm.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/net/i40e/i40e_tm.c b/drivers/net/i40e/i40e_tm.c index 00709c1..c2f794b 10

[dpdk-dev] [PATCH v3 06/20] net/i40e: support deleting TM node

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_node_delete. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_tm.c | 66 ++ 1 file changed, 66 insertions(+) diff --git a/drivers/net/i40e/i40e_tm.c b/drivers/net/i40e/i40e_tm.c index 8444580..0

[dpdk-dev] [PATCH v3 05/20] net/i40e: support adding TM node

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_node_add. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c | 3 + drivers/net/i40e/i40e_ethdev.h | 46 ++ drivers/net/i40e/i40e_tm.c | 325 + 3 files changed, 374 insertions(+) d

[dpdk-dev] [PATCH v3 03/20] net/i40e: support adding TM shaper profile

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_shaper_profile_add. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_ethdev.c | 6 +++ drivers/net/i40e/i40e_ethdev.h | 18 +++ drivers/net/i40e/i40e_tm.c | 119 + 3 files changed, 143 ins

[dpdk-dev] [PATCH v3 04/20] net/i40e: support deleting TM shaper profile

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_shaper_profile_delete. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_tm.c | 36 1 file changed, 36 insertions(+) diff --git a/drivers/net/i40e/i40e_tm.c b/drivers/net/i40e/i40e_tm.c index 1cce2af..9

[dpdk-dev] [PATCH v3 02/20] net/i40e: support getting TM capability

2017-06-28 Thread Wenzhuo Lu
Add the support of the Traffic Management API, rte_tm_capabilities_get. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/i40e_tm.c | 84 +- 1 file changed, 83 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_tm.c b/drivers/net/i40e/i40e_t

[dpdk-dev] [PATCH v3 01/20] net/i40e: support getting TM ops

2017-06-28 Thread Wenzhuo Lu
To support QoS scheduler APIs, create a new C file for the TM (Traffic Management) ops but without any function implemented. Signed-off-by: Wenzhuo Lu --- drivers/net/i40e/Makefile | 1 + drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/i40e/i40e_ethdev.h | 2 ++ drivers/net/i40e/i40e_t

[dpdk-dev] [PATCH v3 00/20] traffic manager on i40e and ixgbe

2017-06-28 Thread Wenzhuo Lu
Implement the traffic manager APIs on i40e and ixgbe. This patch set is based on the patch set, "ethdev: abstraction layer for QoS traffic management" http://dpdk.org/dev/patchwork/patch/25275/ http://dpdk.org/dev/patchwork/patch/25276/ Series Reviewed-by: Ferruh Yigit Series-Acked-by: Cristian D

Re: [dpdk-dev] [PATCH v2 0/5] Support NIC reset and keep same port id

2017-06-28 Thread Peng, Yuan
Tested-by: Peng, Yuan - Tested commit c1923afc0999b5b6f109190bc5b69b6c3d334635+the 5 patches. - OS: 4.5.5-300.fc24.x86_64 - GCC: gcc version 6.1.1 20160510 (Red Hat 6.1.1-2) (GCC) - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz - NIC: Ethernet controller [0200]: Intel Corporation 82599ES 10-Giga

Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e

2017-06-28 Thread Stephen Hemminger
On Wed, 28 Jun 2017 19:07:24 +0800 Jeff Guo wrote: > From: "Guo, Jia" > > This patch enable the hot plug feature in i40e, by monitoring the > hot plug uevent of the device. When remove event got, call the app > callback function to handle the detach process. > > Signed-off-by: Guo, Jia > ---

[dpdk-dev] [PATCH] app/testpmd: fix io fwd mode to forward VLAN packets

2017-06-28 Thread Ajit Khaparde
In io fwd mode, while the received VLAN packets are forwarded for transmit, the ol_flags are not updated appropriately to indicate presence of VLAN tags in the Tx path. This patch fixes that. Signed-off-by: Ajit Khaparde --- app/test-pmd/iofwd.c | 15 +++ 1 file changed, 15 insertion

[dpdk-dev] [PATCH 7/7] net/bnxt: fix copy/pasted error message

2017-06-28 Thread Ajit Khaparde
Fix an error message. Probably a copy/paste error. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/rte_pmd_bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c index 1903101..11

[dpdk-dev] [PATCH 6/7] net/bnxt: fix some link related issues

2017-06-28 Thread Ajit Khaparde
This patch fixes some link related issues that can occur because: bnxt_hwrm_port_phy_cfg() was setting enables inappropriately. bnxt_hwrm_port_phy_qcfg() was overly complex. bnxt_get_hwrm_link_config() was basing the speed on the link status. bnxt_get_hwrm_link_config() was using the incorrect mac

[dpdk-dev] [PATCH 1/7] net/bnxt: add support for Stratus VF device

2017-06-28 Thread Ajit Khaparde
This patch adds support for Stratus VF devices. Other than adding the VF device ID, we also are adding support for short message format. The new short firmware message of size 16 bytes points to a location in host memory that contains the firmware message that the driver wants the adapter to proce

[dpdk-dev] [PATCH 2/7] net/bnxt: fix mtu configuration for the function

2017-06-28 Thread Ajit Khaparde
Set the MTU of the device to MAX size possible. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index e237041..580b2d8 100644 --- a/drivers/net/bnxt/bnxt

[dpdk-dev] [PATCH 5/7] net/bnxt: fix automatic clearing of VF stats

2017-06-28 Thread Ajit Khaparde
Add code to avoid automatic clearing of VF stats on a function reset or a stat context free. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_hwrm.c | 5 +-- drivers/net/bnxt/bnxt_hwrm.h | 3 +

[dpdk-dev] [PATCH 4/7] net/bnxt: pass func_default flag to VNIC_ALLOC

2017-06-28 Thread Ajit Khaparde
Previously, no VNICs were allocated as the default VNIC, even if they were configured as one. This patch fixes that error. Fixes: db678d5c2b54 ("net/bnxt: add HWRM VNIC configure") Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 2 ++ 1 file changed

[dpdk-dev] [PATCH 3/7] net/bnxt: fix calculation of VNICs

2017-06-28 Thread Ajit Khaparde
We used the default as a work-around for the 4-byte MTU VNICs, but we filter those out now. So fix the calculation of VNICs accordingly. Fixes: ff63ebbb67a7 ("net/bnxt: determine the Rx status of VF") Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c

[dpdk-dev] [PATCH 0/7] bnxt patch series

2017-06-28 Thread Ajit Khaparde
The first patch of the series adds support for a new device. Rest of the patches in the patchset fix some of the issues found during testing. net/bnxt: add support for Stratus VF device net/bnxt: fix mtu configuration for the function net/bnxt: fix calculation of VNICs net/bnxt: pass func_

Re: [dpdk-dev] [PATCH v2 1/2] eal: add uevent api for hot plug

2017-06-28 Thread Wu, Jingjing
> + > +int > +rte_uevent_connect(void) > +{ > + struct sockaddr_nl addr; > + int ret; > + int netlink_fd = -1; > + int size = 64 * 1024; > + int nonblock = 1; > + memset(&addr, 0, sizeof(addr)); > + addr.nl_family = AF_NETLINK; > + addr.nl_pid = 0; > + addr.nl_gr

Re: [dpdk-dev] [PATCH v7 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-28 Thread Jiayu Hu
Hi Konstantin, On Thu, Jun 29, 2017 at 07:56:10AM +0800, Ananyev, Konstantin wrote: > Hi Jiayu, > > > > > In this patch, we introduce five APIs to support TCP/IPv4 GRO. > > - gro_tcp_tbl_create: create a TCP reassembly table, which is used to > > merge packets. > > - gro_tcp_tbl_destroy: fre

Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e

2017-06-28 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Wednesday, June 28, 2017 7:07 PM > To: Zhang, Helin ; Wu, Jingjing > > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e > > From: "Guo, Jia" > > This patch enable the hot plug feature in i40e, by

Re: [dpdk-dev] 17.05.1 patches review and test

2017-06-28 Thread Chen, WeichunX
Hi Yuanhan and all We have done all of the test jobs on stable release 17.05.1. All pass and no new issues. More detailed information attached. -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kavanagh, Mark B Sent: Wednesday, June 28, 2017 8:49 PM To: Yu

Re: [dpdk-dev] [PATCH] maintainers: update for i40e

2017-06-28 Thread Zhang, Helin
> -Original Message- > From: Xing, Beilei > Sent: Thursday, June 29, 2017 9:12 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Zhang, Helin > Subject: [PATCH] maintainers: update for i40e > > Signed-off-by: Beilei Xing Acked-by: Helin Zhang > --- > MAINTAINERS | 2 +- > 1 file changed, 1 in

Re: [dpdk-dev] [PATCH v7 1/3] lib: add Generic Receive Offload API framework

2017-06-28 Thread Jiayu Hu
Hi Konstantin, On Thu, Jun 29, 2017 at 01:41:40AM +0800, Ananyev, Konstantin wrote: > > Hi Jiayu, > > > > > > > > > > + > > > > +/** > > > > + * GRO table, which is used to merge packets. It keeps many reassembly > > > > + * tables of desired GRO types. Applications need to create GRO tables >

[dpdk-dev] [PATCH] maintainers: update for i40e

2017-06-28 Thread Beilei Xing
Signed-off-by: Beilei Xing --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index f6095ef..00351ff 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -350,8 +350,8 @@ F: doc/guides/nics/intel_vf.rst F: doc/guides/nics/features/ixgbe*.ini

Re: [dpdk-dev] [PATCH v7 2/3] lib/gro: add TCP/IPv4 GRO support

2017-06-28 Thread Ananyev, Konstantin
Hi Jiayu, > > In this patch, we introduce five APIs to support TCP/IPv4 GRO. > - gro_tcp_tbl_create: create a TCP reassembly table, which is used to > merge packets. > - gro_tcp_tbl_destroy: free memory space of a TCP reassembly table. > - gro_tcp_tbl_flush: flush all packets from a TCP reass

[dpdk-dev] [PATCH 3/5] net/mlx5: use buffer address for LKEY search

2017-06-28 Thread Yongseok Koh
When searching LKEY, if search key is mempool pointer, the 2nd cacheline has to be accessed and it even requires to check whether a buffer is indirect per every search. Instead, using address for search key can reduce cycles taken. And caching the last hit entry is beneficial as well. Signed-off-b

[dpdk-dev] [PATCH 5/5] net/mlx5: add vectorized Rx/Tx burst for SSE4.1

2017-06-28 Thread Yongseok Koh
To make vectorized burst routines enabled, it is required to run on x86_64 architecture which can support at least SSE4.1. If all the conditions are met, the vectorized burst functions are enabled automatically. The decision is made individually on RX and TX. There's no PMD option to make a selecti

[dpdk-dev] [PATCH 4/5] net/mlx5: select Rx/Tx callbacks when starting device

2017-06-28 Thread Yongseok Koh
The callbacks are global to a device but the seletion is made every queue configuration, which is redundant. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxq.c | 2 -- drivers/net/mlx5/mlx5_trigger.c | 3 +++ drivers/net/mlx5/mlx5_txq.c | 2 -- 3 files changed, 3 insertions(+),

[dpdk-dev] [PATCH 2/5] net/mlx5: free buffers in bulk on Tx completion

2017-06-28 Thread Yongseok Koh
When processing Tx completion, it is more efficient to free buffers in bulk using rte_mempool_put_bulk() if buffers are from a same mempool. Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxtx.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) d

[dpdk-dev] [PATCH 1/5] net/mlx5: change indexing for Tx SW ring

2017-06-28 Thread Yongseok Koh
For Tx SW ring (txq->elts[]), indexes are kept and used in txq->elts_head/tail. Because of this, one entry must always be left unused and it also makes code complex. Changed to store counters instead of indexes in order to make the code simpler and to reduce a few calculations. Signed-off-by: Yong

[dpdk-dev] [PATCH 0/5] net/mlx5: add vectorized Rx/Tx burst for x86

2017-06-28 Thread Yongseok Koh
This is to introduce more efficient Rx/Tx burst functions using SIMD instructions. Currently it is only supported by 64bit x86 having SSE4.1. >From functional perspective, Rx burst function is equivalent to the existing mlx5_rx_burst() except for scatter support, which will be added soon. Tx burst

Re: [dpdk-dev] [PATCH v3] mem: fix malloc_elem resize with padding

2017-06-28 Thread Thomas Monjalon
20/06/2017 12:18, Sergio Gonzalez Monroy: > On 08/06/2017 20:12, Jamie Lavigne wrote: > > Currently when a malloc_elem is split after resizing, any padding > > present in the elem is ignored. This causes the resized elem to be too > > small when padding is present, and user data can overwrite the

Re: [dpdk-dev] [PATCH] crypto/scheduler: remove deprecation functions

2017-06-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Monday, May 29, 2017 1:42 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] crypto/scheduler: remove deprecation > functions > > > > > -Original Messag

[dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support IPSec Multi-buffer lib v0.46

2017-06-28 Thread Pablo de Lara
IPSec Multi-buffer library v0.46 has been released, which includes, among othe features, support for 12-byte IV, for AES-CTR, keeping also the previous 16-byte IV, for backward compatibility reasons. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/aesni_mb.rst | 18 +++

[dpdk-dev] [PATCH 2/2] test/crypto: add 12-byte IV AES-CTR test cases

2017-06-28 Thread Pablo de Lara
AESNI MB PMD supports now 12-byte IVs, so some tests are added to check that, apart from the ones with 16-byte IVs, as this is still compatible. Signed-off-by: Pablo de Lara --- test/test/test_cryptodev_aes_test_vectors.h | 186 1 file changed, 186 insertions(+) dif

[dpdk-dev] [PATCH 0/2] AES-NI MB PMD: support Multi-buffer library 0.46

2017-06-28 Thread Pablo de Lara
Intel IPSec Multi-buffer library v0.46 has been released, which among other features, adds support for 12-byte IVs for AES Counter mode (AES-CTR), since IPSec requires only 12 bytes from the user, which are appended 4 extra bytes, set to 1 always. There are no major changes made in the PMD, just d

[dpdk-dev] [PATCH v2 3/4] test/crypto: add AES GCM 192 tests

2017-06-28 Thread Pablo de Lara
Added AES GCM tests for 192-bit keys, now that AES GCM PMD supports it. Signed-off-by: Pablo de Lara --- test/test/test_cryptodev.c | 116 + test/test/test_cryptodev_gcm_test_vectors.h | 357 2 files changed, 473 insertions(+) diff --git a/t

[dpdk-dev] [PATCH v2 4/4] test/crypto: extend AES-GCM 192/256 to other PMDs

2017-06-28 Thread Pablo de Lara
QAT and OpenSSL PMDs support 192-bit and 256-bit key sizes for AES-GCM, apart from 128-bit keys. Therefore, these tests that were only used by AES-NI MB PMD are extended to these other two PMDs. Signed-off-by: Pablo de Lara --- test/test/test_cryptodev.c | 113 +++

[dpdk-dev] [PATCH v2 1/4] crypto/aesni_gcm: migrate to Multi-buffer library

2017-06-28 Thread Pablo de Lara
Since Intel Multi Buffer library for IPSec has been updated to support Scatter Gather List, the AESNI GCM PMD can link to this library, instead of the ISA-L library. This move eases the maintenance of the driver, as it will use the same library as the AESNI MB PMD. It also adds support for 192-bit

[dpdk-dev] [PATCH v2 2/4] test/crypto: rename some tests

2017-06-28 Thread Pablo de Lara
AES-GCM tests are used for AES-NI MB, OpenSSL and QAT PMDs, so they are not specific to the first one. Therefore, _mb_ prefix can be removed. Signed-off-by: Pablo de Lara --- test/test/test_cryptodev.c | 268 ++--- 1 file changed, 134 insertions(+), 134 de

[dpdk-dev] [PATCH v2 0/4] AESNI GCM PMD: Migration from ISA-L to Multi-buffer library

2017-06-28 Thread Pablo de Lara
AES-NI GCM PMD migrated previously from Multi-buffer Crypto library to ISA-L Crypto library, to support several features that were not supported by that time, such as GMAC algorithm and Scatter-gather list. Since version 0.45, Multi-buffer library (https://github.com/01org/intel-ipsec-mb) suppo

Re: [dpdk-dev] [PATCH v4 0/6] Reproducible build

2017-06-28 Thread Luca Boccassi
On Wed, 2017-06-28 at 17:04 +0100, Bruce Richardson wrote: > On Wed, Jun 28, 2017 at 08:57:33AM -0700, Stephen Hemminger wrote: > > On Wed, 28 Jun 2017 14:56:56 +0100 > > wrote: > > > > > From: Luca Boccassi > > > > > > In the past couple of years a concerted effort among almost all > > > Linux

Re: [dpdk-dev] [PATCH] doc: add extended stats to features file

2017-06-28 Thread Ferruh Yigit
On 6/28/2017 6:14 PM, Charles (Chas) Williams wrote: > Update vmxnet3.ini to indicate extended stats support > > Signed-off-by: Chas Williams Squashed into relevant commit in next-net, thanks.

Re: [dpdk-dev] [PATCH] test/crypto: fix overflow

2017-06-28 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, June 28, 2017 10:31 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH] test/crypto: fix overflow > > In one of the SNOW3G unit tests, insufficient memory was allocated, > leading t

Re: [dpdk-dev] [PATCH V2 0/6] some local vmxnet3 patches

2017-06-28 Thread Ferruh Yigit
On 6/28/2017 6:15 PM, Charles (Chas) Williams wrote: > > > On 06/28/2017 08:52 AM, Ferruh Yigit wrote: >> On 6/28/2017 12:30 PM, Ferruh Yigit wrote: >>> On 6/15/2017 1:16 PM, Charles (Chas) Williams wrote: This series addresses some local issues with the vmxnet3 driver that others might

Re: [dpdk-dev] [PATCH v7 1/3] lib: add Generic Receive Offload API framework

2017-06-28 Thread Ananyev, Konstantin
Hi Jiayu, > > > > > > + > > > +/** > > > + * GRO table, which is used to merge packets. It keeps many reassembly > > > + * tables of desired GRO types. Applications need to create GRO tables > > > + * before using rte_gro_reassemble to perform GRO. > > > + */ > > > +struct rte_gro_tbl { > > > +

[dpdk-dev] [PATCH] test/crypto: fix overflow

2017-06-28 Thread Pablo de Lara
In one of the SNOW3G unit tests, insufficient memory was allocated, leading to a buffer overflow. Fixes: 2b52e1e95aab ("app/test: add SNOW 3G UEA2 with offset") CC: sta...@dpdk.org Signed-off-by: Pablo de Lara --- test/test/test_cryptodev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [dpdk-dev] [PATCH V2 0/6] some local vmxnet3 patches

2017-06-28 Thread Charles (Chas) Williams
On 06/28/2017 08:52 AM, Ferruh Yigit wrote: On 6/28/2017 12:30 PM, Ferruh Yigit wrote: On 6/15/2017 1:16 PM, Charles (Chas) Williams wrote: This series addresses some local issues with the vmxnet3 driver that others might find of interest. Changes in v2: - net/vmxnet3: Implement retrieval o

[dpdk-dev] [PATCH] doc: add extended stats to features file

2017-06-28 Thread Charles (Chas) Williams
Update vmxnet3.ini to indicate extended stats support Signed-off-by: Chas Williams --- doc/guides/nics/features/vmxnet3.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/vmxnet3.ini b/doc/guides/nics/features/vmxnet3.ini index 8f7f8e0..4e60183 100644 --- a/doc/gui

Re: [dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions

2017-06-28 Thread Mody, Rasesh
Hi Ferruh, > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, June 28, 2017 9:01 AM > To: Alexey Kardashevskiy ; Mody, Rasesh > ; dev@dpdk.org > Cc: Patil, Harish > Subject: Re: [dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions > > On 4/29/2017 6:12 AM, Alexey Karda

Re: [dpdk-dev] [PATCH v5 5/7] bus: add helper to find a bus from a device name

2017-06-28 Thread Thomas Monjalon
27/06/2017 20:55, Jan Blunck: > On Wed, Jun 21, 2017 at 1:30 AM, Gaetan Rivet wrote: > > /** > > + * Find a bus capable of identifying a device. > > + * > > + * @param str > > + * A device identifier (PCI address, virtual PMD name, ...). > > + * > > + * @return > > + * A valid bus handle if f

Re: [dpdk-dev] [PATCH v4 0/6] Reproducible build

2017-06-28 Thread Bruce Richardson
On Wed, Jun 28, 2017 at 08:57:33AM -0700, Stephen Hemminger wrote: > On Wed, 28 Jun 2017 14:56:56 +0100 > wrote: > > > From: Luca Boccassi > > > > In the past couple of years a concerted effort among almost all Linux > > distros has been striving toward achieving reproducible builds. [1] > > Th

Re: [dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions

2017-06-28 Thread Ferruh Yigit
On 4/29/2017 6:12 AM, Alexey Kardashevskiy wrote: > On 29/04/17 10:31, Mody, Rasesh wrote: >> Hi Alexey, >> >>> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >>> Sent: Wednesday, April 26, 2017 2:18 AM >>> >>> On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote: Recent kernels/distros have u

Re: [dpdk-dev] [PATCH v4 0/6] Reproducible build

2017-06-28 Thread Stephen Hemminger
On Wed, 28 Jun 2017 14:56:56 +0100 wrote: > From: Luca Boccassi > > In the past couple of years a concerted effort among almost all Linux > distros has been striving toward achieving reproducible builds. [1] > This involves changes to the toolchain, new tools and CI systems. [2] > > v1 fixed t

Re: [dpdk-dev] [PATCH] bug: Use correct arguments in run.py

2017-06-28 Thread Wiles, Keith
> On Jun 28, 2017, at 7:54 AM, McCullough, Harrison > wrote: > > When using run.py it would occasionally ignore the given command line > arguments because the wrong variable was used. Fixed this, along with > minor changes to reflect more idiomatic Python usage. Thanks I will integrate these

Re: [dpdk-dev] [PATCH 18/38] doc: add NXP DPAA PMD documentation

2017-06-28 Thread Ferruh Yigit
On 6/16/2017 6:40 AM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain > --- > MAINTAINERS | 2 + > doc/guides/nics/dpaa.rst | 360 > ++ As a reminder, you may need to send a web page patch

Re: [dpdk-dev] [PATCH 38/38] net/dpaa: add packet dump for debugging

2017-06-28 Thread Ferruh Yigit
On 6/16/2017 6:41 AM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain Is there a driver documentation, I haven't see any in net/dpaa patches? <...> > +CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER_DISPLAY=n > +CONFIG_RTE_LIBRTE_DPAA_CHECKING=n This config option is

Re: [dpdk-dev] [PATCH 36/38] net/dpaa: add support for checksum offload

2017-06-28 Thread Ferruh Yigit
On 6/16/2017 6:41 AM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > @@ -363,6 +439,18 @@ dpaa_eth_queue_tx(void *q, struct rte_mbuf **bufs, > uint16_t nb_bufs) > } >

Re: [dpdk-dev] [PATCH 35/38] net/dpaa: add support for packet type parsing

2017-06-28 Thread Ferruh Yigit
On 6/16/2017 6:41 AM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > +static const uint32_t * > +dpaa_supported_ptypes_get(struct rte_eth_dev *dev) > +{ > + static const uint32_t ptypes[] = { > + /*todo -= add more types */ > +

  1   2   >