Re: [dpdk-dev] [PATCH] ethdev: add isolated mode to flow API

2017-05-19 Thread John Daley (johndale)
Hi Adrien, I understand why applications may want to operate in this sort of isolated mode. Just to better understand the value of adding this feature can you contrast it to simply having the application add a very low priority "catch all" flow rule with DROP action? Thanks, Johnd > -Orig

[dpdk-dev] [PATCH 6/6] net/vmxnet3: preserve configured MAC address

2017-05-19 Thread Charles (Chas) Williams
From: George Wilkie When starting a vmxnet3 device, it is always writing the permanent MAC address, even if a different MAC address was configured. Write from the device data instead which holds the current one. Signed-off-by: George Wilkie --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- 1 f

[dpdk-dev] [PATCH 4/6] net/vmxnet3: Make vmxnet3_process_events less noisy

2017-05-19 Thread Charles (Chas) Williams
From: Robert Shearman Make vmxnet3_process_events less noisy by removing logging when there are no events to process and by making link, device-change and debug events DEBUG level rather than ERR. Change these to use PMD_DRV_LOG instead of PMD_INIT_LOG since they don't happen at device init. Si

[dpdk-dev] [PATCH 3/6] net/vmxnet3: Generate link-state change notifications

2017-05-19 Thread Charles (Chas) Williams
From: Robert Shearman Generate link-state change notifications by listening to interrupts generated by the device. Make use of the existing vmxnet3_process_events function that was compiled out, but change it to call vmxnet3_dev_link_update on a VMXNET3_ECR_LINK event and to not be so noisy in it

[dpdk-dev] [PATCH 5/6] net/vmxnet3: receive queue lockup and memleak

2017-05-19 Thread Charles (Chas) Williams
From: Mandeep Rohilla The receive queue can lockup if all the rx descriptors have lost their mbufs and temporarily there are no mbufs available. This can happen if there is an mbuf leak or if the application holds on to the mbuf for a while. This also addresses an mbuf leak in an error condition

[dpdk-dev] [PATCH 2/6] net/vmxnet3: Implement retrieval of extended stats

2017-05-19 Thread Charles (Chas) Williams
From: Robert Shearman Implement xstats_get() to allow a number of driver-specific tx and rx stats to be retrieved. Signed-off-by: Robert Shearman --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 111 +++ 1 file changed, 111 insertions(+) diff --git a/drivers/net/vmxn

[dpdk-dev] [PATCH 1/6] net/vmxnet3: retain counters on restart

2017-05-19 Thread Charles (Chas) Williams
From: Nachiketa Prachanda Most nics like virtio, igb/ixgbe etc. don't reset counters on dev_start and arguably this helps in monitoring the counters across a longer time span with multiple device start/stops. vmxnet3 behavior is opposite to that and counters are reset by the host side implementat

Re: [dpdk-dev] [RFC 2/4] eal: enable experimental dlopen()-based secondary process support

2017-05-19 Thread Stephen Hemminger
On Fri, 19 May 2017 17:39:44 +0100 Anatoly Burakov wrote: > This new forked secondary dlopen()'s the original secondary process > binary and runs main() again. In the meantime, the original secondary > process waits until this new forked secondary dies, and exits. You don't have to use a lock f

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: add traffic management API

2017-05-19 Thread Stephen Hemminger
On Fri, 19 May 2017 18:12:52 +0100 Cristian Dumitrescu wrote: > + > +#define RTE_TM_FUNC(port_id, func) \ > +({ \ > + const struct rte_tm_ops *ops = \ > + rte_tm_ops_get(port_id, error);

[dpdk-dev] [PATCH v4 1/2] ethdev: add traffic management ops get API

2017-05-19 Thread Cristian Dumitrescu
The rte_flow feature breaks the monolithic approach for ethdev by introducing the new rte_flow API to ethdev using a plugin-like approach. Basically, the rte_flow API is still logically part of ethdev: - It extends the ethdev functionality: rte_flow is a new feature/ capability of ethdev; - all

[dpdk-dev] [PATCH v4 0/2] ethdev: abstraction layer for QoS traffic management

2017-05-19 Thread Cristian Dumitrescu
This patch set introduces an ethdev-based abstraction layer for Quality of Service (QoS) Traffic Management, which includes: hierarchical scheduling, traffic shaping, congestion management, packet marking. The goal is to provide a simple generic API that is agnostic of the underlying HW, SW or mixe

[dpdk-dev] [PATCH v4 2/2] ethdev: add traffic management API

2017-05-19 Thread Cristian Dumitrescu
This patch introduces the generic ethdev API for the traffic manager capability, which includes: hierarchical scheduling, traffic shaping, congestion management, packet marking. Main features: - Exposed as ethdev plugin capability (similar to rte_flow) - Capability query API per port, per level an

[dpdk-dev] [RFC 2/4] eal: enable experimental dlopen()-based secondary process support

2017-05-19 Thread Anatoly Burakov
Primary process forks itself into a new process that will be used as basis for forking secondary processes. Secondary process then connects to this forked process over a socket, and triggers a fork. This new forked secondary dlopen()'s the original secondary process binary and runs main() again. I

[dpdk-dev] [RFC 3/4] apps: enable new secondary process support in multiprocess apps

2017-05-19 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- examples/multi_process/client_server_mp/mp_client/Makefile | 2 +- examples/multi_process/simple_mp/Makefile | 2 +- examples/multi_process/symmetric_mp/Makefile | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

[dpdk-dev] [RFC 4/4] mk: default to compiling shared libraries

2017-05-19 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- config/common_base | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common_base b/config/common_base index 8907bea..1c088e9 100644 --- a/config/common_base +++ b/config/common_base @@ -67,7 +67,7 @@ CONFIG_RTE_ARCH_STRICT_ALIGN=n # #

[dpdk-dev] [RFC 1/4] vfio: refactor sockets into separate files

2017-05-19 Thread Anatoly Burakov
Signed-off-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/Makefile | 1 + lib/librte_eal/linuxapp/eal/eal_mp_socket.c| 301 + lib/librte_eal/linuxapp/eal/eal_mp_socket.h| 54 + lib/librte_eal/linuxapp/eal/eal_vfio.c | 20 +- lib/librt

[dpdk-dev] [RFC 0/4] DPDK multiprocess rework

2017-05-19 Thread Anatoly Burakov
This is a proof-of-concept proposal for rework of how DPDK secondary processes work. While the code has some limitations, it works well enough to demonstrate the concept, and it can successfully run all existing multiprocess applications. Current problems with DPDK secondary processes: * ASLR inte

Re: [dpdk-dev] [RFC v2] Flow classification library

2017-05-19 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, May 18, 2017 7:12 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Mcnamara, John > ; Tahhan, Maryam > > Subject: [dpdk-dev] [RFC v2] Flow classification library > > DPDK work

[dpdk-dev] [PATCH v2] ethdev: add flow API rule copy function

2017-05-19 Thread Gaetan Rivet
Take this helper from testpmd app to offer it alongside the flow API. This allows PMDs and applications to save flow rules in their generic format for later processing. This is useful when rules cannot be applied immediately, such as when the device is not properly initialized. Signed-off-by: Gae

[dpdk-dev] [PATCH] ethdev: add flow API rule copy function

2017-05-19 Thread Gaetan Rivet
Take this helper from testpmd app to offer it alongside the flow API. This allows PMDs and applications to save flow rules in their generic format for later processing. This is useful when rules cannot be applied immediately, such as when the device is not properly initialized. Signed-off-by: Gae

[dpdk-dev] [RFC PATCH] LACP control packet filtering offload

2017-05-19 Thread Tomasz Kulasek
This RFC describes a proposal to improve packet processing in bonding mode 4 using hardware offloads. 1. Overview Packet processing in the current path for bonding in mode 4, requires parse all packets in the fast path, to classify and process LACP packets. The idea of performance impro

[dpdk-dev] [PATCH v1 2/4] test: callback process API changes

2017-05-19 Thread Bernard Iremonger
From: "Bernard.Iremonger" Modify the following test code for rte_eth_dev_callback_process API changes: virtual_pmd test_link_bonding Signed-off-by: Bernard.Iremonger --- test/test/test_link_bonding.c | 8 ++-- test/test/virtual_pmd.c | 3 ++- 2 files changed, 8 insertions(+), 3 dele

[dpdk-dev] [PATCH v1 4/4] doc: remove deprecation notice

2017-05-19 Thread Bernard Iremonger
From: "Bernard.Iremonger" Remove deprecation notice for rte_eth_dev_callback_process API changes. Signed-off-by: Bernard.Iremonger --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprec

[dpdk-dev] [PATCH v1 1/4] ethdev: modify callback process API

2017-05-19 Thread Bernard Iremonger
From: "Bernard.Iremonger" Change the rte_eth_dev_callback_process function to return int, and add a void *ret_param parameter. Modify the following PMD's for rte_eth_dev_callback_process API changes: net/bonding net/nfp net/enic net/vhost net/virtio net/thunderx net/e1000: e1000 and igb net/sfc

[dpdk-dev] [PATCH v1 3/4] examples: callback process API changes

2017-05-19 Thread Bernard Iremonger
From: "Bernard.Iremonger" Modify the link_status_interrupt sample application for the rte_eth_dev_callback_process API changes. Signed-off-by: Bernard.Iremonger --- examples/link_status_interrupt/main.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/examples/lin

[dpdk-dev] [PATCH v1 0/4] ethdev: callback process API

2017-05-19 Thread Bernard Iremonger
From: "Bernard.Iremonger" At present the _rte_eth_dev_callback_process function is using the cb_arg parameter to return data to the caller. The cb_arg parameter is an input parameter and should not be used to return data to the caller. In this patchset the return type of _rte_eth_dev_callback_pr

Re: [dpdk-dev] [PATCH] examples/exception_path: add FreeBSD support

2017-05-19 Thread Bruce Richardson
On Fri, May 19, 2017 at 08:13:48AM +0800, Tiwei Bie wrote: > Signed-off-by: Tiwei Bie > --- > examples/exception_path/Makefile | 9 - > examples/exception_path/main.c | 28 +++- > 2 files changed, 27 insertions(+), 10 deletions(-) > Tested compilation with both

Re: [dpdk-dev] [RFC 17.08] flow_classify: add librte_flow_classify library

2017-05-19 Thread Thomas Monjalon
19/05/2017 11:11, Gaëtan Rivet: > On Fri, May 19, 2017 at 08:57:01AM +, Ananyev, Konstantin wrote: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > >> 18/05/2017 13:33, Ferruh Yigit: > >> > On 5/17/2017 5:38 PM, Gaëtan Rivet wrote: > >> > > The other is the expression of flows through a

Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+

2017-05-19 Thread Srinivasan J
Hi Wei, Yes the changes are in ixgbe_dev_start( ), the patch shows the function as eth_ixgbevf_pci_remove() probably due to the way diff recognizes the change. I have tested the change using Intel Corporation 82599ES. Thanks, Srini On Tue, May 16, 2017 at 9:04 AM, Dai, Wei wrote: > Hi

Re: [dpdk-dev] [RFC 17.08] flow_classify: add librte_flow_classify library

2017-05-19 Thread Ananyev, Konstantin
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Friday, May 19, 2017 10:11 AM > To: Ananyev, Konstantin > Cc: Thomas Monjalon ; Yigit, Ferruh > ; dev@dpdk.org; Mcnamara, John > ; Tahhan, Maryam ; > adrien.mazarg...@6wind.com > Subject: Re: [dpdk-dev] [

Re: [dpdk-dev] [RFC 17.08] flow_classify: add librte_flow_classify library

2017-05-19 Thread Gaëtan Rivet
On Fri, May 19, 2017 at 08:57:01AM +, Ananyev, Konstantin wrote: -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Thursday, May 18, 2017 9:32 PM To: Yigit, Ferruh Cc: dev@dpdk.org; Gaëtan Rivet ; Ananyev, Konstantin ; Mcnamara, John ; Tahhan, Maryam ;

Re: [dpdk-dev] [RFC 17.08] flow_classify: add librte_flow_classify library

2017-05-19 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, May 18, 2017 9:32 PM > To: Yigit, Ferruh > Cc: dev@dpdk.org; Gaëtan Rivet ; Ananyev, Konstantin > ; Mcnamara, John > ; Tahhan, Maryam ; > adrien.mazarg...@6wind.com > Subject: Re: [dpdk-dev] [RF

Re: [dpdk-dev] [PATCH] ethdev: add isolated mode to flow API

2017-05-19 Thread Adrien Mazarguil
Re-sending this due to the lack of feedback. Anyone? On Thu, Mar 30, 2017 at 11:08:16AM +0200, Adrien Mazarguil wrote: > Isolated mode can be requested by applications on individual ports to avoid > ingress traffic outside of the flow rules they define. > > Besides making ingress more determinist