Re: [dpdk-dev] [PATCH v2] app/testpmd: support non contiguous socket ids

2017-05-05 Thread Wu, Jingjing
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Wednesday, May 3, 2017 9:44 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; tho...@monjalon.net; sta...@dpdk.org > Subject: [PATCH v2] app/testpmd: support non contiguous socket ids > > The test assumes the socke

[dpdk-dev] [PATCH] net/mlx5: fix erroneous index handling for Tx ring

2017-05-05 Thread Yongseok Koh
In case of resource deficiency on Tx, mlx5_tx_burst() breaks the loop without rolling back consumed resources (txq->wqes[] and txq->elts[]). This can make application crash because unposted mbufs can be freed while processing completions. In regard to this, some error-prone/redundant indexing has b

Re: [dpdk-dev] [PATCH v2] app/testpmd: disable latency stats by default

2017-05-05 Thread Wu, Jingjing
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Friday, May 5, 2017 12:29 AM > To: Wu, Jingjing ; Pattan, Reshma > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2] app/testpmd: disable latency stats by default > > Disable latency stats gathering by default, so

Re: [dpdk-dev] [PATCH] app/testpmd: fix compilation when bitrate lib is disabled

2017-05-05 Thread Wu, Jingjing
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, May 3, 2017 3:02 PM > To: Wu, Jingjing ; Horton, Remy > > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] app/testpmd: fix compilation when bitrate lib is disabled > > Fixes: e25e6c70fb56 ("app/testpmd: ad

Re: [dpdk-dev] [PATCH v3] app/testpmd: configure event display

2017-05-05 Thread Wu, Jingjing
> -Original Message- > From: Gaetan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Tuesday, May 2, 2017 5:54 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Lu, Wenzhuo > Subject: [PATCH v3] app/testpmd: configure event display > > Add two parameters to testpmd: > > --print-event > --ma

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix port_numa and ring_numa not initialize issue

2017-05-05 Thread Wu, Jingjing
> -Original Message- > From: Pei, Yulong > Sent: Wednesday, May 3, 2017 6:30 PM > To: dev@dpdk.org > Cc: Wu, Jingjing ; tho...@monjalon.net > Subject: [PATCH v5] app/testpmd: fix port_numa and ring_numa not initialize > issue > > Previous numa_support = 0 by default, it need to add --num

Re: [dpdk-dev] [PATCH] eventdev: abstract ethdev HW capability to inject packets

2017-05-05 Thread Eads, Gage
Hi Jerin, > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Friday, May 5, 2017 8:34 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Richardson, Bruce ; > Van Haaren, Harry ; hemant.agra...@nxp.com; > Eads, Gage ; nipun.gu...@nxp.com; Vangati,

Re: [dpdk-dev] custom align for mempool elements

2017-05-05 Thread Gregory Etelson
Hello Oliver, Our application writes data from incoming MBUFs to storage device. For performance considerations we use O_DIRECT storage access and work in 'zero copy' data mode. To achieve the 'zero copy' we MUST arrange data in all MBUFs to be 512 bytes aligned With pre-calculated custom pool ele

Re: [dpdk-dev] [PATCH 00/10] Enable DPDK core build with gcc 7

2017-05-05 Thread Thomas Monjalon
04/05/2017 17:38, Bruce Richardson: > Since GCC 7 is now yesterday's news :-), I figured we should try and make > DPDK compile successfully with that new version. The main difficulties are > because of new warnings being triggered. > > * New warnings for fall-though in case statements > * New warn

Re: [dpdk-dev] [PATCH] doc: factorize overview table CSS

2017-05-05 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, May 4, 2017 10:56 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] doc: factorize overview table CSS > > There were several tables in NIC and crypto guides with the same copy-

Re: [dpdk-dev] [PATCH] doc: add known issue about l3fwd-power

2017-05-05 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Friday, May 5, 2017 6:17 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Yang, Qiming > > Subject: [dpdk-dev] [PATCH] doc: add known issue about l3fwd-power > > Because of UIO only suppor

Re: [dpdk-dev] [PATCH v1] doc: Merge l3fwd and l3fwd-acl documentation files

2017-05-05 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kerur > Sent: Tuesday, April 25, 2017 7:39 PM > To: dev@dpdk.org; Ananyev, Konstantin > Cc: Ravi Kerur > Subject: [dpdk-dev] [PATCH v1] doc: Merge l3fwd and l3fwd-acl > documentation files > > Merge releva

[dpdk-dev] [PATCH] eal/linux: fix phys addresses not avaialbe for Xen dom0

2017-05-05 Thread Jianfeng Tan
When physical NICs are binded to igb_uio/uio-pci-generic, they cannot be used in DPDK app in Xen dom0. Due to (1) a restriction that phys addresses should be availabe is added by commit cdc242f260e7 ("eal/linux: support running as unprivileged user"), (2) and previous implementation of the test to

Re: [dpdk-dev] [PATCH] net/af_packet: prefer snprintf against strncpy

2017-05-05 Thread Thomas Monjalon
04/05/2017 13:16, Ferruh Yigit: > strncpy may left destination buffer not NULL terminated, switched using > snprintf to be sure destination buffer is NULL terminated. > > Coverity issue: 1407495 > Coverity issue: 1407498 > Fixes: cc68ac4847bc ("net/af_packet: support MTU change") > Fixes: 21825959

Re: [dpdk-dev] [PATCH] net/mlx5: fix crash on deleting flow drop queue

2017-05-05 Thread Thomas Monjalon
02/05/2017 08:45, Nélio Laranjeiro: > On Mon, May 01, 2017 at 02:05:42PM -0700, Yongseok Koh wrote: > > If mlx5_dev_start() fails, it tries to rollback data structures related to > > rte_flow including drop queue. The destruction code doesn't assume the > > structures are created but priv_flow_dele

Re: [dpdk-dev] [RFC] service core concept header implementation

2017-05-05 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Hi Harry, > > > > Overall it looks good. Some initial comments Off to a good start! Replies inline, in general I think we're on the same page. This RFC was pretty "fresh", mostly to check if the community agrees with the general c

Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx max inline with TSO

2017-05-05 Thread Thomas Monjalon
03/05/2017 08:59, Nélio Laranjeiro: > On Wed, May 03, 2017 at 09:55:35AM +0300, Shahaf Shuler wrote: > > When TSO is enabled, Verbs layer aggregates the TSO > > inline size with the txq inline size for the Tx creation, > > while the PMD takes the maximum among them. > > > > Fixing it by adjusting

Re: [dpdk-dev] [RFC] cryptodev: remove crypto device type enumeration

2017-05-05 Thread Declan Doherty
On 05/05/2017 12:07 PM, Slawomir Mrozowicz wrote: This RFC changes device type identification to be based on a unique driver id replacing the current device type enumeration, which needed library changes every time a new crypto driver was added. The driver id is assigned dynamically during drive

Re: [dpdk-dev] [PATCH 0/3] fix memory overflow for 32 bit vPMD

2017-05-05 Thread Thomas Monjalon
30/04/2017 07:26, Qi Zhang: > The return mbuf points of RX path is possible be modified out of bound > with 32 bit vPMD. > The patch set fix for related drivers. > > Qi Zhang (3): > net/i40e: fix memory overflow for 32 bit vPMD > net/ixgbe: fix memory overflow for 32 bit vPMD > net/fm10k: f

Re: [dpdk-dev] [PATCH] doc: announce crypto structures rework

2017-05-05 Thread Declan Doherty
On 28/04/2017 7:06 PM, De Lara Guarch, Pablo wrote: The current crypto operation and symmetric crypto operation structures will be reworked for correctness and improvement, reducing also their sizes, to fit into less cache lines, as stated in the following RFC: http://dpdk.org/dev/patchwork/patc

Re: [dpdk-dev] [PATCH] doc: announce API changes in crypto library

2017-05-05 Thread Declan Doherty
On 04/05/2017 4:37 PM, Tomasz Kulasek wrote: API changes are planned for 17.08 to made sessions agnostic to the underlaying devices, removing coupling with crypto PMDs, so a single session can be used on multiple devices. It requires to change "struct rte_cryptodev_sym_session" to store more tha

Re: [dpdk-dev] [PATCH] doc: announce public crypto PMD names removal

2017-05-05 Thread Declan Doherty
On 04/05/2017 7:22 AM, Mrozowicz, SlawomirX wrote: The following PMD names definitions will be moved to the individual PMDs to remove the coupling between crypto PMDs and the librte_cryptodev: CRYPTODEV_NAME_NULL_PMD CRYPTODEV_NAME_AESNI_MB_PMD CRYPTODEV_NAME_AESNI_GCM_PMD CRYPTODEV_NAME_OPENSSL_

Re: [dpdk-dev] [PATCH v2] net/i40e: consider QinQ when setting MTU

2017-05-05 Thread Thomas Monjalon
02/05/2017 03:51, Wenzhuo Lu: > When counting max packet length from MTU, count > VLAN tag length twice for QinQ packets. > > Signed-off-by: Wenzhuo Lu > Acked-by: Jingjing Wu Applied, thanks

Re: [dpdk-dev] [PATCH] net/i40e: add check for ethertype filter

2017-05-05 Thread Thomas Monjalon
> > LLDP rule is not supported in ethertype filter. > > > > Signed-off-by: Beilei Xing > > Acked-by: Jingjing Wu Applied, thanks

Re: [dpdk-dev] [PATCH] ixgbe: check scatter_enable in set_mtu

2017-05-05 Thread Thomas Monjalon
02/05/2017 02:51, Lu, Wenzhuo: > From: Jia Yu [mailto:j...@vmware.com] > > > > There exists case that software sets mtu (i.e jumbo frame) of ixgbe device > > when it's stopped. Before the fix, scattered_rx is cleared during device > > stop, > > and setting jumbo frame mtu after device stop will a

Re: [dpdk-dev] [PATCH] net/ixgbe: fix VF Rx mode if allmulticast is disabled

2017-05-05 Thread Thomas Monjalon
> > Some customers find that 82599 NIC DPDK VF PMD can't receive any > > broadcast packets when it is bound to igb_uio in the first time to run a > > DPDK > > application like testpmd. But when the application is quited and run again, > > the DPDK VF PMD can receive broadcast packets again. The as

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/e1000: fix VF received problem

2017-05-05 Thread Thomas Monjalon
03/05/2017 09:12, Lu, Wenzhuo: > Hi, > > > VF default MAC address be added in PF Mac address list instead of VF MAC > > address list, makes VF can't receive packets. This patch fixes this issue. > > > > Fixes: be2d648a2dd3 ("igb: add PF support") > > > > Signed-off-by: Qiming Yang > Acked-by: W

[dpdk-dev] [PATCH v1 1/1] app/procinfo: resource leak fix.

2017-05-05 Thread Roman Korynkevych
Coverity issue: 143256 Fixes: 2deb6b5246d7706448d070335b329d1acb754cee ("app/procinfo: add collectd format and host id") Cc: sta...@dpdk.org Signed-off-by: Roman Korynkevych --- app/proc_info/main.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/app/p

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/e1000: fix VF MAC address set problem

2017-05-05 Thread Thomas Monjalon
03/05/2017 09:13, Lu, Wenzhuo: > Hi, > > > We find that VF receive address register is not set if MAC address is > > assigned > > by PF. This patch fixes it. > > > > Fixes: d82170d27918 ("igb: add VF support") > > > > Signed-off-by: Qiming Yang > Acked-by: Wenzhuo Lu Applied, thanks

Re: [dpdk-dev] [PATCH] net/ixgbe: fix default MAC setting

2017-05-05 Thread Thomas Monjalon
02/05/2017 10:34, Wenzhuo Lu: > Pool 0 is not PF, it's VF 0. So the MAC is set for VF 0 > but not PF. > The code introduced a weird issue. In the scenario PF + VF, > when only starting PF, the default PF MAC address is working. > But after starting a VF, the default PF MAC address becomes > the VF'

Re: [dpdk-dev] [PATCH v7 1/3] ethdev: fix adding invalid MAC addr

2017-05-05 Thread Thomas Monjalon
05/05/2017 02:40, Wei Dai: > Some customers find adding MAC addr to VF sometimes can fail, > but it is still stored in dev->data->mac_addrs[ ]. So this > can lead to some errors that assumes the non-zero entry in > dev->data->mac_addrs[ ] is valid. > Following acknowledgements are from specific NIC

Re: [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to add many MAC addrs

2017-05-05 Thread Thomas Monjalon
05/05/2017 02:40, Wei Dai: > This patch is added to introduce a testpmd command which > is used to add more than one MAC addresses one time. > This command can simplify the test for the change where > the type of return value of adding MAC address. > Normally a MAC address may fails to be added onl

Re: [dpdk-dev] [PATCH v7 2/3] doc: change type of return value of adding MAC addr

2017-05-05 Thread Thomas Monjalon
05/05/2017 02:40, Wei Dai: > Add following lines in section of API change in release note. > > If a MAC address fails to be added without this change, it is still > stored and may be regarded as a valid one. This may lead to errors > in application. The type of return value of eth_mac_addr_add_t i

Re: [dpdk-dev] [PATCH v7 1/3] ethdev: fix adding invalid MAC addr

2017-05-05 Thread Thomas Monjalon
05/05/2017 02:40, Wei Dai: > Some customers find adding MAC addr to VF sometimes can fail, > but it is still stored in dev->data->mac_addrs[ ]. So this > can lead to some errors that assumes the non-zero entry in > dev->data->mac_addrs[ ] is valid. > Following acknowledgements are from specific NIC

Re: [dpdk-dev] [PATCH v7 1/3] ethdev: fix adding invalid MAC addr

2017-05-05 Thread Thomas Monjalon
05/05/2017 03:46, Yang, Qiming: > Hi, Dai wei > > > static void > > diff --git a/drivers/net/e1000/igb_ethdev.c > > b/drivers/net/e1000/igb_ethdev.c index b6b81cb..e8c6282 100644 > > --- a/drivers/net/e1000/igb_ethdev.c > > +++ b/drivers/net/e1000/igb_ethdev.c > > @@ -171,9 +171,9 @@ static int e

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net: fix stripped VLAN flag for offload emulation

2017-05-05 Thread Thomas Monjalon
05/05/2017 12:02, Olivier Matz: > Hi Thomas, > > On Fri, 5 May 2017 00:36:13 +0200, Thomas Monjalon > wrote: > > From: Michał Mirosław > > > > Apply the new flag PKT_RX_VLAN_STRIPPED to the software emulation case > > (currently only for virtio and af_packet). > > > > Fixes: b37b528d957c ("m

Re: [dpdk-dev] [PATCH] examples/vhost: fix the use of strnlen()

2017-05-05 Thread Gang Jiang
My name is Gang Jiang. > -原始邮件- > 发件人: "Thomas Monjalon" > 发送时间: 2017-05-05 20:11:35 (星期五) > 收件人: jiangg > 抄送: dev@dpdk.org > 主题: Re: [dpdk-dev] [PATCH] examples/vhost: fix the use of strnlen() > > Hi, > > 16/04/2017 13:39, jiangg: > > The return value of strnlen(s, maxlen) is never b

[dpdk-dev] [RFC PATCH 11/11] add virtio 1.1 test guide

2017-05-05 Thread Jens Freimann
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- README-virtio-1.1 | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 README-virtio-1.1 diff --git a/README-virtio-1.1 b/README-virtio-1.1 new file mode 100644 index 000..8af3eb3 ---

[dpdk-dev] [RFC PATCH 10/11] vhost: prefetch desc

2017-05-05 Thread Jens Freimann
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- lib/librte_vhost/virtio_net.c | 36 +--- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index c9e466f..b4d9031 100644 --- a/lib/librte_v

[dpdk-dev] [RFC PATCH 09/11] xxx: virtio: remove overheads

2017-05-05 Thread Jens Freimann
From: Yuanhan Liu for better performance comparing Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_rxtx.c | 188 +++ 1 file changed, 12 insertions(+), 176 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c

[dpdk-dev] [RFC PATCH 08/11] xxx: batch the desc_hw update?

2017-05-05 Thread Jens Freimann
From: Yuanhan Liu Signed-off-by: Yuanhan Liu Conflicts: lib/librte_vhost/virtio_net.c --- drivers/net/virtio/virtio_rxtx_1.1.c | 18 ++ lib/librte_vhost/virtio_net.c| 17 ++--- 2 files changed, 20 insertions(+), 15 deletions(-) diff --git a/drivers/

[dpdk-dev] [RFC PATCH 07/11] vhost: mark desc being used

2017-05-05 Thread Jens Freimann
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- lib/librte_vhost/virtio_net.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index fd6f200..df88e31 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/libr

[dpdk-dev] [RFC PATCH 06/11] vhost: implement virtio 1.1 dequeue path

2017-05-05 Thread Jens Freimann
From: Yuanhan Liu Build test only; haven't tested it yet Signed-off-by: Yuanhan Liu Signed-off-by: Jens Freimann --- lib/librte_vhost/virtio-1.1.h | 23 ++ lib/librte_vhost/virtio_net.c | 181 ++ 2 files changed, 204 insertions(+) create mode 1006

[dpdk-dev] [RFC PATCH 04/11] vhost: enable 1.1 for testing

2017-05-05 Thread Jens Freimann
From: Yuanhan Liu Just set the features on, no actual work has been done. Just make sure the virtio PMD could have this feature been enabled, for testing only. Signed-off-by: Yuanhan Liu --- lib/librte_vhost/vhost.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_vhost/vhost

[dpdk-dev] [RFC PATCH 05/11] vhost: set desc addr for 1.1

2017-05-05 Thread Jens Freimann
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/vhost_user.c | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h index 208b2eb..f3b7ad5 100644 --- a/lib/librte_vhost/vhost.h +++ b/lib/li

[dpdk-dev] [RFC PATCH 03/11] net/virtio-user: add option to enable 1.1

2017-05-05 Thread Jens Freimann
From: Yuanhan Liu Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 9 - drivers/net/virtio/virtio_user/virtio_user_dev.h | 3 ++- drivers/net/virtio/virtio_user_ethdev.c | 14 +- 3 files changed, 23 insertions(+), 3 deletions(-) d

[dpdk-dev] [RFC PATCH 02/11] net/virtio: implement 1.1 guest Tx

2017-05-05 Thread Jens Freimann
From: Yuanhan Liu build only so far Signed-off-by: Yuanhan Liu --- drivers/net/virtio/Makefile | 1 + drivers/net/virtio/virtio_ethdev.c | 24 -- drivers/net/virtio/virtio_ethdev.h | 3 + drivers/net/virtio/virtio_rxtx.c | 3 + drivers/net/virtio/virtio_rxtx_1.1.c |

[dpdk-dev] [RFC PATCH 01/11] net/virtio: vring init for 1.1

2017-05-05 Thread Jens Freimann
From: Yuanhan Liu Add and initialize descriptor data structures. Signed-off-by: Yuanhan Liu [rename desc_1_1 to vring_desc_1_1, refactor desc init code] Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio-1.1.h| 19 +++ drivers/net/virtio/virtio_ethdev.c | 22 ++

[dpdk-dev] [RFC PATCH 00/11] net/virtio: packed ring layout

2017-05-05 Thread Jens Freimann
Hi Yuanhan, I rebased your patches on next-virtio/for-testing to current master, made sure every patch compiles and still works. I'm implementing the receive path now to eventually get some benchmark results for that as well (Patches not included yet) Any comments to the existing patches are wel

Re: [dpdk-dev] [PATCH] kni: fix unit test segfault

2017-05-05 Thread Thomas Monjalon
03/05/2017 18:10, Ferruh Yigit: > To clean alloc_q, which has physicall addresses of the mbufs, kni lib > free the pkt_mempool, but this leads a crash in kni unit test. > > KNI library shouldn't free the pkt_mempool. > > Implementation updated to find the mbufs in the alloc_q and return them > ba

Re: [dpdk-dev] [PATCH] mbuf: rte_pktmbuf_alloc_bulk bugfix

2017-05-05 Thread Olivier Matz
Hi Gregory, On Fri, 05 May 2017 16:29:59 +0300, Gregory Etelson wrote: > bugfix in rte_pktmbuf_alloc_bulk > > Signed-off-by: Gregory Etelson Thank you for the fix. I suggest the following title instead: mbuf: fix bulk allocation when debug enabled Please refer to the guidelines: http://dpdk.

Re: [dpdk-dev] [PATCH] kni: fix ethtool build with kernel 4.11

2017-05-05 Thread Thomas Monjalon
03/05/2017 19:06, Nicolas Dichtel: > Le 03/05/2017 à 18:43, Ferruh Yigit a écrit : > > On 5/3/2017 5:39 PM, Nicolas Dichtel wrote: > >> Le 03/05/2017 à 18:00, Ferruh Yigit a écrit : > >>> build error: > >>> .../build/build/lib/librte_eal/linuxapp/kni/igb_main.c:1034:10: > >>> error: implicit declar

[dpdk-dev] [PATCH] eventdev: abstract ethdev HW capability to inject packets

2017-05-05 Thread Jerin Jacob
Some Ethdev Hardware is capable of injecting the events(Ethernet packets) to eventdev without the need for dedicated service cores on Rx path. Since eventdev API is device capability agnostic, we need to address three combinations of ethdev and eventdev PMD drivers. 1) Ethdev HW is not capable of

[dpdk-dev] [PATCH] mbuf: rte_pktmbuf_alloc_bulk bugfix

2017-05-05 Thread Gregory Etelson
bugfix in rte_pktmbuf_alloc_bulk Signed-off-by: Gregory Etelson --- lib/librte_mbuf/rte_mbuf.h | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 466ec00..bebe94f 100644 --- a/lib/librte_mbu

Re: [dpdk-dev] [PATCH v2] eal: optimize timer routines

2017-05-05 Thread Thomas Monjalon
02/05/2017 07:19, Jerin Jacob: > Since DPDK has only two timer sources, > Avoid &eal_timer_source memory read and followed > by the switch case statement when > RTE_LIBEAL_USE_HPET is not defined. > > Signed-off-by: Jerin Jacob It is not a fix but it is simple and safe enough to be in 17.05-rc4.

Re: [dpdk-dev] [PATCH v3 0/2] add a macro to disable support of backtrace

2017-05-05 Thread Thomas Monjalon
05/05/2017 15:18, Thomas Monjalon: > Some LIBC implementation like musl doesn't support backtrace() > and backtrace_symbols() declared in execinfo.h. > Currently some DPDK customers fail to build DPDK with musl. > In order to build DPDK with musl, there is a need to > remove references to execinfo.

[dpdk-dev] [PATCH v3 0/2] add a macro to disable support of backtrace

2017-05-05 Thread Thomas Monjalon
Some LIBC implementation like musl doesn't support backtrace() and backtrace_symbols() declared in execinfo.h. Currently some DPDK customers fail to build DPDK with musl. In order to build DPDK with musl, there is a need to remove references to execinfo.h. Add a configuration parameter which defau

[dpdk-dev] [PATCH v3 2/2] config: make backtrace optional

2017-05-05 Thread Thomas Monjalon
From: Wei Dai When building DPDK with musl, there is need not to disable backtrace to remove some references to execinfo.h which is not supported by musl now. This also applies to some other libc implementation which doesn't support backtrace() and backtrace_symbols(). musl is an implementation

[dpdk-dev] [PATCH v3 1/2] examples/performance-thread: remove useless include

2017-05-05 Thread Thomas Monjalon
From: Wei Dai There is no function to refer any part of execinfo.h, so remove the reference to it. And there is no this file in musl. So need to remove it to support musl. Signed-off-by: Wei Dai --- examples/performance-thread/common/lthread_tls.c | 1 - 1 file changed, 1 deletion(-) diff --g

Re: [dpdk-dev] [RFC PATCH 5/5] kni: support multiple userspace process working with kni module

2017-05-05 Thread Ferruh Yigit
On 5/3/2017 12:21 PM, Hemant Agrawal wrote: > in case of multiple application using the same KNI module, > protect that one application will only clean it's own devices. Idea looks OK, but there is already a check in the module that prevents /dev/kni opened by more than one process [1], did you al

Re: [dpdk-dev] Occasional instability in RSS Hashes/Queues from X540 NIC

2017-05-05 Thread Matt Laswell
On Thu, May 4, 2017 at 1:15 PM, Matt Laswell wrote: > Hey Keith, > > Here is a hexdump of a subset of one of my packet captures. In this > capture, all of the packets are part of the same TCP connection, which > happens to be NFSv3 traffic. All of them except packet number 6 get the > correct RS

Re: [dpdk-dev] [PATCH 0/2] prepare function names for bus move

2017-05-05 Thread Thomas Monjalon
04/05/2017 18:40, Stephen Hemminger: > On Thu, 4 May 2017 18:18:49 +0200 > Thomas Monjalon wrote: > > > It is planned to move the bus PCI and VDEV to /drivers/bus/ > > during 17.08. So the eal_ prefix will not make sense. > > Let's rename now before releasing 17.05 where EAL API has > > already

Re: [dpdk-dev] [PATCH] eal: remove forward declaration of generic driver

2017-05-05 Thread Thomas Monjalon
04/05/2017 17:46, Thomas Monjalon: > We can just move rte_driver definition before rte_device > (which depends on rte_driver). > > Signed-off-by: Thomas Monjalon Applied

Re: [dpdk-dev] [PATCH 01/10] mk: adjust gcc flags for new gcc 7 warnings

2017-05-05 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, May 5, 2017 11:03 AM > To: dev@dpdk.org; Richardson, Bruce ; Stephen > Hemminger > > Subject: Re: [dpdk-dev] [PATCH 01/10] mk: adjust gcc flags for new gcc 7 > warnings > > In this series, there are some fixe

Re: [dpdk-dev] [PATCH] examples/vhost: fix the use of strnlen()

2017-05-05 Thread Thomas Monjalon
Hi, 16/04/2017 13:39, jiangg: > The return value of strnlen(s, maxlen) is never bigger than maxlen. > > Signed-off-by: jiangg Please, could you provide your full name in SoB? We could also add a Fixes: line. Thanks

Re: [dpdk-dev] [RFC PATCH 4/5] kni: add support to get gso_size info

2017-05-05 Thread Ferruh Yigit
On 5/3/2017 12:21 PM, Hemant Agrawal wrote: > Inform userspace about gso size info > > Signed-off-by: Hemant Agrawal > --- > lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h | 3 ++- > lib/librte_eal/linuxapp/kni/kni_net.c | 1 + > 2 files changed, 3 insertio

[dpdk-dev] [PATCH] doc: announce crypto device type enumeration removal

2017-05-05 Thread Slawomir Mrozowicz
Refer to RFC patch - cryptodev: remove crypto device type enumeration It is planned to remove device type enumeration rte_cryptodev_type from library to remove the coupling between crypto PMD and the librte_cryptodev. In this case following stuctures will be changed: rte_cryptodev_session, rte_cr

Re: [dpdk-dev] [RFC PATCH 1/5] kni: change and configure mac address

2017-05-05 Thread Ferruh Yigit
On 5/3/2017 12:21 PM, Hemant Agrawal wrote: > This patch adds following: > 1. option to configure the mac address during create > 2. inform usespace, if mac address is being changed in linux > > Signed-off-by: Hemant Agrawal > --- > .../linuxapp/eal/include/exec-env/rte_kni_common.h| 3

Re: [dpdk-dev] custom align for mempool elements

2017-05-05 Thread Olivier Matz
Hi Gregory, On Wed, 26 Apr 2017 07:00:49 +0300, Gregory Etelson wrote: > Signed-off-by: Gregory Etelson > --- > lib/librte_mempool/rte_mempool.c | 27 --- > lib/librte_mempool/rte_mempool.h | 1 + > 2 files changed, 21 insertions(+), 7 deletions(-) > > diff --git a/lib

[dpdk-dev] [RFC] cryptodev: remove crypto device type enumeration

2017-05-05 Thread Slawomir Mrozowicz
This RFC changes device type identification to be based on a unique driver id replacing the current device type enumeration, which needed library changes every time a new crypto driver was added. The driver id is assigned dynamically during driver registration using the new macro RTE_PMD_REGISTER_

Re: [dpdk-dev] [PATCH 01/10] mk: adjust gcc flags for new gcc 7 warnings

2017-05-05 Thread Bruce Richardson
On Fri, May 05, 2017 at 12:02:44PM +0200, Thomas Monjalon wrote: > In this series, there are some fixes for fall-through comments, > missing break and missing initializers. > I think there is no discussion about accepting them in 17.05. > The last item to discuss it the new snprintf warning: > > 0

Re: [dpdk-dev] [PATCH 01/10] mk: adjust gcc flags for new gcc 7 warnings

2017-05-05 Thread Thomas Monjalon
In this series, there are some fixes for fall-through comments, missing break and missing initializers. I think there is no discussion about accepting them in 17.05. The last item to discuss it the new snprintf warning: 05/05/2017 11:42, Bruce Richardson: > On Thu, May 04, 2017 at 09:38:08AM -0700

Re: [dpdk-dev] [PATCH v2] net: fix stripped VLAN flag for offload emulation

2017-05-05 Thread Olivier Matz
Hi Thomas, On Fri, 5 May 2017 00:36:13 +0200, Thomas Monjalon wrote: > From: Michał Mirosław > > Apply the new flag PKT_RX_VLAN_STRIPPED to the software emulation case > (currently only for virtio and af_packet). > > Fixes: b37b528d957c ("mbuf: add new Rx flags for stripped VLAN") > Cc: sta..

Re: [dpdk-dev] [PATCH 2/2] doc: update mlx4 supported OFED and FW

2017-05-05 Thread Adrien Mazarguil
On Wed, May 03, 2017 at 10:28:49AM +0300, Shahaf Shuler wrote: > Update the supported Mellanox OFED and FW versions. > > Signed-off-by: Shahaf Shuler Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND

Re: [dpdk-dev] [PATCH 1/2] doc: update mlx5 supported OFED and FW

2017-05-05 Thread Adrien Mazarguil
On Wed, May 03, 2017 at 10:28:48AM +0300, Shahaf Shuler wrote: > Update the supported Mellanox OFED and FW versions. > > Signed-off-by: Shahaf Shuler Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND

Re: [dpdk-dev] [PATCH] drivers/net: add generic ethdev macro to get PCI device

2017-05-05 Thread Ferruh Yigit
On 5/5/2017 1:44 AM, Lu, Wenzhuo wrote: > Hi, > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Thursday, May 4, 2017 9:08 PM >> To: Thomas Monjalon; Shepard Siegel; Ed Czeck; John Miller; Legacy, Allain >> (Wind River); Peters, Matt (Wind River); Lu, Wenzhuo; Zhang, Helin; Wu, >> Ji

Re: [dpdk-dev] [PATCH 01/10] mk: adjust gcc flags for new gcc 7 warnings

2017-05-05 Thread Bruce Richardson
On Thu, May 04, 2017 at 09:38:08AM -0700, Stephen Hemminger wrote: > On Thu, 4 May 2017 16:38:13 +0100 > Bruce Richardson wrote: > > > There are two new warnings in GCC 7 that cause problems in the DPDK > > compile. > > > > 1. GCC now warns if you have a switch fall-through without a suitable >

Re: [dpdk-dev] [PATCH 07/10] net: fix missing break inside conditional compile block

2017-05-05 Thread Singh, Jasvinder
-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson Sent: Thursday, May 4, 2017 4:38 PM To: dev@dpdk.org Cc: Richardson, Bruce Subject: [dpdk-dev] [PATCH 07/10] net: fix missing break inside conditional compile block The #ifdef only had the break in

Re: [dpdk-dev] Proposal - ARM Support for Arkville PMD in DPDK 17.08

2017-05-05 Thread Ferruh Yigit
On 5/4/2017 7:05 PM, Shepard Siegel wrote: > This email is notification ahead of the May 28 proposal deadline for 17.08 > that Atomic Rules proposes to implement, test and support our Arkville > net/ark PMD for ARM architecture in the DPDK 17.08 release. Our intent is > for ARM architecture support